[libcxx] r321717 - Creating release_60 branch off revision 321711

Author: hans Date: Wed Jan 3 06:54:46 2018 New Revision: 321717 URL: http://llvm.org/viewvc/llvm-project?rev=321717=rev Log: Creating release_60 branch off revision 321711 Added: libcxx/branches/release_60/ (props changed) - copied from r321711, libcxx/trunk/ Propchange:

[libcxxabi] r321718 - Creating release_60 branch off revision 321711

Author: hans Date: Wed Jan 3 06:54:46 2018 New Revision: 321718 URL: http://llvm.org/viewvc/llvm-project?rev=321718=rev Log: Creating release_60 branch off revision 321711 Added: libcxxabi/branches/release_60/ - copied from r321711, libcxxabi/trunk/

[PATCH] D39457: [OPENMP] Current status of OpenMP support.

hfinkel added a comment. In https://reviews.llvm.org/D39457#961824, @Hahnfeld wrote: > @hfinkel I think you requested this documentation on the mailing list. Can > you take a look if it matches your expectations so we can get this bundled in > the 6.0 release? Yes, this looks good. Thank

r321705 - UserManual: Update with the latest clang-cl flags

Author: hans Date: Wed Jan 3 05:20:25 2018 New Revision: 321705 URL: http://llvm.org/viewvc/llvm-project?rev=321705=rev Log: UserManual: Update with the latest clang-cl flags Modified: cfe/trunk/docs/UsersManual.rst Modified: cfe/trunk/docs/UsersManual.rst URL:

[PATCH] D41486: [OpenMP][Clang] Add missing argument to runtime functions.

gtbercea abandoned this revision. gtbercea added a comment. Functionality already landed. See previous comment. Repository: rL LLVM https://reviews.llvm.org/D41486 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D41661: [clangd] Don't navigate to forward class declaration when go to definition.

hokein updated this revision to Diff 128516. hokein added a comment. Use getDefinition to simply the code. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D41661 Files: clangd/XRefs.cpp unittests/clangd/XRefsTests.cpp Index: unittests/clangd/XRefsTests.cpp

Re: r321697 - [libclang] Support querying whether a declaration is invalid

I don't, but reverting your change made the test pass again. I was able to reproduce locally by adding -target ppc64le-unknown-linux to the run-line in test/Index/opencl-types.cl. On Wed, Jan 3, 2018 at 3:23 PM, Ivan Donchevskii wrote: > Hi! > I saw it but I don't see an

Re: r321697 - [libclang] Support querying whether a declaration is invalid

Ok, I've asked Nikolai to recheck it on Linux and re-commited the rolled back change which is not connected with the failing one. From: hwennb...@google.com on behalf of Hans Wennborg Sent: Wednesday, January 3, 2018

[PATCH] D39050: Add index-while-building support to Clang

ioeric requested changes to this revision. ioeric added a comment. This revision now requires changes to proceed. (I think I forgot to update the patch status :) https://reviews.llvm.org/D39050 ___ cfe-commits mailing list

Re: r321697 - [libclang] Support querying whether a declaration is invalid

This caused failures on the buildbots. I've reverted it and the commits that depended on it in r321708. See that commit message for more details. On Wed, Jan 3, 2018 at 10:49 AM, Ivan Donchevskii via cfe-commits wrote: > Author: yvvan > Date: Wed Jan 3 01:49:31 2018

Re: [clang-tools-extra] r321363 - [clang-tidy] Adding Fuchsia checker for overloaded operators

There was a recent bug report related to this check. Could you take a look? http://llvm.org/PR35803 On Fri, Dec 22, 2017 at 5:52 PM, Julie Hockett via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: juliehockett > Date: Fri Dec 22 08:52:25 2017 > New Revision: 321363 > > URL:

[libunwind] r321724 - Creating release_60 branch off revision 321711

Author: hans Date: Wed Jan 3 06:54:55 2018 New Revision: 321724 URL: http://llvm.org/viewvc/llvm-project?rev=321724=rev Log: Creating release_60 branch off revision 321711 Added: libunwind/branches/release_60/ - copied from r321711, libunwind/trunk/

[PATCH] D41711: [docs] Mention support for Windows/ARM64 in the release notes

This revision was automatically updated to reflect the committed changes. Closed by commit rL321788: [docs] Mention support for Windows/ARM64 in the release notes (authored by mstorsjo, committed by ). Changed prior to commit: https://reviews.llvm.org/D41711?vs=128555=128596#toc Repository:

[PATCH] D41668: [clangd] Add static index for the global code completion.

ioeric added inline comments. Comment at: clangd/ClangdLSPServer.h:40 + bool BuildDynamicSymbolIndex, + std::unique_ptr GlobalIdx); We are calling this global index and static index in the patch. I think we should be

[PATCH] D41668: [clangd] Add static index for the global code completion.

ioeric added a comment. You have mentioned that YAML data source is experimental only in the patch summary, but we should also mention this in the code. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D41668 ___ cfe-commits mailing

[PATCH] D41005: Reuse preamble even if an unsaved file does not exist

yvvan added a comment. No regression in tests on Windows with and without extra patch ([PATCH] Use file path instead of uniqueID) Repository: rC Clang https://reviews.llvm.org/D41005 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D41512: [Sema] -Wtautological-constant-compare is too good. Cripple it.

This revision was automatically updated to reflect the committed changes. Closed by commit rL321691: [Sema] -Wtautological-constant-compare is too good. Cripple it. (authored by lebedevri, committed by ). Changed prior to commit: https://reviews.llvm.org/D41512?vs=128470=128494#toc

r321691 - [Sema] -Wtautological-constant-compare is too good. Cripple it.

Author: lebedevri Date: Wed Jan 3 00:45:19 2018 New Revision: 321691 URL: http://llvm.org/viewvc/llvm-project?rev=321691=rev Log: [Sema] -Wtautological-constant-compare is too good. Cripple it. Summary: The diagnostic was mostly introduced in D38101 by me, as a reaction to wasting a lot of

r321695 - [libclang] Add clang_getFileContents to libclang.exports

Author: yvvan Date: Wed Jan 3 01:17:08 2018 New Revision: 321695 URL: http://llvm.org/viewvc/llvm-project?rev=321695=rev Log: [libclang] Add clang_getFileContents to libclang.exports This is the follow up patch for rL319881 which introduced the function but did not put it into .exports file.

r321697 - [libclang] Support querying whether a declaration is invalid

Author: yvvan Date: Wed Jan 3 01:49:31 2018 New Revision: 321697 URL: http://llvm.org/viewvc/llvm-project?rev=321697=rev Log: [libclang] Support querying whether a declaration is invalid This is useful for e.g. highlighting purposes in an IDE. Patch by Nikolai Kosjar. Differential Revision:

[PATCH] D40072: [libclang] Support querying whether a declaration is invalid

This revision was automatically updated to reflect the committed changes. Closed by commit rC321697: [libclang] Support querying whether a declaration is invalid (authored by yvvan, committed by ). Changed prior to commit: https://reviews.llvm.org/D40072?vs=128491=128497#toc Repository: rC

[PATCH] D40561: [libclang] Fix cursors for functions with trailing return type

This revision was automatically updated to reflect the committed changes. Closed by commit rC321698: [libclang] Fix cursors for functions with trailing return type (authored by yvvan, committed by ). Changed prior to commit: https://reviews.llvm.org/D40561?vs=124576=128499#toc Repository:

r321698 - [libclang] Fix cursors for functions with trailing return type

Author: yvvan Date: Wed Jan 3 02:04:37 2018 New Revision: 321698 URL: http://llvm.org/viewvc/llvm-project?rev=321698=rev Log: [libclang] Fix cursors for functions with trailing return type For the function declaration auto foo5(Foo) -> Foo; the parameter tokens were mapped to cursors

[PATCH] D41661: [clangd] Don't navigate to forward class declaration when go to definition.

hokein added a comment. With more test, it turns out that `ASTNode.OrigD` is not always pointed to the definition, so we can't rely on `D` or `ASTNode.OrigD` :(. I revised the way of checking definition, it should works for major cases. Please review it again. Repository: rCTE Clang Tools

[PATCH] D41661: [clangd] Don't navigate to forward class declaration when go to definition.

hokein updated this revision to Diff 128501. hokein marked an inline comment as done. hokein added a comment. - Revise the way of checking definition. - Add a test for function declaration. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D41661 Files: clangd/XRefs.cpp

[PATCH] D41005: Reuse preamble even if an unsaved file does not exist

ilya-biryukov added inline comments. Comment at: include/clang/Frontend/ASTUnit.h:193 /// some number of calls. - unsigned PreambleRebuildCounter; + unsigned PreambleRebuildCountdownCounter; + NIT: Maybe shorten to `PreambleRebuildCountdown`? It's not a

r321700 - Fix line endings.

Author: yvvan Date: Wed Jan 3 02:33:21 2018 New Revision: 321700 URL: http://llvm.org/viewvc/llvm-project?rev=321700=rev Log: Fix line endings. Modified: cfe/trunk/test/Index/annotate-tokens.cpp cfe/trunk/test/Index/print-type-size.cpp cfe/trunk/tools/c-index-test/c-index-test.c

[PATCH] D41661: [clangd] Don't navigate to forward class declaration when go to definition.

ilya-biryukov added inline comments. Comment at: clangd/XRefs.cpp:68 + // declaration, and it could be a forward declaration. + auto Def = std::find_if(D->redecls_begin(), D->redecls_end(), + [](const Decl *D) { return IsDefinition(D); });

r321701 - Fix more line endings.

Author: yvvan Date: Wed Jan 3 02:40:11 2018 New Revision: 321701 URL: http://llvm.org/viewvc/llvm-project?rev=321701=rev Log: Fix more line endings. Modified: cfe/trunk/include/clang-c/Index.h Modified: cfe/trunk/include/clang-c/Index.h URL:

[PATCH] D41668: [clangd] Add static index for the global code completion.

ilya-biryukov added inline comments. Comment at: clangd/tool/ClangdMain.cpp:122 +llvm::cl::desc( +"YAML-format global symbol file to build the static index. It is only " +"available when 'enable-index-based-completion' is enabled."), Let's

[PATCH] D41345: [clangd] Add more symbol information for code completion.

ioeric updated this revision to Diff 128505. ioeric added a comment. - Merge with origin/master. Use Arena for symbol details. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D41345 Files: clangd/ClangdUnit.cpp clangd/ClangdUnit.h clangd/CodeComplete.cpp

[PATCH] D41537: Optionally add code completion results for arrow instead of dot

yvvan updated this revision to Diff 128509. yvvan added a comment. Update CIndex minor version, add call to libclang.exports https://reviews.llvm.org/D41537 Files: include/clang-c/Index.h include/clang/Sema/CodeCompleteConsumer.h include/clang/Sema/CodeCompleteOptions.h

[PATCH] D41698: [DebugInfo] Enable debug information for C99 VLA types

sdesmalen created this revision. sdesmalen added reviewers: echristo, aprantl, dexonsmith, clayborg, pcc, kristof.beyls. Herald added a subscriber: JDevlieghere. This patch enables debugging of C99 VLA types by generating more precise LLVM Debug metadata, using the extended DISubrange 'count'

[PATCH] D41345: [clangd] Add more symbol information for code completion.

ioeric added inline comments. Comment at: clangd/index/Index.h:122 + + llvm::Optional Detail; + sammccall wrote: > ioeric wrote: > > sammccall wrote: > > > I think you probably want a raw pointer rather than optional: > > > - reduce the size of the struct when

[PATCH] D41668: [clangd] Add static index for the global code completion.

hokein updated this revision to Diff 128513. hokein marked 8 inline comments as done. hokein added a comment. Address review comments. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D41668 Files: clangd/ClangdLSPServer.cpp clangd/ClangdLSPServer.h clangd/ClangdServer.cpp

[PATCH] D41668: [clangd] Add static index for the global code completion.

hokein added a comment. Thanks for the comments. Comment at: clangd/ClangdLSPServer.h:40 + bool BuildDynamicSymbolIndex, + std::unique_ptr GlobalIdx); ioeric wrote: > We are calling this global index and static index in the

[PATCH] D38124: Hide some symbols to avoid a crash on shutdown when using code coverage

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rCRT321703: Hide some symbols to avoid a crash on shutdown when using code coverage (authored by marco, committed by ).

[PATCH] D38124: Hide some symbols to avoid a crash on shutdown when using code coverage

marco-c added a comment. The change was already positively reviewed with the request for a test, which has been written since then. Repository: rCRT Compiler Runtime https://reviews.llvm.org/D38124 ___ cfe-commits mailing list

[PATCH] D41668: [clangd] Add static index for the global code completion.

ioeric added inline comments. Comment at: clangd/CodeComplete.cpp:583 - Items->isIncomplete = !Index.fuzzyFind(Ctx, Req, [&](const Symbol ) { -Items->items.push_back(indexCompletionItem(Sym, Filter, SSInfo)); - }); + // FIXME: figure out a way to merge the symbols from

r321775 - PR35815: Separate out the ns-consumed diagnostic into an error and

Author: arphaman Date: Wed Jan 3 15:52:42 2018 New Revision: 321775 URL: http://llvm.org/viewvc/llvm-project?rev=321775=rev Log: PR35815: Separate out the ns-consumed diagnostic into an error and a warning This commit separates out the warn_nsconsumed_attribute_mismatch and

Re: trivial_abi

On 3 January 2018 at 15:24, John McCall via cfe-commits < cfe-commits@lists.llvm.org> wrote: > On Jan 3, 2018, at 5:53 PM, Richard Smith wrote: > On 3 January 2018 at 14:29, John McCall via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> >> On Jan 3, 2018, at 5:12

r321776 - Fix test to use -S instead of -c so it doesn't unnecessarily run the assembler.

Author: dyung Date: Wed Jan 3 16:16:57 2018 New Revision: 321776 URL: http://llvm.org/viewvc/llvm-project?rev=321776=rev Log: Fix test to use -S instead of -c so it doesn't unnecessarily run the assembler. Reviewed by Paul Robinson Modified: cfe/trunk/test/Driver/config-file.c Modified:

r321777 - PR35028: Retain duplicate alignas attributes in template instantiation.

Author: rsmith Date: Wed Jan 3 17:02:18 2018 New Revision: 321777 URL: http://llvm.org/viewvc/llvm-project?rev=321777=rev Log: PR35028: Retain duplicate alignas attributes in template instantiation. Modified: cfe/trunk/include/clang/Basic/Attr.td cfe/trunk/test/SemaTemplate/alignas.cpp

[PATCH] D41720: [clang-tidy] Add a -show-color flag.

itessier created this revision. itessier added a project: clang-tools-extra. Herald added a subscriber: xazax.hun. This change will allow enabling of colour diagnostics when not directly running within a terminal, but colour output is possible. For example, if stdout is being captured and

Re: r321395 - [ODRHash] Support ODR violation detection in functions.

Vedant, I'm looking into it. On Wed, Jan 3, 2018 at 11:12 AM, Vedant Kumar wrote: > Oops, the build log was too big to attach. Resending with just the bot > link, then: > http://lab.llvm.org:8080/green/view/Experimental/job/ > clang-stage2-coverage-R/2193/consoleText > > vedant

[PATCH] D41713: [Myriad] Remove invalidated -elf flag for MoviAsm

waltl created this revision. waltl added a reviewer: jyknight. The flag has been deprecated, and is becoming invalid in the latest MDK. https://reviews.llvm.org/D41713 Files: clang/lib/Driver/ToolChains/Myriad.cpp clang/test/Driver/myriad-toolchain.c Index:

[PATCH] D41711: [docs] Mention support for Windows/ARM64 in the release notes

rnk added a comment. In https://reviews.llvm.org/D41711#966983, @rnk wrote: > We should also discuss LLD and PDBs here. That's made huge progress since 5.0. Nevermind, we have LLD release notes for that. Repository: rC Clang https://reviews.llvm.org/D41711

Re: trivial_abi

> On Jan 3, 2018, at 5:12 PM, Richard Smith wrote: > > On 2 January 2018 at 20:55, John McCall via cfe-commits > > wrote: >> On Jan 2, 2018, at 10:43 PM, Richard Smith >

[PATCH] D41545: Replace cp -a in various Clang tests

hubert.reinterpretcast updated this revision to Diff 128584. hubert.reinterpretcast added a comment. Use cp -R, which is sufficient instead of cp -RPp Repository: rC Clang https://reviews.llvm.org/D41545 Files: test/Modules/crash-vfs-path-emptydir-entries.m

[libcxx] r321725 - Update version to 7.0.0svn: cmake, include files and docs

Author: hans Date: Wed Jan 3 07:40:29 2018 New Revision: 321725 URL: http://llvm.org/viewvc/llvm-project?rev=321725=rev Log: Update version to 7.0.0svn: cmake, include files and docs Modified: libcxx/trunk/CMakeLists.txt libcxx/trunk/docs/conf.py libcxx/trunk/include/__config

[libcxxabi] r321726 - Update version to 7.0.0svn

Author: hans Date: Wed Jan 3 07:42:34 2018 New Revision: 321726 URL: http://llvm.org/viewvc/llvm-project?rev=321726=rev Log: Update version to 7.0.0svn Modified: libcxxabi/trunk/CMakeLists.txt Modified: libcxxabi/trunk/CMakeLists.txt URL:

[libunwind] r321741 - Drop 'svn' suffix from the version number.

Author: hans Date: Wed Jan 3 08:58:46 2018 New Revision: 321741 URL: http://llvm.org/viewvc/llvm-project?rev=321741=rev Log: Drop 'svn' suffix from the version number. Modified: libunwind/branches/release_60/CMakeLists.txt Modified: libunwind/branches/release_60/CMakeLists.txt URL:

[libcxxabi] r321739 - Drop 'svn' suffix from the version number.

Author: hans Date: Wed Jan 3 08:58:21 2018 New Revision: 321739 URL: http://llvm.org/viewvc/llvm-project?rev=321739=rev Log: Drop 'svn' suffix from the version number. Modified: libcxxabi/branches/release_60/CMakeLists.txt Modified: libcxxabi/branches/release_60/CMakeLists.txt URL:

[libcxx] r321740 - Drop 'svn' suffix from the version number.

Author: hans Date: Wed Jan 3 08:58:30 2018 New Revision: 321740 URL: http://llvm.org/viewvc/llvm-project?rev=321740=rev Log: Drop 'svn' suffix from the version number. Modified: libcxx/branches/release_60/CMakeLists.txt Modified: libcxx/branches/release_60/CMakeLists.txt URL:

r321728 - Update docs version and clear release notes for 7.0.0

Author: hans Date: Wed Jan 3 07:49:39 2018 New Revision: 321728 URL: http://llvm.org/viewvc/llvm-project?rev=321728=rev Log: Update docs version and clear release notes for 7.0.0 Modified: cfe/trunk/docs/ReleaseNotes.rst cfe/trunk/docs/conf.py Modified: cfe/trunk/docs/ReleaseNotes.rst

[PATCH] D37014: [clang-tidy] Add a checker to remove useless intermediate variables before return statements with comparisons

Abpostelnicu added inline comments. Comment at: clang-tidy/readability/UnnecessaryIntermediateVarCheck.cpp:376 +// expression wouldn't really benefit readability. Therefore we abort. +if (NewReturnLength > MaximumLineLength) { + return; lebedev.ri

[libunwind] r321743 - Update PACKAGE_VERSION to 7.0.0svn

Author: hans Date: Wed Jan 3 08:59:48 2018 New Revision: 321743 URL: http://llvm.org/viewvc/llvm-project?rev=321743=rev Log: Update PACKAGE_VERSION to 7.0.0svn Modified: libunwind/trunk/CMakeLists.txt Modified: libunwind/trunk/CMakeLists.txt URL:

[PATCH] D41698: [DebugInfo] Enable debug information for C99 VLA types

aprantl added a comment. It would be awesome if you could also add an end-to-end test to the debuginfo-tests repository so we can verify that this actually works in LLDB and GDB. Comment at: lib/CodeGen/CGDebugInfo.cpp:2358 +if (auto *SizeNode =

[clang-tools-extra] r321730 - Docs, release notes: update version to 7.0.0

Author: hans Date: Wed Jan 3 07:53:24 2018 New Revision: 321730 URL: http://llvm.org/viewvc/llvm-project?rev=321730=rev Log: Docs, release notes: update version to 7.0.0 Modified: clang-tools-extra/trunk/docs/ReleaseNotes.rst clang-tools-extra/trunk/docs/conf.py Modified:

[libunwind] r321732 - Update docs version to 7.0

Author: hans Date: Wed Jan 3 07:58:08 2018 New Revision: 321732 URL: http://llvm.org/viewvc/llvm-project?rev=321732=rev Log: Update docs version to 7.0 Modified: libunwind/trunk/docs/conf.py Modified: libunwind/trunk/docs/conf.py URL:

[PATCH] D41708: [clang-tidy] Update fuchsia-overloaded-operator to check for valid loc

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE321762: [clang-tidy] Update fuchsia-overloaded-operator to check for valid loc (authored by juliehockett, committed by ). Changed prior to commit: https://reviews.llvm.org/D41708?vs=128548=128563#toc

[PATCH] D41711: [docs] Mention support for Windows/ARM64 in the release notes

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm We should also discuss LLD and PDBs here. That's made huge progress since 5.0. Repository: rC Clang https://reviews.llvm.org/D41711 ___

Re: [clang-tools-extra] r321762 - [clang-tidy] Update fuchsia-overloaded-operator to check for valid loc

Hans, I'd like to nominate this patch for the 6.0 branch. It fixes a failing assertion with new functionality; without this fix, anyone enabling this check and including a STL header that transitively includes (which is most of them) will hit the assertion. Thanks! ~Aaron On Wed, Jan 3, 2018

[PATCH] D41416: [modules] [pch] Do not deserialize all lazy template specializations when looking for one.

v.g.vassilev updated this revision to Diff 128575. v.g.vassilev marked 4 inline comments as done. v.g.vassilev added a comment. Address comments: - Fix style; - Do not potentially deserialize a specialization in debug mode. https://reviews.llvm.org/D41416 Files:

[PATCH] D41384: [analyzer] Suppress false positive warnings form security.insecureAPI.strcpy

NoQ added a comment. This patch makes a totally valid point :) Comment at: lib/StaticAnalyzer/Checkers/CheckSecuritySyntaxOnly.cpp:513 + int ArraySize = -1, StrLen = -1; + const auto *Target = CE->getArg(0)->IgnoreImpCasts(), You might want to use a wider

[PATCH] D41711: [docs] Mention support for Windows/ARM64 in the release notes

mstorsjo created this revision. mstorsjo added reviewers: rnk, compnerd, mgrang. Herald added subscribers: kristof.beyls, aemerson. Repository: rC Clang https://reviews.llvm.org/D41711 Files: docs/ReleaseNotes.rst Index: docs/ReleaseNotes.rst

[PATCH] D41716: clang-tidy: add IgnoreMacros option to readability-inconsistent-declaration-parameter-name

vmiklos created this revision. vmiklos added reviewers: alexfh, piotrdz. And also enable it by default to be consistent with e.g. modernize-use-using. This helps e.g. when running this check on client code where the macro is provided by the system, so there is no easy way to modify it.

[PATCH] D41717: [CGBuiltin] Handle unsigned mul overflow properly (PR35750)

vsk created this revision. vsk added reviewers: efriedma, arphaman. r320902 fixed the IRGen for some types of checked multiplications. It did not handle unsigned overflow correctly in the case where the signed operand is negative (PR35750). Eli pointed out that on overflow, the result must be

[PATCH] D41538: [analyzer] Fix some checker's output plist not containing the checker name #2

NoQ added a comment. I'm still not quite sure what's the whole point of having `BugType` without a checker. We can still easily write anything we want in the "category" and "name" fields anyways, so we can easily produce bugs that are indistinguishable to the user from different checkers,

r321770 - PR33503: When a qualified name in a redeclaration names a prior declaration in

Author: rsmith Date: Wed Jan 3 15:03:54 2018 New Revision: 321770 URL: http://llvm.org/viewvc/llvm-project?rev=321770=rev Log: PR33503: When a qualified name in a redeclaration names a prior declaration in an inline namespace, update its semantic DeclContext to match. We would previously get

[PATCH] D41717: [CGBuiltin] Handle unsigned mul overflow properly (PR35750)

This revision was automatically updated to reflect the committed changes. Closed by commit rL321771: [CGBuiltin] Handle unsigned mul overflow properly (PR35750) (authored by vedantk, committed by ). Changed prior to commit: https://reviews.llvm.org/D41717?vs=128567=128574#toc Repository: rL

r321771 - [CGBuiltin] Handle unsigned mul overflow properly (PR35750)

Author: vedantk Date: Wed Jan 3 15:11:32 2018 New Revision: 321771 URL: http://llvm.org/viewvc/llvm-project?rev=321771=rev Log: [CGBuiltin] Handle unsigned mul overflow properly (PR35750) r320902 fixed the IRGen for some types of checked multiplications. It did not handle unsigned overflow

Re: trivial_abi

> On Jan 3, 2018, at 5:53 PM, Richard Smith wrote: > On 3 January 2018 at 14:29, John McCall via cfe-commits > > wrote: > >> On Jan 3, 2018, at 5:12 PM, Richard Smith >

r321763 - Introduce some infrastructure for adding C attributes with [[]] syntax.

Author: aaronballman Date: Wed Jan 3 14:22:48 2018 New Revision: 321763 URL: http://llvm.org/viewvc/llvm-project?rev=321763=rev Log: Introduce some infrastructure for adding C attributes with [[]] syntax. This patch adds support to the attribute tablegen for specifying a [[]] attribute is

[PATCH] D41317: Infrastructure for adding C attributes

aaron.ballman closed this revision. aaron.ballman added a comment. I commit in r321763. I changed the name of `IncludeC` to be `AllowInC` at John McCall's suggestion. https://reviews.llvm.org/D41317 ___ cfe-commits mailing list

[PATCH] D41553: Support parsing double square-bracket attributes in ObjC

rjmccall added inline comments. Comment at: include/clang/Basic/Attr.td:239 + bit IncludeC = includeC; +} aaron.ballman wrote: > rjmccall wrote: > > I have no objection to allowing ObjC attributes to be spelled in > > [[clang::objc_whatever]] style. We can

[PATCH] D41708: [clang-tidy] Update fuchsia-overloaded-operator to check for valid loc

alexfh added inline comments. Comment at: clang-tidy/fuchsia/OverloadedOperatorCheck.cpp:38 + if (Loc.isValid()) +diag(Loc, "cannot overload %0") << D; } This is not related to the fix, but the warning message is unclear, incorrect and confusing: one most

[clang-tools-extra] r321762 - [clang-tidy] Update fuchsia-overloaded-operator to check for valid loc

Author: juliehockett Date: Wed Jan 3 14:10:11 2018 New Revision: 321762 URL: http://llvm.org/viewvc/llvm-project?rev=321762=rev Log: [clang-tidy] Update fuchsia-overloaded-operator to check for valid loc Updating fuchsia-overloaded-operator check to not issue warnings for invalid locations.

Re: trivial_abi

On 2 January 2018 at 20:55, John McCall via cfe-commits < cfe-commits@lists.llvm.org> wrote: > On Jan 2, 2018, at 10:43 PM, Richard Smith wrote: > > On 2 January 2018 at 19:02, John McCall via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> >> On Jan 2, 2018, at

[PATCH] D41717: [CGBuiltin] Handle unsigned mul overflow properly (PR35750)

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D41717 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: trivial_abi

On 3 January 2018 at 14:29, John McCall via cfe-commits < cfe-commits@lists.llvm.org> wrote: > > On Jan 3, 2018, at 5:12 PM, Richard Smith wrote: > > On 2 January 2018 at 20:55, John McCall via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> On Jan 2, 2018, at

[PATCH] D41545: Replace cp -a in various Clang tests

This revision was automatically updated to reflect the committed changes. Closed by commit rC321778: Replace cp -a in various Clang tests (authored by hubert.reinterpretcast, committed by ). Changed prior to commit: https://reviews.llvm.org/D41545?vs=128584=128586#toc Repository: rC Clang

r321778 - Replace cp -a in various Clang tests

Author: hubert.reinterpretcast Date: Wed Jan 3 17:15:52 2018 New Revision: 321778 URL: http://llvm.org/viewvc/llvm-project?rev=321778=rev Log: Replace cp -a in various Clang tests Summary: cp -a is neither part of POSIX nor the LSB. The nearest equivalent under POSIX is cp -RPp; however, cp -R

r321779 - PR35045: Convert injected-class-name to its corresponding simple-template-id

Author: rsmith Date: Wed Jan 3 17:24:17 2018 New Revision: 321779 URL: http://llvm.org/viewvc/llvm-project?rev=321779=rev Log: PR35045: Convert injected-class-name to its corresponding simple-template-id during template argument deduction. We already did this when the injected-class-name was in

r321781 - [Modules] Allow modules specified by -fmodule-map-file to shadow implicitly found ones

Author: bruno Date: Wed Jan 3 18:17:40 2018 New Revision: 321781 URL: http://llvm.org/viewvc/llvm-project?rev=321781=rev Log: [Modules] Allow modules specified by -fmodule-map-file to shadow implicitly found ones When modules come from module map files explicitly specified by

[PATCH] D31269: [Modules] Allow modules specified by -fmodule-map-file to shadow implicitly found ones

bruno added a comment. > It might make more sense to have the module loaded from the AST file shadow > the module from the module map, especially for an explicit module build, now > that we have that functionality.) +1, seems a much more consistent model. Comment at:

Re: [PATCH] D41039: Add support for attribute "trivial_abi"

On Wed, Jan 3, 2018 at 2:07 PM, Akira Hatanaka wrote: > On Jan 3, 2018, at 10:25 AM, John McCall wrote: > > On Wed, Jan 3, 2018 at 12:24 PM, Akira Hatanaka > wrote: > >> On Jan 2, 2018, at 9:42 AM, David Blaikie via cfe-commits < >>

[PATCH] D40819: Implement Attribute Target MultiVersioning (Improved edition!)

rsmith added a comment. Lots of comments, but no high-level design concerns. I think this is very close to being ready to go. Comment at: include/clang/AST/Decl.h:2162-2168 + /// Sets the multiversion state for this declaration and all of its + /// redeclarations. + void

[PATCH] D41629: [libcxx] Improve accuracy of complex asinh and acosh

miyuki added inline comments. Comment at: test/std/numerics/complex.number/complex.transcendentals/acosh.pass.cpp:59 +{ +assert(r.real() == 0); +assert(!std::signbit(r.real())); Ideally, I would prefer some approximate comparison

[PATCH] D41517: mmintrin.h documentation fixes and updates

kromanova added inline comments. Comment at: lib/Headers/mmintrin.h:1292 /// -/// This intrinsic corresponds to the VXORPS / XORPS instruction. +/// This intrinsic corresponds to the XOR instruction. /// craig.topper wrote: > PXOR? For which

[PATCH] D31269: [Modules] Allow modules specified by -fmodule-map-file to shadow implicitly found ones

This revision was automatically updated to reflect the committed changes. Closed by commit rL321781: [Modules] Allow modules specified by -fmodule-map-file to shadow implicitly… (authored by bruno, committed by ). Changed prior to commit: https://reviews.llvm.org/D31269?vs=92738=128590#toc

[PATCH] D40819: Implement Attribute Target MultiVersioning (Improved edition!)

echristo accepted this revision. echristo added a comment. This revision is now accepted and ready to land. Couple of inline comments, otherwise I'm pretty happy. I'd wait for an ack by Richard for this though. -eric Comment at: lib/CodeGen/CGBuiltin.cpp:7673 -Value

Re: [PATCH] D41039: Add support for attribute "trivial_abi"

> On Jan 3, 2018, at 6:39 PM, John McCall wrote: > > On Wed, Jan 3, 2018 at 2:07 PM, Akira Hatanaka > wrote: >> On Jan 3, 2018, at 10:25 AM, John McCall > > wrote: >> >> On

[PATCH] D38320: [clang] Fix serializers for `TypeTemplateParmDecl` + related types

elsteveogrande updated this revision to Diff 128593. elsteveogrande added a comment. Update: now works properly with modules as well. This needed to handle the case where a `ParmDecl` is already inheriting, but it's innocuously inheriting from the same decl. Now

r321786 - Revert "[Modules] Allow modules specified by -fmodule-map-file to shadow implicitly found ones"

Author: bruno Date: Wed Jan 3 23:31:24 2018 New Revision: 321786 URL: http://llvm.org/viewvc/llvm-project?rev=321786=rev Log: Revert "[Modules] Allow modules specified by -fmodule-map-file to shadow implicitly found ones" This reverts r321781 until I fix the leaks pointed out by bots:

[PATCH] D41716: clang-tidy: add IgnoreMacros option to readability-inconsistent-declaration-parameter-name

lebedev.ri added a comment. > And also enable it by default to be consistent with e.g. modernize-use-using. That changes the defaults though. I thought clang-tidy *tried* to produce the same results on different clang-tidy versions with the same `.clang-tidy` config? Or is there no such

[PATCH] D40819: Implement Attribute Target MultiVersioning (Improved edition!)

erichkeane added a comment. Hi all-- I'm intending to miss the branch for 6.0, but I'd love to get this in soon after. Can anyone take another look? Thanks, Erich https://reviews.llvm.org/D40819 ___ cfe-commits mailing list

Re: [PATCH] D41039: Add support for attribute "trivial_abi"

> On Jan 2, 2018, at 9:42 AM, David Blaikie via cfe-commits > wrote: > > > > On Tue, Dec 19, 2017 at 9:43 PM Akira Hatanaka > wrote: > On Tue, Dec 12, 2017 at 12:12 PM, John McCall

[PATCH] D41575: [index] Return when DC is null in handleReference

MaskRay added a comment. HighCommander4 narrowed it down https://github.com/jacobdufault/cquery/issues/219#issuecomment-354903152 to a much simpler reproduce: c++ template struct actor; template class Actor = actor> struct terminal; This may trigger null pointer dereference of

[PATCH] D41102: Setup clang-doc frontend framework

phosek added a comment. In https://reviews.llvm.org/D41102#955200, @JDevlieghere wrote: > I don't know what basis is used to differentiate between the two, but should > this be part of clang tools or clang-tools-extra? AFAIK there's a general agreement that clang-tools-extra should be

  1   2   >