[PATCH] D39903: [libclang] Allow pretty printing declarations

nik updated this revision to Diff 129591. nik added a comment. Addressed comments. Repository: rC Clang https://reviews.llvm.org/D39903 Files: include/clang-c/Index.h test/Index/print-display-names.cpp tools/c-index-test/c-index-test.c tools/libclang/CIndex.cpp

[PATCH] D39903: [libclang] Allow pretty printing declarations

nik added a comment. > It might be worth adding some very simple get/set tests to ensure that > properties are set as intended. clang_PrintingPolicy_setProperty is already called in c-index-test.c and covered with test/Index/print-display-names.cpp. Do you have another kind of test in mind?

[PATCH] D41897: Fixing a crash in Sema.

jkorous-apple added inline comments. Comment at: Sema/SemaDeclCXX.cpp:2426 +// Skip all dependent types in templates being used as base specifiers. +// Checks below assume that base specifier is a CXXRecord. +if (BaseType->isDependentType()) {

[PATCH] D39903: [libclang] Allow pretty printing declarations

nik updated this revision to Diff 129600. nik marked an inline comment as done. nik added a comment. Added assert() for getter/setter. Repository: rC Clang https://reviews.llvm.org/D39903 Files: include/clang-c/Index.h test/Index/print-display-names.cpp

[PATCH] D39903: [libclang] Allow pretty printing declarations

jbcoe added a comment. Looking good, only a few nits. Comment at: tools/libclang/CIndex.cpp:4782 + + return 0; +} Might be worth asserting here. Comment at: unittests/libclang/LibclangTest.cpp:596 +TEST_F(LibclangPrintingPolicyTest,

[PATCH] D39903: [libclang] Allow pretty printing declarations

nik marked an inline comment as done. nik added inline comments. Comment at: tools/libclang/CIndex.cpp:4782 + + return 0; +} jbcoe wrote: > Might be worth asserting here. Good idea. I've done the same for the setter. Comment at:

[PATCH] D41989: [CodeComplete] Add an option to omit results from the preamble.

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM modulo the comment about variable name. Comment at: lib/Sema/SemaLookup.cpp:3502 + bool IncludeDependentBases, +

[PATCH] D41992: [libcxx] Avoid spurious construction of valarray elements

miyuki created this revision. miyuki added reviewers: EricWF, mclow.lists. Currently libc++ implements some operations on valarray by using the resize method. This method has a parameter with a default value. Because of this, valarray may spuriously construct and destruct objects of valarray's

[PATCH] D20124: [PCH] Serialize skipped preprocessor ranges

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM, sorry for the delay. https://reviews.llvm.org/D20124 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D41897: Fixing a crash in Sema.

jkorous-apple added inline comments. Comment at: SemaCXX/base-class-ambiguity-check.cpp:1 +// RUN: %clang_cc1 -fsyntax-only %s + aaron.ballman wrote: > jkorous-apple wrote: > > aaron.ballman wrote: > > > jkorous-apple wrote: > > > > aaron.ballman wrote: > > > >

[PATCH] D41897: Fixing a crash in Sema.

aaron.ballman added a comment. In https://reviews.llvm.org/D41897#974618, @jkorous-apple wrote: > Thank you! Do you have commit privileges, or would you like me to commit this on your behalf? https://reviews.llvm.org/D41897 ___ cfe-commits

[PATCH] D41980: Add tests for llvm-bcanalyzer stream types

aprantl accepted this revision. aprantl added inline comments. This revision is now accepted and ready to land. Comment at: test/PCH/include-stream-type.cpp:7 +// RUN: cp %S/Inputs/pragma-once2.h %t-dir +// RUN: %clang_cc1 -x c++-header -emit-pch -o %t %t-dir/pragma-once2-pch.h

[PATCH] D41989: [CodeComplete] Add an option to omit results from the preamble.

This revision was automatically updated to reflect the committed changes. Closed by commit rC322371: [CodeComplete] Add an option to omit results from the preamble. (authored by sammccall, committed by ). Changed prior to commit: https://reviews.llvm.org/D41989?vs=129618=129620#toc

[PATCH] D40780: [clangd] Incorporate fuzzy-match into result rankings.

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. LGTM. Comment at: test/clangd/completion-fuzzy.test:1 +# RUN: clangd -pretty -run-synchronously < %s | FileCheck %s +# It is absolutely vital that this file has CRLF line

[PATCH] D40780: [clangd] Incorporate fuzzy-match into result rankings.

This revision was automatically updated to reflect the committed changes. Closed by commit rL322377: [clangd] Incorporate fuzzy-match into result rankings. (authored by sammccall, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[clang-tools-extra] r322377 - [clangd] Incorporate fuzzy-match into result rankings.

Author: sammccall Date: Fri Jan 12 08:16:09 2018 New Revision: 322377 URL: http://llvm.org/viewvc/llvm-project?rev=322377=rev Log: [clangd] Incorporate fuzzy-match into result rankings. Summary: The scoring function is fuzzy-match-quality * existing quality score. Reviewers: ioeric

[clang-tools-extra] r322370 - [clangd] Don't navigate to forward class declaration when go to definition.

Author: hokein Date: Fri Jan 12 06:21:10 2018 New Revision: 322370 URL: http://llvm.org/viewvc/llvm-project?rev=322370=rev Log: [clangd] Don't navigate to forward class declaration when go to definition. Summary: For some cases, GoToDefinition will navigate to the forward class declaration, we

[PATCH] D41661: [clangd] Don't navigate to forward class declaration when go to definition.

This revision was automatically updated to reflect the committed changes. Closed by commit rL322370: [clangd] Dont navigate to forward class declaration when go to definition. (authored by hokein, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM

[PATCH] D40780: [clangd] Incorporate fuzzy-match into result rankings.

sammccall marked 2 inline comments as done. sammccall added a comment. Tested in this file: #include #include #include int main() { std::^ } Before this change: u -> __has_argument_type, __has_first_argument_type... un -> __has_argument_type, __has_first_argument_type... u_p

[PATCH] D41897: Fixing a crash in Sema.

jkorous-apple added a comment. I do. Will commit this in a minute. https://reviews.llvm.org/D41897 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D39903: [libclang] Allow pretty printing declarations

nik updated this revision to Diff 129635. nik added a comment. What about this? :) Repository: rC Clang https://reviews.llvm.org/D39903 Files: include/clang-c/Index.h test/Index/print-display-names.cpp tools/c-index-test/c-index-test.c tools/libclang/CIndex.cpp

[clang-tools-extra] r322379 - [clangd] Include debugging tags for both static and dynamic index. NFC

Author: sammccall Date: Fri Jan 12 09:09:49 2018 New Revision: 322379 URL: http://llvm.org/viewvc/llvm-project?rev=322379=rev Log: [clangd] Include debugging tags for both static and dynamic index. NFC Modified: clang-tools-extra/trunk/clangd/CodeComplete.cpp

[PATCH] D41937: [WebAssembly] supports -stdlib=libc++ switch

sbc100 added a comment. lgtm https://reviews.llvm.org/D41937 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D41989: [CodeComplete] Add an option to omit results from the preamble.

sammccall updated this revision to Diff 129618. sammccall added a comment. Load -> LoadExternal Repository: rC Clang https://reviews.llvm.org/D41989 Files: include/clang-c/Index.h include/clang/Sema/CodeCompleteConsumer.h include/clang/Sema/CodeCompleteOptions.h

[PATCH] D41990: [Frontend] Allow to use PrecompiledPreamble without calling CanReuse

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: include/clang/Frontend/PrecompiledPreamble.h:107 /// is accessible. - /// For in-memory preambles, PrecompiledPreamble instance continues to own -

[PATCH] D40023: [RISCV] Implement ABI lowering

rjmccall added inline comments. Comment at: lib/CodeGen/CGCall.cpp:1937 +RetAttrs.addAttribute(llvm::Attribute::ZExt); +} // FALL THROUGH asb wrote: > rjmccall wrote: > > I feel like a better design would be to record whether to do a sext or a

[PATCH] D41980: Add tests for llvm-bcanalyzer stream types

aprantl added inline comments. Comment at: test/PCH/include-stream-type.cpp:7 +// RUN: cp %S/Inputs/pragma-once2.h %t-dir +// RUN: %clang_cc1 -x c++-header -emit-pch -o %t %t-dir/pragma-once2-pch.h +// RUN: llvm-bcanalyzer -dump %t | FileCheck %s You may need to

[PATCH] D41655: [clang-tidy] New check bugprone-unused-return-value

JonasToth added a comment. High Integrity C++ has the rule `17.5.1 Do not ignore the result of std::remove, std::remove_if or std::unique`. Do we want to add those to the preconfigured list? https://reviews.llvm.org/D41655 ___ cfe-commits mailing

[PATCH] D41991: [clangd] Always use preamble (even stale) for code completion

ilya-biryukov created this revision. ilya-biryukov added reviewers: bkramer, sammccall. Herald added a subscriber: klimek. This improves performance of code completion, because we avoid stating the files from the preamble and never attempt to parse the files without using the preamble if it's

[PATCH] D40780: [clangd] Incorporate fuzzy-match into result rankings.

sammccall updated this revision to Diff 129622. sammccall marked 2 inline comments as done. sammccall added a comment. Rebase, and address comments. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D40780 Files: clangd/CodeComplete.cpp clangd/FuzzyMatch.h clangd/Protocol.h

[PATCH] D41897: Fixing a crash in Sema.

aaron.ballman added inline comments. Comment at: SemaCXX/base-class-ambiguity-check.cpp:1 +// RUN: %clang_cc1 -fsyntax-only %s + jkorous-apple wrote: > aaron.ballman wrote: > > jkorous-apple wrote: > > > aaron.ballman wrote: > > > > This run line isn't testing

[PATCH] D41980: Add tests for llvm-bcanalyzer stream types

modocache added inline comments. Comment at: test/PCH/include-stream-type.cpp:7 +// RUN: cp %S/Inputs/pragma-once2.h %t-dir +// RUN: %clang_cc1 -x c++-header -emit-pch -o %t %t-dir/pragma-once2-pch.h +// RUN: llvm-bcanalyzer -dump %t | FileCheck %s aprantl

r322371 - [CodeComplete] Add an option to omit results from the preamble.

Author: sammccall Date: Fri Jan 12 06:51:47 2018 New Revision: 322371 URL: http://llvm.org/viewvc/llvm-project?rev=322371=rev Log: [CodeComplete] Add an option to omit results from the preamble. Summary: Enumerating the contents of a namespace or global scope will omit any decls that aren't

[PATCH] D41809: Clang counterpart change for fuzzer FreeBSD support

devnexen added a comment. In https://reviews.llvm.org/D41809#969475, @kimgr wrote: > Typo in the commit title: buzzer :) Changed ... just to follow-up the now accepted change of this one https://reviews.llvm.org/D41642 https://reviews.llvm.org/D41809

[PATCH] D41897: Fixing a crash in Sema.

jkorous-apple updated this revision to Diff 129631. jkorous-apple added a comment. Fixed test based on Aaron's comments. https://reviews.llvm.org/D41897 Files: Sema/SemaDeclCXX.cpp SemaCXX/base-class-ambiguity-check.cpp Index: SemaCXX/base-class-ambiguity-check.cpp

[PATCH] D41937: [WebAssembly] supports -stdlib=libc++ switch

patcheng added a comment. Thanks @sbc100. BTW I don't have commit access. When it's ready to be committed, I would need help with that. Thanks https://reviews.llvm.org/D41937 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D41990: [Frontend] Allow to use PrecompiledPreamble without calling CanReuse

ilya-biryukov created this revision. ilya-biryukov added reviewers: bkramer, sammccall. The new method 'OverridePreamble' allows to override the preamble of any source file without checking if preamble bounds or dependencies were changed. This is used for completion in clangd. Repository: rC

[PATCH] D41897: Fixing a crash in Sema.

jkorous-apple added a comment. Thank you! https://reviews.llvm.org/D41897 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D40780: [clangd] Incorporate fuzzy-match into result rankings.

sammccall updated this revision to Diff 129633. sammccall marked an inline comment as done. sammccall added a comment. Unit test instead of lit test. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D40780 Files: clangd/CodeComplete.cpp clangd/FuzzyMatch.h clangd/Protocol.h

[PATCH] D40780: [clangd] Incorporate fuzzy-match into result rankings.

sammccall added inline comments. Comment at: test/clangd/completion-fuzzy.test:1 +# RUN: clangd -pretty -run-synchronously < %s | FileCheck %s +# It is absolutely vital that this file has CRLF line endings. hokein wrote: > nit: any reason not using unittest

[PATCH] D41809: Clang counterpart change for fuzzer FreeBSD support

krytarowski added a comment. Looks good, please improve the description of the commit (and not your authorship that will be preserved in the commit message). Once accepted by another developer, I can commit it for you. https://reviews.llvm.org/D41809

[PATCH] D41423: [Lex] Avoid out-of-bounds dereference in LexAngledStringLiteral.

This revision was automatically updated to reflect the committed changes. Closed by commit rC322390: [Lex] Avoid out-of-bounds dereference in LexAngledStringLiteral. (authored by vsapsai, committed by ). Changed prior to commit: https://reviews.llvm.org/D41423?vs=129379=129666#toc Repository:

r322390 - [Lex] Avoid out-of-bounds dereference in LexAngledStringLiteral.

Author: vsapsai Date: Fri Jan 12 10:54:35 2018 New Revision: 322390 URL: http://llvm.org/viewvc/llvm-project?rev=322390=rev Log: [Lex] Avoid out-of-bounds dereference in LexAngledStringLiteral. Fix makes the loop in LexAngledStringLiteral more like the loops in LexStringLiteral, LexCharConstant.

[PATCH] D41228: [ObjC] Enable __strong pointers in structs under ARC

rjmccall added inline comments. Comment at: include/clang/AST/Decl.h:3529 + /// Basic properties of non-trivial C structs. + bool HasStrongObjCPointer : 1; + Is it interesting to track all the individual reasons that a struct is non-trivial at the struct

[PATCH] D41996: [clangd] Code completion uses Sema for NS-level things in the current file.

sammccall added a comment. In https://reviews.llvm.org/D41996#974751, @hokein wrote: > nice, LGTM. > > By `r322377`, I think you mean `r322371`. Done. > We also need to set `CollectorOpts.IndexMainFiles` to `false` in > `FileIndex.cpp::indexAST` -- we don't need dynamic index to catch the

[PATCH] D42001: [Driver] Add "did you mean?" suggestions to -cc1as

modocache created this revision. modocache added reviewers: v.g.vassilev, bruno. In https://reviews.llvm.org/D41733, the driver was modified such that, when a user provided a mispelled option such as `-hel`, it would suggest a valid option with a nearby edit distance: "did you mean '-help'?".

[PATCH] D41999: Refactor handling of signext/zeroext in ABIArgInfo

This revision was automatically updated to reflect the committed changes. Closed by commit rC322396: Refactor handling of signext/zeroext in ABIArgInfo (authored by asb, committed by ). Repository: rC Clang https://reviews.llvm.org/D41999 Files: include/clang/CodeGen/CGFunctionInfo.h

[PATCH] D41228: [ObjC] Enable __strong pointers in structs under ARC

rjmccall added inline comments. Comment at: include/clang/AST/Type.h:1148 +DK_objc_weak_lifetime, +DK_c_struct_strong_field }; ahatanak wrote: > rjmccall wrote: > > I don't think you want to refer to the fact that the C struct specifically > >

Re: r322390 - [Lex] Avoid out-of-bounds dereference in LexAngledStringLiteral.

Hans, I am nominating this change to be merged into 6.0.0 release branch. Thanks, Volodymyr > On Jan 12, 2018, at 10:54, Volodymyr Sapsai via cfe-commits > wrote: > > Author: vsapsai > Date: Fri Jan 12 10:54:35 2018 > New Revision: 322390 > > URL:

[PATCH] D42005: [docs] Use monospace for PCH option flags

modocache created this revision. modocache added reviewers: sepavloff, aaron.ballman. Use monospace for option flags in the PCH section, instead of the italics that were being used previously. I believe these used to be links, for which single backticks would have been appropriate, but since

[PATCH] D41815: [clang-tidy] implement check for goto

JonasToth updated this revision to Diff 129677. JonasToth marked 8 inline comments as done. JonasToth added a comment. - address review comments - add better documentation with code examples Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D41815 Files:

[PATCH] D41384: [analyzer] Suppress false positive warnings form security.insecureAPI.strcpy

leanil updated this revision to Diff 129676. leanil marked an inline comment as done. leanil added a comment. Measure array size in bytes instead of elements. https://reviews.llvm.org/D41384 Files: lib/StaticAnalyzer/Checkers/CheckSecuritySyntaxOnly.cpp

[PATCH] D41384: [analyzer] Suppress false positive warnings form security.insecureAPI.strcpy

leanil marked 2 inline comments as done. leanil added a comment. In https://reviews.llvm.org/D41384#973851, @NoQ wrote: > Do you have commit access or should someone else commit it for you? I don't have, please commit it. Comment at:

[PATCH] D41963: [clang-tidy] Adding Fuchsia checker for thread local storage.

juliehockett updated this revision to Diff 129647. juliehockett marked 3 inline comments as done. juliehockett added a comment. Fixing comments https://reviews.llvm.org/D41963 Files: clang-tidy/fuchsia/CMakeLists.txt clang-tidy/fuchsia/FuchsiaTidyModule.cpp

r322382 - [WebAssembly] Support -stdlib=libc++ switch

Author: sbc Date: Fri Jan 12 09:54:49 2018 New Revision: 322382 URL: http://llvm.org/viewvc/llvm-project?rev=322382=rev Log: [WebAssembly] Support -stdlib=libc++ switch Referenced implementation from Fuchsia and Darwin Toolchain. Still only support CST_Libcxx. Now checks that the argument is

[PATCH] D41937: [WebAssembly] supports -stdlib=libc++ switch

This revision was automatically updated to reflect the committed changes. Closed by commit rC322382: [WebAssembly] Support -stdlib=libc++ switch (authored by sbc, committed by ). Changed prior to commit: https://reviews.llvm.org/D41937?vs=129572=129649#toc Repository: rC Clang

[PATCH] D41999: Refactor handling of signext/zeroext in ABIArgInfo

asb created this revision. asb added a reviewer: rjmccall. Herald added subscribers: cfe-commits, arichardson. As @rjmccall suggested in https://reviews.llvm.org/D40023, we can get rid of ABIInfo::shouldSignExtUnsignedType (used to handle cases like the Mips calling convention where 32-bit

[clang-tools-extra] r322387 - [clangd] Code completion uses Sema for NS-level things in the current file.

Author: sammccall Date: Fri Jan 12 10:30:08 2018 New Revision: 322387 URL: http://llvm.org/viewvc/llvm-project?rev=322387=rev Log: [clangd] Code completion uses Sema for NS-level things in the current file. Summary: To stay fast, it avoids deserializing anything outside the current file, by

[PATCH] D41996: [clangd] Code completion uses Sema for NS-level things in the current file.

This revision was automatically updated to reflect the committed changes. Closed by commit rL322387: [clangd] Code completion uses Sema for NS-level things in the current file. (authored by sammccall, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D39074: [libunwind][MIPS]: Add support for unwinding in N32 processes.

sdardis added a comment. Um, I now appear to be getting different results for running under QEMU doing it the proper way. I was previously rebuilding the failing test by hand and running under qemu. I don't believe I changed anything important, I'll have to take a longer look. If you define

[PATCH] D41815: [clang-tidy] implement check for goto

JonasToth updated this revision to Diff 129684. JonasToth added a comment. - simplified the code and merged diagnostics Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D41815 Files: clang-tidy/cppcoreguidelines/AvoidGotoCheck.cpp clang-tidy/cppcoreguidelines/AvoidGotoCheck.h

[PATCH] D41996: [clangd] Code completion uses Sema for NS-level things in the current file.

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. nice, LGTM. By `r322377`, I think you mean `r322371`. We also need to set `CollectorOpts.IndexMainFiles` to `false` in `FileIndex.cpp::indexAST` -- we don't need dynamic index to catch the

[PATCH] D41788: [DeclPrinter] Fix two cases that crash clang -ast-print.

tra added a comment. @arphaman: ping. https://reviews.llvm.org/D41788 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D41999: Refactor handling of signext/zeroext in ABIArgInfo

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Thanks, that looks great. I appreciate you doing this. Repository: rC Clang https://reviews.llvm.org/D41999 ___ cfe-commits mailing list

[PATCH] D40023: [RISCV] Implement ABI lowering

rjmccall added inline comments. Comment at: lib/CodeGen/CGCall.cpp:1937 +RetAttrs.addAttribute(llvm::Attribute::ZExt); +} // FALL THROUGH asb wrote: > rjmccall wrote: > > asb wrote: > > > rjmccall wrote: > > > > I feel like a better design would

[PATCH] D41228: [ObjC] Enable __strong pointers in structs under ARC

ahatanak added inline comments. Comment at: include/clang/AST/Type.h:1148 +DK_objc_weak_lifetime, +DK_c_struct_strong_field }; rjmccall wrote: > I don't think you want to refer to the fact that the C struct specifically > contains a __strong field

[PATCH] D42001: [Driver] Add "did you mean?" suggestions to -cc1as

v.g.vassilev accepted this revision. v.g.vassilev added a comment. This revision is now accepted and ready to land. LGTM! Repository: rC Clang https://reviews.llvm.org/D42001 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D40737: [clang-tidy] Resubmit hicpp-multiway-paths-covered without breaking test

JonasToth added a comment. @sbenza and/or @klimek did you have time to address the stackoverflow caused from the ASTMatchers? I forgot to add the link to the original break:

[PATCH] D41998: [clang-tidy] Expand readability-redundant-smartptr-get to understand implicit converions to bool in more contexts.

sbenza created this revision. sbenza added a reviewer: hokein. Herald added subscribers: cfe-commits, xazax.hun, klimek. Expand readability-redundant-smartptr-get to understand implicit converions to bool in more contexts. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D41998

[PATCH] D41815: [clang-tidy] implement check for goto

JonasToth marked 3 inline comments as done. JonasToth added inline comments. Comment at: clang-tidy/cppcoreguidelines/AvoidGotoCheck.cpp:20 + +AST_MATCHER(GotoStmt, isForwardJumping) { + lebedev.ri wrote: > JonasToth wrote: > > lebedev.ri wrote: > > > It would

[PATCH] D42004: [Driver] Suggest valid integrated tools

modocache created this revision. modocache added reviewers: sepavloff, bkramer, phosek. There are only two valid integrated Clang driver tools: `-cc1` and `-cc1as`. If a user asks for an unknown tool, such as `-cc1asphalt`, an error message is displayed to indicate that there is no such tool, but

[PATCH] D40023: [RISCV] Implement ABI lowering

asb added inline comments. Comment at: lib/CodeGen/CGCall.cpp:1937 +RetAttrs.addAttribute(llvm::Attribute::ZExt); +} // FALL THROUGH rjmccall wrote: > asb wrote: > > rjmccall wrote: > > > I feel like a better design would be to record whether to

[PATCH] D39074: [libunwind][MIPS]: Add support for unwinding in N32 processes.

bsdjhb added a comment. To be clear, are you getting the failure running libunwind's test suite or your own test? I've managed to get libunwind to cross-compile for me using GCC 6.3.0 on FreeBSD for O32, N32, and N64, but only to build the library, not the tests. I've been running a simple

[PATCH] D39074: [libunwind][MIPS]: Add support for unwinding in N32 processes.

sdardis added a comment. This was libunwind's test suite: Compiled test failed unexpectedly! Testing Time: 0.53s Failing Tests (1): libunwind :: libunwind_02.pass.cpp Expected Passes: 3 Unexpected Failures: 1 The hacky

r322393 - [OPENMP] Replace calls of getAssociatedStmt().

Author: abataev Date: Fri Jan 12 11:39:11 2018 New Revision: 322393 URL: http://llvm.org/viewvc/llvm-project?rev=322393=rev Log: [OPENMP] Replace calls of getAssociatedStmt(). getAssociatedStmt() returns the outermost captured statement for the OpenMP directive. It may return incorrect region in

[PATCH] D41384: [analyzer] Suppress false positive warnings form security.insecureAPI.strcpy

NoQ added inline comments. Comment at: lib/StaticAnalyzer/Checkers/CheckSecuritySyntaxOnly.cpp:517 +if (const auto *Array = dyn_cast( +DeclRef->getDecl()->getType().getTypePtr())) { + unsigned long long ArraySize = Array->getSize().getLimitedValue();

[PATCH] D40673: Add _Float128 as alias to __float128 to enable compilations on Fedora27/glibc2-26

nsz added a comment. In https://reviews.llvm.org/D40673#973638, @efriedma wrote: > > as this patch is committed clang is broken (cannot use glibc headers) > > This patch was supposed to *fix* compatibility with the glibc headers. If it > doesn't, we should clearly revert it... but we need to

[PATCH] D40023: [RISCV] Implement ABI lowering

asb updated this revision to Diff 129683. asb marked 8 inline comments as done. asb added a comment. Rebase after ABIArgInfo signext/zeroext refactoring https://reviews.llvm.org/D41999 / https://reviews.llvm.org/rL322396. We no longer need to modify CGCall.cpp for unsigned 32-bit return values

[PATCH] D41815: [clang-tidy] implement check for goto

JonasToth marked 5 inline comments as done. JonasToth added inline comments. Comment at: docs/ReleaseNotes.rst:63 + + The usage of ``goto`` has been discouraged for a long time and is diagnosed + with this check. Eugene.Zelenko wrote: > I think will be good

[PATCH] D40737: [clang-tidy] Resubmit hicpp-multiway-paths-covered without breaking test

JonasToth updated this revision to Diff 129686. JonasToth added a comment. - get up to date to 7.0 Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D40737 Files: clang-tidy/hicpp/CMakeLists.txt clang-tidy/hicpp/HICPPTidyModule.cpp

[PATCH] D41648: [clang-tidy] implement cppcoreguidelines macro rules

JonasToth updated this revision to Diff 129691. JonasToth added a comment. - minor issues fixed Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D41648 Files: clang-tidy/cppcoreguidelines/CMakeLists.txt clang-tidy/cppcoreguidelines/CppCoreGuidelinesTidyModule.cpp

[PATCH] D40023: [RISCV] Implement ABI lowering

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Thanks. LGTM, but you should wait for Eli's sign-off, too. https://reviews.llvm.org/D40023 ___ cfe-commits mailing list

[PATCH] D41976: Low-hanging fruit optimization in string::__move_assign().

vsk added reviewers: EricWF, mclow.lists, hiraditya. vsk added a comment. Adding some folks who may be interested. https://reviews.llvm.org/D41976 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D40023: [RISCV] Implement ABI lowering

efriedma accepted this revision. efriedma added a comment. LGTM Not sure if anyone's mentioned it yet, but there's a C ABI testing tool in clang/utils/ABITest/ which you'll probably want to try at some point. Comment at: lib/CodeGen/TargetInfo.cpp:8913 + } + return

[PATCH] D41746: Make std::get_temporary_buffer respect overaligned types when possible

ckennelly marked 2 inline comments as done. ckennelly added a comment. In https://reviews.llvm.org/D41746#973941, @EricWF wrote: > This LGTM minus nits. > > Is there a LWG issue or paper that specifies this change? or is it just a > general bug fix? This is just a general bug fix.

[PATCH] D41384: [analyzer] Suppress false positive warnings form security.insecureAPI.strcpy

This revision was automatically updated to reflect the committed changes. Closed by commit rL322410: [analyzer] Dont flag strcpy of string literals into sufficiently large buffers. (authored by dergachev, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D41935: [analyzer] NFC: Mark default constructors for ProgramPoints.

dcoughlin accepted this revision. dcoughlin added a comment. This revision is now accepted and ready to land. LGTM! Repository: rC Clang https://reviews.llvm.org/D41935 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r322414 - When rebuilding an InitListExpr, don't give it a type.

Author: rsmith Date: Fri Jan 12 14:21:33 2018 New Revision: 322414 URL: http://llvm.org/viewvc/llvm-project?rev=322414=rev Log: When rebuilding an InitListExpr, don't give it a type. InitListExprs without types (well, with type 'void') represent not-yet-analyzed initializer lists; InitListExpr

[PATCH] D42011: [DWARFv5] Enable MD5 checksums

This revision was automatically updated to reflect the committed changes. Closed by commit rC322413: [DWARFv5] Have -gdwarf-5 generate MD5 checksums (authored by probinson, committed by ). Changed prior to commit: https://reviews.llvm.org/D42011?vs=129703=129708#toc Repository: rC Clang

[PATCH] D42011: [DWARFv5] Enable MD5 checksums

This revision was automatically updated to reflect the committed changes. Closed by commit rL322413: [DWARFv5] Have -gdwarf-5 generate MD5 checksums (authored by probinson, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D42017: Link sanitized programs on NetBSD with -lkvm

krytarowski created this revision. krytarowski added reviewers: joerg, vitalybuka, dvyukov. krytarowski added a project: Sanitizers. Herald added a subscriber: llvm-commits. kvm - kernel memory interface This set of functions is defined in the libkvm library. The kvm(3) functions are used in

[PATCH] D41820: [coroutines] Pass coro func args to promise ctor

GorNishanov added a comment. In https://reviews.llvm.org/D41820#974116, @EricWF wrote: > Is this behavior specified somewhere? Or are we simply adding an extension to > Clang? If so I would really prefer to add my `co_promise` solution (but I > need to write a paper in favor of it first).

[PATCH] D42019: [Driver] Set default sysroot for Fuchsia if none is specified

mcgrathr added inline comments. Comment at: lib/Driver/ToolChains/Fuchsia.cpp:152 + llvm::sys::path::append(P, normalizeTriple(Triple)); + return P.str(); +} The GCC behavior (if --with-sysroot is given to configure) is tooldir/sys-root, not tooldir itself.

[PATCH] D40218: [Clang] Add __builtin_launder

EricWF updated this revision to Diff 129742. EricWF added a comment. - Improve diagnostic handling. https://reviews.llvm.org/D40218 Files: include/clang/Basic/Builtins.def include/clang/Basic/DiagnosticSemaKinds.td lib/AST/ExprConstant.cpp lib/CodeGen/CGBuiltin.cpp

[PATCH] D41816: [analyzer] Model and check unrepresentable left shifts

dcoughlin added a comment. The diagnostic text looks to me, but I do have a comment about the nested 'if' inline. Comment at: lib/StaticAnalyzer/Checkers/UndefResultChecker.cpp:150 +SB.getKnownValue(state, C.getSVal(B->getRHS())); +if ((unsigned)

[PATCH] D42014: Disable BinPackArguments and BinPackParameters in Google Objective-C style ⚙️

stephanemoore added a comment. I am still working to verify that this change represents actual consensus. I will hold off on adding reviewers until then. https://reviews.llvm.org/D42014 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: r321395 - [ODRHash] Support ODR violation detection in functions.

Seems to be working now. Thank you! On Thu, Jan 11, 2018 at 9:46 PM, Richard Trieu wrote: > Hi Vedant and Eric, > > Please retry after r322350. I suspect an interaction between templates > and friend functions is causing this issue. This revision disables hashing > for

[PATCH] D40560: [analyzer] Get construction into `operator new` running in simple cases.

dcoughlin accepted this revision. dcoughlin added a comment. This revision is now accepted and ready to land. LGTM with the TODO and the test case I requested inline. Comment at: lib/StaticAnalyzer/Core/ExprEngine.cpp:487 +if (const MemRegion *MR = I.second.getAsRegion())

[PATCH] D41977: [libc++] Fix PR20855 -- libc++ incorrectly diagnoses illegal reference binding in std::tuple.

EricWF added a comment. In https://reviews.llvm.org/D41977#975403, @rsmith wrote: > This will still diagnose valid and reasonable programs, such as: > > struct ConvertToRef { operator int&(); }; > std::tuple t = {ConvertToRef()}; > > > ... on compilers that don't provide the trait. You

[PATCH] D41977: [libc++] Fix PR20855 -- libc++ incorrectly diagnoses illegal reference binding in std::tuple.

EricWF updated this revision to Diff 129744. EricWF added a comment. - Address @rsmith's comments by removing the fallback implementation of the diagnostics. https://reviews.llvm.org/D41977 Files: include/tuple test/libcxx/utilities/tuple/tuple.tuple/diagnose_reference_binding.fail.cpp

  1   2   >