[PATCH] D42071: [Sema] Add visited contexts to CodeCompleteContext

hokein updated this revision to Diff 130155. hokein marked 5 inline comments as done. hokein retitled this revision from " [Sema] Add visited contexts to CodeCompleteContext" to "[Sema] Add visited contexts to CodeCompleteContext". hokein edited the summary of this revision. hokein added a

[PATCH] D42177: DO NOT SUBMIT. Combined diff of D42174 and D42173.

ilya-biryukov created this revision. Herald added subscribers: cfe-commits, klimek. To simplify review of both changes. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D42177 Files: clangd/ClangdServer.cpp clangd/ClangdServer.h clangd/ClangdUnit.cpp clangd/ClangdUnit.h

[PATCH] D42168: [OpenMP] Generate unique name for offloading entries

Hahnfeld added a comment. In https://reviews.llvm.org/D42168#978593, @ABataev wrote: > After some investigation, I think this whole code is incorrect. We should not > rely on the fact that there is no padding on some architectures and should > mix the type generated by the Clang and initial

[PATCH] D42174: [clangd] Refactored threading in ClangdServer

ilya-biryukov created this revision. ilya-biryukov added reviewers: sammccall, bkramer. Herald added a subscriber: klimek. We now provide an abstraction of Scheduler that abstracts threading and resource management in ClangdServer. No changes to behavior are intended with an exception of changed

[PATCH] D42173: [clangd] Simplify code handling compile commands

ilya-biryukov created this revision. ilya-biryukov added reviewers: sammccall, bkramer. Herald added a subscriber: klimek. CppFile can now change compilation arguments during rebuild. This allows simplifying code that manages CppFiles. Repository: rCTE Clang Tools Extra

Re: [libcxx] r321963 - Add pre-C++11 is_constructible wrappers for 3 arguments

Merged to 6.0 in r322659. On Sun, Jan 7, 2018 at 5:45 PM, Dimitry Andric via cfe-commits wrote: > Author: dim > Date: Sun Jan 7 08:45:11 2018 > New Revision: 321963 > > URL: http://llvm.org/viewvc/llvm-project?rev=321963=rev > Log: > Add pre-C++11 is_constructible

RE: [PATCH] D41837: Add Function multiversion to the release notes.

It did not, I held it until just after the branch was made. -Original Message- From: hwennb...@google.com [mailto:hwennb...@google.com] On Behalf Of Hans Wennborg Sent: Wednesday, January 17, 2018 4:47 AM To: reviews+d41837+public+36225483e5851...@reviews.llvm.org Cc: Keane, Erich

[PATCH] D32860: [Analyzer] Iterator Checker - Part 6: Mismatched iterator checker for constructors and comparisons

baloghadamsoftware updated this revision to Diff 130186. baloghadamsoftware added a comment. Rebased. https://reviews.llvm.org/D32860 Files: lib/StaticAnalyzer/Checkers/IteratorChecker.cpp test/Analysis/mismatched-iterator.cpp Index: test/Analysis/mismatched-iterator.cpp

Re: [PATCH] D42157: [clang-cl] Let /FA output use intel assembly.

Hi Nico, On 17 January 2018 at 14:35, Nico Weber via Phabricator via cfe-commits wrote: > thakis closed this revision. > thakis added a comment. > > r322652, thanks! This commit broke ARM bots: http://lab.llvm.org:8011/builders/clang-cmake-armv7-a15/builds/14839

[PATCH] D42168: [OpenMP] Generate unique name for offloading entries

ABataev added a comment. Or, there is another one solution - mark `_tgt_offload_entry` record as packed. Repository: rC Clang https://reviews.llvm.org/D42168 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D42113: [clangd] Deduplicate symbols collected in global-symbol-builder tool.

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Herald added a reviewer: jkorous-apple. Comment at: clangd/global-symbol-builder/GlobalSymbolBuilderMain.cpp:109 + // Deduplicate the result by key. + //

[PATCH] D42170: Fixit for 'typedef' instead of 'typename' typo

jkorous-apple created this revision. https://reviews.llvm.org/D42170 Files: Parse/ParseTemplate.cpp Parser/typedef-instead-of-typename-typo.hpp clang/Basic/DiagnosticParseKinds.td Index: Parser/typedef-instead-of-typename-typo.hpp

[PATCH] D41947: Provide default virtual filesystem argument to ClangTool constructor

ilya-biryukov added a comment. LGTM, but could we add a test that checks the VFS is actually used? Repository: rC Clang https://reviews.llvm.org/D41947 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r322661 - [Sema] Add visited contexts to CodeCompleteContext

Author: hokein Date: Wed Jan 17 06:29:25 2018 New Revision: 322661 URL: http://llvm.org/viewvc/llvm-project?rev=322661=rev Log: [Sema] Add visited contexts to CodeCompleteContext Summary: This would allow code completion clients to know which context is visited during Sema code completion.

[PATCH] D42168: [OpenMP] Generate unique name for offloading entries

ABataev added a comment. After some investigation, I think this whole code is incorrect. We should not rely on the fact that there is no padding on some architectures and should mix the type generated by the Clang and initial value, generated by LLVM. Repository: rC Clang

[PATCH] D42185: [ASTMatcher] Add isScoped matcher for enumDecl.

hokein created this revision. hokein added a reviewer: bkramer. Herald added a subscriber: klimek. No doc update on the LibASTMatchersReference.html - The dump_ast_matchers.py script has been broken since r318304. Repository: rC Clang https://reviews.llvm.org/D42185 Files:

[PATCH] D41271: [RISCV] Propagate -mabi and -march values to GNU assembler.

asb added a comment. In https://reviews.llvm.org/D41271#977222, @apazos wrote: > I tested this on windows and I had to add an assembler placeholder > executable, just like it was done with the linker in the RISCV multilib dir > checked under Inputs. > Other observations, are these known

[PATCH] D41708: [clang-tidy] Update fuchsia-overloaded-operator to check for valid loc

hans added a comment. In https://reviews.llvm.org/D41708#978186, @alexfh wrote: > In https://reviews.llvm.org/D41708#977000, @hans wrote: > > > Alex, do you think the fix is still OK for the 6.0 branch? Let me know, and > > I'll merge it. > > > Yes, please. Thank you! Oh, it was already

Re: [PATCH] D41837: Add Function multiversion to the release notes.

OK, thanks for clarifying. On Wed, Jan 17, 2018 at 4:18 PM, Keane, Erich wrote: > It did not, I held it until just after the branch was made. > > -Original Message- > From: hwennb...@google.com [mailto:hwennb...@google.com] On Behalf Of Hans > Wennborg > Sent:

[PATCH] D41760: Introduce __builtin_load_no_speculate

kristof.beyls added a comment. The API design has been discussed over the past weeks in detail on the gcc mailing list. As a result of that, we propose to adapt the API, to enable efficient code generation also on architectures that need to generate a barrier instruction to achieve the desired

[PATCH] D42185: [ASTMatcher] Add isScoped matcher for enumDecl.

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. lg Repository: rC Clang https://reviews.llvm.org/D42185 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: r321777 - PR35028: Retain duplicate alignas attributes in template instantiation.

Merged to 6.0 in r322676. On Thu, Jan 4, 2018 at 2:02 AM, Richard Smith via cfe-commits wrote: > Author: rsmith > Date: Wed Jan 3 17:02:18 2018 > New Revision: 321777 > > URL: http://llvm.org/viewvc/llvm-project?rev=321777=rev > Log: > PR35028: Retain duplicate

[libcxx] r322659 - Merging r321963:

Author: hans Date: Wed Jan 17 06:26:10 2018 New Revision: 322659 URL: http://llvm.org/viewvc/llvm-project?rev=322659=rev Log: Merging r321963: r321963 | dim | 2018-01-07 08:45:11 -0800 (Sun, 07 Jan 2018) | 51 lines Add

[PATCH] D41535: Add -vfsoverlay option for Clang-Tidy

vladimir.plyashkun added a comment. Friendly ping Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D41535 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D41921: [Parse] Forward brace locations to TypeConstructExpr

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! https://reviews.llvm.org/D41921 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D32845: [Analyzer] Iterator Checker - Part 4: Mismatched iterator checker for function parameters

baloghadamsoftware updated this revision to Diff 130174. baloghadamsoftware marked an inline comment as done. baloghadamsoftware added a comment. Updated according to some comments. https://reviews.llvm.org/D32845 Files: include/clang/StaticAnalyzer/Checkers/Checkers.td

[PATCH] D41991: [clangd] Always use preamble (even stale) for code completion

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Herald added a reviewer: jkorous-apple. Big +1 to the change here. Just suggestions for the comments. Comment at: clangd/CodeComplete.cpp:522 - // Attempt to reuse

[PATCH] D42167: [clang-format] adds enclosing function detection to raw string formatting

This revision was automatically updated to reflect the committed changes. Closed by commit rC322678: [clang-format] adds enclosing function detection to raw string formatting (authored by krasimir, committed by ). Changed prior to commit: https://reviews.llvm.org/D42167?vs=130177=130191#toc

[PATCH] D42167: [clang-format] adds enclosing function detection to raw string formatting

This revision was automatically updated to reflect the committed changes. Closed by commit rL322678: [clang-format] adds enclosing function detection to raw string formatting (authored by krasimir, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM

[PATCH] D42135: [Format] Improve ObjC header guessing heuristic

benhamilton updated this revision to Diff 130192. benhamilton added a comment. - Remove unused variable. Repository: rC Clang https://reviews.llvm.org/D42135 Files: lib/Format/Format.cpp unittests/Format/FormatTestObjC.cpp Index: unittests/Format/FormatTestObjC.cpp

[PATCH] D41852: [clang-tidy] Don't generate fix for argument constructed from std::initializer_list.

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM modulo a change to the 'initializer_list.h'. Do we really need it for this patch? Comment at:

[PATCH] D41991: [clangd] Always use preamble (even stale) for code completion

ilya-biryukov updated this revision to Diff 130193. ilya-biryukov added a comment. - Rewrote the comment for prepareCompilerInstance - Call CanReuse() and discard its results. We have clients that rely on having the stat() calls for files from preamble Repository: rCTE Clang Tools Extra

[PATCH] D42071: [Sema] Add visited contexts to CodeCompleteContext

This revision was automatically updated to reflect the committed changes. Closed by commit rC322661: [Sema] Add visited contexts to CodeCompleteContext (authored by hokein, committed by ). Changed prior to commit: https://reviews.llvm.org/D42071?vs=130155=130170#toc Repository: rC Clang

[clang-tools-extra] r322668 - [clangd] Avoid divide-by-zero

Author: sammccall Date: Wed Jan 17 07:25:55 2018 New Revision: 322668 URL: http://llvm.org/viewvc/llvm-project?rev=322668=rev Log: [clangd] Avoid divide-by-zero Modified: clang-tools-extra/trunk/clangd/FuzzyMatch.cpp Modified: clang-tools-extra/trunk/clangd/FuzzyMatch.cpp URL:

[PATCH] D16403: Add scope information to CFG

m.ostapenko updated this revision to Diff 130183. m.ostapenko retitled this revision from "Add scope information to CFG for If/While/For/Do/Compound/CXXRangeFor statements" to "Add scope information to CFG". m.ostapenko added a comment. Some code cleanup + updated test case.

r322672 - [Index] Fix GCC warning. This is silly, but no llvm_unreachable and no C99.

Author: sammccall Date: Wed Jan 17 07:57:14 2018 New Revision: 322672 URL: http://llvm.org/viewvc/llvm-project?rev=322672=rev Log: [Index] Fix GCC warning. This is silly, but no llvm_unreachable and no C99. Modified: cfe/trunk/tools/c-index-test/c-index-test.c Modified:

Re: r322549 - Squash -Wcovered-switch-default wairning

Fixed in r322672. (Slightly awkwardly, because we don't have llvm_unreachable in C) On Tue, Jan 16, 2018 at 11:52 PM, Galina Kistanova wrote: > Hello Sam, > > This commit broke one of our builders: > http://lab.llvm.org:8011/builders/ubuntu-gcc7.1-werror/builds/4517 > > .

r322674 - Attempt to fix test/Driver/masm.c on the ARM bots.

Author: nico Date: Wed Jan 17 08:03:08 2018 New Revision: 322674 URL: http://llvm.org/viewvc/llvm-project?rev=322674=rev Log: Attempt to fix test/Driver/masm.c on the ARM bots. Modified: cfe/trunk/test/Driver/masm.c Modified: cfe/trunk/test/Driver/masm.c URL:

Re: r322246 - [X86] Fix vpshrd builtins to require an ICE for their constant argument to match vpshld.

Merged to 6.0 in r322682. On Thu, Jan 11, 2018 at 2:38 AM, Craig Topper via cfe-commits wrote: > Author: ctopper > Date: Wed Jan 10 17:38:00 2018 > New Revision: 322246 > > URL: http://llvm.org/viewvc/llvm-project?rev=322246=rev > Log: > [X86] Fix vpshrd builtins to

[PATCH] D42111: [Tooling] Don't deduplicate tool results in the All-TUs executor.

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. lg Repository: rC Clang https://reviews.llvm.org/D42111 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D42167: [clang-format] adds enclosing function detection to raw string formatting

bkramer added inline comments. Comment at: lib/Format/ContinuationIndenter.cpp:1454 +// found. +static StringRef getEnclosingFunctionName(const FormatToken& Current) { + // Look for: 'function(' or 'function(' before Current. This function doesn't look

[PATCH] D42181: [clangd] Merge index-provided completions with those from Sema.

sammccall created this revision. sammccall added a reviewer: ioeric. Herald added subscribers: cfe-commits, mgrang, ilya-biryukov, klimek. - we match on USR, and do a field-by-field merge if both have results - scoring is post-merge, with both sets of information available (for now, sema

[PATCH] D41074: [ClangFormat] ObjCSpaceBeforeProtocolList should be true in the google style

benhamilton added a comment. Any way we can get an accept on this one? Repository: rC Clang https://reviews.llvm.org/D41074 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D42185: [ASTMatcher] Add isScoped matcher for enumDecl.

aaron.ballman requested changes to this revision. aaron.ballman added a comment. This revision now requires changes to proceed. This needs to be added to the dynamic matcher registry and also should not be commit until the documentation is generated for it. Comment at:

[PATCH] D42071: [Sema] Add visited contexts to CodeCompleteContext

hokein added inline comments. Comment at: include/clang/Sema/CodeCompleteConsumer.h:271 + using VisitedContextSet = llvm::SmallPtrSet; + ilya-biryukov wrote: > Given that lookup does not visit the same `DeclContext` twice, we're probably >

[PATCH] D42167: [clang-format] adds enclosing function detection to raw string formatting

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. lgtm Repository: rC Clang https://reviews.llvm.org/D42167 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D42116: [clang-tidy] Adding Fuchsia checker for trailing returns

aaron.ballman added inline comments. Comment at: clang-tidy/fuchsia/TrailingReturnCheck.cpp:23 + const auto *F = cast(T); + return F->hasTrailingReturn(); +} I'd rewrite this as: `return Node.getType()->castAs()->hasTrailingReturnType();`

[PATCH] D32859: [Analyzer] Iterator Checker - Part 5: Move Assignment of Containers

baloghadamsoftware updated this revision to Diff 130185. baloghadamsoftware added a comment. Rebased. https://reviews.llvm.org/D32859 Files: lib/StaticAnalyzer/Checkers/IteratorChecker.cpp test/Analysis/mismatched-iterator.cpp Index: test/Analysis/mismatched-iterator.cpp

[PATCH] D42168: [OpenMP] Generate unique name for offloading entries

ABataev added a comment. In https://reviews.llvm.org/D42168#978594, @Hahnfeld wrote: > In https://reviews.llvm.org/D42168#978593, @ABataev wrote: > > > After some investigation, I think this whole code is incorrect. We should > > not rely on the fact that there is no padding on some

r322678 - [clang-format] adds enclosing function detection to raw string formatting

Author: krasimir Date: Wed Jan 17 08:17:26 2018 New Revision: 322678 URL: http://llvm.org/viewvc/llvm-project?rev=322678=rev Log: [clang-format] adds enclosing function detection to raw string formatting Summary: This patch adds enclosing function detection to raw string formatting. Reviewers:

[PATCH] D42167: [clang-format] adds enclosing function detection to raw string formatting

krasimir updated this revision to Diff 130177. krasimir added a comment. - Format a function Repository: rC Clang https://reviews.llvm.org/D42167 Files: docs/ClangFormatStyleOptions.rst include/clang/Format/Format.h lib/Format/ContinuationIndenter.cpp

[PATCH] D42174: [clangd] Refactored threading in ClangdServer

bkramer added inline comments. Comment at: clangd/ClangdServer.h:107 +/// A simple fixed-size thread pool implementation. +class SimpleThreadPool { public: What's so simple about it? Why not `clangd::ThreadPool`? Also there's `llvm::ThreadPool`, what's the

Re: [PATCH] D42157: [clang-cl] Let /FA output use intel assembly.

r322674 attempts to fix. On Wed, Jan 17, 2018 at 10:54 AM, Yvan Roux via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Hi Nico, > > On 17 January 2018 at 14:35, Nico Weber via Phabricator via > cfe-commits wrote: > > thakis closed this revision. > > thakis added

[PATCH] D42168: [OpenMP] Generate unique name for offloading entries

ABataev added a comment. 1. Please, mark the record as packed. 2. Tests Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:3576-3577 EntryInit.addInt(CGM.Int32Ty, 0); - llvm::GlobalVariable *Entry = -EntryInit.finishAndCreateGlobal(".omp_offloading.entry", -

Re: r321779 - PR35045: Convert injected-class-name to its corresponding simple-template-id

Merged to 6.0 in r322677. On Thu, Jan 4, 2018 at 2:24 AM, Richard Smith via cfe-commits wrote: > Author: rsmith > Date: Wed Jan 3 17:24:17 2018 > New Revision: 321779 > > URL: http://llvm.org/viewvc/llvm-project?rev=321779=rev > Log: > PR35045: Convert

[PATCH] D42157: [clang-cl] Let /FA output use intel assembly.

seurer added a comment. This patch fails on powerpc64 http://lab.llvm.org:8011/builders/clang-ppc64be-linux/builds/14380 http://lab.llvm.org:8011/builders/clang-ppc64le-linux/builds/13463 - TEST 'Clang :: Driver/masm.c' FAILED Script: ---

r322687 - Update dump_ast_matchers for many recent changes.

Author: d0k Date: Wed Jan 17 08:50:14 2018 New Revision: 322687 URL: http://llvm.org/viewvc/llvm-project?rev=322687=rev Log: Update dump_ast_matchers for many recent changes. The html file hasn't been updated in a long time so there are quite a few changes in there. No matchers were removed

[PATCH] D42173: [clangd] Simplify code handling compile commands

sammccall added a comment. This looks better overall to me. I'm not sure about clangdserver rather than clangdunit computing the commands. You're probably right but I'd like you to explain it to me :-) Rest is just readability nits. Comment at: clangd/ClangdServer.cpp:35

[PATCH] D41946: [clangd] Add support for different file URI schemas.

ioeric updated this revision to Diff 130201. ioeric marked 17 inline comments as done. ioeric added a comment. Herald added a reviewer: jkorous-apple. - Addressed review comments. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D41946 Files: clangd/CMakeLists.txt

[PATCH] D42116: [clang-tidy] Adding Fuchsia checker for trailing returns

juliehockett updated this revision to Diff 130200. juliehockett marked 8 inline comments as done. juliehockett added a comment. Updating matchers & fixing comments https://reviews.llvm.org/D42116 Files: clang-tidy/fuchsia/CMakeLists.txt clang-tidy/fuchsia/FuchsiaTidyModule.cpp

[PATCH] D41991: [clangd] Always use preamble (even stale) for code completion

ilya-biryukov updated this revision to Diff 130206. ilya-biryukov marked an inline comment as done. ilya-biryukov added a comment. - s/buffer for MainFile/MainFile/ Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D41991 Files: clangd/CodeComplete.cpp clangd/Compiler.cpp

[PATCH] D42106: [analyzer] Remove the useless method declararion 'BugReporter::RemoveUnneededCalls()'.

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Yep, weird. Thanks :) Repository: rC Clang https://reviews.llvm.org/D42106 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D41938: [Analyzer] SValBuilder Comparison Rearrangement (with Restrictions and Analyzer Option)

NoQ added a comment. I think it'd be fine to do the rearrangement for additive ops without the option check, as we discussed. I.e., rearrange when it's either an additive op, or both the flag is set and the values are overflow-clamped. And remove the clamp checks (which are presumably heavy)

r322729 - [Parse] Forward brace locations to TypeConstructExpr

Author: vedantk Date: Wed Jan 17 10:53:51 2018 New Revision: 322729 URL: http://llvm.org/viewvc/llvm-project?rev=322729=rev Log: [Parse] Forward brace locations to TypeConstructExpr When parsing C++ type construction expressions with list initialization, forward the locations of the braces to

[PATCH] D42116: [clang-tidy] Adding Fuchsia checker for trailing returns

aaron.ballman added inline comments. Comment at: clang-tidy/fuchsia/TrailingReturnCheck.cpp:25 + +AST_TYPE_MATCHER(DecltypeType, decltypeType); + Good try, but if you rebase, you'll find that this macro has gone away entirely in r322687. I believe this macro

[PATCH] D41946: [clangd] Add support for different file URI schemas.

sammccall added a comment. Few more interface nits, sorry for picking here! Will get through the impl in the morning. Comment at: clangd/URI.cpp:43 + Body.consume_front("/"); +return llvm::sys::path::convert_to_slash(Body); + } Don't you want the

[PATCH] D41455: [ASTMatchers] Add isNoReturn() match narrower for FunctionDeclarations

aaron.ballman added a comment. Great, looks good to commit. Thanks, Roman! Repository: rC Clang https://reviews.llvm.org/D41455 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D41788: [DeclPrinter] Fix two cases that crash clang -ast-print.

This revision was automatically updated to reflect the committed changes. Closed by commit rL322742: [DeclPrinter] Fix two cases that crash clang -ast-print. (authored by tra, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D42146: libcxx: Disable CFI in function std::get_temporary_buffer.

This revision was automatically updated to reflect the committed changes. Closed by commit rCXX322744: libcxx: Disable CFI in function std::get_temporary_buffer. (authored by pcc, committed by ). Herald added a subscriber: cfe-commits. Changed prior to commit:

[PATCH] D42187: [clang-format] Adds a canonical delimiter to raw string formatting

krasimir created this revision. Herald added subscribers: cfe-commits, klimek. This patch adds canonical delimiter support to the raw string formatting. This allows matching delimiters to be updated to the canonical one. Repository: rC Clang https://reviews.llvm.org/D42187 Files:

[PATCH] D41921: [Parse] Forward brace locations to TypeConstructExpr

This revision was automatically updated to reflect the committed changes. Closed by commit rC322729: [Parse] Forward brace locations to TypeConstructExpr (authored by vedantk, committed by ). Changed prior to commit: https://reviews.llvm.org/D41921?vs=130021=130216#toc Repository: rC Clang

r322746 - [ASTMatchers] Add isNoReturn() match narrower for FunctionDeclarations

Author: lebedevri Date: Wed Jan 17 11:40:55 2018 New Revision: 322746 URL: http://llvm.org/viewvc/llvm-project?rev=322746=rev Log: [ASTMatchers] Add isNoReturn() match narrower for FunctionDeclarations Reviewers: aaron.ballman Reviewed By: aaron.ballman Subscribers: dblaikie, klimek,

[PATCH] D41455: [ASTMatchers] Add isNoReturn() match narrower for FunctionDeclarations

This revision was automatically updated to reflect the committed changes. Closed by commit rL322746: [ASTMatchers] Add isNoReturn() match narrower for FunctionDeclarations (authored by lebedevri, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D41991: [clangd] Always use preamble (even stale) for code completion

ilya-biryukov updated this revision to Diff 130195. ilya-biryukov added a comment. - Fixed a typo Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D41991 Files: clangd/CodeComplete.cpp clangd/Compiler.cpp clangd/Compiler.h Index: clangd/Compiler.h

[PATCH] D42168: [OpenMP] Generate unique name for offloading entries

Hahnfeld marked an inline comment as done. Hahnfeld added a comment. In https://reviews.llvm.org/D42168#978634, @ABataev wrote: > 1. Please, mark the record as packed. Where and how do I need to do this? I found that `PackedAttr` is checked on `FieldDecl`s but I'm not sure if we go through

[libunwind] r322717 - Creating release candidate rc1 from release_600 branch

Author: hans Date: Wed Jan 17 09:50:33 2018 New Revision: 322717 URL: http://llvm.org/viewvc/llvm-project?rev=322717=rev Log: Creating release candidate rc1 from release_600 branch Added: libunwind/tags/RELEASE_600/rc1/ - copied from r322716, libunwind/branches/release_60/

[libunwind] r322716 - Creating release directory for release_600.

Author: hans Date: Wed Jan 17 09:50:33 2018 New Revision: 322716 URL: http://llvm.org/viewvc/llvm-project?rev=322716=rev Log: Creating release directory for release_600. Added: libunwind/tags/RELEASE_600/ ___ cfe-commits mailing list

[PATCH] D41455: [ASTMatchers] Add isNoReturn() match narrower for FunctionDeclarations

lebedev.ri updated this revision to Diff 130220. lebedev.ri edited the summary of this revision. lebedev.ri added a comment. - rebased - finally updated docs - found a new bug in doc generator https://bugs.llvm.org/show_bug.cgi?id=35989 Going to finally land this. Repository: rC Clang

[PATCH] D41455: [ASTMatchers] Add isNoReturn() match narrower for FunctionDeclarations

lebedev.ri updated this revision to Diff 130221. lebedev.ri added a comment. Update extra newline that prevented full documentation generation :/ Repository: rC Clang https://reviews.llvm.org/D41455 Files: docs/LibASTMatchersReference.html include/clang/ASTMatchers/ASTMatchers.h

[PATCH] D42043: c-index: CXString: fix MSAN read-past-end bug

elsteveogrande updated this revision to Diff 130225. elsteveogrande added a comment. Add a needed null-check on input string's data ptr. Repository: rC Clang https://reviews.llvm.org/D42043 Files: include/clang-c/CXString.h tools/c-index-test/c-index-test.c tools/libclang/CXString.cpp

[PATCH] D42185: [ASTMatcher] Add isScoped matcher for enumDecl.

bkramer requested changes to this revision. bkramer added a comment. dump_ast_matchers.py should be working again now. Repository: rC Clang https://reviews.llvm.org/D42185 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D42135: [Format] Improve ObjC header guessing heuristic

benhamilton updated this revision to Diff 130202. benhamilton added a comment. Use unordered_set, consolidate at-token checks Repository: rC Clang https://reviews.llvm.org/D42135 Files: lib/Format/Format.cpp unittests/Format/FormatTestObjC.cpp Index: unittests/Format/FormatTestObjC.cpp

r322691 - [Tooling] Don't deduplicate tool results in the All-TUs executor.

Author: ioeric Date: Wed Jan 17 09:37:11 2018 New Revision: 322691 URL: http://llvm.org/viewvc/llvm-project?rev=322691=rev Log: [Tooling] Don't deduplicate tool results in the All-TUs executor. Summary: As result deduplication or reduction is not supported in the framework, we should leave the

[PATCH] D42111: [Tooling] Don't deduplicate tool results in the All-TUs executor.

This revision was automatically updated to reflect the committed changes. Closed by commit rC322691: [Tooling] Dont deduplicate tool results in the All-TUs executor. (authored by ioeric, committed by ). Changed prior to commit: https://reviews.llvm.org/D42111?vs=129982=130204#toc Repository:

[PATCH] D41455: [ASTMatchers] Add isNoReturn() match narrower for FunctionDeclarations

lebedev.ri updated this revision to Diff 130228. lebedev.ri marked an inline comment as done. lebedev.ri added a comment. Address review note: reduce amount of examples in documentation. Repository: rC Clang https://reviews.llvm.org/D41455 Files: docs/LibASTMatchersReference.html

[PATCH] D42189: [clang-format] Replace unordered_set with an array

benhamilton accepted this revision. benhamilton added a comment. This revision is now accepted and ready to land. Thanks, this is smarter. Repository: rC Clang https://reviews.llvm.org/D42189 ___ cfe-commits mailing list

[PATCH] D42189: [clang-format] Replace unordered_set with an array

benhamilton added inline comments. Comment at: lib/Format/Format.cpp:1424 const AdditionalKeywords ) { -static const std::unordered_set FoundationIdentifiers = { +static constexpr llvm::StringLiteral FoundationIdentifiers[] = {

[PATCH] D41535: Add -vfsoverlay option for Clang-Tidy

ilya-biryukov requested changes to this revision. ilya-biryukov added a comment. This revision now requires changes to proceed. Sorry for the delay Comment at: clang-tidy/ClangTidy.cpp:93 +vfs::OverlayFileSystem ) { + if (OverlayFile.empty()) +

Re: [PATCH] D42157: [clang-cl] Let /FA output use intel assembly.

On 17 January 2018 at 17:05, Nico Weber wrote: > r322674 attempts to fix. Fixed on ARM bots. Thanks > On Wed, Jan 17, 2018 at 10:54 AM, Yvan Roux via cfe-commits > wrote: >> >> Hi Nico, >> >> On 17 January 2018 at 14:35, Nico Weber via

[PATCH] D42174: [clangd] Refactored threading in ClangdServer

ilya-biryukov added inline comments. Comment at: clangd/ClangdServer.h:107 +/// A simple fixed-size thread pool implementation. +class SimpleThreadPool { public: bkramer wrote: > What's so simple about it? Why not `clangd::ThreadPool`? > > Also there's

[PATCH] D41946: [clangd] Add support for different file URI schemas.

ioeric added a comment. Thanks for the comments! I've refactored the code according to your suggestions. PTAL Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D41946 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D42189: [clang-format] Replace unordered_set with an array

bkramer added inline comments. Comment at: lib/Format/Format.cpp:1424 const AdditionalKeywords ) { -static const std::unordered_set FoundationIdentifiers = { +static const llvm::ArrayRef FoundationIdentifiers = { "CGFloat",

[PATCH] D42192: [analyzer] Assume that the allocated value is non-null before construction, not after.

NoQ created this revision. NoQ added reviewers: dcoughlin, xazax.hun, a.sidorin, george.karpenkov, szepet. Herald added subscribers: cfe-commits, rnkovacs. In the `c++-allocator-inlining=true` mode, we need to make the assumption that the conservatively evaluated operator new() has returned a

[libcxx] r322744 - libcxx: Disable CFI in function std::get_temporary_buffer.

Author: pcc Date: Wed Jan 17 11:32:35 2018 New Revision: 322744 URL: http://llvm.org/viewvc/llvm-project?rev=322744=rev Log: libcxx: Disable CFI in function std::get_temporary_buffer. The specification of this function mandates a cast to uninitialized T*, which is forbidden under CFI.

[PATCH] D41852: [clang-tidy] Don't generate fix for argument constructed from std::initializer_list.

hokein marked an inline comment as done. hokein added inline comments. Comment at: test/clang-tidy/Inputs/modernize-smart-ptr/initializer_list.h:30 vector(initializer_list<_E> init); + ~vector(); }; ilya-biryukov wrote: > Why do we need to add this

[clang-tools-extra] r322692 - [clang-tidy] Fixing Fuchsia overloaded operator warning message

Author: juliehockett Date: Wed Jan 17 09:41:50 2018 New Revision: 322692 URL: http://llvm.org/viewvc/llvm-project?rev=322692=rev Log: [clang-tidy] Fixing Fuchsia overloaded operator warning message Updating Fuchsia overloaded operator warning message for clarity. Differential Revision:

[PATCH] D42189: [clang-format] Replace unordered_set with an array

krasimir updated this revision to Diff 130223. krasimir added a comment. - Address review comment Repository: rC Clang https://reviews.llvm.org/D42189 Files: lib/Format/Format.cpp Index: lib/Format/Format.cpp === ---

[PATCH] D42168: [OpenMP] Generate unique name for offloading entries

ABataev added a comment. In https://reviews.llvm.org/D42168#978689, @Hahnfeld wrote: > In https://reviews.llvm.org/D42168#978634, @ABataev wrote: > > > 1. Please, mark the record as packed. > > > Where and how do I need to do this? I found that `PackedAttr` is checked on > `FieldDecl`s but I'm

r322690 - [Format] Improve ObjC header guessing heuristic

Author: benhamilton Date: Wed Jan 17 09:33:08 2018 New Revision: 322690 URL: http://llvm.org/viewvc/llvm-project?rev=322690=rev Log: [Format] Improve ObjC header guessing heuristic Summary: This improves upon the previous Objective-C header guessing heuristic from rC320479. Now, we run the

[PATCH] D42135: [Format] Improve ObjC header guessing heuristic

This revision was automatically updated to reflect the committed changes. Closed by commit rL322690: [Format] Improve ObjC header guessing heuristic (authored by benhamilton, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D42135 Files:

  1   2   3   >