ahatanak created this revision.
ahatanak added reviewers: rjmccall, vsk.
This patch fixes what looks like a bug in IRGen's member initialization where
it uses the alignment of a complete object instead of its non-virtual alignment
when emitting the base constructor.
For example, when emitting t
hokein added inline comments.
Comment at: clangd/tool/ClangdMain.cpp:131
+ "0 means no limit."),
+llvm::cl::init(100), llvm::cl::Hidden);
+
sammccall wrote:
> I think we probably want to keep the default at 0 for now. I'm fine with 100
> pe
hokein updated this revision to Diff 131394.
hokein marked 4 inline comments as done.
hokein added a comment.
Address review comments.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D42484
Files:
clangd/CodeComplete.cpp
clangd/index/Merge.cpp
clangd/tool/ClangdMain.cpp
u
ilya-biryukov accepted this revision.
ilya-biryukov added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D42491
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
Author: hokein
Date: Thu Jan 25 01:20:09 2018
New Revision: 323408
URL: http://llvm.org/viewvc/llvm-project?rev=323408&view=rev
Log:
[clangd] Limit completion results.
Summary:
* truncate symbols from static/dynamic index to the limited number
(which would save lots of cost in constructing the me
This revision was automatically updated to reflect the committed changes.
Closed by commit rL323408: [clangd] Limit completion results. (authored by
hokein, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D42484
Files:
clang-tools-extra/
ilya-biryukov added inline comments.
Comment at: clangd/ClangdLSPServer.cpp:302
+// FIXME: This function needs to be properly tested.
+void ClangdLSPServer::onChangeConfiguration(
simark wrote:
> ilya-biryukov wrote:
> > Are you planning to to address this FIXM
hans added a comment.
Thanks for looking into this!
Comment at: lib/Driver/ToolChains/Arch/X86.cpp:43
if (const Arg *A = Args.getLastArg(options::OPT__SLASH_arch)) {
+// Mapping built by looking at lib/Basic's X86TargetInfo::initFeatureMap().
I wonder
ioeric added inline comments.
Comment at: clangd/ClangdServer.h:324
+ /// Returns estimated memory usage for each of the currently files.
+ /// The order of results is unspecified.
s/currently/current/ ? or current open?
Comment at: clangd/
This revision was automatically updated to reflect the committed changes.
Closed by commit rL323410: [clangd] Disable typo correction when doing code
completion. (authored by hokein, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D42491
F
Author: hokein
Date: Thu Jan 25 01:44:06 2018
New Revision: 323410
URL: http://llvm.org/viewvc/llvm-project?rev=323410&view=rev
Log:
[clangd] Disable typo correction when doing code completion.
Reviewers: ilya-biryukov
Reviewed By: ilya-biryukov
Subscribers: klimek, jkorous-apple, cfe-commits,
This revision was automatically updated to reflect the committed changes.
Closed by commit rCTE323410: [clangd] Disable typo correction when doing code
completion. (authored by hokein, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D42491?vs=131286&id=131400#toc
Repository:
ilya-biryukov added inline comments.
Comment at: clangd/Context.h:163
+
+ template Context derive(Type &&Value) const && {
+static Key::type> Private;
s/`const &&`/`&&`
Comment at: clangd/Context.h:165
+static Key::type> Private;
+
Author: sdardis
Date: Thu Jan 25 02:09:33 2018
New Revision: 323412
URL: http://llvm.org/viewvc/llvm-project?rev=323412&view=rev
Log:
[Driver] Add support for mips32 and scudo
r317337 missed that scudo is supported on MIPS32, so permit that option for
MIPS32.
Reviewers: cryptoad, atanasyan
Diff
This revision was automatically updated to reflect the committed changes.
Closed by commit rL323412: [Driver] Add support for mips32 and scudo (authored
by sdardis, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D42416?vs=131047&id=131
xazax.hun accepted this revision.
xazax.hun added a comment.
This revision is now accepted and ready to land.
Overall looks good! Thanks for working on this!
Comment at: lib/AST/ExternalASTMerger.cpp:403
+ASTImporter *Importer = C.second;
+NamedDecl *ND = cast(Importer-
jolesiak requested changes to this revision.
jolesiak added inline comments.
This revision now requires changes to proceed.
Comment at: test/Format/lit.local.cfg:2-3
+# Suffixes supported by clang-format.
+config.suffixes = ['.cpp', '.h', '.m', '.mm', '.java', '.js', '.ts', '.pro
ilya-biryukov created this revision.
ilya-biryukov added a reviewer: sammccall.
Herald added subscribers: ioeric, jkorous-apple, klimek.
The new API allows tracing events to outlive individual Spans and
gives a guarantee that invididual Spans will be not be called from
multiple threads.
Reposito
xazax.hun updated this revision to Diff 131406.
xazax.hun marked 2 inline comments as done.
xazax.hun added a comment.
- Address review comments.
https://reviews.llvm.org/D42335
Files:
lib/AST/ASTImporter.cpp
unittests/AST/ASTImporterTest.cpp
Index: unittests/AST/ASTImporterTest.cpp
==
ilya-biryukov added a comment.
I've tried experimenting with that and came up with an alternative that has
less changes to the API. Could you take a look, too?
https://reviews.llvm.org/D42524
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D42499
_
ilya-biryukov updated this revision to Diff 131407.
ilya-biryukov added a comment.
- Remove redundant code
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D42524
Files:
clangd/JSONRPCDispatcher.cpp
clangd/Trace.cpp
clangd/Trace.h
Index: clangd/Trace.h
=
hokein added inline comments.
Comment at: clang-tidy/objc/PropertyDeclarationCheck.cpp:28
+enum NamingStyle {
+ StandardProperty = 1,
+ CategoryProperty = 2,
Please add documentation describing what these properties are.
Comment at: clang-tid
ilya-biryukov created this revision.
ilya-biryukov added a reviewer: sammccall.
Herald added subscribers: ioeric, jkorous-apple, klimek.
r322838 changed semantics for llvm::Optional that removes the
guarantee of setting the value to empty after move.
This change creates a wrapper around Optional t
sammccall added inline comments.
Comment at: clangd/Function.h:141
namespace detail {
+/// Optional-like type that sets its value to llvm::None when it was moved
+/// constructed from.
As noted in the thread I don't think this pulls its weight for us.
Swapping u
ilya-biryukov added a comment.
LG. Let's move the APIs to callbacks and start passing Contexts everywhere.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D42517
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llv
sammccall accepted this revision.
sammccall added a comment.
This revision is now accepted and ready to land.
Thanks for this cleanup!
The way we deal with ResourceDir still doesn't feel ideal, but that's no worse
here and everything else is better!
Comment at: clangd/ClangdS
ilya-biryukov updated this revision to Diff 131415.
ilya-biryukov marked 2 inline comments as done.
ilya-biryukov added a comment.
- Fixed review comments
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D42480
Files:
clangd/ClangdServer.cpp
clangd/ClangdServer.h
clangd/Clan
ilya-biryukov marked 2 inline comments as done.
ilya-biryukov added inline comments.
Comment at: clangd/ClangdServer.h:324
+ /// Returns estimated memory usage for each of the currently files.
+ /// The order of results is unspecified.
ioeric wrote:
> s/curre
ioeric accepted this revision.
ioeric added a comment.
This revision is now accepted and ready to land.
lg
Comment at: clangd/ClangdUnit.cpp:664
+ std::lock_guard Lock(Mutex);
+ return ASTMemUsage + PreambleMemUsage;
+}
ilya-biryukov wrote:
> ioeric wrote:
>
ilya-biryukov added inline comments.
Comment at: clangd/Function.h:141
namespace detail {
+/// Optional-like type that sets its value to llvm::None when it was moved
+/// constructed from.
sammccall wrote:
> As noted in the thread I don't think this pulls its we
Fznamznon created this revision.
Herald added subscribers: cfe-commits, Anastasia, yaxunl.
For OpenCL 1.1 embedded profile 64 bit integers i.e. long,
ulong including the appropriate vector data types and operations
on 64-bit integers are optional. The "cles_khr_int64" extension
string will be repo
thakis updated this revision to Diff 131428.
thakis edited the summary of this revision.
https://reviews.llvm.org/D42497
Files:
lib/Driver/ToolChains/Arch/X86.cpp
test/Driver/cl-x86-flags.c
Index: test/Driver/cl-x86-flags.c
===
thakis added inline comments.
Comment at: lib/Driver/ToolChains/Arch/X86.cpp:43
if (const Arg *A = Args.getLastArg(options::OPT__SLASH_arch)) {
+// Mapping built by looking at lib/Basic's X86TargetInfo::initFeatureMap().
hans wrote:
> I wonder if it woul
Author: krasimir
Date: Thu Jan 25 06:10:43 2018
New Revision: 323419
URL: http://llvm.org/viewvc/llvm-project?rev=323419&view=rev
Log:
[clang-format] Fixes indentation of inner text proto messages
Summary:
Consider the text proto:
```
message {
sub { key: value }
}
```
Previously the first `{`
ilya-biryukov updated this revision to Diff 131429.
ilya-biryukov marked 5 inline comments as done.
ilya-biryukov added a comment.
Herald added subscribers: hintonda, mgorny.
- Addressed review comments
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D42429
Files:
clangd/CMakeL
This revision was automatically updated to reflect the committed changes.
Closed by commit rL323419: [clang-format] Fixes indentation of inner text proto
messages (authored by krasimir, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D42500
Author: ibiryukov
Date: Thu Jan 25 06:19:21 2018
New Revision: 323420
URL: http://llvm.org/viewvc/llvm-project?rev=323420&view=rev
Log:
[clangd] Moved caching of compile commands to ClangdServer
Summary:
It allows to get rid of CppFile::getLastCommand and simplify the
code in the upcoming threadi
This revision was automatically updated to reflect the committed changes.
Closed by commit rCTE323420: [clangd] Moved caching of compile commands to
ClangdServer (authored by ibiryukov, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D42429?vs=131429&id=131432#toc
Repository:
Author: kosarev
Date: Thu Jan 25 06:21:55 2018
New Revision: 323421
URL: http://llvm.org/viewvc/llvm-project?rev=323421&view=rev
Log:
[CodeGen] Decorate aggregate accesses with TBAA tags
Differential Revision: https://reviews.llvm.org/D41539
Modified:
cfe/trunk/lib/CodeGen/CGAtomic.cpp
c
bader accepted this revision.
bader added a comment.
This revision is now accepted and ready to land.
LGTM, but I'd like Anastasia to approve.
Thanks.
Repository:
rC Clang
https://reviews.llvm.org/D42532
___
cfe-commits mailing list
cfe-commits@l
This revision was automatically updated to reflect the committed changes.
Closed by commit rL323421: [CodeGen] Decorate aggregate accesses with TBAA tags
(authored by kosarev, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D41539?vs=13
This revision was automatically updated to reflect the committed changes.
Closed by commit rC323421: [CodeGen] Decorate aggregate accesses with TBAA tags
(authored by kosarev, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D41539?vs=131257&id=131434#toc
Repository:
rC Clan
ilya-biryukov added a comment.
Thanks for reviewing this!
Comment at: unittests/clangd/ClangdTests.cpp:428
+TEST_F(ClangdVFSTest, MemoryUsage) {
+ MockFSProvider FS;
ioeric wrote:
> ilya-biryukov wrote:
> > ioeric wrote:
> > > Can we add a test for non-empty
ilya-biryukov updated this revision to Diff 131435.
ilya-biryukov marked 6 inline comments as done.
ilya-biryukov added a comment.
- Added a FIXME to CppFile::getUsedBytes()
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D42480
Files:
clangd/ClangdServer.cpp
clangd/ClangdSer
Author: ibiryukov
Date: Thu Jan 25 06:29:29 2018
New Revision: 323423
URL: http://llvm.org/viewvc/llvm-project?rev=323423&view=rev
Log:
[clangd] Added forgotten files
Added:
clang-tools-extra/trunk/clangd/CompileArgsCache.cpp
clang-tools-extra/trunk/clangd/CompileArgsCache.h
Added: clang
Author: ibiryukov
Date: Thu Jan 25 06:30:46 2018
New Revision: 323424
URL: http://llvm.org/viewvc/llvm-project?rev=323424&view=rev
Log:
[clangd] Fixed the file comment of new file. NFC
Modified:
clang-tools-extra/trunk/clangd/CompileArgsCache.cpp
Modified: clang-tools-extra/trunk/clangd/Comp
Author: ibiryukov
Date: Thu Jan 25 06:32:21 2018
New Revision: 323425
URL: http://llvm.org/viewvc/llvm-project?rev=323425&view=rev
Log:
[clangd] Provide a helper to report estimated memory usage per-file
Reviewers: sammccall, ioeric, hokein
Reviewed By: ioeric
Subscribers: klimek, cfe-commits,
This revision was automatically updated to reflect the committed changes.
Closed by commit rCTE323425: [clangd] Provide a helper to report estimated
memory usage per-file (authored by ibiryukov, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D42480?vs=131435&id=131438#toc
Re
This revision was automatically updated to reflect the committed changes.
Closed by commit rL323425: [clangd] Provide a helper to report estimated memory
usage per-file (authored by ibiryukov, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org
hans accepted this revision.
hans added a comment.
This revision is now accepted and ready to land.
lgtm
https://reviews.llvm.org/D42497
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commi
Author: nico
Date: Thu Jan 25 06:38:29 2018
New Revision: 323426
URL: http://llvm.org/viewvc/llvm-project?rev=323426&view=rev
Log:
clang-cl: Simplify handling of /arch: flag.
r213083 initially implemented /arch: support by mapping it to CPU features.
Then r241077 additionally mapped it to CPU, wh
thakis closed this revision.
thakis added a comment.
r323426, thanks!
https://reviews.llvm.org/D42497
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
simark added inline comments.
Comment at: clangd/ClangdLSPServer.cpp:302
+// FIXME: This function needs to be properly tested.
+void ClangdLSPServer::onChangeConfiguration(
ilya-biryukov wrote:
> simark wrote:
> > ilya-biryukov wrote:
> > > Are you planning to
ilya-biryukov added inline comments.
Comment at: clangd/ClangdLSPServer.cpp:78
{"documentHighlightProvider", true},
+{"configurationChangeProvider", true},
{"renameProvider", true},
simark wrote:
> Nebiroth wrote:
> > simark
Author: alexfh
Date: Thu Jan 25 07:09:33 2018
New Revision: 323431
URL: http://llvm.org/viewvc/llvm-project?rev=323431&view=rev
Log:
Removed Unicode BOM.
Modified:
clang-tools-extra/trunk/clang-tidy/cppcoreguidelines/NoMallocCheck.cpp
Modified: clang-tools-extra/trunk/clang-tidy/cppcoreguide
thakis created this revision.
thakis added a reviewer: hans.
thakis edited the summary of this revision.
Also refactor the existing AVX / AVX2 code to not repeat itself in both the
32-bit and 64-bit cases.
For /arch:AVX512F, we define `__AVX512F__` `__AVX512CD__` `__AVX512ER__`
`__AVX512PF__`.
hans accepted this revision.
hans added a comment.
This revision is now accepted and ready to land.
lgtm
https://reviews.llvm.org/D42538
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commi
Author: nico
Date: Thu Jan 25 07:24:43 2018
New Revision: 323433
URL: http://llvm.org/viewvc/llvm-project?rev=323433&view=rev
Log:
[clang-cl] Add support for /arch:AVX512F and /arch:AVX512
For /arch:AVX512F:
clang-cl and cl.exe both defines __AVX512F__ __AVX512CD__.
clang-cl also defines __AVX512
thakis closed this revision.
thakis added a comment.
r323433, thanks!
https://reviews.llvm.org/D42538
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
sammccall marked 5 inline comments as done.
sammccall added a comment.
In https://reviews.llvm.org/D42499#987583, @ilya-biryukov wrote:
> I've tried experimenting with that and came up with an alternative that has
> less changes to the API. Could you take a look, too?
> https://reviews.llvm.org
Author: d0k
Date: Thu Jan 25 07:57:22 2018
New Revision: 323435
URL: http://llvm.org/viewvc/llvm-project?rev=323435&view=rev
Log:
Unused diagnostics can occur in tblgen.
Modified:
cfe/trunk/utils/find-unused-diagnostics.sh
Modified: cfe/trunk/utils/find-unused-diagnostics.sh
URL:
http://llv
sammccall added a comment.
Agreed we can defer lots of stuff in order to keep this patch compact.
Generally the things I think we can get right before landing:
- names and file organization for new things
- documentation including where we want to get to
Comment at: clangd/Cla
sammccall updated this revision to Diff 131460.
sammccall marked 4 inline comments as done.
sammccall added a comment.
Address review comments
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D42499
Files:
clangd/ClangdUnit.cpp
clangd/Context.h
clangd/Function.h
clangd/J
Great question. Is there an existing separate list for libunwind?
If libunwind discussion already happens on cfe-commits, then I'll make
reviews for libunwind subscribe that list.
On Tue, Jan 23, 2018, 21:40 Don Hinton wrote:
> Currently, herald doesn't subscribe libunwind to any group. Should
miyuki created this revision.
miyuki added reviewers: faisalv, rsmith.
According to [dcl.init.list]p7:
A narrowing conversion is an implicit conversion
- ...
- from an integer type or unscoped enumeration type to a
floating-point type, except where the source is a constant
expressio
mattd added a comment.
Ping.
https://reviews.llvm.org/D42248
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
a.sidorin accepted this revision.
a.sidorin added a comment.
This revision is now accepted and ready to land.
LGTM, thank you!
https://reviews.llvm.org/D42335
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mail
Author: sammccall
Date: Thu Jan 25 09:01:39 2018
New Revision: 323443
URL: http://llvm.org/viewvc/llvm-project?rev=323443&view=rev
Log:
[clangd] Replace homegrown make_scope_exit with one from ADT
Modified:
clang-tools-extra/trunk/clangd/ClangdServer.cpp
clang-tools-extra/trunk/clangd/Fun
sammccall added a comment.
r323443 removed ScopeExitGuard altogether.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D42525
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co
a.sidorin added a comment.
Thank you, Gabor. I'll change cast<> to cast_or_null<> to enable the assertion
below.
Repository:
rC Clang
https://reviews.llvm.org/D42301
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/c
sammccall added inline comments.
Comment at: clangd/ClangdLSPServer.cpp:283
llvm::Optional Result = Server.switchSourceHeader(Params.uri.file);
- std::string ResultUri;
- reply(C, Result ? URI::fromFile(*Result).uri : "");
+ std::string ResultUri = "";
+ if (Result) {
Author: sammccall
Date: Thu Jan 25 09:29:17 2018
New Revision: 323448
URL: http://llvm.org/viewvc/llvm-project?rev=323448&view=rev
Log:
[clangd] Add ClangdUnit diagnostics tests using annotated code.
Summary:
This adds checks that our diagnostics emit correct ranges in a bunch of cases,
as promis
benhamilton updated this revision to Diff 131470.
benhamilton added a comment.
- Add more extensions.
Repository:
rC Clang
https://reviews.llvm.org/D42395
Files:
test/Format/dump-config-cxx.h
test/Format/dump-config-objc.h
test/Format/lit.local.cfg
tools/clang-format/ClangFormat.cpp
This revision was automatically updated to reflect the committed changes.
Closed by commit rCTE323448: [clangd] Add ClangdUnit diagnostics tests using
annotated code. (authored by sammccall, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D41454?vs=127843&id=131471#toc
Reposi
benhamilton marked an inline comment as done.
benhamilton added inline comments.
Comment at: test/Format/lit.local.cfg:2-3
+# Suffixes supported by clang-format.
+config.suffixes = ['.cpp', '.h', '.m', '.mm', '.java', '.js', '.ts', '.proto',
+ '.protodevel', '.p
Quuxplusone added a comment.
FWIW, I would also like this patch, because it would mean that I could build
with -Werror even when the project includes headers written by MSVC-using
people. Given that we know what "#pragma region" does, it hardly deserves an
"unknown pragma" diagnostic! So this p
Ah, I see from
http://bcain-llvm.readthedocs.io/projects/libunwind/en/latest/ that
libunwind review discussion does take place on cfe-commits.
Added. Sorry about not doing that earlier!
Ben
On Thu, Jan 25, 2018 at 8:37 AM Ben Hamilton wrote:
> Great question. Is there an existing separate list
ilya-biryukov accepted this revision.
ilya-biryukov added a comment.
This revision is now accepted and ready to land.
LGTM. And sorry for confusion with https://reviews.llvm.org/D42524, if any.
Comment at: clangd/Function.h:147
- ScopeExitGuard(Func F) : F(std::move(F)) {}
+
Thanks Ben...
On Thu, Jan 25, 2018 at 9:53 AM, Ben Hamilton
wrote:
> Ah, I see from http://bcain-llvm.readthedocs.io/projects/
> libunwind/en/latest/ that libunwind review discussion does take place on
> cfe-commits.
>
> Added. Sorry about not doing that earlier!
>
> Ben
>
> On Thu, Jan 25, 2018
majnemer accepted this revision.
majnemer added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D42248
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/c
compnerd updated this revision to Diff 131477.
compnerd added a comment.
Add additional test cases as discussed on IRC. These ensure that the back
reference handling is correct.
Repository:
rC Clang
https://reviews.llvm.org/D42508
Files:
lib/AST/MicrosoftMangle.cpp
test/CodeGenObjCXX/m
Author: dhinton
Date: Thu Jan 25 10:13:26 2018
New Revision: 323453
URL: http://llvm.org/viewvc/llvm-project?rev=323453&view=rev
Log:
[cmake] [libcxx] Call llvm_setup_rpath() when adding shared libraries.
Clang and llvm already use llvm_setup_rpath(), so this change will
help standarize rpath usa
This revision was automatically updated to reflect the committed changes.
Closed by commit rCXX323453: [cmake] [libcxx] Call llvm_setup_rpath() when
adding shared libraries. (authored by dhinton, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D42459?vs=131195&id=131478#toc
R
mattd added a comment.
Thanks @majnemer! Would you mind committing this on my behalf? I do not have
commit access, thanks.
https://reviews.llvm.org/D42248
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailma
Author: dhinton
Date: Thu Jan 25 10:43:18 2018
New Revision: 323455
URL: http://llvm.org/viewvc/llvm-project?rev=323455&view=rev
Log:
[cmake] [libcxxabi] Call llvm_setup_rpath() when adding shared libraries.
Clang and llvm already use llvm_setup_rpath(), so this change will
help standarize rpath
This revision was automatically updated to reflect the committed changes.
Closed by commit rL323455: [cmake] [libcxxabi] Call llvm_setup_rpath() when
adding shared libraries. (authored by dhinton, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm
juliehockett updated this revision to Diff 131481.
juliehockett added a comment.
Herald added a subscriber: hintonda.
Cleaning up a few unnecessary copyings
https://reviews.llvm.org/D41102
Files:
test/CMakeLists.txt
test/Tooling/clang-doc-basic.cpp
test/lit.cfg.py
tools/CMakeLists.txt
mattd created this revision.
mattd added a reviewer: majnemer.
This change avoids the overhead of storing, and later crawling,
an initializer list of all zeros for arrays. When LLVM
visits this (llvm/IR/Constants.cpp) ConstantArray::getImpl()
it will scan the list looking for an array of all zero.
Btw, I'm seeing other inconsistencies, e.g., I just committed
https://reviews.llvm.org/D42460 and herald ended up adding both cfe-commits
and llvm-commits to subscribers.
When I created it, I left subscribers blank, so herald added cfe-commits --
which seems to be correct.
Then, when I committed i
This is going to break building libc++ standalone (i.e. without any LLVM
repository or even its CMake modules), right? Some upstream users care a lot
about that use case (CC beanz and Duncan).
From: cfe-commits on behalf of Don Hinton
via cfe-commits
Reply-To: Don Hinton
Date: Thursday, Janu
Same concerns about building standalone as r323453.
From: cfe-commits on behalf of Don Hinton
via cfe-commits
Reply-To: Don Hinton
Date: Thursday, January 25, 2018 at 10:45 AM
To: "cfe-commits@lists.llvm.org"
Subject: [libcxxabi] r323455 - [cmake] [libcxxabi] Call llvm_setup_rpath() when
add
rjmccall accepted this revision.
rjmccall added a comment.
This revision is now accepted and ready to land.
LGTM.
https://reviews.llvm.org/D42521
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/
rjmccall added inline comments.
Comment at: lib/AST/ExprClassification.cpp:652
+if (Ctx.getCanonicalType(ASE->getBase()->getType()).isConstQualified())
+ return Cl::CM_ConstQualified;
+
Is there a reason why the places that compute the type of these l-va
Author: dhinton
Date: Thu Jan 25 11:18:51 2018
New Revision: 323458
URL: http://llvm.org/viewvc/llvm-project?rev=323458&view=rev
Log:
Revert [libcxxabi] r323455 - [cmake] [libcxxabi] Call llvm_setup_rpath() when
adding shared libraries.
Shoaib Meenai pointed out this will break standalone builds
Author: dhinton
Date: Thu Jan 25 11:22:23 2018
New Revision: 323459
URL: http://llvm.org/viewvc/llvm-project?rev=323459&view=rev
Log:
Revert [libcxx] r323453 - [cmake] [libcxx] Call llvm_setup_rpath() when adding
shared libraries.
Shoaib Meenai pointed out this will break standalone builds when
Yes, that's currently a submit time feature built in to Phabricator which i
believe we'll have to fix upstream.
Because both the top level LLVM SVN report and the sub repos see the same
files, Phabricator automatically subscribes both lists to the commits.
I wasn't able to find an easy way to dis
hintonda reopened this revision.
hintonda added a comment.
This revision is now accepted and ready to land.
Reopen after rollback.
@smeenai pointed out LLVM may not be available in standalone builds
Repository:
rCXX libc++
https://reviews.llvm.org/D42459
__
hintonda reopened this revision.
hintonda added a comment.
This revision is now accepted and ready to land.
Reopen after rollback.
@smeenai pointed out LLVM may not be available in standalone builds
Repository:
rL LLVM
https://reviews.llvm.org/D42460
__
Ah, I think that's the issue.
local:/Users/dhinton/projects/llvm_project/libcxxabi $ cat .arcconfig
{
"repository.callsign" : "CXXA",
"conduit_uri" : "https://reviews.llvm.org/";
}
So, it should set repository to CXXA, not LLVM.
On Thu, Jan 25, 2018 at 11:25 AM, Ben Hamilton
wrote:
> Yes
Author: compnerd
Date: Thu Jan 25 11:54:31 2018
New Revision: 323461
URL: http://llvm.org/viewvc/llvm-project?rev=323461&view=rev
Log:
AST: inline a single-use variable (NFC)
Inline the single use variable into the only use. NFC.
Modified:
cfe/trunk/lib/AST/MicrosoftMangle.cpp
Modified: cf
1 - 100 of 153 matches
Mail list logo
