r324884 - ASan+operator new[]: Add an option for more thorough operator new[] cookie poisoning

2018-02-12 Thread Filipe Cabecinhas via cfe-commits
Author: filcab Date: Mon Feb 12 03:49:02 2018 New Revision: 324884 URL: http://llvm.org/viewvc/llvm-project?rev=324884=rev Log: ASan+operator new[]: Add an option for more thorough operator new[] cookie poisoning Summary: Right now clang is skipping array cookie poisoning for any operator new[]

[PATCH] D42922: [CUDA] Register relocatable GPU binaries

2018-02-12 Thread Jonas Hahnfeld via Phabricator via cfe-commits
Hahnfeld planned changes to this revision. Hahnfeld added a comment. Still no regression tests. I did some functional tests though (https://reviews.llvm.org/F5822023): With this patch Clang can generate valid object files with relocatable device code. For linking I still defer to `nvcc` and

[PATCH] D43174: [clang-move] Fix the incorrect expansion end location.

2018-02-12 Thread Haojian Wu via Phabricator via cfe-commits
hokein created this revision. hokein added a reviewer: ioeric. Herald added a subscriber: klimek. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D43174 Files: clang-move/ClangMove.cpp unittests/clang-move/ClangMoveTests.cpp Index: unittests/clang-move/ClangMoveTests.cpp

[PATCH] D43108: Support for the mno-stack-arg-probe flag

2018-02-12 Thread Hans Wennborg via Phabricator via cfe-commits
hans added a comment. I see in the PR that matches a MinGW flag, but I'm curious to the motivation here. In what scenario would the user want to use this, i.e. how do they know it's safe to drop the probes? Comment at: lib/CodeGen/TargetInfo.cpp:2358 -static void

[libcxx] r324874 - Merging r324855:

2018-02-12 Thread Hans Wennborg via cfe-commits
Author: hans Date: Mon Feb 12 02:04:36 2018 New Revision: 324874 URL: http://llvm.org/viewvc/llvm-project?rev=324874=rev Log: Merging r324855: r324855 | dim | 2018-02-11 23:31:05 +0100 (Sun, 11 Feb 2018) | 26 lines Add

Re: [libcxx] r324855 - Add default C++ ABI libname and include paths for FreeBSD

2018-02-12 Thread Hans Wennborg via cfe-commits
Merged to 6.0 in r324874. On Sun, Feb 11, 2018 at 11:31 PM, Dimitry Andric via cfe-commits wrote: > Author: dim > Date: Sun Feb 11 14:31:05 2018 > New Revision: 324855 > > URL: http://llvm.org/viewvc/llvm-project?rev=324855=rev > Log: > Add default C++ ABI libname and

[PATCH] D43012: [ASTImporter] Fix lexical DC for templated decls; support VarTemplatePartialSpecDecl

2018-02-12 Thread Aleksei Sidorin via Phabricator via cfe-commits
a.sidorin added inline comments. Comment at: lib/AST/ASTImporter.cpp:2858 + + // Templated declarations should never appear in the enclosing DeclContext. + if (!D->getDescribedVarTemplate()) martong wrote: > In case of class templates, the explicit

Re: [clang-tools-extra] r323040 - Assume the shared library path variable is LD_LIBRARY_PATH on systems

2018-02-12 Thread Hans Wennborg via cfe-commits
Merged to 6.0 in r324871. On Sat, Jan 20, 2018 at 3:34 PM, Dimitry Andric via cfe-commits wrote: > Author: dim > Date: Sat Jan 20 06:34:33 2018 > New Revision: 323040 > > URL: http://llvm.org/viewvc/llvm-project?rev=323040=rev > Log: > Assume the shared library path

[PATCH] D42920: [CUDA] Fix test cuda-external-tools.cu

2018-02-12 Thread Jonas Hahnfeld via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL324877: [CUDA] Fix test cuda-external-tools.cu (authored by Hahnfeld, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D42569: [ARM] disable FPU features when using soft floating point.

2018-02-12 Thread Keith Walker via Phabricator via cfe-commits
keith.walker.arm added a comment. review request ping. There was one line in the compiler itself which is different to what had been previously reviewed and approved ... so hopefully that change is easily reviewed. However this change also resulted in updates to the associated tests, and the

[PATCH] D42921: [CUDA] Add option to generate relocatable device code

2018-02-12 Thread Jonas Hahnfeld via Phabricator via cfe-commits
Hahnfeld added inline comments. Comment at: include/clang/Driver/Options.td:572 + HelpText<"Generate relocatable device code, also known as separate compilation mode.">; +def fno_cuda_rdc : Flag<["-"], "fno-cuda-rdc">; def dA : Flag<["-"], "dA">, Group; tra

[PATCH] D43068: [clangd] Remove codeComplete that returns std::future<>

2018-02-12 Thread Ilya Biryukov via Phabricator via cfe-commits
ilya-biryukov added inline comments. Comment at: unittests/clangd/SyncAPI.h:1 +//===--- SyncAPI.h - Sync version of ClangdServer's API --*- C++-*-===// +// sammccall wrote: > Being able to call synchronously is really nice for tests. > It's a bit

[PATCH] D43013: ASan+operator new[]: Fix operator new[] cookie poisoning

2018-02-12 Thread Filipe Cabecinhas via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC324884: ASan+operator new[]: Add an option for more thorough operator new[] cookie… (authored by filcab, committed by ). Changed prior to commit: https://reviews.llvm.org/D43013?vs=133389=133830#toc

[PATCH] D42921: [CUDA] Add option to generate relocatable device code

2018-02-12 Thread Jonas Hahnfeld via Phabricator via cfe-commits
Hahnfeld updated this revision to Diff 133817. Hahnfeld marked an inline comment as done. Hahnfeld added a comment. Hide help for `-fcuda-rdc` until support is ready. https://reviews.llvm.org/D42921 Files: include/clang/Basic/LangOptions.def include/clang/Driver/Options.td

[PATCH] D42920: [CUDA] Fix test cuda-external-tools.cu

2018-02-12 Thread Jonas Hahnfeld via Phabricator via cfe-commits
Hahnfeld added inline comments. Comment at: test/Driver/cuda-external-tools.cu:11 +// RUN: | FileCheck -check-prefix CHECK -check-prefix ARCH64 \ +// RUN: -check-prefix SM20 -check-prefix OPT0 %s // RUN: %clang -### -target x86_64-linux-gnu -O1 -c %s 2>&1 \

[PATCH] D42920: [CUDA] Fix test cuda-external-tools.cu

2018-02-12 Thread Jonas Hahnfeld via Phabricator via cfe-commits
Hahnfeld updated this revision to Diff 133816. Hahnfeld marked an inline comment as done. Hahnfeld added a comment. Use `--check-prefixes` instead of multiple `--check-prefix`. https://reviews.llvm.org/D42920 Files: test/Driver/cuda-external-tools.cu Index:

[PATCH] D42922: [CUDA] Register relocatable GPU binaries

2018-02-12 Thread Jonas Hahnfeld via Phabricator via cfe-commits
Hahnfeld updated this revision to Diff 133831. Hahnfeld added a comment. Rebase and fix `Debug` build. https://reviews.llvm.org/D42922 Files: lib/CodeGen/CGCUDANV.cpp Index: lib/CodeGen/CGCUDANV.cpp === ---

[PATCH] D43174: [clang-move] Fix the incorrect expansion end location.

2018-02-12 Thread Eric Liu via Phabricator via cfe-commits
ioeric accepted this revision. ioeric added a comment. This revision is now accepted and ready to land. lgtm Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D43174 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D43123: [clangd] Log all ignored diagnostics.

2018-02-12 Thread Haojian Wu via Phabricator via cfe-commits
hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. LGTM. Comment at: clangd/ClangdUnit.cpp:197 - -log(llvm::formatv("Ignored diagnostic outside main file. {0}: {1}", - Location, Message));

[PATCH] D43174: [clang-move] Fix the incorrect expansion end location.

2018-02-12 Thread Haojian Wu via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL324886: [clang-move] Fix the incorrect expansion end location. (authored by hokein, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D43174 Files:

[PATCH] D42530: Clang permits assignment to vector/extvector elements in a const method

2018-02-12 Thread Andrew V. Tischenko via Phabricator via cfe-commits
avt77 closed this revision. avt77 added a comment. Fixed by 324721. https://reviews.llvm.org/D42530 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D43127: [clangd] Stop exposing Futures from ClangdServer operations.

2018-02-12 Thread Ilya Biryukov via Phabricator via cfe-commits
ilya-biryukov added inline comments. Comment at: clangd/Threading.h:60 +/// A point in time we may wait for, or None to wait forever. +/// (We use Optional because buggy implementations of std::chrono overflow...) +using Deadline = llvm::Optional; Maybe remove

[PATCH] D43174: [clang-move] Fix the incorrect expansion end location.

2018-02-12 Thread Eric Liu via Phabricator via cfe-commits
ioeric added a comment. The fix is quite subtle and not obvious to tell from the test. Could you elaborate on the issue this fixes in the patch description? Thanks! Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D43174 ___

[PATCH] D42895: [libclang] Add `CXSymbolRole role` to CXIdxEntityRefInfo

2018-02-12 Thread Ilya Biryukov via Phabricator via cfe-commits
ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM. > Is it possible to see this landed before clang+llvm 6 is released? I don't know in detail how releases work, but I believe the release branch has already been created

[PATCH] D42921: [CUDA] Add option to generate relocatable device code

2018-02-12 Thread Jonas Hahnfeld via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL324878: [CUDA] Add option to generate relocatable device code (authored by Hahnfeld, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

r324878 - [CUDA] Add option to generate relocatable device code

2018-02-12 Thread Jonas Hahnfeld via cfe-commits
Author: hahnfeld Date: Mon Feb 12 02:46:45 2018 New Revision: 324878 URL: http://llvm.org/viewvc/llvm-project?rev=324878=rev Log: [CUDA] Add option to generate relocatable device code As a first step, pass '-c/--compile-only' to ptxas so that it doesn't complain about references to external

[PATCH] D42366: [CodeGen] Fix generation of TBAA tags for may-alias accesses

2018-02-12 Thread Ivan Kosarev via Phabricator via cfe-commits
kosarev added a comment. Hal, a friendly ping. Repository: rL LLVM https://reviews.llvm.org/D42366 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D43123: [clangd] Log all ignored diagnostics.

2018-02-12 Thread Ilya Biryukov via Phabricator via cfe-commits
ilya-biryukov updated this revision to Diff 133827. ilya-biryukov marked an inline comment as done. ilya-biryukov added a comment. - Renamed logIgnoredDiag to log. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D43123 Files: clangd/ClangdUnit.cpp clangd/Compiler.cpp

[PATCH] D43123: [clangd] Log all ignored diagnostics.

2018-02-12 Thread Ilya Biryukov via Phabricator via cfe-commits
ilya-biryukov added inline comments. Comment at: clangd/ClangdUnit.cpp:197 - -log(llvm::formatv("Ignored diagnostic outside main file. {0}: {1}", - Location, Message)); hokein wrote: > I'm not sure, do we care about this particular case

r324877 - [CUDA] Fix test cuda-external-tools.cu

2018-02-12 Thread Jonas Hahnfeld via cfe-commits
Author: hahnfeld Date: Mon Feb 12 02:46:34 2018 New Revision: 324877 URL: http://llvm.org/viewvc/llvm-project?rev=324877=rev Log: [CUDA] Fix test cuda-external-tools.cu This didn't verify the CHECK prefix before! Differential Revision: https://reviews.llvm.org/D42920 Modified:

[PATCH] D43068: [clangd] Remove codeComplete that returns std::future<>

2018-02-12 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL324883: [clangd] Remove codeComplete that returns std::future (authored by ibiryukov, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D43068

[clang-tools-extra] r324883 - [clangd] Remove codeComplete that returns std::future<>

2018-02-12 Thread Ilya Biryukov via cfe-commits
Author: ibiryukov Date: Mon Feb 12 03:37:28 2018 New Revision: 324883 URL: http://llvm.org/viewvc/llvm-project?rev=324883=rev Log: [clangd] Remove codeComplete that returns std::future<> Summary: It was deprecated and callback version and is used everywhere. Only changes to the testing code were

[clang-tools-extra] r324888 - [clangd] Log all ignored diagnostics.

2018-02-12 Thread Ilya Biryukov via cfe-commits
Author: ibiryukov Date: Mon Feb 12 04:48:51 2018 New Revision: 324888 URL: http://llvm.org/viewvc/llvm-project?rev=324888=rev Log: [clangd] Log all ignored diagnostics. Summary: To aid debugging failures and crashes. Only part of ignored diagnostics was logged before, now we log all of them.

[PATCH] D43123: [clangd] Log all ignored diagnostics.

2018-02-12 Thread Haojian Wu via Phabricator via cfe-commits
hokein added inline comments. Comment at: clangd/ClangdUnit.cpp:197 - -log(llvm::formatv("Ignored diagnostic outside main file. {0}: {1}", - Location, Message)); I'm not sure, do we care about this particular case (diagnostic outside

[PATCH] D40787: [clang-tidy] Replace the usage of std::uncaught_exception with std::uncaught_exceptions

2018-02-12 Thread Daniel Kolozsvari via Phabricator via cfe-commits
koldaniel updated this revision to Diff 133814. https://reviews.llvm.org/D40787 Files: clang-tidy/modernize/CMakeLists.txt clang-tidy/modernize/ModernizeTidyModule.cpp clang-tidy/modernize/UseUncaughtExceptionsCheck.cpp clang-tidy/modernize/UseUncaughtExceptionsCheck.h

[clang-tools-extra] r324886 - [clang-move] Fix the incorrect expansion end location.

2018-02-12 Thread Haojian Wu via cfe-commits
Author: hokein Date: Mon Feb 12 04:26:12 2018 New Revision: 324886 URL: http://llvm.org/viewvc/llvm-project?rev=324886=rev Log: [clang-move] Fix the incorrect expansion end location. Summary: Before the fix, if clang-move decides to move the following macro statement, it only moves the first

[PATCH] D42593: GCC compatibility: Ignore -fstack-clash-protection

2018-02-12 Thread Sylvestre Ledru via Phabricator via cfe-commits
sylvestre.ledru accepted this revision. sylvestre.ledru added a comment. This revision is now accepted and ready to land. Looks good, thanks. Repository: rC Clang https://reviews.llvm.org/D42593 ___ cfe-commits mailing list

[PATCH] D43068: [clangd] Remove codeComplete that returns std::future<>

2018-02-12 Thread Ilya Biryukov via Phabricator via cfe-commits
ilya-biryukov updated this revision to Diff 133825. ilya-biryukov marked 2 inline comments as done. ilya-biryukov added a comment. Herald added a subscriber: mgorny. - Added CaptureProxy helper, use it to implement runCodeComplete. - Documented that we deliberately don't expose the sync API in

[PATCH] D43123: [clangd] Log all ignored diagnostics.

2018-02-12 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL324888: [clangd] Log all ignored diagnostics. (authored by ibiryukov, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D43123 Files:

[PATCH] D42593: GCC compatibility: Ignore -fstack-clash-protection

2018-02-12 Thread Joerg Sonnenberger via Phabricator via cfe-commits
joerg added a comment. I really don't like ignoring options that are supposed to provide actual functionality. Most of the other options are for pointless fine tuning and workarounds for broken gcc behavior in ancient versions. Repository: rC Clang https://reviews.llvm.org/D42593

[PATCH] D43180: [clang-format] Support text proto extensions

2018-02-12 Thread Krasimir Georgiev via Phabricator via cfe-commits
krasimir created this revision. Herald added subscribers: cfe-commits, klimek. This adds support for text proto extensions, like: msg { [type.type/ext] { key: value } } Repository: rC Clang https://reviews.llvm.org/D43180 Files: lib/Format/ContinuationIndenter.cpp

[PATCH] D43187: [AST] Refine the condition for element-dependent array fillers

2018-02-12 Thread Ivan Kosarev via Phabricator via cfe-commits
kosarev created this revision. kosarev added a reviewer: rsmith. kosarev added a project: clang. Herald added a subscriber: llvm-commits. This patch fixes clang to not consider braced initializers for aggregate elements of arrays to be potentially dependent on the indices of the initialized

[PATCH] D43127: [clangd] Stop exposing Futures from ClangdServer operations.

2018-02-12 Thread Sam McCall via Phabricator via cfe-commits
sammccall updated this revision to Diff 133857. sammccall marked 3 inline comments as done. sammccall added a comment. Change AsyncTaskRunner::wait() to be LLVM_NODISCARD when used with a deadline. Restore NoConcurrentDiagnostics test to its former glory (with comments) Other comment fixes.

[PATCH] D43127: [clangd] Stop exposing Futures from ClangdServer operations.

2018-02-12 Thread Sam McCall via Phabricator via cfe-commits
sammccall added inline comments. Comment at: clangd/Threading.h:60 +/// A point in time we may wait for, or None to wait forever. +/// (We use Optional because buggy implementations of std::chrono overflow...) +using Deadline = llvm::Optional; ilya-biryukov

[PATCH] D43180: [clang-format] Support text proto extensions

2018-02-12 Thread Daniel Jasper via Phabricator via cfe-commits
djasper added inline comments. Comment at: unittests/Format/FormatTestTextProto.cpp:317 + +TEST_F(FormatTestTextProto, FormatsExtensions) { + verifyFormat("[type] { key: value }"); It might be useful to attach a test case for what happens if the "[...]" does

[PATCH] D43182: [clangd] SymbolLocation only covers symbol name.

2018-02-12 Thread Haojian Wu via Phabricator via cfe-commits
hokein created this revision. hokein added a reviewer: sammccall. Herald added subscribers: ioeric, jkorous-apple, ilya-biryukov, klimek. - Change the offset range to half-open, [start, end). - Fix a few fixmes. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D43182 Files:

[PATCH] D43183: clang-format: introduce `CaseBlockIndent` to control indent in switch

2018-02-12 Thread Francois Ferrand via Phabricator via cfe-commits
Typz created this revision. Typz added reviewers: krasimir, djasper, klimek. When a block is started after a case label, clang-format does add extra indent to the content of this block: the block content is indented one level (with respect to the switch) while the closing brace is not indented,

[PATCH] D38171: [clang-tidy] Implement clang-tidy check aliases

2018-02-12 Thread Gábor Horváth via Phabricator via cfe-commits
xazax.hun added subscribers: dkrupp, whisperity. xazax.hun added a comment. @alexfh did you have any chance to think about this change? https://reviews.llvm.org/D38171 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D43182: [clangd] SymbolLocation only covers symbol name.

2018-02-12 Thread Sam McCall via Phabricator via cfe-commits
sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Nice! Comment at: clangd/index/Index.cpp:40 raw_ostream <<(raw_ostream , const Symbol ) { - return OS << S.Scope << S.Name; + return OS << S.Scope << S.Name << " "

[PATCH] D43189: [DebugInfo] Avoid name conflict of generated VLA expression variable.

2018-02-12 Thread Sander de Smalen via Phabricator via cfe-commits
sdesmalen created this revision. sdesmalen added reviewers: CarlosAlbertoEnciso, probinson, aprantl. Herald added a subscriber: JDevlieghere. This patch also adds the 'DW_AT_artificial' flag to the generated variable. https://reviews.llvm.org/D43189 Files: lib/CodeGen/CGDecl.cpp

[PATCH] D43127: [clangd] Stop exposing Futures from ClangdServer operations.

2018-02-12 Thread Sam McCall via Phabricator via cfe-commits
sammccall updated this revision to Diff 133868. sammccall marked 3 inline comments as done. sammccall added a comment. Review comments Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D43127 Files: clangd/ClangdServer.cpp clangd/ClangdServer.h clangd/TUScheduler.cpp

[PATCH] D39050: Add index-while-building support to Clang

2018-02-12 Thread Eric Liu via Phabricator via cfe-commits
ioeric added a comment. I'm wondering if there is any further plan for this? ;) https://reviews.llvm.org/D39050 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D43120: [clang-tidy] New checker for exceptions that are created but not thrown

2018-02-12 Thread Umann Kristóf via Phabricator via cfe-commits
Szelethus updated this revision to Diff 133860. Szelethus added a comment. Fixed almost everything mentioned in comments. I also came up with this problem: RegularException funcReturningExceptioniTest(int i) { return RegularException(); } void returnedValueTest() {

[libcxx] r324895 - While implementing P0777 - preventing unnecessary decay, I found some non-public uses of decay that could be replaced by __uncvref. NFC intented

2018-02-12 Thread Marshall Clow via cfe-commits
Author: marshall Date: Mon Feb 12 07:41:25 2018 New Revision: 324895 URL: http://llvm.org/viewvc/llvm-project?rev=324895=rev Log: While implementing P0777 - preventing unnecessary decay, I found some non-public uses of decay that could be replaced by __uncvref. NFC intented Modified:

[PATCH] D43184: [WIP] [ItaniunCXXABI] Add an option for loading the type info vtable with dllimport

2018-02-12 Thread Martin Storsjö via Phabricator via cfe-commits
mstorsjo created this revision. mstorsjo added reviewers: rnk, majnemer, smeenai, compnerd. The first member of the type info structs/objects is a pointer to the vtable of the type info class. If the standard C++ library that provides this vtable is linked as a DLL, this field of the struct

[PATCH] D42640: [clangd] collect symbol #include & insert #include in global code completion.

2018-02-12 Thread Sam McCall via Phabricator via cfe-commits
sammccall added a comment. Insertion still LG (couple of nits, inline). For indexing, my biggest questions: - I worry CanonicalIncludes doesn't get enough information to make good decisions - passing the include stack in some form may be better - CanonicalIncludes has slightly weird patterns

r324896 - [clang-format] Fix comment indentation in text protos

2018-02-12 Thread Krasimir Georgiev via cfe-commits
Author: krasimir Date: Mon Feb 12 07:49:09 2018 New Revision: 324896 URL: http://llvm.org/viewvc/llvm-project?rev=324896=rev Log: [clang-format] Fix comment indentation in text protos Summary: This patch fixes a bug where the comment indent of comments in text protos gets messed up because by

[PATCH] D43127: [clangd] Stop exposing Futures from ClangdServer operations.

2018-02-12 Thread Sam McCall via Phabricator via cfe-commits
sammccall added inline comments. Comment at: clangd/TUScheduler.cpp:286 } // unlock Mutex. RequestsCV.notify_one(); } ilya-biryukov wrote: > Change to `notify_all()`? Otherwise we might wake up some thread waiting on > `blockUntilIdle()`, but not the

[PATCH] D43194: [clang-format] Fix comment indentation in text protos

2018-02-12 Thread Krasimir Georgiev via Phabricator via cfe-commits
krasimir created this revision. Herald added subscribers: cfe-commits, klimek. This patch fixes a bug where the comment indent of comments in text protos gets messed up because by default paren states get created with AlignColons = true (which makes snese for ObjC). Repository: rC Clang

[PATCH] D43120: [clang-tidy] New checker for exceptions that are created but not thrown

2018-02-12 Thread Umann Kristóf via Phabricator via cfe-commits
Szelethus marked 7 inline comments as done. Szelethus added inline comments. Comment at: clang-tidy/misc/ThrowKeywordMissingCheck.cpp:45 + diag(TemporaryExpr->getLocStart(), + "exception instantiated but not bound (did you intend to 'throw'?)"); +}

[PATCH] D43127: [clangd] Stop exposing Futures from ClangdServer operations.

2018-02-12 Thread Ilya Biryukov via Phabricator via cfe-commits
ilya-biryukov added inline comments. Comment at: clangd/TUScheduler.cpp:286 } // unlock Mutex. RequestsCV.notify_one(); } Change to `notify_all()`? Otherwise we might wake up some thread waiting on `blockUntilIdle()`, but not the worker thread.

[PATCH] D43194: [clang-format] Fix comment indentation in text protos

2018-02-12 Thread Krasimir Georgiev via Phabricator via cfe-commits
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rC324896: [clang-format] Fix comment indentation in text protos (authored by krasimir, committed by ). Changed prior to

[PATCH] D43194: [clang-format] Fix comment indentation in text protos

2018-02-12 Thread Krasimir Georgiev via Phabricator via cfe-commits
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL324896: [clang-format] Fix comment indentation in text protos (authored by krasimir, committed by ). Herald added a

[PATCH] D43181: [CodeGen] Initialize large arrays by copying from a global

2018-02-12 Thread Ivan Kosarev via Phabricator via cfe-commits
kosarev created this revision. kosarev added a reviewer: rjmccall. kosarev added a project: clang. Herald added a subscriber: llvm-commits. Currently, clang compiles explicit initializers for array elements into series of store instructions. For large arrays of built-in types this results in

r324890 - Allow the NS, CF, and ObjC attributes to be used with -fdouble-square-bracket-attributes. The syntactic locations for such attributes on ObjC constructs have been specifically chosen to foll

2018-02-12 Thread Aaron Ballman via cfe-commits
Author: aaronballman Date: Mon Feb 12 05:38:25 2018 New Revision: 324890 URL: http://llvm.org/viewvc/llvm-project?rev=324890=rev Log: Allow the NS, CF, and ObjC attributes to be used with -fdouble-square-bracket-attributes. The syntactic locations for such attributes on ObjC constructs have

[PATCH] D41553: Support parsing double square-bracket attributes in ObjC

2018-02-12 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman closed this revision. aaron.ballman added a comment. Thanks for the detailed review! I've commit in r324890. https://reviews.llvm.org/D41553 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D30691: [analyzer] Support for naive cross translational unit analysis

2018-02-12 Thread Zoltán Gera via Phabricator via cfe-commits
gerazo added inline comments. Comment at: tools/scan-build-py/libscanbuild/analyze.py:702 + # To have good results from static analyzer certain compiler options shall be george.karpenkov wrote: > This blank line should not be in this PR. Scheduled to be done.

Re: r324433 - [NFC] Change odd cast-through-unknown behavior to an Optional

2018-02-12 Thread David Blaikie via cfe-commits
FWIW, you can write "*M" rather than M.getValue() if you reckon that's neater. And you could roll the declaration/initialization of M into the 'if' condition - but I can understand why you might prefer not to, given it's a many-line statement, etc. On Tue, Feb 6, 2018 at 4:39 PM Erich Keane via

[PATCH] D43184: [WIP] [ItaniunCXXABI] Add an option for loading the type info vtable with dllimport

2018-02-12 Thread Reid Kleckner via Phabricator via cfe-commits
rnk added a comment. In https://reviews.llvm.org/D43184#1005161, @majnemer wrote: > Do I understand correctly that this workarounds a feature missing in lld? > Does MinGW emit the same sorts of object files as clang in these scenarios? You can see it that way, but having the linker synthesize

[PATCH] D43184: [WIP] [ItaniunCXXABI] Add an option for loading the type info vtable with dllimport

2018-02-12 Thread Shoaib Meenai via Phabricator via cfe-commits
smeenai added a comment. FYI, binutils auto-import actually creates a fake IAT entry rather than using a dynamic initializer. I think it's actually a pretty cute trick. http://blog.omega-prime.co.uk/2011/07/04/everything-you-never-wanted-to-know-about-dlls/#how-auto-import-works has details.

[PATCH] D42983: [clang-tidy] Add readability-simd-intrinsics check.

2018-02-12 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay updated this revision to Diff 133902. MaskRay marked an inline comment as done. MaskRay added a comment. Rename `Enabled` to `UseStdExperimental` and only suggest std::experimental:: (not `std::`) Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D42983 Files:

[PATCH] D43203: [Driver] Generate .eh_frame_hdr for static executables too.

2018-02-12 Thread Dan Albert via Phabricator via cfe-commits
danalbert created this revision. danalbert added a reviewer: srhines. libgcc won't unwind without an .eh_frame_hdr section. Repository: rC Clang https://reviews.llvm.org/D43203 Files: lib/Driver/ToolChains/Gnu.cpp test/Driver/linux-ld.c Index: test/Driver/linux-ld.c

[PATCH] D43197: [OpenMP] Add flag for linking runtime bitcode library

2018-02-12 Thread George Rokos via Phabricator via cfe-commits
grokos accepted this revision. grokos added a comment. This revision is now accepted and ready to land. I don't have any other remarks, looks good. Repository: rC Clang https://reviews.llvm.org/D43197 ___ cfe-commits mailing list

r324929 - [DebugInfo] Update Checksum handling in CGDebugInfo

2018-02-12 Thread Scott Linder via cfe-commits
Author: scott.linder Date: Mon Feb 12 11:47:05 2018 New Revision: 324929 URL: http://llvm.org/viewvc/llvm-project?rev=324929=rev Log: [DebugInfo] Update Checksum handling in CGDebugInfo Update to match new DIFile API. Modified: cfe/trunk/lib/CodeGen/CGDebugInfo.cpp

[PATCH] D43044: [DebugInfo] Update Checksum handling in CGDebugInfo

2018-02-12 Thread Scott Linder via Phabricator via cfe-commits
scott.linder closed this revision. scott.linder added a comment. Closed by https://reviews.llvm.org/rC324929 Repository: rC Clang https://reviews.llvm.org/D43044 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D42923: [CUDA] Allow external variables in separate compilation

2018-02-12 Thread Jonas Hahnfeld via Phabricator via cfe-commits
Hahnfeld added inline comments. Comment at: test/SemaCUDA/extern-shared.cu:4 +// These declarations are fine in separate compilation mode! +// RUN: %clang_cc1 -fsyntax-only -fcuda-rdc -verify=rdc %s +// RUN: %clang_cc1 -fsyntax-only -fcuda-is-device -fcuda-rdc -verify=rdc %s

r324900 - Re-commit r324490: [DebugInfo] Improvements to representation of enumeration types (PR36168)

2018-02-12 Thread Momchil Velikov via cfe-commits
Author: chill Date: Mon Feb 12 08:12:52 2018 New Revision: 324900 URL: http://llvm.org/viewvc/llvm-project?rev=324900=rev Log: Re-commit r324490: [DebugInfo] Improvements to representation of enumeration types (PR36168) Differential revision: https://reviews.llvm.org/D42736 Added:

r324902 - Add Invalid-note test negllected in R324673, 324674, 324675, 324676

2018-02-12 Thread Erich Keane via cfe-commits
Author: erichkeane Date: Mon Feb 12 08:24:08 2018 New Revision: 324902 URL: http://llvm.org/viewvc/llvm-project?rev=324902=rev Log: Add Invalid-note test negllected in R324673,324674,324675,324676 Added: cfe/trunk/test/Misc/target-invalid-cpu-note.c Added:

[PATCH] D39050: Add index-while-building support to Clang

2018-02-12 Thread Marc-Andre Laperle via Phabricator via cfe-commits
malaperle added a comment. In https://reviews.llvm.org/D39050#1004937, @ioeric wrote: > I'm wondering if there is any further plan for this? ;) I'd like to comment on the amount of data that will be stored but that can be done outside this review. I still have a few things to figure out

r324907 - Make attribute-target on a Definition-after-use update the LLVM attributes

2018-02-12 Thread Erich Keane via cfe-commits
Author: erichkeane Date: Mon Feb 12 09:01:41 2018 New Revision: 324907 URL: http://llvm.org/viewvc/llvm-project?rev=324907=rev Log: Make attribute-target on a Definition-after-use update the LLVM attributes As reported here: https://bugs.llvm.org/show_bug.cgi?id=36301 The issue is that the 'use'

[libcxx] r324911 - Implement LWG#2908 - The less-than operator for shared pointers could do more, and mark 2878 as complete as well (we already do that)

2018-02-12 Thread Marshall Clow via cfe-commits
Author: marshall Date: Mon Feb 12 09:26:40 2018 New Revision: 324911 URL: http://llvm.org/viewvc/llvm-project?rev=324911=rev Log: Implement LWG#2908 - The less-than operator for shared pointers could do more, and mark 2878 as complete as well (we already do that) Modified:

[PATCH] D42844: [OpenCL] Add test for atomic pointers.

2018-02-12 Thread Anastasia Stulova via Phabricator via cfe-commits
Anastasia added a comment. In https://reviews.llvm.org/D42844#1004663, @Fznamznon wrote: > Yes, we don't have anything OpenCL specific for atomic pointers. > But we have OpenCL specific in pointers and atomics separately and we have > address spaces. > Why not to test all at once? We don't

r324913 - [Sema] Don't mark plain MS enums as fixed

2018-02-12 Thread Reid Kleckner via cfe-commits
Author: rnk Date: Mon Feb 12 09:37:06 2018 New Revision: 324913 URL: http://llvm.org/viewvc/llvm-project?rev=324913=rev Log: [Sema] Don't mark plain MS enums as fixed Summary: This fixes a flaw in our AST: PR27098 MSVC always gives plain enums the underlying type 'int'. Clang does this as well,

[libcxx] r324923 - Implement LWG 2835 - fix

2018-02-12 Thread Marshall Clow via cfe-commits
Author: marshall Date: Mon Feb 12 11:13:24 2018 New Revision: 324923 URL: http://llvm.org/viewvc/llvm-project?rev=324923=rev Log: Implement LWG 2835 - fix Modified: libcxx/trunk/include/tgmath.h libcxx/trunk/www/cxx1z_status.html Modified: libcxx/trunk/include/tgmath.h URL:

[PATCH] D42923: [CUDA] Allow external variables in separate compilation

2018-02-12 Thread Artem Belevich via Phabricator via cfe-commits
tra accepted this revision. tra added a comment. This revision is now accepted and ready to land. LGTM. Comment at: test/SemaCUDA/extern-shared.cu:4 +// These declarations are fine in separate compilation mode! +// RUN: %clang_cc1 -fsyntax-only -fcuda-rdc -verify=rdc %s +//

[PATCH] D43204: [OpenMP] Fix trailing space when printing pragmas

2018-02-12 Thread Joel E. Denny via Phabricator via cfe-commits
jdenny created this revision. jdenny added a reviewer: ABataev. Herald added a subscriber: guansong. -ast-print prints omp pragmas with a trailing space. While this behavior is likely of little concern to most users, surely it's unintentional, and it's annoying for some source-level work I'm

[PATCH] D43180: [clang-format] Support text proto extensions

2018-02-12 Thread Krasimir Georgiev via Phabricator via cfe-commits
krasimir updated this revision to Diff 133872. krasimir added a comment. - Add tests with long [...] Repository: rC Clang https://reviews.llvm.org/D43180 Files: lib/Format/ContinuationIndenter.cpp lib/Format/FormatToken.h lib/Format/TokenAnnotator.cpp

[PATCH] D43180: [clang-format] Support text proto extensions

2018-02-12 Thread Krasimir Georgiev via Phabricator via cfe-commits
krasimir marked an inline comment as done. krasimir added inline comments. Comment at: unittests/Format/FormatTestTextProto.cpp:317 + +TEST_F(FormatTestTextProto, FormatsExtensions) { + verifyFormat("[type] { key: value }"); djasper wrote: > It might be useful

[PATCH] D43197: [OpenMP] Add flag for linking runtime bitcode library

2018-02-12 Thread Gheorghe-Teodor Bercea via Phabricator via cfe-commits
gtbercea created this revision. gtbercea added reviewers: Hahnfeld, ABataev, carlo.bertolli, caomhin, grokos. Herald added subscribers: cfe-commits, guansong. This patch adds an additional flag to the OpenMP device offloading toolchain to link in the runtime library bitcode. Repository: rC

[PATCH] D35894: [clangd] Code hover for Clangd

2018-02-12 Thread Ilya Biryukov via Phabricator via cfe-commits
ilya-biryukov added a comment. In https://reviews.llvm.org/D35894#1003356, @simark wrote: > In https://reviews.llvm.org/D35894#1003342, @simark wrote: > > > The only problem I see is that when hovering a function/struct name, it now > > prints the whole function/struct definition. When talking

[PATCH] D43095: Make attribute-target on a Definition-after-use update the LLVM attributes

2018-02-12 Thread Eric Christopher via Phabricator via cfe-commits
echristo added inline comments. Comment at: lib/CodeGen/CodeGenModule.cpp:1318-1325 +llvm::AttrBuilder Attrs; +if (GetCPUAndFeaturesAttributes(D, Attrs)) { + // We know that GetCPUAndFeaturesAttributes will always have the + // newest set, since

[PATCH] D43181: [CodeGen] Initialize large arrays by copying from a global

2018-02-12 Thread John McCall via Phabricator via cfe-commits
rjmccall added inline comments. Comment at: lib/CodeGen/CGExprAgg.cpp:421 + // with explicit initializers should be large enough. + if (NumInitElements > 8 && elementType->isBuiltinType()) { +CodeGen::CodeGenModule = CGF.CGM; Is there a good reason to use

[PATCH] D42895: [libclang] Add `CXSymbolRole role` to CXIdxEntityRefInfo

2018-02-12 Thread Fangrui Song via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL324914: [libclang] Add `CXSymbolRole role` to CXIdxEntityRefInfo (authored by MaskRay, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D42895: [libclang] Add `CXSymbolRole role` to CXIdxEntityRefInfo

2018-02-12 Thread Fangrui Song via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC324914: [libclang] Add `CXSymbolRole role` to CXIdxEntityRefInfo (authored by MaskRay, committed by ). Changed prior to commit: https://reviews.llvm.org/D42895?vs=133632=133890#toc Repository: rL

r324917 - Add a unit test for Driver::getDefaultModuleCachePath().

2018-02-12 Thread Adrian Prantl via cfe-commits
Author: adrian Date: Mon Feb 12 09:59:54 2018 New Revision: 324917 URL: http://llvm.org/viewvc/llvm-project?rev=324917=rev Log: Add a unit test for Driver::getDefaultModuleCachePath(). Added: cfe/trunk/unittests/Driver/ModuleCacheTest.cpp Modified:

r324914 - [libclang] Add `CXSymbolRole role` to CXIdxEntityRefInfo

2018-02-12 Thread Fangrui Song via cfe-commits
Author: maskray Date: Mon Feb 12 09:42:09 2018 New Revision: 324914 URL: http://llvm.org/viewvc/llvm-project?rev=324914=rev Log: [libclang] Add `CXSymbolRole role` to CXIdxEntityRefInfo Summary: CXIdxEntityRefInfo contains the member `CXIdxEntityRefKind kind;` to differentiate implicit and

[PATCH] D43184: [WIP] [ItaniunCXXABI] Add an option for loading the type info vtable with dllimport

2018-02-12 Thread David Majnemer via Phabricator via cfe-commits
majnemer added a comment. Do I understand correctly that this workarounds a feature missing in lld? Does MinGW emit the same sorts of object files as clang in these scenarios? Repository: rC Clang https://reviews.llvm.org/D43184 ___ cfe-commits

Re: [PATCH] D43128: Introduce an API for LLDB to compute the default module cache path

2018-02-12 Thread David Blaikie via cfe-commits
Unit test? On Fri, Feb 9, 2018 at 10:45 AM Phabricator via Phabricator via llvm-commits wrote: > This revision was automatically updated to reflect the committed changes. > Closed by commit rL324761: Introduce an API for LLDB to compute the > default module cache

[PATCH] D43095: Make attribute-target on a Definition-after-use update the LLVM attributes

2018-02-12 Thread Eric Christopher via Phabricator via cfe-commits
echristo added inline comments. Comment at: lib/CodeGen/CodeGenModule.cpp:1318-1325 +llvm::AttrBuilder Attrs; +if (GetCPUAndFeaturesAttributes(D, Attrs)) { + // We know that GetCPUAndFeaturesAttributes will always have the + // newest set, since

[PATCH] D43197: [OpenMP] Add flag for linking runtime bitcode library

2018-02-12 Thread George Rokos via Phabricator via cfe-commits
grokos added inline comments. Comment at: lib/Driver/ToolChains/Cuda.cpp:559 +if (!FoundBCLibrary) + getDriver().Diag(diag::remark_drv_omp_offload_target_missingbcruntime); + } Should we be more specific when it comes to the name of the missing bc file

  1   2   >