[PATCH] D41537: Optionally add code completion results for arrow instead of dot

2018-02-22 Thread Ivan Donchevskii via Phabricator via cfe-commits
yvvan added a comment. Or is your idea is to return the char sequence instead to use this correction in some universal way? https://reviews.llvm.org/D41537 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D43547: [Indexing] Fixing inconsistencies between FUNCDNAME and generated code by improving ASTContext's API for MangleContext

2018-02-22 Thread Michael Haidl via Phabricator via cfe-commits
pacxx updated this revision to Diff 135372. pacxx retitled this revision from "[NameMangling] Make ASTContext owning the ManglingContext during entire compilation" to "[Indexing] Fixing inconsistencies between FUNCDNAME and generated code by improving ASTContext's API for MangleContext". pacxx

[PATCH] D43579: [libcxx] Do not include the C math.h header before __config

2018-02-22 Thread Mikhail Maltsev via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL325760: [libcxx] Do not include the C math.h header before __config (authored by miyuki, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D39571: [clangd] DidChangeConfiguration Notification

2018-02-22 Thread Ilya Biryukov via Phabricator via cfe-commits
ilya-biryukov accepted this revision. ilya-biryukov added a comment. Thanks for fixing all the comments! LGTM! Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D39571 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D43614: Define _PTHREADS for -pthread on NetBSD

2018-02-22 Thread Kamil Rytarowski via Phabricator via cfe-commits
krytarowski created this revision. krytarowski added reviewers: joerg, rnk. krytarowski added a project: clang. Herald added a subscriber: llvm-commits. GCC and PCC define _PTHREADS for -pthreads on NetBSD. The _PTHREADS preprocessor macro is used in the NetBSD header in . NetBSD uses both:

[PATCH] D43570: [OpenCL] Add '-cl-uniform-work-group-size' compile option

2018-02-22 Thread Kristina Bessonova via Phabricator via cfe-commits
krisb updated this revision to Diff 135375. krisb added a comment. Herald added a subscriber: nhaehnle. Updated one more test where attributes became mismatched. Repository: rC Clang https://reviews.llvm.org/D43570 Files: include/clang/Driver/Options.td

[PATCH] D43518: [clangd] Allow embedders some control over when diagnostics are generated.

2018-02-22 Thread Sam McCall via Phabricator via cfe-commits
sammccall added a comment. Not convinced about the flow control stuff - I think you might be underestimating the complexity of the cancellation-based approach with the extra functionality. But if you think it would still be more readable the other way, happy to get a third opinion.

[clang-tools-extra] r325764 - [clangd] Not collect include headers for dynamic index for now.

2018-02-22 Thread Eric Liu via cfe-commits
Author: ioeric Date: Thu Feb 22 02:14:05 2018 New Revision: 325764 URL: http://llvm.org/viewvc/llvm-project?rev=325764=rev Log: [clangd] Not collect include headers for dynamic index for now. Summary: The new behaviors introduced by this patch: o When include collection is enabled, we always set

[PATCH] D43518: [clangd] Allow embedders some control over when diagnostics are generated.

2018-02-22 Thread Sam McCall via Phabricator via cfe-commits
sammccall updated this revision to Diff 135382. sammccall marked an inline comment as done. sammccall added a comment. add param names to decls Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D43518 Files: clangd/ClangdLSPServer.cpp clangd/ClangdServer.cpp

[PATCH] D43550: [clangd] Not collect include headers for dynamic index for now.

2018-02-22 Thread Eric Liu via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL325764: [clangd] Not collect include headers for dynamic index for now. (authored by ioeric, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM

[clang-tools-extra] r325774 - [clangd] Allow embedders some control over when diagnostics are generated.

2018-02-22 Thread Sam McCall via cfe-commits
Author: sammccall Date: Thu Feb 22 05:11:12 2018 New Revision: 325774 URL: http://llvm.org/viewvc/llvm-project?rev=325774=rev Log: [clangd] Allow embedders some control over when diagnostics are generated. Summary: Through the C++ API, we support for a given snapshot version: - Yes: make sure

[PATCH] D43569: [clangd] Correct setting ignoreWarnings in CodeCompletion.

2018-02-22 Thread Haojian Wu via Phabricator via cfe-commits
hokein updated this revision to Diff 135399. hokein added a comment. - add a comment - find one more incorrect usage, and fix it. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D43569 Files: clangd/CodeComplete.cpp clangd/Headers.cpp Index: clangd/Headers.cpp

[PATCH] D43569: [clangd] Correct setting ignoreWarnings in CodeCompletion.

2018-02-22 Thread Haojian Wu via Phabricator via cfe-commits
hokein marked an inline comment as done. hokein added inline comments. Comment at: clangd/CodeComplete.cpp:705 } + CI->getDiagnosticOpts().IgnoreWarnings = true; auto Clang = prepareCompilerInstance( ilya-biryukov wrote: > Could we add a comment that this

[clang-tools-extra] r325779 - [clangd] Correct setting ignoreWarnings in CodeCompletion.

2018-02-22 Thread Haojian Wu via cfe-commits
Author: hokein Date: Thu Feb 22 05:35:01 2018 New Revision: 325779 URL: http://llvm.org/viewvc/llvm-project?rev=325779=rev Log: [clangd] Correct setting ignoreWarnings in CodeCompletion. Summary: We should set the flag before creating ComplierInstance -- when CopmilerInstance gets initialized,

[PATCH] D41102: Setup clang-doc frontend framework

2018-02-22 Thread Roman Lebedev via Phabricator via cfe-commits
lebedev.ri added inline comments. Comment at: clang-doc/BitcodeWriter.cpp:149 + +/// \brief Emits a record ID in the BLOCKINFO block. +void ClangDocBitcodeWriter::emitRecordID(RecordId ID) { For me, with no prior knowledge of llvm's bitstreams, it was not

[PATCH] D43518: [clangd] Allow embedders some control over when diagnostics are generated.

2018-02-22 Thread Ilya Biryukov via Phabricator via cfe-commits
ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM (just one more possibly useful nit about const) Comment at: clangd/TUScheduler.cpp:298 + while (shouldSkipHeadLocked()) +

[PATCH] D43569: [clangd] Correct setting ignoreWarnings in CodeCompletion.

2018-02-22 Thread Ilya Biryukov via Phabricator via cfe-commits
ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM with a minor nit. Comment at: clangd/CodeComplete.cpp:705 } + CI->getDiagnosticOpts().IgnoreWarnings = true; auto Clang = prepareCompilerInstance(

[PATCH] D43518: [clangd] Allow embedders some control over when diagnostics are generated.

2018-02-22 Thread Sam McCall via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL325774: [clangd] Allow embedders some control over when diagnostics are generated. (authored by sammccall, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D43500: [clang-tidy]: modernize-use-default-member-init: Remove trailing comma and colon.

2018-02-22 Thread Alexander Kornienko via Phabricator via cfe-commits
alexfh added a reviewer: ioeric. alexfh added a comment. In https://reviews.llvm.org/D43500#1013497, @aaron.ballman wrote: > > It seems, when they are apply directly from clang-tidy, the RefactoringTool > > engine is smart enough to remove trailing tokens. However, when fixes are > > exported,

[PATCH] D43569: [clangd] Correct setting ignoreWarnings in CodeCompletion.

2018-02-22 Thread Haojian Wu via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. hokein marked an inline comment as done. Closed by commit rL325779: [clangd] Correct setting ignoreWarnings in CodeCompletion. (authored by hokein, committed by ). Herald added a subscriber: llvm-commits. Repository: rL

[PATCH] D41537: Optionally add code completion results for arrow instead of dot

2018-02-22 Thread Ilya Biryukov via Phabricator via cfe-commits
ilya-biryukov added a comment. In https://reviews.llvm.org/D41537#1015563, @yvvan wrote: > Or is your idea is to return the char sequence instead to use this correction > in some universal way? Exactly. Editors that implement corrections would pick up any new corrections automatically,

Re: r324308 - Fix crash on invalid.

2018-02-22 Thread Hans Wennborg via cfe-commits
Seems safe. Merged in r325766. On Thu, Feb 22, 2018 at 1:15 AM, Richard Trieu wrote: > Hi Hans, > > If there's still time for rc3, I'd like to get this crash fix in. This adds > a null check to prevent a crash on invalid. > > Richard > > On Mon, Feb 5, 2018 at 6:58 PM,

[PATCH] D41880: Adding nocf_check attribute for cf-protection fine tuning

2018-02-22 Thread Oren Ben Simhon via Phabricator via cfe-commits
oren_ben_simhon updated this revision to Diff 135386. oren_ben_simhon added a comment. Implemented comments posted until 02/22 (Thanks Aaron). Repository: rL LLVM https://reviews.llvm.org/D41880 Files: include/clang/AST/Type.h include/clang/Basic/Attr.td

[PATCH] D41880: Adding nocf_check attribute for cf-protection fine tuning

2018-02-22 Thread Oren Ben Simhon via Phabricator via cfe-commits
oren_ben_simhon marked 2 inline comments as done. oren_ben_simhon added a comment. I added a comment ignoring nocf_check attribute in case -fcf-protection is not set. Now LLVM is identical to GCC. Comment at: test/Sema/attr-nocf_check.c:18-20 + FuncPointerWithNoCfCheck

[PATCH] D43570: [OpenCL] Add '-cl-uniform-work-group-size' compile option

2018-02-22 Thread Alexey Sotkin via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL325771: [OpenCL] Add -cl-uniform-work-group-size compile option (authored by AlexeySotkin, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D43570

[PATCH] D43518: [clangd] Allow embedders some control over when diagnostics are generated.

2018-02-22 Thread Ilya Biryukov via Phabricator via cfe-commits
ilya-biryukov added inline comments. Comment at: clangd/TUScheduler.cpp:298 + while (shouldSkipHeadLocked()) +Requests.pop_front(); + assert(!Requests.empty() && "skipped the whole queue"); sammccall wrote: > ilya-biryukov wrote: > > Instead of

[PATCH] D43621: [Driver] Allow using a canonical form of '-fuse-ld=' when cross-compiling on Windows.

2018-02-22 Thread Igor Kudrin via Phabricator via cfe-commits
ikudrin added inline comments. Comment at: lib/Driver/ToolChain.cpp:415 // second-guess that. -if (llvm::sys::fs::exists(UseLinker)) +if (llvm::sys::fs::can_execute(UseLinker)) return UseLinker; Hahnfeld wrote: > I don't think we should do

[PATCH] D42840: [docs] Fix duplicate arguments for JoinedAndSeparate

2018-02-22 Thread Jonas Hahnfeld via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL325805: [docs] Fix duplicate arguments for JoinedAndSeparate (authored by Hahnfeld, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D42841: [docs] Improve help for OpenMP options

2018-02-22 Thread Jonas Hahnfeld via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL325806: [docs] Improve help for OpenMP options, NFC. (authored by Hahnfeld, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D43634: [clangd] Extend textDocument/didChange to specify whether diagnostics should be generated.

2018-02-22 Thread Eric Liu via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rCTE325813: [clangd] Extend textDocument/didChange to specify whether diagnostics should be… (authored by ioeric, committed by ). Changed prior to commit:

[PATCH] D42644: [asan] Intercept std::rethrow_exception indirectly.

2018-02-22 Thread Robert Schneider via Phabricator via cfe-commits
robot marked an inline comment as done. robot added a comment. Have you had the time to review the second revision? Repository: rCRT Compiler Runtime https://reviews.llvm.org/D42644 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D43621: [Driver] Allow using a canonical form of '-fuse-ld=' when cross-compiling on Windows.

2018-02-22 Thread Igor Kudrin via Phabricator via cfe-commits
ikudrin created this revision. ikudrin added reviewers: phosek, Hahnfeld, logan, rnk. ikudrin added a project: clang. Right now, we have to add an `.exe` suffix when using this switch, like `-fuse-ld=lld.exe`. If the suffix is omitted, `llvm::sys::fs::exists()` cannot find the file on Windows,

Re: [libcxx] r323971 - Remove ; use instead. See https://libcxx.llvm.org/TS_deprecation.html

2018-02-22 Thread Nico Weber via cfe-commits
I have a small personal project where I used to use this. I tried switching to instead, but that apparently requires -std=c++17. With that, things build fine with my locally-built clang, but latest Xcode clang doesn't accept that flag yet. So I tried -std=c++1z, but latest Xcode (9.2) doesn't

[PATCH] D43625: [OpenMP] Remove implicit data sharing code gen that aims to use device shared memory

2018-02-22 Thread Alexey Bataev via Phabricator via cfe-commits
ABataev added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntimeNVPTX.cpp:564 +llvm::Value *FnArgs[] = {ZeroAddr.getPointer(), ZeroAddr.getPointer()}; +emitCall(CGF, Fn, FnArgs); Pass non-null `SourceLocation` here as the last argument

[PATCH] D43630: [Driver] Fix search paths on x32

2018-02-22 Thread James Clarke via Phabricator via cfe-commits
jrtc27 created this revision. Herald added a subscriber: cfe-commits. When targeting x32, the x32 libraries and headers should be used, not the x86_64 ones (which may not even be available), so prioritise those and use the right multiarch triple. Repository: rC Clang

[PATCH] D43500: [clang-tidy]: modernize-use-default-member-init: Remove trailing comma and colon.

2018-02-22 Thread Eric Liu via Phabricator via cfe-commits
ioeric added a comment. In https://reviews.llvm.org/D43500#1015208, @jdemeule wrote: > In https://reviews.llvm.org/D43500#1013558, @malcolm.parsons wrote: > > > In https://reviews.llvm.org/D43500#1013497, @aaron.ballman wrote: > > > > > Is there a way to make clang-apply-replacements smarter

[PATCH] D43634: [clangd] Extend textDocument/didChange to specify whether diagnostics should be generated.

2018-02-22 Thread Sam McCall via Phabricator via cfe-commits
sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Nice, this will be useful for at least a couple of editor integrations. Comment at: clangd/Protocol.h:301 + + /// If this is not set, diagnostics will be generated

[clang-tools-extra] r325801 - [clangd] fix test use-after-free from r325774

2018-02-22 Thread Sam McCall via cfe-commits
Author: sammccall Date: Thu Feb 22 07:33:33 2018 New Revision: 325801 URL: http://llvm.org/viewvc/llvm-project?rev=325801=rev Log: [clangd] fix test use-after-free from r325774 Modified: clang-tools-extra/trunk/unittests/clangd/TUSchedulerTests.cpp Modified:

[PATCH] D43621: [Driver] Allow using a canonical form of '-fuse-ld=' when cross-compiling on Windows.

2018-02-22 Thread Jonas Hahnfeld via Phabricator via cfe-commits
Hahnfeld added inline comments. Comment at: lib/Driver/ToolChain.cpp:415 // second-guess that. -if (llvm::sys::fs::exists(UseLinker)) +if (llvm::sys::fs::can_execute(UseLinker)) return UseLinker; I don't think we should do this for absolute

r325805 - [docs] Fix duplicate arguments for JoinedAndSeparate

2018-02-22 Thread Jonas Hahnfeld via cfe-commits
Author: hahnfeld Date: Thu Feb 22 09:06:27 2018 New Revision: 325805 URL: http://llvm.org/viewvc/llvm-project?rev=325805=rev Log: [docs] Fix duplicate arguments for JoinedAndSeparate We can't see how many arguments are in the meta var name, so just assume that it is the right number.

r325806 - [docs] Improve help for OpenMP options, NFC.

2018-02-22 Thread Jonas Hahnfeld via cfe-commits
Author: hahnfeld Date: Thu Feb 22 09:06:35 2018 New Revision: 325806 URL: http://llvm.org/viewvc/llvm-project?rev=325806=rev Log: [docs] Improve help for OpenMP options, NFC. * Add HelpText for -fopenmp so that it appears in clang --help. * Hide -fno-openmp-simd, only list the positive option.

[PATCH] D43590: [clang-format] Fix regression when getStyle() called with empty filename

2018-02-22 Thread Bjorn Pettersson via Phabricator via cfe-commits
bjope added inline comments. Comment at: unittests/Format/FormatTest.cpp:11727 +TEST(FormatStyle, GetStyleWithEmptyFileName) { + auto Style1 = getStyle("file", "", "Google"); + ASSERT_TRUE((bool)Style1); Do you really want to try to find a ".clang-format" file

[PATCH] D42366: [CodeGen] Fix generation of TBAA tags for may-alias accesses

2018-02-22 Thread Hal Finkel via Phabricator via cfe-commits
hfinkel added a comment. In https://reviews.llvm.org/D42366#1014546, @rjmccall wrote: > In https://reviews.llvm.org/D42366#1014157, @kosarev wrote: > > > I think zero would serve better as the unknown-size value. People who are > > not aware of TBAA internals would guess that since zero-sized

r325812 - [OPENMP] Require valid SourceLocation in function call, NFC.

2018-02-22 Thread Alexey Bataev via cfe-commits
Author: abataev Date: Thu Feb 22 10:33:31 2018 New Revision: 325812 URL: http://llvm.org/viewvc/llvm-project?rev=325812=rev Log: [OPENMP] Require valid SourceLocation in function call, NFC. Removed default empty SourceLocation argument from `emitCall` function and require valid location.

[PATCH] D43621: [Driver] Allow using a canonical form of '-fuse-ld=' when cross-compiling on Windows.

2018-02-22 Thread Adrian McCarthy via Phabricator via cfe-commits
amccarth added a comment. > Right now, we have to add an .exe suffix when using this switch, like > -fuse-ld=lld.exe. That's weird, because lots of lldb tests compile and link test binaries on Windows with `-fuse-ld=lld` (without the `.exe`). What makes you say the `.exe` is necessary?

[PATCH] D41228: [ObjC] Enable __strong pointers in structs under ARC

2018-02-22 Thread Akira Hatanaka via Phabricator via cfe-commits
ahatanak added inline comments. Comment at: include/clang/AST/Type.h:1121 + /// after it is moved, as opposed to a truely destructive move in which the + /// source object is placed in an uninitialized state. + PrimitiveCopyKind isNonTrivialToPrimitiveDestructiveMove() const;

[PATCH] D43513: [OpenMP] Limit reduction support for pragma 'distribute' when combined with pragma 'simd'

2018-02-22 Thread Carlo Bertolli via Phabricator via cfe-commits
carlo.bertolli updated this revision to Diff 135429. carlo.bertolli added a comment. [OpenMP] Add regression test: this verifies that only one call to the runtime for reduction is done in a combined construct with distribute, without simd, and with at least one pragma accepting reduction as a

[PATCH] D43634: [clangd] Extend textDocument/didChange to specify whether diagnostics should be generated.

2018-02-22 Thread Eric Liu via Phabricator via cfe-commits
ioeric updated this revision to Diff 135463. ioeric marked 2 inline comments as done. ioeric added a comment. Addressed review comments. Removed test. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D43634 Files: clangd/ClangdLSPServer.cpp clangd/Protocol.cpp

[clang-tools-extra] r325813 - [clangd] Extend textDocument/didChange to specify whether diagnostics should be generated.

2018-02-22 Thread Eric Liu via cfe-commits
Author: ioeric Date: Thu Feb 22 10:40:39 2018 New Revision: 325813 URL: http://llvm.org/viewvc/llvm-project?rev=325813=rev Log: [clangd] Extend textDocument/didChange to specify whether diagnostics should be generated. Summary: This would allow us to disable diagnostics when didChange is called

r325814 - [CUDA] Added missing functions.

2018-02-22 Thread Artem Belevich via cfe-commits
Author: tra Date: Thu Feb 22 10:40:52 2018 New Revision: 325814 URL: http://llvm.org/viewvc/llvm-project?rev=325814=rev Log: [CUDA] Added missing functions. Initial commit missed sincos(float), llabs() and few atomics that we used to pull in from device_functions.hpp, which we no longer include.

[PATCH] D43621: [Driver] Allow using a canonical form of '-fuse-ld=' when cross-compiling on Windows.

2018-02-22 Thread Adrian McCarthy via Phabricator via cfe-commits
amccarth added a comment. This must be new-ish code, since I've routinely used `-fuse-ld=lld` (without `.exe`) on Windows. Repository: rC Clang https://reviews.llvm.org/D43621 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang-tools-extra] r325802 - Fix "not all control paths return a value" MSVC warning. NFCI.

2018-02-22 Thread Simon Pilgrim via cfe-commits
Author: rksimon Date: Thu Feb 22 08:12:27 2018 New Revision: 325802 URL: http://llvm.org/viewvc/llvm-project?rev=325802=rev Log: Fix "not all control paths return a value" MSVC warning. NFCI. Modified: clang-tools-extra/trunk/clangd/TUScheduler.cpp Modified:

[PATCH] D43625: [OpenMP] Remove implicit data sharing code gen that aims to use device shared memory

2018-02-22 Thread Gheorghe-Teodor Bercea via Phabricator via cfe-commits
gtbercea created this revision. gtbercea added reviewers: ABataev, carlo.bertolli, caomhin. Herald added subscribers: cfe-commits, guansong, jholewinski. Remove this scheme for now since it will be covered by another more generic scheme using global memory. This code will be worked into an

r325807 - [docs] Regenerate command line reference

2018-02-22 Thread Jonas Hahnfeld via cfe-commits
Author: hahnfeld Date: Thu Feb 22 09:10:28 2018 New Revision: 325807 URL: http://llvm.org/viewvc/llvm-project?rev=325807=rev Log: [docs] Regenerate command line reference Modified: cfe/trunk/docs/ClangCommandLineReference.rst Modified: cfe/trunk/docs/ClangCommandLineReference.rst URL:

[PATCH] D41102: Setup clang-doc frontend framework

2018-02-22 Thread Julie Hockett via Phabricator via cfe-commits
juliehockett updated this revision to Diff 135453. juliehockett marked 13 inline comments as done. juliehockett added a comment. Cleaning up bitcode writer https://reviews.llvm.org/D41102 Files: CMakeLists.txt clang-doc/BitcodeWriter.cpp clang-doc/BitcodeWriter.h

[PATCH] D41102: Setup clang-doc frontend framework

2018-02-22 Thread Julie Hockett via Phabricator via cfe-commits
juliehockett added inline comments. Comment at: clang-doc/BitcodeWriter.cpp:219 + +void ClangDocBitcodeWriter::emitIntRecord(int Value, RecordId ID) { + if (!Value) return; lebedev.ri wrote: > Now, all these three `emit*Record` functions now have the 'same

[PATCH] D43513: [OpenMP] Limit reduction support for pragma 'distribute' when combined with pragma 'simd'

2018-02-22 Thread Alexey Bataev via Phabricator via cfe-commits
ABataev added a comment. LG Repository: rC Clang https://reviews.llvm.org/D43513 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D43621: [Driver] Allow using a canonical form of '-fuse-ld=' when cross-compiling on Windows.

2018-02-22 Thread Jonas Hahnfeld via Phabricator via cfe-commits
Hahnfeld added a comment. In https://reviews.llvm.org/D43621#1015888, @amccarth wrote: > This must be new-ish code, since I've routinely used `-fuse-ld=lld` (without > `.exe`) on Windows. Well, since 12/2016: https://reviews.llvm.org/rC289668 Repository: rC Clang

[PATCH] D43628: [Sema][NFC] Split Function MultiVersioning decl semantic analysis into its own .cpp file.

2018-02-22 Thread Erich Keane via Phabricator via cfe-commits
erichkeane created this revision. erichkeane added reviewers: rnk, echristo, aaron.ballman, rsmith. Herald added subscribers: mgrang, mgorny. I'm currently working on the cpu_dispatch and cpu_specific multiversion support, which is making this functionality require a significant amount of

[PATCH] D43634: [clangd] Extend textDocument/didChange to specify whether diagnostics should be generated.

2018-02-22 Thread Eric Liu via Phabricator via cfe-commits
ioeric created this revision. ioeric added a reviewer: sammccall. Herald added subscribers: cfe-commits, jkorous-apple, ilya-biryukov, klimek. This would allow us to disable diagnostics when didChange is called but diagnostics are not wanted (e.g. code completion). Repository: rCTE Clang

[PATCH] D43581: [clang-tidy/google] Fix the Objective-C global variable declaration check 

2018-02-22 Thread Yan Zhang via Phabricator via cfe-commits
Wizard requested changes to this revision. Wizard added a comment. This revision now requires changes to proceed. Please update the warning info to indicate that prefix 'k' is not the only option for constants. Something like: "const global variable '%0' must have an appropriate prefix or a name

[PATCH] D43576: Solution to fix PR27066 - Redefinition with same mangled name as another definition (dllexport and uuid)

2018-02-22 Thread Erich Keane via Phabricator via cfe-commits
erichkeane added a comment. It seems to me that the test here is very much lacking. It doesn't seem to include the example you've mentioned, and has no validation to ensure that there is a single instantiation happening. I'd like to see what happens when a UUID is passed as a pack, how

[PATCH] D42776: [Sema] Fix an assertion failure in constant expression evaluation of calls to functions with default arguments

2018-02-22 Thread Akira Hatanaka via Phabricator via cfe-commits
ahatanak added a comment. ping https://reviews.llvm.org/D42776 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D41228: [ObjC] Enable __strong pointers in structs under ARC

2018-02-22 Thread John McCall via Phabricator via cfe-commits
rjmccall added inline comments. Comment at: include/clang/AST/Type.h:1121 + /// after it is moved, as opposed to a truely destructive move in which the + /// source object is placed in an uninitialized state. + PrimitiveCopyKind isNonTrivialToPrimitiveDestructiveMove() const;

[PATCH] D43576: Solution to fix PR27066 - Redefinition with same mangled name as another definition (dllexport and uuid)

2018-02-22 Thread Zahira Ammarguellat via Phabricator via cfe-commits
zahiraam added a comment. In https://reviews.llvm.org/D43576#1016295, @majnemer wrote: > We should really, really avoid making this sort of change without first > trying to desugar uuidof into a reference to a variable. That would solve a > ton of problems, problems like this one. Not sure I

[PATCH] D43640: add support for constants with appropriate prefix. Start with 'k' is not the only option. This is according to http://google.github.io/styleguide/objcguide.html#constants

2018-02-22 Thread Yan Zhang via Phabricator via cfe-commits
Wizard created this revision. Herald added subscribers: cfe-commits, klimek. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D43640 Files: clang-tidy/google/GlobalVariableDeclarationCheck.cpp test/clang-tidy/google-objc-global-variable-declaration.m Index:

r325822 - [OpenMP] Limit reduction support for pragma 'distribute' when combined with pragma 'simd'

2018-02-22 Thread Carlo Bertolli via cfe-commits
Author: cbertol Date: Thu Feb 22 11:38:14 2018 New Revision: 325822 URL: http://llvm.org/viewvc/llvm-project?rev=325822=rev Log: [OpenMP] Limit reduction support for pragma 'distribute' when combined with pragma 'simd' Differential Revision: https://reviews.llvm.org/D43513 This is a bug fix

Re: r324308 - Fix crash on invalid.

2018-02-22 Thread Richard Trieu via cfe-commits
Thanks, Hans! On Thu, Feb 22, 2018 at 3:27 AM, Hans Wennborg wrote: > Seems safe. Merged in r325766. > > On Thu, Feb 22, 2018 at 1:15 AM, Richard Trieu wrote: > > Hi Hans, > > > > If there's still time for rc3, I'd like to get this crash fix in. This >

[PATCH] D43533: [CFG] [analyzer] NFC: Refactor ConstructionContext into a finite set of cases.

2018-02-22 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ updated this revision to Diff 135480. NoQ added a comment. Address comments. https://reviews.llvm.org/D43533 Files: include/clang/Analysis/CFG.h include/clang/Analysis/ConstructionContext.h lib/Analysis/CFG.cpp lib/Analysis/CMakeLists.txt lib/Analysis/ConstructionContext.cpp

[PATCH] D34367: CodeGen: Fix address space of indirect function argument

2018-02-22 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl updated this revision to Diff 135474. yaxunl added a comment. Revised by John's comments. https://reviews.llvm.org/D34367 Files: lib/CodeGen/CGAtomic.cpp lib/CodeGen/CGCall.cpp lib/CodeGen/CGCall.h lib/CodeGen/CGClass.cpp lib/CodeGen/CGDecl.cpp lib/CodeGen/CGExprCXX.cpp

[PATCH] D43513: [OpenMP] Limit reduction support for pragma 'distribute' when combined with pragma 'simd'

2018-02-22 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL325822: [OpenMP] Limit reduction support for pragma distribute when combined with… (authored by cbertol, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D43581: [clang-tidy/google] Fix the Objective-C global variable declaration check 

2018-02-22 Thread Yan Zhang via Phabricator via cfe-commits
Wizard accepted this revision. Wizard added a comment. This revision is now accepted and ready to land. In https://reviews.llvm.org/D43581#1016318, @stephanemoore wrote: > In https://reviews.llvm.org/D43581#1016300, @Wizard wrote: > > > Please update the warning info to indicate that prefix 'k'

[PATCH] D43581: [clang-tidy/google] Fix the Objective-C global variable declaration check 

2018-02-22 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added inline comments. Comment at: clang-tidy/google/GlobalVariableDeclarationCheck.cpp:92 + "an appropriate prefix (see " + "http://google.github.io/styleguide/objcguide#constants).") << Decl->getName() << generateFixItHint(Decl, true);

[PATCH] D43581: [clang-tidy/google] Fix the Objective-C global variable declaration check 

2018-02-22 Thread Stephane Moore via Phabricator via cfe-commits
stephanemoore added a comment. In https://reviews.llvm.org/D43581#1016327, @Wizard wrote: > In https://reviews.llvm.org/D43581#1016318, @stephanemoore wrote: > > > In https://reviews.llvm.org/D43581#1016300, @Wizard wrote: > > > > > Please update the warning info to indicate that prefix 'k' is

[PATCH] D43576: Solution to fix PR27066 - Redefinition with same mangled name as another definition (dllexport and uuid)

2018-02-22 Thread Zahira Ammarguellat via Phabricator via cfe-commits
zahiraam updated this revision to Diff 135502. https://reviews.llvm.org/D43576 Files: test/CodeGenCXX/instantiate-uuid.cpp test/Sema/member-reference-dll.cpp Index: test/Sema/member-reference-dll.cpp === ---

[PATCH] D43576: Solution to fix PR27066 - Redefinition with same mangled name as another definition (dllexport and uuid)

2018-02-22 Thread Zahira Ammarguellat via Phabricator via cfe-commits
zahiraam added a comment. Adding test case. https://reviews.llvm.org/D43576 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D43640: add support for constants with appropriate prefix. Start with 'k' is not the only option. This is according to http://google.github.io/styleguide/objcguide.html#constants

2018-02-22 Thread Stephane Moore via Phabricator via cfe-commits
stephanemoore added a comment. I have this change out for review as well: https://reviews.llvm.org/D43581 Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D43640 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D43581: [clang-tidy/google] Fix the Objective-C global variable declaration check 

2018-02-22 Thread Stephane Moore via Phabricator via cfe-commits
stephanemoore updated this revision to Diff 135489. stephanemoore added a comment. I forgot to update the diagnostic message per the change. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D43581 Files: clang-tidy/google/GlobalVariableDeclarationCheck.cpp

[PATCH] D43640: add support for constants with appropriate prefix. Start with 'k' is not the only option. This is according to http://google.github.io/styleguide/objcguide.html#constants

2018-02-22 Thread Yan Zhang via Phabricator via cfe-commits
Wizard added a comment. In https://reviews.llvm.org/D43640#1016287, @stephanemoore wrote: > I have this change out for review as well: > https://reviews.llvm.org/D43581 Ah cool. Your change looks good. Technically the same as mine. I will discard this diff. Repository: rCTE Clang Tools

[PATCH] D43576: Solution to fix PR27066 - Redefinition with same mangled name as another definition (dllexport and uuid)

2018-02-22 Thread David Majnemer via Phabricator via cfe-commits
majnemer added a comment. We should really, really avoid making this sort of change without first trying to desugar uuidof into a reference to a variable. That would solve a ton of problems, problems like this one. https://reviews.llvm.org/D43576

[PATCH] D43581: [clang-tidy/google] Fix the Objective-C global variable declaration check 

2018-02-22 Thread Stephane Moore via Phabricator via cfe-commits
stephanemoore updated this revision to Diff 135497. stephanemoore added a comment. Update the diagnostic information to link to the Google Objective-C style guide for guidance on an appropriate prefix. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D43581 Files:

[PATCH] D43581: [clang-tidy/google] Fix the Objective-C global variable declaration check 

2018-02-22 Thread Stephane Moore via Phabricator via cfe-commits
stephanemoore updated this revision to Diff 135510. stephanemoore added a comment. Revert the inclusion of the link to the Google Objective-C style guide in the diagnostic message. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D43581 Files:

[PATCH] D43640: add support for constants with appropriate prefix. Start with 'k' is not the only option. This is according to http://google.github.io/styleguide/objcguide.html#constants

2018-02-22 Thread Yan Zhang via Phabricator via cfe-commits
Wizard updated this revision to Diff 135485. Wizard added a comment. fix format Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D43640 Files: clang-tidy/google/GlobalVariableDeclarationCheck.cpp test/clang-tidy/google-objc-global-variable-declaration.m Index:

[PATCH] D43581: [clang-tidy/google] Fix the Objective-C global variable declaration check 

2018-02-22 Thread Stephane Moore via Phabricator via cfe-commits
stephanemoore added a comment. In https://reviews.llvm.org/D43581#1016300, @Wizard wrote: > Please update the warning info to indicate that prefix 'k' is not the only > option for constants. Something like: > "const global variable '%0' must have an appropriate prefix or a name which > starts

[PATCH] D43602: [CUDA] Added missing functions.

2018-02-22 Thread Artem Belevich via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC325814: [CUDA] Added missing functions. (authored by tra, committed by ). Changed prior to commit: https://reviews.llvm.org/D43602?vs=135348=135466#toc Repository: rC Clang

[PATCH] D43533: [CFG] [analyzer] NFC: Refactor ConstructionContext into a finite set of cases.

2018-02-22 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ added inline comments. Comment at: include/clang/Analysis/ConstructionContext.h:119 + static const ConstructionContext * + finalize(BumpVectorContext , const ConstructionContextLayer *TopLayer); + a.sidorin wrote: > Maybe just `build()`? For me,

[PATCH] D43105: [RISCV] Enable __int128_t and __uint128_t through clang flag

2018-02-22 Thread Mandeep Singh Grang via Phabricator via cfe-commits
mgrang updated this revision to Diff 135493. mgrang retitled this revision from "[RISCV] Enable __int128_t and uint128_t through clang flag" to "[RISCV] Enable __int128_t and __uint128_t through clang flag". mgrang edited the summary of this revision. Repository: rC Clang

[PATCH] D43322: Diagnose cases of "return x" that should be "return std::move(x)" for efficiency

2018-02-22 Thread Arthur O'Dwyer via Phabricator via cfe-commits
Quuxplusone updated this revision to Diff 135484. Quuxplusone added a reviewer: rsmith. Quuxplusone added a subscriber: Rakete. Quuxplusone added a comment. Eliminate a couple of `auto` per comment by @Rakete. Repository: rC Clang https://reviews.llvm.org/D43322 Files:

[PATCH] D34367: CodeGen: Fix address space of indirect function argument

2018-02-22 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl updated this revision to Diff 135499. yaxunl added a comment. sync to ToT. https://reviews.llvm.org/D34367 Files: lib/CodeGen/CGAtomic.cpp lib/CodeGen/CGCall.cpp lib/CodeGen/CGCall.h lib/CodeGen/CGClass.cpp lib/CodeGen/CGDecl.cpp lib/CodeGen/CGExprCXX.cpp

[PATCH] D34367: CodeGen: Fix address space of indirect function argument

2018-02-22 Thread John McCall via Phabricator via cfe-commits
rjmccall added inline comments. Comment at: lib/CodeGen/CGCall.cpp:3446 + return LV.asAggregateRValue(); +} + No, I don't think this is right. This method should always return an independent RValue; if the CallArg is storing an LValue, it should copy from it

[PATCH] D43581: [clang-tidy/google] Fix the Objective-C global variable declaration check 

2018-02-22 Thread Yan Zhang via Phabricator via cfe-commits
Wizard added inline comments. Comment at: clang-tidy/google/GlobalVariableDeclarationCheck.cpp:92 + "an appropriate prefix (see " + "http://google.github.io/styleguide/objcguide#constants).") << Decl->getName() << generateFixItHint(Decl, true);

[PATCH] D42776: [Sema] Fix an assertion failure in constant expression evaluation of calls to functions with default arguments

2018-02-22 Thread Richard Smith - zygoloid via Phabricator via cfe-commits
rsmith added a comment. Thank you, this looks like a great direction. As noted, there are a bunch of other cases that we should cover with this approach. I'm really happy about the number of related bugs we get to fix with this change. Comment at:

[PATCH] D43105: [RISCV] Enable __int128_t and __uint128_t through clang flag

2018-02-22 Thread Mandeep Singh Grang via Phabricator via cfe-commits
mgrang added a comment. Added tests for ABI lowering and preprocessor defines as per comments. Repository: rC Clang https://reviews.llvm.org/D43105 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D43362: Simplify setting dso_local. NFC.

2018-02-22 Thread Eric Christopher via Phabricator via cfe-commits
echristo accepted this revision. echristo added a comment. This revision is now accepted and ready to land. LGTM. Thanks for the cleanup. https://reviews.llvm.org/D43362 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D43657: [analyzer] dump() dynamic type info and taint into state dumps.

2018-02-22 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ created this revision. NoQ added reviewers: dcoughlin, xazax.hun, a.sidorin, george.karpenkov, szepet. Herald added subscribers: cfe-commits, rnkovacs. More dumps! Eg.: Dynamic types of regions: x : class PR13569_virtual::Child Taint dumps were already implemented, so i added them

Re: [PATCH] D43514: Start settinng dso_local for COFF

2018-02-22 Thread Rafael Avila de Espindola via cfe-commits
Eric Christopher via Phabricator writes: > echristo added inline comments. > > > > Comment at: lib/CodeGen/CodeGenModule.h:728 > + /// This must be called after dllimport/dllexport is set. > + /// FIXME: should this set dllimport/dllexport instead? >

[PATCH] D43576: Solution to fix PR27066 - Redefinition with same mangled name as another definition (dllexport and uuid)

2018-02-22 Thread Richard Smith - zygoloid via Phabricator via cfe-commits
rsmith added a comment. In https://reviews.llvm.org/D43576#1016561, @majnemer wrote: > Here's my thinking: the `__uuidof` expression literally declares a variable > called `_GUID_ddb47a6a_0f23_11d5_9109_00e0296b75d3` of type `__s_GUID` which > is why it behaves the way it does:

[PATCH] D43105: [RISCV] Enable __int128_t and __uint128_t through clang flag

2018-02-22 Thread Alex Bradbury via Phabricator via cfe-commits
asb added inline comments. Comment at: test/CodeGen/riscv32-abi.c:2-3 // RUN: %clang_cc1 -triple riscv32 -emit-llvm %s -o - | FileCheck %s +// RUN: %clang_cc1 -triple riscv32 -emit-llvm -fforce-enable-int128 %s -o - \ +// RUN: | FileCheck %s -check-prefix=CHECK-FORCEINT128

[PATCH] D43105: [RISCV] Enable __int128_t and __uint128_t through clang flag

2018-02-22 Thread Mandeep Singh Grang via Phabricator via cfe-commits
mgrang updated this revision to Diff 135553. Repository: rC Clang https://reviews.llvm.org/D43105 Files: include/clang/Basic/TargetInfo.h include/clang/Basic/TargetOptions.h include/clang/Driver/Options.td lib/Basic/Targets/Mips.h lib/Driver/ToolChains/Clang.cpp

[PATCH] D41102: Setup clang-doc frontend framework

2018-02-22 Thread Julie Hockett via Phabricator via cfe-commits
juliehockett updated this revision to Diff 135559. juliehockett marked 10 inline comments as done. juliehockett added a comment. Refactoring bitcode writer https://reviews.llvm.org/D41102 Files: CMakeLists.txt clang-doc/BitcodeWriter.cpp clang-doc/BitcodeWriter.h

  1   2   >