[PATCH] D44582: [Builtins] Fix calling long double math functions on x86_64 mingw

mstorsjo abandoned this revision. mstorsjo added a comment. Fixed the issue via https://reviews.llvm.org/D44592 instead, thanks @efriedma for the pointers! Repository: rC Clang https://reviews.llvm.org/D44582 ___ cfe-commits mailing list

[PATCH] D43764: [clang-apply-replacements] Convert tooling::Replacements to tooling::AtomicChange for conflict resolving of changes, code cleanup, and code formatting.

jdemeule updated this revision to Diff 139082. jdemeule added a comment. Update after review. Change error reporting to use `ReplacementError` message. https://reviews.llvm.org/D43764 Files: clang-apply-replacements/include/clang-apply-replacements/Tooling/ApplyReplacements.h

[PATCH] D44630: [ms] Parse #pragma optimize and ignore it behind its own flag

This revision was automatically updated to reflect the committed changes. hans marked an inline comment as done. Closed by commit rL327959: [ms] Parse #pragma optimize and ignore it behind its own flag (authored by hans, committed by ). Herald added a subscriber: llvm-commits. Changed prior to

[PATCH] D44630: [ms] Parse #pragma optimize and ignore it behind its own flag

hans marked an inline comment as done. hans added inline comments. Comment at: include/clang/Basic/DiagnosticParseKinds.td:973 +def warn_pragma_optimize : Warning< + "'#pragma optimize' is not supported; use '#pragma clang optimize on|off' instead">, + InGroup;

[PATCH] D44606: [analyzer] Fix the crash in `IteratorChecker.cpp` when `SymbolConjured` has a null Stmt.

This revision was automatically updated to reflect the committed changes. Closed by commit rL327962: [analyzer] Fix the crash in IteratorChecker.cpp when SymbolConjured has a… (authored by henrywong, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D44381: [mips] Change the way how Clang chooses relocation mode

abeserminji updated this revision to Diff 139102. abeserminji added a comment. Herald added a subscriber: llvm-commits. Resolved a comment. Repository: rL LLVM https://reviews.llvm.org/D44381 Files: lib/Driver/ToolChains/CommonArgs.cpp test/Driver/mips-as.c test/Driver/mips-features.c

[PATCH] D44381: [mips] Force PIC to level 1

abeserminji updated this revision to Diff 139110. abeserminji retitled this revision from "[mips] Change the way how Clang chooses relocation mode" to "[mips] Force PIC to level 1". abeserminji edited the summary of this revision. abeserminji added a comment. Updated the patch. Now this patch

[PATCH] D43764: [clang-apply-replacements] Convert tooling::Replacements to tooling::AtomicChange for conflict resolving of changes, code cleanup, and code formatting.

ioeric added a comment. This looks great! Just a few nits left. Comment at: clang-apply-replacements/include/clang-apply-replacements/Tooling/ApplyReplacements.h:75 +/// \brief Deduplicate, check for conflicts, and convert all Replacements stored +/// in \c TUs to

[PATCH] D44632: [clang-format] Add a few more Core Graphics identifiers to ObjC heuristic

jolesiak requested changes to this revision. jolesiak added inline comments. This revision now requires changes to proceed. Comment at: unittests/Format/FormatTest.cpp:12099 EXPECT_EQ(FormatStyle::LK_ObjC, guessLanguage("foo", "@interface Foo\n@end\n")); +

[PATCH] D44628: Backport changes from llvm/.clang_tidy to clang/.clang_tidy configs

ilya-biryukov added inline comments. Comment at: .clang-tidy:8 - key: readability-identifier-naming.FunctionCase -value: lowerCase +value: camelBack + - key: readability-identifier-naming.MemberCase simark

[PATCH] D41808: Rename clang link from clang-X.Y to clang-X

sylvestre.ledru updated this revision to Diff 139100. sylvestre.ledru marked an inline comment as done. sylvestre.ledru added a reviewer: dim. https://reviews.llvm.org/D41808 Files: CMakeLists.txt Index: CMakeLists.txt === ---

[PATCH] D44272: [clangd] Support incremental document syncing

ilya-biryukov added inline comments. Comment at: clangd/ClangdLSPServer.cpp:164 + if (!Contents) { +log(llvm::toString(Contents.takeError())); +return; simark wrote: > ilya-biryukov wrote: > > We should signal an error to the client by calling

[PATCH] D44632: [clang-format] Add a few more Core Graphics identifiers to ObjC heuristic

jolesiak added inline comments. Comment at: lib/Format/Format.cpp:1450 // Keep this array sorted, since we are binary searching over it. static constexpr llvm::StringLiteral FoundationIdentifiers[] = { "CGFloat", djasper wrote: > I have

[PATCH] D44634: [clang-format] Detect Objective-C for #import

djasper added a comment. I'd really like to not parse include/import statements this way. Can you send me examples of headers where we fail to recognize them as ObjC and this matters (happy for you to send me examples offline). Repository: rC Clang https://reviews.llvm.org/D44634

[PATCH] D44673: Make positionToOffset return llvm::Expected

ilya-biryukov added inline comments. Comment at: clangd/ClangdServer.cpp:196 +return Begin.takeError(); + + llvm::Expected End = positionToOffset(Code, Rng.end); NIT: maybe remove empty lines? they don't seem to add much to readability, since when prev

r327962 - [analyzer] Fix the crash in IteratorChecker.cpp when 'SymbolConjured' has a null Stmt.

Author: henrywong Date: Tue Mar 20 02:27:02 2018 New Revision: 327962 URL: http://llvm.org/viewvc/llvm-project?rev=327962=rev Log: [analyzer] Fix the crash in IteratorChecker.cpp when 'SymbolConjured' has a null Stmt. When the loop has a null terminator statement and sets 'widen-loops=true',

[PATCH] D44632: [clang-format] Add a few more Core Graphics identifiers to ObjC heuristic

djasper added inline comments. Comment at: lib/Format/Format.cpp:1450 // Keep this array sorted, since we are binary searching over it. static constexpr llvm::StringLiteral FoundationIdentifiers[] = { "CGFloat", I have concerns about this

[PATCH] D44628: Backport changes from llvm/.clang_tidy to clang/.clang_tidy configs

alexfh accepted this revision. alexfh added a comment. Thanks! I don't know how useful is the support of cfe being checked out somewhere else than into llvm/tools/clang. If we could give up on that, we could just kill this file and rely on clang-tidy to pick up llvm/.clang-tidy. Anyways, LG.

r327984 - Backport changes from llvm/.clang_tidy to clang/.clang_tidy configs

Author: ibiryukov Date: Tue Mar 20 07:39:12 2018 New Revision: 327984 URL: http://llvm.org/viewvc/llvm-project?rev=327984=rev Log: Backport changes from llvm/.clang_tidy to clang/.clang_tidy configs Summary: LLVM .clang_tidy seems to be more up-to-date. Reviewers: alexfh, simark Reviewed By:

[PATCH] D44638: [clang-format] Fix ObjC selectors with multiple params passed to macro

This revision was automatically updated to reflect the committed changes. Closed by commit rL327986: [clang-format] Fix ObjC selectors with multiple params passed to macro (authored by benhamilton, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM

[PATCH] D44634: [clang-format] Detect Objective-C for #import

benhamilton updated this revision to Diff 139127. benhamilton added a comment. clang-format Repository: rC Clang https://reviews.llvm.org/D44634 Files: lib/Format/Format.cpp unittests/Format/FormatTest.cpp Index: unittests/Format/FormatTest.cpp

[PATCH] D44632: [clang-format] Add a few more Core Graphics identifiers to ObjC heuristic

benhamilton added a subscriber: krasimir. benhamilton added a comment. @krasimir, can you answer @djasper's question about hash set vs. binary search? Comment at: lib/Format/Format.cpp:1450 // Keep this array sorted, since we are binary searching over it. static

[PATCH] D43766: [clang-tidy][modernize-make-unique] Checks c++14 flag before using std::make_unique

alexfh added a comment. Frederic, do you need someone to commit the patch for you? https://reviews.llvm.org/D43766 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D44628: Backport changes from llvm/.clang_tidy to clang/.clang_tidy configs

This revision was not accepted when it landed; it landed in state "Needs Revision". This revision was automatically updated to reflect the committed changes. Closed by commit rL327984: Backport changes from llvm/.clang_tidy to clang/.clang_tidy configs (authored by ibiryukov, committed by ).

r327986 - [clang-format] Fix ObjC selectors with multiple params passed to macro

Author: benhamilton Date: Tue Mar 20 07:53:25 2018 New Revision: 327986 URL: http://llvm.org/viewvc/llvm-project?rev=327986=rev Log: [clang-format] Fix ObjC selectors with multiple params passed to macro Summary: Objective-C selectors with arguments take the form of: foo: foo:bar: foo:bar:baz:

[PATCH] D44295: [clang-tidy] Detects and fixes calls to grand-...parent virtual methods instead of calls to parent's virtual methods

alexfh added inline comments. Comment at: clang-tidy/bugprone/ParentVirtualCallCheck.cpp:24 + +static bool IsParentOf(const CXXRecordDecl , + const CXXRecordDecl ) { http://llvm.org/docs/CodingStandards.html says: "Function names should be

[PATCH] D44632: [clang-format] Add a few more Core Graphics identifiers to ObjC heuristic

benhamilton updated this revision to Diff 139125. benhamilton marked 2 inline comments as done. benhamilton added a comment. clang-format Repository: rC Clang https://reviews.llvm.org/D44632 Files: lib/Format/Format.cpp unittests/Format/FormatTest.cpp Index:

r327985 - [OPENMP, NVPTX] Globalization of the private redeclarations.

Author: abataev Date: Tue Mar 20 07:45:59 2018 New Revision: 327985 URL: http://llvm.org/viewvc/llvm-project?rev=327985=rev Log: [OPENMP, NVPTX] Globalization of the private redeclarations. If the generic codegen is enabled and private copy of the original variable escapes the declaration

[PATCH] D44684: [mips] Improve handling of -fno-[pic/PIC] option

abeserminji created this revision. abeserminji added reviewers: petarj, sdardis. Herald added subscribers: llvm-commits, arichardson. - On N64 ABI, -mno-abicalls is needed to disable PIC. Warning is reported when only -fno-pic/-fno-PIC is used. This is how GCC behaves. - An error is reported

[PATCH] D44634: [clang-format] Detect Objective-C for #import

benhamilton updated this revision to Diff 139137. benhamilton added a comment. Add assert(std::is_sorted(...)). (We can't static_assert on is_sorted until C++2x.) Repository: rC Clang https://reviews.llvm.org/D44634 Files: lib/Format/Format.cpp unittests/Format/FormatTest.cpp Index:

[PATCH] D44645: [test] Fix Cross-DSO CFI Android sanitizer test for -rtlib=compiler-rt

mgorny marked 2 inline comments as done. mgorny added a comment. @eugenis, updated. https://reviews.llvm.org/D44645 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D44093: [BUILTINS] structure pretty printer

aaron.ballman added inline comments. Comment at: lib/Sema/SemaChecking.cpp:1122 +!PtrArgType->getPointeeType()->isRecordType()) { + this->Diag(PtrArg->getLocStart(), + diag::err_typecheck_convert_incompatible) Drop all instances of

[PATCH] D44632: [clang-format] Add a few more Core Graphics identifiers to ObjC heuristic

jolesiak accepted this revision. jolesiak added inline comments. This revision is now accepted and ready to land. Comment at: lib/Format/Format.cpp:1450 // Keep this array sorted, since we are binary searching over it. static constexpr llvm::StringLiteral

r327990 - [OPENMP, NVPTX] Codegen for target distribute parallel combined

Author: abataev Date: Tue Mar 20 08:41:05 2018 New Revision: 327990 URL: http://llvm.org/viewvc/llvm-project?rev=327990=rev Log: [OPENMP, NVPTX] Codegen for target distribute parallel combined constructs in generic mode. Fixed codegen for distribute parallel combined constructs. We have to pass

r327991 - Set dso_local for guid decls.

Author: rafael Date: Tue Mar 20 08:42:58 2018 New Revision: 327991 URL: http://llvm.org/viewvc/llvm-project?rev=327991=rev Log: Set dso_local for guid decls. Modified: cfe/trunk/lib/CodeGen/CodeGenModule.cpp cfe/trunk/test/CodeGenCXX/microsoft-templ-uuidof.cpp Modified:

[PATCH] D44649: Set dso_local for guid decls

espindola closed this revision. espindola added a comment. 327991 https://reviews.llvm.org/D44649 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r327993 - Set dso_local for CFConstantStringClassReference.

Author: rafael Date: Tue Mar 20 08:48:00 2018 New Revision: 327993 URL: http://llvm.org/viewvc/llvm-project?rev=327993=rev Log: Set dso_local for CFConstantStringClassReference. This one cannot use setGVProperties since it has special logic for when it is dllimport or not. Modified:

[PATCH] D44491: Set dso_local for CFConstantStringClassReference

espindola added a comment. 327993 https://reviews.llvm.org/D44491 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D44632: [clang-format] Add a few more Core Graphics identifiers to ObjC heuristic

benhamilton marked 4 inline comments as done. benhamilton added inline comments. Comment at: lib/Format/Format.cpp:1450 // Keep this array sorted, since we are binary searching over it. static constexpr llvm::StringLiteral FoundationIdentifiers[] = {

[PATCH] D44632: [clang-format] Add a few more Core Graphics identifiers to ObjC heuristic

djasper added inline comments. Comment at: lib/Format/Format.cpp:1450 // Keep this array sorted, since we are binary searching over it. static constexpr llvm::StringLiteral FoundationIdentifiers[] = { "CGFloat", benhamilton wrote: > jolesiak

[PATCH] D44632: [clang-format] Add a few more Core Graphics identifiers to ObjC heuristic

benhamilton updated this revision to Diff 139136. benhamilton added a comment. Add assert(std::is_sorted(...)). (We can't static_assert on is_sorted until C++2x.) Repository: rC Clang https://reviews.llvm.org/D44632 Files: lib/Format/Format.cpp unittests/Format/FormatTest.cpp Index:

[PATCH] D44645: [test] Fix Cross-DSO CFI Android sanitizer test for -rtlib=compiler-rt

mgorny updated this revision to Diff 139135. mgorny edited the summary of this revision. https://reviews.llvm.org/D44645 Files: test/Driver/sanitizer-ld.c Index: test/Driver/sanitizer-ld.c === --- test/Driver/sanitizer-ld.c +++

[PATCH] D44602: [clang-tidy] readability-function-size: add VariableThreshold param.

aaron.ballman added inline comments. Comment at: clang-tidy/readability/FunctionSizeCheck.cpp:30-31 + bool VisitDecompositionDecl(DecompositionDecl *) { +// DecompositionDecl was already visited as VarDecl. Don't count it twice. +Info.Variables--; +return true;

[PATCH] D44695: [clang-format] Partially revert r322749, replacing array with DenseSet

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. I wouldn't say that this is more maintainable, but I'm not the maintainer of clang-format. Repository: rC Clang https://reviews.llvm.org/D44695

[PATCH] D44602: [clang-tidy] readability-function-size: add VariableThreshold param.

lebedev.ri added inline comments. Comment at: test/clang-tidy/readability-function-size.cpp:207-212 +void variables_8() { + int a, b; + struct A { +A(int c, int d); + }; +} aaron.ballman wrote: > lebedev.ri wrote: > > aaron.ballman wrote: > > > lebedev.ri

[PATCH] D44597: [CFG] [analyzer] Add C++17-specific variable and return value construction contexts.

george.karpenkov accepted this revision. george.karpenkov added a comment. This revision is now accepted and ready to land. LGTM, subject to minor nits Comment at: include/clang/Analysis/CFG.h:172 /// by value. This, like constructor, requires a construction context, which

[PATCH] D44689: Set dso_local on string literals

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm https://reviews.llvm.org/D44689 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D44688: Set dso_local for runtime functions

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm We don't assume these are `dso_local` on Linux, right? https://reviews.llvm.org/D44688 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D44695: [clang-format] Partially revert r322749, replacing array with DenseSet

benhamilton added a comment. I'm fine with whichever approach we use, but I'll defer to @krasimir here. (I'm not fully sure why `llvm::DenseSet` is better than `std::unsorted_set`, but I'm sure you and @krasimir understand the subtleties better than I do.) Repository: rC Clang

[PATCH] D44692: [clang-format] Don't insert space between r_paren and 'new' in ObjC decl

stephanemoore accepted this revision. stephanemoore added a comment. This revision is now accepted and ready to land. Makes sense to me. Repository: rC Clang https://reviews.llvm.org/D44692 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D44706: Delete BuiltinCC

espindola created this revision. espindola added reviewers: rnk, echristo. It is always identical to RuntimeCC. https://reviews.llvm.org/D44706 Files: lib/CodeGen/ABIInfo.h lib/CodeGen/CGExprComplex.cpp lib/CodeGen/CodeGenModule.cpp lib/CodeGen/CodeGenTypeCache.h

Re: r328040 - Set dso_local on string literals.

On Tue, Mar 20, 2018 at 08:42:55PM -, Rafael Espindola via cfe-commits wrote: > Author: rafael > Date: Tue Mar 20 13:42:55 2018 > New Revision: 328040 > > URL: http://llvm.org/viewvc/llvm-project?rev=328040=rev > Log: > Set dso_local on string literals. I wonder if unnamed_addr shouldn't

[PATCH] D44619: [CodeGen] Add cleanup scope to EmitInlinedInheritingCXXConstructorCall

smeenai added a comment. Thanks Reid. I still need to look into why this is causing some existing tests to crash, but I'll also adjust the test. Repository: rC Clang https://reviews.llvm.org/D44619 ___ cfe-commits mailing list

[PATCH] D44708: [test] Adding config initialization to lit tests in clang-tools-extra

lebedev.ri added a comment. Nice catch! I wonder how many more `test/lit.site.cfg.in` are silently partially non-functional because they don't have that substitution... I also have an idea why it might not have worked for you - are you building clang-tools-extra repo separately manually, not

[libcxx] r328059 - Implement LWG3035: std::allocator's constructors should be constexpr.

Author: marshall Date: Tue Mar 20 16:02:53 2018 New Revision: 328059 URL: http://llvm.org/viewvc/llvm-project?rev=328059=rev Log: Implement LWG3035: std::allocator's constructors should be constexpr. Added: libcxx/trunk/test/std/utilities/memory/default.allocator/allocator.ctor.pass.cpp

Re: r328006 - [NVPTX] Make tensor load/store intrinsics overloaded.

With this clang/test/CodeGen/builtins-nvptx-sm_70.cu is crashing: lib/IR/Instructions.cpp:299: void llvm::CallInst::init(llvm::FunctionType *, llvm::Value *, ArrayRef, ArrayRef, const llvm::Twine &): Assertion `(i >= FTy->getNumParams()|| FTy->getParamType(i) == Args[i]->getType()) && "Calling a

r328047 - [format] Eliminate global destructors.

Author: d0k Date: Tue Mar 20 14:52:19 2018 New Revision: 328047 URL: http://llvm.org/viewvc/llvm-project?rev=328047=rev Log: [format] Eliminate global destructors. Modified: cfe/trunk/lib/Format/BreakableToken.cpp cfe/trunk/lib/Format/Format.cpp Modified:

[PATCH] D44710: Set dso_local on builtin functions

espindola created this revision. espindola added reviewers: rnk, echristo. With https://reviews.llvm.org/D44706 we can just forward to CreateRuntimeFunction. https://reviews.llvm.org/D44710 Files: lib/CodeGen/CodeGenModule.cpp test/CodeGen/mingw-long-double.c Index:

[PATCH] D44706: Delete BuiltinCC

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM. https://reviews.llvm.org/D44706 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D41102: Setup clang-doc frontend framework

juliehockett added a comment. After much digging, it looks like the lit config is never initialized in clang-tools-extra like it is in the other projects. REQUIRES et.al. work properly once that's in there (see D44708 ). Once that lands I'll reland this and

r328053 - [Modules] Honor -fmodule-name when handling private framework modules

Author: bruno Date: Tue Mar 20 15:36:39 2018 New Revision: 328053 URL: http://llvm.org/viewvc/llvm-project?rev=328053=rev Log: [Modules] Honor -fmodule-name when handling private framework modules When skipping building the module for a private framework module, LangOpts.CurrentModule isn't

[libcxx] r328054 - Implement LWG 3039 and 3041 - 'Treating Unnecessary decay'.

Author: marshall Date: Tue Mar 20 15:37:37 2018 New Revision: 328054 URL: http://llvm.org/viewvc/llvm-project?rev=328054=rev Log: Implement LWG 3039 and 3041 - 'Treating Unnecessary decay'. Modified: libcxx/trunk/include/future libcxx/trunk/include/thread Modified:

r328036 - Set dso_local for runtime function.

Author: rafael Date: Tue Mar 20 13:27:30 2018 New Revision: 328036 URL: http://llvm.org/viewvc/llvm-project?rev=328036=rev Log: Set dso_local for runtime function. This is another case where there is special logic for adding dllimport and so we cannot use setGVProperties. Modified:

[PATCH] D44688: Set dso_local for runtime functions

espindola added a comment. In https://reviews.llvm.org/D44688#1043575, @rnk wrote: > lgtm > > We don't assume these are `dso_local` on Linux, right? Depends on shouldAssumeDSOLocal. We do if there is no -fPIC or -fPIE for example. https://reviews.llvm.org/D44688

r328048 - Add CHECKs for a few declarations. NFC.

Author: rafael Date: Tue Mar 20 14:54:14 2018 New Revision: 328048 URL: http://llvm.org/viewvc/llvm-project?rev=328048=rev Log: Add CHECKs for a few declarations. NFC. We were just missing test coverage for this. Modified: cfe/trunk/test/CodeGen/mingw-long-double.c Modified:

r328051 - Change ImplicitConverionKind comments to refer to C++ stable names[NFC]

Author: erichkeane Date: Tue Mar 20 15:05:01 2018 New Revision: 328051 URL: http://llvm.org/viewvc/llvm-project?rev=328051=rev Log: Change ImplicitConverionKind comments to refer to C++ stable names[NFC] Modified: cfe/trunk/include/clang/Sema/Overload.h Modified:

[PATCH] D44706: Delete BuiltinCC

espindola closed this revision. espindola added a comment. r328050 https://reviews.llvm.org/D44706 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D44646: Sema: in msvc compatibility mode, don't allow forceinline on variadics

compnerd added inline comments. Comment at: test/Sema/ms-forceinline-on-variadic.cpp:14 +__builtin_va_end(ap); +} + DHowett-MSFT wrote: > compnerd wrote: > > Would be nice to have a second test that uses the Microsoft definitions > > (`char *` and the

[PATCH] D44708: [test] Adding config initialization to lit tests in clang-tools-extra

juliehockett created this revision. juliehockett added reviewers: alexfh, mgorny. juliehockett added a project: clang-tools-extra. Adding the config initialization (the footer) to clang-tools-extra so that tests that use REQUIRES, UNSUPPORTED, and XFAIL based on platform or target triple work

[PATCH] D43766: [clang-tidy][modernize-make-unique] Checks c++14 flag before using std::make_unique

ftingaud added a comment. Hi, Yes please! https://reviews.llvm.org/D43766 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D44708: [test] Adding config initialization to lit tests in clang-tools-extra

lebedev.ri accepted this revision. lebedev.ri added a comment. This revision is now accepted and ready to land. As per https://github.com/llvm-project/llvm-project-20170507/search?utf8=%E2%9C%93=LIT_SITE_CFG_IN_FOOTER= this substitution already exists in most of the repos. I don't see why it

[PATCH] D44646: Sema: in msvc compatibility mode, don't allow forceinline on variadics

efriedma added inline comments. Comment at: test/Sema/ms-forceinline-on-variadic.cpp:14 +__builtin_va_end(ap); +} + compnerd wrote: > DHowett-MSFT wrote: > > compnerd wrote: > > > Would be nice to have a second test that uses the Microsoft definitions > > >

[PATCH] D44694: [clang-tidy] Use :doc: for check links in Release Notes

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D44694 ___ cfe-commits mailing list

[PATCH] D43764: [clang-apply-replacements] Convert tooling::Replacements to tooling::AtomicChange for conflict resolving of changes, code cleanup, and code formatting.

jdemeule added inline comments. Comment at: clang-apply-replacements/include/clang-apply-replacements/Tooling/ApplyReplacements.h:75 +/// \brief Deduplicate, check for conflicts, and convert all Replacements stored +/// in \c TUs to AtomicChange. If conflicts occur, no

r328044 - [Driver] Fix some Clang-tidy modernize and Include What You Use warnings; other minor fixes (NFC).

Author: eugenezelenko Date: Tue Mar 20 14:08:59 2018 New Revision: 328044 URL: http://llvm.org/viewvc/llvm-project?rev=328044=rev Log: [Driver] Fix some Clang-tidy modernize and Include What You Use warnings; other minor fixes (NFC). Modified: cfe/trunk/include/clang/Driver/Action.h

r328050 - Delete BuiltinCC. NFC.

Author: rafael Date: Tue Mar 20 15:02:57 2018 New Revision: 328050 URL: http://llvm.org/viewvc/llvm-project?rev=328050=rev Log: Delete BuiltinCC. NFC. It is always identical to RuntimeCC. Modified: cfe/trunk/lib/CodeGen/ABIInfo.h cfe/trunk/lib/CodeGen/CGExprComplex.cpp

[PATCH] D44671: [libcxx] Enable static libcxxabi linking on Darwin

compnerd added a reviewer: dexonsmith. compnerd added a comment. I want to get Duncan's input on this. I don't think that this is a supported configuration for macOS. Repository: rCXX libc++ https://reviews.llvm.org/D44671 ___ cfe-commits

[PATCH] D43957: Fixing issue where a space was not added before a global namespace variable when SpacesInParentheses is set

dpayne updated this revision to Diff 139212. dpayne added a comment. Adding a unit test for formatting a global namespace var with SpacesInParentheses enabled. Repository: rC Clang https://reviews.llvm.org/D43957 Files: lib/Format/TokenAnnotator.cpp unittests/Format/FormatTest.cpp

[clang-tools-extra] r328060 - [lit] Adding config initialization to lit tests in clang-tools-extra

Author: juliehockett Date: Tue Mar 20 16:22:50 2018 New Revision: 328060 URL: http://llvm.org/viewvc/llvm-project?rev=328060=rev Log: [lit] Adding config initialization to lit tests in clang-tools-extra Adding the config initialization to clang-tools-extra so that tests that use REQUIRES,

Re: r328006 - [NVPTX] Make tensor load/store intrinsics overloaded.

Thanks for the heads up. Which buildbot shows the failure? I don't see the failure on the cuda buildbot, nor do I see it on my machine locally. It may be due to llvm/clang being out of sync. The commit had changes for both sides and if clang and llvm are out of sync, you may see this kind of

[PATCH] D44619: [CodeGen] Add cleanup scope to EmitInlinedInheritingCXXConstructorCall

rsmith added inline comments. Comment at: lib/CodeGen/CGClass.cpp:2183 ApplyInlineDebugLocation DebugScope(*this, GD); + RunCleanupsScope CleanupScope(*this); Please add a test to ensure that we still destroy function parameters in the right order and at

[PATCH] D44539: [Sema][Objective-C] Add check to warn when property of objc type has assign attribute

QF5690 added a comment. > I think the problem is there are valid places to use assign on object types > (especially delegates). Isn't it better to have unsafe_unretained there? I thought unsafe_unretained keyword is introduced specifically for that kinds of things. Ok, here is my last point

[PATCH] D44688: Set dso_local for runtime functions

espindola closed this revision. espindola added a comment. 328036 https://reviews.llvm.org/D44688 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D44539: [Sema][Objective-C] Add check to warn when property of objc type has assign attribute

benhamilton added a comment. > Isn't it better to have unsafe_unretained there? That is a good question for the author of that property attribute. I'm not sure of the entire history. Repository: rC Clang https://reviews.llvm.org/D44539 ___

r328038 - [AArch64] Add vmulxh_lane fp16 vector intrinsic

Author: az Date: Tue Mar 20 13:37:31 2018 New Revision: 328038 URL: http://llvm.org/viewvc/llvm-project?rev=328038=rev Log: [AArch64] Add vmulxh_lane fp16 vector intrinsic https://reviews.llvm.org/D44591 Modified: cfe/trunk/include/clang/Basic/arm_neon.td

r328041 - [format] Initialize regex lazily

Author: d0k Date: Tue Mar 20 13:43:12 2018 New Revision: 328041 URL: http://llvm.org/viewvc/llvm-project?rev=328041=rev Log: [format] Initialize regex lazily No need to pay for this on program startup, and also no need to destroy it on process end. Modified:

r328040 - Set dso_local on string literals.

Author: rafael Date: Tue Mar 20 13:42:55 2018 New Revision: 328040 URL: http://llvm.org/viewvc/llvm-project?rev=328040=rev Log: Set dso_local on string literals. Modified: cfe/trunk/lib/CodeGen/CodeGenModule.cpp cfe/trunk/test/CodeGen/c-strings.c

[PATCH] D44689: Set dso_local on string literals

espindola closed this revision. espindola added a comment. r328040 https://reviews.llvm.org/D44689 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: r328006 - [NVPTX] Make tensor load/store intrinsics overloaded.

Sorry, I was just missing "git pull" in the llvm repo. Cheers, Rafael Artem Belevich writes: > Thanks for the heads up. > > Which buildbot shows the failure? I don't see the failure on the cuda > buildbot, nor do I see it on my machine locally. > > It may be due to llvm/clang

[PATCH] D44712: Set dso_local on runtime variables

espindola created this revision. espindola added reviewers: rnk, echristo, eli.friedman. https://reviews.llvm.org/D44712 Files: lib/CodeGen/CodeGenModule.cpp test/CodeGenCXX/ubsan-vtable-checks.cpp Index: test/CodeGenCXX/ubsan-vtable-checks.cpp

[PATCH] D44708: [test] Adding config initialization to lit tests in clang-tools-extra

This revision was automatically updated to reflect the committed changes. Closed by commit rL328060: [lit] Adding config initialization to lit tests in clang-tools-extra (authored by juliehockett, committed by ). Herald added subscribers: llvm-commits, klimek. Changed prior to commit:

[PATCH] D44723: Set dso_local when clearing dllimport

espindola created this revision. espindola added reviewers: rnk, echristo. https://reviews.llvm.org/D44723 Files: lib/CodeGen/CodeGenModule.cpp test/CodeGenCXX/dllimport.cpp Index: test/CodeGenCXX/dllimport.cpp === ---

[PATCH] D44727: [RISCV] Implement getTargetDefines, handleTargetFeatures and hasFeature for RISCVTargetInfo

kito-cheng created this revision. kito-cheng added reviewers: asb, apazos. Herald added subscribers: cfe-commits, shiva0217, niosHD, sabuasal, jordy.potman.lists, simoncook, johnrusso, rbar. kito-cheng added a dependency: D44189: [RISCV] Verify the input value of -march=. This patch implement

[PATCH] D44589: [Sema] Make deprecation fix-it replace all multi-parameter ObjC method slots.

vsapsai marked 3 inline comments as done. vsapsai added inline comments. Comment at: clang/lib/Sema/SemaDeclAttr.cpp:7207-7217 +} else { + FixIts.push_back(FixItHint::CreateInsertion( + SelectorLocs[I], SelectorSlotNames[I])); +

[PATCH] D44724: [Fuchsia] Avoid using static ABI library with libc++ on Darwin

mcgrathr added a comment. When targetting Darwin we should really not be even compiling libc++/libc++abi and certainly should not have anything else compiling against their headers since at runtime the system libraries will be used and so things better compile against the system headers that

[PATCH] D44597: [CFG] [analyzer] Add C++17-specific variable and return value construction contexts.

NoQ updated this revision to Diff 139245. NoQ added a comment. Address review comments. https://reviews.llvm.org/D44597 Files: include/clang/Analysis/CFG.h include/clang/Analysis/ConstructionContext.h lib/Analysis/CFG.cpp lib/Analysis/ConstructionContext.cpp

Re: r328040 - Set dso_local on string literals.

Joerg Sonnenberger via cfe-commits writes: > On Tue, Mar 20, 2018 at 08:42:55PM -, Rafael Espindola via cfe-commits > wrote: >> Author: rafael >> Date: Tue Mar 20 13:42:55 2018 >> New Revision: 328040 >> >> URL: http://llvm.org/viewvc/llvm-project?rev=328040=rev

[PATCH] D44646: Sema: in msvc compatibility mode, don't allow forceinline on variadics

DHowett-MSFT added inline comments. Comment at: test/Sema/ms-forceinline-on-variadic.cpp:14 +__builtin_va_end(ap); +} + efriedma wrote: > compnerd wrote: > > DHowett-MSFT wrote: > > > compnerd wrote: > > > > Would be nice to have a second test that uses the

r328067 - Revert r326782 "[analyzer] CStringChecker.cpp: Remove the duplicated check...".

Author: dergachev Date: Tue Mar 20 17:57:37 2018 New Revision: 328067 URL: http://llvm.org/viewvc/llvm-project?rev=328067=rev Log: Revert r326782 "[analyzer] CStringChecker.cpp: Remove the duplicated check...". It seems that the refactoring was causing a functional change and some warnings have

[PATCH] D44720: [clangd] Simplify fuzzy matcher (sequence alignment) by removing some condition checks.

MaskRay created this revision. MaskRay added a reviewer: sammccall. Herald added subscribers: cfe-commits, ioeric, jkorous-apple, ilya-biryukov, klimek. Also rename `matchBonus` and `skipPenalty` to uniform `{match,miss}Score` in addition form. Repository: rCTE Clang Tools Extra

  1   2   >