kito-cheng updated this revision to Diff 139256.
kito-cheng added a comment.
Update revision according Alex's review.
Changes:
- Add testcase for uppercase of -march string.
- Add testcase for repeated letter in -march.
- Add more comment.
- Add several TODO item for diagnostic message improveme
kito-cheng marked 4 inline comments as done.
kito-cheng added a comment.
Hi Alex:
Thanks for your input, check for repeated letter was missed in my last patch :)
Comment at: lib/Driver/ToolChains/Arch/RISCV.cpp:34
+
+// The canonical order specified in ISA manual.
+Str
sammccall added a comment.
Can you elaborate on what this patch is improving, and how?
There are some stylistic changes, and also what look like subtle logic changes,
and some rearrangement of the algorithm - to what end?
Canonical way to run all tests is `ninja check-clang-tools`, the way you
sammccall added a comment.
(Sorry if I sound gruff - I'm sure there are improvements to be had here. But
since the code is a bit dense (my fault) I have trouble inferring them from the
deltas.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D44720
avt77 added a comment.
>> In https://reviews.llvm.org/D44559#1040799, @rjmccall wrote:
>>
>>> I think we're correct not to warn here and that GCC/ICC are being noisy.
>>> The existence of a temporary promotion to a wider type doesn't justify
>>> warning on arithmetic between two operands that
yvvan added a comment.
In https://reviews.llvm.org/D44426#1042162, @mibintc wrote:
> I added some inline comments. You are using the Intel 18.0 compiler on
> Windows - what version of Visual Studio is in the environment?
Yes, I'm using 18.0
Comment at: include/llvm-c/Target
yvvan added inline comments.
Comment at: include/clang/Sema/CodeCompleteConsumer.h:565
+ /// \brief For this completion result correction is required.
+ Optional Corr = None;
+
ilya-biryukov wrote:
> Having a string replacement without an actual range to replac
On Wed, Mar 21, 2018 at 5:28 AM, Petr Hosek via cfe-commits
wrote:
> Author: phosek
> Date: Tue Mar 20 19:28:22 2018
> New Revision: 328069
>
> URL: http://llvm.org/viewvc/llvm-project?rev=328069&view=rev
> Log:
> Revert "[lit] Adding config initialization to lit tests in clang-tools-extra"
>
> Th
courbet added inline comments.
Comment at: clang-tidy/cppcoreguidelines/NarrowingConversionsCheck.cpp:26
+ binaryOperator(
+ anyOf(hasOperatorName("+="), hasOperatorName("-=")),
+ hasLHS(hasType(isInteger())),
aaron.ballman wrote:
> courbet
avt77 updated this revision to Diff 139271.
avt77 added a comment.
I removed the dependence on arch and updated the tests.
https://reviews.llvm.org/D44559
Files:
lib/Sema/SemaChecking.cpp
test/Sema/conversion.c
test/SemaCXX/conversion.cpp
Index: test/SemaCXX/conversion.cpp
=
Author: courbet
Date: Wed Mar 21 03:48:00 2018
New Revision: 328086
URL: http://llvm.org/viewvc/llvm-project?rev=328086&view=rev
Log:
[ASTMatchers] Regenerate doc.
Modified:
cfe/trunk/docs/LibASTMatchersReference.html
Modified: cfe/trunk/docs/LibASTMatchersReference.html
URL:
http://llvm.or
courbet created this revision.
courbet added reviewers: aaron.ballman, alexfh.
Herald added a subscriber: klimek.
This is needed to implement more checks in https://reviews.llvm.org/D38455.
Repository:
rC Clang
https://reviews.llvm.org/D44729
Files:
docs/LibASTMatchersReference.html
incl
Author: courbet
Date: Wed Mar 21 03:54:29 2018
New Revision: 328087
URL: http://llvm.org/viewvc/llvm-project?rev=328087&view=rev
Log:
[ASTMatchers] Remove extra qualifier for consistency
(LibASTMatchersReference.html)
+ Regenerate doc.
Modified:
cfe/trunk/docs/LibASTMatchersReference.html
dim accepted this revision.
dim added a comment.
This revision is now accepted and ready to land.
LGTM.
https://reviews.llvm.org/D41808
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commit
ilya-biryukov accepted this revision.
ilya-biryukov added a comment.
This revision is now accepted and ready to land.
LGTM. See the empty line NITS, though.
Comment at: clangd/ClangdServer.cpp:199
+return End.takeError();
+
+ return formatCode(Code, File, {tooling::Range(*
jolesiak added inline comments.
Comment at: lib/Format/Format.cpp:1450
// Keep this array sorted, since we are binary searching over it.
static constexpr llvm::StringLiteral FoundationIdentifiers[] = {
"CGFloat",
krasimir wrote:
> jolesiak wrot
LukeCheeseman closed this revision.
LukeCheeseman added a comment.
closed by https://reviews.llvm.org/rC328092
Repository:
rC Clang
https://reviews.llvm.org/D44555
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-
a.sidorin added a comment.
Hi Gabor! This looks much better.
Comment at: unittests/AST/ASTImporterTest.cpp:1000
+ R"(
+ template
+ struct X {};
In C++, names started with underscore are reserved for implementation so it's
undesirable to use them
djasper accepted this revision.
djasper added a comment.
This revision is now accepted and ready to land.
Please generally upload diffs with the full file as context so that Phabricator
can properly expand the context where necessary.
This looks good, though.
Repository:
rC Clang
https://re
aaron.ballman added a comment.
I think `hasSourceExpression()` already does what you're looking for.
void f() {
int i = 1.0f;
}
clang-query> match implicitCastExpr(hasSourceExpression(floatLiteral()))
Match #1:
C:\Users\aballman.GRAMMATECH\Desktop\test.c:2:11: note: "root" binds here
ilya-biryukov added inline comments.
Comment at: clangd/SourceCode.h:41
/// Turn an offset in Code into a [line, column] pair.
Position offsetToPosition(llvm::StringRef Code, size_t Offset);
We should be consistent for all functions inside this fail. They may
aaron.ballman added a comment.
This generally looks reasonable to me, but @rsmith should weigh in before you
commit because `MultiSourceLocation` is novel.
https://reviews.llvm.org/D44589
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http
Author: lukecheeseman
Date: Wed Mar 21 05:05:19 2018
New Revision: 328092
URL: http://llvm.org/viewvc/llvm-project?rev=328092&view=rev
Log:
clang-interpreter example cmake fix
Add in a space when appending the export to the linker options. Without
the space the export is appended onto whatever th
hokein created this revision.
hokein added a reviewer: sammccall.
Herald added subscribers: ioeric, jkorous-apple, ilya-biryukov, klimek.
This would allow us to log the editor using custom-built clangd.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D44732
Files:
clangd/client
simark updated this revision to Diff 139292.
simark marked 3 inline comments as done.
simark added a comment.
Remove spaces, add fixmes
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D44673
Files:
clangd/ClangdServer.cpp
clangd/SourceCode.cpp
clangd/SourceCode.h
unittest
simark marked 6 inline comments as done.
simark added inline comments.
Comment at: clangd/ClangdServer.cpp:199
+return End.takeError();
+
+ return formatCode(Code, File, {tooling::Range(*Begin, *End - *Begin)});
ilya-biryukov wrote:
> NIT: unnecessary empty
JonasToth updated this revision to Diff 139293.
JonasToth marked 4 inline comments as done.
JonasToth added a comment.
- adress review comments
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D40737
Files:
clang-tidy/hicpp/CMakeLists.txt
clang-tidy/hicpp/HICPPTidyModule.cpp
JonasToth added inline comments.
Comment at: clang-tidy/hicpp/MultiwayPathsCoveredCheck.cpp:119
+ if (!SwitchHasDefault && SwitchCaseCount == 0) {
+diag(Switch->getLocStart(), "degenerated switch without labels");
+return;
aaron.ballman wrote:
> I think
martong added inline comments.
Comment at: unittests/AST/ASTImporterTest.cpp:1169
+ MatchVerifier Verifier;
+ ASSERT_TRUE(Verifier.match(From, cxxRecordDecl(has(fieldDecl();
+ ASSERT_TRUE(Verifier.match(To, cxxRecordDecl(has(fieldDecl();
a.sidorin wrot
martong updated this revision to Diff 139295.
martong marked 7 inline comments as done.
martong added a comment.
Add minor syntax changes and rename
Repository:
rC Clang
https://reviews.llvm.org/D43967
Files:
unittests/AST/ASTImporterTest.cpp
unittests/AST/DeclMatcher.h
Index: unittests
ilya-biryukov added inline comments.
Comment at: clangd/ClangdServer.cpp:199
+return End.takeError();
+
+ return formatCode(Code, File, {tooling::Range(*Begin, *End - *Begin)});
simark wrote:
> ilya-biryukov wrote:
> > NIT: unnecessary empty line
> In genera
alexfh accepted this revision.
alexfh added a comment.
LG. Thanks!
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D44694
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commi
Author: alexfh
Date: Wed Mar 21 07:39:24 2018
New Revision: 328101
URL: http://llvm.org/viewvc/llvm-project?rev=328101&view=rev
Log:
[clang-tidy][modernize-make-unique] Checks c++14 flag before using
std::make_unique
Summary: For a c++11 code, the clang-tidy rule "modernize-make-unique" should
This revision was automatically updated to reflect the committed changes.
Closed by commit rL328100: Make positionToOffset return
llvm::Expected (authored by simark, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D44673
Files:
c
This revision was automatically updated to reflect the committed changes.
Closed by commit rL328101: [clang-tidy][modernize-make-unique] Checks c++14
flag before using std… (authored by alexfh, committed by ).
Herald added subscribers: llvm-commits, klimek.
Changed prior to commit:
https://revi
This revision was automatically updated to reflect the committed changes.
Closed by commit rCTE328100: Make positionToOffset return
llvm::Expected (authored by simark, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D44673?vs=139292&id=139297#toc
Repository:
rL LLVM
On Mon, Mar 19, 2018 at 10:43 PM wrote:
> This should be fixed by r327911.
>
Thanks!
>
>
> Douglas Yung
>
>
>
> *From:* cfe-commits [mailto:cfe-commits-boun...@lists.llvm.org] *On
> Behalf Of *Galina Kistanova via cfe-commits
> *Sent:* Monday, March 19, 2018 13:13
> *To:* Alexander Kornienko
>
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
LG modulo other reviewers' open comments.
https://reviews.llvm.org/D44231
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.ll
Author: simark
Date: Wed Mar 21 07:36:46 2018
New Revision: 328100
URL: http://llvm.org/viewvc/llvm-project?rev=328100&view=rev
Log:
Make positionToOffset return llvm::Expected
Summary:
To implement incremental document syncing, we want to verify that the
ranges provided by the front-end are val
djasper accepted this revision.
djasper added a comment.
Looks good.
Repository:
rC Clang
https://reviews.llvm.org/D44692
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
djasper accepted this revision.
djasper added a comment.
Looks good.
Repository:
rC Clang
https://reviews.llvm.org/D44632
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
grokos abandoned this revision.
grokos added a comment.
@ABataev came up with a much simpler solution to the implementation of `declare
target`: https://reviews.llvm.org/rL327636
I am abandoning this obsolete revision.
Repository:
rC Clang
https://reviews.llvm.org/D43026
grokos abandoned this revision.
grokos added a comment.
@ABataev came up with a much simpler solution to the implementation of `declare
target`: https://reviews.llvm.org/rL327636
I am abandoning this obsolete revision.
Repository:
rL LLVM
https://reviews.llvm.org/D38798
_
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM!
Comment at: clang-tidy/hicpp/MultiwayPathsCoveredCheck.cpp:119
+ if (!SwitchHasDefault && SwitchCaseCount == 0) {
+diag(Switch->getLocStart(), "degen
JonasToth updated this revision to Diff 139304.
JonasToth marked 3 inline comments as done.
JonasToth added a comment.
- add fixme for degenerated switch
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D40737
Files:
clang-tidy/hicpp/CMakeLists.txt
clang-tidy/hicpp/HICPPTidyMo
JonasToth added inline comments.
Comment at: clang-tidy/hicpp/MultiwayPathsCoveredCheck.cpp:119
+ if (!SwitchHasDefault && SwitchCaseCount == 0) {
+diag(Switch->getLocStart(), "degenerated switch without labels");
+return;
aaron.ballman wrote:
> JonasTot
mibintc added inline comments.
Comment at: include/llvm-c/Target.h:25
-#if defined(_MSC_VER) && !defined(inline)
+#if defined(_MSC_VER) && !defined(inline) && !defined(__INTEL_COMPILER)
#define inline __inline
yvvan wrote:
> mibintc wrote:
> > I really think a
Author: jonastoth
Date: Wed Mar 21 08:34:15 2018
New Revision: 328107
URL: http://llvm.org/viewvc/llvm-project?rev=328107&view=rev
Log:
[clang-tidy] Resubmit hicpp-multiway-paths-covered without breaking test
The original check did break the green buildbot in the sanitizer build.
It took a while
>From the bot changes, it seems that -Wunknown-pragma doesn't disable this
new warning. Shouldn't it do that?
On Tue, Mar 20, 2018, 9:55 AM Hans Wennborg via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: hans
> Date: Tue Mar 20 01:53:11 2018
> New Revision: 327959
>
> URL: http://llv
courbet added a comment.
Thanks for the pointer. I missed the trampoline through
GetSourceExpressionMatcher.
Repository:
rC Clang
https://reviews.llvm.org/D44729
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-b
simark marked 34 inline comments as done.
simark added inline comments.
Comment at: clangd/DraftStore.h:36
/// Replace contents of the draft for \p File with \p Contents.
- void updateDraft(PathRef File, StringRef Contents);
+ void addDraft(PathRef File, StringRef Contents);
alexfh added inline comments.
Comment at: clang-tidy/modernize/DeprecatedFunctionalCheck.cpp:48-54
+ } else if (const auto *const Call =
+ Result.Nodes.getNodeAs("ptr_fun_call")) {
+diag(Call->getLocStart(), Message) << "'std::ptr_fun'";
+ } else if (const a
a.sidorin accepted this revision.
a.sidorin added a comment.
This revision is now accepted and ready to land.
This looks good to me. Thank you!
@xazax.hun Gabor, could you please take a look?
Repository:
rC Clang
https://reviews.llvm.org/D43967
_
Author: jonastoth
Date: Wed Mar 21 08:50:15 2018
New Revision: 328108
URL: http://llvm.org/viewvc/llvm-project?rev=328108&view=rev
Log:
[Fix] fix type deduction on ARM and MSVC
Modified:
clang-tools-extra/trunk/clang-tidy/hicpp/MultiwayPathsCoveredCheck.cpp
Modified: clang-tools-extra/trunk/
aaron.ballman added inline comments.
Comment at: clang-tidy/modernize/DeprecatedFunctionalCheck.cpp:48-54
+ } else if (const auto *const Call =
+ Result.Nodes.getNodeAs("ptr_fun_call")) {
+diag(Call->getLocStart(), Message) << "'std::ptr_fun'";
+ } else if (
vsapsai added a comment.
In https://reviews.llvm.org/D44589#1044350, @aaron.ballman wrote:
> This generally looks reasonable to me, but @rsmith should weigh in before you
> commit because `MultiSourceLocation` is novel.
Thanks for the review, Aaron. I tried not to do anything stupid with
`Mul
simark updated this revision to Diff 139310.
simark marked an inline comment as done.
simark added a comment.
Address review comments, except LSP version check
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D44272
Files:
clangd/ClangdLSPServer.cpp
clangd/DraftStore.cpp
cla
phosek updated this revision to Diff 139311.
https://reviews.llvm.org/D44724
Files:
clang/cmake/caches/Fuchsia-stage2.cmake
Index: clang/cmake/caches/Fuchsia-stage2.cmake
===
--- clang/cmake/caches/Fuchsia-stage2.cmake
+++ clang/
ilya-biryukov added inline comments.
Comment at: clangd/DraftStore.h:36
/// Replace contents of the draft for \p File with \p Contents.
- void updateDraft(PathRef File, StringRef Contents);
+ void addDraft(PathRef File, StringRef Contents);
+
simark wrote:
>
Author: phosek
Date: Wed Mar 21 09:48:26 2018
New Revision: 328114
URL: http://llvm.org/viewvc/llvm-project?rev=328114&view=rev
Log:
[Fuchsia] Don't install libc++, libc++abi or libunwind on Darwin
The Clang driver doesn't currently know how to use the libraries
that are shipped as part of the to
This revision was automatically updated to reflect the committed changes.
Closed by commit rL328114: [Fuchsia] Don't install libc++, libc++abi or
libunwind on Darwin (authored by phosek, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D
rjmccall added a comment.
In https://reviews.llvm.org/D44559#1044186, @avt77 wrote:
> >> In https://reviews.llvm.org/D44559#1040799, @rjmccall wrote:
> >>
> >>> I think we're correct not to warn here and that GCC/ICC are being noisy.
> >>> The existence of a temporary promotion to a wider type
MaskRay updated this revision to Diff 139313.
MaskRay added a comment.
Update summary
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D44720
Files:
clangd/FuzzyMatch.cpp
clangd/FuzzyMatch.h
Index: clangd/FuzzyMatch.h
==
MaskRay updated this revision to Diff 139314.
MaskRay edited the summary of this revision.
MaskRay added a comment.
Update summary
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D44720
Files:
clangd/FuzzyMatch.cpp
clangd/FuzzyMatch.h
Index: clangd/FuzzyMatch.h
=
aaron.ballman added a comment.
In https://reviews.llvm.org/D44559#1044639, @rjmccall wrote:
> In https://reviews.llvm.org/D44559#1044186, @avt77 wrote:
>
> > >> In https://reviews.llvm.org/D44559#1040799, @rjmccall wrote:
> > >>
> > >>> I think we're correct not to warn here and that GCC/ICC are
MaskRay added inline comments.
Comment at: clangd/FuzzyMatch.cpp:93
+ for (int I = PatN; I <= WordN; I++)
+Best = std::max(Best, Scores[PatN][I][Match].Score);
if (isAwful(Best))
sammccall wrote:
> this looks like a behavior change - why?
This is a behavi
MaskRay added inline comments.
Comment at: clangd/FuzzyMatch.h:61
bool allowMatch(int P, int W) const;
- int skipPenalty(int W, Action Last) const;
- int matchBonus(int P, int W, Action Last) const;
+ int missScore(int W, Action Last) const;
+ int matchScore(int P, int W,
MaskRay added inline comments.
Comment at: clangd/FuzzyMatch.cpp:96
return None;
return ScoreScale * std::min(PerfectBonus * PatN, std::max(0, Best));
}
I also don't understand why it clamps the value to zero here. Negative values
are also meaningful to
Author: eugenezelenko
Date: Wed Mar 21 10:06:13 2018
New Revision: 328115
URL: http://llvm.org/viewvc/llvm-project?rev=328115&view=rev
Log:
[clang-tidy] Use :doc: for check links in Release Notes.
Differential revision: https://reviews.llvm.org/D44694
Modified:
clang-tools-extra/trunk/clang-
This revision was automatically updated to reflect the committed changes.
Closed by commit rCTE328115: [clang-tidy] Use :doc: for check links in Release
Notes. (authored by eugenezelenko, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D44694?vs=139167&id=139320#toc
Repositor
simark updated this revision to Diff 139321.
simark added a comment.
Remove draft if update fails
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D44272
Files:
clangd/ClangdLSPServer.cpp
clangd/DraftStore.cpp
clangd/DraftStore.h
clangd/Protocol.cpp
clangd/Protocol.h
t
alexfh added inline comments.
Comment at: clang-tidy/modernize/DeprecatedFunctionalCheck.cpp:48-54
+ } else if (const auto *const Call =
+ Result.Nodes.getNodeAs("ptr_fun_call")) {
+diag(Call->getLocStart(), Message) << "'std::ptr_fun'";
+ } else if (const a
juliehockett created this revision.
juliehockett added reviewers: zturner, phosek.
juliehockett added a project: clang-tools-extra.
Herald added a subscriber: xazax.hun.
After changes to lit.site.cfg.in, the test is now running (and failing) on
windows, so temporarily marking it unsupported. See
alekseyshl created this revision.
alekseyshl added a reviewer: eugenis.
Herald added a subscriber: cryptoad.
Porting HWASan to Linux x86-64, the third of the three patches, clang part.
Repository:
rC Clang
https://reviews.llvm.org/D44745
Files:
lib/Driver/SanitizerArgs.cpp
lib/Driver/Too
CodaFi updated this revision to Diff 139325.
https://reviews.llvm.org/D43737
Files:
lib/Sema/AnalysisBasedWarnings.cpp
test/SemaCXX/warn-infinite-recursion.cpp
Index: test/SemaCXX/warn-infinite-recursion.cpp
===
--- test/SemaCXX
yaxunl added a comment.
Ping
https://reviews.llvm.org/D44533
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
simark updated this revision to Diff 139328.
simark added a comment.
Add lit test case
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D44272
Files:
clangd/ClangdLSPServer.cpp
clangd/DraftStore.cpp
clangd/DraftStore.h
clangd/Protocol.cpp
clangd/Protocol.h
test/clangd/
phosek accepted this revision.
phosek added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D44743
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c
erik.pilkington added a comment.
Hi Volodymyr, thanks for working on this! Overall this looks good, I just have
a few nits.
Comment at: clang/include/clang/Basic/SourceLocation.h:202
+/// Can be used transparently in places where SourceLocation is expected.
+class MultiSourceL
rjmccall added a comment.
In https://reviews.llvm.org/D44559#1044653, @aaron.ballman wrote:
> In https://reviews.llvm.org/D44559#1044639, @rjmccall wrote:
>
> > In https://reviews.llvm.org/D44559#1044186, @avt77 wrote:
> >
> > > >> In https://reviews.llvm.org/D44559#1040799, @rjmccall wrote:
> >
Author: juliehockett
Date: Wed Mar 21 11:03:41 2018
New Revision: 328127
URL: http://llvm.org/viewvc/llvm-project?rev=328127&view=rev
Log:
[clang-tidy] Marking hicpp-no-assembler-msvc unsupported on Windows
After changes to lit.site.cfg.in, the test is now running (and failing)
on windows, so tem
juliehockett closed this revision.
juliehockett added a comment.
Committed in r328127.
https://reviews.llvm.org/D44743
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
yaxunl created this revision.
yaxunl added reviewers: rjmccall, arsenm.
Herald added subscribers: t-tye, tpr, dstuttard, wdng, kzhuravl.
This patch sets the calling convention for CUDA kernels required by AMDGPU
target.
Patch by Greg Rodgers.
Lit test added by Yaxun Liu.
https://reviews.llvm.o
aaron.ballman added inline comments.
Comment at: clang-tidy/modernize/DeprecatedFunctionalCheck.cpp:48-54
+ } else if (const auto *const Call =
+ Result.Nodes.getNodeAs("ptr_fun_call")) {
+diag(Call->getLocStart(), Message) << "'std::ptr_fun'";
+ } else if (
Author: juliehockett
Date: Wed Mar 21 11:50:26 2018
New Revision: 328131
URL: http://llvm.org/viewvc/llvm-project?rev=328131&view=rev
Log:
Reland "[lit] Adding config initialization to lit tests in clang-tools-extra"
Adding the config initialization to clang-tools-extra so that tests that
use REQ
gtbercea created this revision.
gtbercea added reviewers: ABataev, grokos, carlo.bertolli, caomhin.
Herald added subscribers: cfe-commits, guansong, jholewinski.
The workers also need to initialize the global stack. The call to the
initialization function needs to happen after the kernel_init() f
gtbercea abandoned this revision.
gtbercea added a comment.
This leads to usage of statically allocated shared data before their
initialization in runtime structures by master thread in kernel_init()
function. New patch available with worker and master-side initialization.
Repository:
rC Cla
lebedev.ri added inline comments.
Comment at: test/clang-tidy/readability-function-size.cpp:207-212
+void variables_8() {
+ int a, b;
+ struct A {
+A(int c, int d);
+ };
+}
aaron.ballman wrote:
> lebedev.ri wrote:
> > aaron.ballman wrote:
> > > lebedev.ri
mclow.lists added a comment.
Sorry I've let this lie fallow for so long.
Comment at: include/charconv:234
+to_chars(char* __first, char* __last, _Tp __value, int __base)
+-> to_chars_result
+{
Why use the trailing return type here?
I don't see any advantage
ilya-biryukov added inline comments.
Comment at: unittests/clangd/DraftStoreTests.cpp:27
+
+static int rangeLength(StringRef Code, const Range &Rng) {
+ size_t Start = positionToOffset(Code, Rng.start);
ilya-biryukov wrote:
> no need for `static`, since function
EricWF updated this revision to Diff 139347.
EricWF marked an inline comment as done.
EricWF added a comment.
- Merge with upstream.
- Add requested assertion.
https://reviews.llvm.org/D43047
Files:
include/clang/Basic/Builtins.def
include/clang/Basic/DiagnosticSemaKinds.td
include/clang/
EricWF added inline comments.
Comment at: lib/Sema/SemaExprCXX.cpp:3458
+ }
+ TheCall->getCallee()->setType(OperatorNewOrDelete->getType());
+
rsmith wrote:
> It would be nice to assert that the callee you're setting the type of is an
> ImplicitCastExpr doing
Author: ericwf
Date: Wed Mar 21 12:19:48 2018
New Revision: 328134
URL: http://llvm.org/viewvc/llvm-project?rev=328134&view=rev
Log:
[Builtins] Overload __builtin_operator_new/delete to allow forwarding to usual
allocation/deallocation functions.
Summary:
Libc++'s default allocator uses `__built
This revision was automatically updated to reflect the committed changes.
Closed by commit rC328134: [Builtins] Overload __builtin_operator_new/delete to
allow forwarding to usual… (authored by EricWF, committed by ).
Repository:
rC Clang
https://reviews.llvm.org/D43047
Files:
include/clang
This revision was automatically updated to reflect the committed changes.
Closed by commit rL328134: [Builtins] Overload __builtin_operator_new/delete to
allow forwarding to usual… (authored by EricWF, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://rev
MaskRay added inline comments.
Comment at: clangd/FuzzyMatch.h:61
bool allowMatch(int P, int W) const;
- int skipPenalty(int W, Action Last) const;
- int matchBonus(int P, int W, Action Last) const;
+ int missScore(int W, Action Last) const;
+ int matchScore(int P, int W,
simark marked 6 inline comments as done.
simark added inline comments.
Herald added a subscriber: MaskRay.
Comment at: unittests/clangd/DraftStoreTests.cpp:27
+
+static int rangeLength(StringRef Code, const Range &Rng) {
+ size_t Start = positionToOffset(Code, Rng.start);
--
simark updated this revision to Diff 139355.
simark marked an inline comment as done.
simark added a comment.
Address review comments I failed to address previously
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D44272
Files:
clangd/ClangdLSPServer.cpp
clangd/DraftStore.cpp
Ericson2314 created this revision.
Ericson2314 added reviewers: arphaman, compnerd, dexonsmith, bob.wilson,
steven_wu.
Herald added subscribers: cfe-commits, javed.absar.
Per my belated [reply] to the mailing list, I believe the "target"
nomenclature incorrect for cross compilation.
[reply]: htt
rjmccall added a comment.
Is there a reason for this to be done as a special case in IRGen instead of
just implicitly applying the calling convention in Sema?
https://reviews.llvm.org/D44747
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
h
1 - 100 of 167 matches
Mail list logo
