[PATCH] D45240: [ARM] Compute a target feature which corresponds to the ARM version.

fhahn accepted this revision. fhahn added a comment. Thanks for updating it to use the stuff from TargetParser. LGTM, with tests for the cases @joerg mentiond. Comment at: lib/Basic/Targets/ARM.cpp:345 // get default FPU features + llvm::ARM::ArchKind Arch =

[PATCH] D45254: [X86][WAITPKG] WaitPKG intrinsics

GBuella added inline comments. Comment at: lib/Headers/waitpkgintrin.h:41 +static __inline__ void __DEFAULT_FN_ATTRS +_umwait (__SIZE_TYPE__ __CONTROL, __UINT64_TYPE__ __COUNTER) +{ craig.topper wrote: > Why does the intrinsic take size_t but then its

r329442 - Generate Libclang invocation reproducers using a new -cc1gen-reproducer

Author: arphaman Date: Fri Apr 6 11:30:14 2018 New Revision: 329442 URL: http://llvm.org/viewvc/llvm-project?rev=329442=rev Log: Generate Libclang invocation reproducers using a new -cc1gen-reproducer driver option This commit is a follow up to the previous work that recorded Libclang

[PATCH] D40983: Generate Libclang invocation reproducers using a new -cc1gen-reproducer option

This revision was automatically updated to reflect the committed changes. Closed by commit rL329442: Generate Libclang invocation reproducers using a new -cc1gen-reproducer (authored by arphaman, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D45384: [ObjC++] Never pass structs with `__weak` fields in registers

ahatanak created this revision. ahatanak added reviewers: rjmccall, rsmith. This patch fixes a bug in r328731 that caused structs with `__weak` fields to be passed in registers. This happens when a struct doesn't have a `__weak` field but one of its subobjects does. To fix this, I added flag

[PATCH] D45387: [CUDA] Revert defining __CUDA_ARCH__ for amdgcn targets

tra accepted this revision. tra added a comment. This revision is now accepted and ready to land. You may want to mention in the commit log that this is a partial unroll of r329232 / https://reviews.llvm.org/D45277. https://reviews.llvm.org/D45387

Re: r329342 - PR36992: do not store beyond the dsize of a class object unless we know

Thanks, I see the problem. On Fri, 6 Apr 2018, 11:56 via cfe-commits, wrote: > Hi Richard, > > I don't know if you are aware, but the test you added in this commit, > tail-padding.cpp is currently failing on one of the ARM bots. Can you take > a look? > > >

[PATCH] D45383: Strip reference from a va_list object in C when merging parameter types.

erichkeane added a comment. One big issue with just disallowing redecls of builtins is we have is that a number of these are actually expected to be in the system headers/libraries (such as vprintf). A ton of the math.h functions are also builtins. Repository: rC Clang

[PATCH] D45382: [CodeGen] Avoid destructing a struct type that has already been destructed by a delegated constructor

ahatanak created this revision. ahatanak added reviewers: rjmccall, rsmith. Herald added a subscriber: kristof.beyls. This patch fixes a bug where a struct with an ObjC `__weak` field gets destructed after it has already been destructed. This bug was introduced in r328731, which made changes to

RE: r329342 - PR36992: do not store beyond the dsize of a class object unless we know

Hi Richard, I don't know if you are aware, but the test you added in this commit, tail-padding.cpp is currently failing on one of the ARM bots. Can you take a look? http://lab.llvm.org:8011/builders/clang-cmake-armv7-selfhost-neon/builds/178 TEST 'Clang ::

[PATCH] D45277: [CUDA] Add amdgpu sub archs

tra added inline comments. Comment at: lib/Basic/Targets.cpp:161 +case CudaArch::GFX902: + return "320"; +case CudaArch::UNKNOWN: yaxunl wrote: > tra wrote: > > yaxunl wrote: > > > tra wrote: > > > > yaxunl wrote: > > > > > tra wrote: > > > > > >

[PATCH] D45387: [CUDA] Revert defining __CUDA_ARCH__ for amdgcn targets

yaxunl added a comment. In https://reviews.llvm.org/D45387#1060194, @tra wrote: > You may want to mention in the commit log that this is a partial unroll of > r329232 / https://reviews.llvm.org/D45277. Will do. Thanks. https://reviews.llvm.org/D45387

[clang-tools-extra] r329452 - [clang-tidy] Fix compilation for ParentVirtualCallCheck.cpp

Author: zinovy.nis Date: Fri Apr 6 13:39:23 2018 New Revision: 329452 URL: http://llvm.org/viewvc/llvm-project?rev=329452=rev Log: [clang-tidy] Fix compilation for ParentVirtualCallCheck.cpp Modified: clang-tools-extra/trunk/clang-tidy/bugprone/ParentVirtualCallCheck.cpp Modified:

[PATCH] D45383: Strip reference from a va_list object in C when merging parameter types.

erichkeane added a comment. In https://reviews.llvm.org/D45383#1060275, @efriedma wrote: > By "builtins" I meant specifically the stuff that that user code isn't > allowed to declare, like __builtin_*, since they often have weird/incomplete > signatures. Unfortunately, the problem shows in

r329449 - Don't assume constructors return void.

Author: rsmith Date: Fri Apr 6 13:06:02 2018 New Revision: 329449 URL: http://llvm.org/viewvc/llvm-project?rev=329449=rev Log: Don't assume constructors return void. Should fix ARM buildbot. Modified: cfe/trunk/test/CodeGenCXX/tail-padding.cpp Modified:

[PATCH] D45240: [ARM] Compute a target feature which corresponds to the ARM version.

efriedma updated this revision to Diff 141393. efriedma added a comment. Add a bunch of tests for various arm arches. Make sure we do something reasonable when we can't figure out any arch at all. Repository: rC Clang https://reviews.llvm.org/D45240 Files: lib/Basic/Targets/ARM.cpp

[PATCH] D45384: [ObjC++] Never pass structs with `__weak` fields in registers

rjmccall added a comment. Well, but I think CanPassInRegisters==false in the base class does always mean CanPassInRegisters==false in the subclass. Repository: rC Clang https://reviews.llvm.org/D45384 ___ cfe-commits mailing list

[clang-tools-extra] r329448 - [clang-tidy] Check if grand-..parent's virtual method was called instead of overridden parent's.

Author: zinovy.nis Date: Fri Apr 6 13:02:50 2018 New Revision: 329448 URL: http://llvm.org/viewvc/llvm-project?rev=329448=rev Log: [clang-tidy] Check if grand-..parent's virtual method was called instead of overridden parent's. class A {...int virtual foo() {...}...}; class B: public A

[PATCH] D45383: Strip reference from a va_list object in C when merging parameter types.

erichkeane added a comment. In https://reviews.llvm.org/D45383#1060104, @efriedma wrote: > Rather than adding weird hacks to merging, can we just reject any attempt to > redeclare a builtin? I don't believe we can. I think things often re-declare them, particularly when it comes to va_end.

[PATCH] D45277: [CUDA] Add amdgpu sub archs

yaxunl added inline comments. Comment at: lib/Basic/Targets.cpp:161 +case CudaArch::GFX902: + return "320"; +case CudaArch::UNKNOWN: tra wrote: > yaxunl wrote: > > tra wrote: > > > yaxunl wrote: > > > > tra wrote: > > > > > yaxunl wrote: > > > > > >

[PATCH] D45383: Strip reference from a va_list object in C when merging parameter types.

erichkeane created this revision. erichkeane added reviewers: efriedma, eli.friedman, compnerd, rsmith. erichkeane added a project: clang. As reported here: https://bugs.llvm.org/show_bug.cgi?id=37033 Any usage of a builtin function that uses a va_list by reference will cause an assertion when

[PATCH] D41968: [libunwind][MIPS] Support MIPS floating-point registers for hard-float ABIs.

bsdjhb added a comment. Ping @sdardis @compnerd Repository: rUNW libunwind https://reviews.llvm.org/D41968 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r329444 - [analyzer] Remove an unused variable

Author: george.karpenkov Date: Fri Apr 6 12:03:43 2018 New Revision: 329444 URL: http://llvm.org/viewvc/llvm-project?rev=329444=rev Log: [analyzer] Remove an unused variable Modified: cfe/trunk/lib/Analysis/LiveVariables.cpp Modified: cfe/trunk/lib/Analysis/LiveVariables.cpp URL:

[PATCH] D45382: [CodeGen] Avoid destructing a struct type that has already been destructed by a delegated constructor

rjmccall added a comment. Hmm. I'm not actually sure *why* it's not okay to forward callee-cleanup arguments. Do we just not have the necessary logic to disable the cleanup in the caller? Repository: rC Clang https://reviews.llvm.org/D45382

[PATCH] D44295: [clang-tidy] Detect and fix calls to grand-...parent virtual methods instead of calls to parent's virtual methods

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE329448: [clang-tidy] Check if grand-..parents virtual method was called instead of… (authored by zinovy.nis, committed by ). Changed prior to commit:

[PATCH] D45383: Strip reference from a va_list object in C when merging parameter types.

efriedma added a comment. By "builtins" I meant specifically the stuff that that user code isn't allowed to declare, like __builtin_*, since they often have weird/incomplete signatures. Repository: rC Clang https://reviews.llvm.org/D45383 ___

[PATCH] D45240: [ARM] Compute a target feature which corresponds to the ARM version.

efriedma added a comment. > I take it we still have test cases for the arm <-> thumb transition? "-mthumb" and "-marm" are handled in the driver by rewriting the triple. Repository: rC Clang https://reviews.llvm.org/D45240 ___ cfe-commits

[PATCH] D45383: Strip reference from a va_list object in C when merging parameter types.

efriedma added a comment. Rather than adding weird hacks to merging, can we just reject any attempt to redeclare a builtin? Repository: rC Clang https://reviews.llvm.org/D45383 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r329445 - Revert "[analyzer] Remove an unused variable"

Author: george.karpenkov Date: Fri Apr 6 12:14:05 2018 New Revision: 329445 URL: http://llvm.org/viewvc/llvm-project?rev=329445=rev Log: Revert "[analyzer] Remove an unused variable" This reverts commit 2fa3e3edc4ed6547cc4ce46a8c79d1891a5b3b36. Removed the wrong variable. Modified:

r329447 - Revert r329442 "Generate Libclang invocation reproducers using a new

Author: arphaman Date: Fri Apr 6 12:45:29 2018 New Revision: 329447 URL: http://llvm.org/viewvc/llvm-project?rev=329447=rev Log: Revert r329442 "Generate Libclang invocation reproducers using a new -cc1gen-reproducer driver option" The tests are failing on some bots Removed:

[PATCH] D45387: [CUDA] Revert defining __CUDA_ARCH__ for amdgcn targets

yaxunl created this revision. yaxunl added a reviewer: tra. Herald added subscribers: nhaehnle, jholewinski. amdgcn targets only support HIP, which does not define `__CUDA_ARCH__`. `__HIP_DEVICE_COMPILE__` depends on HIP language mode, therefore it needs to be added in a different patch. refer

[PATCH] D45384: [ObjC++] Never pass structs with `__weak` fields in registers

ahatanak added a comment. In https://reviews.llvm.org/D45384#1060164, @rjmccall wrote: > Well, but I think CanPassInRegisters==false in the base class does always > mean CanPassInRegisters==false in the subclass. I think there are cases that is not true. If I compile the following code, S0

[clang-tools-extra] r329454 - [clang-tidy] One more fix compilation for ParentVirtualCallCheck.cpp: find_if predicate

Author: zinovy.nis Date: Fri Apr 6 14:00:18 2018 New Revision: 329454 URL: http://llvm.org/viewvc/llvm-project?rev=329454=rev Log: [clang-tidy] One more fix compilation for ParentVirtualCallCheck.cpp: find_if predicate Modified:

[PATCH] D44616: Update existed CodeGen TBAA tests

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Yes, this is fine. Repository: rC Clang https://reviews.llvm.org/D44616 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D44773: [CMake] Use custom command and target to install libc++ headers

phosek updated this revision to Diff 141442. phosek marked an inline comment as done. Repository: rCXX libc++ https://reviews.llvm.org/D44773 Files: libcxx/NOTES.TXT libcxx/cmake/Modules/HandleLibCXXABI.cmake libcxx/include/CMakeLists.txt libcxx/lib/CMakeLists.txt Index:

[PATCH] D45357: [XRay][llvm+clang] Consolidate attribute list files

vlad.tsyrklevich accepted this revision. vlad.tsyrklevich added inline comments. This revision is now accepted and ready to land. Comment at: llvm/docs/XRayExample.rst:196 +``-fxray-attr-list=`` flag to clang. You can have multiple files, each defining +different sets of

[PATCH] D42893: [libclang] Add clang_File_tryGetRealPathName

MaskRay added a comment. There is no unittest but I have verified with a C++ language server on Arch Linux. Without using this function, cquery/ccls will not be able to index system header files because of excessive .. in the path returned by clang_getFileName. Repository: rC Clang

[PATCH] D43957: Fixing issue where a space was not added before a global namespace variable when SpacesInParentheses is set

dpayne added a comment. Hi Bumping this commit. I do not have commit access so I cannot merge myself, if you have the time could you merge this commit? Repository: rC Clang https://reviews.llvm.org/D43957 ___ cfe-commits mailing list

RE: [clang-tools-extra] r329454 - [clang-tidy] One more fix compilation for ParentVirtualCallCheck.cpp: find_if predicate

Hi Zinovy, The PS4 Windows bot is still failing to compile this file after your latest change. Can you take a look? http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/builds/16316 FAILED:

[PATCH] D45384: [ObjC++] Never pass structs with `__weak` fields in registers

ahatanak added a comment. Yes. I intended it as a property that propagates to classes that contain or derive from the type. Would it make it less confusing if I merged CXXRecordDecl::CanPassInRegisters and RecordDecl::CannotPassInRegisters into a single enum? For example, the enum could have

[PATCH] D45392: add new check to find out objc ivars which do not have prefix '_'

Wizard created this revision. Herald added subscribers: cfe-commits, mgorny, klimek. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D45392 Files: clang-tidy/objc/CMakeLists.txt clang-tidy/objc/IvarDeclarationCheck.cpp clang-tidy/objc/IvarDeclarationCheck.h

[PATCH] D45384: [ObjC++] Never pass structs with `__weak` fields in registers

rjmccall added a comment. In https://reviews.llvm.org/D45384#1060369, @ahatanak wrote: > Yes. I intended it as a property that propagates to classes that contain or > derive from the type. > > Would it make it less confusing if I merged CXXRecordDecl::CanPassInRegisters > and

[PATCH] D45384: [ObjC++] Never pass structs with `__weak` fields in registers

rjmccall added a comment. In https://reviews.llvm.org/D45384#1060192, @ahatanak wrote: > In https://reviews.llvm.org/D45384#1060164, @rjmccall wrote: > > > Well, but I think CanPassInRegisters==false in the base class does always > > mean CanPassInRegisters==false in the subclass. > > > I think

[PATCH] D45382: [CodeGen] Avoid destructing a struct type that has already been destructed by a delegated constructor

ahatanak added a comment. In https://reviews.llvm.org/D45382#1060163, @rjmccall wrote: > Hmm. I'm not actually sure *why* it's not okay to forward callee-cleanup > arguments. Do we just not have the necessary logic to disable the cleanup in > the caller? It seems that it would be OK if

[PATCH] D45305: ObjCGNU: Fix empty v3 protocols being emitted two fields short

DHowett-MSFT updated this revision to Diff 141450. DHowett-MSFT added a comment. Added a test per @rjmccall's suggestion. I chose to test this by emitting assembly because the llvm ir is significantly harder to pick apart for the true _size_ of the protocol. Repository: rC Clang

[PATCH] D44646: Sema: in msvc compatibility mode, don't allow forceinline on variadics

DHowett-MSFT added a comment. Thanks! I don't have the means to check this in myself. Repository: rC Clang https://reviews.llvm.org/D44646 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r329467 - Generalize test for 32-bit targets.

Author: rsmith Date: Fri Apr 6 17:28:32 2018 New Revision: 329467 URL: http://llvm.org/viewvc/llvm-project?rev=329467=rev Log: Generalize test for 32-bit targets. Modified: cfe/trunk/test/CodeGenCXX/tail-padding.cpp Modified: cfe/trunk/test/CodeGenCXX/tail-padding.cpp URL:

[PATCH] D44449: [Parser] Fix assertion-on-invalid for unexpected typename.

vsapsai updated this revision to Diff 141448. vsapsai added a comment. - Add a comment. https://reviews.llvm.org/D9 Files: clang/lib/Parse/ParseDecl.cpp clang/test/Parser/cxx-decl.cpp Index: clang/test/Parser/cxx-decl.cpp

[PATCH] D45384: [ObjC++] Never pass structs with `__weak` fields in registers

ahatanak updated this revision to Diff 141471. ahatanak added a comment. Replace flags CanPassInRegisters and CannotPassInRegisters with a 2-bit enum in RecordDecl. Repository: rC Clang https://reviews.llvm.org/D45384 Files: include/clang/AST/Decl.h include/clang/AST/Type.h

[PATCH] D44988: [Sema] Fix decrement availability for built-in types

vsapsai added inline comments. Comment at: test/SemaCXX/overloaded-builtin-operators.cpp:95-99 // C++ [over.built]p3 long l1 = lr--; + // C++ [over.built]p4 + float f1 = fr--; Looks like p3 for `lr--` is a typo because p3 is about `++` while p4 is

[libcxx] r329460 - Implement P0768r1: Library support for the Spaceship Operator.

Author: ericwf Date: Fri Apr 6 14:37:23 2018 New Revision: 329460 URL: http://llvm.org/viewvc/llvm-project?rev=329460=rev Log: Implement P0768r1: Library support for the Spaceship Operator. this patch adds the header and implements all of it except for [comp.alg]. As I understand it, the

[PATCH] D41148: [libcxx] implement declarations based on P0214R7.

timshen updated this revision to Diff 141436. timshen marked an inline comment as done. timshen added a comment. Update file comments copy-paste error. https://reviews.llvm.org/D41148 Files: libcxx/include/experimental/__config libcxx/include/experimental/simd

[PATCH] D44449: [Parser] Fix assertion-on-invalid for unexpected typename.

vsapsai added inline comments. Comment at: clang/lib/Parse/ParseDecl.cpp:3076 DS.SetRangeEnd(Tok.getAnnotationEndLoc()); ConsumeAnnotationToken(); // The typename } rsmith wrote: > vsapsai wrote: > > Here we potentially can leave

[libcxx] r329474 - Work around missing braces in init warning

Author: ericwf Date: Fri Apr 6 18:28:54 2018 New Revision: 329474 URL: http://llvm.org/viewvc/llvm-project?rev=329474=rev Log: Work around missing braces in init warning Modified: libcxx/trunk/include/compare Modified: libcxx/trunk/include/compare URL:

r329476 - Remove another unnecessary -I flag passed to clang-tblgen.

Author: nico Date: Fri Apr 6 18:34:36 2018 New Revision: 329476 URL: http://llvm.org/viewvc/llvm-project?rev=329476=rev Log: Remove another unnecessary -I flag passed to clang-tblgen. Modified: cfe/trunk/include/clang/StaticAnalyzer/Checkers/CMakeLists.txt

[libclc] r329462 - select: simplify implementation and fix fp16

Author: jvesely Date: Fri Apr 6 15:00:00 2018 New Revision: 329462 URL: http://llvm.org/viewvc/llvm-project?rev=329462=rev Log: select: simplify implementation and fix fp16 Fix half precision implementation Vector ?: operator should behave exactly as select Passes CTS on carrizo Signed-off-by:

[PATCH] D45383: Strip reference from a va_list object in C when merging parameter types.

efriedma added a comment. How could this patch possibly affect vprintf? Repository: rC Clang https://reviews.llvm.org/D45383 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D45294: [libcxx] [test] Remove non-portable assertions from filebuf tests

BillyONeal updated this revision to Diff 141433. BillyONeal retitled this revision from "[libcxx] [test] Remove non-portable assertions from filebuf's seekoff.pass.cpp test" to "[libcxx] [test] Remove non-portable assertions from filebuf tests". BillyONeal edited the summary of this revision.

[PATCH] D45392: add new check to find out objc ivars which do not have prefix '_'

Wizard updated this revision to Diff 141444. Wizard added a comment. fix doc Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D45392 Files: clang-tidy/objc/CMakeLists.txt clang-tidy/objc/IvarDeclarationCheck.cpp clang-tidy/objc/IvarDeclarationCheck.h

r329465 - Recommit r329442: Generate Libclang invocation reproducers using a new

Author: arphaman Date: Fri Apr 6 17:03:27 2018 New Revision: 329465 URL: http://llvm.org/viewvc/llvm-project?rev=329465=rev Log: Recommit r329442: Generate Libclang invocation reproducers using a new -cc1gen-reproducer driver option The recommit fixes: - An MSAN failure (CCPrintOptions wasn't

r329464 - Remove two unnecessary -I flags passed to clang-tblgen.

Author: nico Date: Fri Apr 6 16:36:50 2018 New Revision: 329464 URL: http://llvm.org/viewvc/llvm-project?rev=329464=rev Log: Remove two unnecessary -I flags passed to clang-tblgen. Modified: cfe/trunk/include/clang/Basic/CMakeLists.txt Modified: cfe/trunk/include/clang/Basic/CMakeLists.txt

[PATCH] D45392: [clang-tidy] add new check to find out objc ivars which do not have prefix '_'

Eugene.Zelenko added a comment. If this is Apple guideline, check name should reflect this. I think will be good idea to have general check for Apple naming conventions instead of separate checks for specific situations like //objc-ivar-declaration// and //objc-property-declaration//.

Re: r311958 - Revert "Revert r311552: [Bash-autocompletion] Add support for static analyzer flags"

Hi Yuka, sorry about the late review comment on this. I just happened to see that this lets Driver's Option.inc depend on StaticAnalyzer/Checker's Checker.inc. However, Driver does not depend on StaticAnalyzer/Checker. In practice, it works ok because of all tablegen targets being collected into

r329481 - Sort source lists in lib/StaticAnalyzer.

Author: nico Date: Fri Apr 6 21:25:01 2018 New Revision: 329481 URL: http://llvm.org/viewvc/llvm-project?rev=329481=rev Log: Sort source lists in lib/StaticAnalyzer. Modified: cfe/trunk/lib/StaticAnalyzer/Core/CMakeLists.txt cfe/trunk/lib/StaticAnalyzer/Frontend/CMakeLists.txt

[libcxx] r329484 - Use void() to create a void expression type

Author: ericwf Date: Fri Apr 6 21:28:11 2018 New Revision: 329484 URL: http://llvm.org/viewvc/llvm-project?rev=329484=rev Log: Use void() to create a void expression type Modified: libcxx/trunk/include/compare Modified: libcxx/trunk/include/compare URL:

[PATCH] D45382: [CodeGen] Avoid destructing a struct type that has already been destructed by a delegated constructor

rjmccall added a comment. If that's the problem, then I think the right design is for CallArg to include an optional cleanup reference for a cleanup that can be deactivated at the instant of the call (we should assert that this exists for parameters that are destroyed in the callee), and then

[PATCH] D45212: [HIP] Let CUDA toolchain support HIP language mode and amdgpu

rjmccall added a comment. This looks okay to me, but I think it would better if someone with more expertise in the design of the driver and frontend code could review this. Comment at: lib/Driver/Driver.cpp:2267 +if ((IA->getType() != types::TY_CUDA) && +

[PATCH] D45384: [ObjC++] Never pass structs with `__weak` fields in registers

rjmccall added a comment. Just a couple minor requests; if you accept them, feel free to commit. Comment at: include/clang/AST/Decl.h:3556 +/// indirectly. This value is used only in C++. +APK_CannotPassInRegs, + I think it's probably worth spelling

r329477 - Make CodeGen depend just once on clangAnalysis.

Author: nico Date: Fri Apr 6 20:29:47 2018 New Revision: 329477 URL: http://llvm.org/viewvc/llvm-project?rev=329477=rev Log: Make CodeGen depend just once on clangAnalysis. Modified: cfe/trunk/lib/CodeGen/CMakeLists.txt Modified: cfe/trunk/lib/CodeGen/CMakeLists.txt URL:

[PATCH] D45233: [Driver] Update GCC libraries detection logic for Gentoo.

mgorny added a comment. To be honest, I don't really know. But since we're not installing it straight to `/usr`, I suppose that's not a problem we need to solve right now. However, they do work with clang installed in `/usr/lib/llvm/*/bin`, and this patch must not regress that. So if your

r329378 - [XRay][clang] Only run driver test for Linux and FreeBSD

Author: dberris Date: Thu Apr 5 23:09:57 2018 New Revision: 329378 URL: http://llvm.org/viewvc/llvm-project?rev=329378=rev Log: [XRay][clang] Only run driver test for Linux and FreeBSD This is a follow-up to D45354, which we should have only been running on Linux and FreeBSD for specific

[PATCH] D45240: [ARM] Compute a target feature which corresponds to the ARM version.

joerg added a comment. Can you make sure that we handle the older ARM versions correctly as well, i.e. v4, v5 and v6? I take it we still have test cases for the arm <-> thumb transition? That's the one part of the triple logic that is really non-trivial. Repository: rC Clang

[PATCH] D45096: Allow the creation of human-friendly ASTDumper to arbitrary output stream

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. LG. I'll commit the patch for you. Repository: rC Clang https://reviews.llvm.org/D45096 ___ cfe-commits mailing list

r329391 - Allow the creation of human-friendly ASTDumper to arbitrary output stream

Author: alexfh Date: Fri Apr 6 06:01:12 2018 New Revision: 329391 URL: http://llvm.org/viewvc/llvm-project?rev=329391=rev Log: Allow the creation of human-friendly ASTDumper to arbitrary output stream Summary: `ASTPrinter` allows setting the ouput to any O-Stream, but that printer creates

[PATCH] D45096: Allow the creation of human-friendly ASTDumper to arbitrary output stream

This revision was automatically updated to reflect the committed changes. Closed by commit rL329391: Allow the creation of human-friendly ASTDumper to arbitrary output stream (authored by alexfh, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D45254: [X86][WAITPKG] WaitPKG intrinsics

GBuella updated this revision to Diff 141319. GBuella added a comment. Using the modified LLVM intrinsics from https://reviews.llvm.org/D45253. https://reviews.llvm.org/D45254 Files: include/clang/Basic/BuiltinsX86.def include/clang/Driver/Options.td lib/Basic/Targets/X86.cpp

[PATCH] D40937: [clang-tidy] Infinite loop checker

szepet updated this revision to Diff 141322. szepet marked 4 inline comments as done. szepet added a comment. Addressed comments and readded the lost fixes. https://reviews.llvm.org/D40937 Files: clang-tidy/bugprone/BugproneTidyModule.cpp clang-tidy/bugprone/CMakeLists.txt

[PATCH] D45240: [ARM] Compute a target feature which corresponds to the ARM version.

rengolin added a subscriber: joerg. rengolin added a comment. LTO is something I never considered before in the context of the target parser, but I understand the issues are similar to what the build attributes were trying to solve, so adding more info shouldn't make it worse. However, this

[PATCH] D45356: [clangd] Adapt index interfaces to D45014, and fix the old bugs.

sammccall created this revision. Herald added subscribers: cfe-commits, MaskRay, ioeric, jkorous-apple, ilya-biryukov, klimek. - don't count occurrences of decls where we don't spell the name Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D45356 Files: clangd/XRefs.cpp

[PATCH] D44381: [mips] Prevent PIC to be set to level 2

sdardis requested changes to this revision. sdardis added a comment. This revision now requires changes to proceed. You should also update the description of the patch. Repository: rC Clang https://reviews.llvm.org/D44381 ___ cfe-commits mailing

[PATCH] D45096: Allow the creation of human-friendly ASTDumper to arbitrary output stream

whisperity updated this revision to Diff 141309. whisperity added a comment. Added comments on what `nullptr` means at call sites. Repository: rC Clang https://reviews.llvm.org/D45096 Files: docs/HowToSetupToolingForLLVM.rst include/clang/Frontend/ASTConsumers.h

[PATCH] D45096: Allow the creation of human-friendly ASTDumper to arbitrary output stream

whisperity marked 2 inline comments as done. whisperity added a comment. It is also std-out (`llvm::outs()`) in case of `nullptr` and not std-err. Repository: rC Clang https://reviews.llvm.org/D45096 ___ cfe-commits mailing list

[clang-tools-extra] r329380 - [clangd] move comment to the right place. NFC

Author: sammccall Date: Fri Apr 6 00:48:21 2018 New Revision: 329380 URL: http://llvm.org/viewvc/llvm-project?rev=329380=rev Log: [clangd] move comment to the right place. NFC Modified: clang-tools-extra/trunk/clangd/ClangdUnit.cpp Modified: clang-tools-extra/trunk/clangd/ClangdUnit.cpp

[PATCH] D45310: Warn about memcpy'ing non-trivial C structs

ahatanak updated this revision to Diff 141291. ahatanak marked 3 inline comments as done. ahatanak added a comment. Address review comments. Repository: rC Clang https://reviews.llvm.org/D45310 Files: include/clang/AST/NonTrivialTypeVisitor.h include/clang/Basic/DiagnosticSemaKinds.td

[PATCH] D45310: Warn about memcpy'ing non-trivial C structs

ahatanak added inline comments. Comment at: include/clang/AST/NonTrivialCStructTypeVisitor.h:30 +if (asDerived().getContext().getAsArrayType(FT)) + return asDerived().visitArray(DK, FT, std::forward(Args)...); + rjmccall wrote: > Should you have this

[PATCH] D45131: [AST] Refactor UnaryTransformType into TransformTraitType supporting non-unary transforms

EricWF updated this revision to Diff 141293. EricWF marked 2 inline comments as done. EricWF added a comment. Address all inline comments. - Dynamically allocate `TransformTraitType`s list of argument types; making the node trivially destructible. - Detect and handle parameter packs when

[PATCH] D45356: [clangd] Adapt index interfaces to D45014, and fix the old bugs.

sammccall updated this revision to Diff 141300. sammccall edited the summary of this revision. sammccall added a comment. Also fix source/expansion location confusion in XRefs (findDefinition et al) Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D45356 Files: clangd/XRefs.cpp

[PATCH] D45233: [Driver] Update GCC libraries detection logic for Gentoo.

mgorny added a comment. Well, it's better: Failing Tests (1): Clang :: Driver/linux-header-search.cpp It is apparently the new test failing: + /var/tmp/portage/sys-devel/clang-6.0.0-r1/work/x/y/cfe-6.0.0.src-abi_x86_32.x86/bin/clang -no-canonical-prefixes

[PATCH] D45233: [Driver] Update GCC libraries detection logic for Gentoo.

manojgupta added a comment. I can't reproduce this using the trunk llvm. Does it pass for you if %clang is replaced by %clang++ in the test case? Repository: rC Clang https://reviews.llvm.org/D45233 ___ cfe-commits mailing list

[PATCH] D44616: Update existed CodeGen TBAA tests

kosarev added a comment. Looks fine to me. Repository: rC Clang https://reviews.llvm.org/D44616 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D45096: Allow the creation of human-friendly ASTDumper to arbitrary output stream

alexfh added a comment. Another couple of nits. Comment at: docs/HowToSetupToolingForLLVM.rst:136 if (this->ASTDump.operator _Bool()) - return clang::CreateASTDumper(this->ASTDumpFilter); + return clang::CreateASTDumper(nullptr, this->ASTDumpFilter);

[PATCH] D45363: [OpenCL] Added -std/-cl-std=CL2.2/CLC++

Anastasia created this revision. Anastasia added reviewers: rjmccall, bader, yaxunl. Added std option for OpenCL C++, see cfe-dev thread for more details: http://lists.llvm.org/pipermail/cfe-dev/2018-April/057535.html Examples: `clang -std=CL2.2 test.cl` `clang -std=cl2.2 test.cl` `clang

[PATCH] D45004: [clang-format] New style option IndentWrappedObjCMethodNames

djasper added a comment. Ok, you know the ObjC community much better than I do. If you think that adding the indentation for ObjC irrespective of the option works for most people, I am happy to go with it. Repository: rC Clang https://reviews.llvm.org/D45004

Re: r329300 - Disable -fmerge-all-constants as default.

This should probably get a release notes entry. Can you write one? On Thu, Apr 5, 2018 at 11:29 AM, Manoj Gupta via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: manojgupta > Date: Thu Apr 5 08:29:52 2018 > New Revision: 329300 > > URL:

[PATCH] D45233: [Driver] Update GCC libraries detection logic for Gentoo.

manojgupta added a comment. Michał, can you give the latest change a try? Hopefully it should not break any tests. Repository: rC Clang https://reviews.llvm.org/D45233 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D44609: [Clang-Format] New option BreakBeforeLambdaBody to manage lambda line break inside function parameter call

djasper added a comment. Please read: https://clang.llvm.org/docs/ClangFormatStyleOptions.html#adding-additional-style-options In this case in particular, I would be very interested in a style guide that defines how Allman brace style and lambdas work together. IMO, it has so many corner

[PATCH] D45357: [XRay][llvm+clang] Consolidate attribute list files

dberris created this revision. dberris added reviewers: echristo, vlad.tsyrklevich, eugenis. This change consolidates the always/never lists that may be provided to clang to externally control which functions should be XRay instrumented by imbuing attributes. The files follow the same format as

[PATCH] D45233: [Driver] Update GCC libraries detection logic for Gentoo.

manojgupta updated this revision to Diff 141295. manojgupta edited the summary of this revision. manojgupta added a comment. Can solve crossdev issue by passing -gcc-toolchain=/usr so just detect gcc libs as an offset to sysroot for now. Repository: rC Clang https://reviews.llvm.org/D45233

[PATCH] D45014: [Index] Return SourceLocation to consumers, not FileID/Offset pair.

sammccall added a comment. Ping... @akyrtzi @arphaman I'm confident there's no functional change in this patch so I'm happy to land it with just a review from clangd folks, but would be great to know if you're happy with the interface change. Repository: rC Clang

[PATCH] D45373: [clang-format] Don't remove empty lines before namespace endings

krasimir created this revision. krasimir added a reviewer: djasper. Herald added subscribers: cfe-commits, klimek. This implements an alternative to r327861, namely preserving empty lines before namespace endings. Repository: rC Clang https://reviews.llvm.org/D45373 Files:

  1   2   >