[PATCH] D44878: libFuzzer OpenBSD support

devnexen updated this revision to Diff 141534. https://reviews.llvm.org/D44878 Files: lib/Driver/ToolChains/OpenBSD.cpp Index: lib/Driver/ToolChains/OpenBSD.cpp === --- lib/Driver/ToolChains/OpenBSD.cpp +++

[PATCH] D45414: [clang-tidy] add missing assignment operations in hicpp-signed-bitwise

JonasToth created this revision. JonasToth added reviewers: aaron.ballman, hokein, alexfh. Herald added subscribers: cfe-commits, xazax.hun, klimek. This patch resolves the bug https://bugs.llvm.org/show_bug.cgi?id=36963. - implement missing assignment operators for `hicpp-signed-bitwise` - add

[PATCH] D45414: [clang-tidy] add missing assignment operations in hicpp-signed-bitwise

JonasToth updated this revision to Diff 141547. JonasToth added a comment. - fix std bitmask type shifting issue Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D45414 Files: clang-tidy/hicpp/SignedBitwiseCheck.cpp docs/ReleaseNotes.rst

[PATCH] D38845: [ASTImporter] Support importing UnresolvedMemberExpr, DependentNameType, DependentScopeDeclRefExpr

a.sidorin added a comment. Herald added a subscriber: martong. Hi Peter, The changes needed for rebase are too large - they contain both fixes for compilation failures and fixes for test errors. Could you please upgrade the patch? https://reviews.llvm.org/D38845

[PATCH] D45406: Document -std= values for different languages

dim added a comment. In https://reviews.llvm.org/D45406#1060914, @mgorny wrote: > Well, my idea was to list the standards one per line (like on GCC manpage), > and then the '(deprecated)' comments would probably stand out enough to apply > to a single line. Also, FWICS the gcc manpage simply

[PATCH] D45406: Document -std= values for different languages

dim updated this revision to Diff 141529. dim added a comment. Attempt to put the standard values in to definition lists. In the HTML output, this looks fairly nice, but as a man page, it seems a bit strange, for example: -std= Specify the language standard to compile for.

[PATCH] D45241: [analyzer] Invalidate union regions properly. Don't hesitate to load the default binding later.

a.sidorin accepted this revision. a.sidorin added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rC Clang https://reviews.llvm.org/D45241 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D44079: [ASTImporter] Allow testing of import sequences; fix import of typedefs for anonymous decls

a.sidorin updated this revision to Diff 141537. a.sidorin added a comment. Rebase to the latest master; add a suggestion from Adam Balogh (thanks!). Repository: rC Clang https://reviews.llvm.org/D44079 Files: include/clang/AST/ASTImporter.h lib/AST/ASTImporter.cpp

[PATCH] D45392: [clang-tidy] add new check to find out objc ivars which do not have prefix '_'

Eugene.Zelenko added a comment. In https://reviews.llvm.org/D45392#1060912, @Wizard wrote: > In https://reviews.llvm.org/D45392#1060854, @Eugene.Zelenko wrote: > > > In https://reviews.llvm.org/D45392#1060845, @Wizard wrote: > > > > > In https://reviews.llvm.org/D45392#1060485, @Eugene.Zelenko

[PATCH] D45407: [StaticAnalyzer] Added notes to the plist output

Szelethus added a comment. Thanks! Repository: rC Clang https://reviews.llvm.org/D45407 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D45406: Document -std= values for different languages

mgorny added a comment. I think you'd want a definition list instead then. But I haven't tested if they can be nested inside option lists. Repository: rC Clang https://reviews.llvm.org/D45406

[PATCH] D45392: [clang-tidy] add new check to find out objc ivars which do not have prefix '_'

Eugene.Zelenko added a comment. In https://reviews.llvm.org/D45392#1061064, @Wizard wrote: > In https://reviews.llvm.org/D45392#1060971, @Eugene.Zelenko wrote: > > > In https://reviews.llvm.org/D45392#1060912, @Wizard wrote: > > > > > In https://reviews.llvm.org/D45392#1060854, @Eugene.Zelenko

[PATCH] D45305: ObjCGNU: Fix empty v3 protocols being emitted two fields short

theraven added a comment. I think that we emit empty method lists so that the GCC runtime doesn't choke on them, though there's no reason why we couldn't with the GNUstep ABI. It would therefore be nice if the test failed if we did change to emitting null so that we could update the test at

[PATCH] D44411: [libcxx] [test] Fix Container::insert(value_type const&) tests

jloser added a comment. In https://reviews.llvm.org/D44411#1056374, @EricWF wrote: > Have you verified that we're not losing test coverage here? That is, are you > sure we still have tests for the rvalue overloads in other test files? Yep. These containers already have tests for inserts with

[PATCH] D44773: [CMake] Use custom command and target to install libc++ headers

EricWF added a comment. There are a couple of new headers, `` and `` that should be added to the list before committing. Repository: rCXX libc++ https://reviews.llvm.org/D44773 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D43779: [Tooling] [0/1] Refactor FrontendActionFactory::create() to return std::unique_ptr<>

lebedev.ri added a comment. Hmm. Got back to this issue. Not reproducible with gcc-4.8.5 and gcc-4.9.3 in ubuntu 16.04 chroot. *Reproducible* with gcc-4.8.4 and gcc-4.9.2 in debian oldstable (Jessie) chroot. So one might assume that it was fixed. I did try to creduce the crasher, but not not

[PATCH] D45405: [clang-tidy] [modernize-use-auto] Add a threshold for minimal type name length to be replaced with 'auto'

zinovy.nis updated this revision to Diff 141561. zinovy.nis added a comment. - Updated ReleaseNotes. https://reviews.llvm.org/D45405 Files: clang-tidy/modernize/UseAutoCheck.cpp clang-tidy/modernize/UseAutoCheck.h docs/ReleaseNotes.rst docs/clang-tidy/checks/modernize-use-auto.rst

[PATCH] D45392: [clang-tidy] add new check to find out objc ivars which do not have prefix '_'

Wizard added a comment. In https://reviews.llvm.org/D45392#1060971, @Eugene.Zelenko wrote: > In https://reviews.llvm.org/D45392#1060912, @Wizard wrote: > > > In https://reviews.llvm.org/D45392#1060854, @Eugene.Zelenko wrote: > > > > > In https://reviews.llvm.org/D45392#1060845, @Wizard wrote: >

[PATCH] D45416: [analyzer] ExprEngine: model GCC inline asm rvalue cast outputs

a.sidorin created this revision. a.sidorin added reviewers: NoQ, dcoughlin, xazax.hun. Herald added subscribers: cfe-commits, rnkovacs, szepet. Herald added a reviewer: george.karpenkov. Despite the fact that cast expressions return rvalues, GCC still handles such outputs as lvalues when

[PATCH] D43764: [clang-apply-replacements] Convert tooling::Replacements to tooling::AtomicChange for conflict resolving of changes, code cleanup, and code formatting.

jdemeule added a comment. Thank you for applying the patch. I suspect some undefined order when applying replacements as directly dependant in which order OS reads `file1.yaml`, `file2.yaml`and `file3.yaml`. As I am not able to reproduce it on my machine, can you share with me the content of

[PATCH] D45417: [analyzer] Don't crash on printing ConcreteInt of size >64 bits

a.sidorin created this revision. a.sidorin added reviewers: NoQ, dcoughlin, xazax.hun. Herald added subscribers: cfe-commits, rnkovacs, szepet. Herald added a reviewer: george.karpenkov. Printing of ConcreteInts with size >64 bits resulted in assertion failure in get[Z|S]ExtValue()

r329515 - [libclang] Add clang_File_tryGetRealPathName

Author: maskray Date: Sat Apr 7 13:50:35 2018 New Revision: 329515 URL: http://llvm.org/viewvc/llvm-project?rev=329515=rev Log: [libclang] Add clang_File_tryGetRealPathName Summary: clang_getFileName() may return a path relative to WorkingDir. On Arch Linux, during clang_indexTranslationUnit(),

[PATCH] D44411: [libcxx] [test] Fix Container::insert(value_type const&) tests

jloser updated this revision to Diff 141573. jloser added a comment. Use `v3` rather than an rvalue of `3` in `libcxx/test/std/containers/associative/multiset/insert_cv.pass.cpp` https://reviews.llvm.org/D44411 Files: libcxx/test/std/containers/associative/multiset/insert_cv.pass.cpp

[libcxx] r329541 - [test] Fix Container::insert(value_type const&) tests

Author: ericwf Date: Sun Apr 8 14:57:35 2018 New Revision: 329541 URL: http://llvm.org/viewvc/llvm-project?rev=329541=rev Log: [test] Fix Container::insert(value_type const&) tests Patch from Joe Loser. Several unit tests meaning to test the behavior of lvalue insertion incorrectly pass

[PATCH] D44411: [libcxx] [test] Fix Container::insert(value_type const&) tests

EricWF closed this revision. EricWF added a comment. Committed as r329541. https://reviews.llvm.org/D44411 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D44411: [libcxx] [test] Fix Container::insert(value_type const&) tests

EricWF accepted this revision. EricWF added a comment. This revision is now accepted and ready to land. LGTM. Thanks! https://reviews.llvm.org/D44411 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D45421: [X86] Emit native IR for pmuldq/pmuludq builtins.

craig.topper created this revision. craig.topper added reviewers: RKSimon, spatel. Herald added a subscriber: cfe-commits. I believe all the pieces are now in place in the backend to make this correctly. We can truncate the vXi64 type to vXi32, extend it back up to the original width and

[PATCH] D45357: [XRay][llvm+clang] Consolidate attribute list files

dberris updated this revision to Diff 141578. dberris added a comment. - fixup: fix typo https://reviews.llvm.org/D45357 Files: clang/include/clang/Basic/LangOptions.h clang/include/clang/Basic/XRayLists.h clang/include/clang/Driver/Options.td clang/include/clang/Driver/XRayArgs.h

[PATCH] D45422: [Driver] Allow drivers to add multiple libc++ include paths

phosek created this revision. phosek added reviewers: rsmith, dlj, rnk. Herald added subscribers: cfe-commits, sdardis, dschuff. Herald added a reviewer: EricWF. This allows toolchain drivers to add multiple libc++ include paths akin to libstdc++. This is useful in multiarch setup when some

[PATCH] D45357: [XRay][llvm+clang] Consolidate attribute list files

This revision was automatically updated to reflect the committed changes. Closed by commit rL329543: [XRay][llvm+clang] Consolidate attribute list files (authored by dberris, committed by ). Changed prior to commit: https://reviews.llvm.org/D45357?vs=141578=141581#toc Repository: rL LLVM

r329543 - [XRay][llvm+clang] Consolidate attribute list files

Author: dberris Date: Sun Apr 8 21:02:09 2018 New Revision: 329543 URL: http://llvm.org/viewvc/llvm-project?rev=329543=rev Log: [XRay][llvm+clang] Consolidate attribute list files Summary: This change consolidates the always/never lists that may be provided to clang to externally control which

[PATCH] D44773: [CMake] Use custom command and target to install libc++ headers

phosek updated this revision to Diff 141580. Repository: rCXX libc++ https://reviews.llvm.org/D44773 Files: libcxx/NOTES.TXT libcxx/cmake/Modules/HandleLibCXXABI.cmake libcxx/include/CMakeLists.txt libcxx/lib/CMakeLists.txt Index: libcxx/lib/CMakeLists.txt

[libcxx] r329544 - [CMake] Use custom command and target to install libc++ headers

Author: phosek Date: Sun Apr 8 21:23:04 2018 New Revision: 329544 URL: http://llvm.org/viewvc/llvm-project?rev=329544=rev Log: [CMake] Use custom command and target to install libc++ headers Using file(COPY FILE...) has several downsides. Since the file command is only executed at configuration

[PATCH] D44773: [CMake] Use custom command and target to install libc++ headers

This revision was automatically updated to reflect the committed changes. Closed by commit rL329544: [CMake] Use custom command and target to install libc++ headers (authored by phosek, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D44773: [CMake] Use custom command and target to install libc++ headers

This revision was automatically updated to reflect the committed changes. Closed by commit rCXX329544: [CMake] Use custom command and target to install libc++ headers (authored by phosek, committed by ). Changed prior to commit: https://reviews.llvm.org/D44773?vs=141580=141583#toc Repository:

[PATCH] D45237: [RISCV] Fix logic to check if frame pointer should be used

mgrang updated this revision to Diff 141584. mgrang retitled this revision from "[RISCV] Fix logic check if frame pointer should be used" to "[RISCV] Fix logic to check if frame pointer should be used". mgrang added a comment. Added unit tests. https://reviews.llvm.org/D45237 Files:

[libcxx] r329545 - Revert "[CMake] Use custom command and target to install libc++ headers"

Author: phosek Date: Sun Apr 8 21:36:04 2018 New Revision: 329545 URL: http://llvm.org/viewvc/llvm-project?rev=329545=rev Log: Revert "[CMake] Use custom command and target to install libc++ headers" This reverts commit r329544 which is failing on libcxx standalone bots. Modified:

r329520 - Revert "[Sema] Fix PR35832 - Ambiguity accessing anonymous struct/union with multiple bases."

Author: ericwf Date: Sat Apr 7 23:05:33 2018 New Revision: 329520 URL: http://llvm.org/viewvc/llvm-project?rev=329520=rev Log: Revert "[Sema] Fix PR35832 - Ambiguity accessing anonymous struct/union with multiple bases." This reverts commit r329519. There are some unaddressed test failures.

r329521 - [Sema] Fix PR35832 - Ambiguity accessing anonymous struct/union with multiple bases.

Author: ericwf Date: Sat Apr 7 23:21:33 2018 New Revision: 329521 URL: http://llvm.org/viewvc/llvm-project?rev=329521=rev Log: [Sema] Fix PR35832 - Ambiguity accessing anonymous struct/union with multiple bases. Summary: Currently clang doesn't do qualified lookup when building indirect field

[PATCH] D45411: [Sema] Fix PR35832 - Ambiguity accessing anonymous struct/union with multiple bases.

EricWF updated this revision to Diff 141527. EricWF added a comment. I missed a test failure. Reuploading and recommiting latest diff to keep the history. https://reviews.llvm.org/D45411 Files: lib/Sema/SemaExprMember.cpp lib/Sema/TreeTransform.h test/SemaCXX/PR35832.cpp Index:

[PATCH] D45392: [clang-tidy] add new check to find out objc ivars which do not have prefix '_'

Wizard added a comment. In https://reviews.llvm.org/D45392#1060854, @Eugene.Zelenko wrote: > In https://reviews.llvm.org/D45392#1060845, @Wizard wrote: > > > In https://reviews.llvm.org/D45392#1060485, @Eugene.Zelenko wrote: > > > > > If this is Apple guideline, check name should reflect this. I

[PATCH] D45406: Document -std= values for different languages

mgorny added a comment. Well, my idea was to list the standards one per line (like on GCC manpage), and then the '(deprecated)' comments would probably stand out enough to apply to a single line. Also, FWICS the gcc manpage simply lists which aliases are deprecated in the description text. But

[PATCH] D45392: [clang-tidy] add new check to find out objc ivars which do not have prefix '_'

Wizard updated this revision to Diff 141574. Wizard added a comment. reorder release note for alphabetical order Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D45392 Files: clang-tidy/objc/CMakeLists.txt clang-tidy/objc/IvarDeclarationCheck.cpp