[PATCH] D45478: [clangd] Merge symbols in global-sym-builder on the go

2018-04-10 Thread Ilya Biryukov via Phabricator via cfe-commits
ilya-biryukov created this revision. ilya-biryukov added reviewers: hokein, sammccall, klimek. Herald added subscribers: MaskRay, ioeric, jkorous-apple. This avoids storing intermediate symbols in memory, most of which are duplicates. The resulting .yaml file is ~120MB, while intermediate symbols

[PATCH] D44878: libFuzzer OpenBSD support

2018-04-10 Thread Dean Michael Berris via Phabricator via cfe-commits
dberris added a comment. In the interest of better documentation, can you please update the description of this change to reflect what we're trying to achieve here? Something more descriptive than "libFuzzer OpenBSD Support" that substantiates the change, along with related changes to other

[PATCH] D45479: [Tooling] Optmized memory usage in InMemoryToolResults.

2018-04-10 Thread Haojian Wu via Phabricator via cfe-commits
hokein created this revision. Herald added subscribers: cfe-commits, klimek. Repository: rC Clang https://reviews.llvm.org/D45479 Files: include/clang/Tooling/Execution.h lib/Tooling/Execution.cpp Index: lib/Tooling/Execution.cpp

[PATCH] D43764: [clang-apply-replacements] Convert tooling::Replacements to tooling::AtomicChange for conflict resolving of changes, code cleanup, and code formatting.

2018-04-10 Thread Malcolm Parsons via Phabricator via cfe-commits
malcolm.parsons added a comment. In https://reviews.llvm.org/D43764#1062748, @jdemeule wrote: > Ok, I understand the problem. > Previously, during the deduplication step, replacements per file where > sorted and it is not the case anymore. > That means now, clang-apply-replacement is highly

[PATCH] D45416: [analyzer] ExprEngine: model GCC inline asm rvalue cast outputs

2018-04-10 Thread Aleksei Sidorin via Phabricator via cfe-commits
a.sidorin added a comment. > The ultimate solution would probably be to add a fake cloned asm statement to > the CFG (instead of the real asm statement) that would point to the correct > output child-expression(s) that are untouched themselves but simply have > their noop casts removed. I

r329684 - -ftime-report switch support in Clang.

2018-04-10 Thread Andrew V. Tischenko via cfe-commits
Author: avt77 Date: Tue Apr 10 03:34:13 2018 New Revision: 329684 URL: http://llvm.org/viewvc/llvm-project?rev=329684=rev Log: -ftime-report switch support in Clang. The current support of the feature produces only 2 lines in report: -Some general Code Generation Time; -Total time of Backend

[PATCH] D45483: [NEON] Support vfma_n and vfms_n intrinsics

2018-04-10 Thread Ivan Kosarev via Phabricator via cfe-commits
kosarev created this revision. kosarev added reviewers: az, sbaranga, t.p.northover. kosarev added a project: clang. Herald added subscribers: javed.absar, rengolin. https://reviews.llvm.org/D45483 Files: include/clang/Basic/arm_neon.td test/CodeGen/aarch64-neon-2velem.c Index:

[PATCH] D45482: [clangd] Match AST and Index label for template Symbols

2018-04-10 Thread Ilya Biryukov via Phabricator via cfe-commits
ilya-biryukov created this revision. ilya-biryukov added reviewers: sammccall, hokein. Herald added subscribers: MaskRay, ioeric, jkorous-apple, klimek. Previsouly, class completions items from the index were missing template parameters in both the snippet and the label. Repository: rCTE

[PATCH] D43815: CodeGen tests - typo fixes

2018-04-10 Thread Gabor Buella via Phabricator via cfe-commits
GBuella closed this revision. GBuella added a comment. Commited r329688 https://reviews.llvm.org/rL329689 Repository: rC Clang https://reviews.llvm.org/D43815 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D45442: Parse .h files as objective-c++ if we don't have a compile command.

2018-04-10 Thread Ilya Biryukov via Phabricator via cfe-commits
ilya-biryukov added a comment. ObjC++ definitely seems like a nicer default. Unfortunately, we'll start getting ObjC++ completion results, which may be confusing. But that seems like a smaller evil. Is there an easy way to add a regression test that checks we don't get any errors for headers

[PATCH] D45478: [clangd] Merge symbols in global-sym-builder on the go

2018-04-10 Thread Haojian Wu via Phabricator via cfe-commits
hokein added a comment. Thanks for digging it out! In upstream, we use `InMemoryToolResults` which saves all duplicated "std::string"s into the memory, I think we could optimize `InMemoryToolResults` by using Arena to keep the memory low, I will try it to see whether it can reduce the memory.

r329693 - The test was fixed.

2018-04-10 Thread Andrew V. Tischenko via cfe-commits
Author: avt77 Date: Tue Apr 10 05:17:01 2018 New Revision: 329693 URL: http://llvm.org/viewvc/llvm-project?rev=329693=rev Log: The test was fixed. Modified: cfe/trunk/test/Frontend/ftime-report-template-decl.cpp Modified: cfe/trunk/test/Frontend/ftime-report-template-decl.cpp URL:

Re: r329580 - [Tooling] A CompilationDatabase wrapper that infers header commands.

2018-04-10 Thread Sam McCall via cfe-commits
Apologies, missed this. r329685 should fix. On Tue, Apr 10, 2018 at 12:53 AM Galina Kistanova wrote: > Hello Sam, > > It looks like this commit added broken tests to one of our builders: > >

r329685 - [Tooling] fix UB when interpolating compile commands with an empty index

2018-04-10 Thread Sam McCall via cfe-commits
Author: sammccall Date: Tue Apr 10 03:36:46 2018 New Revision: 329685 URL: http://llvm.org/viewvc/llvm-project?rev=329685=rev Log: [Tooling] fix UB when interpolating compile commands with an empty index Modified: cfe/trunk/lib/Tooling/InterpolatingCompilationDatabase.cpp Modified:

[PATCH] D45479: [Tooling] Optmized memory usage in InMemoryToolResults.

2018-04-10 Thread Haojian Wu via Phabricator via cfe-commits
hokein updated this revision to Diff 141822. hokein added a comment. Update. Repository: rC Clang https://reviews.llvm.org/D45479 Files: include/clang/Tooling/Execution.h lib/Tooling/AllTUsExecution.cpp lib/Tooling/Execution.cpp Index: lib/Tooling/Execution.cpp

[PATCH] D43815: CodeGen tests - typo fixes

2018-04-10 Thread Gabor Buella via Phabricator via cfe-commits
GBuella added a comment. See: https://reviews.llvm.org/rL329689 Repository: rC Clang https://reviews.llvm.org/D43815 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] r329695 - s/LLVM_ON_WIN32/_WIN32/, clang-tools-extra

2018-04-10 Thread Nico Weber via cfe-commits
Author: nico Date: Tue Apr 10 06:14:03 2018 New Revision: 329695 URL: http://llvm.org/viewvc/llvm-project?rev=329695=rev Log: s/LLVM_ON_WIN32/_WIN32/, clang-tools-extra LLVM_ON_WIN32 is set exactly with MSVC and MinGW (but not Cygwin) in HandleLLVMOptions.cmake, which is where _WIN32 defined

r329689 - CodeGen tests - typo fixes NFC

2018-04-10 Thread Gabor Buella via cfe-commits
Author: gbuella Date: Tue Apr 10 04:20:05 2018 New Revision: 329689 URL: http://llvm.org/viewvc/llvm-project?rev=329689=rev Log: CodeGen tests - typo fixes NFC Modified: cfe/trunk/test/CodeGen/avx512-reduceMinMaxIntrin.c cfe/trunk/test/CodeGen/avx512f-builtins.c Modified:

[PATCH] D44764: [clangd] Use operator<< to prevent printers issues in Gtest

2018-04-10 Thread Sam McCall via Phabricator via cfe-commits
sammccall accepted this revision. sammccall added a comment. Sorry I lost track of this. LGTM! Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D44764 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D43667: [clang-doc] Implement a YAML generator

2018-04-10 Thread Julie Hockett via Phabricator via cfe-commits
juliehockett added a comment. In https://reviews.llvm.org/D43667#1062746, @Athosvk wrote: > I'm a bit late on this, but I'd say that YAML is usually not a 'final' > format. What would be the use-cases for this? And if is meant as an > alternative intermediate format, why not instead of having

[PATCH] D28462: clang-format: Add new style option AlignConsecutiveMacros

2018-04-10 Thread Marcos Horro via Phabricator via cfe-commits
markoshorro added a comment. This feature should have been merged time ago, any news? Repository: rL LLVM https://reviews.llvm.org/D28462 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D44765: PR36643 Make clang-format support more generic TMarcos

2018-04-10 Thread Teodor Petrov via Phabricator via cfe-commits
obfuscated marked an inline comment as done. obfuscated added a comment. Ping? https://reviews.llvm.org/D44765 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D45488: [X86] Disable SGX for Skylake Server - CPP test

2018-04-10 Thread Gabor Buella via Phabricator via cfe-commits
GBuella created this revision. GBuella added reviewers: craig.topper, davezarzycki. Herald added a subscriber: cfe-commits. Fix test case - corresponding to r329701 Repository: rC Clang https://reviews.llvm.org/D45488 Files: test/Preprocessor/predefined-arch-macros.c Index:

[PATCH] D43578: -ftime-report switch support in Clang

2018-04-10 Thread Richard Smith - zygoloid via Phabricator via cfe-commits
rsmith added a comment. In https://reviews.llvm.org/D43578#1062984, @thakis wrote: > Also, please add cfe-commits to clang changes. Since this wasn't here and the > patch wasn't seen by clang folks, since > ftime-report-template-decl.cppwarnings is still failing on the bots (e.g. >

[PATCH] D45483: [NEON] Support vfma_n and vfms_n intrinsics

2018-04-10 Thread Tim Northover via Phabricator via cfe-commits
t.p.northover accepted this revision. t.p.northover added a comment. This revision is now accepted and ready to land. Looks fine to me. https://reviews.llvm.org/D45483 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D45479: [Tooling] Optimize memory usage in InMemoryToolResults.

2018-04-10 Thread Haojian Wu via Phabricator via cfe-commits
hokein updated this revision to Diff 141842. hokein edited the summary of this revision. hokein added a comment. Add a comment. Repository: rC Clang https://reviews.llvm.org/D45479 Files: include/clang/Tooling/Execution.h lib/Tooling/AllTUsExecution.cpp lib/Tooling/Execution.cpp

[PATCH] D43667: [clang-doc] Implement a YAML generator

2018-04-10 Thread Athos via Phabricator via cfe-commits
Athosvk added a comment. In https://reviews.llvm.org/D43667#1063049, @juliehockett wrote: > In https://reviews.llvm.org/D43667#1062746, @Athosvk wrote: > > > I'm a bit late on this, but I'd say that YAML is usually not a 'final' > > format. What would be the use-cases for this? And if is meant

[PATCH] D44093: [BUILTINS] structure pretty printer

2018-04-10 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM with some minor commenting nits. Comment at: lib/CodeGen/CGBuiltin.cpp:992 + +// We check whether we are in a recursive type +if

[PATCH] D45488: [X86] Disable SGX for Skylake Server - CPP test

2018-04-10 Thread Gabor Buella via Phabricator via cfe-commits
GBuella updated this revision to Diff 141853. https://reviews.llvm.org/D45488 Files: test/Preprocessor/predefined-arch-macros.c Index: test/Preprocessor/predefined-arch-macros.c === --- test/Preprocessor/predefined-arch-macros.c

[PATCH] D45489: [HIP] Add input type for HIP

2018-04-10 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl created this revision. yaxunl added reviewers: tra, Hahnfeld. This patch is split from https://reviews.llvm.org/D45212 https://reviews.llvm.org/D45489 Files: include/clang/Driver/Types.def lib/Driver/Driver.cpp lib/Driver/Types.cpp Index: lib/Driver/Types.cpp

[PATCH] D44093: [BUILTINS] structure pretty printer

2018-04-10 Thread Alexander Richardson via Phabricator via cfe-commits
arichardson added a comment. I'm also often restricted to using printf for debugging so this looks really useful! However, before committing this I feel like the test should also verify that the format strings that are generated are sensible. Also what should happens when you have enum

Re: [clang-tools-extra] r329452 - [clang-tidy] Fix compilation for ParentVirtualCallCheck.cpp

2018-04-10 Thread Alexander Kornienko via cfe-commits
On Mon, Apr 9, 2018 at 8:09 PM Zinovy Nis wrote: > I had compilation errors here on MVSV@PSP and for ARM: > > > > FAILED: /usr/bin/c++ -DGTEST_HAS_RTTI=0 -D_DEBUG -D_GNU_SOURCE > -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS

[PATCH] D45485: [CMake] Unbreak BUILD_SHARED_LIBS workflow

2018-04-10 Thread Nico Weber via Phabricator via cfe-commits
thakis added a comment. Can you link to the recent timer changes? Repository: rC Clang https://reviews.llvm.org/D45485 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D45485: [CMake] Unbreak BUILD_SHARED_LIBS workflow

2018-04-10 Thread Nico Weber via Phabricator via cfe-commits
thakis added a comment. Thanks for the pointer! I commented on https://reviews.llvm.org/D43578; I'm hoping there's a fix that doesn't require making so many libs depend on clang's IR library. Repository: rC Clang https://reviews.llvm.org/D45485

[PATCH] D45479: [Tooling] Optimize memory usage in InMemoryToolResults.

2018-04-10 Thread Sam McCall via Phabricator via cfe-commits
sammccall added inline comments. Comment at: include/clang/Tooling/Execution.h:55 class InMemoryToolResults : public ToolResults { public: please add a high-level comment explaining what this is caching and when we expect it to work well. Repository:

[PATCH] D43578: -ftime-report switch support in Clang

2018-04-10 Thread Nico Weber via Phabricator via cfe-commits
thakis added a comment. Also, please add cfe-commits to clang changes. Since this wasn't here and the patch wasn't seen by clang folks, since ftime-report-template-decl.cppwarnings is still failing on the bots (e.g.

[PATCH] D44883: [Sema] Extend -Wself-assign and -Wself-assign-field to warn on overloaded self-assignment (classes)

2018-04-10 Thread Roman Lebedev via Phabricator via cfe-commits
lebedev.ri added a comment. In https://reviews.llvm.org/D44883#1063003, @thakis wrote: > This landing made our clang trunk bots do an evaluation of this warning :-P > It fired 8 times, all false positives, and all from unit tests testing that > operator= works for self-assignment. >

[PATCH] D45058: [X86] Disable SGX for Skylake Server

2018-04-10 Thread David Zarzycki via Phabricator via cfe-commits
davezarzycki added a comment. I think this change is incomplete. The following clang test fails on my SKX machine: `Preprocessor/predefined-arch-macros.c` Line 895: `// CHECK_SKX_M32: #define __SGX__ 1` Repository: rL LLVM https://reviews.llvm.org/D45058

Re: [PATCH] D44883: [Sema] Extend -Wself-assign and -Wself-assign-field to warn on overloaded self-assignment (classes)

2018-04-10 Thread David Blaikie via cfe-commits
On Tue, Apr 10, 2018 at 7:21 AM Roman Lebedev via Phabricator < revi...@reviews.llvm.org> wrote: > lebedev.ri added a comment. > > In https://reviews.llvm.org/D44883#1063003, @thakis wrote: > > > This landing made our clang trunk bots do an evaluation of this warning > :-P It fired 8 times, all

r329701 - [X86] Disable SGX for Skylake Server

2018-04-10 Thread Gabor Buella via cfe-commits
Author: gbuella Date: Tue Apr 10 07:04:21 2018 New Revision: 329701 URL: http://llvm.org/viewvc/llvm-project?rev=329701=rev Log: [X86] Disable SGX for Skylake Server Reviewers: craig.topper, zvi, echristo Reviewed By: craig.topper Differential Revision: https://reviews.llvm.org/D45058

r329710 - [X86] Disable SGX for Skylake Server - CPP test

2018-04-10 Thread Gabor Buella via cfe-commits
Author: gbuella Date: Tue Apr 10 08:03:03 2018 New Revision: 329710 URL: http://llvm.org/viewvc/llvm-project?rev=329710=rev Log: [X86] Disable SGX for Skylake Server - CPP test Summary: Fix test case - corresponding to r329701 Reviewers: craig.topper, davezarzycki Reviewed By: davezarzycki

[PATCH] D45485: [CMake] Unbreak BUILD_SHARED_LIBS workflow

2018-04-10 Thread David Zarzycki via Phabricator via cfe-commits
davezarzycki added a comment. I haven't proven that r329684 is the source of the regression, but it is the only timer related change in the last 24 hours as far as I can tell. Repository: rC Clang https://reviews.llvm.org/D45485 ___ cfe-commits

[PATCH] D45050: [clang-tidy] New checker for not null-terminated result caused by strlen or wcslen

2018-04-10 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added inline comments. Comment at: clang-tidy/bugprone/NotNullTerminatedResultCheck.cpp:21 + +static std::string exprToStr(const Expr *Expr, + const MatchFinder::MatchResult ) { Do not name the parameter with the same

[PATCH] D45485: [CMake] Unbreak BUILD_SHARED_LIBS workflow

2018-04-10 Thread David Zarzycki via Phabricator via cfe-commits
davezarzycki added a comment. Great! I'll revisit this patch in a week and see if it is still needed. Hopefully the author of https://reviews.llvm.org/D43578 will make this patch unnecessary by then. Repository: rC Clang https://reviews.llvm.org/D45485

[PATCH] D38455: [clang-tidy] new cppcoreguidelines-narrowing-conversions check.

2018-04-10 Thread Alexander Kornienko via Phabricator via cfe-commits
alexfh added a comment. In https://reviews.llvm.org/D38455#1062722, @courbet wrote: > In https://reviews.llvm.org/D38455#1062718, @JonasToth wrote: > > > > Sure. Is it OK to add a dependency from > > > clang-tidy/bugprone/BugproneTidyModule.cpp to stuff in > > > clang-tidy/cpp-coreguidelines ?

[PATCH] D45058: [X86] Disable SGX for Skylake Server

2018-04-10 Thread Gabor Buella via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC329701: [X86] Disable SGX for Skylake Server (authored by GBuella, committed by ). Changed prior to commit: https://reviews.llvm.org/D45058?vs=140302=141839#toc Repository: rL LLVM

[PATCH] D45058: [X86] Disable SGX for Skylake Server

2018-04-10 Thread Gabor Buella via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL329701: [X86] Disable SGX for Skylake Server (authored by GBuella, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D45058 Files:

r329702 - Attempt to fix Windows build after r329698.

2018-04-10 Thread Nico Weber via cfe-commits
Author: nico Date: Tue Apr 10 07:08:25 2018 New Revision: 329702 URL: http://llvm.org/viewvc/llvm-project?rev=329702=rev Log: Attempt to fix Windows build after r329698. Modified: cfe/trunk/lib/Basic/FileManager.cpp Modified: cfe/trunk/lib/Basic/FileManager.cpp URL:

[PATCH] D45488: [X86] Disable SGX for Skylake Server - CPP test

2018-04-10 Thread David Zarzycki via Phabricator via cfe-commits
davezarzycki added a comment. I don't think this change is correct. To the best of my knowledge, SKL does support SGX but SKX does not. Repository: rC Clang https://reviews.llvm.org/D45488 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D45447: [clang-tidy] Adding alias for anon namespaces in header (fuchsia module)

2018-04-10 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from a minor docs nit. Comment at: docs/clang-tidy/checks/fuchsia-header-anon-namespaces.rst:6 +fuchsia-header-anon-namespaces

[PATCH] D45488: [X86] Disable SGX for Skylake Server - CPP test

2018-04-10 Thread Gabor Buella via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL329710: [X86] Disable SGX for Skylake Server - CPP test (authored by GBuella, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D45414: [clang-tidy] add missing assignment operations in hicpp-signed-bitwise

2018-04-10 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LG aside from a diagnostic wording nit. Comment at: clang-tidy/hicpp/SignedBitwiseCheck.cpp:92 + if (N.getNodeAs("std_type")) +diag(Location, "shifting a

[PATCH] D45165: Use llvm::sys::fs::real_path() in clang.

2018-04-10 Thread Hans Wennborg via Phabricator via cfe-commits
hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. lgtm https://reviews.llvm.org/D45165 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D45442: Parse .h files as objective-c++ if we don't have a compile command.

2018-04-10 Thread Sam McCall via Phabricator via cfe-commits
sammccall added a comment. Will try to add a test. Comment at: clangd/GlobalCompilationDatabase.cpp:24 + // Parsing as Objective C++ is friendly to more cases. + if (llvm::sys::path::extension(File) == ".h") +Argv.push_back("-xobjective-c++-header");

[PATCH] D44883: [Sema] Extend -Wself-assign and -Wself-assign-field to warn on overloaded self-assignment (classes)

2018-04-10 Thread Nico Weber via Phabricator via cfe-commits
thakis added a comment. This landing made our clang trunk bots do an evaluation of this warning :-P It fired 8 times, all false positives, and all from unit tests testing that operator= works for self-assignment. (https://chromium-review.googlesource.com/c/chromium/src/+/1000856 has the exact

Re: [PATCH] D44883: [Sema] Extend -Wself-assign and -Wself-assign-field to warn on overloaded self-assignment (classes)

2018-04-10 Thread Nico Weber via cfe-commits
"False positive" means "warning fires but didn't find anything interesting", not "warning fires while being technically correct". So all these instances do count as false positives. clang tries super hard to make sure that every time a warning fires, it is useful for a dev to fix it. If you build

[PATCH] D45165: Use llvm::sys::fs::real_path() in clang.

2018-04-10 Thread Nico Weber via Phabricator via cfe-commits
thakis added a comment. r329698, thanks! https://reviews.llvm.org/D45165 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r329698 - Use llvm::sys::fs::real_path() in clang.

2018-04-10 Thread Nico Weber via cfe-commits
Author: nico Date: Tue Apr 10 06:36:38 2018 New Revision: 329698 URL: http://llvm.org/viewvc/llvm-project?rev=329698=rev Log: Use llvm::sys::fs::real_path() in clang. No expected behavior change. https://reviews.llvm.org/D45165 Modified: cfe/trunk/lib/Basic/FileManager.cpp

[PATCH] D45488: [X86] Disable SGX for Skylake Server - CPP test

2018-04-10 Thread Gabor Buella via Phabricator via cfe-commits
GBuella added a comment. In https://reviews.llvm.org/D45488#1063067, @davezarzycki wrote: > I don't think this change is correct. To the best of my knowledge, SKL does > support SGX but SKX does not. llvm-lit test/Preprocessor/predefined-arch-macros.c passes now. I didn't know tests are not

[PATCH] D44765: PR36643 Make clang-format support more generic TMarcos

2018-04-10 Thread Alexander Kornienko via Phabricator via cfe-commits
alexfh added inline comments. Comment at: lib/Format/FormatTokenLexer.cpp:371 FormatToken *Macro = Tokens[Tokens.size() - 4]; - if (Macro->TokenText != "_T") + if (std::find(Style.TMacros.begin(), Style.TMacros.end(), Macro->TokenText) == + Style.TMacros.end())

[PATCH] D45059: [clang-tidy] Add check to catch comparisons in TEMP_FAILURE_RETRY

2018-04-10 Thread Alexander Kornienko via Phabricator via cfe-commits
alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. LG. Thanks! https://reviews.llvm.org/D45059 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r329714 - I removed the failed test.

2018-04-10 Thread Andrew V. Tischenko via cfe-commits
Author: avt77 Date: Tue Apr 10 08:45:43 2018 New Revision: 329714 URL: http://llvm.org/viewvc/llvm-project?rev=329714=rev Log: I removed the failed test. Removed: cfe/trunk/test/Frontend/ftime-report-template-decl.cpp Removed: cfe/trunk/test/Frontend/ftime-report-template-decl.cpp URL:

Re: [PATCH] D44883: [Sema] Extend -Wself-assign and -Wself-assign-field to warn on overloaded self-assignment (classes)

2018-04-10 Thread John McCall via cfe-commits
If you have a concrete suggestion of how to suppress this warning for user-defined operators just in unit tests, great. I don’t think 8 easily-suppressed warnings is an unacceptably large false-positive problem, though. Most warnings have similar problems, and the standard cannot possibly be “must

Re: [PATCH] D44883: [Sema] Extend -Wself-assign and -Wself-assign-field to warn on overloaded self-assignment (classes)

2018-04-10 Thread Roman Lebedev via cfe-commits
Because *so far* it has been running on the existing code, which i guess was already pretty warning free, and was run through the static analyzer, which obviously should catch such issues. Do you always use [clang] static analyzer, each time you build? Great! It is indeed very good to do so. But

[PATCH] D45212: [HIP] Let CUDA toolchain support HIP language mode and amdgpu

2018-04-10 Thread Jonas Hahnfeld via Phabricator via cfe-commits
Hahnfeld added a comment. In https://reviews.llvm.org/D45212#1063186, @yaxunl wrote: > In https://reviews.llvm.org/D45212#1060628, @Hahnfeld wrote: > > > Can this revision be split further? The summary mentions many things that > > might make up multiple independent changes... > > > I separated

[PATCH] D45414: [clang-tidy] add missing assignment operations in hicpp-signed-bitwise

2018-04-10 Thread Jonas Toth via Phabricator via cfe-commits
JonasToth added inline comments. Comment at: clang-tidy/hicpp/SignedBitwiseCheck.cpp:92 + if (N.getNodeAs("std_type")) +diag(Location, "shifting a value of the standardized bitmask types"); + else aaron.ballman wrote: > How about: "shifting a value of

Re: [PATCH] D44883: [Sema] Extend -Wself-assign and -Wself-assign-field to warn on overloaded self-assignment (classes)

2018-04-10 Thread David Blaikie via cfe-commits
Any good ideas on how to evaluate it, then? (in addition to/other than something like Google where we can track the diagnostic for - a few months?) On Tue, Apr 10, 2018 at 9:34 AM John McCall wrote: > Yeah, -Wself-assign in general is about catching a class of live-coding >

[PATCH] D45417: [analyzer] Don't crash on printing ConcreteInt of size >64 bits

2018-04-10 Thread Aleksei Sidorin via Phabricator via cfe-commits
a.sidorin updated this revision to Diff 141869. a.sidorin edited the summary of this revision. a.sidorin added a comment. After thinking a bit more, I have removed the FIXME at all: dumping SVal is an extremely rare event so this shouldn't affect the performance. Repository: rC Clang

[PATCH] D45005: [clang-format] Set IndentWrappedObjCMethodNames to Always in google style

2018-04-10 Thread Ben Hamilton via Phabricator via cfe-commits
benhamilton abandoned this revision. benhamilton added a comment. Abandoned in favor of unconditionally indenting wrapped ObjC selectors in https://reviews.llvm.org/D45004. Repository: rC Clang https://reviews.llvm.org/D45005 ___ cfe-commits

[PATCH] D44093: [BUILTINS] structure pretty printer

2018-04-10 Thread Paul Semel via Phabricator via cfe-commits
paulsemel added a comment. In https://reviews.llvm.org/D44093#1063122, @arichardson wrote: > I'm also often restricted to using printf for debugging so this looks really > useful! > > However, before committing this I feel like the test should also verify that > the format strings that are

[PATCH] D45444: [clang-tidy] WIP: implement new check for const-correctness

2018-04-10 Thread Jonas Toth via Phabricator via cfe-commits
JonasToth added a comment. > It'll be good idea to have option to apply this check for pointer/references > only, or include built-in types/enums. Agreed. I aim at a `mark handles const`(default on), `mark values const`(default on for objects), `mark pointer (const int * >> const <<) const`

[PATCH] D45414: [clang-tidy] add missing assignment operations in hicpp-signed-bitwise

2018-04-10 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added inline comments. Comment at: clang-tidy/hicpp/SignedBitwiseCheck.cpp:92 + if (N.getNodeAs("std_type")) +diag(Location, "shifting a value of the standardized bitmask types"); + else JonasToth wrote: > aaron.ballman wrote: > > JonasToth

[PATCH] D44976: Change DEBUG() macro to LLVM_DEBUG() in clang-tools-extra

2018-04-10 Thread Reid Kleckner via Phabricator via cfe-commits
rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D44976 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D44975: Change DEBUG() macro to LLVM_DEBUG()

2018-04-10 Thread Reid Kleckner via Phabricator via cfe-commits
rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm Repository: rC Clang https://reviews.llvm.org/D44975 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D45234: CMake: Check LLVM_ENABLE_LIBXML2 in clang

2018-04-10 Thread Reid Kleckner via Phabricator via cfe-commits
rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm Repository: rC Clang https://reviews.llvm.org/D45234 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D43578: -ftime-report switch support in Clang

2018-04-10 Thread Andrew V. Tischenko via Phabricator via cfe-commits
avt77 reopened this revision. avt77 added a comment. This revision is now accepted and ready to land. Obviously, this patch was not ready for commit that's why I reopen the revison. But I don't know how to revert the patch from trunk: please, help me. Repository: rL LLVM

[PATCH] D45491: [analyzer] Do not invalidate the `this` pointer.

2018-04-10 Thread George Karpenkov via Phabricator via cfe-commits
george.karpenkov added a comment. @MTC what happens for this.j = 0; for (int i=0; i<100; i++) this.j++; ? Repository: rC Clang https://reviews.llvm.org/D45491 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D45495: [CUDA] Added --[no-]cuda-include-ptx=sm_XX|all option.

2018-04-10 Thread Justin Lebar via Phabricator via cfe-commits
jlebar accepted this revision. jlebar added a comment. This revision is now accepted and ready to land. Where do we document the default values for these flags? Like, how is a user supposed to figure out whether the default is to include ptx or not? https://reviews.llvm.org/D45495

[clang-tools-extra] r329730 - [clang-tidy] [modernize-use-auto] Add a threshold for minimal type name length to be replaced with 'auto'

2018-04-10 Thread Zinovy Nis via cfe-commits
Author: zinovy.nis Date: Tue Apr 10 11:05:24 2018 New Revision: 329730 URL: http://llvm.org/viewvc/llvm-project?rev=329730=rev Log: [clang-tidy] [modernize-use-auto] Add a threshold for minimal type name length to be replaced with 'auto' The threshold option is 'MinTypeNameLength' with default

[PATCH] D45383: Limit types of builtins that can be redeclared.

2018-04-10 Thread Eli Friedman via Phabricator via cfe-commits
efriedma added inline comments. Comment at: test/Sema/builtin-redecl.cpp:9 +// Overloading a builtin is acceptable in C++. +void __builtin_va_copy(double d); +#endif We don't want to allow this; in particular, for builtins with custom type-checking, we have no

[PATCH] D45491: [analyzer] Do not invalidate the `this` pointer.

2018-04-10 Thread Henry Wong via Phabricator via cfe-commits
MTC created this revision. MTC added reviewers: NoQ, george.karpenkov, a.sidorin, seaneveson, szepet. Herald added subscribers: cfe-commits, rnkovacs, xazax.hun. MTC edited the summary of this revision. `this` pointer is not an l-value, although we have modeled `CXXThisRegion` for `this`

[PATCH] D45212: [HIP] Let CUDA toolchain support HIP language mode and amdgpu

2018-04-10 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl updated this revision to Diff 141863. yaxunl marked 2 inline comments as done. yaxunl edited the summary of this revision. yaxunl added a comment. Separate file type changes to another patch. https://reviews.llvm.org/D45212 Files: include/clang/Driver/Options.td

Re: [clang-tools-extra] r329452 - [clang-tidy] Fix compilation for ParentVirtualCallCheck.cpp

2018-04-10 Thread Zinovy Nis via cfe-commits
OK) вт, 10 апр. 2018 г. в 18:44, Alexander Kornienko : > I totally get it, no worries. But if you have free cycles, it would be > nice to brush this code up again. > > > On Tue, Apr 10, 2018 at 5:32 PM Zinovy Nis wrote: > >> Looks you are right, but I

Re: [PATCH] D44883: [Sema] Extend -Wself-assign and -Wself-assign-field to warn on overloaded self-assignment (classes)

2018-04-10 Thread John McCall via cfe-commits
Yeah, -Wself-assign in general is about catching a class of live-coding errors which is pretty unlikely to ever make it into committed code, since the code would need to be dead/redundant for the mistake to not be noticed. So it’s specifically a rather poor match for the static analyzer, and I

[PATCH] D44988: [Sema] Fix decrement availability for built-in types

2018-04-10 Thread Volodymyr Sapsai via Phabricator via cfe-commits
vsapsai accepted this revision. vsapsai added a comment. This revision is now accepted and ready to land. Looks good to me. https://reviews.llvm.org/D44988 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D43322: Diagnose cases of "return x" that should be "return std::move(x)" for efficiency

2018-04-10 Thread Arthur O'Dwyer via Phabricator via cfe-commits
Quuxplusone added a comment. Tuesday ping! I just need someone to commit this for me. Repository: rC Clang https://reviews.llvm.org/D43322 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang-tools-extra] r329725 - [clangd] Use operator<< to prevent printers issues in Gtest

2018-04-10 Thread Marc-Andre Laperle via cfe-commits
Author: malaperle Date: Tue Apr 10 10:34:46 2018 New Revision: 329725 URL: http://llvm.org/viewvc/llvm-project?rev=329725=rev Log: [clangd] Use operator<< to prevent printers issues in Gtest Summary: It is possible that there will be two different instantiations of the printer template for a

[PATCH] D44093: [BUILTINS] structure pretty printer

2018-04-10 Thread Paul Semel via Phabricator via cfe-commits
paulsemel added a comment. I don't really know what's the procedure right now.. What should I do once you both accepted the patch ? :) Repository: rC Clang https://reviews.llvm.org/D44093 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D45383: Limit types of builtins that can be redeclared.

2018-04-10 Thread Erich Keane via Phabricator via cfe-commits
erichkeane updated this revision to Diff 141876. erichkeane retitled this revision from "Strip reference from a va_list object in C when merging parameter types." to "Limit types of builtins that can be redeclared.". erichkeane edited the summary of this revision. erichkeane added a comment.

[PATCH] D45495: [CUDA] Added --[no-]cuda-include-ptx=sm_XX|all option.

2018-04-10 Thread Artem Belevich via Phabricator via cfe-commits
tra created this revision. tra added a reviewer: jlebar. Herald added a subscriber: sanjoy. Currently we always include PTX into the fatbin along with the GPU code. It about doubles the size of the GPU binary we need to carry in the executable. These options allow control inclusion of PTX into

[PATCH] D44093: [BUILTINS] structure pretty printer

2018-04-10 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added a comment. In https://reviews.llvm.org/D44093#1063340, @paulsemel wrote: > I don't really know what's the procedure right now.. What should I do once > you both accepted the patch ? :) You're good to commit the patch and address the concerns raised by @arichardson in a

[PATCH] D45454: Make __gcov_flush visible outside a shared library

2018-04-10 Thread David Li via Phabricator via cfe-commits
davidxl added a comment. With this change, gcov_flush will resolve to the copy in the main executable for each shared library -- this is not the desired the behavior. https://reviews.llvm.org/D45454 ___ cfe-commits mailing list

[PATCH] D45212: [HIP] Let CUDA toolchain support HIP language mode and amdgpu

2018-04-10 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl added a comment. In https://reviews.llvm.org/D45212#1060628, @Hahnfeld wrote: > Can this revision be split further? The summary mentions many things that > might make up multiple independent changes... I separated file type changes to https://reviews.llvm.org/D45489 and deferred some

[PATCH] D44602: [clang-tidy] readability-function-size: add VariableThreshold param.

2018-04-10 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added inline comments. Comment at: clang-tidy/readability/FunctionSizeCheck.cpp:31 +!(isa(VD) || isa(VD)) && +!VD->getLocation().isMacroID()) + Info.Variables++; This isn't the restriction I was envisioning. I was thinking more

Re: [PATCH] D44883: [Sema] Extend -Wself-assign and -Wself-assign-field to warn on overloaded self-assignment (classes)

2018-04-10 Thread Nico Weber via cfe-commits
On Tue, Apr 10, 2018 at 12:13 PM, David Blaikie wrote: > It's more the fact that that's /all/ the warning improvement has found so > far. If it was 8 false positives & also found 80 actionable bugs/bad code, > that'd be one thing. > Right. We used to hold ourselves to very

Re: [PATCH] D44883: [Sema] Extend -Wself-assign and -Wself-assign-field to warn on overloaded self-assignment (classes)

2018-04-10 Thread John McCall via cfe-commits
Also, the standard for the static analyzer is not lower than it is for the compiler. The static analyzer tries to catch a much larger class of bugs, but it also tries very hard to make all the warnings it emits count. There’s a really common problem in the static analysis field where users try a

[PATCH] D45468: [clang-tidy] Adding Fuchsia checker for human-readable logging

2018-04-10 Thread Jonas Toth via Phabricator via cfe-commits
JonasToth added inline comments. Comment at: clang-tidy/zircon/HumanReadableStatusCheck.cpp:68 +SourceRange FmtStringRange; +for (const auto *Arg : D->arguments()) { + if (const auto *ICE = dyn_cast(Arg)) { Did you consider using

[PATCH] D45416: [analyzer] ExprEngine: model GCC inline asm rvalue cast outputs

2018-04-10 Thread Aleksei Sidorin via Phabricator via cfe-commits
a.sidorin added a comment. Maybe we should just remove the condition and leave a FIXME? Repository: rC Clang https://reviews.llvm.org/D45416 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D45485: [CMake] Unbreak BUILD_SHARED_LIBS workflow

2018-04-10 Thread David Zarzycki via Phabricator via cfe-commits
davezarzycki created this revision. davezarzycki added reviewers: mspertus, beanz, gottesmm. Herald added a subscriber: mgorny. Due to recent timer changes, we need to add LLVM's `Core` library to avoid undefined symbol errors at link time (`llvm::TimePassesIsEnabled`) when using LLVM's

[PATCH] D45479: [Tooling] Optimize memory usage in InMemoryToolResults.

2018-04-10 Thread Ilya Biryukov via Phabricator via cfe-commits
ilya-biryukov added a comment. This definitely helps with memory consumption of clangd's global-symbol-indexer, I can now run it over LLVM on MacBook without it swapping out of RAM. The physical memory usage goes up to 3GB at some point, before it was > 20GB. Strictly speaking, interning the

  1   2   3   >