[PATCH] D45442: Parse .h files as objective-c++ if we don't have a compile command.

ilya-biryukov added inline comments. Comment at: clangd/GlobalCompilationDatabase.cpp:24 + // Parsing as Objective C++ is friendly to more cases. + if (llvm::sys::path::extension(File) == ".h") +Argv.push_back("-xobjective-c++-header"); sammccall wrote: >

[PATCH] D38845: [ASTImporter] Support importing UnresolvedMemberExpr, DependentNameType, DependentScopeDeclRefExpr

szepet marked an inline comment as done. szepet added a comment. Hello Aleksei, Thanks for carrying the ASTImporter improvements (in general)! I will rebase it and upload for sure, but probably just next week. (After EuroLLVM.) https://reviews.llvm.org/D38845

[PATCH] D45512: [Tooling] Correct the "-std" compile command option.

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Thanks! Repository: rC Clang https://reviews.llvm.org/D45512 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D33537: [clang-tidy] Exception Escape Checker

baloghadamsoftware added a comment. Thank you for your thorough review, I will do the fixes next week, after the Euro LLVM. https://reviews.llvm.org/D33537 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D45512: [Tooling] Correct the "-std" compile command option.

This revision was automatically updated to reflect the committed changes. Closed by commit rL329786: [Tooling] Correct the -std compile command option. (authored by hokein, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D45512 Files:

[PATCH] D44203: [clang-format] Improve Incomplete detection for (text) protos

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: lib/Format/TokenAnnotator.cpp:773 case tok::r_brace: - // Lines can start with '}'. - if (Tok->Previous) + // Lines can start with

r329786 - [Tooling] Correct the "-std" compile command option.

Author: hokein Date: Wed Apr 11 02:18:18 2018 New Revision: 329786 URL: http://llvm.org/viewvc/llvm-project?rev=329786=rev Log: [Tooling] Correct the "-std" compile command option. Summary: "-std c++11" is not valid in compiler, we have to use "-std=c++11". Test in vscode with this patch, code

[PATCH] D43871: [modules] No longer include stdlib.h from mm_malloc.h.

v.g.vassilev added inline comments. Comment at: test/CXX/except/except.spec/libc-empty-except.cpp:27 +#else +#include "mm_malloc.h" +#include "stdlib.h" Maybe we should reverse the includes here as we discussed offline. https://reviews.llvm.org/D43871

[PATCH] D45512: [Tooling] Correct the "-std" compile command option.

hokein created this revision. hokein added a reviewer: sammccall. Herald added a subscriber: klimek. "-std c++11" is not valid in compiler, we have to use "-std=c++11". Test in vscode with this patch, code completion for header works as expected. Repository: rC Clang

[PATCH] D43578: -ftime-report switch support in Clang

avt77 added a comment. In https://reviews.llvm.org/D43578#1062950, @thakis wrote: > @davezarzycki remarks in https://reviews.llvm.org/D45485 that this breaks the > shared build. The proposed fix there is to make several of clang's modules > depend on LLVM's IR library ("Core"). This seems

[PATCH] D45406: Document -std= values for different languages

dim added a comment. Ping Repository: rC Clang https://reviews.llvm.org/D45406 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D45513: [clangd] Add line and column number to the index symbol.

hokein created this revision. hokein added a reviewer: sammccall. Herald added subscribers: MaskRay, ioeric, jkorous-apple, ilya-biryukov, klimek. LSP is using Line & column as symbol position, clangd needs to transfer file offset to Line & column when sending results back to LSP client, which is

[PATCH] D44970: [XRay][clang] Add flag to choose instrumentation bundles

dberris updated this revision to Diff 141958. dberris marked an inline comment as done. dberris added a comment. Herald added a subscriber: mgorny. - Rebase - Address comments to use a bitmask/bitset for instrumentation bundle https://reviews.llvm.org/D44970 Files:

[PATCH] D43764: [clang-apply-replacements] Convert tooling::Replacements to tooling::AtomicChange for conflict resolving of changes, code cleanup, and code formatting.

jdemeule updated this revision to Diff 141969. jdemeule marked 3 inline comments as done. jdemeule added a comment. Sort replacements before converting them to AtomicChange. https://reviews.llvm.org/D43764 Files:

[PATCH] D45414: [clang-tidy] add missing assignment operations in hicpp-signed-bitwise

JonasToth updated this revision to Diff 141970. JonasToth added a comment. - remove shifting exception for standarized bitmask types Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D45414 Files: clang-tidy/hicpp/SignedBitwiseCheck.cpp docs/ReleaseNotes.rst

[PATCH] D45476: [C++2a] Implement operator<=> CodeGen and ExprConstant

rsmith added inline comments. Comment at: include/clang/AST/ComparisonCategories.h:68 + /// \brief A map containing the comparison category values built from the + /// standard library. The key is a value of ComparisonCategoryValue. + llvm::DenseMap

[PATCH] D43817: [x86] wbnoinvd intrinsic

GBuella added inline comments. Comment at: lib/Basic/Targets/X86.cpp:188 setFeatureEnabledImpl(Features, "mpx", true); if (Kind != CK_SkylakeServer) // SKX inherits all SKL features, except SGX setFeatureEnabledImpl(Features, "sgx", true);

[PATCH] D45255: [CodeGen] Add an option to suppress output of llvm.ident

miyuki added a comment. ping https://reviews.llvm.org/D45255 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D35110: [Analyzer] Constraint Manager Negates Difference

baloghadamsoftware updated this revision to Diff 141955. baloghadamsoftware added a comment. Herald added a reviewer: george.karpenkov. Rebased to the newly committed SValbuilder rearranger patch https://reviews.llvm.org/D35110 Files: lib/StaticAnalyzer/Core/RangeConstraintManager.cpp

[PATCH] D45442: Parse .h files as objective-c++ if we don't have a compile command.

sammccall updated this revision to Diff 141957. sammccall added a comment. Herald added a subscriber: mgorny. Add test, shave required yaks Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D45442 Files: clangd/GlobalCompilationDatabase.cpp clangd/GlobalCompilationDatabase.h

[PATCH] D43871: [modules] No longer include stdlib.h from mm_malloc.h.

rsmith added inline comments. Comment at: lib/Sema/SemaExceptionSpec.cpp:312 +OldProto->getReturnType(), OldProto->getParamTypes(), +OldProto->getExtProtoInfo().withExceptionSpec(EST_DynamicNone))); +return false; Updating the old function's

[PATCH] D45513: [clangd] Add line and column number to the index symbol.

sammccall added inline comments. Comment at: clangd/index/Index.h:27 struct SymbolLocation { + struct Position { +// Line position in a document (zero-based). There are 4 of these per symbol, if we can keep line + character to 32 bits we save 16 bytes per

Re: r329784 - [Tooling] Optimize memory usage in InMemoryToolResults.

On Wed, Apr 11, 2018 at 10:16 AM Haojian Wu via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: hokein > Date: Wed Apr 11 01:13:07 2018 > New Revision: 329784 > ... > > == > ---

[PATCH] D45479: [Tooling] Optimize memory usage in InMemoryToolResults.

This revision was automatically updated to reflect the committed changes. Closed by commit rC329784: [Tooling] Optimize memory usage in InMemoryToolResults. (authored by hokein, committed by ). Changed prior to commit: https://reviews.llvm.org/D45479?vs=141842=141956#toc Repository: rC

r329784 - [Tooling] Optimize memory usage in InMemoryToolResults.

Author: hokein Date: Wed Apr 11 01:13:07 2018 New Revision: 329784 URL: http://llvm.org/viewvc/llvm-project?rev=329784=rev Log: [Tooling] Optimize memory usage in InMemoryToolResults. Avoid storing duplicated "std::string"s. clangd's global-symbol-builder takes 20+GB memory running across LLVM

[PATCH] D45442: Parse .h files as objective-c++ if we don't have a compile command.

sammccall added a comment. Added a unit test, and cleaned up a couple of things to make it pass: - GlobalCompilationDatabase.h wasn't self-contained due to incomplete types - testPath() isn't very usable with subdirectories on windows Comment at:

[PATCH] D45478: [clangd] Merge symbols in global-sym-builder on the go

sammccall added a comment. Is this patch still relevant after haojian's string deduplication? Comment at: clangd/global-symbol-builder/GlobalSymbolBuilderMain.cpp:53 +/// Combines occurrences of the same symbols across translation units. +class SymbolMerger {

[PATCH] D45406: Document -std= values for different languages

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. Looks good to me, thank you Repository: rC Clang https://reviews.llvm.org/D45406 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D45414: [clang-tidy] add missing assignment operations in hicpp-signed-bitwise

JonasToth closed this revision. JonasToth added a comment. Commit in https://reviews.llvm.org/rCTE329789 Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D45414 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D43578: -ftime-report switch support in Clang

On Wed, Apr 11, 2018 at 6:18 AM, Andrew V. Tischenko via Phabricator via cfe-commits wrote: > avt77 added a comment. > > In https://reviews.llvm.org/D43578#1062950, @thakis wrote: > > > @davezarzycki remarks in https://reviews.llvm.org/D45485 that this > breaks the

[clang-tools-extra] r329789 - [clang-tidy] add missing assignment operations in hicpp-signed-bitwise

Author: jonastoth Date: Wed Apr 11 02:53:08 2018 New Revision: 329789 URL: http://llvm.org/viewvc/llvm-project?rev=329789=rev Log: [clang-tidy] add missing assignment operations in hicpp-signed-bitwise This patch resolves the bug https://bugs.llvm.org/show_bug.cgi?id=36963. - implement missing

[PATCH] D45405: [clang-tidy] [modernize-use-auto] Add a threshold for minimal type name length to be replaced with 'auto'

alexfh added a comment. In https://reviews.llvm.org/D45405#1063890, @zinovy.nis wrote: > Roman, I see you've fixed them. Thanks a lot! > I did not face with these errors on MSVS'201 so had no chance to fix early. No stress, but as Roman said, please watch the bots after committing a patch:

[PATCH] D45491: [analyzer] Do not invalidate the `this` pointer.

MTC marked 2 inline comments as done. MTC added inline comments. Comment at: lib/StaticAnalyzer/Core/RegionStore.cpp:1024-1027 + // 'this' pointer is not an lvalue, we should not invalidate it. + if (CXXThisRegion::classof(baseR)) +return; + NoQ wrote: > I

[PATCH] D44602: [clang-tidy] readability-function-size: add VariableThreshold param.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. Aside from some minor nits, LGTM! Comment at: clang-tidy/readability/FunctionSizeCheck.cpp:28 +// Do not count decomposition declarations (C++17's

r329810 - [Driver] Don't forward -m[no-]unaligned-access options to GCC when assembling/linking

Author: mcrosier Date: Wed Apr 11 07:20:37 2018 New Revision: 329810 URL: http://llvm.org/viewvc/llvm-project?rev=329810=rev Log: [Driver] Don't forward -m[no-]unaligned-access options to GCC when assembling/linking Differential Revision: https://reviews.llvm.org/D45092 Modified:

[PATCH] D45092: [Driver] Don't forward -m[no-]unaligned-access options to GCC when assembling/linking

This revision was automatically updated to reflect the committed changes. Closed by commit rC329810: [Driver] Dont forward -m[no-]unaligned-access options to GCC when… (authored by mcrosier, committed by ). Herald added a subscriber: cfe-commits. Repository: rC Clang

[PATCH] D44931: [WebAssembly] Use Windows EH instructions for Wasm EH

aheejin updated this revision to Diff 141979. aheejin added a comment. - Change personality function name to a unique one Repository: rC Clang https://reviews.llvm.org/D44931 Files: lib/CodeGen/CGCXXABI.h lib/CodeGen/CGCleanup.cpp lib/CodeGen/CGCleanup.h lib/CodeGen/CGException.cpp

[PATCH] D45363: [OpenCL] Added -std/-cl-std=CL2.2/CLC++

bader accepted this revision. bader added a comment. This revision is now accepted and ready to land. LGTM. Thanks! https://reviews.llvm.org/D45363 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D44988: [Sema] Fix decrement availability for built-in types

This revision was automatically updated to reflect the committed changes. Closed by commit rL329804: [Sema] Fix built-in decrement operator overload resolution (authored by jkorous, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

r329804 - [Sema] Fix built-in decrement operator overload resolution

Author: jkorous Date: Wed Apr 11 06:36:29 2018 New Revision: 329804 URL: http://llvm.org/viewvc/llvm-project?rev=329804=rev Log: [Sema] Fix built-in decrement operator overload resolution C++ [over.built] p4: "For every pair (T, VQ), where T is an arithmetic type other than bool, and VQ is

[PATCH] D45363: [OpenCL] Added -std/-cl-std=CL2.2/CLC++

Anastasia added inline comments. Comment at: lib/Frontend/InitPreprocessor.cpp:434 +llvm_unreachable("Unsupported OpenCL C++ version"); + Builder.defineMacro("__CL_CPP_VERSION_1_0__", "100"); +} else { There is no such macro in the spec it

[clang-tools-extra] r329790 - [clang-tidy] fix buildbots from hicpp-signed-bitwise

Author: jonastoth Date: Wed Apr 11 03:22:25 2018 New Revision: 329790 URL: http://llvm.org/viewvc/llvm-project?rev=329790=rev Log: [clang-tidy] fix buildbots from hicpp-signed-bitwise The applied patch to diagnose assignment operators introduced breakage on some architectures. This patch tries

[PATCH] D44882: [clangd] Implementation of workspace/symbol request

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Sorry about the delay Marc-André - I got stuck on "how to test ClangdLSPServer" and then distracted! But this looks great. Comment at: clangd/ClangdLSPServer.cpp:101

[PATCH] D45045: [DebugInfo] Generate debug information for labels.

HsiangKai updated this revision to Diff 141989. HsiangKai added a comment. Update the test case for inlined functions. The inlined label will attach to DISubprogram(..., labels: !n) Repository: rC Clang https://reviews.llvm.org/D45045 Files: lib/CodeGen/CGDebugInfo.cpp

[PATCH] D45392: [clang-tidy] add new check to find out objc ivars which do not have prefix '_'

alexfh requested changes to this revision. alexfh added a comment. This revision now requires changes to proceed. Thank you, that's much better! I'd also appreciate, if you could document the options this check supports in its .rst document (separately from this patch). A few more comments

[PATCH] D44602: [clang-tidy] readability-function-size: add VariableThreshold param.

lebedev.ri updated this revision to Diff 141997. lebedev.ri added a reviewer: alexfh. lebedev.ri added a comment. After a quick IRC chat with @aaron.ballman, it was discovered that there has been a big misunderstanding: we don't need to ignore/exempt *all* the variables declared in macros, we

[PATCH] D45405: [clang-tidy] [modernize-use-auto] Add a threshold for minimal type name length to be replaced with 'auto'

zinovy.nis added a comment. The build was broken by someone else's commit then. From my side there was a warning only I fixed immediately. ср, 11 апр. 2018 г. в 16:26, Alexander Kornienko via Phabricator < revi...@reviews.llvm.org>: > alexfh added a comment. > > In

[PATCH] D45363: [OpenCL] Added -std/-cl-std=CL2.2/CLC++

Anastasia updated this revision to Diff 141975. Anastasia edited the summary of this revision. Anastasia added a comment. Changed to `-cl-std=c++` since it's explicitly defined in spec. We could reuse `OpenCLVersion` in `LangOpts` but I think it might be cleaner to add separate

[PATCH] D45482: [clangd] Match AST and Index label for template Symbols

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Nice, I'd been wondering about that... Comment at: clangd/index/SymbolCollector.cpp:36 + return *T; +return ND; + } uber-nit: these three

[PATCH] D43578: -ftime-report switch support in Clang

russell.gallop added a comment. We also see an assertion failure prior to the revert. At r329738: $ cat test.cpp template struct A { template using rebind_alloc = _Other; }; template struct _Wrap_alloc { template using rebind_alloc = typename A<_Alloc>::template

[PATCH] D45515: [NEON] Support vrndns_f32 intrinsic

kosarev created this revision. kosarev added reviewers: t.p.northover, rengolin, SjoerdMeijer. kosarev added a project: clang. Herald added a subscriber: javed.absar. https://reviews.llvm.org/D45515 Files: include/clang/Basic/arm_neon.td lib/CodeGen/CGBuiltin.cpp

[PATCH] D44882: [clangd] Implementation of workspace/symbol request

sammccall added a comment. (BTW @hokein has https://reviews.llvm.org/D45513 to add row/col to the index, which will allow all the file-reading stuff to be cleaned up, but no need to wait on that since it's all working now). Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D44882

[PATCH] D43578: -ftime-report switch support in Clang

avt77 added a comment. In https://reviews.llvm.org/D43578#1064113, @russell.gallop wrote: > We also see an assertion failure prior to the revert. At r329738: Yes, you're right - thaks again for this test case. Repository: rL LLVM https://reviews.llvm.org/D43578

[PATCH] D44931: [WebAssembly] Use Windows EH instructions for Wasm EH

aheejin updated this revision to Diff 141983. aheejin added a comment. - Rebase Repository: rC Clang https://reviews.llvm.org/D44931 Files: lib/CodeGen/CGCXXABI.h lib/CodeGen/CGCleanup.cpp lib/CodeGen/CGCleanup.h lib/CodeGen/CGException.cpp lib/CodeGen/ItaniumCXXABI.cpp

[PATCH] D44602: [clang-tidy] readability-function-size: add VariableThreshold param.

lebedev.ri updated this revision to Diff 142003. lebedev.ri marked 2 inline comments as done. lebedev.ri added a comment. - Drop stale comment - Switch to pre{in,de}crement Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D44602 Files:

Re: r329804 - [Sema] Fix built-in decrement operator overload resolution

While you're here... ++ should not be available for bool in C++17 onwards. :) On Wed, 11 Apr 2018, 14:39 Jan Korous via cfe-commits, < cfe-commits@lists.llvm.org> wrote: > Author: jkorous > Date: Wed Apr 11 06:36:29 2018 > New Revision: 329804 > > URL:

[PATCH] D44921: [PowerPC] Option for secure plt mode

This revision was automatically updated to reflect the committed changes. Closed by commit rL329795: [PowerPC] Option for secure plt mode (authored by spetrovic, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

r329795 - [PowerPC] Option for secure plt mode

Author: spetrovic Date: Wed Apr 11 05:24:44 2018 New Revision: 329795 URL: http://llvm.org/viewvc/llvm-project?rev=329795=rev Log: [PowerPC] Option for secure plt mode This patch enables option for secure plt mode in clang (-msecure-plt). Differential Revision: https://reviews.llvm.org/D44921

[PATCH] D45491: [analyzer] Do not invalidate the `this` pointer.

MTC added a comment. In https://reviews.llvm.org/D45491#1063364, @george.karpenkov wrote: > @MTC what happens for > > this.j = 0; > for (int i=0; i<100; i++) > this.j++; > > > ? @george.karpenkov `this`'s value will remain unchanged, `j` will be invalidated. 1 void

[PATCH] D45515: [NEON] Support vrndns_f32 intrinsic

SjoerdMeijer accepted this revision. SjoerdMeijer added a comment. This revision is now accepted and ready to land. Looks good to me. https://reviews.llvm.org/D45515 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D45517: [analyzer] WIP: False positive refutation with Z3

rnkovacs created this revision. rnkovacs added reviewers: george.karpenkov, NoQ, dcoughlin. Herald added subscribers: a.sidorin, szepet, baloghadamsoftware, whisperity, fhahn. This is a prototype of a bug reporter visitor that invalidates bug reports by re-checking constraints of certain states

[PATCH] D45523: [CodeGen] Handle __func__ inside __finally

smeenai created this revision. smeenai added reviewers: compnerd, majnemer, rnk. When we enter a __finally block, the CGF's CurCodeDecl will be null (because CodeGenFunction::StartFunction is given an empty GlobalDecl for a __finally block), and so the dyn_cast here will result in an assertion

[PATCH] D45483: [NEON] Support vfma_n and vfms_n intrinsics

This revision was automatically updated to reflect the committed changes. Closed by commit rL329814: [NEON] Support vfma_n and vfms_n intrinsics (authored by kosarev, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D43764: [clang-apply-replacements] Convert tooling::Replacements to tooling::AtomicChange for conflict resolving of changes, code cleanup, and code formatting.

This revision was automatically updated to reflect the committed changes. Closed by commit rL329813: [clang-apply-replacements] Convert tooling::Replacements to tooling… (authored by malcolm.parsons, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[clang-tools-extra] r329813 - [clang-apply-replacements] Convert tooling::Replacements to tooling::AtomicChange for conflict resolving of changes, code cleanup, and code formatting.

Author: malcolm.parsons Date: Wed Apr 11 07:39:17 2018 New Revision: 329813 URL: http://llvm.org/viewvc/llvm-project?rev=329813=rev Log: [clang-apply-replacements] Convert tooling::Replacements to tooling::AtomicChange for conflict resolving of changes, code cleanup, and code formatting.

[PATCH] D45523: [CodeGen] Handle __func__ inside __finally

smeenai added inline comments. Comment at: test/CodeGen/exceptions-seh-finally.c:281 +// CHECK-LABEL: define internal void @"?fin$0@0@finally_with_func@@"({{[^)]*}}) +// CHECK: call void @cleanup_with_func(i8* getelementptr inbounds ([18 x i8], [18 x i8]*

[PATCH] D45491: [analyzer] Do not invalidate the `this` pointer.

MTC updated this revision to Diff 142026. MTC marked 2 inline comments as done. MTC added a comment. - Move the `CXXThisRegion`'s check to `LoopWidening.cpp` - Use `isa(R)` instead of `CXXThisRegion::classof(R)`. Repository: rC Clang https://reviews.llvm.org/D45491 Files:

[PATCH] D45255: [CodeGen] Add an option to suppress output of llvm.ident

aprantl added a comment. What's your use-case for this? Comment at: test/CodeGen/no-ident-version.c:4 +// CHECK-NOT: llvm.ident +// CHECK-NOT: producer: +int main(void) {} You'll also want to check for something positive, otherwise this test will succeed even

r329814 - [NEON] Support vfma_n and vfms_n intrinsics

Author: kosarev Date: Wed Apr 11 07:43:11 2018 New Revision: 329814 URL: http://llvm.org/viewvc/llvm-project?rev=329814=rev Log: [NEON] Support vfma_n and vfms_n intrinsics Differential Revision: https://reviews.llvm.org/D45483 Modified: cfe/trunk/include/clang/Basic/arm_neon.td

[PATCH] D45483: [NEON] Support vfma_n and vfms_n intrinsics

This revision was automatically updated to reflect the committed changes. Closed by commit rC329814: [NEON] Support vfma_n and vfms_n intrinsics (authored by kosarev, committed by ). Repository: rL LLVM https://reviews.llvm.org/D45483 Files: include/clang/Basic/arm_neon.td

[PATCH] D45521: [clang-format] Improve ObjC guessing heuristic by supporting all @keywords

benhamilton created this revision. benhamilton added reviewers: djasper, jolesiak. Herald added subscribers: cfe-commits, klimek. This diff improves the Objective-C guessing heuristic by replacing the hard-coded list of a subset of Objective-C @keywords with a general check which supports all

r329816 - Fix bugs around handling C++11 attributes.

Author: klimek Date: Wed Apr 11 07:51:54 2018 New Revision: 329816 URL: http://llvm.org/viewvc/llvm-project?rev=329816=rev Log: Fix bugs around handling C++11 attributes. Previously, we would format: int a() { ... } [[unused]] int b() { ... } as... int a() {} [[unused] int b() {} Now we

[PATCH] D45454: Make __gcov_flush visible outside a shared library

davidxl added a comment. The behavior will change if the shared libraries are not 'dlopen'ed but loaded at program startup time. https://reviews.llvm.org/D45454 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r329827 - Document -std= values for different languages

Author: dim Date: Wed Apr 11 10:21:52 2018 New Revision: 329827 URL: http://llvm.org/viewvc/llvm-project?rev=329827=rev Log: Document -std= values for different languages Summary: After a remark on a FreeBSD mailing list that the clang man page did not have any list of possible values for the

[PATCH] D45061: [NVPTX, CUDA] Improved feature constraints on NVPTX target builtins.

tra added a comment. In https://reviews.llvm.org/D45061#1063791, @echristo wrote: > Guessing that SM_60 (etc) are defines? > > Anyhow LGTM. I'm not sure you can split up the satom part of the patch, but > if you can that'd be great. > > -eric I'll split out removal of satom feature into a

[PATCH] D43817: [x86] wbnoinvd intrinsic

craig.topper accepted this revision. craig.topper added a comment. LGTM https://reviews.llvm.org/D43817 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D45532: [StaticAnalyzer] Checker to find uninitialized fields after a constructor call

lebedev.ri added a comment. Please always upload all patches with full context (`-U9`) Repository: rC Clang https://reviews.llvm.org/D45532 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D45179: [libc++] Add _LIBCPP_FORCE_NODISCARD define to force-enable nodiscard in pre-C++17

Quuxplusone added a comment. In https://reviews.llvm.org/D45179#1064589, @lebedev.ri wrote: > I'm waiting for @mclow.lists to have the final say re this differential. Ack. :) > So roughly: > > // NOTE: Do not use [[nodiscard]] in pre-C++17 mode > // to avoid -Wc++17-extensions

[PATCH] D45454: Make __gcov_flush visible outside a shared library

chh added a comment. Yes, calling `__gcov_flush` within .so files are different, but it's a revert of https://reviews.llvm.org/D38124. I think https://bugs.llvm.org/show_bug.cgi?id=27224 can be fixed by hiding only llvm_gcda_* functions, without any change to `__gcov_flush`. (1) Before

[PATCH] D45532: [StaticAnalyzer] Checker to find uninitialized fields after a constructor call

Szelethus added inline comments. Comment at: test/Analysis/ctor-uninitialized-member.cpp:869 +void f44() { + ContainsUnionWithSimpleUnionTest2(); // xpected-warning{{1 uninitialized field}} +} NoQ wrote: > Hmm, shouldn't it say "expected"? Do these tests

[PATCH] D45392: [clang-tidy] add new check to find out objc ivars which do not have prefix '_'

Wizard added inline comments. Comment at: test/clang-tidy/readability-identifier-naming-objc.m:8-9 +// RUN: ]}' -- -fno-delayed-template-parsing \ +// RUN: -I%S/Inputs/readability-identifier-naming \ +// RUN: -isystem %S/Inputs/readability-identifier-naming/system +

r329830 - [NVPTX] Removed 'satom' feature which is no longer used.

Author: tra Date: Wed Apr 11 10:51:33 2018 New Revision: 329830 URL: http://llvm.org/viewvc/llvm-project?rev=329830=rev Log: [NVPTX] Removed 'satom' feature which is no longer used. Differential Revision: https://reviews.llvm.org/D45061 Modified: cfe/trunk/lib/Basic/Targets/NVPTX.cpp

[PATCH] D45061: [NVPTX, CUDA] Improved feature constraints on NVPTX target builtins.

This revision was automatically updated to reflect the committed changes. Closed by commit rC329829: [NVPTX, CUDA] Improved feature constraints on NVPTX target builtins. (authored by tra, committed by ). Changed prior to commit: https://reviews.llvm.org/D45061?vs=141932=142047#toc Repository:

[PATCH] D45532: [StaticAnalyzer] Checker to find uninitialized fields after a constructor call

Szelethus created this revision. Szelethus added reviewers: NoQ, xazax.hun, dkrupp, whisperity. Herald added subscribers: cfe-commits, a.sidorin, rnkovacs, szepet, mgorny. Herald added a reviewer: george.karpenkov. This checker checks at the end of a constructor call whether all fields of the

[PATCH] D45523: [CodeGen] Handle __func__ inside __finally

This revision was automatically updated to reflect the committed changes. Closed by commit rL329836: [CodeGen] Handle __func__ inside __finally (authored by smeenai, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D45523 Files:

[PATCH] D45526: [clang-format] Prefer breaking after ObjC category close paren

benhamilton created this revision. benhamilton added reviewers: djasper, jolesiak. Herald added subscribers: cfe-commits, klimek. Previously, `clang-format` would break Objective-C category extensions after the opening parenthesis to avoid breaking the protocol list: % echo "@interface

[PATCH] D45529: [CMake] Set the default ABI version for Fuchsia in CMake as well

phosek created this revision. phosek added reviewers: EricWF, beanz. Herald added subscribers: cfe-commits, christof, mgorny. This is neeeded since the CMake value is used for the SOVERSION. Repository: rCXX libc++ https://reviews.llvm.org/D45529 Files: libcxx/CMakeLists.txt Index:

[PATCH] D45406: Document -std= values for different languages

This revision was automatically updated to reflect the committed changes. Closed by commit rL329827: Document -std= values for different languages (authored by dim, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D45179: [libc++] Add _LIBCPP_FORCE_NODISCARD define to force-enable nodiscard in pre-C++17

lebedev.ri added a comment. I'm waiting for @mclow.lists to have the final say re this differential. In https://reviews.llvm.org/D45179#1057187, @Quuxplusone wrote: > In https://reviews.llvm.org/D45179#1056706, @lebedev.ri wrote: > > > gcc does not silence the warning produced by > > these

[clang-tools-extra] r329833 - [Documentation] Fix formatting and order in Release Notes for recent changes in modernize-use-auto.

Author: eugenezelenko Date: Wed Apr 11 11:03:57 2018 New Revision: 329833 URL: http://llvm.org/viewvc/llvm-project?rev=329833=rev Log: [Documentation] Fix formatting and order in Release Notes for recent changes in modernize-use-auto. Modified: clang-tools-extra/trunk/docs/ReleaseNotes.rst

[PATCH] D45532: [StaticAnalyzer] Checker to find uninitialized fields after a constructor call

Szelethus added a comment. In https://reviews.llvm.org/D45532#1064652, @NoQ wrote: > > In most cases, all fields of a union is regarded as unknown. I checked > > these cases by regarding unknown fields as uninitialized. > > The whole point of making them unknown, as far as i understand, was to

[PATCH] D45532: [StaticAnalyzer] Checker to find uninitialized fields after a constructor call

NoQ added a comment. Ok, thanks, looking forward to it! Comment at: test/Analysis/ctor-uninitialized-member.cpp:869 +void f44() { + ContainsUnionWithSimpleUnionTest2(); // xpected-warning{{1 uninitialized field}} +} Szelethus wrote: > NoQ wrote: > > Hmm,

[PATCH] D45532: [StaticAnalyzer] Checker to find uninitialized fields after a constructor call

Szelethus added a comment. In https://reviews.llvm.org/D45532#1064670, @Szelethus wrote: > I wasn't too clear on this one: unknown fields are regarded as uninitialized, > what I wrote was a temporary change in the code so I could check whether it > would work. Woops, I meant that unknown

r329836 - [CodeGen] Handle __func__ inside __finally

Author: smeenai Date: Wed Apr 11 11:17:35 2018 New Revision: 329836 URL: http://llvm.org/viewvc/llvm-project?rev=329836=rev Log: [CodeGen] Handle __func__ inside __finally When we enter a __finally block, the CGF's CurCodeDecl will be null (because CodeGenFunction::StartFunction is given an

[PATCH] D45532: [StaticAnalyzer] Checker to find uninitialized fields after a constructor call

NoQ added a comment. That's a lot of code, so it'll take me some time to understand what's going on here. You might be able to help me by the large patch in smaller logical chunks. The idea looks reasonable. We're having specific warnings for, eg., assigning an uninitialized value, which fire

[PATCH] D45523: [CodeGen] Handle __func__ inside __finally

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm, thanks! Comment at: test/CodeGen/exceptions-seh-finally.c:281 +// CHECK-LABEL: define internal void @"?fin$0@0@finally_with_func@@"({{[^)]*}}) +// CHECK: call void

r329829 - [NVPTX, CUDA] Improved feature constraints on NVPTX target builtins.

Author: tra Date: Wed Apr 11 10:51:19 2018 New Revision: 329829 URL: http://llvm.org/viewvc/llvm-project?rev=329829=rev Log: [NVPTX, CUDA] Improved feature constraints on NVPTX target builtins. When NVPTX TARGET_BUILTIN specifies sm_XX or ptxYY as required feature, consider those features

[PATCH] D45532: [StaticAnalyzer] Checker to find uninitialized fields after a constructor call

Szelethus updated this revision to Diff 142053. Szelethus added a comment. Reuploaded the diff with full context. https://reviews.llvm.org/D45532 Files: include/clang/StaticAnalyzer/Checkers/Checkers.td lib/StaticAnalyzer/Checkers/CMakeLists.txt

[PATCH] D45392: [clang-tidy] add new check to find out objc ivars which do not have prefix '_'

Wizard updated this revision to Diff 142057. Wizard added a comment. remove unnecessary flags Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D45392 Files: clang-tidy/readability/IdentifierNamingCheck.cpp test/clang-tidy/readability-identifier-naming-objc.m Index:

[PATCH] D45015: [Preprocessor] Allow libc++ to detect when aligned allocation is unavailable.

EricWF added a comment. In https://reviews.llvm.org/D45015#1064922, @vsapsai wrote: > Another approach is `__has_feature` but I don't think it is applicable in > this case. > > Is there a way right now to detect that aligned allocation is supported by > clang, regardless of link time? Asking

  1   2   >