[PATCH] D45891: [clang-tidy] Improve bugprone-unused-return-value check

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D45891 ___ cfe-commits mailing list

[PATCH] D45532: [StaticAnalyzer] Checker to find uninitialized fields after a constructor call

whisperity added a comment. @george.karpenkov @NoQ `bugprone.` as a category sounds nice. It also nicely corresponds to the Clang-Tidy `bugprone-` category. It would not be nice to further fragment the "top levels" of checker categories. I can say with confidence that CodeChecker does not

[PATCH] D45717: [clangd] Using index for GoToDefinition.

hokein updated this revision to Diff 143508. hokein marked 7 inline comments as done. hokein added a comment. Refine the patch and address all review comments. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D45717 Files: clangd/ClangdServer.cpp clangd/XRefs.cpp

[PATCH] D45717: [clangd] Using index for GoToDefinition.

hokein added a comment. I have updated the patch according to offline discussion -- for each symbol, we will return both decl and def locations (if available, def first) as they seems to be most sensible to users. We always prefer location from AST over Index when conflicts.

[PATCH] D45619: [Time-report] (1) Use special new Clang flag 'FrontendTimesIsEnabled' instead of 'llvm::TimePassesIsEnabled' inside -ftime-report feature

This revision was automatically updated to reflect the committed changes. Closed by commit rL330571: Use special new Clang flag FrontendTimesIsEnabled instead of llvm… (authored by avt77, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

r330571 - Use special new Clang flag 'FrontendTimesIsEnabled' instead of 'llvm::TimePassesIsEnabled' inside -ftime-report feature.

Author: avt77 Date: Mon Apr 23 02:22:30 2018 New Revision: 330571 URL: http://llvm.org/viewvc/llvm-project?rev=330571=rev Log: Use special new Clang flag 'FrontendTimesIsEnabled' instead of 'llvm::TimePassesIsEnabled' inside -ftime-report feature. Differential Revision:

[PATCH] D41240: [Solaris] __float128 is supported on Solaris/x86

This revision was automatically updated to reflect the committed changes. Closed by commit rL330572: [Solaris] __float128 is supported on Solaris/x86 (authored by ro, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

r330566 - [Atomics] warn about atomic accesses using libcalls

Author: tnorthover Date: Mon Apr 23 01:16:24 2018 New Revision: 330566 URL: http://llvm.org/viewvc/llvm-project?rev=330566=rev Log: [Atomics] warn about atomic accesses using libcalls If an atomic variable is misaligned (and that suspicion is why Clang emits libcalls at all) the runtime support

[PATCH] D45319: [Atomics] warn about misaligned atomic accesses using libcalls

t.p.northover closed this revision. t.p.northover added a comment. Ah, I see you approved it before, presumably with the suggested changes. I've committed as r330566. Repository: rC Clang https://reviews.llvm.org/D45319 ___ cfe-commits mailing

r330569 - Revert "[clang-format] Improve Incomplete detection for (text) protos"

Author: krasimir Date: Mon Apr 23 01:50:36 2018 New Revision: 330569 URL: http://llvm.org/viewvc/llvm-project?rev=330569=rev Log: Revert "[clang-format] Improve Incomplete detection for (text) protos" This reverts commit r330016. The incomplete detection has too many false positives, picking up

r330573 - Format closing braces when reformatting the line containing the opening brace.

Author: klimek Date: Mon Apr 23 02:34:26 2018 New Revision: 330573 URL: http://llvm.org/viewvc/llvm-project?rev=330573=rev Log: Format closing braces when reformatting the line containing the opening brace. This required a couple of yaks to be shaved: 1. MatchingOpeningBlockLineIndex was misused

[PATCH] D45726: Format closing braces when reformatting the line containing theopening brace.

This revision was automatically updated to reflect the committed changes. Closed by commit rL330573: Format closing braces when reformatting the line containing the opening brace. (authored by klimek, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM

[PATCH] D45177: CStringChecker, check strlcpy/strlcat

devnexen added a comment. If anybody can land for me, I would appreciate. Thanks regardless :-) Repository: rC Clang https://reviews.llvm.org/D45177 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D45319: [Atomics] warn about misaligned atomic accesses using libcalls

t.p.northover updated this revision to Diff 143506. t.p.northover added a comment. Moved diagnostic emission next to where the decision is made. Repository: rC Clang https://reviews.llvm.org/D45319 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td clang/lib/CodeGen/CGAtomic.cpp

[PATCH] D45835: Add new driver mode for dumping compiler options

aaron.ballman added a comment. In https://reviews.llvm.org/D45835#1073883, @efriedma wrote: > > If any of those options we care about wind up being changed, there's a good > > chance we may need to change something on our end anyway, so breaking us is > > actually useful. > > I'm not sure I

[PATCH] D45873: [OpenCL] Reject virtual functions for OpenCL C++

This revision was automatically updated to reflect the committed changes. Closed by commit rC330579: [OpenCL] Reject virtual functions for OpenCL C++ (authored by svenvh, committed by ). Changed prior to commit: https://reviews.llvm.org/D45873?vs=143330=143524#toc Repository: rC Clang

[PATCH] D41240: [Solaris] __float128 is supported on Solaris/x86

krytarowski added subscribers: joerg, krytarowski. krytarowski added a comment. Does it work for you for 32-bit? @joerg opposed adoption of 32-bit version as it seemed to be unimplemented.. Repository: rL LLVM https://reviews.llvm.org/D41240

[PATCH] D45619: [Time-report] (1) Use special new Clang flag 'FrontendTimesIsEnabled' instead of 'llvm::TimePassesIsEnabled' inside -ftime-report feature

avt77 reopened this revision. avt77 added a comment. This revision is now accepted and ready to land. It's terrible but my new test was failed again as result of commit of this patch!

r330589 - [analyzer] CStringChecker.cpp - Code refactoring on bug report.

Author: henrywong Date: Mon Apr 23 06:36:51 2018 New Revision: 330589 URL: http://llvm.org/viewvc/llvm-project?rev=330589=rev Log: [analyzer] CStringChecker.cpp - Code refactoring on bug report. Reviewers: NoQ, george.karpenkov, xazax.hun Reviewed By: george.karpenkov Differential Revision:

[PATCH] D44557: [analyzer] CStringChecker.cpp - Code refactoring on bug report.

This revision was automatically updated to reflect the committed changes. Closed by commit rC330589: [analyzer] CStringChecker.cpp - Code refactoring on bug report. (authored by henrywong, committed by ). Changed prior to commit: https://reviews.llvm.org/D44557?vs=138682=143545#toc

[PATCH] D45944: Disallow pointers to const in __sync_fetch_and_xxx

aaron.ballman added a comment. In https://reviews.llvm.org/D45944#1075055, @lebedev.ri wrote: > Please always upload all patches with full context (`-U9`) I'm not keen on uploading patches with that much context. For instance, it disables syntax highlighting in Phab for many of our files.

[PATCH] D45944: Disallow pointers to const in __sync_fetch_and_xxx

aaron.ballman updated this revision to Diff 143526. aaron.ballman added a comment. Updated with more context. https://reviews.llvm.org/D45944 Files: include/clang/Basic/DiagnosticSemaKinds.td lib/Sema/SemaChecking.cpp test/Sema/builtins.c Index: test/Sema/builtins.c

r330575 - [CodeGen] Reland r330442: Add an option to suppress output of llvm.ident

Author: miyuki Date: Mon Apr 23 03:08:46 2018 New Revision: 330575 URL: http://llvm.org/viewvc/llvm-project?rev=330575=rev Log: [CodeGen] Reland r330442: Add an option to suppress output of llvm.ident The test case in the original patch was overly contrained and failed on PPC targets. Added:

r330572 - [Solaris] __float128 is supported on Solaris/x86

Author: ro Date: Mon Apr 23 02:28:08 2018 New Revision: 330572 URL: http://llvm.org/viewvc/llvm-project?rev=330572=rev Log: [Solaris] __float128 is supported on Solaris/x86 When rebasing https://reviews.llvm.org/D40898 with GCC 5.4 on Solaris 11.4, I ran into a few instances of In file

r330574 - [clang-format] Fix clang-tidy readability problems, NFCI

Author: krasimir Date: Mon Apr 23 03:02:59 2018 New Revision: 330574 URL: http://llvm.org/viewvc/llvm-project?rev=330574=rev Log: [clang-format] Fix clang-tidy readability problems, NFCI Modified: cfe/trunk/lib/Format/BreakableToken.h cfe/trunk/lib/Format/NamespaceEndCommentsFixer.cpp

[PATCH] D44932: [CodeComplete] Fix completion in the middle of ident in ctor lists.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, modulo a tiny commenting nit. Comment at: lib/Lex/Lexer.cpp:1667 + // Note that code completion token is not added as a separate character + //

[PATCH] D45050: [clang-tidy] New checker for not null-terminated result caused by strlen or wcslen

aaron.ballman added inline comments. Comment at: clang-tidy/bugprone/NotNullTerminatedResultCheck.cpp:226 +DiagnosticBuilder ) { + if (getLangOpts().CPlusPlus11) { +StringRef NewFuncName = (Name[0] != 'w') ? "strncpy_s" : "wcsncpy_s"; Charusso wrote: >

[PATCH] D45944: Disallow pointers to const in __sync_fetch_and_xxx

lebedev.ri added a comment. Please always upload all patches with full context (`-U9`) https://reviews.llvm.org/D45944 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D45944: Disallow pointers to const in __sync_fetch_and_xxx

aaron.ballman created this revision. aaron.ballman added reviewers: rsmith, dblaikie. The following code is currently accepted without a diagnostic when it should be prohibited: void f(const int *ptr) { __sync_fetch_and_add(ptr, 1); } NB: the above code is diagnosed by GCC and ICC.

r330579 - [OpenCL] Reject virtual functions for OpenCL C++

Author: svenvh Date: Mon Apr 23 04:23:47 2018 New Revision: 330579 URL: http://llvm.org/viewvc/llvm-project?rev=330579=rev Log: [OpenCL] Reject virtual functions for OpenCL C++ Differential Revision: https://reviews.llvm.org/D45873 Added: cfe/trunk/test/Parser/opencl-cxx-virtual.cl

[clang-tools-extra] r330580 - Fix tests after changes to clang-format in r330573.

Author: klimek Date: Mon Apr 23 04:47:59 2018 New Revision: 330580 URL: http://llvm.org/viewvc/llvm-project?rev=330580=rev Log: Fix tests after changes to clang-format in r330573. We do now both: - stop reformatting a sequence after a closing brace in more cases, in order to not misindent

Re: [PATCH] D45619: [Time-report] (1) Use special new Clang flag 'FrontendTimesIsEnabled' instead of 'llvm::TimePassesIsEnabled' inside -ftime-report feature

In any case, when you see a test failing on bots and the fix isn't obvious, revert first to get the bots back green. On Mon, Apr 23, 2018 at 8:54 AM, Andrew V. Tischenko via Phabricator via cfe-commits wrote: > avt77 reopened this revision. > avt77 added a comment. >

[PATCH] D45717: [clangd] Using index for GoToDefinition.

sammccall added a comment. Thanks for the changes! I still find the logic quite confusing. Happy to chat offline if useful. Comment at: clangd/XRefs.cpp:137 + +IdentifiedSymbol getSymbolAtPosition(ParsedAST , SourceLocation Pos) { + auto DeclMacrosFinder = std::make_shared(

[PATCH] D45505: [GCC] Match a GCC version with a patch suffix without a third version component

mstorsjo updated this revision to Diff 143558. mstorsjo retitled this revision from "[WIP] [GCC] Match a GCC version with a patch suffix without a third version component" to "[GCC] Match a GCC version with a patch suffix without a third version component". mstorsjo edited the summary of this

[PATCH] D45619: [Time-report] (1) Use special new Clang flag 'FrontendTimesIsEnabled' instead of 'llvm::TimePassesIsEnabled' inside -ftime-report feature

avt77 added a comment. In https://reviews.llvm.org/D45619#1075385, @bjope wrote: > Anyway, if the order isn't deteministic, then a solution could be to use > CHECK-DAG instead of CHECK for the checks that may be reordered. For example: Thank you very much! I'll try to fix it in this way.

[PATCH] D44079: [ASTImporter] Allow testing of import sequences; fix import of typedefs for anonymous decls

a.sidorin marked 2 inline comments as done. a.sidorin added a comment. Thank you Gabor! Comment at: unittests/AST/ASTImporterTest.cpp:356 + ImportAction(StringRef FromFilename, StringRef ToFilename, + const std::string ) + : FromFilename(FromFilename),

[PATCH] D45964: [Driver] Fix implicit config files from prefixed symlinks

mstorsjo created this revision. mstorsjo added reviewers: sepavloff, hfinkel, hans, rnk. If -no-canonical-prefixes isn't used, the clang executable name used is the one of the actual executable, not the name of the symlink that the user invoked. In these cases, the target prefix was overridden

[PATCH] D45619: [Time-report] (1) Use special new Clang flag 'FrontendTimesIsEnabled' instead of 'llvm::TimePassesIsEnabled' inside -ftime-report feature

bjope added a comment. In https://reviews.llvm.org/D45619#1075089, @avt77 wrote: > It's terrible but my new test was failed again as result of commit of this > patch! > > ///b/sanitizer-x86_64-linux-bootstrap/build/llvm/tools/clang/test/Frontend/ftime-report-template-decl.cpp:155:11: > error:

[PATCH] D45965: [Targets] Implement getConstraintRegister for ARM and AArch64

miyuki created this revision. miyuki added a reviewer: eli.friedman. Herald added subscribers: chrib, kristof.beyls, eraman, rengolin. Herald added a reviewer: javed.absar. The getConstraintRegister method is used by semantic checking of inline assembly statements in order to diagnose conflicts

[PATCH] D30882: Add a callback for __has_include and use it for dependency scanning

ddunbar added a comment. In https://reviews.llvm.org/D30882#1074822, @dexonsmith wrote: > I don't think this is quite right. I know at least `make`-based incremental > builds wouldn't deal well with this. This is actually not a novel problem w.r.t. this patch. The exact same situation comes

[PATCH] D45619: [Time-report] (1) Use special new Clang flag 'FrontendTimesIsEnabled' instead of 'llvm::TimePassesIsEnabled' inside -ftime-report feature

avt77 added a comment. In https://reviews.llvm.org/D45619#1075260, @thakis wrote: > In any case, when you see a test failing on bots and the fix isn't obvious, > revert first to get the bots back green. I reverted it immediatly. Repository: rL LLVM https://reviews.llvm.org/D45619

[PATCH] D45619: [Time-report] (1) Use special new Clang flag 'FrontendTimesIsEnabled' instead of 'llvm::TimePassesIsEnabled' inside -ftime-report feature

bjope added a comment. I can't see that it has been reverted. But I guess that the table maybe is sorted based on time spent in each pass? So that is why it might be sorted differently on different buildbots (or when using pipe etc). So I think a quick fix is to add -DAG to the checks that can

r330595 - [index] Fix methods that take a shared_ptr to just take a reference.

Author: d0k Date: Mon Apr 23 07:30:21 2018 New Revision: 330595 URL: http://llvm.org/viewvc/llvm-project?rev=330595=rev Log: [index] Fix methods that take a shared_ptr to just take a reference. There is no ownership here, passing a shared_ptr just adds confusion. No functionality change

[clang-tools-extra] r330595 - [index] Fix methods that take a shared_ptr to just take a reference.

Author: d0k Date: Mon Apr 23 07:30:21 2018 New Revision: 330595 URL: http://llvm.org/viewvc/llvm-project?rev=330595=rev Log: [index] Fix methods that take a shared_ptr to just take a reference. There is no ownership here, passing a shared_ptr just adds confusion. No functionality change

[PATCH] D45682: [analyzer] Move `TaintBugVisitor` from `GenericTaintChecker.cpp` to `BugReporterVisitors.h`.

This revision was automatically updated to reflect the committed changes. Closed by commit rC330596: [analyzer] Move `TaintBugVisitor` from `GenericTaintChecker.cpp` to… (authored by henrywong, committed by ). Changed prior to commit: https://reviews.llvm.org/D45682?vs=142621=143561#toc

r330596 - [analyzer] Move `TaintBugVisitor` from `GenericTaintChecker.cpp` to `BugReporterVisitors.h`.

Author: henrywong Date: Mon Apr 23 07:41:17 2018 New Revision: 330596 URL: http://llvm.org/viewvc/llvm-project?rev=330596=rev Log: [analyzer] Move `TaintBugVisitor` from `GenericTaintChecker.cpp` to `BugReporterVisitors.h`. Summary: `TaintBugVisitor` is a universal visitor, and many checkers

[PATCH] D45966: Remove LLVM_INSTALL_CCTOOLS_SYMLINKS

thakis created this revision. thakis added a reviewer: JDevlieghere. Herald added a subscriber: mgorny. It used to symlink `dsymutil` to `llvm-dsymutil`, but after r327790 llvm's dsymutil binary is now called dsymutil without prefix. r327792 then reversed the direction of the symlink if

[clang-tools-extra] r330599 - [clangd] Prune some dead declarations. No functionality change.

Author: d0k Date: Mon Apr 23 07:58:18 2018 New Revision: 330599 URL: http://llvm.org/viewvc/llvm-project?rev=330599=rev Log: [clangd] Prune some dead declarations. No functionality change. Modified: clang-tools-extra/trunk/clangd/Diagnostics.h clang-tools-extra/trunk/clangd/Trace.h

[PATCH] D41537: Optionally add code completion results for arrow instead of dot

yvvan updated this revision to Diff 143566. yvvan added a comment. Use wrapped FixItHint to keep corrections. Can be quite easily changed from Optional to some container if required. https://reviews.llvm.org/D41537 Files: include/clang-c/Index.h include/clang/Basic/DiagnosticSemaKinds.td

[PATCH] D41537: Optionally add code completion results for arrow instead of dot

yvvan updated this revision to Diff 143572. yvvan added a comment. Use vector instead of optional as Ilya suggested https://reviews.llvm.org/D41537 Files: include/clang-c/Index.h include/clang/Basic/DiagnosticSemaKinds.td include/clang/Sema/CodeCompleteConsumer.h

[PATCH] D45619: [Time-report] (1) Use special new Clang flag 'FrontendTimesIsEnabled' instead of 'llvm::TimePassesIsEnabled' inside -ftime-report feature

avt77 added a comment. In https://reviews.llvm.org/D45619#1075437, @bjope wrote: > I can't see that it has been reverted. > But I guess that the table maybe is sorted based on time spent in each pass? > So that is why it might be sorted differently on different buildbots (or when > using pipe

[PATCH] D45284: [RISCV] More validations on the input value of -march=

asb added a comment. In https://reviews.llvm.org/D45284#1074282, @apazos wrote: > Hi Alex, it seems the table expects these extensions in a canonical order > too: all x extensions, followed by all s extensions, and then all sx > extensions. > > I can make the change, no problem. I have also

[clang-tools-extra] r330608 - [clangd][tests] Fix handling of EOF in delimited input

Author: jkorous Date: Mon Apr 23 08:55:07 2018 New Revision: 330608 URL: http://llvm.org/viewvc/llvm-project?rev=330608=rev Log: [clangd][tests] Fix handling of EOF in delimited input Request in delimited input ended by EOF shouldn't be an error state. Comments at the end of test file shouldn't

[PATCH] D45763: [clangd][tests] Fix handling of EOF in delimited input

jkorous closed this revision. jkorous added a comment. I forgot to mention review in commit message. git-svn-id: https://llvm.org/svn/llvm-project/clang-tools-extra/trunk@330608 91177308-0d34-0410-b5e6-96231b3b80d8 https://reviews.llvm.org/D45763

r330605 - [analyzer] Don't crash on printing ConcreteInt of size >64 bits

Author: a.sidorin Date: Mon Apr 23 08:41:44 2018 New Revision: 330605 URL: http://llvm.org/viewvc/llvm-project?rev=330605=rev Log: [analyzer] Don't crash on printing ConcreteInt of size >64 bits Printing of ConcreteInts with size >64 bits resulted in assertion failure in get[Z|S]ExtValue()

r330613 - Quick fix for rC330605: specify a target arch for test

Author: a.sidorin Date: Mon Apr 23 09:38:29 2018 New Revision: 330613 URL: http://llvm.org/viewvc/llvm-project?rev=330613=rev Log: Quick fix for rC330605: specify a target arch for test Modified: cfe/trunk/test/Analysis/sval-dump-int128.c Modified:

[PATCH] D30882: Add a callback for __has_include and use it for dependency scanning

dexonsmith added a comment. In https://reviews.llvm.org/D30882#1075407, @ddunbar wrote: > In https://reviews.llvm.org/D30882#1074822, @dexonsmith wrote: > > > I don't think this is quite right. I know at least `make`-based > > incremental builds wouldn't deal well with this. > > > This is

r330601 - Remove unused code (made unused by r161073, and later more so by r248043).

Author: nico Date: Mon Apr 23 08:26:15 2018 New Revision: 330601 URL: http://llvm.org/viewvc/llvm-project?rev=330601=rev Log: Remove unused code (made unused by r161073, and later more so by r248043). Modified: cfe/trunk/tools/diagtool/CMakeLists.txt Modified:

[clang-tools-extra] r330602 - [clangd] Fix Context::derive to actually call the right method.

Author: d0k Date: Mon Apr 23 08:27:42 2018 New Revision: 330602 URL: http://llvm.org/viewvc/llvm-project?rev=330602=rev Log: [clangd] Fix Context::derive to actually call the right method. C++ is weird. Modified: clang-tools-extra/trunk/clangd/Context.h Modified:

r330604 - Fix case of LLVM library names.

Author: nico Date: Mon Apr 23 08:41:08 2018 New Revision: 330604 URL: http://llvm.org/viewvc/llvm-project?rev=330604=rev Log: Fix case of LLVM library names. Modified: cfe/trunk/tools/clang-import-test/CMakeLists.txt Modified: cfe/trunk/tools/clang-import-test/CMakeLists.txt URL:

[PATCH] D45417: [analyzer] Don't crash on printing ConcreteInt of size >64 bits

a.sidorin closed this revision. a.sidorin added a comment. Closed with https://reviews.llvm.org/rC330605. Forgot to mention the Differential Revision, sorry. Repository: rC Clang https://reviews.llvm.org/D45417 ___ cfe-commits mailing list

[PATCH] D45764: [clangd][tests] Fix delimiter handling

This revision was automatically updated to reflect the committed changes. Closed by commit rL330609: [clangd][tests] Fix delimiter handling (authored by jkorous, committed by ). Herald added subscribers: llvm-commits, klimek. Changed prior to commit:

[clang-tools-extra] r330609 - [clangd][tests] Fix delimiter handling

Author: jkorous Date: Mon Apr 23 08:58:42 2018 New Revision: 330609 URL: http://llvm.org/viewvc/llvm-project?rev=330609=rev Log: [clangd][tests] Fix delimiter handling Empty line shouldn't be considered a delimiter Differential Revision: https://reviews.llvm.org/D45764 Added:

[PATCH] D45965: [Targets] Implement getConstraintRegister for ARM and AArch64

thopre added inline comments. Comment at: lib/Basic/Targets/AArch64.h:85-89 + StringRef getConstraintRegister(StringRef Constraint, + StringRef Expression) const override { +return Expression; + } + From what I understood

[PATCH] D45715: [libcxx] [test] Remove nonportable that errc::is_a_directory produces "Is a directory" from ios_base::failure tests

mclow.lists added a comment. I'm fine with this change, but I'm wondering: - if there are similar tests in the filesystem test suite, and you haven't tripped over them because you spelled your error message the same as we did. - Should part of this test be moved into test/libcxx

[PATCH] D41148: [libcxx] implement declarations based on P0214R7.

mclow.lists accepted this revision. mclow.lists added a comment. This revision is now accepted and ready to land. Herald added a subscriber: bixia. This looks ready to land to me. Comment at: libcxx/test/std/experimental/simd/simd.traits/is_simd_mask.pass.cpp:122

[PATCH] D45451: [ItaniumMangle] Undeduced auto type doesn't belong in the substitution table

rjmccall added inline comments. Comment at: clang/lib/AST/ItaniumMangle.cpp:2342 + if (isa(Ty)) +return false; return true; erik.pilkington wrote: > rjmccall wrote: > > rjmccall wrote: > > > rjmccall wrote: > > > > I agree with your analysis that this

[PATCH] D45619: [Time-report] (1) Use special new Clang flag 'FrontendTimesIsEnabled' instead of 'llvm::TimePassesIsEnabled' inside -ftime-report feature

bjope added a comment. buildbots have been failing all day (and were still failing). So I pushed my suggested fix. I hope that was OK. Repository: rL LLVM https://reviews.llvm.org/D45619 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D30882: Add a callback for __has_include and use it for dependency scanning

dexonsmith added a comment. In https://reviews.llvm.org/D30882#1075589, @dexonsmith wrote: > In https://reviews.llvm.org/D30882#1075576, @pete wrote: > > > Would it be ok to turn this on by default, without a flag, only in the case > > of the path actually existing, and only the found path

[PATCH] D30882: Add a callback for __has_include and use it for dependency scanning

dexonsmith added a comment. In https://reviews.llvm.org/D30882#1075576, @pete wrote: > Oh, that actually wasn't my intention when I wrote it. > > Honestly I didn't expect it to log anything for missing paths at all, as we > don't currently log all the missing (but attempted) paths for regular

[PATCH] D45722: [X86] Lowering SAD (sum of absolute differences) intrinsics to native IR (clang side)

craig.topper added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:8426 + llvm::Type *BTy = llvm::VectorType::get(CGF.Builder.getInt8Ty(), N * 8); + SmallVector ShuffleMask; + for (unsigned i = 0; i < N; ++i) Size the ShuffleMask to

r330620 - [OPENMP] Do not cast captured by value variables with pointer types in

Author: abataev Date: Mon Apr 23 10:33:41 2018 New Revision: 330620 URL: http://llvm.org/viewvc/llvm-project?rev=330620=rev Log: [OPENMP] Do not cast captured by value variables with pointer types in NVPTX target. When generating the wrapper function for the offloading region, we need to call

[PATCH] D45917: Pass -Oz/-Os along to the backend

paquette updated this revision to Diff 143584. paquette added a comment. Add context to diff. https://reviews.llvm.org/D45917 Files: lib/CodeGen/BackendUtil.cpp test/CodeGen/arm64-outline.c Index: test/CodeGen/arm64-outline.c

[PATCH] D30882: Add a callback for __has_include and use it for dependency scanning

pete added a comment. In https://reviews.llvm.org/D30882#1075461, @dexonsmith wrote: > In https://reviews.llvm.org/D30882#1075407, @ddunbar wrote: > > > In https://reviews.llvm.org/D30882#1074822, @dexonsmith wrote: > > > > > I don't think this is quite right. I know at least `make`-based > >

[PATCH] D45722: [X86] Lowering SAD (sum of absolute differences) intrinsics to native IR (clang side)

craig.topper added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:8431 + CGF.Builder.CreateZExt(CGF.Builder.CreateShuffleVector( + AD, llvm::UndefValue::get(BTy), ShuffleMask), + VTy);

[PATCH] D45996: [HWASan] Update HWASan assembly snippet in the docs

alekseyshl created this revision. alekseyshl added a reviewer: eugenis. To complement https://reviews.llvm.org/D45840 Repository: rC Clang https://reviews.llvm.org/D45996 Files: docs/HardwareAssistedAddressSanitizerDesign.rst Index: docs/HardwareAssistedAddressSanitizerDesign.rst

[PATCH] D45920: [analyzer] Move RangeSet related declarations into the RangedConstraintManager header.

NoQ added a comment. In https://reviews.llvm.org/D45920#1074439, @george.karpenkov wrote: > Another approach would be to instead teach `RangedConstraintManager` to > convert it's constraints to Z3. That would be an unwanted dependency, but the > change would be much smaller, and the internals

[PATCH] D45766: [Sema] Add -Wno-self-assign-overloaded

lebedev.ri added inline comments. Comment at: lib/Sema/SemaExpr.cpp:11527-11528 - S.Diag(OpLoc, diag::warn_self_assignment) - << LHSDeclRef->getType() - << LHSExpr->getSourceRange() << RHSExpr->getSourceRange(); + S.Diag(OpLoc, IsBuiltin ?

[PATCH] D45766: [Sema] Add -Wno-self-assign-overloaded

This revision was automatically updated to reflect the committed changes. Closed by commit rL330651: [Sema] Add -Wno-self-assign-overloaded (authored by lebedevri, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D45766: [Sema] Add -Wno-self-assign-overloaded

lebedev.ri added inline comments. Comment at: lib/Sema/SemaExpr.cpp:11527-11528 - S.Diag(OpLoc, diag::warn_self_assignment) - << LHSDeclRef->getType() - << LHSExpr->getSourceRange() << RHSExpr->getSourceRange(); + S.Diag(OpLoc, IsBuiltin ?

[libcxx] r330655 - Re-commit r330627 "[libcxx] implement declarations based on P0214R7."

Author: timshen Date: Mon Apr 23 14:54:06 2018 New Revision: 330655 URL: http://llvm.org/viewvc/llvm-project?rev=330655=rev Log: Re-commit r330627 "[libcxx] implement declarations based on P0214R7." There are 3 changes: * Renamed genertor.pass.cpp to generator.pass.cpp * Removed

[PATCH] D45932: [clang-tidy][modernize-raw-string-literal] Don't replace upper ASCII with raw literals

LegalizeAdulthood added inline comments. Comment at: test/clang-tidy/modernize-raw-string-literal.cpp:44 +char const *const MultibyteSnowman("\xE2\x98\x83"); +// CHECK-FIXES: {{^}}char const *const MultibyteSnowman("\xE2\x98\x83");{{$}} IIRC, the default

[libcxx] r330636 - Revert "[libcxx] implement declarations based on P0214R7."

Author: timshen Date: Mon Apr 23 12:56:20 2018 New Revision: 330636 URL: http://llvm.org/viewvc/llvm-project?rev=330636=rev Log: Revert "[libcxx] implement declarations based on P0214R7." This reverts commit r330627. This causes several bots to freak out. Removed:

[PATCH] D45015: [Preprocessor] Allow libc++ to detect when aligned allocation is unavailable.

vsapsai added a comment. In https://reviews.llvm.org/D45015#1064930, @EricWF wrote: > In https://reviews.llvm.org/D45015#1064922, @vsapsai wrote: > > > Another approach is `__has_feature` but I don't think it is applicable in > > this case. > > > > Is there a way right now to detect that

[PATCH] D45382: [CodeGen] Avoid destructing a struct type that has already been destructed by a delegated constructor

rsmith added a comment. In https://reviews.llvm.org/D45382#1060452, @ahatanak wrote: > In https://reviews.llvm.org/D45382#1060163, @rjmccall wrote: > > > Hmm. I'm not actually sure *why* it's not okay to forward callee-cleanup > > arguments. Do we just not have the necessary logic to disable

[PATCH] D44387: [x86] Introduce the pconfig/encl[u|s|v] intrinsics

GBuella updated this revision to Diff 143639. GBuella added a comment. Rebased the patch. Added pconfig to Icelake Server. https://reviews.llvm.org/D44387 Files: include/clang/Basic/BuiltinsX86.def include/clang/Driver/Options.td lib/Basic/Targets/X86.cpp lib/Basic/Targets/X86.h

[PATCH] D45984: [X86] directstore and movdir64b intrinsics

craig.topper added inline comments. Comment at: docs/ClangCommandLineReference.rst:2465 +.. option:: -mmovdiri, -mno-movdiri + Please alphabetize this correctly. Comment at: include/clang/Basic/BuiltinsX86.def:1896

[PATCH] D45984: [X86] directstore and movdir64b intrinsics

GBuella updated this revision to Diff 143647. https://reviews.llvm.org/D45984 Files: docs/ClangCommandLineReference.rst include/clang/Basic/BuiltinsX86.def include/clang/Basic/BuiltinsX86_64.def include/clang/Driver/Options.td lib/Basic/Targets/X86.cpp lib/Basic/Targets/X86.h

r330633 - Fix typo in comment.

Author: nico Date: Mon Apr 23 12:22:52 2018 New Revision: 330633 URL: http://llvm.org/viewvc/llvm-project?rev=330633=rev Log: Fix typo in comment. Modified: cfe/trunk/tools/libclang/CMakeLists.txt Modified: cfe/trunk/tools/libclang/CMakeLists.txt URL:

r330634 - [OPENMP] Formatting and code improvement, NFC.

Author: abataev Date: Mon Apr 23 12:53:05 2018 New Revision: 330634 URL: http://llvm.org/viewvc/llvm-project?rev=330634=rev Log: [OPENMP] Formatting and code improvement, NFC. Modified: cfe/trunk/lib/Parse/ParseOpenMP.cpp Modified: cfe/trunk/lib/Parse/ParseOpenMP.cpp URL:

r330654 - [Docs] Regenerate command line documentation.

Author: ctopper Date: Mon Apr 23 14:41:06 2018 New Revision: 330654 URL: http://llvm.org/viewvc/llvm-project?rev=330654=rev Log: [Docs] Regenerate command line documentation. Modified: cfe/trunk/docs/ClangCommandLineReference.rst Modified: cfe/trunk/docs/ClangCommandLineReference.rst URL:

[PATCH] D44609: [Clang-Format] New option BreakBeforeLambdaBody to manage lambda line break inside function parameter call

Wawha added a comment. Hi djasper, Here a project where there is lambda and allman style for them : https://github.com/boostorg/hof/blob/develop/example/in.cpp https://github.com/boostorg/hof/blob/develop/example/sequence.cpp Example of code: // Function to find an iterator using a

[PATCH] D45766: [Sema] Add -Wno-self-assign-overloaded

rjmccall added a comment. In https://reviews.llvm.org/D45766#1076176, @dblaikie wrote: > Is there anything else in the "-w" namespace other than the literal "-w" so > far? No. This would be novel. > I mean, I could imagine it might make more sense to default these warnings > off & users can

[PATCH] D45517: [analyzer] WIP: False positive refutation with Z3

NoQ added a comment. In https://reviews.llvm.org/D45517#1074422, @rnkovacs wrote: > In https://reviews.llvm.org/D45517#1074057, @NoQ wrote: > > > So, yeah, that's a good optimization that we're not invoking the solver on > > every node. But i don't think we should focus on improving this > >

Re: [PATCH] D45619: [Time-report] (1) Use special new Clang flag 'FrontendTimesIsEnabled' instead of 'llvm::TimePassesIsEnabled' inside -ftime-report feature

On Mon, Apr 23, 2018 at 11:53 AM, Andrew V. Tischenko via Phabricator via cfe-commits wrote: > avt77 added a comment. > > In https://reviews.llvm.org/D45619#1075437, @bjope wrote: > > > I can't see that it has been reverted. > > But I guess that the table maybe is

[PATCH] D45839: [analyzer] Add support for WebKit "unified sources".

NoQ marked 2 inline comments as done. NoQ added inline comments. Comment at: include/clang/StaticAnalyzer/Core/PathSensitive/AnalysisManager.h:145-147 + if (Name.endswith_lower(".c") || Name.endswith_lower(".cpp") || + Name.endswith_lower(".cc") ||

[PATCH] D44882: [clangd] Implementation of workspace/symbol request

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE330637: [clangd] Implementation of workspace/symbol request (authored by malaperle, committed by ). Changed prior to commit: https://reviews.llvm.org/D44882?vs=143220=143626#toc Repository: rCTE

[PATCH] D45766: [Sema] Add -Wno-self-assign-overloaded

dblaikie accepted this revision. dblaikie added inline comments. This revision is now accepted and ready to land. Comment at: lib/Sema/SemaExpr.cpp:11527-11528 - S.Diag(OpLoc, diag::warn_self_assignment) - << LHSDeclRef->getType() - << LHSExpr->getSourceRange() <<

[PATCH] D45984: [X86] directstore and movdir64b intrinsics

GBuella created this revision. GBuella added a reviewer: craig.topper. Herald added subscribers: cfe-commits, mgorny. Repository: rC Clang https://reviews.llvm.org/D45984 Files: docs/ClangCommandLineReference.rst include/clang/Basic/BuiltinsX86.def include/clang/Driver/Options.td

[PATCH] D45984: [X86] directstore and movdir64b intrinsics

GBuella updated this revision to Diff 143642. https://reviews.llvm.org/D45984 Files: docs/ClangCommandLineReference.rst include/clang/Basic/BuiltinsX86.def include/clang/Basic/BuiltinsX86_64.def include/clang/Driver/Options.td lib/Basic/Targets/X86.cpp lib/Basic/Targets/X86.h

  1   2   >