r331620 - Non-zero-length bit-fields make a class non-empty.

Author: rsmith Date: Sun May 6 23:43:30 2018 New Revision: 331620 URL: http://llvm.org/viewvc/llvm-project?rev=331620=rev Log: Non-zero-length bit-fields make a class non-empty. This implements the rule intended by the standard (see LWG 2358) and the rule intended by the Itanium C++ ABI (see

r331621 - Remove now-unnecessary check for non-zero nvsize in addition to

Author: rsmith Date: Sun May 6 23:43:31 2018 New Revision: 331621 URL: http://llvm.org/viewvc/llvm-project?rev=331621=rev Log: Remove now-unnecessary check for non-zero nvsize in addition to emptyness in MS record layout. Modified: cfe/trunk/lib/AST/RecordLayoutBuilder.cpp Modified:

[PATCH] D46504: [clang-tidy] Profile is a per-AST (per-TU) data.

lebedev.ri added inline comments. Comment at: clang-tidy/ClangTidyDiagnosticConsumer.cpp:181 std::unique_ptr OptionsProvider) -: DiagEngine(nullptr), OptionsProvider(std::move(OptionsProvider)), - Profile(nullptr) { +: DiagEngine(nullptr),

[PATCH] D40481: [libclang] Fix cursors for arguments of Subscript and Call operators

nik added a comment. Ping. https://reviews.llvm.org/D40481 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D45174: non-zero-length bit-fields should make a class non-empty

This revision was automatically updated to reflect the committed changes. Closed by commit rL331620: Non-zero-length bit-fields make a class non-empty. (authored by rsmith, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D46050: [Frontend] Avoid running plugins during code completion parse

nik marked an inline comment as done. nik added inline comments. Comment at: test/Frontend/plugins.c:8 +// RUN: c-index-test -code-completion-at=%s:6:1 -load %llvmshlibdir/PrintFunctionNames%pluginext -add-plugin print-fns %s | FileCheck

[PATCH] D46050: [Frontend] Avoid running plugins during code completion parse

nik updated this revision to Diff 145430. nik added a comment. Moved the test to "Index". https://reviews.llvm.org/D46050 Files: lib/Frontend/FrontendAction.cpp test/Index/complete-and-plugins.c Index: test/Index/complete-and-plugins.c

[PATCH] D44435: CUDA ctor/dtor Module-Unique Symbol Name

SimeonEhrig added a comment. In https://reviews.llvm.org/D44435#1088019, @tra wrote: > Perhaps we should take a step back and consider whether this is the right > approach to solve your problem. > > If I understand it correctly, the real issue is that you repeatedly recompile > the same module

[PATCH] D46450: [Driver] Add mips_Features_Group to Options to improve documentation sorting

vdelvecc added a comment. In https://reviews.llvm.org/D46450#1089105, @atanasyan wrote: > LGTM > > Do you have commit access? Nope. Would you commit it please? Thanks much! Repository: rC Clang https://reviews.llvm.org/D46450 ___

[PATCH] D46176: Add SourceManagerForFile helper which sets up SourceManager and dependencies for a single file with code snippet

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: include/clang/Basic/SourceManager.h:1819 +/// SourceManager and necessary depdencies (e.g. VFS, FileManager) for a single +/// file. +class

?????? If I want to disable certain attributes, such as"swiftcall",isthereany way to do it now?

hi, Aaron I may found a useful example. For example, I tested the alias attribute on my own Apple laptop (Target: x86_64-apple-darwin17.5.0). First, I use __has_attribute to test that the alias is usable or not. The test code is as follows: #include void print() { #if

[PATCH] D33537: [clang-tidy] Exception Escape Checker

lebedev.ri added inline comments. Comment at: test/clang-tidy/bugprone-exception-escape.cpp:178 +void indirect_implicit() noexcept { + // CHECK-MESSAGES: :[[@LINE-1]]:6: warning: function 'indirect_implicit' throws + implicit_int_thrower(); baloghadamsoftware

[PATCH] D46241: [CodeGen] Recognize more cases of zero initialization

sepavloff updated this revision to Diff 145445. sepavloff marked an inline comment as done. sepavloff added a comment. Avoid redundant initializer calculation Repository: rC Clang https://reviews.llvm.org/D46241 Files: include/clang/AST/Expr.h lib/AST/ExprConstant.cpp

[PATCH] D46520: [Driver] Use -fuse-line-directives by default in MSVC mode

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. Seems reasonable to me (but please update the comment before landing). Comment at: lib/Driver/ToolChains/Clang.cpp:4218 // -fno-use-line-directives is default. if

[PATCH] D38455: [clang-tidy] new cppcoreguidelines-narrowing-conversions check.

courbet added a comment. @aaron.ballman Ping Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D38455 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D46519: [clang-format] Respect BreakBeforeClosingBrace while calculating length

krasimir created this revision. Herald added subscribers: cfe-commits, klimek. This patch makes `getLengthToMatchingParen` respect the `BreakBeforeClosingBrace` ParenState for matching scope closers. In order to distinguish between paren states introduced by real vs. fake parens, I've added the

Re: If I want to disable certain attributes, such as"swiftcall", isthereany way to do it now?

On Mon, May 7, 2018 at 5:48 AM, 朴素 <772847...@qq.com> wrote: > hi, Aaron > > > I may found a useful example. For example, I tested the alias attribute on > my own Apple laptop (Target: x86_64-apple-darwin17.5.0). First, I use > __has_attribute to test that the alias is usable or not. The test

[PATCH] D46241: [CodeGen] Recognize more cases of zero initialization

sepavloff added inline comments. Comment at: lib/CodeGen/CGExprConstant.cpp:1413 + } else if (!Init->isEvaluatable(CE.CGM.getContext())) { +return false; + } else if (InitTy->hasPointerRepresentation()) { rsmith wrote: > sepavloff wrote: > > rjmccall

[PATCH] D33537: [clang-tidy] Exception Escape Checker

baloghadamsoftware updated this revision to Diff 145452. baloghadamsoftware added a comment. Updated according to the comments. https://reviews.llvm.org/D33537 Files: clang-tidy/bugprone/BugproneTidyModule.cpp clang-tidy/bugprone/CMakeLists.txt

[PATCH] D33537: [clang-tidy] Exception Escape Checker

baloghadamsoftware marked 10 inline comments as done. baloghadamsoftware added inline comments. Comment at: test/clang-tidy/bugprone-exception-escape.cpp:178 +void indirect_implicit() noexcept { + // CHECK-MESSAGES: :[[@LINE-1]]:6: warning: function 'indirect_implicit' throws

[PATCH] D38845: [ASTImporter] Support importing UnresolvedMemberExpr, DependentNameType, DependentScopeDeclRefExpr

This revision was automatically updated to reflect the committed changes. Closed by commit rC331630: [ASTImporter] Support importing UnresolvedMemberExpr, DependentNameType… (authored by szepet, committed by ). Changed prior to commit: https://reviews.llvm.org/D38845?vs=145159=145447#toc

r331630 - [ASTImporter] Support importing UnresolvedMemberExpr, DependentNameType, DependentScopeDeclRefExpr

Author: szepet Date: Mon May 7 05:08:27 2018 New Revision: 331630 URL: http://llvm.org/viewvc/llvm-project?rev=331630=rev Log: [ASTImporter] Support importing UnresolvedMemberExpr, DependentNameType, DependentScopeDeclRefExpr The visit callback implementations for the 3 C++ AST Node added to

[PATCH] D46522: [clang] cmake: resolve symlinks in ClangConfig.cmake

Lekensteyn created this revision. Lekensteyn added a reviewer: sylvestre.ledru. Herald added subscribers: cfe-commits, mgorny. Ensure that symlinks such as /usr/lib/cmake/clang-X.Y (pointing to /usr/lib/llvm-X.Y/lib/cmake/llvm) are resolved. This ensures that CLANG_INSTALL_PREFIX ends up to be

[PATCH] D44684: [mips] Improve handling of -fno-[pic/PIC] option

abeserminji updated this revision to Diff 145460. abeserminji marked 4 inline comments as done. abeserminji added a comment. Comments resolved. https://reviews.llvm.org/D44684 Files: include/clang/Basic/DiagnosticDriverKinds.td lib/Driver/ToolChains/Arch/Mips.cpp

[PATCH] D46520: [Driver] Use -fuse-line-directives by default in MSVC mode

mstorsjo created this revision. mstorsjo added reviewers: rnk, hans, thakis. Don't use the GNU extension form of line markers in MSVC mode. Repository: rC Clang https://reviews.llvm.org/D46520 Files: lib/Driver/ToolChains/Clang.cpp test/Driver/cl-options.c Index:

[PATCH] D46524: [clangd] Extract scoring/ranking logic, and shave yaks.

sammccall created this revision. sammccall added a reviewer: ilya-biryukov. Herald added subscribers: cfe-commits, mgrang, jkorous, MaskRay, ioeric, mgorny, klimek. Code completion scoring was embedded in CodeComplete.cpp, which is bad: - awkward to test. The mechanisms (extracting info from

[PATCH] D44684: [mips] Improve handling of -fno-[pic/PIC] option

This revision was automatically updated to reflect the committed changes. Closed by commit rL331636: [mips] Improve handling of -fno-[pic/PIC] option (authored by abeserminji, committed by ). Changed prior to commit: https://reviews.llvm.org/D44684?vs=145460=145462#toc Repository: rL LLVM

[PATCH] D46524: [clangd] Extract scoring/ranking logic, and shave yaks.

ilya-biryukov added a comment. The change makes both testing and scoring code better. Even though those are largely independent changes, perfectly happy to review them together. I mostly have NITs here, overall the changes LG. Comment at: clangd/CodeComplete.cpp:36

r331640 - [mips] Improve handling of -fno-[pic/PIC] option

Author: abeserminji Date: Mon May 7 07:30:49 2018 New Revision: 331640 URL: http://llvm.org/viewvc/llvm-project?rev=331640=rev Log: [mips] Improve handling of -fno-[pic/PIC] option In order to disable PIC and to match GCC behaviour, -mno-abicalls option is neccessary. When -fno-[pic/PIC] is

[PATCH] D46501: [OpenCL] Guard all half float usage based on cl_khr_fp16 extension

yaxunl added a comment. Only halfn type requires cl_khr_fp16. These functions do not use halfn type, therefore cl_khr_fp16 is not required. Repository: rC Clang https://reviews.llvm.org/D46501 ___ cfe-commits mailing list

[PATCH] D46471: [HIP] Add hip offload kind

yaxunl updated this revision to Diff 145472. yaxunl marked 2 inline comments as done. yaxunl added a comment. Updated comments. https://reviews.llvm.org/D46471 Files: include/clang/Driver/Action.h lib/Driver/Action.cpp lib/Driver/Compilation.cpp lib/Driver/ToolChains/Clang.cpp Index:

r331636 - [mips] Improve handling of -fno-[pic/PIC] option

Author: abeserminji Date: Mon May 7 07:19:54 2018 New Revision: 331636 URL: http://llvm.org/viewvc/llvm-project?rev=331636=rev Log: [mips] Improve handling of -fno-[pic/PIC] option In order to disable PIC and to match GCC behaviour, -mno-abicalls option is neccessary. When -fno-[pic/PIC] is

r331639 - Revert "[mips] Improve handling of -fno-[pic/PIC] option"

Author: abeserminji Date: Mon May 7 07:28:42 2018 New Revision: 331639 URL: http://llvm.org/viewvc/llvm-project?rev=331639=rev Log: Revert "[mips] Improve handling of -fno-[pic/PIC] option" This reverts commit r331636. Forgot to add the test case. Modified:

[PATCH] D46520: [Driver] Use -fuse-line-directives by default in MSVC mode

mstorsjo added inline comments. Comment at: lib/Driver/ToolChains/Clang.cpp:4218 // -fno-use-line-directives is default. if (Args.hasFlag(options::OPT_fuse_line_directives, hans wrote: > The comment needs an update I think. Thanks, will change into

[PATCH] D46497: [clangd] Populate #include insertions as additional edits in completion items.

sammccall added a comment. I'm concerned about the scope of this patch - it does too many things and touches too many files for me to feel comfortable that I understand it well enough to review. Is it possible to split it up? (You mention 6 distinct things in the description). Have tried to

[PATCH] D46471: [HIP] Add hip offload kind

yaxunl marked an inline comment as done. yaxunl added inline comments. Comment at: lib/Driver/Compilation.cpp:201 + // not compiled again if there are already failures. It is OK to abort the + // CUDA pipeline on errors. + if (A->isOffloading(Action::OFK_Cuda) ||

[libcxx] r331638 - Update for Rapperswil

Author: marshall Date: Mon May 7 07:21:52 2018 New Revision: 331638 URL: http://llvm.org/viewvc/llvm-project?rev=331638=rev Log: Update for Rapperswil Modified: libcxx/trunk/www/upcoming_meeting.html Modified: libcxx/trunk/www/upcoming_meeting.html URL:

r331642 - [OPENMP, NVPTX] Added support for L2 parallelism.

Author: abataev Date: Mon May 7 07:50:05 2018 New Revision: 331642 URL: http://llvm.org/viewvc/llvm-project?rev=331642=rev Log: [OPENMP, NVPTX] Added support for L2 parallelism. Added initial codegen for level 2, 3 etc. parallelism. Currently, all the second, the third etc. parallel regions

[PATCH] D46403: [CFI] Force LLVM to die if the implicit blacklist files cannot be found.

cmtice updated this revision to Diff 145524. cmtice added a comment. Fix test failure that my previous changes caused. https://reviews.llvm.org/D46403 Files: lib/Driver/SanitizerArgs.cpp test/Driver/Inputs/resource_dir_with_cfi_blacklist/cfi_blacklist.txt

[PATCH] D46403: [CFI] Force LLVM to die if the implicit blacklist files cannot be found.

cmtice updated this revision to Diff 145537. cmtice added a comment. Make -resource-dir point to correct directory, in test case; move cfi_blacklist.txt file to 'share' subdirectory in test resource dir. https://reviews.llvm.org/D46403 Files: lib/Driver/SanitizerArgs.cpp

r331683 - [X86] Use target feature defines in tests instead of defining our own flag on the command line. NFCI

Author: ctopper Date: Mon May 7 14:47:13 2018 New Revision: 331683 URL: http://llvm.org/viewvc/llvm-project?rev=331683=rev Log: [X86] Use target feature defines in tests instead of defining our own flag on the command line. NFCI Modified: cfe/trunk/test/CodeGen/gfni-builtins.c

r331682 - [X86] Make _mm256_gf2p8mul_epi8 require avx features since its 256 bits.

Author: ctopper Date: Mon May 7 14:47:11 2018 New Revision: 331682 URL: http://llvm.org/viewvc/llvm-project?rev=331682=rev Log: [X86] Make _mm256_gf2p8mul_epi8 require avx features since its 256 bits. Without this we throw an error on the header file instead of the user code when the right

RE: r331536 - [NFC]Convert Class to use member initialization instead of inline.

I don’t believe the member initialization for bitfields (of which all the ‘0’ values are) happened until C++17, right? I could definitely member initialize the two enum fields though. From: David Blaikie [mailto:dblai...@gmail.com] Sent: Monday, May 7, 2018 12:03 PM To: Keane, Erich

[PATCH] D46535: Correct warning on Float->Integer conversions.

aaron.ballman added inline comments. Comment at: lib/Sema/SemaChecking.cpp:9432 if (IsLiteral) { +// Conversion of a floating point value to a non-bool integer where the +// integral part cannot be represented by the integer type is undefined.

[PATCH] D46300: [Clang] Implement function attribute no_stack_protector.

aaron.ballman edited reviewers, added: probinson; removed: void. aaron.ballman added a subscriber: probinson. aaron.ballman added a comment. Adding in @probinson as he originally added the `optnone` attribute. Paul, do you recall why you opted (haha, pun totally intended) to implement `optnone`

[PATCH] D45476: [C++2a] Implement operator<=> CodeGen and ExprConstant

rsmith added inline comments. Comment at: include/clang/AST/ASTContext.h:1983 + /// \brief Types and expressions required to build C++2a three-way comparisons + /// using operator<=>, including the values return by builtin <=> operators. + ComparisonCategories

[PATCH] D46300: [Clang] Implement function attribute no_stack_protector.

manojgupta updated this revision to Diff 145514. manojgupta added a comment. Added docs, Sema test case for the attribute. Repository: rC Clang https://reviews.llvm.org/D46300 Files: include/clang/Basic/Attr.td include/clang/Basic/AttrDocs.td lib/CodeGen/CodeGenModule.cpp

[PATCH] D43778: [clang-tidy] Adding RestrictIncludes check to Fuchsia module

juliehockett added inline comments. Comment at: clang-tidy/fuchsia/RestrictIncludesCheck.cpp:75 +for (const auto : FileDirectives) { + auto D = Check.diag(Include.Loc, "restricted include found"); + aaron.ballman wrote: > I believe this check will be

[PATCH] D43778: [clang-tidy] Adding RestrictIncludes check to Fuchsia module

juliehockett updated this revision to Diff 145547. juliehockett marked 9 inline comments as done. juliehockett edited the summary of this revision. juliehockett added a comment. Sorry for the delay in updating this -- check now restricts includes to a whitelist, rather than a blacklist, and only

[PATCH] D46300: [Clang] Implement function attribute no_stack_protector.

manojgupta added inline comments. Comment at: include/clang/Basic/Attr.td:1494 +def NoStackProtector : InheritableAttr { + let Spellings = [GCC<"no_stack_protector">]; + let Subjects = SubjectList<[Function]>; aaron.ballman wrote: > This is not a GCC

[PATCH] D45476: [C++2a] Implement operator<=> CodeGen and ExprConstant

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Fine, that works. https://reviews.llvm.org/D45476 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D24867: Request init/fini array on FreeBSD 12 and later

brooks accepted this revision. brooks added a comment. I do think we should make this change, but don't have a strong opinion on the timing. If we do it for 12 and not 13 then we should probably try to get it into a 6.0.2. https://reviews.llvm.org/D24867

[PATCH] D46535: Correct warning on Float->Integer conversions.

erichkeane marked 2 inline comments as done. erichkeane added inline comments. Comment at: lib/Sema/SemaChecking.cpp:9440-9441 +diag::warn_impcast_literal_float_to_integer_out_of_range); + if (IntegerValue.isUnsigned() && + (IntegerValue.isMaxValue() ||

[PATCH] D46403: [CFI] Force LLVM to die if the implicit blacklist files cannot be found.

cmtice updated this revision to Diff 145540. cmtice added a comment. Make cfi_blacklist.txt be an empty file. https://reviews.llvm.org/D46403 Files: lib/Driver/SanitizerArgs.cpp test/Driver/Inputs/resource_dir_with_cfi_blacklist/share/cfi_blacklist.txt test/Driver/fsanitize-blacklist.c

[PATCH] D46541: [CodeGen] Improve diagnostics related to target attributes

craig.topper added inline comments. Comment at: lib/CodeGen/CodeGenFunction.cpp:2271 +static bool hasRequiredFeature(StringRef Feature, + llvm::StringMap& CallerFeatureMap, + std::string ) { '&' should

r331688 - [NFC] Move 2 variable initialization from Ctor to member initializers.

Author: erichkeane Date: Mon May 7 15:01:06 2018 New Revision: 331688 URL: http://llvm.org/viewvc/llvm-project?rev=331688=rev Log: [NFC] Move 2 variable initialization from Ctor to member initializers. In response to dblaikie's suggestion on r331536, replace the two enum typed variable

[PATCH] D45093: [AST] Fix -ast-print for _Bool when have diagnostics

rsmith added a comment. If you want to force a particular printing policy to be used for `-ast-print`, I think it would be better to change the `print` call in `lib/Frontend/ASTConsumers.cpp` to pass your desired printing policy, rather than changing other components to prevent them from

[PATCH] D46403: [CFI] Force LLVM to die if the implicit blacklist files cannot be found.

pcc added inline comments. Comment at: test/Frontend/dependency-gen.c:24 // RUN: echo "fun:foo" > %t.blacklist -// RUN: %clang -MD -MF - %s -fsyntax-only -fsanitize=cfi-vcall -flto -fvisibility=hidden -fsanitize-blacklist=%t.blacklist -I ./ | FileCheck

r331674 - [CFI] Force LLVM to die if the implicit blacklist files cannot be found.

Author: pcc Date: Mon May 7 13:54:05 2018 New Revision: 331674 URL: http://llvm.org/viewvc/llvm-project?rev=331674=rev Log: [CFI] Force LLVM to die if the implicit blacklist files cannot be found. Currently LLVM CFI tries to use an implicit blacklist file, currently in /usr/lib64/clang//share.

[PATCH] D46403: [CFI] Force LLVM to die if the implicit blacklist files cannot be found.

This revision was automatically updated to reflect the committed changes. Closed by commit rC331674: [CFI] Force LLVM to die if the implicit blacklist files cannot be found. (authored by pcc, committed by ). Repository: rC Clang https://reviews.llvm.org/D46403 Files:

[PATCH] D46550: Support Swift calling convention for PPC64 targets

bob.wilson added a comment. Previous review (for the swift-llvm GitHub repo): https://github.com/apple/swift-clang/pull/167 Repository: rC Clang https://reviews.llvm.org/D46550 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D46052: GNUstep Objective-C ABI version 2

rjmccall added a comment. Thanks, the comments help a lot. Comment at: lib/CodeGen/CGObjCGNU.cpp:439 + ArrayRef IvarOffsets, + ArrayRef IvarAlign, + ArrayRef IvarOwnership);

r331692 - PR37352: mangle numbering for decomposition declarations.

Author: rsmith Date: Mon May 7 15:23:38 2018 New Revision: 331692 URL: http://llvm.org/viewvc/llvm-project?rev=331692=rev Log: PR37352: mangle numbering for decomposition declarations. In order to match our mangling scheme, use a different set of numbers for decomposition declarations, and

[PATCH] D46024: [clang-format] Add SpaceBeforeCpp11BracedList option.

rkirsling added a comment. Any further commentary? :) Repository: rC Clang https://reviews.llvm.org/D46024 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D46403: [CFI] Force LLVM to die if the implicit blacklist files cannot be found.

vsk added a comment. Do you have commit access? If not I'd be happy to land this for you. Comment at: test/Driver/Inputs/resource_dir_with_cfi_blacklist/cfi_blacklist.txt:19 +# in order to call std::allocator_traits::construct. +fun:_ZNSt23_Sp_counted_ptr_inplace*

r331666 - [Driver] Use -fuse-line-directives by default in MSVC mode

Author: mstorsjo Date: Mon May 7 13:26:09 2018 New Revision: 331666 URL: http://llvm.org/viewvc/llvm-project?rev=331666=rev Log: [Driver] Use -fuse-line-directives by default in MSVC mode Don't use the GNU extension form of line markers in MSVC mode. Differential Revision:

[PATCH] D46535: Correct warning on Float->Integer conversions.

erichkeane updated this revision to Diff 145536. erichkeane marked an inline comment as done. erichkeane added a comment. Aaron's comments :) https://reviews.llvm.org/D46535 Files: include/clang/Basic/DiagnosticSemaKinds.td lib/Sema/SemaChecking.cpp test/SemaCXX/coroutines.cpp

[PATCH] D46403: [CFI] Force LLVM to die if the implicit blacklist files cannot be found.

pcc accepted this revision. pcc added a comment. LGTM https://reviews.llvm.org/D46403 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D46535: Correct warning on Float->Integer conversions.

This revision was automatically updated to reflect the committed changes. Closed by commit rC331673: Correct warning on Float-Integer conversions. (authored by erichkeane, committed by ). Changed prior to commit: https://reviews.llvm.org/D46535?vs=145536=145542#toc Repository: rC Clang

r331673 - Correct warning on Float->Integer conversions.

Author: erichkeane Date: Mon May 7 13:52:56 2018 New Revision: 331673 URL: http://llvm.org/viewvc/llvm-project?rev=331673=rev Log: Correct warning on Float->Integer conversions. As identified and briefly discussed here: https://bugs.llvm.org/show_bug.cgi?id=37305 Converting a floating point

[PATCH] D46550: Support Swift calling convention for PPC64 targets

bob.wilson created this revision. bob.wilson added a reviewer: aschwaighofer. Herald added subscribers: kbarton, nemanjai, mcrosier. This adds basic support for the Swift calling convention with PPC64 targets. Patch provided by Atul Sowani in bug report #37223 Repository: rC Clang

[PATCH] D45093: [AST] Fix -ast-print for _Bool when have diagnostics

jdenny added a comment. In https://reviews.llvm.org/D45093#1087652, @aaron.ballman wrote: > This approach generally looks good to me, but I'd like @rsmith's opinion on > whether we should be trying to make -ast-print have good source fidelity or > not. I was under the impression we wanted

Re: r331536 - [NFC]Convert Class to use member initialization instead of inline.

On Mon, May 7, 2018 at 12:57 PM Keane, Erich wrote: > I don’t believe the member initialization for bitfields (of which all the > ‘0’ values are) happened until C++17, right? > Ah, fair point - I hadn't looked at the types, just what was visible in the patch. (& I don't

[PATCH] D24867: Request init/fini array on FreeBSD 12 and later

arichardson accepted this revision. arichardson added a comment. I recently made this change for the CHERI clang fork and as far as I can tell everything works fine. https://reviews.llvm.org/D24867 ___ cfe-commits mailing list

[PATCH] D46535: Correct warning on Float->Integer conversions.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! https://reviews.llvm.org/D46535 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D42933: [Sema] Avoid -Wformat warning for NSInteger/NSUInteger 'int' values with %zu/%zi long specifiers

jfb added a comment. In https://reviews.llvm.org/D42933#1090286, @smeenai wrote: > Note that the alignment matters in addition to the size. Sure, but AFAICT from `./lib/Basic/Targets/*` the alignment is also specified properly, is it not? > The pattern I've seen internally is people using

[PATCH] D42933: [Sema] Avoid -Wformat warning for NSInteger/NSUInteger 'int' values with %zu/%zi long specifiers

jfb added a comment. Herald added a reviewer: javed.absar. I was just looking at this, and I think @arphaman's patch is pretty much the right approach (with 2 suggested fixes below). I don't think the code we're currently warning on is broken: a user code has `NSInteger` with `%zd` or

[PATCH] D42933: [Sema] Avoid -Wformat warning for NSInteger/NSUInteger 'int' values with %zu/%zi long specifiers

smeenai added a comment. Note that the alignment matters in addition to the size. The pattern I've seen internally is people using `%zd` for NSInteger and `%tu` for NSUInteger, since until clang 6 neither of those were format-checked at all. I'd be fine with adding an option to relax the

[PATCH] D46403: [CFI] Force LLVM to die if the implicit blacklist files cannot be found.

cmtice added a comment. I'm not sure if I have commit access or not; Peter was working with me on trying to commit the change. https://reviews.llvm.org/D46403 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D45702: [clang-tidy] Add a new check, readability-redundant-data-call, that finds and removes redundant calls to .data().

aaron.ballman added inline comments. Comment at: clang-tidy/readability/RedundantDataCallCheck.cpp:45 + anyOf(TypesMatcher, pointerType(pointee(TypesMatcher)), + callee(namedDecl(hasName("data" + .bind("call",

[PATCH] D46520: [Driver] Use -fuse-line-directives by default in MSVC mode

This revision was automatically updated to reflect the committed changes. Closed by commit rC331666: [Driver] Use -fuse-line-directives by default in MSVC mode (authored by mstorsjo, committed by ). Changed prior to commit: https://reviews.llvm.org/D46520?vs=145446=145528#toc Repository: rC

[PATCH] D46520: [Driver] Use -fuse-line-directives by default in MSVC mode

This revision was automatically updated to reflect the committed changes. Closed by commit rL331666: [Driver] Use -fuse-line-directives by default in MSVC mode (authored by mstorsjo, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D45093: [AST] Fix -ast-print for _Bool when have diagnostics

jdenny added a comment. In https://reviews.llvm.org/D45093#1090292, @rsmith wrote: > If you want to force a particular printing policy to be used for > `-ast-print`, I think it would be better to change the `print` call in > `lib/Frontend/ASTConsumers.cpp` to pass your desired printing policy,

r331681 - Relax a FileCheck pattern to make it pass on Windows.

Author: pcc Date: Mon May 7 14:40:53 2018 New Revision: 331681 URL: http://llvm.org/viewvc/llvm-project?rev=331681=rev Log: Relax a FileCheck pattern to make it pass on Windows. Should fix Windows bot failure:

r331697 - Fix failing codegen test on non-x86_64 platforms

Author: ericwf Date: Mon May 7 16:15:34 2018 New Revision: 331697 URL: http://llvm.org/viewvc/llvm-project?rev=331697=rev Log: Fix failing codegen test on non-x86_64 platforms Modified: cfe/trunk/test/CodeGenCXX/cxx2a-compare.cpp Modified: cfe/trunk/test/CodeGenCXX/cxx2a-compare.cpp URL:

Buildbot numbers for the week of 4/22/2018 - 4/28/2018

Hello everyone, Below are some buildbot numbers for the week of 4/22/2018 - 4/28/2018. Please see the same data in attached csv files: The longest time each builder was red during the week; "Status change ratio" by active builder (percent of builds that changed the builder status from greed to

Buildbot numbers for the week of 4/29/2018 - 5/5/2018

Hello everyone, Below are some buildbot numbers for the last week of 4/29/2018 - 5/5/2018. Please see the same data in attached csv files: The longest time each builder was red during the week; "Status change ratio" by active builder (percent of builds that changed the builder status from greed

[PATCH] D22711: Diagnose invalid failure memory orderings.

jfb requested changes to this revision. jfb added a comment. This revision now requires changes to proceed. Given http://wg21.link/p0418 I think this requires an update. I don't think the old behavior is worth supporting in older `-std=` versions, unless we're worried that it would make code

[PATCH] D45997: [CMake] Pass additional CMake flags in Fuchsia cache files

This revision was automatically updated to reflect the committed changes. Closed by commit rL331717: [CMake] Pass additional CMake flags in Fuchsia cache files (authored by phosek, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

r331717 - [CMake] Pass additional CMake flags in Fuchsia cache files

Author: phosek Date: Mon May 7 19:47:13 2018 New Revision: 331717 URL: http://llvm.org/viewvc/llvm-project?rev=331717=rev Log: [CMake] Pass additional CMake flags in Fuchsia cache files This allows passing additional CMake flags to builtins and runtimes build through Fuchsia cache files.

r331706 - Move test input file into same directory as test. NFC

Author: rtrieu Date: Mon May 7 17:29:21 2018 New Revision: 331706 URL: http://llvm.org/viewvc/llvm-project?rev=331706=rev Log: Move test input file into same directory as test. NFC Added: cfe/trunk/test/Frontend/Inputs/resource_dir_with_cfi_blacklist/

r331707 - [C++2a] Implement operator<=>: Address bugs and post-commit review comments after r331677.

Author: ericwf Date: Mon May 7 17:52:19 2018 New Revision: 331707 URL: http://llvm.org/viewvc/llvm-project?rev=331707=rev Log: [C++2a] Implement operator<=>: Address bugs and post-commit review comments after r331677. This patch addresses some mostly trivial post-commit review comments

r331713 - [C++2a] operator<=>: Fix incorrect use of Twine.

Author: ericwf Date: Mon May 7 19:28:47 2018 New Revision: 331713 URL: http://llvm.org/viewvc/llvm-project?rev=331713=rev Log: [C++2a] operator<=>: Fix incorrect use of Twine. Modified: cfe/trunk/lib/Sema/SemaDeclCXX.cpp Modified: cfe/trunk/lib/Sema/SemaDeclCXX.cpp URL:

[PATCH] D23041: Un-XFAIL GCC atomics.align

jfb added a comment. Herald added subscribers: christof, aheejin. In https://reviews.llvm.org/D23041#632708, @EricWF wrote: > Have you filed a bug against GCC regarding its current behavior? > > Also it seems like a bad idea to add `-fabi-version=6`, since it selects an > older ABI version and

[PATCH] D46540: [X86] ptwrite intrinsic

GBuella created this revision. GBuella added a reviewer: craig.topper. Herald added subscribers: cfe-commits, mgorny. Repository: rC Clang https://reviews.llvm.org/D46540 Files: include/clang/Basic/BuiltinsX86.def include/clang/Basic/BuiltinsX86_64.def include/clang/Driver/Options.td

Re: r331556 - [analyzer] Treat more const variables and fields as known contants.

It looks like this commit has introduced an assertion failure. See https://bugs.llvm.org/show_bug.cgi?id=37357. On Fri, May 4, 2018 at 10:56 PM Artem Dergachev via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: dergachev > Date: Fri May 4 13:52:39 2018 > New Revision: 331556 > >

[PATCH] D46541: [CodeGen] Improve diagnostics related to target attributes

GBuella created this revision. GBuella added reviewers: craig.topper, echristo, dblaikie. Herald added a subscriber: cfe-commits. When requirement imposed by __target__ attributes on functions are not satisfied, prefer printing those requirements, which are explicitly mentioned in the attributes.

[PATCH] D24867: Request init/fini array on FreeBSD 12 and later

dim added a comment. Brooks, I can commit this if you prefer. Maybe it can go into 6.0.2 still... https://reviews.llvm.org/D24867 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: r331536 - [NFC]Convert Class to use member initialization instead of inline.

Perhaps this should use non-static data member initializers instead? On Fri, May 4, 2018 at 9:23 AM Erich Keane via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: erichkeane > Date: Fri May 4 09:19:53 2018 > New Revision: 331536 > > URL:

[libcxx] r331661 - Status updates for Rapperswil

Author: marshall Date: Mon May 7 11:59:04 2018 New Revision: 331661 URL: http://llvm.org/viewvc/llvm-project?rev=331661=rev Log: Status updates for Rapperswil Modified: libcxx/trunk/www/upcoming_meeting.html Modified: libcxx/trunk/www/upcoming_meeting.html URL:

  1   2   >