[PATCH] D47673: [Coroutines] Less IR for noexcept await_resume

modocache created this revision. modocache added reviewers: GorNishanov, EricWF. Herald added a subscriber: cfe-commits. In his review of https://reviews.llvm.org/D45860, @GorNishanov suggested avoiding generating additional exception-handling IR in the case that the resume function was marked as

[PATCH] D47564: [Parse] Use CapturedStmt for @finally on MSVC

rjmccall added a comment. In https://reviews.llvm.org/D47564#1119874, @smeenai wrote: > In https://reviews.llvm.org/D47564#1118424, @rjmccall wrote: > > > No, it was just a general question. Have you gotten this to a point where > > it's testable? > > > Yup, it's been working fine in my local

[PATCH] D46805: If some platforms do not support an attribute, we should exclude the platform

HLJ2009 added a comment. In https://reviews.llvm.org/D46805#1117091, @sunfish wrote: > In https://reviews.llvm.org/D46805#1115681, @rsmith wrote: > > > In https://reviews.llvm.org/D46805#1113358, @aaron.ballman wrote: > > > > > @rsmith -- do the object file formats listed look correct to you? >

[PATCH] D47201: [CUDA] Implement nv_weak attribute for functions

Hahnfeld added a comment. In https://reviews.llvm.org/D47201#1119254, @aaron.ballman wrote: > In https://reviews.llvm.org/D47201#1119249, @tra wrote: > > > IIUIC, nv_weak is a synonym for weak (why, oh why did they need > > it?) > > You may need to hunt down and change few other places that

[PATCH] D46602: [clang-tidy] Store checks profiling info as YAML files

lebedev.ri updated this revision to Diff 149610. lebedev.ri marked 6 inline comments as done. lebedev.ri added a comment. Rebased. Addressed review notes. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D46602 Files: clang-tidy/ClangTidy.cpp clang-tidy/ClangTidy.h

[PATCH] D46602: [clang-tidy] Store checks profiling info as YAML files

lebedev.ri added inline comments. Comment at: clang-tidy/tool/ClangTidyMain.cpp:342-347 +if (!llvm::sys::fs::exists(AbsolutePath)) { + // If the destination prefix does not exist, don't try to use real_path(). + return AbsolutePath; +} +SmallString<256>

[PATCH] D47358: : Implement {un, }synchronized_pool_resource.

Quuxplusone updated this revision to Diff 149611. Quuxplusone added a comment. - Split up the unit tests. - Refactor to shrink the memory layout of the resource object itself. Before this patch `sizeof(unsynchronized_pool_resource)==48`. After this patch `sizeof(unsynchronized_pool_resource) ==

[PATCH] D45050: [clang-tidy] New checker for not null-terminated result caused by strlen or wcslen

Charusso added a comment. In https://reviews.llvm.org/D45050#1116446, @lebedev.ri wrote: > I would like to see more negative tests. > What does it do if the len/size is a constant? > Variable that wasn't just assigned with `strlen()` return? Thanks for the comment! What do you mean by

[PATCH] D45050: [clang-tidy] New checker for not null-terminated result caused by strlen or wcslen

xbolva00 added a comment. In https://reviews.llvm.org/D45050#1119973, @Charusso wrote: > In https://reviews.llvm.org/D45050#1116446, @lebedev.ri wrote: > > > I would like to see more negative tests. > > What does it do if the len/size is a constant? > > Variable that wasn't just assigned with

[PATCH] D45050: [clang-tidy] New checker for not null-terminated result caused by strlen or wcslen

lebedev.ri added a comment. In https://reviews.llvm.org/D45050#1119973, @Charusso wrote: > In https://reviews.llvm.org/D45050#1116446, @lebedev.ri wrote: > > > I would like to see more negative tests. > > What does it do if the len/size is a constant? > > Variable that wasn't just assigned

[PATCH] D47121: [NEON] Support VLD1xN intrinsics in AArch32 mode (Clang part)

This revision was automatically updated to reflect the committed changes. Closed by commit rL333819: [NEON] Support VLD1xN intrinsics in AArch32 mode (Clang part) (authored by kosarev, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D47103: Implement strip.invariant.group

Prazek added a comment. friendly ping Repository: rL LLVM https://reviews.llvm.org/D47103 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D47299: [CodeGenCXX] Emit strip.invariant.group with -fstrict-vtable-pointers

Prazek added a comment. @rjmccall @rsmith friendly ping Repository: rL LLVM https://reviews.llvm.org/D47299 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits