MTC added inline comments.
Herald added a subscriber: mikhail.ramalho.
Comment at: include/clang/Analysis/ConstructionContext.h:351
+
+ explicit SimpleTemporaryObjectConstructionContext(
+ const CXXBindTemporaryExpr *BTE, const MaterializeTemporaryExpr *MTE)
---
Author: phosek
Date: Mon Jun 11 23:58:06 2018
New Revision: 334477
URL: http://llvm.org/viewvc/llvm-project?rev=334477&view=rev
Log:
[CMake] Use common variable for all header targets NFC
This simplifies the handling of header targets.
Modified:
libcxx/trunk/cmake/Modules/HandleLibCXXABI.cma
Szelethus updated this revision to Diff 150899.
Szelethus added a comment.
Polite ping :)
This diff fixed a minor issue in FieldChainInfo's constructor.
https://reviews.llvm.org/D45532
Files:
include/clang/StaticAnalyzer/Checkers/Checkers.td
lib/StaticAnalyzer/Checkers/CMakeLists.txt
lib
krasimir created this revision.
Herald added a subscriber: cfe-commits.
This is an alternative to https://reviews.llvm.org/D48034.
Repository:
rC Clang
https://reviews.llvm.org/D48063
Files:
lib/Format/TokenAnnotator.cpp
unittests/Format/FormatTestTextProto.cpp
Index: unittests/Format/
Author: ioeric
Date: Tue Jun 12 01:48:20 2018
New Revision: 334485
URL: http://llvm.org/viewvc/llvm-project?rev=334485&view=rev
Log:
[clangd] Support proximity paths in index fuzzy find.
Reviewers: sammccall
Subscribers: ilya-biryukov, MaskRay, jkorous, cfe-commits
Differential Revision: https:
This revision was automatically updated to reflect the committed changes.
Closed by commit rL334485: [clangd] Support proximity paths in index fuzzy
find. (authored by ioeric, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D47937
Files:
hans added a comment.
In https://reviews.llvm.org/D46024#1121242, @rkirsling wrote:
> FWIW, please note that this space-before-brace style is not specific to
> WebKit; CppCoreGuidelines exhibits it as well:
>
> http://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#es23-prefer-the--initia
sdardis updated this revision to Diff 150904.
sdardis added a comment.
Modify implementation to produce a function attribute.
Repository:
rC Clang
https://reviews.llvm.org/D47829
Files:
include/clang/Driver/Options.td
include/clang/Frontend/CodeGenOptions.def
lib/CodeGen/CodeGenFunctio
gerazo added a comment.
In https://reviews.llvm.org/D47946#1127679, @balazske wrote:
> Problem: This change interferes with https://reviews.llvm.org/D47445.
> Probably that should be committed, it is approved already.
Ok. I'll wait for the other thing to be committed and I will rework this
im
Author: lukegeeson
Date: Tue Jun 12 02:54:27 2018
New Revision: 334489
URL: http://llvm.org/viewvc/llvm-project?rev=334489&view=rev
Log:
[AArch64] Corrected FP16 Intrinsic range checks in Clang + added Sema tests
Summary:
This fixes the ranges for the vcvth family of FP16 intrinsics in the clang
This revision was automatically updated to reflect the committed changes.
LukeGeeson marked an inline comment as done.
Closed by commit rL334489: [AArch64] Corrected FP16 Intrinsic range checks in
Clang + added Sema tests (authored by LukeGeeson, committed by ).
Herald added a subscriber: llvm-com
ilya-biryukov created this revision.
ilya-biryukov added a reviewer: sammccall.
Herald added subscribers: jkorous, MaskRay, ioeric, mgorny.
Caching is now handled by ClangdLSPServer and hidden behind the
GlobalCompilationDatabase interface. This simplifies ClangdServer.
No behavioral changes are
ilya-biryukov added a comment.
After looking at it more closely, it seems caching happens in the underlying
compilation databases anyway. So I guess we don't even need the
`CachingCompilationDatabase`.
I'll remove it.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D48068
___
ilya-biryukov updated this revision to Diff 150917.
ilya-biryukov added a comment.
- Remove CachingCompilationDb
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D48068
Files:
clangd/CMakeLists.txt
clangd/ClangdLSPServer.cpp
clangd/ClangdLSPServer.h
clangd/ClangdServer.cpp
ilya-biryukov updated this revision to Diff 150920.
ilya-biryukov added a comment.
- Revert "Remove CachingCompilationDb". Turns out we do need it internally
(Thanks, Sam!) :-)
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D48068
Files:
clangd/CMakeLists.txt
clangd/ClangdL
sdardis added a comment.
In https://reviews.llvm.org/D47829#1124040, @efriedma wrote:
> Is this something which is actually useful to control? From your
> description, you want to add the flag to clang not because you actually want
> to use it, but just because you can't figure out how to pass
ioeric updated this revision to Diff 150923.
ioeric added a comment.
- Merge branch 'uri' into proximity
- Addressed review comments.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D47935
Files:
clangd/CodeComplete.cpp
clangd/Quality.cpp
clangd/Quality.h
unittests/clangd
ioeric updated this revision to Diff 150924.
ioeric added a comment.
- Cleanup comment a bit.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D47935
Files:
clangd/CodeComplete.cpp
clangd/Quality.cpp
clangd/Quality.h
unittests/clangd/QualityTests.cpp
unittests/clangd/Tes
ioeric added a comment.
PTAL
Comment at: clangd/Quality.cpp:215
void SymbolRelevanceSignals::merge(const CodeCompletionResult &SemaCCResult) {
if (SemaCCResult.Availability == CXAvailability_NotAvailable ||
ioeric wrote:
> sammccall wrote:
> > proximity p
ilya-biryukov created this revision.
ilya-biryukov added a reviewer: sammccall.
Herald added subscribers: jkorous, MaskRay, ioeric.
Disabled by default and hidden, caching for most implementation
already happens outside clangd, so we rarely need to change it.
Repository:
rCTE Clang Tools Extra
ilya-biryukov added a comment.
Testing should be possible with lit tests, I'll look into that. Let me know if
there's anything else about this patch that needs attention. Thanks!
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D48071
___
krasimir updated this revision to Diff 150926.
krasimir added a comment.
- Add tests
Repository:
rC Clang
https://reviews.llvm.org/D48063
Files:
lib/Format/TokenAnnotator.cpp
unittests/Format/FormatTestProto.cpp
unittests/Format/FormatTestTextProto.cpp
Index: unittests/Format/FormatTe
jmorse created this revision.
jmorse added reviewers: rsmith, doug.gregor, majnemer.
Herald added a subscriber: cfe-commits.
Hi,
This patch tries to fix a problem in clangs implementation of C++11's
[basic.lookup.qual]p6 as demonstrated in PR12350, by:
- Re-enabling looking in name-specifier pre
Anastasia added inline comments.
Comment at: include/clang/Basic/BuiltinsAMDGPU.def:49
+
+// FIXME: Need to disallow constant address space.
BUILTIN(__builtin_amdgcn_div_scale, "dddbb*", "n")
arsenm wrote:
> Anastasia wrote:
> > Do you plan to provide the suppor
CarlosAlbertoEnciso added a comment.
@Typz,
It seems that the changes done to `ClangFormatStyleOptions.rst` @334408 are
causing the generation of the documentation to fail, with the following error:
Warning, treated as error:
/llvm/tools/clang/docs/ClangFormatStyleOptions.rst:1060: WARNING:
Author: hans
Date: Tue Jun 12 04:33:44 2018
New Revision: 334493
URL: http://llvm.org/viewvc/llvm-project?rev=334493&view=rev
Log:
Revert r334418 "Enable crash recovery tests on Windows, globs work in the lit
internal shell now"
The tests fail on Windows bots, and for me locally.
> Enable crash
I've reverted in r334493 in the meantime.
When I run the tests locally, they fail with:
# command stderr:
C:\src\llvm\tools\clang\test\Driver\crash-report.c:17:11: error:
expected string not found in input
// CHECK: Preprocessed source(s) and associated run script(s) are located at:
^
:
Author: hans
Date: Tue Jun 12 04:51:22 2018
New Revision: 334494
URL: http://llvm.org/viewvc/llvm-project?rev=334494&view=rev
Log:
Re-apply r334418 "Enable crash recovery tests on Windows, globs work in the lit
internal shell now"
Plus change run lines from
not env FOO=bar %clang
to
env F
On Tue, Jun 12, 2018 at 1:43 PM, Hans Wennborg wrote:
> I've reverted in r334493 in the meantime.
>
> When I run the tests locally, they fail with:
>
> # command stderr:
> C:\src\llvm\tools\clang\test\Driver\crash-report.c:17:11: error:
> expected string not found in input
> // CHECK: Preprocessed
Author: ibiryukov
Date: Tue Jun 12 04:56:21 2018
New Revision: 334495
URL: http://llvm.org/viewvc/llvm-project?rev=334495&view=rev
Log:
[clangd] Trace time the operations wait on Semaphore.
The Semaphore is currently used to limit the number of concurrently
running tasks. Tracing the wait times w
erichkeane updated this revision to Diff 150934.
erichkeane marked an inline comment as done.
erichkeane added a comment.
Add error checking to perform copy init.
https://reviews.llvm.org/D48053
Files:
lib/Sema/SemaChecking.cpp
test/SemaCXX/builtins-overflow.cpp
Index: lib/Sema/SemaChecki
erichkeane added inline comments.
Comment at: lib/Sema/SemaChecking.cpp:228
+ S.getASTContext(), Ty, /*consume*/ false);
+ Arg = S.PerformCopyInitialization(Entity, SourceLocation(), Arg);
+ TheCall->setArg(2, Arg.get());
efriedma wrote:
> Is i
thakis added a comment.
What's the status here? The MS STL has this feature under _HAS_NODISCARD and
it's super useful.
Repository:
rCXX libc++
https://reviews.llvm.org/D45179
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.
aaron.ballman added a comment.
Ping
Repository:
rC Clang
https://reviews.llvm.org/D47435
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: erichkeane
Date: Tue Jun 12 06:59:32 2018
New Revision: 334503
URL: http://llvm.org/viewvc/llvm-project?rev=334503&view=rev
Log:
Fix overload resolution between Ptr-To-Member and Bool
As reported here (https://bugs.llvm.org/show_bug.cgi?id=19808)
and discovered independently when looking
lebedev.ri added a comment.
The checking by itself looks sane-ish, but i don't have any reasonable
knowledge in this area.
Comment at: lib/Sema/SemaChecking.cpp:925
+ case Builtin::BI__builtin_signbitl:
if (SemaBuiltinFPClassification(TheCall, 1))
return ExprError
Typz added a comment.
In https://reviews.llvm.org/D42787#1127790, @djasper wrote:
> The normal rule for formatting options apply. If you can dig up a public
> style guide and a project of reasonable size where it is used, we can add an
> option.
I don't want to be rude, but it seems to me tha
gtbercea updated this revision to Diff 150947.
gtbercea added a comment.
Added separate test.
Repository:
rC Clang
https://reviews.llvm.org/D47394
Files:
include/clang/Driver/Action.h
include/clang/Driver/Compilation.h
include/clang/Driver/Driver.h
include/clang/Driver/Options.td
i
ebevhan added inline comments.
Comment at: include/clang/Basic/TargetInfo.h:89
+ // corresponding unsaturated types.
+ unsigned char ShortAccumFBits, ShortAccumIBits;
+ unsigned char AccumFBits, AccumIBits;
leonardchan wrote:
> ebevhan wrote:
> > I suspect it'
tobiasvk updated this revision to Diff 150965.
tobiasvk added a comment.
- Rebase for current tree
- Fix -flto -save-temps which the previous patch broke
https://reviews.llvm.org/D34156
Files:
clang/include/clang/Frontend/CodeGenOptions.def
clang/lib/CodeGen/BackendUtil.cpp
clang/lib/Code
aaron.ballman updated this revision to Diff 150967.
aaron.ballman marked 5 inline comments as done.
aaron.ballman added a comment.
Updating based on review feedback.
https://reviews.llvm.org/D47435
Files:
lib/Sema/SemaChecking.cpp
test/Sema/builtins.c
Index: test/Sema/builtins.c
=
aaron.ballman added inline comments.
Comment at: lib/Sema/SemaChecking.cpp:925
+ case Builtin::BI__builtin_signbitl:
if (SemaBuiltinFPClassification(TheCall, 1))
return ExprError();
lebedev.ri wrote:
> The name of the function is unfortunate given th
lebedev.ri accepted this revision.
lebedev.ri added a comment.
This revision is now accepted and ready to land.
Looks good to me, but you probably want a bit for a second opinion.
https://reviews.llvm.org/D47435
___
cfe-commits mailing list
cfe-comm
DHowett-MSFT added a comment.
In https://reviews.llvm.org/D47233#1129207, @rjmccall wrote:
> In https://reviews.llvm.org/D47233#1129110, @smeenai wrote:
>
> > WinObjC does this wrapping, for example.
>
>
> I see. The idea of creating the type descriptors and mangled names ad-hoc
> for the catch
djasper added a comment.
You are right that this behavior is what the code authors, but also many other
people, like to have and so it is what is engrained in clang-format. There are
likely about a million things that fall into the same category. Now we might
find that the current default is ac
sammccall created this revision.
sammccall added a reviewer: ilya-biryukov.
Herald added subscribers: cfe-commits, jkorous, MaskRay, ioeric.
These have few signals other than being keywords, so the boost is high.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D48083
Files:
cla
sammccall accepted this revision.
sammccall added inline comments.
This revision is now accepted and ready to land.
Comment at: lib/Format/TokenAnnotator.cpp:3104
if (Left.is(tok::colon) && Left.isOneOf(TT_DictLiteral, TT_ObjCMethodExpr)) {
if ((Style.Language == FormatSt
klimek accepted this revision.
klimek added a comment.
In https://reviews.llvm.org/D46024#1129350, @hans wrote:
> In https://reviews.llvm.org/D46024#1121242, @rkirsling wrote:
>
> > FWIW, please note that this space-before-brace style is not specific to
> > WebKit; CppCoreGuidelines exhibits it
krasimir updated this revision to Diff 150980.
krasimir added a comment.
- Split-up the if-condition
Repository:
rC Clang
https://reviews.llvm.org/D48063
Files:
lib/Format/TokenAnnotator.cpp
unittests/Format/FormatTestProto.cpp
unittests/Format/FormatTestTextProto.cpp
Index: unittests
Author: krasimir
Date: Tue Jun 12 10:26:31 2018
New Revision: 334517
URL: http://llvm.org/viewvc/llvm-project?rev=334517&view=rev
Log:
[clang-format] Discourage breaks in submessage entries, hard rule
Summary:
Currently clang-format allows this for text protos:
```
submessage:
{ key: 'aaa
This revision was automatically updated to reflect the committed changes.
Closed by commit rL334517: [clang-format] Discourage breaks in submessage
entries, hard rule (authored by krasimir, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D4
tra accepted this revision.
tra added a comment.
This revision is now accepted and ready to land.
Thank you.
https://reviews.llvm.org/D47958
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c
sammccall accepted this revision.
sammccall added inline comments.
This revision is now accepted and ready to land.
Comment at: clangd/GlobalCompilationDatabase.cpp:137
+ // 'It' may be invalid at this point, recompute it.
+ It = Cached.find(File);
+ if (It != Cached.end())
--
Author: zturner
Date: Tue Jun 12 10:43:52 2018
New Revision: 334518
URL: http://llvm.org/viewvc/llvm-project?rev=334518&view=rev
Log:
Refactor ExecuteAndWait to take StringRefs.
This simplifies some code which had StringRefs to begin with, and
makes other code more complicated which had const cha
smeenai added a comment.
In https://reviews.llvm.org/D47233#1129810, @DHowett-MSFT wrote:
> In https://reviews.llvm.org/D47233#1129207, @rjmccall wrote:
>
> > In https://reviews.llvm.org/D47233#1129110, @smeenai wrote:
> >
> > > WinObjC does this wrapping, for example.
> >
> >
> > I see. The ide
GBuella added inline comments.
Comment at: lib/CodeGen/CGBuiltin.cpp:10071
+ // is _MM_FROUND_CUR_DIRECTION
+ if (cast(Ops[4])->getZExtValue() != 4)
+UsesNonDefaultRounding = true;
efriedma wrote:
> Given we're ignoring floating-point exceptions
tra added a comment.
Last comment in the bug pointed out that those overloads should be constexpr in
c++14. Maybe in a separate patch, though.
https://bugs.llvm.org/show_bug.cgi?id=37753#c5
https://reviews.llvm.org/D48036
___
cfe-commits mailing l
rkirsling updated this revision to Diff 150984.
rkirsling added a comment.
Addressed feedback—thank you for the review!
Repository:
rC Clang
https://reviews.llvm.org/D46024
Files:
docs/ClangFormatStyleOptions.rst
include/clang/Format/Format.h
lib/Format/Format.cpp
lib/Format/TokenAnn
On Tue, Jun 12, 2018 at 4:43 AM Hans Wennborg wrote:
> Actually, maybe switching the order from "not env ... %clang" to "env
> ... not %clang" might work...
>
Thanks, I was going to try that next.
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
Author: george.karpenkov
Date: Tue Jun 12 12:08:00 2018
New Revision: 334525
URL: http://llvm.org/viewvc/llvm-project?rev=334525&view=rev
Log:
[analyzer] [NFC] Unify Minimal and Extensive diagnostics.
Once we removed AlternateExtensive, I've looked closer into the
difference between Minimal and E
Author: george.karpenkov
Date: Tue Jun 12 12:08:17 2018
New Revision: 334526
URL: http://llvm.org/viewvc/llvm-project?rev=334526&view=rev
Log:
[analyzer] [NFC] Now let's have only one place for diagnostics generation
Differential Revision: https://reviews.llvm.org/D47808
Modified:
cfe/trunk/
This revision was automatically updated to reflect the committed changes.
Closed by commit rC334525: [analyzer] [NFC] Unify Minimal and Extensive
diagnostics. (authored by george.karpenkov, committed by ).
Herald added a subscriber: cfe-commits.
Changed prior to commit:
https://reviews.llvm.org
sammccall added a comment.
Not ignoring this patch: the implementation LG, whether it's the right design
depends on where https://reviews.llvm.org/D47935 ends up I think.
(I suspect this is what we want, is there any urgency to landing this part?)
Repository:
rCTE Clang Tools Extra
https://r
This revision was automatically updated to reflect the committed changes.
Closed by commit rC334526: [analyzer] [NFC] Now let's have only one place
for diagnostics generation (authored by george.karpenkov, committed by ).
Herald added a subscriber: cfe-commits.
Changed prior to commit:
https://
krasimir created this revision.
Herald added a subscriber: cfe-commits.
The added test case was currently crashing with an assertion:
Repository:
rC Clang
https://reviews.llvm.org/D48089
Files:
lib/Format/BreakableToken.cpp
unittests/Format/FormatTestComments.cpp
Index: unittests/Forma
sammccall added a comment.
Sorry for the delay on this change. There's a bunch of complexity in this
problem that I haven't seen how to slice through:
1. the signals needed seem like a weird fit for the Symbol*Signals structs for
some reason (maybe my misdesign)
2. the inconsistency between how
Author: krasimir
Date: Tue Jun 12 12:33:15 2018
New Revision: 334527
URL: http://llvm.org/viewvc/llvm-project?rev=334527&view=rev
Log:
[clang-format] Fix crash while reflowing backslash in comments
Summary:
The added test case was currently crashing with an assertion:
```
krasimir@krasimir> cat t
This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rC334527: [clang-format] Fix crash while reflowing backslash
in comments (authored by krasimir, committed by ).
Changed pri
ormris added inline comments.
Comment at: lib/StaticAnalyzer/Core/LoopWidening.cpp:89
+new Callback(LCtx, MRMgr, ITraits));
+ Finder.matchAST(ASTCtx);
+
ormris wrote:
> NoQ wrote:
> > NoQ wrote:
> > > george.karpenkov wrote:
> > > > ormris wr
NoQ added inline comments.
Comment at: lib/StaticAnalyzer/Core/LoopWidening.cpp:89
+new Callback(LCtx, MRMgr, ITraits));
+ Finder.matchAST(ASTCtx);
+
ormris wrote:
> ormris wrote:
> > NoQ wrote:
> > > NoQ wrote:
> > > > george.karpenkov wrote
ormris added inline comments.
Comment at: lib/StaticAnalyzer/Core/LoopWidening.cpp:89
+new Callback(LCtx, MRMgr, ITraits));
+ Finder.matchAST(ASTCtx);
+
NoQ wrote:
> ormris wrote:
> > ormris wrote:
> > > NoQ wrote:
> > > > NoQ wrote:
> > > >
Author: phosek
Date: Tue Jun 12 13:00:50 2018
New Revision: 334531
URL: http://llvm.org/viewvc/llvm-project?rev=334531&view=rev
Log:
[AArch64] Support reserving x20 register
Register x20 is a callee-saved register which may be used for other
purposes in certain contexts, for example to hold speci
This revision was automatically updated to reflect the committed changes.
Closed by commit rC334531: [AArch64] Support reserving x20 register (authored
by phosek, committed by ).
Herald added a subscriber: cfe-commits.
Changed prior to commit:
https://reviews.llvm.org/D46552?vs=150601&id=151006
Hello Hans,
The test Driver/crash-report-modules.m still fails on one of windows
builder:
http://lab.llvm.org:8011/builders/llvm-clang-x86_64-expensive-checks-win/builds/10221
. . .
Failing Tests (1):
Clang :: Driver/crash-report-modules.m
Please have a look?
Thanks
Galina
On Tue, Jun
Author: maskray
Date: Tue Jun 12 13:44:11 2018
New Revision: 334539
URL: http://llvm.org/viewvc/llvm-project?rev=334539&view=rev
Log:
Work around false -Wmissing-braces warning from old clang which has been fixed
in r314838
Modified:
cfe/trunk/lib/StaticAnalyzer/Frontend/AnalysisConsumer.cpp
aprantl accepted this revision.
aprantl added a comment.
This revision is now accepted and ready to land.
That should work. Thanks!
https://reviews.llvm.org/D47996
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin
The length of that path is about 257, or very near MAX_PATH, which suggests
that the version of rm you are using does not tolerate deep paths. This has
been a long standing problem, and our solution to it was to install a
special version of rm.exe on all of our buildbots that reliably handles
long
Author: george.karpenkov
Date: Tue Jun 12 13:50:44 2018
New Revision: 334540
URL: http://llvm.org/viewvc/llvm-project?rev=334540&view=rev
Log:
[analyzer] [NFC] Remove most usages of getEndPath
getEndPath is a problematic API, because it's not clear when it's called
(hint: not always at the end of
This revision was automatically updated to reflect the committed changes.
Closed by commit rC334540: [analyzer] [NFC] Remove most usages of getEndPath
(authored by george.karpenkov, committed by ).
Herald added a subscriber: cfe-commits.
Changed prior to commit:
https://reviews.llvm.org/D48042?
Author: george.karpenkov
Date: Tue Jun 12 13:51:01 2018
New Revision: 334541
URL: http://llvm.org/viewvc/llvm-project?rev=334541&view=rev
Log:
[analyzer] [NFC] Move ::dump methods from BugReporter.cpp to PathDiagnostics.cpp
BugReporter.cpp is already severely overloaded, and those dump methods
ar
Author: george.karpenkov
Date: Tue Jun 12 13:51:19 2018
New Revision: 334542
URL: http://llvm.org/viewvc/llvm-project?rev=334542&view=rev
Log:
[analyzer] [NFC] Remove "removeInvalidation" from visitor API
removeInvalidation is a very problematic API, as it makes suppression
order-dependent.
Moreo
This revision was automatically updated to reflect the committed changes.
Closed by commit rC334541: [analyzer] [NFC] Move ::dump methods from
BugReporter.cpp to PathDiagnostics.cpp (authored by george.karpenkov, committed
by ).
Herald added a subscriber: cfe-commits.
Changed prior to commit:
This revision was automatically updated to reflect the committed changes.
Closed by commit rL334542: [analyzer] [NFC] Remove
"removeInvalidation" from visitor API (authored by george.karpenkov,
committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.ll
This revision was automatically updated to reflect the committed changes.
Closed by commit rC334542: [analyzer] [NFC] Remove
"removeInvalidation" from visitor API (authored by george.karpenkov,
committed by ).
Herald added a subscriber: cfe-commits.
Changed prior to commit:
https://reviews.llv
leonardchan updated this revision to Diff 151016.
leonardchan marked 9 inline comments as done.
Repository:
rC Clang
https://reviews.llvm.org/D46915
Files:
include/clang/AST/ASTContext.h
include/clang/AST/Expr.h
include/clang/AST/OperationKinds.def
include/clang/AST/RecursiveASTVisitor
efriedma accepted this revision.
efriedma added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D48053
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/c
leonardchan added inline comments.
Comment at: include/clang/Basic/TargetInfo.h:89
+ // corresponding unsaturated types.
+ unsigned char ShortAccumFBits, ShortAccumIBits;
+ unsigned char AccumFBits, AccumIBits;
ebevhan wrote:
> leonardchan wrote:
> > ebevhan w
rnk added a comment.
In https://reviews.llvm.org/D47988#1127432, @smeenai wrote:
> Any idea why we would see inlining in one case and not the other? i686 vs.
> x86-64 doesn't make any difference, and neither does -Os vs. -O1 vs. -O2.
My theory is that the inliner is attempting to avoid inlinin
leonardchan abandoned this revision.
leonardchan added a comment.
No longer setting fractional and integral bits at configure time. These values
are set and checked in TargetInfo.
Repository:
rC Clang
https://reviews.llvm.org/D47030
___
cfe-comm
Author: ab
Date: Tue Jun 12 14:27:36 2018
New Revision: 334550
URL: http://llvm.org/viewvc/llvm-project?rev=334550&view=rev
Log:
[CMake][Darwin] Match cxx-headers -> cxx_headers libcxx target rename.
This was changed in r334477.
Modified:
cfe/trunk/cmake/caches/Apple-stage2.cmake
Modified:
Hey Petr,
FYI: clang has cmake caches that listed cxx-headers as a dependency;
I fixed that in:
r334550 [CMake][Darwin] Match cxx-headers -> cxx_headers libcxx target rename.
-Ahmed
On Mon, Jun 11, 2018 at 11:58 PM, Petr Hosek via cfe-commits
wrote:
> Author: phosek
> Date: Mon Jun 11 23:58:06
MarcoFalke created this revision.
Repository:
rC Clang
https://reviews.llvm.org/D48098
Files:
tools/clang-format/clang-format-diff.py
Index: tools/clang-format/clang-format-diff.py
===
--- tools/clang-format/clang-format-diff.
MarcoFalke updated this revision to Diff 151038.
MarcoFalke added a comment.
In python2.7:
TypeError: 'encoding' is an invalid keyword argument for this function
So remove it for now.
https://reviews.llvm.org/D48098
Files:
tools/clang-format/clang-format-diff.py
Index: tools/clang-format/c
ormris updated this revision to Diff 151043.
ormris added a comment.
- Use match function iterators rather than a callback class
- Update test
Repository:
rC Clang
https://reviews.llvm.org/D47044
Files:
lib/StaticAnalyzer/Core/LoopWidening.cpp
test/Analysis/loop-widening-preserve-referen
george.karpenkov accepted this revision.
george.karpenkov added a comment.
This revision is now accepted and ready to land.
Looks good to me, apart from the nit on an unused header.
Comment at: lib/StaticAnalyzer/Core/LoopWidening.cpp:21
#include "clang/StaticAnalyzer/Core/Pat
ormris updated this revision to Diff 151046.
ormris added a comment.
Remove unneeded header
Repository:
rC Clang
https://reviews.llvm.org/D47044
Files:
lib/StaticAnalyzer/Core/LoopWidening.cpp
test/Analysis/loop-widening-preserve-reference-type.cpp
Index: test/Analysis/loop-widening-pr
Meinersbur created this revision.
Meinersbur added reviewers: hfinkel, TylerNowicki, ABataev, thakis, rjmccall,
george.burgess.iv, nicholas, nlewycky.
Herald added subscribers: atanasyan, zzheng.
... instead of prepending it at the beginning (the original behavior since
implemented in r122535 20
NoQ accepted this revision.
NoQ added a comment.
I'm still curious whether this also works:
void foo() {
const A &x = B();
bar();
}
void bar() {
for (int i = 0; i < 10; ++i) {}
}
Though we can land this patch and deal with this later.
Repository:
rC Clang
https://revi
ormris marked an inline comment as done.
ormris added a comment.
Sounds good. I'll go ahead and commit this. Thanks for the review!
Repository:
rC Clang
https://reviews.llvm.org/D47044
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http:
ormris added a comment.
Hmm... I'll take a look.
Repository:
rC Clang
https://reviews.llvm.org/D47044
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
1 - 100 of 130 matches
Mail list logo
