[PATCH] D49573: [CMake] Option to control whether shared/static library is installed

ldionne added a comment. Can't you simply set `LIBCXX_ENABLE_SHARED=OFF` when you don't want to build/install the shared library and `LIBCXX_ENABLE_STATIC=OFF` for the static library? Repository: rL LLVM https://reviews.llvm.org/D49573 ___

[PATCH] D49591: [clangd] Introduce search Tokens and trigram generation algorithms

sammccall added a comment. Looks really nice! Only major issue is the query trigrams don't look right. Otherwise, some style nits and fixes that seem to have gotten lost. Comment at: clang-tools-extra/clangd/index/dex/Token.cpp:28 + +llvm::StringRef Token::data() const {

r337706 - [Sema] Don't emit -Wmemset-transposed-args for memset(p, 0, 0)

Author: epilk Date: Mon Jul 23 09:24:14 2018 New Revision: 337706 URL: http://llvm.org/viewvc/llvm-project?rev=337706=rev Log: [Sema] Don't emit -Wmemset-transposed-args for memset(p,0,0) Thanks to Arthur O'Dwyer for the suggestion! Modified: cfe/trunk/lib/Sema/SemaChecking.cpp

[PATCH] D48717: [clang-tidy] fix PR36489 - respect deduced pointer types from auto as well

aaron.ballman accepted this revision. aaron.ballman added a comment. Yes, this looks good to me. Thanks! Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D48717 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D49638: [libcxxabi] Implement a GCC compatible SEH unwinding personality, __gxx_personality_seh0

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm Repository: rCXXA libc++abi https://reviews.llvm.org/D49638 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D49267: [clangd] Watch for changes in compile_commands.json

simark added a comment. In https://reviews.llvm.org/D49267#1171286, @ilya-biryukov wrote: > Thanks for putting up this change! It can be really annoying that clangd does > not pick up the compile commands that got updated. > > A few things of the top of my head on why we might want to punt on

[PATCH] D49627: [CFG] [analyzer] Constructors of member CXXOperatorCallExpr's argument 0 are not argument constructors.

george.karpenkov accepted this revision. george.karpenkov added a comment. This revision is now accepted and ready to land. I take it we are crashing otherwise? Comment at: include/clang/Analysis/ConstructionContext.h:606 + unsigned Index; + // Whether the object needs to be

[PATCH] D49629: [CMake] Fix the setting of LIBCXX_HEADER_DIR

aheejin added a comment. Ping Repository: rCXX libc++ https://reviews.llvm.org/D49629 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D49511: [Sema/Attribute] Check for noderef attribute

leonardchan added inline comments. Comment at: include/clang/Basic/AttrDocs.td:3426 + let Content = [{ +The ``noderef`` attribute causes clang to throw a warning whenever a pointer marked with +this attribute is dereferenced. This is ideally used with pointers that point to

[PATCH] D49688: [Sema] Fix a crash when a BlockExpr appears in a default-member-initializer of a class template

erik.pilkington added a comment. (Forgot to add rdar://41200624) Repository: rC Clang https://reviews.llvm.org/D49688 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D49244: Always search sysroot for GCC installs

greened added a comment. Ping. Repository: rC Clang https://reviews.llvm.org/D49244 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: r337433 - [clang]: Add support for "-fno-delete-null-pointer-checks"

Agree, will try to add separate testcase soon. Thanks, Manoj On Mon, Jul 23, 2018 at 12:39 PM Richard Smith wrote: > Hi Manoj, > > Please can you add better test coverage that we don't emit 'nonnull' > annotations for reference parameters / return values? At the moment, the > only such test

[PATCH] D49338: Implement - P0122R7

mclow.lists marked 5 inline comments as done. mclow.lists added a comment. I think I've answered all of Louis' questions that don't require code changes. New patch will be coming soon. Comment at: include/span:217 +using pointer= _Tp *; +using

[PATCH] D49652: Apply -fdebug-prefix-map in reverse of command line order

alxu added a comment. I was just going to run llvm-dwarfdump. Repository: rC Clang https://reviews.llvm.org/D49652 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D49704: Fix typo in test/CodeGen/Mips/dins.ll

pcc accepted this revision. pcc added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D49704 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r337728 - Separate out the initialization kind for a statement expression result

Author: rsmith Date: Mon Jul 23 12:19:08 2018 New Revision: 337728 URL: http://llvm.org/viewvc/llvm-project?rev=337728=rev Log: Separate out the initialization kind for a statement expression result from that for a return value. No functionality change intended: I don't believe any of the

r337732 - [ms] Fix mangling of vector types in QMM_Result contexts.

Author: nico Date: Mon Jul 23 13:04:00 2018 New Revision: 337732 URL: http://llvm.org/viewvc/llvm-project?rev=337732=rev Log: [ms] Fix mangling of vector types in QMM_Result contexts. If QMM_Result is set (which it is for return types, RTTI descriptors, and exception type descriptors), tag types

r337746 - [clang-cl] Expose -fblocks and -fno-builtin as driver flags

Author: rnk Date: Mon Jul 23 14:29:43 2018 New Revision: 337746 URL: http://llvm.org/viewvc/llvm-project?rev=337746=rev Log: [clang-cl] Expose -fblocks and -fno-builtin as driver flags Users have requested them. Helps with PR36427. Modified: cfe/trunk/include/clang/Driver/Options.td

[PATCH] D49597: [ms] Fix mangling of vector types in QMM_Result contexts.

thakis closed this revision. thakis added a comment. r337732, thanks! https://reviews.llvm.org/D49597 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D49466: Initial implementation of -fmacro-prefix-map and -ffile-prefix-map

alxu added a comment. FYI, gcc uses the stupid and bad string prefix matching approach. if clang supports the same option, it should have the same behavior. you could decide that it's a bad idea, but then the option should be called something else, otherwise people will have to go back to

[PATCH] D49338: Implement - P0122R7

mclow.lists marked an inline comment as done. mclow.lists added a comment. > I missed the container constructors being `noexcept` Never mind; they're not `noexcept` (and they should not be) https://reviews.llvm.org/D49338 ___ cfe-commits mailing

Re: [libcxx] r337669 - Use possibly cached directory entry values when performing recursive directory iteration.

I think I've found the bug, but I need to spend some more time on it. I've reverted in for now in r337749. /Eric On Mon, Jul 23, 2018 at 1:25 PM Eric Fiselier wrote: > Thanks. I'm looking into this. > > /Eric > > On Mon, Jul 23, 2018 at 12:58 PM Jonas Hahnfeld wrote: > >> Hi Eric, >> >> this

[PATCH] D49688: [Sema] Fix a crash when a BlockExpr appears in a default-member-initializer of a class template

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. It makes sense that the BlockDecl's parent DC is the class, although I think it would be even better if we took a page from Swift and make a special DC for initializer expressions. I

[PATCH] D49615: [ASTMatchers] Add an isMain() matcher

This revision was automatically updated to reflect the committed changes. Closed by commit rC337761: [ASTMatchers] Add an isMain() matcher (authored by george.karpenkov, committed by ). Herald added a subscriber: cfe-commits. Changed prior to commit:

r337760 - [ASTMatchers] [NFC] Regenerate HTML docs.

Author: george.karpenkov Date: Mon Jul 23 15:29:10 2018 New Revision: 337760 URL: http://llvm.org/viewvc/llvm-project?rev=337760=rev Log: [ASTMatchers] [NFC] Regenerate HTML docs. Modified: cfe/trunk/docs/LibASTMatchersReference.html Modified: cfe/trunk/docs/LibASTMatchersReference.html

r337761 - [ASTMatchers] Add an isMain() matcher

Author: george.karpenkov Date: Mon Jul 23 15:29:35 2018 New Revision: 337761 URL: http://llvm.org/viewvc/llvm-project?rev=337761=rev Log: [ASTMatchers] Add an isMain() matcher Differential Revision: https://reviews.llvm.org/D49615 Modified: cfe/trunk/docs/LibASTMatchersReference.html

Re: [libcxx] r337669 - Use possibly cached directory entry values when performing recursive directory iteration.

Hi Jonas, I believe I fixed the issue, and I've recommitted the change as r337765. Please let me know if you still see the failures. I think there might be a lingering issues with how we handle DT_UNKNOWN. /Eric On Mon, Jul 23, 2018 at 3:53 PM Eric Fiselier wrote: > I think I've found the

[PATCH] D49647: [libcxx] Library support for contracts (C++2a)

hamzasood updated this revision to Diff 156857. hamzasood added a comment. - Made the suggested test changes. The compiler is meant to create these; Clang doesn't do this yet but I'm working on the implementation. I was under the impression that the compiler support would require the library

Re: [libcxx] r337669 - Use possibly cached directory entry values when performing recursive directory iteration.

Thanks. I'm looking into this. /Eric On Mon, Jul 23, 2018 at 12:58 PM Jonas Hahnfeld wrote: > Hi Eric, > > this breaks > test/std/experimental/filesystem/class.rec.dir.itr/rec.dir.itr.members/increment.pass.cpp > > for me: > In access_denied_on_recursion_test_case():176 Assertion

[PATCH] D49526: Updated llvm-proto-fuzzer to execute the compiled code

emmettneyman updated this revision to Diff 156862. emmettneyman added a comment. Made fixes to patch, rebased CMake file Repository: rC Clang https://reviews.llvm.org/D49526 Files: clang/tools/clang-fuzzer/handle-llvm/CMakeLists.txt clang/tools/clang-fuzzer/handle-llvm/handle_llvm.cpp

[PATCH] D49403: More aggressively complete RecordTypes with Function Pointers

rjmccall added a comment. Are you sure you shouldn't do it based on some sort of actual annotation based on the frontend's knowledge of types instead of adding semantics for LLVM IR types that were never intended? https://reviews.llvm.org/D49403

r337738 - Update to -r337585, allow scoped enum inits in -pedantic

Author: erichkeane Date: Mon Jul 23 14:08:13 2018 New Revision: 337738 URL: http://llvm.org/viewvc/llvm-project?rev=337738=rev Log: Update to -r337585, allow scoped enum inits in -pedantic Modified: cfe/trunk/include/clang/AST/Type.h cfe/trunk/lib/AST/Type.cpp

[libcxxabi] r337754 - Implement a GCC compatible SEH unwinding personality, __gxx_personality_seh0

Author: mstorsjo Date: Mon Jul 23 15:09:23 2018 New Revision: 337754 URL: http://llvm.org/viewvc/llvm-project?rev=337754=rev Log: Implement a GCC compatible SEH unwinding personality, __gxx_personality_seh0 This allows handling SEH based exceptions, with unwind functions provided by libgcc.

[PATCH] D49067: Stop wrapping __has_include in another macro

EricWF added a reviewer: mclow.lists. EricWF added a subscriber: mclow.lists. EricWF added a comment. Where are the special lexing rules specified? Comment at: include/__config:153 +#ifndef __has_include +#define __has_include(...) 0 #endif I do prefer not

[PATCH] D49067: Stop wrapping __has_include in another macro

arichardson added a comment. In https://reviews.llvm.org/D49067#1172500, @EricWF wrote: > Where are the special lexing rules specified? In https://bugs.llvm.org/show_bug.cgi?id=37990#c1 @rsmith wrote: > The C++ standard appears to be missing a rule that says that a __has_include > token

Re: [libcxx] r337669 - Use possibly cached directory entry values when performing recursive directory iteration.

Sorry for the repeated emails. I did more digging and we were indeed handling DT_UNKNOWN incorrectly. I've fixed that in r337768. /Eric On Mon, Jul 23, 2018 at 4:43 PM Eric Fiselier wrote: > Hi Jonas, > > I believe I fixed the issue, and I've recommitted the change as r337765. > Please let me

[PATCH] D49597: [ms] Fix mangling of vector types in QMM_Result contexts.

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm https://reviews.llvm.org/D49597 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r337743 - Fold -Wreturn-stack-address into general initialization lifetime

Author: rsmith Date: Mon Jul 23 14:21:22 2018 New Revision: 337743 URL: http://llvm.org/viewvc/llvm-project?rev=337743=rev Log: Fold -Wreturn-stack-address into general initialization lifetime checking. Modified: cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td

r337744 - Do not try to perform lifetime-extension through conditional

Author: rsmith Date: Mon Jul 23 14:21:24 2018 New Revision: 337744 URL: http://llvm.org/viewvc/llvm-project?rev=337744=rev Log: Do not try to perform lifetime-extension through conditional expressions. CodeGen can't cope with that yet. Instead, produce a "not supported" warning for now and don't

[PATCH] D49573: [CMake] Option to control whether shared/static library is installed

ldionne accepted this revision. ldionne added a comment. This revision is now accepted and ready to land. Ah, so you mean you need it for libc++abi because you want to build them but not install them (so they're linked into libc++)? Then LGTM as-is. I'd like to see what Eric has to say though.

[PATCH] D49091: Warn about usage of __has_include/__has_include_next in macro expansions

arichardson added a comment. Ping? Repository: rC Clang https://reviews.llvm.org/D49091 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D49067: Stop wrapping __has_include in another macro

arichardson added a comment. Ping? Repository: rCXX libc++ https://reviews.llvm.org/D49067 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D49652: Apply -fdebug-prefix-map in reverse of command line order

alxu added a comment. my general theory is that it's better to have tests that test everything at once if possible, but I guess it's unlikely enough that the debug info path will be correct in the IR and then not correct in the generated file and that that won't be caught by LLVM tests.

[PATCH] D48786: [Preprocessor] Stop entering included files after hitting a fatal error.

vsapsai added inline comments. Comment at: clang/lib/Lex/PPDirectives.cpp:1875 + // Stop further preprocessing if a fatal error has occurred. Any diagnostics + // we might have raised will not be visible. + if (ShouldEnter && Diags->hasFatalErrorOccurred())

r337767 - Support lifetime-extension of conditional temporaries.

Author: rsmith Date: Mon Jul 23 15:56:45 2018 New Revision: 337767 URL: http://llvm.org/viewvc/llvm-project?rev=337767=rev Log: Support lifetime-extension of conditional temporaries. Modified: cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td cfe/trunk/lib/CodeGen/CGCleanup.cpp

[PATCH] D49338: Implement - P0122R7

ldionne requested changes to this revision. ldionne added a comment. This revision now requires changes to proceed. My comments are based off of http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2018/p0122r7.pdf. Comment at: include/span:189 +struct

[PATCH] D49597: [ms] Fix mangling of vector types in QMM_Result contexts.

thakis updated this revision to Diff 156858. thakis added a comment. Address comments. https://reviews.llvm.org/D49597 Files: clang/lib/AST/MicrosoftMangle.cpp clang/test/CodeGenCXX/mangle-ms-vector-types.cpp Index: clang/test/CodeGenCXX/mangle-ms-vector-types.cpp

[PATCH] D49597: [ms] Fix mangling of vector types in QMM_Result contexts.

thakis marked 2 inline comments as done. thakis added a comment. Thanks! All done. https://reviews.llvm.org/D49597 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D49652: Apply -fdebug-prefix-map in reverse of command line order

probinson added a comment. Re. SmallVector versus std::vector, they are functionally similar but have different memory-allocation behaviors. SmallVector includes a vector of N elements (where N is the template parameter) so does no dynamic allocation until you have more than N elements; but

[PATCH] D49688: [Sema] Fix a crash when a BlockExpr appears in a default-member-initializer of a class template

rjmccall added a comment. I honestly don't know why the `BlockDecl` is in the members list in the first place; that seems wrong, for the same reason that we wouldn't (I assume?) consider a lambda's implicit record to be a member. Repository: rC Clang https://reviews.llvm.org/D49688

Re: [PATCH] D45124: [CodeGen] Record if a C++ record is a trivial type

Test? On Mon, Jul 23, 2018 at 11:49 PM, Aaron Smith via Phabricator via llvm-commits wrote: > This revision was automatically updated to reflect the committed changes. > Closed by commit rC337736: [CodeGen] Record if a C++ record is a trivial type > (authored by asmith, committed by ). > >

[PATCH] D49403: More aggressively complete RecordTypes with Function Pointers

olga.chupina added a comment. Yes, correct. https://reviews.llvm.org/D49403 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: r337627 - Fold dangling-field warning into general initialization lifetime checks.

Thanks, fixed and re-committed in r337726. On Sun, 22 Jul 2018 at 23:33, Ilya Biryukov via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Reverted in r337671 > > On Mon, Jul 23, 2018 at 8:24 AM Ilya Biryukov > wrote: > >> Hi Richard, >> >> this commit seems to cause invalid warning in the

[PATCH] D49338: Implement - P0122R7

mclow.lists marked 13 inline comments as done. mclow.lists added a comment. I missed the container constructors being `noexcept`, and the asserts on `operator[]` and `operator()` are half done (stupid signed indicies). I'll wait for other feedback before doing those bits.

[PATCH] D49573: [CMake] Option to control whether shared/static library is installed

phosek added a comment. You're right that we don't need these flags for libc++, we only need them for libc++abi and libunwind for the cases when one of these is linked into libc++ or libc++abi respectively. I added them for consistency, but I'm fine dropping them from libc++, would that be

[PATCH] D49652: Apply -fdebug-prefix-map in reverse of command line order

probinson added a comment. In https://reviews.llvm.org/D49652#1172352, @alxu wrote: > I was just going to run llvm-dwarfdump. Well, that's one of those quirks I mentioned. This is a Clang change, and Clang tests should exercise as little of LLVM as possible. That means you don't generate

[libcxx] r337749 - Revert "Use possibly cached directory entry values when performing recursive directory iteration."

Author: ericwf Date: Mon Jul 23 14:52:29 2018 New Revision: 337749 URL: http://llvm.org/viewvc/llvm-project?rev=337749=rev Log: Revert "Use possibly cached directory entry values when performing recursive directory iteration." This reverts commit 04ce4aef00d3ee508327f6cf7bf1b1d200ab6238.

[libcxxabi] r337759 - [demangler] call terminate() if allocation failed

Author: epilk Date: Mon Jul 23 15:23:04 2018 New Revision: 337759 URL: http://llvm.org/viewvc/llvm-project?rev=337759=rev Log: [demangler] call terminate() if allocation failed We really should set *status to memory_alloc_failure, but we need to refactor the demangler a bit to properly propagate

[PATCH] D49688: [Sema] Fix a crash when a BlockExpr appears in a default-member-initializer of a class template

This revision was automatically updated to reflect the committed changes. Closed by commit rC337766: [Sema] Fix crash on BlockExprs in a default member initializers (authored by epilk, committed by ). Changed prior to commit: https://reviews.llvm.org/D49688?vs=156848=156906#toc Repository:

r337766 - [Sema] Fix crash on BlockExprs in a default member initializers

Author: epilk Date: Mon Jul 23 15:47:37 2018 New Revision: 337766 URL: http://llvm.org/viewvc/llvm-project?rev=337766=rev Log: [Sema] Fix crash on BlockExprs in a default member initializers Clang would crash when instantiating a BlockDecl that appeared in a default-member-initializer of a class

[libcxx] r337768 - Handle DT_UNKNOWN correctly during directory iteration.

Author: ericwf Date: Mon Jul 23 15:58:46 2018 New Revision: 337768 URL: http://llvm.org/viewvc/llvm-project?rev=337768=rev Log: Handle DT_UNKNOWN correctly during directory iteration. Unlike stat and lstat, where unknown really means we know it's something weird, during directory iteration

[PATCH] D49703: [analyzer] pr38273: Admit that we can't handle the newly produced Loc<>NonLoc comparisons.

This revision was automatically updated to reflect the committed changes. Closed by commit rC337769: [analyzer] pr38273: Legalize LocNonLoc comparison symbols. (authored by dergachev, committed by ). Repository: rC Clang https://reviews.llvm.org/D49703 Files:

[PATCH] D48896: [libcxx][c++17] P0083R5: Splicing Maps and Sets Part 2: merge

erik.pilkington updated this revision to Diff 156912. erik.pilkington added a comment. In this new patch: - Rebase on top of changes in https://reviews.llvm.org/D46845 - Move in some forward decls that I accidentally left in https://reviews.llvm.org/D46845 - Add some missing visibility

r337769 - [analyzer] pr38273: Legalize Loc<>NonLoc comparison symbols.

Author: dergachev Date: Mon Jul 23 16:09:44 2018 New Revision: 337769 URL: http://llvm.org/viewvc/llvm-project?rev=337769=rev Log: [analyzer] pr38273: Legalize Loc<>NonLoc comparison symbols. Remove an assertion in RangeConstraintManager that expects such symbols to never appear, while admitting

Re: r337433 - [clang]: Add support for "-fno-delete-null-pointer-checks"

Hi Manoj, Please can you add better test coverage that we don't emit 'nonnull' annotations for reference parameters / return values? At the moment, the only such test coverage has been added to test files that are testing unrelated things, which seems inappropriate. A separate test file that

[PATCH] D49403: More aggressively complete RecordTypes with Function Pointers

rjmccall added a comment. Sorry, I'm not following you. Are you doing some sort of type-based security analysis based on LLVM IR types? https://reviews.llvm.org/D49403 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D45124: [CodeGen] Record if a C++ record is a trivial type

This revision was automatically updated to reflect the committed changes. Closed by commit rC337736: [CodeGen] Record if a C++ record is a trivial type (authored by asmith, committed by ). Repository: rC Clang https://reviews.llvm.org/D45124 Files: lib/CodeGen/CGDebugInfo.cpp Index:

[PATCH] D49688: [Sema] Fix a crash when a BlockExpr appears in a default-member-initializer of a class template

erik.pilkington added a comment. In https://reviews.llvm.org/D49688#1172269, @rjmccall wrote: > I honestly don't know why the `BlockDecl` is in the members list in the first > place; that seems wrong, for the same reason that we wouldn't (I assume?) > consider a lambda's implicit record to be

[PATCH] D49338: Implement - P0122R7

ldionne added inline comments. Comment at: include/span:217 +using pointer= _Tp *; +using const_pointer = const _Tp *; // not in standard +using reference = _Tp &; mclow.lists wrote: > ldionne wrote: > > Why are

r337736 - [CodeGen] Record if a C++ record is a trivial type

Author: asmith Date: Mon Jul 23 13:49:07 2018 New Revision: 337736 URL: http://llvm.org/viewvc/llvm-project?rev=337736=rev Log: [CodeGen] Record if a C++ record is a trivial type Summary: This has a dependence on D45122 Reviewers: rnk, zturner, llvm-commits, aleksandr.urakov Reviewed By: rnk

[PATCH] D49638: [libcxxabi] Implement a GCC compatible SEH unwinding personality, __gxx_personality_seh0

This revision was automatically updated to reflect the committed changes. Closed by commit rL337754: Implement a GCC compatible SEH unwinding personality, __gxx_personality_seh0 (authored by mstorsjo, committed by ). Herald added subscribers: llvm-commits, christof. Changed prior to commit:

[libcxx] r337765 - Recommit "Use possibly cached directory entry values when performing recursive directory iteration."

Author: ericwf Date: Mon Jul 23 15:40:41 2018 New Revision: 337765 URL: http://llvm.org/viewvc/llvm-project?rev=337765=rev Log: Recommit "Use possibly cached directory entry values when performing recursive directory iteration." The initial patch didn't correctly handle systems when the dirent

[PATCH] D49703: [analyzer] pr38273: Admit that we can't handle the newly produced Loc<>NonLoc comparisons.

NoQ created this revision. NoQ added reviewers: dcoughlin, xazax.hun, a.sidorin, george.karpenkov, szepet, rnkovacs, mikhail.ramalho. Herald added subscribers: cfe-commits, baloghadamsoftware. This patch fixes the crash caused by https://reviews.llvm.org/D48650 and reported as

[libcxx] r337764 - Fix accidentally removed test.

Author: ericwf Date: Mon Jul 23 15:39:56 2018 New Revision: 337764 URL: http://llvm.org/viewvc/llvm-project?rev=337764=rev Log: Fix accidentally removed test. When adding the new tests for the filesystem_error::what method, I incorrectly removed a test case and replaced it with something else.

[PATCH] D49704: Fix typo in test/CodeGen/Mips/dins.ll

thomasanderson created this revision. thomasanderson added a reviewer: pcc. Herald added subscribers: atanasyan, arichardson, sdardis. https://reviews.llvm.org/D49704 Files: test/CodeGen/Mips/dins.ll Index: test/CodeGen/Mips/dins.ll

[PATCH] D49704: Fix typo in test/CodeGen/Mips/dins.ll

thomasanderson added a comment. pcc ptal I've been granted commit-after-approval, and this is my test CL. https://reviews.llvm.org/D49704 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D48786: [Preprocessor] Stop entering included files after hitting a fatal error.

vsapsai updated this revision to Diff 156911. vsapsai added a comment. - Tweak the comment according to review comments. Undiscussed changes: we don't stop preprocessing entirely, only in included files; not using better-sounding "skip" deliberately as it might be confused with `FileSkipped`

[PATCH] D49704: Fix typo in test/CodeGen/Mips/dins.ll

This revision was automatically updated to reflect the committed changes. Closed by commit rL337771: Fix typo in test/CodeGen/Mips/dins.ll (authored by thomasanderson, committed by ). Herald added subscribers: llvm-commits, jrtc27. Changed prior to commit:

[PATCH] D45124: [CodeGen] Record if a C++ record is a trivial type

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm I still think we probably want to flag individual constructors and destructors as trivial, so we can decide whether to emit them or not in CodeViewDebug.cpp. https://reviews.llvm.org/D45124

[PATCH] D49511: [Sema/Attribute] Check for noderef attribute

leonardchan updated this revision to Diff 156826. leonardchan marked 21 inline comments as done. Repository: rC Clang https://reviews.llvm.org/D49511 Files: include/clang/AST/Type.h include/clang/Basic/Attr.td include/clang/Basic/AttrDocs.td include/clang/Basic/DiagnosticSemaKinds.td

[PATCH] D49158: [clang-tidy] Fixing segfault when there's no IdentifierInfo

juliehockett added a comment. In https://reviews.llvm.org/D49158#1159882, @hokein wrote: > In https://reviews.llvm.org/D49158#1158327, @JonasToth wrote: > > > Is there a way to add a test, that would trigger the old segfault and show > > that it does not happen anymore with this fix? > > > +1,

[PATCH] D49158: [clang-tidy] Fixing segfault when there's no IdentifierInfo

aaron.ballman added a comment. In https://reviews.llvm.org/D49158#1172178, @juliehockett wrote: > In https://reviews.llvm.org/D49158#1159882, @hokein wrote: > > > In https://reviews.llvm.org/D49158#1158327, @JonasToth wrote: > > > > > Is there a way to add a test, that would trigger the old

[PATCH] D49652: Apply -fdebug-prefix-map in reverse of command line order

alxu added a comment. Also, is it right to use SmallVector in one place and vector in the other? I just assumed based on the surrounding declarations, but I really have no idea. Repository: rC Clang https://reviews.llvm.org/D49652 ___

r337703 - [ASTMatchers] add matcher for decltypeType and its underlyingType

Author: jonastoth Date: Mon Jul 23 08:59:27 2018 New Revision: 337703 URL: http://llvm.org/viewvc/llvm-project?rev=337703=rev Log: [ASTMatchers] add matcher for decltypeType and its underlyingType Summary: This patch introduces a new matcher for `DecltypeType` and its underlying type in order to

[PATCH] D48759: [ASTMatchers] add matcher for decltypeType and its underlyingType

This revision was automatically updated to reflect the committed changes. Closed by commit rL337703: [ASTMatchers] add matcher for decltypeType and its underlyingType (authored by JonasToth, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM

[PATCH] D49580: [clang-format] Adding style option for absolute formatting

acoomans added a comment. Also ping @jolesiak since he initially filed the report https://reviews.llvm.org/D49580 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D49403: More aggressively complete RecordTypes with Function Pointers

olga.chupina added a comment. Hello, Since the structure field which is a function pointer appears in the assignment statement, it messes up the type analysis. If it would really be a pointer to a structure then the corresponding assignment could be treated as bad type casting and potentially

[PATCH] D48717: [clang-tidy] fix PR36489 - respect deduced pointer types from auto as well

JonasToth updated this revision to Diff 156812. JonasToth added a comment. rebase to master Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D48717 Files: test/clang-tidy/cppcoreguidelines-pro-bounds-pointer-arithmetic.cpp Index:

[PATCH] D49647: [libcxx] Library support for contracts (C++2a)

mclow.lists added a comment. > Testing whether it's actually hooked up correctly is quite problematic; it > isn't meant to be instantiable. What's the best way to proceed with this? The compiler is supposed to create these - right? Does clang currently do this? - If not, we should wait for

[PATCH] D49580: [clang-format] Adding style option for absolute formatting

acoomans added a comment. I don't know; I just picked a random bug from the Bugzilla to get myself familiarized with the LLVM codebase :) @jolesiak? https://reviews.llvm.org/D49580 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D49627: [CFG] [analyzer] Constructors of member CXXOperatorCallExpr's argument 0 are not argument constructors.

NoQ updated this revision to Diff 156827. NoQ marked an inline comment as done. NoQ added a comment. In https://reviews.llvm.org/D49627#1172023, @george.karpenkov wrote: > I take it we are crashing otherwise? Not yet, but i'm about to commit code that would (https://reviews.llvm.org/D49443).

[PATCH] D49656: [analyzer] Add support for more pointer invalidating functions in InnerPointerChecker

xazax.hun added inline comments. Comment at: lib/StaticAnalyzer/Checkers/InnerPointerChecker.cpp:207 - if (mayInvalidateBuffer(Call)) { -if (const PtrSet *PS = State->get(ObjRegion)) { - // Mark all pointer symbols associated with the deleted object released. -

[PATCH] D49682: [clang-tidy] fix PR36489 - respect deduced pointer types from auto as well

JonasToth created this revision. Herald added subscribers: cfe-commits, kbarton, xazax.hun, nemanjai. The cppcoreguidelines-pro-bounds-pointer-arithmetic warns on all occassion where pointer arithmetic is used, but does not check values where the pointer types is deduced via `auto`. This patch

[PATCH] D49652: Apply -fdebug-prefix-map in reverse of command line order

alxu planned changes to this revision. alxu added a comment. The test syntax looked complicated, and I assumed that the documentation was terrible, like wine's, but it's actually pretty good, so I'll give it a go. I think the order is not really surprising though. It is run from right to left,

[PATCH] D49656: [analyzer] Add support for more pointer invalidating functions in InnerPointerChecker

xazax.hun requested changes to this revision. xazax.hun added a comment. This revision now requires changes to proceed. Some comments, mostly nits inline. Comment at: lib/StaticAnalyzer/Checkers/InnerPointerChecker.cpp:149 +C.addTransition(State); return; + }

[PATCH] D49667: [clangd] Tune down quality score for class constructors so that it's ranked after class types.

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. No opinion on the boost style thing. Comment at: unittests/clangd/QualityTests.cpp:198 EXPECT_LT(Macro.evaluate(), Default.evaluate()); +

Re: r337470 - [Sema] Add a new warning, -Wmemset-transposed-args

Sure, that seems pretty reasonable. r337706. Thanks for the suggestion! On 7/21/18 1:40 PM, Arthur O'Dwyer wrote: In this case Clang is complaining about     memset(complicated-expr, 0, 0); which means that transposing the last two arguments would not "fix" anything. Clang ought to not

[PATCH] D49618: [clang-tidy] remove private decltypeType in TrailingReturnType

JonasToth updated this revision to Diff 156805. JonasToth added a comment. - rebase to master Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D49618 Files: clang-tidy/fuchsia/TrailingReturnCheck.cpp Index: clang-tidy/fuchsia/TrailingReturnCheck.cpp

[PATCH] D49682: [clang-tidy] fix PR36489 - respect deduced pointer types from auto as well

JonasToth updated this revision to Diff 156823. JonasToth added a comment. rebase to master Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D49682 Files: clang-tidy/cppcoreguidelines/ProBoundsPointerArithmeticCheck.cpp

[libcxx] r337727 - [CMake] Fix the setting of LIBCXX_HEADER_DIR

Author: aheejin Date: Mon Jul 23 11:58:12 2018 New Revision: 337727 URL: http://llvm.org/viewvc/llvm-project?rev=337727=rev Log: [CMake] Fix the setting of LIBCXX_HEADER_DIR Reviewers: phosek Subscribers: mgorny, christof, ldionne, cfe-commits Differential Revision:

  1   2   3   >