ldionne added a comment.
In https://reviews.llvm.org/D49240#1195723, @rnk wrote:
> In https://reviews.llvm.org/D49240#1195237, @ldionne wrote:
>
> > In https://reviews.llvm.org/D49240#1195125, @thakis wrote:
> >
> > > When we updated out clang bundle in chromium (which includes libc++
> > >
ldionne added a comment.
In https://reviews.llvm.org/D50534#1194664, @timshen wrote:
> I'm not fully equipped with the context right now, but something doesn't add
> up. if `__neg_chars_.empty()` check is removed, the `(__neg_mask_ == 0)`
> above should be removed too. They have to be
ioeric accepted this revision.
ioeric added a comment.
This revision is now accepted and ready to land.
lg! Thanks for the changes!
Comment at: clang-tools-extra/clangd/index/dex/Trigram.cpp:147
+ if (Chars.size() == 3) {
+const auto Trigram =
+
shuaiwang added a comment.
In https://reviews.llvm.org/D45444#1191874, @JonasToth wrote:
> > Could you give a concrete example of this?
>
> vi llvm/lib/Demangle/ItaniumDemangle.cpp +1762
>
> /home/jonas/opt/llvm/lib/Demangle/ItaniumDemangle.cpp:1762:7: warning:
> variable 'num' of type 'char
hokein accepted this revision.
hokein added a comment.
This revision is now accepted and ready to land.
Looks good with a few nits. Looks like you didn't update the patch correctly.
You have marked comments done, but your code doesn't get changed accordingly.
Please double check with it.
I
simark marked an inline comment as done.
simark added a comment.
In https://reviews.llvm.org/D48687#1195840, @hokein wrote:
> Looks good with a few nits. Looks like you didn't update the patch correctly.
> You have marked comments done, but your code doesn't get changed accordingly.
> Please
Author: george.karpenkov
Date: Fri Aug 10 14:42:19 2018
New Revision: 339476
URL: http://llvm.org/viewvc/llvm-project?rev=339476=rev
Log:
[analyzer] Fix tracking expressions through negation operator
Differential Revision: https://reviews.llvm.org/D50537
Modified:
rnkovacs updated this revision to Diff 160193.
rnkovacs marked 3 inline comments as done.
rnkovacs added a comment.
Address comments & rebase.
https://reviews.llvm.org/D49570
Files:
lib/StaticAnalyzer/Checkers/AllocationState.h
lib/StaticAnalyzer/Checkers/InnerPointerChecker.cpp
rnkovacs marked an inline comment as done.
rnkovacs added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/DanglingInternalBufferChecker.cpp:253
+ allocation_state::getContainerObjRegion(N->getState(), PtrToBuf);
+ const auto *TypedRegion = dyn_cast(ObjRegion);
+
hugoeg updated this revision to Diff 160124.
https://reviews.llvm.org/D50542
Files:
clang-tidy/abseil/AbseilTidyModule.cpp
clang-tidy/abseil/CMakeLists.txt
clang-tidy/abseil/NoInternalDepsCheck.cpp
clang-tidy/abseil/NoInternalDepsCheck.h
docs/ReleaseNotes.rst
kbobyrev updated this revision to Diff 160133.
kbobyrev marked 7 inline comments as done.
kbobyrev added a comment.
Address issues we have discussed with Eric.
https://reviews.llvm.org/D50517
Files:
clang-tools-extra/clangd/index/dex/Iterator.h
This revision was automatically updated to reflect the committed changes.
arphaman marked an inline comment as done.
Closed by commit rCTE339454: [clangd] extend the publishDiagnostics response to
send back fixits to the (authored by arphaman, committed by ).
Changed prior to commit:
aaron.ballman closed this revision.
aaron.ballman marked 2 inline comments as done.
aaron.ballman added a comment.
Thank you for the review and discussion -- I've commit in r339455.
https://reviews.llvm.org/D50055
___
cfe-commits mailing list
mgrang added a comment.
Does the error show up if you build llvm with -DLLVM_REVERSE_ITERATION:ON?
LLVM_REVERSE_ITERATION:BOOL
If enabled, all supported unordered llvm containers would be iterated in
reverse order. This is useful for uncovering non-determinism caused by
iteration of
kbobyrev updated this revision to Diff 160154.
kbobyrev marked 7 inline comments as done.
kbobyrev added a comment.
Address a round of comments.
https://reviews.llvm.org/D50517
Files:
clang-tools-extra/clangd/index/dex/Iterator.h
clang-tools-extra/clangd/index/dex/Trigram.cpp
simark updated this revision to Diff 160175.
simark marked 4 inline comments as done.
simark added a comment.
Latest update.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D48687
Files:
clangd/FindSymbols.cpp
clangd/SourceCode.cpp
clangd/SourceCode.h
clangd/XRefs.cpp
timshen accepted this revision.
timshen added a comment.
This revision is now accepted and ready to land.
That looks more correct to me, thanks! Although I'm still puzzled by the empty
check at all, it's clearly an improvement.
Repository:
rCXX libc++
https://reviews.llvm.org/D50534
cdavis5x updated this revision to Diff 160195.
cdavis5x added a comment.
- Fix outdated comment.
- Make preprocessor conditional more consistent.
- Make some private functions used only in a single file static.
Repository:
rUNW libunwind
https://reviews.llvm.org/D50564
Files:
cdavis5x added inline comments.
Comment at: src/Unwind-seh.cpp:53
+
+/// Exception cleanup routine used by \c __libunwind_frame_consolidate to
+/// regain control after handling an SEH exception.
mstorsjo wrote:
> I don't see any `__libunwind_frame_consolidate`
NoQ accepted this revision.
NoQ added a comment.
This revision is now accepted and ready to land.
I think this is way easier to understand :)
https://reviews.llvm.org/D49570
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
george.karpenkov requested changes to this revision.
george.karpenkov added a comment.
This revision now requires changes to proceed.
Overall: great! Thank you for following this direction!
However, to avoid clutter, could we put all the checker files into a separate
folder, like MPI-Checker?
aaron.ballman added inline comments.
Comment at: lib/Sema/SemaExpr.cpp:14251-14253
+if (const auto *Ptr = dyn_cast(Ty))
+ Inner = Ptr->getPointeeType();
+else if (const auto *Arr = dyn_cast(Ty))
I don't think this strips off sugar from the type, so
aaron.ballman added a comment.
Oops, I hit "Send" too soon. I was going to say that you should also keep an
eye on https://reviews.llvm.org/D50526 because that may impact this patch (or
vice versa if this one lands first).
Repository:
rC Clang
https://reviews.llvm.org/D49511
hugoeg updated this revision to Diff 160168.
hugoeg added a comment.
corrections from comments applied
https://reviews.llvm.org/D50542
Files:
clang-tidy/abseil/AbseilTidyModule.cpp
clang-tidy/abseil/CMakeLists.txt
clang-tidy/abseil/NoInternalDepsCheck.cpp
aaron.ballman requested changes to this revision.
aaron.ballman added inline comments.
This revision now requires changes to proceed.
Comment at: lib/Sema/SemaChecking.cpp:10424
+ // We don't want to warn for system macro.
+
george.karpenkov accepted this revision.
george.karpenkov added a comment.
This revision is now accepted and ready to land.
OK. I'm not a fan of inheritance hierarchies in general (especially if you only
have two cases) but OK if it makes your life easier.
Repository:
rC Clang
nickdesaulniers added inline comments.
Comment at: lib/Sema/SemaChecking.cpp:10424
+ // We don't want to warn for system macro.
+ S.SourceMgr.isInSystemMacro(E->getOperatorLoc()))
+// warn about dropping FP rank.
aaron.ballman wrote:
> This looks
mstorsjo added a comment.
> I've tested this implementation on x86-64 to ensure that it works. All
> libc++abi tests pass, as do all libc++ exception-related tests.
I tested it now as well, and seems to work for my simple testcase.
> ARM still remains to be implemented (@compnerd?).
LLVM
rjmccall added a comment.
You can't test that there's no non-determinism, but you can certainly test that
we emit selectors in sorted order as opposed to the order in which they're
used. I imagine a function with a bunch of `@selector` expressions should be
good enough for that.
Repository:
george.karpenkov added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/CStringSyntaxChecker.cpp:164
+ // - sizeof(dst)
+ if (Append && isSizeof(LenArg, DstArg))
+return true;
george.karpenkov wrote:
> I am confused on what is happening in this
george.karpenkov requested changes to this revision.
george.karpenkov added inline comments.
This revision now requires changes to proceed.
Comment at: lib/StaticAnalyzer/Checkers/CStringSyntaxChecker.cpp:164
+ // - sizeof(dst)
+ if (Append && isSizeof(LenArg, DstArg))
+
aaron.ballman added a comment.
Thank you for working on this -- the approach you've taken looks good, and I
mostly have little nits here and there. I think this is a great refactoring
overall though -- much needed!
Comment at: include/clang/AST/Type.h:1856
+
+ /// Was this
rnk added a comment.
In https://reviews.llvm.org/D49240#1195237, @ldionne wrote:
> In https://reviews.llvm.org/D49240#1195125, @thakis wrote:
>
> > When we updated out clang bundle in chromium (which includes libc++
> > headers), our ios simulator bots regressed debug info size by ~50% due to
mgrang added a comment.
In https://reviews.llvm.org/D50559#1195787, @bmwiedemann wrote:
> got a build failure with this patch added onto 6.0.1
You may have to add:
#include "llvm/ADT/STLExtras.h"
Repository:
rC Clang
https://reviews.llvm.org/D50559
Hi Tom,
I’ll take a look over the weekend and see if I can reproduce locally. It’s odd
that a test for a Windows triple would be behaving differently on a Windows
host.
David
> On 10 Aug 2018, at 18:01, Tom Weaver wrote:
>
> Hi David,
>
> revision 339428 seems to have caused failing tests
nickdesaulniers marked 3 inline comments as done.
nickdesaulniers added a comment.
Thanks for the info, I found
https://gcc.gnu.org/onlinedocs/cpp/Preprocessor-Output.html helpful. How does
this look?
Repository:
rC Clang
https://reviews.llvm.org/D50467
rnk added a comment.
In https://reviews.llvm.org/D49240#1195733, @ldionne wrote:
> Ah, thanks a lot for taking a look! Yes, this makes a lot of sense, since now
> we're not inlining everything anymore. So the code size is actually smaller
> (-9.8%), but there's more symbols because more
kbobyrev created this revision.
kbobyrev added reviewers: ioeric, ilya-biryukov.
Herald added subscribers: arphaman, jkorous, MaskRay.
This patch allows processing DocIDs from iterator using callback so that they
are not stored in a vector if actual DocIDs are not needed.
Such overhead is the
bmwiedemann added a comment.
got a build failure with this patch added onto 6.0.1
Comment at: lib/CodeGen/CGObjCGNU.cpp:3547
+ allSelectors.push_back(entry.first);
+llvm::sort(allSelectors.begin(), allSelectors.end());
compilation failed here:
ldionne added a comment.
I still think we should go forward with this change since the tests _are_
expected to fail on the provided OS X versions, which do not contain the
required operators.
Repository:
rCXX libc++
https://reviews.llvm.org/D50341
deannagarcia created this revision.
deannagarcia added reviewers: alexfh, hokein.
deannagarcia added a project: clang-tools-extra.
Herald added subscribers: xazax.hun, mgorny.
This check ensures that users of Abseil do not open namespace absl in their
code, as that violates our compatibility
nickdesaulniers updated this revision to Diff 160191.
nickdesaulniers added a comment.
- fix up system macro case and add test coverage for that case.
Repository:
rC Clang
https://reviews.llvm.org/D50467
Files:
lib/Sema/SemaChecking.cpp
test/SemaCXX/warn-float-conversion.cpp
Index:
cdavis5x added inline comments.
Comment at: src/libunwind_ext.h:43
+ #if defined(__x86_64__) && !defined(__MINGW64__)
+typedef struct _DISPATCHER_CONTEXT {
+ ULONG64 ControlPc;
mstorsjo wrote:
> What's this all about? winnt.h (from both MSVC and mingw-w64)
This revision was automatically updated to reflect the committed changes.
Closed by commit rCTE339483: [clangd] Avoid duplicates in findDefinitions
response (authored by simark, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D48687?vs=160175=160197#toc
Repository:
rCTE
Author: simark
Date: Fri Aug 10 15:27:53 2018
New Revision: 339483
URL: http://llvm.org/viewvc/llvm-project?rev=339483=rev
Log:
[clangd] Avoid duplicates in findDefinitions response
Summary:
When compile_commands.json contains some source files expressed as
relative paths, we can get duplicate
simark added inline comments.
Comment at: clangd/SourceCode.h:65
/// Get the absolute file path of a given file entry.
TextEdit toTextEdit(const FixItHint , const SourceManager ,
hokein wrote:
> nit: this comment is not needed.
Woops, merge mistake.
rnk added inline comments.
Comment at: src/libunwind_ext.h:43
+ #if defined(__x86_64__) && !defined(__MINGW64__)
+typedef struct _DISPATCHER_CONTEXT {
+ ULONG64 ControlPc;
cdavis5x wrote:
> mstorsjo wrote:
> > What's this all about? winnt.h (from both MSVC and
cdavis5x added a comment.
In https://reviews.llvm.org/D50564#1195794, @mstorsjo wrote:
> > Special thanks to KJK::Hyperion for his excellent series of articles on how
> > EH works on x86-64 Windows. (Seriously, check it out. It's awesome.)
>
> Can you give some links to it? A brief googling
kbobyrev updated this revision to Diff 160104.
kbobyrev marked 12 inline comments as done.
kbobyrev added a comment.
Address most comments.
https://reviews.llvm.org/D50337
Files:
clang-tools-extra/clangd/CMakeLists.txt
clang-tools-extra/clangd/index/dex/DexIndex.cpp
lebedev.ri updated this revision to Diff 160106.
lebedev.ri added a comment.
Rebase (ugh, bitrot), port `test/clang-tidy/hicpp-exception-baseclass.cpp`.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D36892
Files:
test/clang-tidy/check_clang_tidy.py
deannagarcia updated this revision to Diff 160109.
deannagarcia marked 3 inline comments as done.
https://reviews.llvm.org/D50389
Files:
clang-tidy/abseil/AbseilTidyModule.cpp
clang-tidy/abseil/CMakeLists.txt
clang-tidy/abseil/DurationDivisionCheck.cpp
This revision was automatically updated to reflect the committed changes.
Closed by commit rL339437: [clang-tidy] check_clang_tidy.py: support
CHECK-NOTES prefix (authored by lebedevri, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
hugoeg updated this revision to Diff 160112.
hugoeg marked 10 inline comments as done.
hugoeg added a comment.
Applied corrections from first round comments
https://reviews.llvm.org/D50542
Files:
clang-tidy/abseil/AbseilTidyModule.cpp
clang-tidy/abseil/CMakeLists.txt
simark marked 8 inline comments as done.
simark added inline comments.
Comment at: clangd/SourceCode.h:69
+llvm::Optional getRealPath(const FileEntry *F,
+const SourceManager );
ilya-biryukov wrote:
> This function looks
JonasToth added a comment.
LGTM with only the formatting question.
But don't commit before any of the reviewers accepts (@alexfh @aaron.ballman
usually have the last word)
Comment at: clang-tidy/abseil/DurationDivisionCheck.cpp:50
+ *result.SourceManager,
justice_adams created this revision.
justice_adams added a project: clang.
When mounting LLVM source into a windows container in read-only mode, certain
tests fail. Ideally, we want all these tests to pass so that developers can
mount the same source folder into multiple (windows) containers
This revision was automatically updated to reflect the committed changes.
Closed by commit rL339451: [libcxx] Mark charconv tests as failing for previous
libcxx versions. (authored by vsapsai, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
Author: vsapsai
Date: Fri Aug 10 10:03:47 2018
New Revision: 339451
URL: http://llvm.org/viewvc/llvm-project?rev=339451=rev
Log:
[libcxx] Mark charconv tests as failing for previous libcxx versions.
was added in r338479. Previous libcxx versions don't have
this functionality and corresponding
JonasToth added inline comments.
Comment at: clang-tidy/abseil/NoInternalDepsCheck.cpp:24
+
+ Finder->addMatcher(
+ nestedNameSpecifierLoc(loc(specifiesNamespace(namespaceDecl(
hugoeg wrote:
> JonasToth wrote:
> > Actually that one is generally useful.
Eugene.Zelenko added inline comments.
Comment at: docs/ReleaseNotes.rst:58
+
+ Warns Abseil users if they attempt to depend on internal details.
I think will be good idea to omit user, and just refer to code which depend on
internal details. Please
vsapsai added a comment.
Thanks for the review.
Repository:
rL LLVM
https://reviews.llvm.org/D50543
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
arphaman created this revision.
arphaman added reviewers: jkorous, ilya-biryukov, sammccall.
Herald added subscribers: dexonsmith, MaskRay, ioeric.
This patch adds a 'category' extension field to the LSP diagnostic that's sent
by Clangd. This extension is always on by default.
Repository:
ilya-biryukov accepted this revision.
ilya-biryukov added a comment.
This revision is now accepted and ready to land.
LGTM, but let's land together with a dependent revision to hove some code that
actually tests it.
Comment at: include/clang/Lex/Preprocessor.h:313
+ ///
ioeric added inline comments.
Comment at: clang-tools-extra/clangd/index/dex/Trigram.cpp:33
+
+void insertChars(DenseSet , std::string Chars) {
+ const auto Trigram = Token(Token::Kind::Trigram, Chars);
This is probably neater as a lambda in
miyuki updated this revision to Diff 160121.
miyuki edited the summary of this revision.
miyuki added a comment.
Fix handling of homogeneous aggregates of FP16 vectors
https://reviews.llvm.org/D50507
Files:
lib/CodeGen/TargetInfo.cpp
test/CodeGen/arm-vfp16-arguments.c
cdavis5x added a comment.
In https://reviews.llvm.org/D50413#1195101, @mstorsjo wrote:
> @cdavis5x I presume the fact that this one turned out tricky is blocking
> submitting the SEH unwinding patch.
>
> Would it be worth to rework that patch to just use the basic types just like
> libunwind
mgrang added a comment.
Thanks for all your review comments. I will try to address them soon.
Meanwhile, I have started an email thread on the general problem of writing
checkers/sanitizers to detect non-deterministic behaviors. See
deannagarcia added inline comments.
Comment at: clang-tidy/abseil/DurationDivisionCheck.cpp:50
+ *result.SourceManager, result.Context->getLangOpts()),
+ ")");
+}
JonasToth wrote:
> This line looks odd, does it come from clang-format?
george.karpenkov requested changes to this revision.
george.karpenkov added a comment.
This revision now requires changes to proceed.
All the comments above + if anything, should use ASTMatchers.
Repository:
rC Clang
https://reviews.llvm.org/D50488
JonasToth added inline comments.
Comment at: clang-tidy/abseil/DurationDivisionCheck.cpp:29
+ hasSourceExpression(ignoringParenCasts(cxxOperatorCallExpr(
+ hasOverloadedOperatorName("/"), argumentCountIs(2),
+ hasArgument(0, expr(IsDuration)),
JonasToth added a comment.
LGTM
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D36892
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
hugoeg added inline comments.
Comment at: clang-tidy/abseil/NoInternalDepsCheck.cpp:24
+
+ Finder->addMatcher(
+ nestedNameSpecifierLoc(loc(specifiesNamespace(namespaceDecl(
JonasToth wrote:
> Actually that one is generally useful. Accessing the
cdavis5x created this revision.
cdavis5x added reviewers: mstorsjo, rnk, compnerd, smeenai.
Herald added subscribers: cfe-commits, chrib, christof, kristof.beyls, mgorny.
Herald added a reviewer: javed.absar.
I've tested this implementation on x86-64 to ensure that it works. All
`libc++abi` tests
JonasToth added a comment.
Thank you for your first contribution to LLVM btw :)
Comment at: clang-tidy/abseil/NoInternalDepsCheck.cpp:24
+
+ TODO(hugoeg): refactor matcher to be configurable or just match on any
internal access from outside the enclosing namespace.
+
Author: lebedevri
Date: Fri Aug 10 08:05:46 2018
New Revision: 339437
URL: http://llvm.org/viewvc/llvm-project?rev=339437=rev
Log:
[clang-tidy] check_clang_tidy.py: support CHECK-NOTES prefix
Summary:
Currently, there is two configured prefixes: `CHECK-FIXES` and `CHECK-MESSAGES`
jhibbits added a comment.
Hi Vit,
Thanks for the feedback. I can add the -mspe=yes/no, that shouldn't be hard.
I didn't include it because it's been deprecated by GCC already as well. I can
add the -mcpu=8548 option as well. I use -mcpu=8540 on FreeBSD for the
powerpcspe target anyway
Author: arphaman
Date: Fri Aug 10 10:25:07 2018
New Revision: 339454
URL: http://llvm.org/viewvc/llvm-project?rev=339454=rev
Log:
[clangd] extend the publishDiagnostics response to send back fixits to the
client if the client supports this extension
This commit extends the
kbobyrev updated this revision to Diff 160146.
kbobyrev marked 2 inline comments as done.
kbobyrev added a comment.
Store symbol qualities (so that it's not computed each time when requested
which might be expensive). Use `operator[]` to construct the value for inverted
index when key is not
ilya-biryukov added a comment.
NIT: maybe also note the number of the clangd revision in this change's
description
Repository:
rC Clang
https://reviews.llvm.org/D50443
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
Author: ahatanak
Date: Fri Aug 10 10:07:27 2018
New Revision: 339452
URL: http://llvm.org/viewvc/llvm-project?rev=339452=rev
Log:
Make changes to the check strings so that the test I modified in r339438
passes on 32-bit targets.
Modified:
cfe/trunk/test/CodeGenCXX/block-byref-cxx-objc.cpp
ioeric added inline comments.
Comment at: clang-tools-extra/clangd/index/dex/Trigram.cpp:31
+/// use it as the special symbol.
+const auto END_MARKER = '$';
+
nit: s/auto/char/
Maybe just use `static` instead of an anonymous namespace just for this.
ioeric added inline comments.
Comment at: clang-tools-extra/clangd/index/dex/Trigram.cpp:83
+
+ bool FoundFirstHead = false;
+ // Iterate through valid seqneces of three characters Fuzzy Matcher can
ioeric wrote:
> It's probably unclear what `FoundFirstHead`
NoQ added a comment.
> I'm only a beginner, but here are some things that caught my eye. I really
> like the idea! :)
Thanks, i appreciate help with reviews greatly.
Comment at: lib/StaticAnalyzer/Checkers/PointerSortingChecker.cpp:93
+ const RecordDecl *RD =
+
lebedev.ri updated this revision to Diff 160107.
lebedev.ri added a comment.
Add docs note.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D36892
Files:
docs/clang-tidy/index.rst
test/clang-tidy/check_clang_tidy.py
test/clang-tidy/hicpp-exception-baseclass.cpp
Index:
Author: ahatanak
Date: Fri Aug 10 08:09:24 2018
New Revision: 339438
URL: http://llvm.org/viewvc/llvm-project?rev=339438=rev
Log:
[CodeGen] Merge equivalent block copy/helper functions.
Clang generates copy and dispose helper functions for each block literal
on the stack. Often these functions
This revision was automatically updated to reflect the committed changes.
Closed by commit rC339438: [CodeGen] Merge equivalent block copy/helper
functions. (authored by ahatanak, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D50152?vs=160053=160110#toc
Repository:
rC
JonasToth added inline comments.
Comment at: clang-tidy/abseil/DurationDivisionCheck.cpp:50
+ *result.SourceManager, result.Context->getLangOpts()),
+ ")");
+}
deannagarcia wrote:
> JonasToth wrote:
> > This line looks odd, does it
Author: aaronballman
Date: Fri Aug 10 10:33:47 2018
New Revision: 339456
URL: http://llvm.org/viewvc/llvm-project?rev=339456=rev
Log:
Allow relockable scopes with thread safety attributes.
Patch by Aaron Puchert
Modified:
cfe/trunk/lib/Analysis/ThreadSafety.cpp
aaron.ballman closed this revision.
aaron.ballman added a comment.
Committed in r339456; if @delesley has concerns with the commit, they can be
addressed post-commit. Thank you for the patch!
Repository:
rC Clang
https://reviews.llvm.org/D49885
Author: rkovacs
Date: Fri Aug 10 16:56:57 2018
New Revision: 339489
URL: http://llvm.org/viewvc/llvm-project?rev=339489=rev
Log:
[analyzer] InnerPointerChecker: improve warning messages and notes.
Differential Revision: https://reviews.llvm.org/D49570
Modified:
rsmith added inline comments.
Comment at: include/clang/Basic/Attr.td:1510
+ let Spellings = [Keyword<"__unsafe_unretained">];
+ let Documentation = [Undocumented];
+}
aaron.ballman wrote:
> I don't suppose you can throw in some quick docs for this keyword? Or
Eugene.Zelenko added a comment.
Check documentation is missing.
Comment at: clang-tidy/abseil/NoNamespaceCheck.cpp:21
+void NoNamespaceCheck::registerMatchers(MatchFinder *Finder) {
+ if (!getLangOpts().CPlusPlus) return;
+
Please place return in separate
Author: george.karpenkov
Date: Fri Aug 10 18:47:41 2018
New Revision: 339493
URL: http://llvm.org/viewvc/llvm-project?rev=339493=rev
Log:
[analyzer] Fix keyboard navigation for .msgNote events
Does not go to msgNote's.
Differential Revision: https://reviews.llvm.org/D50595
Modified:
This revision was automatically updated to reflect the committed changes.
Closed by commit rC339493: [analyzer] Fix keyboard navigation for .msgNote
events (authored by george.karpenkov, committed by ).
Herald added a subscriber: cfe-commits.
Changed prior to commit:
BillyONeal added a comment.
In https://reviews.llvm.org/D50549#1194852, @EricWF wrote:
> We should add some TSAN folks to this review, since I think these are also
> TSAN false negatives; perhaps correctly, perhaps not.
Do you know who that is / can you add them?
EricWF added a comment.
I was hoping my comment would summon them magically. I'll figure it out shortly.
https://reviews.llvm.org/D50549
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
This revision was automatically updated to reflect the committed changes.
Closed by commit rL339489: [analyzer] InnerPointerChecker: improve warning
messages and notes. (authored by rkovacs, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
Author: dyung
Date: Fri Aug 10 19:46:47 2018
New Revision: 339494
URL: http://llvm.org/viewvc/llvm-project?rev=339494=rev
Log:
Make the section boundary checks on Windows not depend on the order as they are
emitted in reverse when the compiler is built by Visual C++.
Modified:
rsmith updated this revision to Diff 160207.
rsmith marked 10 inline comments as done.
https://reviews.llvm.org/D50526
Files:
include/clang/AST/ASTContext.h
include/clang/AST/Attr.h
include/clang/AST/Type.h
include/clang/AST/TypeLoc.h
include/clang/Basic/Attr.td
saar.raz updated this revision to Diff 160216.
saar.raz added a comment.
Address Richard's CR comments. Among other things:
- CSEs overhauled and now store both source and converted template arguments
(latter are tail-allocated), template KW location and NNS.
- CSEs no longer violate layering -
1 - 100 of 181 matches
Mail list logo