hokein added inline comments.
Comment at: clangd/XRefs.cpp:43
+ if (Line >= SymbolLocation::Position::MaxLine)
+log("Get an overflowed line");
+ return Line;
sammccall wrote:
> Log message could use more context. And I think it'd be really useful to
>
This revision was automatically updated to reflect the committed changes.
Closed by commit rL344777: [clangd] Remove the overflow log. (authored by
hokein, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D53400
Files:
Author: hokein
Date: Fri Oct 19 01:35:24 2018
New Revision: 344777
URL: http://llvm.org/viewvc/llvm-project?rev=344777=rev
Log:
[clangd] Remove the overflow log.
Summary:
LLVM codebase has generated files (all are build/Target/XXX/*.inc) that
exceed the MaxLine & MaxColumn. Printing these log
hokein accepted this revision.
hokein added a comment.
This revision is now accepted and ready to land.
The change looks reasonable to me, I'd let @ilya-biryukov take a second look.
Repository:
rC Clang
https://reviews.llvm.org/D53369
___
balazske added inline comments.
Comment at: lib/AST/ASTImporter.cpp:8197
-void ASTImporter::ImportDefinition(Decl *From) {
+Error ASTImporter::ImportDefinition_New(Decl *From) {
Decl *To = Import(From);
a_sidorin wrote:
> ImportDefinitionOrError?
The
mstorsjo added a comment.
Please add a testcase in test/Driver/, it looks like fopenmp.c there might be a
good target to add a few lines in.
Repository:
rC Clang
https://reviews.llvm.org/D53397
___
cfe-commits mailing list
takuto.ikuta added a comment.
ping? Can I go forward in this way?
https://reviews.llvm.org/D51340
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
hokein updated this revision to Diff 170157.
hokein marked an inline comment as done.
hokein added a comment.
Log the whole location when overflow happens.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D53400
Files:
clangd/XRefs.cpp
clangd/index/Index.cpp
hokein updated this revision to Diff 170159.
hokein added a comment.
Minor cleanup.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D53400
Files:
clangd/XRefs.cpp
clangd/index/Index.cpp
clangd/index/Index.h
unittests/clangd/IndexTests.cpp
Index:
Author: mantognini
Date: Fri Oct 19 02:01:37 2018
New Revision: 344778
URL: http://llvm.org/viewvc/llvm-project?rev=344778=rev
Log:
[OpenCL] Remove unwanted signedness conversion from tests
The get_kernel_* functions used in cl20-device-side-enqueue.cl all return
unsigned integers. This patch
This revision was automatically updated to reflect the committed changes.
Closed by commit rL344778: [OpenCL] Remove unwanted signedness conversion from
tests (authored by mantognini, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
This revision was automatically updated to reflect the committed changes.
Closed by commit rC344778: [OpenCL] Remove unwanted signedness conversion from
tests (authored by mantognini, committed by ).
Repository:
rC Clang
https://reviews.llvm.org/D52873
Files:
xbolva00 added inline comments.
Comment at: lib/Driver/ToolChains/Gnu.cpp:241
+ case llvm::Triple::thumbeb:
+IsBigEndian = true;
+ case llvm::Triple::arm:
peter.smith wrote:
> xbolva00 wrote:
> > Gnu.cpp:241:17: warning: this statement may fall through
>
sidorovd added a comment.
Ping
https://reviews.llvm.org/D51402
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
sammccall updated this revision to Diff 170153.
sammccall marked an inline comment as done.
sammccall added a comment.
Don't call URIForFile again, rebase.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D53391
Files:
clangd/ClangdLSPServer.cpp
clangd/Diagnostics.cpp
sammccall added a comment.
Thanks! @arphaman, any concerns about the change to extension format?
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D53391
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
twoh updated this revision to Diff 170148.
twoh added a comment.
Herald added a subscriber: jfb.
Rebase. Sorry I somehow missed the recent comments. I addresses @davidxl's
comment on documentation. Thanks!
Repository:
rC Clang
https://reviews.llvm.org/D34796
Files:
curdeius updated this revision to Diff 170152.
curdeius added a comment.
Fixed diff.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D53372
Files:
clang-tidy/readability/ElseAfterReturnCheck.cpp
test/clang-tidy/readability-else-after-return-if-constexpr.cpp
Index:
wuzish added a comment.
If anybody knows who are familiar with C/C++ function overload and code related
to this issue, please feel free to add them as reviewers and subscribers.
Repository:
rC Clang
https://reviews.llvm.org/D53417
___
yvvan added a comment.
Do you know the better way to accomplish my aim than adding an option to
libFormat? For example making a dependent library which serves a little
different purpose than libFormat itself or something simpler?
https://reviews.llvm.org/D53072
AlexeySotkin added a comment.
Ping
https://reviews.llvm.org/D51484
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: krasimir
Date: Thu Oct 18 23:05:32 2018
New Revision: 344773
URL: http://llvm.org/viewvc/llvm-project?rev=344773=rev
Log:
[clangd] Fix msan failure after r344735 by initializing bitfields
That revision changed integer members to bitfields; the integers were
default initialized before and
Author: lebedevri
Date: Thu Oct 18 23:04:07 2018
New Revision: 344772
URL: http://llvm.org/viewvc/llvm-project?rev=344772=rev
Log:
[clang-tidy] readability-uppercase-literal-suffix: specify target for ms test
too
Apparently the bots were still failing with this.
Sadly, i did not see *this*
peter.smith added a comment.
Thanks for pointing that out, I'm out of office today, will look at describing
the intention to fall through when I get back in on Monday.
Comment at: lib/Driver/ToolChains/Gnu.cpp:241
+ case llvm::Triple::thumbeb:
+IsBigEndian = true;
+
wuzish created this revision.
wuzish added reviewers: hfinkel, nemanjai, Douglasgido, hubert.reinterpretcast,
fpichet.
There are 2 function variations with altivec type parameter. When we call them
with argument of generic gcc vector type we would prefer to choose the
variation with implicit
Author: balazske
Date: Fri Oct 19 08:16:51 2018
New Revision: 344784
URL: http://llvm.org/viewvc/llvm-project?rev=344784=rev
Log:
[ASTImporter] Removed uneeded default case label.
Modified:
cfe/trunk/lib/AST/ASTImporter.cpp
Modified: cfe/trunk/lib/AST/ASTImporter.cpp
URL:
sammccall added inline comments.
Comment at: clangd/index/FileIndex.cpp:167
+}
+// FIXME: aggregate symbol reference count based on references.
+for (const auto : FileSyms.getValue()->Refs) {
This is a good FIXME to carry over to
thakis accepted this revision.
thakis added a comment.
This revision is now accepted and ready to land.
Thanks for the fix! Do you happen to know what had regressed this?
Repository:
rC Clang
https://reviews.llvm.org/D53434
___
cfe-commits
hubert.reinterpretcast added inline comments.
Comment at: clang/lib/Sema/SemaOverload.cpp:3908
+ QualType ToType) {
+assert(FromType->isVectorType() && "FromType should be a vector type");
+assert(ToType->isVectorType()
twoh added a comment.
@joerg Sorry but I'm not sure if I understand your question. This doesn't
pretend to honor source code order, but makes linker to place "hot" functions
under .text.hot section (There's no guarantee of ordering between functions
inside .hot.text section) while "cold"
SamMaier created this revision.
Herald added a subscriber: cfe-commits.
Previously, Java annotation declarations (`@interface AnnotationName`) were
being handled as ObjC interfaces. This caused the brace formatting to mess up,
so that when you had a class with an interface defined in it, it
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM!
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D53372
___
cfe-commits mailing list
Author: mkurdej
Date: Fri Oct 19 08:26:17 2018
New Revision: 344785
URL: http://llvm.org/viewvc/llvm-project?rev=344785=rev
Log:
[clang-tidy] Resolve readability-else-after-return false positive for constexpr
if.
Summary:
It fixes the false positive when using constexpr if and where else cannot
This revision was automatically updated to reflect the committed changes.
Closed by commit rCTE344785: [clang-tidy] Resolve readability-else-after-return
false positive for constexpr… (authored by mkurdej, committed by ).
Changed prior to commit:
Author: kparzysz
Date: Fri Oct 19 08:36:45 2018
New Revision: 344786
URL: http://llvm.org/viewvc/llvm-project?rev=344786=rev
Log:
[Hexagon] Remove support for V4
Modified:
cfe/trunk/docs/ClangCommandLineReference.rst
cfe/trunk/include/clang/Driver/Options.td
twoh updated this revision to Diff 170205.
twoh added a comment.
Remove conflict line.
Repository:
rC Clang
https://reviews.llvm.org/D34796
Files:
docs/ClangCommandLineReference.rst
include/clang/Driver/Options.td
include/clang/Frontend/CodeGenOptions.def
lib/CodeGen/BackendUtil.cpp
sammccall added a comment.
Nice savings!
My initial thought is that it seems weird to only do it for this one string -
the readers look different, the serialization code has different logic etc for
the different flavors of strings.
The struct certainly looks nicer to my eyes.
This may be the
This revision was automatically updated to reflect the committed changes.
Closed by commit rCTE344787: [clangd] Set workspace root when initializing
ClangdServer, disallow mutation. (authored by sammccall, committed by ).
Changed prior to commit:
Author: sammccall
Date: Fri Oct 19 08:42:23 2018
New Revision: 344787
URL: http://llvm.org/viewvc/llvm-project?rev=344787=rev
Log:
[clangd] Set workspace root when initializing ClangdServer, disallow mutation.
Summary:
Rename instance variable to WorkspaceRoot to match what we call it
sammccall created this revision.
sammccall added reviewers: ioeric, ilya-biryukov.
Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay.
The CDB implementations used in open-source code are fast, and our private
slow CDB will soon do the relevant caching itself.
lantictac created this revision.
lantictac added a reviewer: rsmith.
lantictac added a project: clang.
MicrosoftExt allows explicit constructor calls. Prevent lookup of constructor
name unless the name has explicit scope.
This avoids a compile-time crash due to confusing a member access for a
kadircet updated this revision to Diff 170215.
kadircet added a comment.
- Keep only relavant changes and rebase
Repository:
rC Clang
https://reviews.llvm.org/D52301
Files:
include/clang/AST/PrettyPrinter.h
include/clang/Sema/Sema.h
lib/AST/TypePrinter.cpp
rsmith added a comment.
In https://reviews.llvm.org/D52301#1267163, @kadircet wrote:
> So in the middle of the patch we were just trying to figure out whether we
> are going to break a big assumption that lots of different components relied
> on but just didn't had any tests for. Maybe @rsmith
Anastasia added inline comments.
Comment at: lib/Headers/opencl-c.h:16197
+#ifdef cl_intel_device_side_avc_motion_estimation
+#pragma OPENCL EXTENSION cl_intel_device_side_avc_motion_estimation : enable
+
Anastasia wrote:
> Should we be using:
> #pragma OPENCL
Anastasia accepted this revision.
Anastasia added inline comments.
This revision is now accepted and ready to land.
Comment at: test/Headers/opencl-pragma-extension-begin.cl:1
+// RUN: rm -rf %t
+// RUN: mkdir -p %t
I think the tests in this folder are for
dblaikie added a comment.
@echristo
> As far as the standard text here, IMO it was just there in case people didn't
> have an objcopy around or don't want to split it. I'm not sure why we would
> want the ability.
I think others have mentioned - but with distributed build it might be easier
Anastasia accepted this revision.
Anastasia added a comment.
This revision is now accepted and ready to land.
LGTM!
https://reviews.llvm.org/D51402
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
Author: hans
Date: Fri Oct 19 09:19:52 2018
New Revision: 344789
URL: http://llvm.org/viewvc/llvm-project?rev=344789=rev
Log:
Java annotation declaration being handled correctly
Previously, Java annotation declarations (@interface AnnotationName) were being
handled as ObjC interfaces. This
ilya-biryukov accepted this revision.
ilya-biryukov added a comment.
LGTM, thanks!
Would be super-nice if didn't have to rewrite this in code completion
Repository:
rC Clang
https://reviews.llvm.org/D53369
___
cfe-commits mailing list
Author: danalbert
Date: Fri Oct 19 11:06:02 2018
New Revision: 344795
URL: http://llvm.org/viewvc/llvm-project?rev=344795=rev
Log:
[Driver] Reland: Default Android toolchains to libc++.
The sanitizer builder that was broken by this should now be fixed.
Original review was
This revision was automatically updated to reflect the committed changes.
Closed by commit rL344789: Java annotation declaration being handled correctly
(authored by hans, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
ilya-biryukov added a comment.
A few more comments, mostly marking places of unintentional changes that we
need to revert.
Hope it's not going past the point where the number of comments are not useful.
Comment at: include/clang/Basic/DiagnosticSemaKinds.td:8616
"use of
Anastasia accepted this revision.
Anastasia added a comment.
This revision is now accepted and ready to land.
LGTM! Thanks!
https://reviews.llvm.org/D52654
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
gtbercea created this revision.
gtbercea added reviewers: ABataev, caomhin.
Herald added subscribers: cfe-commits, guansong, jholewinski.
This patch enables the choosing of the default schedule for parallel for loops
even in non-SPMD cases.
Repository:
rC Clang
dblaikie added a comment.
Don't know enough about the code to have an opinion on the fix - but in any
case this would need a test case, if possible
Repository:
rC Clang
https://reviews.llvm.org/D53334
___
cfe-commits mailing list
ABataev added inline comments.
Comment at: lib/CodeGen/CGOpenMPRuntimeNVPTX.h:350
void getDefaultScheduleAndChunk(CodeGenFunction ,
- const OMPLoopDirective , OpenMPScheduleClauseKind ,
+ const OMPLoopDirective , OpenMPScheduleTy ,
llvm::Value *) const
gtbercea updated this revision to Diff 170238.
gtbercea added a comment.
Refactor.
Repository:
rOMP OpenMP
https://reviews.llvm.org/D53141
Files:
libomptarget/deviceRTLs/nvptx/src/data_sharing.cu
libomptarget/deviceRTLs/nvptx/src/interface.h
Author: rsmith
Date: Fri Oct 19 12:01:34 2018
New Revision: 344801
URL: http://llvm.org/viewvc/llvm-project?rev=344801=rev
Log:
PR24164, PR39336: init-captures are not distinct full-expressions.
Rather, they are subexpressions of the enclosing lambda-expression, and
any temporaries in them are
gtbercea updated this revision to Diff 170236.
gtbercea added a comment.
Herald added subscribers: cfe-commits, jholewinski.
Refactor.
Repository:
rC Clang
https://reviews.llvm.org/D53141
Files:
lib/CodeGen/CGOpenMPRuntimeNVPTX.cpp
Index: lib/CodeGen/CGOpenMPRuntimeNVPTX.cpp
Author: danalbert
Date: Fri Oct 19 12:23:01 2018
New Revision: 344806
URL: http://llvm.org/viewvc/llvm-project?rev=344806=rev
Log:
Revert "[Driver] Reland: Default Android toolchains to libc++."
This reverts commit 84677d5009d613232d360fda27e6e41fb5cb6700.
Modified:
gtbercea created this revision.
gtbercea added reviewers: ABataev, caomhin.
Herald added subscribers: cfe-commits, guansong, jholewinski.
This patch adds a new code generation path for bound sharing directives
containing distribute parallel for. The new code generation scheme applies to
chunked
vmiklos created this revision.
vmiklos added reviewers: alexfh, sbenza.
Herald added subscribers: cfe-commits, xazax.hun.
And also enable it by default to be consistent with e.g. modernize-use-using.
This helps e.g. when running this check on client code where the macro is
provided by
vmiklos added a comment.
In practice cppunit's `CPPUNIT_TEST_SUITE_END` macro triggers this problem.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D53454
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
ilya-biryukov created this revision.
ilya-biryukov added reviewers: ioeric, sammccall.
Herald added a subscriber: arphaman.
Without the function body, we cannot determine is parameter was used.
Repository:
rC Clang
https://reviews.llvm.org/D53456
Files:
lib/Sema/SemaDecl.cpp
gtbercea updated this revision to Diff 170237.
gtbercea added a comment.
Refactor.
Repository:
rC Clang
https://reviews.llvm.org/D53443
Files:
lib/CodeGen/CGOpenMPRuntimeNVPTX.cpp
Index: lib/CodeGen/CGOpenMPRuntimeNVPTX.cpp
gtbercea updated this revision to Diff 170241.
gtbercea added a comment.
Rebase.
Repository:
rC Clang
https://reviews.llvm.org/D53448
Files:
include/clang/AST/StmtOpenMP.h
include/clang/Basic/OpenMPKinds.h
lib/AST/StmtOpenMP.cpp
lib/CodeGen/CGOpenMPRuntime.cpp
rsmith added inline comments.
Comment at: clang/lib/AST/ExprConstant.cpp:711
+
+ /// Evaluate as a constant expression, as per C++11-and-later constexpr
+ /// rules. Stop if we find that the expression is not a constant
jyknight wrote:
> rsmith wrote:
Author: rsmith
Date: Fri Oct 19 12:01:31 2018
New Revision: 344800
URL: http://llvm.org/viewvc/llvm-project?rev=344800=rev
Log:
Add basic test that we perform lifetime extension in the expected
situations.
Added:
cfe/trunk/test/CXX/special/class.temporary/p6.cpp
Added:
NoQ added inline comments.
Comment at:
lib/StaticAnalyzer/Checkers/UninitializedObject/UninitializedObjectChecker.cpp:515
+ continue;
+const auto *FirstAccess = Accesses[0].getNodeAs("access");
+
I feel that it's a good practice to
NoQ accepted this revision.
NoQ added a comment.
This revision is now accepted and ready to land.
Code looks good to me, but I'd wait for @george.karpenkov because it was his
idea.
Comment at:
lib/StaticAnalyzer/Checkers/UninitializedObject/UninitializedObjectChecker.cpp:502
hubert.reinterpretcast added inline comments.
Comment at: clang/test/Sema/altivec-generic-overload.c:3
+
+typedef signed char __v4sc __attribute__((__vector_size__(16)));
+typedef unsigned char __v4uc __attribute__((__vector_size__(16)));
`__v4sc` is suspicious.
ilya-biryukov added a comment.
Since we're showing the diagnostics in the editors anyway, how crucial do we
think it is to actually add that to the procotol?
Having more concrete reasons for misbehaving completions sounds more useful,
though, e.g. "cannot complete members of the incomplete
oleg.smolsky added a comment.
In https://reviews.llvm.org/D52676#1268806, @djasper wrote:
> In https://reviews.llvm.org/D52676#1268748, @oleg.smolsky wrote:
>
> > In https://reviews.llvm.org/D52676#1268706, @djasper wrote:
> >
> > > Ok, I think I agree with both of you to a certain extent, but I
neerajksingh created this revision.
neerajksingh added reviewers: rnk, hans.
The clang-cl driver disables access to command line options outside of the
"Core" and "CLOption" sets of command line arguments. This filtering makes it
impossible to pass arguments that are interpreted by the clang
rsmith added inline comments.
Comment at: lib/AST/DeclBase.cpp:1704-1705
+
+ // In C, the redeclaration context for enumerators is the translation unit,
+ // so we skip through transparent contexts as well as struct/union contexts.
+ bool SkipRecords = getDeclKind() ==
rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
(Looks fine with a suitably-adjusted comment.)
https://reviews.llvm.org/D52384
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
NoQ added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/ConversionChecker.cpp:163
+
+switch (FloatingSize) {
+ case 64:
Continuing the float semantics discussion on the new revision - Did you
consider `llvm::APFloat`?
aprantl added a comment.
Oh wait, this patch is just for dumping the ASTs? Can you elaborate why this
makes it into a binary then?
Repository:
rC Clang
https://reviews.llvm.org/D38061
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
aprantl added a comment.
RTTI?
Repository:
rC Clang
https://reviews.llvm.org/D38061
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
On Fri, Oct 19, 2018 at 3:56 PM Adrian Prantl via Phabricator via
llvm-commits wrote:
> aprantl added a comment.
>
> I have a vague recollection that this column info hack was added to
> disambiguate two types defined on the same line (which is something that
> happened more often than one would
ilya-biryukov updated this revision to Diff 170273.
ilya-biryukov marked 2 inline comments as done.
ilya-biryukov added a comment.
- Addressed review comments
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D53347
Files:
clangd/XRefs.cpp
unittests/clangd/XRefsTests.cpp
echristo added a reviewer: aprantl.
echristo added a comment.
I think Adrian has looked at this more recently than I have. Adding him here.
Repository:
rC Clang
https://reviews.llvm.org/D38061
___
cfe-commits mailing list
oleg.smolsky updated this revision to Diff 170270.
oleg.smolsky added a comment.
Generalized the patch so that it deals with lambda args irrespective of bin
packing. Added additional tests and patched existing ones.
Repository:
rC Clang
https://reviews.llvm.org/D52676
Files:
aprantl added a comment.
I have a vague recollection that this column info hack was added to
disambiguate two types defined on the same line (which is something that
happened more often than one would think because of macro expansion). Did you
do the git archeology to ensure that the original
hans added a comment.
I haven't started looking at the code yet.
I'm not completely convinced that we want this. So far we've used the strategy
of promoting clang options that are also useful in clang-cl to core options,
and if someone wants to use more clang than that, maybe clang-cl isn't
BillyONeal closed this revision.
BillyONeal added a comment.
Committed r344820
https://reviews.llvm.org/D50549
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
aprantl added inline comments.
Comment at: lib/CodeGen/CGExpr.cpp:2871
+ auto *DI = CGF.getDebugInfo();
+ SourceLocation Loc = DI ? DI->getLocation() : SourceLocation();
+ auto DL = ApplyDebugLocation::CreateDefaultArtificial(CGF, Loc);
vsk wrote:
> Why
vsk added inline comments.
Comment at: lib/CodeGen/CGExpr.cpp:2871
+ auto *DI = CGF.getDebugInfo();
+ SourceLocation Loc = DI ? DI->getLocation() : SourceLocation();
+ auto DL = ApplyDebugLocation::CreateDefaultArtificial(CGF, Loc);
aprantl wrote:
> vsk
NoQ accepted this revision.
NoQ added a comment.
I'll use this.
And i think it's unfair to give users -analyzer-config and not give them a list
of options. Users should be able to discover either both or none of the two. If
a user goes far enough to start digging into non-driver options, such
hubert.reinterpretcast requested changes to this revision.
hubert.reinterpretcast added inline comments.
This revision now requires changes to proceed.
Comment at: clang/lib/Sema/SemaOverload.cpp:3920
+
+ // Prefer a compatible vector conversion to lax vector conversion
+ //
hwright added a comment.
Ping.
What are the next steps here?
https://reviews.llvm.org/D53339
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
BillyONeal closed this revision.
BillyONeal added a comment.
Thank you! :D
Committed r344829
https://reviews.llvm.org/D53466
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: ahatanak
Date: Fri Oct 19 22:45:01 2018
New Revision: 344833
URL: http://llvm.org/viewvc/llvm-project?rev=344833=rev
Log:
[CodeGen] Use the mangle context owned by CodeGenModule to correctly
mangle types of lambda objects captured by a block instead of creating a
new mangle context
NoQ added a comment.
My take on the out-of-alpha checklist:
- The checker should be evaluated on a large codebase in order to discover
crashes and false positives specific to the checker. It should demonstrate the
expected reasonably good results on it, with the stress on having as little
nickdesaulniers created this revision.
nickdesaulniers added reviewers: srhines, pirama, danalbert.
Herald added subscribers: cfe-commits, kristof.beyls, javed.absar.
Partial revert of r330873 ('[Driver] Reland "Android triples are not
aliases for other triples."')
While we don't want `-target
Author: dergachev
Date: Fri Oct 19 17:29:24 2018
New Revision: 344823
URL: http://llvm.org/viewvc/llvm-project?rev=344823=rev
Log:
[analyzer] Be more plugin-friendly by moving static locals into .cpp files.
The GDMIndex functions return a pointer that's used as a key for looking up
data, but
This revision was automatically updated to reflect the committed changes.
Closed by commit rL344823: [analyzer] Be more plugin-friendly by moving static
locals into .cpp files. (authored by dergachev, committed by ).
Herald added subscribers: llvm-commits, dkrupp, donat.nagy.
Changed prior to
NoQ closed this revision.
NoQ added a comment.
Herald added subscribers: dkrupp, donat.nagy.
I committed both patches as https://reviews.llvm.org/rC344823 but it seems that
Phabricator doesn't pick up closing multiple revisions with the same commit, so
closing manually.
Also thanks!~
NoQ added a reviewer: dcoughlin.
NoQ added inline comments.
Herald added a subscriber: dkrupp.
Comment at: lib/StaticAnalyzer/Checkers/LocalizationChecker.cpp:1401-1402
checker->IsAggressive =
- mgr.getAnalyzerOptions().getBooleanOption("AggressiveReport", false);
+
Author: ctopper
Date: Fri Oct 19 18:30:00 2018
New Revision: 344824
URL: http://llvm.org/viewvc/llvm-project?rev=344824=rev
Log:
[X86] When checking the bits in cpu_features for function multiversioning
dispatcher in the resolver, make sure all the required bits are set. Not just
one of them
1 - 100 of 133 matches
Mail list logo
