Szelethus added a comment.
Oh, and the reason why I think it would add a lot of complication: since only
`ExprEngine` is avaible in the `checkEndAnalysis` callback, which, from what I
can see, doesn't have a handly `isDead` method, so I'm not even sure how I'd
implement it.
This revision was automatically updated to reflect the committed changes.
Closed by commit rC346064: [Driver] Use -push-/-pop-state and -as-needed for
libc++ on Fuchsia (authored by phosek, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D53854?vs=171948=172478#toc
phosek created this revision.
phosek added a reviewer: mcgrathr.
Herald added subscribers: cfe-commits, cryptoad.
This makes the tests stricter by not only matching the runtime file
name, but the entire path into the resource directory.
Repository:
rC Clang
https://reviews.llvm.org/D54064
NoQ added a comment.
Ok, so what this code does is, eg., for a call of `i1.operator==(i2)` that
returns a symbol `$x` of type `bool`, it conserves the sacred checker-specific
knowledge that `$x` is in fact equal to `$offset(i1) == $offset(i2)`, where
`$offset(i)` is the offset symbol within
jfb created this revision.
jfb added a reviewer: rjmccall.
Herald added subscribers: cfe-commits, dexonsmith.
jfb added a comment.
I'm not sure this is the right fix because mangling confuses me. It fixes the
assertion I'm encountering in my patch, and I don't think I can create a repro
without
jfb added a comment.
In https://reviews.llvm.org/D54055#1286196, @erik.pilkington wrote:
> Can you give an example of some code that triggered this with your patch
> applied? Even if it isn't a real reproducer right now, it would help to try
> to understand whats happening here.
Sure!
I
Hi Galina,
I'm sad that they appear to have been abandoned but no objections from me as
I'm not the admin for any of these anymore. A couple of them were taken over by
a colleague when I left but he too has left MIPS since then. Simon Atanasyan
might be able to find the owners if there still
phosek added a comment.
In https://reviews.llvm.org/D54026#1285754, @mcgrathr wrote:
> So the default is not per-target? It should be.
Agreed, although that'll require non-trivial driver changes.
Repository:
rC Clang
https://reviews.llvm.org/D54026
Author: phosek
Date: Fri Nov 2 16:49:36 2018
New Revision: 346056
URL: http://llvm.org/viewvc/llvm-project?rev=346056=rev
Log:
[CMake][Fuchsia] Set -fuse-ld=lld explicitly for Linux runtimes
We set lld as the default linker on non-Darwin platforms, but we still
need to set -fuse-ld=lld
Author: sammccall
Date: Fri Nov 2 16:47:55 2018
New Revision: 346054
URL: http://llvm.org/viewvc/llvm-project?rev=346054=rev
Log:
[clangd] don't buffer the input-mirror stream, it's used to diagnose crashes
Modified:
clang-tools-extra/trunk/clangd/tool/ClangdMain.cpp
Modified:
mgrang created this revision.
mgrang added reviewers: rnk, efriedma, mstorsjo, TomTan.
Herald added subscribers: kristina, jfb, chrib, kristof.beyls, javed.absar.
This is sixth in a series of patches to move intrinsic definitions out of
intrin.h.
Repository:
rC Clang
MaskRay added inline comments.
Comment at: lib/Driver/ToolChains/Fuchsia.cpp:128
if (OnlyLibstdcxxStatic)
- CmdArgs.push_back("-Bstatic");
+ CmdArgs.push_back("-static");
ToolChain.AddCXXStdlibLibArgs(Args, CmdArgs);
If
rjmccall added a comment.
That sounds more like this use of the mangler isn't manipulating the function
type context correctly. But actually I think the problem is that it's
ridiculous to assume that arbitrary local declarations have meaningful
manglings. Why are we calling
erik.pilkington added a comment.
Can you give an example of some code that triggered this with your patch
applied? Even if it isn't a real reproducer right now, it would help to try to
understand whats happening here.
Repository:
rC Clang
https://reviews.llvm.org/D54055
mgrang created this revision.
mgrang added reviewers: rnk, efriedma, mstorsjo, TomTan.
Herald added subscribers: kristina, jfb, chrib, kristof.beyls, javed.absar.
This is third in a series of patches to move intrinsic definitions out of
intrin.h.
Repository:
rC Clang
mgrang created this revision.
mgrang added reviewers: rnk, efriedma, mstorsjo, TomTan.
Herald added subscribers: kristina, jfb, chrib, kristof.beyls, javed.absar.
This is fourth in a series of patches to move intrinsic defintions out of
intrin.h.
Repository:
rC Clang
mgrang created this revision.
mgrang added reviewers: rnk, efriedma, mstorsjo, TomTan.
Herald added subscribers: kristina, jfb, chrib, kristof.beyls, javed.absar.
This is eight in a series of patches to move intrinsic definitions out of
intrin.h.
Repository:
rC Clang
NoQ added a comment.
In https://reviews.llvm.org/D53856#1285373, @rnkovacs wrote:
> In https://reviews.llvm.org/D53856#1280408, @Szelethus wrote:
>
> > In https://reviews.llvm.org/D53856#1279887, @NoQ wrote:
> >
> > > This might be also covered by @rnkovacs's string buffer escape checker -
> >
Author: phosek
Date: Fri Nov 2 18:43:25 2018
New Revision: 346064
URL: http://llvm.org/viewvc/llvm-project?rev=346064=rev
Log:
[Driver] Use -push-/-pop-state and -as-needed for libc++ on Fuchsia
This avoids introducing unnecessary DT_NEEDED entries when using
C++ driver for linking C code or
Author: adrian
Date: Fri Nov 2 15:19:02 2018
New Revision: 346048
URL: http://llvm.org/viewvc/llvm-project?rev=346048=rev
Log:
Add an explicit -std=c++14 to this test.
rdar://problem/45642490
Modified:
cfe/trunk/test/Modules/lsv-debuginfo.cpp
Modified:
Szelethus added a comment.
Sorry for the late reply.
I'm not actually super confident about this idea, I don't think it would add
much value, compared to how complicated it would make things. This patch
reduces report by a significant amount when pointer chasing is enabled, but a
global set
sammccall created this revision.
sammccall added reviewers: hokein, alexfh.
Herald added subscribers: cfe-commits, xazax.hun.
By now the context's SourceManager is now initialized everywhere that
ClangTidyCheck::registerMatcher() is called, so the call from run() seems
entirely redundant, and
jfb added a comment.
In https://reviews.llvm.org/D54055#1286396, @rjmccall wrote:
> That sounds more like this use of the mangler isn't manipulating the function
> type context correctly. But actually I think the problem is that it's
> ridiculous to assume that arbitrary local declarations
Eugene.Zelenko added inline comments.
Comment at: docs/ReleaseNotes.rst:116
+
+ This check searches for those for loops which has a loop variable with
+ a "too small" type which means this type can't represent all values
Please avoid This check, may be
Szelethus updated this revision to Diff 172459.
Szelethus marked an inline comment as done.
Szelethus added a comment.
- Fixes according to @xazax.hun's observations
Thanks! I'll commit when I have time watch buildbots.
https://reviews.llvm.org/D52794
Files:
Author: rsmith
Date: Fri Nov 2 19:23:33 2018
New Revision: 346065
URL: http://llvm.org/viewvc/llvm-project?rev=346065=rev
Log:
Revert r345562: "PR23833, DR2140: an lvalue-to-rvalue conversion on a glvalue
of type"
This exposes a (known) CodeGen bug: it can't cope with emitting lvalue
mgrang created this revision.
mgrang added reviewers: rnk, efriedma, mstorsjo, TomTan.
Herald added subscribers: kristina, jfb, chrib, kristof.beyls, javed.absar.
This is seventh in a series of patches to move intrinsic definitions out of
intrin.h.
Repository:
rC Clang
jfb added a comment.
I'm not sure this is the right fix because mangling confuses me. It fixes the
assertion I'm encountering in my patch, and I don't think I can create a repro
without the patch (since I'm asking to mangle a local in a way we don't seem to
right now).
Repository:
rC Clang
This revision was automatically updated to reflect the committed changes.
Closed by commit rL346056: [CMake][Fuchsia] Set -fuse-ld=lld explicitly for
Linux runtimes (authored by phosek, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
mgrang created this revision.
mgrang added reviewers: rnk, efriedma, mstorsjo, TomTan.
Herald added subscribers: kristina, jfb, chrib, kristof.beyls, javed.absar.
This is fifth in a series of patches to move intrinsic defintions out of
intrin.h.
Repository:
rC Clang
phosek created this revision.
phosek added a reviewer: mcgrathr.
Herald added subscribers: cfe-commits, mgorny.
We set lld as the default linker on non-Darwin platforms, but we still
need to set -fuse-ld=lld explicitly in to support cross-compiling Linux
runtimes on Darwin.
Repository:
rC
Author: maskray
Date: Thu Nov 1 22:59:29 2018
New Revision: 345953
URL: http://llvm.org/viewvc/llvm-project?rev=345953=rev
Log:
[clangd] Really fix clang -Wimplicit-fallthrough
The intention was to fall through to Function case in
LLVM_ENABLE_ASSERTIONS=Off builds.
Use #ifndef NDEBUG to fix
lebedev.ri added a comment.
In https://reviews.llvm.org/D53949#1283872, @regehr wrote:
> Regarding ++ and --, I think for now it's fine to just document that these
> aren't instrumented.
Indeed, that is a different issue, i don't want to solve it in this
differential.
Though, there currently
void updated this revision to Diff 172313.
Repository:
rC Clang
https://reviews.llvm.org/D53921
Files:
include/clang/AST/Expr.h
include/clang/ASTMatchers/ASTMatchers.h
lib/AST/ASTImporter.cpp
lib/AST/Expr.cpp
lib/AST/ExprConstant.cpp
lib/ASTMatchers/ASTMatchersInternal.cpp
wuzish added inline comments.
Comment at: clang/lib/Sema/SemaOverload.cpp:3913
+for (auto Type : Types) {
+ if (S.Context.getCanonicalType(Type)->getTypeClass() != Type::Vector)
+return false;
hubert.reinterpretcast wrote:
> wuzish
hans added a comment.
Thanks! I don't think the new isThisDeclarationADefinition() and
isImplicitlyInstantiable() checks are right. Besides that, I only have a few
more comments about the test.
Comment at: clang/lib/Sema/SemaDeclCXX.cpp:5715
+
takuto.ikuta updated this revision to Diff 172317.
takuto.ikuta added a comment.
Added cl driver flag test
https://reviews.llvm.org/D51340
Files:
clang/include/clang/Basic/Attr.td
clang/include/clang/Basic/LangOptions.def
clang/include/clang/Driver/CC1Options.td
takuto.ikuta marked an inline comment as done.
takuto.ikuta added a comment.
I missed the comment about driver flag test.
https://reviews.llvm.org/D51340
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
kbobyrev added a comment.
In https://reviews.llvm.org/D52998#1284312, @eandrews wrote:
> > Upstreaming it first might be better, especially since the change seems to
> > be trivial. Is this line addition the only change proposed for the
> > benchmark library?
>
> Yes this line is the only
Szelethus added a comment.
Also, thank you so much for the feedback on this, and almost every single other
patch I made!
https://reviews.llvm.org/D53692
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
Szelethus added a comment.
In https://reviews.llvm.org/D53692#1285091, @NoQ wrote:
> I guess i'm running out of steam for today :)
>
> > `Opts.shouldDoThat()` -> `Opts.ShouldDoThat.getValue()`
>
> Is this really unavoidable? Like, what makes them optional when they're
> always non-optional?
sammccall marked an inline comment as done.
sammccall added a comment.
In https://reviews.llvm.org/D53953#1285244, @hokein wrote:
> I think this is a bug, we should return non-zero code when processing a
> non-existing file. The new behavior seems better to me, though we need to
> polish the
Author: plyster
Date: Fri Nov 2 05:18:11 2018
New Revision: 345967
URL: http://llvm.org/viewvc/llvm-project?rev=345967=rev
Log:
Add support for 'atomic_default_mem_order' clause on 'requires' directive. Also
renamed test files relating to 'requires'. Differntial review:
Author: ibiryukov
Date: Fri Nov 2 03:50:26 2018
New Revision: 345963
URL: http://llvm.org/viewvc/llvm-project?rev=345963=rev
Log:
Revert "Fix regression in behavior of clang -x c++-header -fmodule-name=XXX"
This reverts commit r345803 and r345915 (a follow-up fix to r345803).
Reason: r345803
Hiya Sam,
are you aware that r345961 caused a test failure on the following bot and
build
http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/builds/21169
is there any chance you could take a look please?
thanks
Tom
On Fri, 2 Nov 2018 at 10:04, Sam McCall via
xazax.hun accepted this revision.
xazax.hun added a comment.
One question otherwise looks good.
Comment at: lib/StaticAnalyzer/Core/PlistDiagnostics.cpp:884
+ // even if we lex a tok::comma and ParanthesesDepth == 1.
+ const IdentifierInfo *__VA_ARGS__II =
xazax.hun added a comment.
I also would like to see in a tool how this would look like as an event before
committing :) Just a sanity check to make sure this feature makes sense. Could
you post a screenshot of CodeChecker or any other tool using this feature?
https://reviews.llvm.org/D52790
grimar added a comment.
In https://reviews.llvm.org/D52296#1284130, @probinson wrote:
> In https://reviews.llvm.org/D52296#1283691, @grimar wrote:
>
> > Nice :)
> > So seems the last unresolved question left is the naming of the new option?
> > If we do not want to go with
Szelethus added inline comments.
Comment at: include/clang/StaticAnalyzer/Core/AnalyzerOptions.h:146-149
+/// If you'd like to add a new -cc1 flag, add it to
+/// include/clang/Driver/CC1Options.td, add a new field to store the value of
+/// that flag in this class, and
Author: xazax
Date: Fri Nov 2 04:22:22 2018
New Revision: 345965
URL: http://llvm.org/viewvc/llvm-project?rev=345965=rev
Log:
[analyzer][CTU] Correctly signal in the function index generation tool if there
was an error
Differential Revision: https://reviews.llvm.org/D53979
Modified:
This revision was automatically updated to reflect the committed changes.
Closed by commit rL345965: [analyzer][CTU] Correctly signal in the function
index generation tool if there… (authored by xazax, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
xazax.hun accepted this revision.
xazax.hun added a comment.
This revision is now accepted and ready to land.
LGTM, but let's wait for @NoQ before committing.
Repository:
rC Clang
https://reviews.llvm.org/D53995
___
cfe-commits mailing list
hokein accepted this revision.
hokein added a comment.
This revision is now accepted and ready to land.
This looks clearer!
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D54033
___
cfe-commits mailing list
sammccall updated this revision to Diff 172326.
sammccall added a comment.
Address comment, rebase
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D53953
Files:
clang-tidy/ClangTidy.cpp
clang-tidy/ClangTidy.h
clang-tidy/ClangTidyDiagnosticConsumer.cpp
lebedev.ri updated this revision to Diff 172335.
lebedev.ri added a comment.
And finish the test coverage.
(sidenote: will these follow-ups again be stuck for two months? let's see!)
Repository:
rC Clang
https://reviews.llvm.org/D53949
Files:
lib/CodeGen/CGExprScalar.cpp
xazax.hun added inline comments.
Comment at: lib/StaticAnalyzer/Core/PlistDiagnostics.cpp:685
const MacroInfo *MI = nullptr;
+ llvm::Optional Args;
I wonder if the optional gives us any value here. An empty map could be just as
great to represent that
sammccall created this revision.
sammccall added a reviewer: hokein.
Herald added subscribers: cfe-commits, xazax.hun.
Clang's hierarchy is CompilerInstance -> DiagnosticsEngine ->
DiagnosticConsumer.
(Ownership is optional/shared, but this structure is fairly clear).
Currently
Author: sammccall
Date: Fri Nov 2 06:06:55 2018
New Revision: 345969
URL: http://llvm.org/viewvc/llvm-project?rev=345969=rev
Log:
[clangd] Remove didOpen extraFlags extension.
Summary:
This was added in D34947 to support YCM, but YCM actually provides *all* args,
and this was never actually
takuto.ikuta added a comment.
Thank you for quick review!
Comment at: clang/lib/Sema/SemaDeclCXX.cpp:5715
+ (MD->isThisDeclarationADefinition() ||
+ MD->isImplicitlyInstantiable()) &&
+ TSK != TSK_ExplicitInstantiationDeclaration &&
takuto.ikuta updated this revision to Diff 172332.
https://reviews.llvm.org/D51340
Files:
clang/include/clang/Basic/Attr.td
clang/include/clang/Basic/LangOptions.def
clang/include/clang/Driver/CC1Options.td
clang/include/clang/Driver/CLCompatOptions.td
takuto.ikuta updated this revision to Diff 172331.
takuto.ikuta added a comment.
added a few more check
https://reviews.llvm.org/D51340
Files:
clang/include/clang/Basic/Attr.td
clang/include/clang/Basic/LangOptions.def
clang/include/clang/Driver/CC1Options.td
xazax.hun accepted this revision.
xazax.hun added a comment.
One question and one nit otherwise looks good. Feel free to commit once those
are resolved without another round of reviews.
Comment at: lib/StaticAnalyzer/Core/PlistDiagnostics.cpp:805
+// macro.
+if (const
This revision was automatically updated to reflect the committed changes.
Closed by commit rL345968: [clangd] Only log ignored diagnostics with
-log=verbose. (authored by sammccall, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D53648
This revision was automatically updated to reflect the committed changes.
Closed by commit rCTE345961: [clang-tidy] Get ClangTidyContext out of the
business of storing diagnostics. (authored by sammccall, committed by ).
Changed prior to commit:
Author: sammccall
Date: Fri Nov 2 03:01:59 2018
New Revision: 345961
URL: http://llvm.org/viewvc/llvm-project?rev=345961=rev
Log:
[clang-tidy] Get ClangTidyContext out of the business of storing diagnostics.
NFC
Summary:
Currently ClangTidyContext::diag() sends the diagnostics to a
takuto.ikuta updated this revision to Diff 172330.
takuto.ikuta marked 10 inline comments as done.
takuto.ikuta added a comment.
Address comment
https://reviews.llvm.org/D51340
Files:
clang/include/clang/Basic/Attr.td
clang/include/clang/Basic/LangOptions.def
hans accepted this revision.
hans added a comment.
This revision is now accepted and ready to land.
Assuming the test still passes when you put the EXPORTINLINE filecheck prefix
back, looks good to me!
Comment at: clang/test/CodeGenCXX/dllexport-no-dllexport-inlines.cpp:9
+//
xazax.hun added inline comments.
Comment at: lib/StaticAnalyzer/Core/AnalyzerOptions.cpp:227
-CTUDir = getStringOption("ctu-dir", "");
-if (!llvm::sys::fs::is_directory(*CTUDir))
- CTUDir = "";
Szelethus wrote:
> This check should and will be moved
Author: sammccall
Date: Fri Nov 2 05:51:26 2018
New Revision: 345968
URL: http://llvm.org/viewvc/llvm-project?rev=345968=rev
Log:
[clangd] Only log ignored diagnostics with -log=verbose.
Reviewers: ilya-biryukov
Subscribers: ioeric, MaskRay, jkorous, arphaman, kadircet, cfe-commits
takuto.ikuta updated this revision to Diff 172348.
takuto.ikuta marked an inline comment as done.
takuto.ikuta added a comment.
Fix check-prefix
https://reviews.llvm.org/D51340
Files:
clang/include/clang/Basic/Attr.td
clang/include/clang/Basic/LangOptions.def
This revision was automatically updated to reflect the committed changes.
Closed by commit rCTE345973: [clangd] Add fallbackFlags initialization
extension. (authored by sammccall, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D53688?vs=171036=172351#toc
Repository:
rCTE
This revision was automatically updated to reflect the committed changes.
Closed by commit rCTE345970: [clangd] Make in-memory CDB always available as an
overlay, refactor. (authored by sammccall, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D53687?vs=171098=172342#toc
This revision was automatically updated to reflect the committed changes.
Closed by commit rL345970: [clangd] Make in-memory CDB always available as an
overlay, refactor. (authored by sammccall, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
takuto.ikuta added a comment.
Thank you! I'll submit this if other people does not have other comments.
Comment at: clang/test/CodeGenCXX/dllexport-no-dllexport-inlines.cpp:9
+// RUN: -emit-llvm -O1 -o - | \
+// RUN: FileCheck
> On 2 Nov 2018, at 15:03, Tim Northover wrote:
>> (If the do belong here: the namespaces and comments don't seem to have been
>> updated)
>
> Good point, I’ll get onto fixing that.
Actually, do you have any particular ones in mind? After going in to make
changes, they still look pretty
On Fri, Nov 2, 2018 at 4:08 PM Tim Northover wrote:
> After that it was discovered OSLog depends on the other format helpers so
> there was still a circular dependency; I decided adding the others was a
> minor enough change to just go ahead.
>
Thanks - I missed the review.
> On 2 Nov 2018, at
Author: abataev
Date: Fri Nov 2 08:25:06 2018
New Revision: 345982
URL: http://llvm.org/viewvc/llvm-project?rev=345982=rev
Log:
[OPENMP]Change the mapping type for lambda captures.
The previously used combination `PTR_AND_OBJ | PRIVATE` could be used for
mapping of some data in Fortran.
xazax.hun updated this revision to Diff 172354.
xazax.hun added a comment.
This new version based on the bullets by NoQ. I also included some additional
ones from other lists and added some new ones, e.g. the NamedDecl::getName will
fail if the name of the decl is not a single token. I also
Author: abataev
Date: Fri Nov 2 07:54:07 2018
New Revision: 345978
URL: http://llvm.org/viewvc/llvm-project?rev=345978=rev
Log:
[OPENMP][NVPTX]Improve emission of the globalized variables for
target/teams/distribute regions.
Target/teams/distribute regions exist for all the time the kernel is
Hi Sam,
On 2 Nov 2018, at 13:31, Sam McCall wrote:
> The move of OSLog.h and FormatString.h to AST doesn't look obviously correct.
> Do these really belong in this layer? I think this patch needs review from
> someone who knows AST/ better than myself... was there a review?
Eli reviewed the
TWeaver created this revision.
TWeaver added a reviewer: sammccall.
Herald added subscribers: llvm-commits, xazax.hun.
r345961 introduced a path check in
.\tools\clang\tools\extra\test\clang-tidy\clang-tidy-run-with-database.cpp.
r345961 added a check line for a path that only handled / on unix
This revision was automatically updated to reflect the committed changes.
Closed by commit rCTE345969: [clangd] Remove didOpen extraFlags extension.
(authored by sammccall, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D53641?vs=170858=172341#toc
Repository:
rCTE Clang
Author: sammccall
Date: Fri Nov 2 06:09:36 2018
New Revision: 345970
URL: http://llvm.org/viewvc/llvm-project?rev=345970=rev
Log:
[clangd] Make in-memory CDB always available as an overlay, refactor.
Summary:
The new implementation is a GlobalCompilationDatabase that overlays a base.
Normally
Author: tnorthover
Date: Fri Nov 2 06:14:11 2018
New Revision: 345971
URL: http://llvm.org/viewvc/llvm-project?rev=345971=rev
Log:
Reapply Logging: make os_log buffer size an integer constant expression.
The size of an os_log buffer is known at any stage of compilation, so making it
a constant
atanasyan accepted this revision.
atanasyan added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rC Clang
https://reviews.llvm.org/D53984
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
AlexeySotkin added inline comments.
Herald added a reviewer: shafik.
Comment at: lib/Sema/SemaInit.cpp:8073
+ assert((Step->Type->isEventT() || Step->Type->isQueueT() ||
+ Step->Type->isOCLIntelSubgroupAVCType) &&
"Wrong type for initialization of
Author: alexfh
Date: Fri Nov 2 08:03:43 2018
New Revision: 345979
URL: http://llvm.org/viewvc/llvm-project?rev=345979=rev
Log:
[clang-tidy] .reset(new X) -> make_unique() in a comment. NFC
Modified:
clang-tools-extra/trunk/clang-tidy/utils/IncludeInserter.h
Modified:
rnkovacs added a comment.
In https://reviews.llvm.org/D53856#1280408, @Szelethus wrote:
> In https://reviews.llvm.org/D53856#1279887, @NoQ wrote:
>
> > This might be also covered by @rnkovacs's string buffer escape checker -
> > either already or eventually, it'll become just yet another string
ABataev abandoned this revision.
ABataev added a comment.
The patch is not required anymore as it is implemented in the different way
Repository:
rC Clang
https://reviews.llvm.org/D45783
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
Author: sammccall
Date: Fri Nov 2 07:07:51 2018
New Revision: 345973
URL: http://llvm.org/viewvc/llvm-project?rev=345973=rev
Log:
[clangd] Add fallbackFlags initialization extension.
Summary:
This allows customizing the flags used when no compile database is
available. It addresses some uses of
TWeaver added a comment.
The test failed on the following build bot:
http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/builds/21169
Repository:
rL LLVM
https://reviews.llvm.org/D54036
___
cfe-commits mailing
This revision was automatically updated to reflect the committed changes.
Closed by commit rL346001: Change
-fsanitize-address-poison-class-member-array-new-cookie to -fsanitize…
(authored by filcab, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
filcab added a comment.
Thanks for the review.
Unfortunately, I forgot to edit the commit message. Let's hope no one gets too
confused (phab reviews will be up anyway, so should be easy to figure out).
Filipe
Repository:
rL LLVM
https://reviews.llvm.org/D52615
rjmccall accepted this revision.
rjmccall added a comment.
This revision is now accepted and ready to land.
Thanks, LGTM.
Repository:
rC Clang
https://reviews.llvm.org/D52615
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
On Fri, Nov 2, 2018 at 12:34 PM Kristof Umann via cfe-commits
wrote:
>
> Author: szelethus
> Date: Fri Nov 2 09:32:15 2018
> New Revision: 345993
>
> URL: http://llvm.org/viewvc/llvm-project?rev=345993=rev
> Log:
> Didn't -> didnt, because #errors complains about untermianted '
Why not quote
eandrews added a comment.
Thanks!
https://reviews.llvm.org/D52998
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: filcab
Date: Fri Nov 2 10:29:04 2018
New Revision: 346001
URL: http://llvm.org/viewvc/llvm-project?rev=346001=rev
Log:
Change -fsanitize-address-poison-class-member-array-new-cookie to
-fsanitize-address-poison-custom-array-cookie
Handle it in the driver and propagate it to cc1
This revision was automatically updated to reflect the committed changes.
Closed by commit rC346001: Change
-fsanitize-address-poison-class-member-array-new-cookie to -fsanitize…
(authored by filcab, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D52615?vs=172376=172392#toc
Author: epilk
Date: Fri Nov 2 10:36:58 2018
New Revision: 346004
URL: http://llvm.org/viewvc/llvm-project?rev=346004=rev
Log:
[CodeGen] Fix a crash when updating a designated initializer
We need to handle the ConstantAggregateZero case here too.
rdar://45691981
Differential revision:
This revision was automatically updated to reflect the committed changes.
Closed by commit rC346004: [CodeGen] Fix a crash when updating a designated
initializer (authored by epilk, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D54010?vs=172306=172396#toc
Repository:
rC
1 - 100 of 177 matches
Mail list logo
