This revision was automatically updated to reflect the committed changes.
Closed by commit rC347351: [OpenMP] Update CHECK-DAG usage in
target_parallel_codegen.cpp (authored by jdenny, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D54765?vs=174817=174837#toc
Repository:
This revision was automatically updated to reflect the committed changes.
Closed by commit rC347350: [OpenMP] Update CHECK-DAG usage in for_codegen.cpp
(authored by jdenny, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D54764?vs=174816=174836#toc
Repository:
rC Clang
Author: jdenny
Date: Tue Nov 20 14:05:23 2018
New Revision: 347351
URL: http://llvm.org/viewvc/llvm-project?rev=347351=rev
Log:
[OpenMP] Update CHECK-DAG usage in target_parallel_codegen.cpp
This patch adjusts a test not to depend on deprecated FileCheck
behavior that permits overlapping matches
rsmith created this revision.
rsmith added a reviewer: rjmccall.
Herald added a subscriber: cfe-commits.
This fixes a miscompile where we'd emit a VTT for a class that ends up
referencing an inline virtual member function that we can't actually
emit a body for (because we never instantiated it in
Author: sammccall
Date: Tue Nov 20 14:06:54 2018
New Revision: 347352
URL: http://llvm.org/viewvc/llvm-project?rev=347352=rev
Log:
[CodeComplete] Penalize inherited ObjC properties for auto-completion
Summary:
Similar to auto-completion for ObjC methods, inherited properties
should be penalized
Author: lebedevri
Date: Tue Nov 20 10:59:05 2018
New Revision: 347339
URL: http://llvm.org/viewvc/llvm-project?rev=347339=rev
Log:
[clang][Parse] Diagnose useless null statements / empty init-statements
Summary:
clang has `-Wextra-semi` (D43162), which is not dictated by the currently
selected
richard.barton.arm added a comment.
Hi @nickdesaulniers
I have run into this too recently so would love to see this patch land. Did you
get anywhere with those lld test failures?
Ta
Rich
Repository:
rC Clang
https://reviews.llvm.org/D53210
___
jdenny created this revision.
jdenny added a reviewer: ABataev.
Herald added a subscriber: guansong.
This patch adjusts a test not to depend on deprecated FileCheck
behavior that permits overlapping matches within a block of CHECK-DAG
directives. Thus, this patch also removes uses of FileCheck's
ABataev accepted this revision.
ABataev added a comment.
This revision is now accepted and ready to land.
LG
Repository:
rC Clang
https://reviews.llvm.org/D54765
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
ABataev added a comment.
In https://reviews.llvm.org/D54764#1304606, @jdenny wrote:
> In https://reviews.llvm.org/D54764#1304573, @ABataev wrote:
>
> > I'm fine with the patch,
>
>
> Thanks for the quick reviews. I'll push soon.
>
> > the original intention was to handle a possible situation
JonasToth added inline comments.
Comment at: unittests/clang-tidy/AddConstTest.cpp:733
+ StringRef T = "template void f(T v) \n";
+ StringRef S = "{ T target = v; }";
+ auto Cat = [](StringRef S) { return (T + S).str(); };
alexfh wrote:
> It would be
lebedev.ri added inline comments.
Comment at: clang-tidy/bugprone/BranchCloneCheck.cpp:43
+
+ for (unsigned i = 0; i < LHS.size(); i++) {
+if (!areStatementsIdentical(LHS[i]->stripLabelLikeStatements(),
Eugene.Zelenko wrote:
> Please use size_t.
Also
```
Eugene.Zelenko added inline comments.
Comment at: docs/ReleaseNotes.rst:60
+- New :doc:`misc-incorrect-pointer-cast
+ ` check
hgabii wrote:
> Eugene.Zelenko wrote:
> > Will be good idea to rebase from trunk and use alphabetical order.
> It is rebased. I could
JonasToth added a comment.
IMHO this patch is fine, but i think a language expert (not me :D) should take
a look (@aaron.ballman ?) as its complicated :)
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D54745
___
cfe-commits mailing
rsmith added a comment.
Thanks! Some simplifications are possible here, but otherwise this looks good.
Comment at: clang/lib/Sema/SemaExpr.cpp:14946
+ // as invalid as well.
+ if (const CXXRecordDecl *RD = FieldType->getAsCXXRecordDecl()) {
+if (RD->isInvalidDecl()) {
jdenny created this revision.
jdenny added a reviewer: ABataev.
Herald added a subscriber: guansong.
This patch adjusts a test not to depend on deprecated FileCheck
behavior that permits overlapping matches within a block of CHECK-DAG
directives. Thus, this patch also removes uses of FileCheck's
JonasToth updated this revision to Diff 174828.
JonasToth added a comment.
add tests for different template instantiations
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D54395
Files:
clang-tidy/performance/ForRangeCopyCheck.cpp
sammccall added a comment.
Very nice! Mostly just a few style/structure nits.
Comment at: clangd/AST.cpp:69
+std::string printName(const NamedDecl ) {
+ const NamedDecl *NameSource =
+ std::string Name = llvm::to_string(NameSource->getDeclName());
just use
rnk added a comment.
Well, you could go further down the route of what we do for "structors", and
store the top-level decl being mangled in the mangler. Would that solve the
problem?
Repository:
rC Clang
https://reviews.llvm.org/D52674
___
hgabii marked 9 inline comments as done.
hgabii added a comment.
I resolved all comments.
Comment at: docs/ReleaseNotes.rst:60
+- New :doc:`misc-incorrect-pointer-cast
+ ` check
Eugene.Zelenko wrote:
> Will be good idea to rebase from trunk and use
Author: jdenny
Date: Tue Nov 20 14:04:45 2018
New Revision: 347350
URL: http://llvm.org/viewvc/llvm-project?rev=347350=rev
Log:
[OpenMP] Update CHECK-DAG usage in for_codegen.cpp
This patch adjusts a test not to depend on deprecated FileCheck
behavior that permits overlapping matches within a
sammccall added a comment.
Nice!
The biggest suggestion I have is merging the callback into ASTCallbacks. That's
awkward in initialization (`makeUpdateCallbacks` probably needs to be called
unconditionally with a maybe-null pointer) but it seems like a natural grouping
in all the places it
ldionne accepted this revision.
ldionne added a comment.
LGTM
Repository:
rCXX libc++
https://reviews.llvm.org/D51268
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
tejohnson updated this revision to Diff 174835.
tejohnson added a comment.
Update to use new module flag
Repository:
rC Clang
https://reviews.llvm.org/D53891
Files:
include/clang/Driver/Options.td
include/clang/Driver/SanitizerArgs.h
include/clang/Frontend/CodeGenOptions.def
tejohnson abandoned this revision.
tejohnson added a comment.
Abandoned in favor of new approach in
https://reviews.llvm.org/D53890/https://reviews.llvm.org/D53891.
Repository:
rC Clang
https://reviews.llvm.org/D53524
___
cfe-commits mailing
rsmith added a comment.
In the past, we've been resistant to adding more fine-grained compat warnings,
because we don't want to encourage subsetting the language (which sounds like
exactly what you're trying to do here). We generally don't think it's Clang's
business to enforce coding style
This revision was automatically updated to reflect the committed changes.
Closed by commit rC347339: [clang][Parse] Diagnose useless null statements /
empty init-statements (authored by lebedevri, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D52695?vs=174624=174812#toc
jdenny added a comment.
In https://reviews.llvm.org/D54764#1304573, @ABataev wrote:
> I'm fine with the patch,
Thanks for the quick reviews. I'll push soon.
> the original intention was to handle a possible situation where we may have
> several debug locations with the same line numbers.
nickdesaulniers added a comment.
Hi @richard.barton.arm , this has landed already. If you click "show older"
you'll see the UI element that shows this landed as r344536 (Oct 15 2018). If
your clang version is later than r344536 (what will become clang-8) and you
still see this, please open a
This revision was automatically updated to reflect the committed changes.
Closed by commit rC347352: [CodeComplete] Penalize inherited ObjC properties
for auto-completion (authored by sammccall, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D53900?vs=171799=174838#toc
phosek added a comment.
@rsmith friendly ping?
Repository:
rC Clang
https://reviews.llvm.org/D53787
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rjmccall accepted this revision.
rjmccall added a comment.
This revision is now accepted and ready to land.
LGTM.
Repository:
rC Clang
https://reviews.llvm.org/D54768
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
Author: void
Date: Tue Nov 20 15:24:16 2018
New Revision: 347364
URL: http://llvm.org/viewvc/llvm-project?rev=347364=rev
Log:
Reinstate 347294 with a fix for the failures.
EvaluateAsInt() is sometimes called in a constant context. When that's the
case, we need to specify it as so.
Modified:
Eugene.Zelenko added inline comments.
Comment at: docs/clang-tidy/checks/abseil-duration-comparison.rst:11
+compared against a floating-pointer value, truncation during the ``Duration``
+conversion might yield a different result. In practice this is very rare, and
+still
This revision was automatically updated to reflect the committed changes.
Closed by commit rCXX347377: [libc++] Implement P0487R1 - Fixing
operator(basic_istream, CharT*) (authored by lichray, committed by
).
Changed prior to commit:
https://reviews.llvm.org/D51268?vs=174722=174864#toc
malaperle created this revision.
Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay,
ioeric, ilya-biryukov.
Alt+o is used on Windows/Linux and Option+Cmd+o on macOS.
Signed-off-by: Marc-Andre Laperle
Repository:
rCTE Clang Tools Extra
cameron.mcinally added a comment.
In https://reviews.llvm.org/D53157#1304275, @kpn wrote:
> In https://reviews.llvm.org/D53157#1303398, @cameron.mcinally wrote:
>
> > If we all agree upon that, then we simply have to treat the functions that
> > modify the FPEnv, e.g. fesetexcept(...), as
Author: alexfh
Date: Tue Nov 20 17:11:18 2018
New Revision: 347373
URL: http://llvm.org/viewvc/llvm-project?rev=347373=rev
Log:
[clang-tidy] Add a test for proper handling of locations in scratch space.
This test examines the behavior change of clang::tooling::Diagnostic in r347372.
Added:
andrew.w.kaylor added a comment.
In https://reviews.llvm.org/D53157#1304895, @cameron.mcinally wrote:
> The problem I was missing is when a FENV_ACCESS=OFF operation, like a FDIV,
> is hoisted into a FENV_ACCESS=ON region. I see it now, but still think that
> forcing FENV_ACCESS=OFF operations
hfinkel added a comment.
In https://reviews.llvm.org/D53157#1304873, @cameron.mcinally wrote:
> In https://reviews.llvm.org/D53157#1304275, @kpn wrote:
>
> > In https://reviews.llvm.org/D53157#1303398, @cameron.mcinally wrote:
> >
> > > If we all agree upon that, then we simply have to treat the
Author: alexfh
Date: Tue Nov 20 17:06:32 2018
New Revision: 347371
URL: http://llvm.org/viewvc/llvm-project?rev=347371=rev
Log:
Implement YAML serialization of notes in clang::tooling::Diagnostic.
Modified:
cfe/trunk/include/clang/Tooling/DiagnosticsYaml.h
Author: void
Date: Tue Nov 20 15:24:39 2018
New Revision: 347366
URL: http://llvm.org/viewvc/llvm-project?rev=347366=rev
Log:
Update EvaluateAsInt to the new syntax.
Modified:
clang-tools-extra/trunk/clang-tidy/bugprone/MisplacedWideningCastCheck.cpp
cameron.mcinally added a comment.
In https://reviews.llvm.org/D53157#1304880, @hfinkel wrote:
> In https://reviews.llvm.org/D53157#1304873, @cameron.mcinally wrote:
>
> > I'd like to hear more about this. The fesetexcept(...) function and friends
> > change the FPEnv state, which can change the
jgorbe added a comment.
Added a test for the "capturing an array of incomplete type" case. See also
responses to inline comments below.
Comment at: clang/lib/Sema/SemaExpr.cpp:14946
+ // as invalid as well.
+ if (const CXXRecordDecl *RD = FieldType->getAsCXXRecordDecl()) {
This revision was automatically updated to reflect the committed changes.
Closed by commit rC347378: [Driver] Link sanitizer runtime deps on Fuchsia when
needed (authored by phosek, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D54741?vs=174728=174868#toc
Repository:
rC
Author: phosek
Date: Tue Nov 20 20:33:44 2018
New Revision: 347378
URL: http://llvm.org/viewvc/llvm-project?rev=347378=rev
Log:
[Driver] Link sanitizer runtime deps on Fuchsia when needed
Even though these deps weren't needed, this makes Fuchsia driver
better match other drivers, and it may be
russellmcc added a comment.
Bump! Thanks again for your consideration.
https://reviews.llvm.org/D40988
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jgorbe updated this revision to Diff 174853.
jgorbe marked 2 inline comments as done.
https://reviews.llvm.org/D54550
Files:
clang/lib/Sema/SemaExpr.cpp
clang/test/SemaCXX/lambda-invalid-array-capture.cpp
clang/test/SemaCXX/lambda-invalid-capture.cpp
Index:
cameron.mcinally added a comment.
In https://reviews.llvm.org/D53157#1304347, @uweigand wrote:
> OK, let me try to expand on my point 3 above, which appears to have confused
> everybody :-)
Ah, that makes more sense.
The problem I was missing is when a FENV_ACCESS=OFF operation, like a FDIV,
Author: alexfh
Date: Tue Nov 20 17:08:46 2018
New Revision: 347372
URL: http://llvm.org/viewvc/llvm-project?rev=347372=rev
Log:
clang::tooling::Diagnostic: Don't store offset in the scratch space.
These offsets are useless (and even harmful in certain cases) in exported
diagnostics. The test
rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
Looks good, thanks! (Though we generally prefer fewer test files with more test
per file, because a lot of the overhead of running tests is the setup /
teardown time, so can you merge the two
cameron.mcinally added a comment.
In https://reviews.llvm.org/D53157#1304900, @andrew.w.kaylor wrote:
> I think at this point we're all on the same page in this regard. I just
> wanted to make sure we also understand why we're on that page. I still
> believe it was the correct choice.
Yup,
malaperle updated this revision to Diff 174866.
malaperle added a comment.
Fix a bad change
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D54781
Files:
clangd/clients/clangd-vscode/package.json
clangd/clients/clangd-vscode/src/extension.ts
Index:
Author: maskray
Date: Tue Nov 20 00:00:00 2018
New Revision: 347293
URL: http://llvm.org/viewvc/llvm-project?rev=347293=rev
Log:
[libclang] Unify getCursorDecl and getCursorParentDecl
They do the same thing, thus the latter (which has only 2 call sites) can be
deleted.
Modified:
Author: void
Date: Tue Nov 20 00:53:30 2018
New Revision: 347294
URL: http://llvm.org/viewvc/llvm-project?rev=347294=rev
Log:
Use is.constant intrinsic for __builtin_constant_p
Summary:
A __builtin_constant_p may end up with a constant after inlining. Use
the is.constant intrinsic if it's a
This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rC347294: Use is.constant intrinsic for __builtin_constant_p
(authored by void, committed by ).
Changed prior to commit:
Szelethus added a comment.
Herald added subscribers: gamesh411, baloghadamsoftware.
Ping
https://reviews.llvm.org/D54401
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Hi George,
I noticed that valgrind started complaining in one case with this patch.
I've no idea if it's really due to something in the patch or if it's
something old that surfaced or if it's a false flag.
Anyway, with this patch the following
valgrind clang-tidy
dim added a comment.
In https://reviews.llvm.org/D54724#1303844, @phosek wrote:
> In https://reviews.llvm.org/D54724#1303809, @dim wrote:
>
> > I think this is the wrong direction, placing "common" code in
> > `addCXXStdlibLinkDeps`, which then has all kinds of ugly ifs and switches
> > for
This revision was automatically updated to reflect the committed changes.
Closed by commit rCRT347338: [cmake] Fix detecting terminfo library (authored
by mgorny, committed by ).
Repository:
rCRT Compiler Runtime
https://reviews.llvm.org/D54641
Files:
cmake/config-ix.cmake
Index:
Eugene.Zelenko added inline comments.
Comment at: clang-tidy/bugprone/BranchCloneCheck.cpp:19
+
+namespace {
+
Please use anonymous namespaces only for type declarations. See LLV coding
style guide.
Comment at:
ABataev accepted this revision.
ABataev added a comment.
This revision is now accepted and ready to land.
I'm fine with the patch, the original intention was to handle a possible
situation where we may have several debug locations with the same line numbers.
Repository:
rC Clang
lebedev.ri added a comment.
`Warn for cases when the pointed to type is wider than the allocated type.`
What does that mean? Is this talking about the size of the allocation, or the
alignment?
Are you aware of the previous attempts, namely https://reviews.llvm.org/D33826?
Please incorporate the
JonasToth added a comment.
Could you please upload the diff with full context? Especially the parts with
refactoring are harder to judge if the code around is not visible. Thank you :)
Comment at: clang-tidy/abseil/DurationComparisonCheck.cpp:25
+static llvm::Optional
martong added a comment.
Herald added a subscriber: gamesh411.
@shafik,
I could run the libcxx tests on my Linux machine (Ubuntu 16.04) by installing
libcxx: `sudo apt-get install libc++-dev`.
From the logs of your build server seems like the crash happened with a
`_gmodules` test.
Charusso marked 8 inline comments as done.
Charusso added a comment.
@NoQ thanks you for the great explanation! I really wanted to write out known
constant integers and booleans but I think 'Knowing...' pieces would be more
cool.
I tried to minimize the changes after a little e-mailing with
Author: vvassilev
Date: Tue Nov 20 05:53:20 2018
New Revision: 347304
URL: http://llvm.org/viewvc/llvm-project?rev=347304=rev
Log:
Allow force updating the NumCreatedFIDsForFileID.
Our internal clients implement parsing cache based on FileID. In order for the
Preprocessor to reenter the cached
This revision was automatically updated to reflect the committed changes.
Closed by commit rC347304: Allow force updating the NumCreatedFIDsForFileID.
(authored by vvassilev, committed by ).
Repository:
rC Clang
https://reviews.llvm.org/D51295
Files:
include/clang/Basic/SourceManager.h
v.g.vassilev added a comment.
Is this change still relevant?
Repository:
rL LLVM
https://reviews.llvm.org/D35559
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
JonasToth added a comment.
Ok, Thank you for looking into it. You can abondon the revision in
phabricator (Selection above comment field at the bottom of the page) if
you wish.
Am 19.11.18 um 23:36 schrieb Mateusz Maćkowski via Phabricator:
> m4tx added a comment.
>
> After thinking about the
ilya-biryukov accepted this revision.
ilya-biryukov added a comment.
This revision is now accepted and ready to land.
LGTM
Comment at: clangd/Function.h:147
+private:
+ static_assert(std::is_same::type, T>::value,
+"use a plain type: event values are always
JonasToth added inline comments.
Comment at: test/clang-tidy/abseil-duration-comparison.cpp:89
+ // CHECK-FIXES: d1 > d2;
+
+ // Check against the LHS
JonasToth wrote:
> What would happen for a type, that can implicitly convert to a duration or
> double/int.
This revision was automatically updated to reflect the committed changes.
Closed by commit rL347298: [clangd] Replay preamble #includes to clang-tidy
checks. (authored by sammccall, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D54694
This revision was automatically updated to reflect the committed changes.
Closed by commit rL347297: [clangd] Allow observation of changes to global
CDBs. (authored by sammccall, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D54475
sammccall created this revision.
sammccall added a reviewer: ilya-biryukov.
Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay,
ioeric, javed.absar.
- Reads are never executed if canceled before ready-to run. In practice, we
finalize cancelled reads eagerly and
Author: sammccall
Date: Tue Nov 20 02:56:03 2018
New Revision: 347297
URL: http://llvm.org/viewvc/llvm-project?rev=347297=rev
Log:
[clangd] Allow observation of changes to global CDBs.
Summary:
Currently, changes *within* CDBs are not tracked (CDB has no facility to do so).
However, discovery of
v.g.vassilev added a comment.
ping...
https://reviews.llvm.org/D43871
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rCTE347298: [clangd] Replay preamble #includes to clang-tidy
checks. (authored by sammccall, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D54694?vs=174621=174742#toc
Repository:
Author: sammccall
Date: Tue Nov 20 02:58:48 2018
New Revision: 347298
URL: http://llvm.org/viewvc/llvm-project?rev=347298=rev
Log:
[clangd] Replay preamble #includes to clang-tidy checks.
Summary:
This is needed to correctly handle checks that use IncludeInserter,
which is very common.
I
ilya-biryukov accepted this revision.
ilya-biryukov added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D54694
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
hokein created this revision.
hokein added reviewers: JonasToth, aaron.ballman.
Herald added a subscriber: xazax.hun.
The fix for aggregate initialization (`std::make_unique(Foo {1, 2})` needs
to see Foo copy constructor, otherwise we will have a compiler error. So we
only emit the check warning.
JonasToth added a comment.
Does make_unique require the copy constructor if it could move?
And would the same argument apply to the move-constructors as the arguments are
forwarded?
What would happen in the obscure case of a public copy-constructor, but private
move-constructor (not saying it
uweigand added a comment.
It seems this patch caused the SystemZ build bots to fail, they're now all
running into assertion failures:
ICE cannot be evaluated!
UNREACHABLE executed at
/home/uweigand/sandbox/buildbot/clang-s390x-linux/llvm/tools/clang/lib/AST/ExprConstant.cpp:11442!
See e.g.
Author: martong
Date: Tue Nov 20 06:19:39 2018
New Revision: 347306
URL: http://llvm.org/viewvc/llvm-project?rev=347306=rev
Log:
[ASTImporter] Set redecl chain of functions before any other import
Summary:
FunctionDecl import starts with a lookup and then we create a new Decl.
Then in case of
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
Aside from some small nits, LGTM!
Comment at: docs/ReleaseNotes.rst:53
+- ``-Wextra-semi-stmt`` is a new diagnostic, which is, much like
+ ``-Wextra-semi``,
aaron.ballman added a comment.
Ping.
https://reviews.llvm.org/D54450
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
hokein added a comment.
Thanks for the review.
In https://reviews.llvm.org/D54745#1303972, @JonasToth wrote:
> Does make_unique require the copy constructor if it could move?
No, in that case, move constructor will be used. I have updated the patch to
include these cases.
> And would the
This revision was automatically updated to reflect the committed changes.
Closed by commit rC347307: [clang-format] JS: dont treat is: as a type
matcher (authored by krasimir, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D54753?vs=174759=174764#toc
Repository:
rC Clang
Author: krasimir
Date: Tue Nov 20 06:22:43 2018
New Revision: 347307
URL: http://llvm.org/viewvc/llvm-project?rev=347307=rev
Log:
[clang-format] JS: don't treat is: as a type matcher
Summary:
Clang-format is treating all occurences of `is` in js as type matchers. In some
cases this is wrong, as
Author: nico
Date: Tue Nov 20 07:27:43 2018
New Revision: 347314
URL: http://llvm.org/viewvc/llvm-project?rev=347314=rev
Log:
Revert 347294, it turned many bots on lab.llvm.org:8011/console red.
Modified:
cfe/trunk/include/clang/AST/Expr.h
cfe/trunk/lib/AST/ASTImporter.cpp
sammccall added inline comments.
Comment at: clangd/Quality.h:98
+ /// Whether the item matches the type expected in the completion context.
+ bool TypeMatchesPreferred = false;
/// FIXME: unify with index proximity score - signals should be
you've inserted
hokein updated this revision to Diff 174760.
hokein marked 2 inline comments as done.
hokein added a comment.
Address review comments, handle move constructor as well.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D54745
Files:
clang-tidy/modernize/MakeSmartPtrCheck.cpp
krasimir created this revision.
Herald added a subscriber: cfe-commits.
Clang-format is treating all occurences of `is` in js as type matchers. In some
cases this is wrong, as it might be a dict key.
Repository:
rC Clang
https://reviews.llvm.org/D54753
Files:
lib/Format/TokenAnnotator.cpp
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
> Currently the smart_ptr check (modernize-make-unique) generates the fixes
> that cannot compile for cases like below -- because brace list can not be
> deduced in make_unique.
sammccall added inline comments.
Comment at: clangd/ExpectedTypes.h:32
+/// this allows the representation to be stored in the index and compared with
+/// types coming from a different AST later.
+class OpaqueType {
ilya-biryukov wrote:
> sammccall wrote:
> >
sammccall added inline comments.
Comment at: clangd/index/Index.cpp:118
+static void own(Symbol , UniqueStringSaver ,
+BumpPtrAllocator ) {
visitStrings(S, [&](StringRef ) { V = Strings.save(V); });
why these changes?
Author: aaronballman
Date: Tue Nov 20 07:23:07 2018
New Revision: 347312
URL: http://llvm.org/viewvc/llvm-project?rev=347312=rev
Log:
Update the documentation for attribute feature tests.
This clarifies that __has_cpp_attribute is no longer always an extension since
it's now available in C++2a.
sammccall added inline comments.
Comment at: clangd/Quality.cpp:373
+ if (TypeMatchesPreferred)
+Score *= 2.0;
+
is 2 really enough?
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D52276
___
Charusso added inline comments.
Comment at: test/Analysis/diagnostics/macros.cpp:33
void testDoubleMacro(double d) {
- if (d == DBL_MAX) { // expected-note {{Taking true branch}}
+ if (d == DBL_MAX) { // expected-note {{Assuming 'd' is equal to DBL_MAX}}
+
Charusso added a comment.
In https://reviews.llvm.org/D54560#1301870, @NoQ wrote:
> Write down full messages in tests. When the message was updated from `'x' is
> moved'` to `Object 'x' is moved`, the tests were not updated because they
> kept passing because the former is still a sub-string
1 - 100 of 124 matches
Mail list logo
