[PATCH] D55262: [OpenCL] Fix for TBAA information of pointer after addresspacecast

romanovvlad added a comment. What bugs with unaligned pointers do you mean? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55262/new/ https://reviews.llvm.org/D55262 ___ cfe-commits mailing list

[PATCH] D55255: Fix a false positive in misplaced-widening-cast

dkrupp added a comment. In D55255#1319784 , @JonasToth wrote: > Committed, Thank you for the patch! Was there a bug-report for this issue? If > yes can you please close it/reference? There was not bug report for this. Thanks for committing!

[PATCH] D54757: [clang-tidy] new check: bugprone-branch-clone

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE348343: [clang-tidy] new check: bugprone-branch-clone (authored by JonasToth, committed by ). Changed prior to commit: https://reviews.llvm.org/D54757?vs=176408=176772#toc Repository: rCTE Clang

[clang-tools-extra] r348343 - [clang-tidy] new check: bugprone-branch-clone

Author: jonastoth Date: Wed Dec 5 01:16:25 2018 New Revision: 348343 URL: http://llvm.org/viewvc/llvm-project?rev=348343=rev Log: [clang-tidy] new check: bugprone-branch-clone Summary: Implement a check for detecting if/else if/else chains where two or more branches are Type I clones of each

[PATCH] D55280: [CTU] Remove redundant error check

martong added a comment. @Szelethus @balazske Thanks for your review! The meantime I have discussed with @xazax.hun that actually the called `ASTUnit::LoadFromASTFile` function inside `loadExternalAST` may return with a nullptr. So, the best is to handle that inside `loadExternalAST`.

[PATCH] D54592: [analyzer][CStringChecker] evaluate explicit_bzero

devnexen marked an inline comment as done. devnexen added inline comments. Comment at: test/Analysis/string.c:1399 + bzero(str, 2); + clang_analyzer_eval(strlen(str) == 0); // expected-warning{{UNKNOWN}} +} NoQ wrote: > I suspect that the reason why this

[PATCH] D54592: [analyzer][CStringChecker] evaluate explicit_bzero

devnexen updated this revision to Diff 176780. devnexen added a comment. - Using same type for zero as memset. - Updating slighty the unit tests with ptr/dynamic array for bzero. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54592/new/ https://reviews.llvm.org/D54592 Files:

[PATCH] D55275: [clangd] Dont provide locations for non-existent files.

hokein added inline comments. Comment at: unittests/clangd/SymbolCollectorTests.cpp:1036 + runSymbolCollector(Header, /*Main=*/"", {"-Dfoo=bar"}); + EXPECT_THAT(Symbols, UnorderedElementsAre(QName("bar"))); +} We handled this case previously, but the code was

[PATCH] D55270: [Sema] Further improvements to to static_assert diagnostics.

courbet updated this revision to Diff 176771. courbet marked 2 inline comments as done. courbet added a comment. - Address comments - Add more tests - Remove AllowTopLevel and handle cases like `sizeof(T)` (-> `sizeof(int)`) Repository: rC Clang CHANGES SINCE LAST ACTION

[PATCH] D55270: [Sema] Further improvements to to static_assert diagnostics.

courbet marked 7 inline comments as done. courbet added inline comments. Comment at: lib/Sema/SemaTemplate.cpp:3065 + + ~FailedBooleanConditionPrinterHelper() override {} + Quuxplusone wrote: > aaron.ballman wrote: > > Is this definition necessary? > Nit: I

[PATCH] D54757: [clang-tidy] new check: bugprone-branch-clone

JonasToth added a comment. I had to revert this patch because it broke (at least one) buildbot with an assertion-failure (http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast/builds/40436/steps/test/logs/stdio) Could you please take a look at it? I could not reproduce

[PATCH] D55255: Fix a false positive in misplaced-widening-cast

JonasToth added a comment. Committed, Thank you for the patch! Was there a bug-report for this issue? If yes can you please close it/reference? Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55255/new/ https://reviews.llvm.org/D55255

[PATCH] D55255: Fix a false positive in misplaced-widening-cast

This revision was automatically updated to reflect the committed changes. Closed by commit rL348341: Fix a false positive in misplaced-widening-cast (authored by JonasToth, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D55280: [CTU] Remove redundant error check

xazax.hun accepted this revision. xazax.hun added a comment. This revision is now accepted and ready to land. LG! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55280/new/ https://reviews.llvm.org/D55280 ___

[PATCH] D54592: [analyzer][CStringChecker] evaluate explicit_bzero

devnexen added a comment. In D54592#1319421 , @Szelethus wrote: > I hope you don't mind me changing the revision title -- many of us are > automatically subscribed to revisions with `analyzer` in the title, that also > helps with getting feedback sooner

[PATCH] D55250: [clangd] Enhance macro hover to see full definition

hokein added inline comments. Comment at: clangd/XRefs.cpp:567 /// Generate a \p Hover object given the macro \p MacroInf. +static Hover getHoverContents(MacroDecl Decl, ASTContext ) { The comment seems stale. Comment at:

[clang-tools-extra] r348341 - Fix a false positive in misplaced-widening-cast

Author: jonastoth Date: Wed Dec 5 00:29:56 2018 New Revision: 348341 URL: http://llvm.org/viewvc/llvm-project?rev=348341=rev Log: Fix a false positive in misplaced-widening-cast Summary: bugprone-misplaced-widening-cast check used to give a false warning to the following example. enum

[PATCH] D55275: [clangd] Dont provide locations for non-existent files.

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. thanks! Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55275/new/ https://reviews.llvm.org/D55275

[PATCH] D55312: [clangd] Fix a typo in TUSchedulerTests

hokein created this revision. hokein added a reviewer: ilya-biryukov. Herald added subscribers: kadircet, arphaman, jkorous, MaskRay, ioeric, javed.absar. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D55312 Files: unittests/clangd/TUSchedulerTests.cpp Index:

[PATCH] D55280: [CTU] Remove redundant error check

balazske added inline comments. Comment at: include/clang/CrossTU/CrossTranslationUnit.h:121 + /// \return Returns a pointer to the ASTUnit that contains the definition of + /// the looked up function. The pointer should not be a nullptr. /// Return value

Re: r347720 - [RISCV] Mark unit tests as "requires: riscv-registered-target"

On Thu, 29 Nov 2018 at 09:44, Alex Bradbury wrote: > > On Tue, 27 Nov 2018 at 22:56, Mandeep Singh Grang via cfe-commits > wrote: > > > > Author: mgrang > > Date: Tue Nov 27 14:53:57 2018 > > New Revision: 347720 > > > > URL: http://llvm.org/viewvc/llvm-project?rev=347720=rev > > Log: > >

[PATCH] D55270: [Sema] Further improvements to to static_assert diagnostics.

courbet updated this revision to Diff 176773. courbet added a comment. - Update PHC and C11 tests. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55270/new/ https://reviews.llvm.org/D55270 Files: include/clang/Sema/Sema.h lib/Sema/SemaDeclCXX.cpp

[PATCH] D55275: [clangd] Dont provide locations for non-existent files.

kadircet updated this revision to Diff 176774. kadircet marked an inline comment as done. kadircet added a comment. - Revert rL346488 partially. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55275/new/

[clang-tools-extra] r348344 - Revert "[clang-tidy] new check: bugprone-branch-clone"

Author: jonastoth Date: Wed Dec 5 01:34:18 2018 New Revision: 348344 URL: http://llvm.org/viewvc/llvm-project?rev=348344=rev Log: Revert "[clang-tidy] new check: bugprone-branch-clone" The patch broke on buildbot with assertion-failure. Revert until this is figured out. Removed:

[PATCH] D55280: [CTU] Remove redundant error check

martong updated this revision to Diff 176779. martong added a comment. - Return an error from loadExternalAST in case of nullptr Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55280/new/ https://reviews.llvm.org/D55280 Files:

[PATCH] D54872: [clangd] Add ability to not use -resource-dir at all

ilya-biryukov added a comment. In D54872#1319684 , @malaperle wrote: > It doesn't seem like there is any difference in how -resource-dir and /imsvc > are handled: they are all added as -internal-isystem Thanks for digging this code up. I'm a bit

r348352 - [clang] - Simplify tools::SplitDebugName.

Author: grimar Date: Wed Dec 5 03:09:10 2018 New Revision: 348352 URL: http://llvm.org/viewvc/llvm-project?rev=348352=rev Log: [clang] - Simplify tools::SplitDebugName. This is an updated version of the D54576, which was reverted. Problem was that SplitDebugName calls the

[clang-tools-extra] r348359 - [clangd] Dont provide locations for non-existent files.

Author: kadircet Date: Wed Dec 5 03:57:15 2018 New Revision: 348359 URL: http://llvm.org/viewvc/llvm-project?rev=348359=rev Log: [clangd] Dont provide locations for non-existent files. Summary: We were getting assertion errors when we had bad file names, instead we should skip those.

[PATCH] D55127: [OpenCL] Diagnose conflicting address spaces between template definition and its instantiation

Anastasia updated this revision to Diff 176793. Anastasia added a comment. Added last corrections before committing. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55127/new/ https://reviews.llvm.org/D55127 Files: include/clang/Basic/DiagnosticSemaKinds.td lib/Sema/SemaType.cpp

[PATCH] D55006: [clang] - Simplify tools::SplitDebugName

This revision was automatically updated to reflect the committed changes. Closed by commit rL348352: [clang] - Simplify tools::SplitDebugName. (authored by grimar, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[clang-tools-extra] r348357 - Fix compilation error when using clang 3.6.0

Author: uabelho Date: Wed Dec 5 03:29:27 2018 New Revision: 348357 URL: http://llvm.org/viewvc/llvm-project?rev=348357=rev Log: Fix compilation error when using clang 3.6.0 Modified: clang-tools-extra/trunk/unittests/clangd/BackgroundIndexTests.cpp Modified:

[PATCH] D55275: [clangd] Dont provide locations for non-existent files.

This revision was automatically updated to reflect the committed changes. Closed by commit rL348359: [clangd] Dont provide locations for non-existent files. (authored by kadircet, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINCE LAST ACTION

[PATCH] D55315: [clangd] Only reduce priority of a thread for indexing.

kadircet created this revision. kadircet added a reviewer: ilya-biryukov. Herald added subscribers: cfe-commits, jfb, arphaman, jkorous, MaskRay, ioeric. We'll soon have tasks pending for reading shards from disk, we want them to have normal priority. Because: - They are not CPU intensive,

[PATCH] D55312: [clangd] Fix a typo in TUSchedulerTests

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55312/new/ https://reviews.llvm.org/D55312

[PATCH] D54862: [OpenCL] Add generic AS to 'this' pointer

mikael marked an inline comment as done and an inline comment as not done. mikael added a comment. Thanks for the feedback, I'll work on fixing the issues! Comment at: lib/Sema/SemaOverload.cpp:1146 +unsigned OldQuals = OldMethod->getTypeQualifiers().getCVRUQualifiers(); +

r348356 - [test] Disable Modules/prune.m on NetBSD as it requires 'touch -a'

Author: mgorny Date: Wed Dec 5 03:17:50 2018 New Revision: 348356 URL: http://llvm.org/viewvc/llvm-project?rev=348356=rev Log: [test] Disable Modules/prune.m on NetBSD as it requires 'touch -a' Modified: cfe/trunk/test/Modules/prune.m Modified: cfe/trunk/test/Modules/prune.m URL:

Re: [cfe-dev] r347339 - [clang][Parse] Diagnose useless null statements / empty init-statements

On Wed, Dec 5, 2018 at 1:40 AM Roman Lebedev wrote: > > On Wed, Dec 5, 2018 at 4:07 AM Artem Dergachev via cfe-commits > wrote: > > > > > > > > On 12/4/18 5:04 PM, George Karpenkov via cfe-dev wrote: > > > > > >> On Dec 4, 2018, at 4:47 PM, Aaron Ballman wrote: > > >> > > >> On Tue, Dec 4, 2018

[PATCH] D54395: [clang-tidy] implement utility-function to add 'const' to variables

JonasToth marked 2 inline comments as done. JonasToth added inline comments. Comment at: clang-tidy/utils/FixItHintUtils.cpp:35 +static bool isValueType(QualType QT) { return isValueType(QT.getTypePtr()); } +static bool isArrayType(QualType QT) { return isa(QT.getTypePtr()); }

r348364 - Revert: Honor -fdebug-prefix-map when creating function names for the debug info.

Author: rengolin Date: Wed Dec 5 05:56:26 2018 New Revision: 348364 URL: http://llvm.org/viewvc/llvm-project?rev=348364=rev Log: Revert: Honor -fdebug-prefix-map when creating function names for the debug info. This commit reverts r348060 and r348062 due to it breaking the AArch64 Full

[PATCH] D55321: Do not check for parameters shadowing fields in function declarations

aaron.ballman created this revision. aaron.ballman added reviewers: rsmith, george.karpenkov. Herald added subscribers: kristof.beyls, javed.absar. This patch changes the way we handle `-Wshadow-field` so that we do not issue diagnostics for parameters in function declarations (as those are

Re: r346041 - Diagnose parameter names that shadow the names of inherited fields under -Wshadow-field.

On Tue, Dec 4, 2018 at 7:56 PM George Karpenkov wrote: > > > > > On Dec 4, 2018, at 4:48 PM, Aaron Ballman wrote: > > > > On Tue, Dec 4, 2018 at 7:17 PM George Karpenkov > > wrote: > >> > >> Hi Aaron, > >> > >> Should such changes be reviewed? > > > > This was reviewed in D52421. > > > >> In

r348368 - [Haiku] Support __float128 for x86 and x86_64

Author: kristina Date: Wed Dec 5 07:05:06 2018 New Revision: 348368 URL: http://llvm.org/viewvc/llvm-project?rev=348368=rev Log: [Haiku] Support __float128 for x86 and x86_64 This patch addresses a compilation error with clang when running in Haiku being unable to compile code using float128

[PATCH] D54901: [Haiku] Support __float128 for Haiku x86 and x86_64

This revision was automatically updated to reflect the committed changes. Closed by commit rL348368: [Haiku] Support __float128 for x86 and x86_64 (authored by kristina, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D55326: [Driver] Fix incorrect GNU triplet for PowerPC on SUSE Linux

glaubitz created this revision. glaubitz added reviewers: jrtc27, kristina. Herald added subscribers: cfe-commits, jsji, nemanjai. On SUSE distributions for 32-bit PowerPC, gcc is configured as a 64-bit compiler using the GNU triplet "powerpc64-suse-linux", but invoked with "-m32" by default.

[PATCH] D53738: [Fixed Point Arithmetic] Fixed Point Addition

ebevhan added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:1304 +RHSTy = ResultTy; + } + rjmccall wrote: > leonardchan wrote: > > rjmccall wrote: > > > leonardchan wrote: > > > > rjmccall wrote: > > > > > leonardchan wrote: > > > > > > rjmccall

[PATCH] D55321: Do not check for parameters shadowing fields in function declarations

aaron.ballman updated this revision to Diff 176807. aaron.ballman added a comment. Added a test with an out-of-line definition. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55321/new/ https://reviews.llvm.org/D55321 Files: lib/Sema/SemaChecking.cpp lib/Sema/SemaDecl.cpp

[PATCH] D54630: Move detection of libc++ include dirs to Driver on MacOS

ilya-biryukov added a comment. D55322 is a review for release notes Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54630/new/ https://reviews.llvm.org/D54630 ___ cfe-commits mailing

[PATCH] D55260: [CodeComplete] Fix a crash in access checks of inner classes

ilya-biryukov updated this revision to Diff 176820. ilya-biryukov added a comment. - Make sure we still run ObjC access checks. - Add a test with a different NamingClass and BaseType. - Fix IsSimplyAccessible to work in this case. Repository: rC Clang CHANGES SINCE LAST ACTION

[PATCH] D53866: [Preamble] Fix preamble for circular #includes

nik updated this revision to Diff 176826. nik added a comment. Addressed comments. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53866/new/ https://reviews.llvm.org/D53866 Files: include/clang/Lex/Preprocessor.h include/clang/Serialization/ASTWriter.h

[PATCH] D55250: [clangd] Enhance macro hover to see full definition

simark added inline comments. Comment at: clangd/XRefs.cpp:572 + + // Try to get the full definition, not just the name + SourceLocation StartLoc = Decl.Info->getDefinitionLoc(); hokein wrote: > if this is a complicated macro (like `AST_MATCHER`), do we still

[PATCH] D55321: Do not check for parameters shadowing fields in function declarations

aaron.ballman marked 2 inline comments as done. aaron.ballman added inline comments. Comment at: test/SemaCXX/warn-shadow.cpp:236 } + void F(int B); // Ok, declaration; not definition. }; lebedev.ri wrote: > Can you please also add one function with

[PATCH] D54901: [Haiku] Support __float128 for Haiku x86 and x86_64

kallisti5 added a comment. Looks good to me. Could you commit for me? (no access) Thanks! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54901/new/ https://reviews.llvm.org/D54901 ___ cfe-commits mailing list

[PATCH] D54630: Move detection of libc++ include dirs to Driver on MacOS

This revision was automatically updated to reflect the committed changes. Closed by commit rC348365: Move detection of libc++ include dirs to Driver on MacOS (authored by ibiryukov, committed by ). Changed prior to commit: https://reviews.llvm.org/D54630?vs=174358=176805#toc Repository: rC

[PATCH] D55260: [CodeComplete] Fix a crash in access checks of inner classes

ilya-biryukov updated this revision to Diff 176821. ilya-biryukov added a comment. - Reformat Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55260/new/ https://reviews.llvm.org/D55260 Files: lib/Sema/SemaAccess.cpp lib/Sema/SemaCodeComplete.cpp

[PATCH] D55260: [CodeComplete] Fix a crash in access checks of inner classes

ilya-biryukov marked an inline comment as done. ilya-biryukov added a comment. In D55260#1318280 , @kadircet wrote: > I believe also we need another test case where `Cls` and `NamingClass` are > different. Done. And thanks for finding this, I totally

[PATCH] D55260: [CodeComplete] Fix a crash in access checks of inner classes

ilya-biryukov updated this revision to Diff 176823. ilya-biryukov added a comment. - Add a newline to the end of the test file Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55260/new/ https://reviews.llvm.org/D55260 Files: lib/Sema/SemaAccess.cpp

[PATCH] D55315: [clangd] Only reduce priority of a thread for indexing.

ilya-biryukov added inline comments. Comment at: clangd/Threading.h:125 +// Sets scheduling priority for the calling thread. +void setThreadPriority(ThreadPriority Priority); // Avoid the use of scheduler policies that may starve low-priority threads. Maybe

[PATCH] D54862: [OpenCL] Add generic AS to 'this' pointer

Anastasia added inline comments. Comment at: lib/AST/ItaniumMangle.cpp:1507 +Qualifiers MethodQuals = Qualifiers::fromCVRUMask( +Method->getTypeQualifiers().getCVRUQualifiers()); // We do not consider restrict a distinguishing attribute for overloading

r348365 - Move detection of libc++ include dirs to Driver on MacOS

Author: ibiryukov Date: Wed Dec 5 06:24:14 2018 New Revision: 348365 URL: http://llvm.org/viewvc/llvm-project?rev=348365=rev Log: Move detection of libc++ include dirs to Driver on MacOS Summary: The intention is to make the tools replaying compilations from 'compile_commands.json'

[clang-tools-extra] r348365 - Move detection of libc++ include dirs to Driver on MacOS

Author: ibiryukov Date: Wed Dec 5 06:24:14 2018 New Revision: 348365 URL: http://llvm.org/viewvc/llvm-project?rev=348365=rev Log: Move detection of libc++ include dirs to Driver on MacOS Summary: The intention is to make the tools replaying compilations from 'compile_commands.json'

[PATCH] D55321: Do not check for parameters shadowing fields in function declarations

lebedev.ri added inline comments. Comment at: test/SemaCXX/warn-shadow.cpp:236 } + void F(int B); // Ok, declaration; not definition. }; Can you please also add one function with out-of-line definition? CHANGES SINCE LAST ACTION

[PATCH] D55322: Mention changes to libc++ include dir lookup in release notes.

ilya-biryukov created this revision. ilya-biryukov added a reviewer: arphaman. Herald added a reviewer: EricWF. The change itself landed as r348365, see the comment for more details. Repository: rC Clang https://reviews.llvm.org/D55322 Files: docs/ReleaseNotes.rst Index:

[PATCH] D53866: [Preamble] Fix preamble for circular #includes

nik marked 2 inline comments as done. nik added inline comments. Comment at: include/clang/Lex/Preprocessor.h:391 } PreambleConditionalStack; + bool PreambleGenerationFailed = false; ilya-biryukov wrote: > There's a mechanism to handle preamble with

[PATCH] D55326: [Driver] Fix incorrect GNU triplet for PowerPC on SUSE Linux

jrtc27 requested changes to this revision. jrtc27 added a comment. This revision now requires changes to proceed. Yes, this is a stupid situation to be in, but 32-bit PowerPC on SUSE really does use `/usr/lib/gcc/powerpc64-suse-linux`:

[PATCH] D55262: [OpenCL] Fix for TBAA information of pointer after addresspacecast

rjmccall added a comment. The code was dropping all the original l-value information, which includes alignment. So if you start with an l-value that refers to under-aligned memory (or over-aligned), we were losing that information on the resulting l-value. The test case would be something

[PATCH] D55326: [Driver] Fix incorrect GNU triplet for PowerPC on SUSE Linux

glaubitz added a comment. Well, I agree on the comment to clarify why it has to be powerpc64-suse-linux, but I'm not sure whether anyone will ever start a SUSE derivative for 32-bit PowerPC, then fix the path in SUSE's gcc and then do a mass-rebuild. I think the probability is pretty low.

[PATCH] D54862: [OpenCL] Add generic AS to 'this' pointer

Anastasia added inline comments. Comment at: lib/Sema/SemaOverload.cpp:1146 +unsigned OldQuals = OldMethod->getTypeQualifiers().getCVRUQualifiers(); +unsigned NewQuals = NewMethod->getTypeQualifiers().getCVRUQualifiers(); if (!getLangOpts().CPlusPlus14 &&

[PATCH] D55326: [Driver] Fix incorrect GNU triplet for PowerPC on SUSE Linux

glaubitz updated this revision to Diff 176830. glaubitz added a comment. Added a comment explaining the unusual triplet name. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55326/new/ https://reviews.llvm.org/D55326 Files: lib/Driver/ToolChains/Gnu.cpp

[PATCH] D55321: Do not check for parameters shadowing fields in function declarations

aaron.ballman marked 2 inline comments as done. aaron.ballman added inline comments. Comment at: test/SemaCXX/warn-shadow.cpp:236 } + void F(int B); // Ok, declaration; not definition. }; steveire wrote: > aaron.ballman wrote: > > lebedev.ri wrote: > > >

[PATCH] D55260: [CodeComplete] Fix a crash in access checks of inner classes

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55260/new/ https://reviews.llvm.org/D55260 ___

[PATCH] D54862: [OpenCL] Add generic AS to 'this' pointer

rjmccall added inline comments. Comment at: lib/AST/ItaniumMangle.cpp:1507 +Qualifiers MethodQuals = Qualifiers::fromCVRUMask( +Method->getTypeQualifiers().getCVRUQualifiers()); // We do not consider restrict a distinguishing attribute for overloading

[PATCH] D55315: [clangd] Only reduce priority of a thread for indexing.

kadircet updated this revision to Diff 176834. kadircet marked 2 inline comments as done. kadircet added a comment. - Move priority change logic into enqueueTask Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55315/new/

r348379 - [NFC] Use clang-format on PrintingPolicy::PrintingPolicy() after fd5c386f743

Author: jkorous Date: Wed Dec 5 08:19:49 2018 New Revision: 348379 URL: http://llvm.org/viewvc/llvm-project?rev=348379=rev Log: [NFC] Use clang-format on PrintingPolicy::PrintingPolicy() after fd5c386f743 The white-space change was causing conflicts downstream. rdar://problem/46486841

[PATCH] D55331: [CodeComplete] Fix assertion failure

ilya-biryukov created this revision. ilya-biryukov added a reviewer: kadircet. ...that fires when running completion inside an argument of UnresolvedMemberExpr (see the added test). The assertion that fires is from Sema::TryObjectArgumentInitialization: assert(FromClassification.isLValue());

[PATCH] D54862: [OpenCL] Add generic AS to 'this' pointer

mikael updated this revision to Diff 176831. mikael added a comment. I uploaded a new patch for most of the comments. I did leave some things out since they need clarification. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54862/new/ https://reviews.llvm.org/D54862 Files:

[PATCH] D54862: [OpenCL] Add generic AS to 'this' pointer

mikael marked an inline comment as done. mikael added inline comments. Comment at: lib/AST/ItaniumMangle.cpp:1507 +Qualifiers MethodQuals = Qualifiers::fromCVRUMask( +Method->getTypeQualifiers().getCVRUQualifiers()); // We do not consider restrict a

[PATCH] D54862: [OpenCL] Add generic AS to 'this' pointer

akyrtzi added inline comments. Comment at: lib/Index/USRGeneration.cpp:274 +if (unsigned quals = MD->getTypeQualifiers().getCVRUQualifiers()) Out << (char)('0' + quals); switch (MD->getRefQualifier()) { rjmccall wrote: > Paging @akyrtzi here.

[PATCH] D55280: [CTU] Make loadExternalAST return with non nullptr on success

martong marked an inline comment as done. martong added inline comments. Comment at: lib/CrossTU/CrossTranslationUnit.cpp:147 llvm::Expected CrossTranslationUnitContext::getCrossTUDefinition(const FunctionDecl *FD, balazske wrote: > Szelethus wrote: > >

[PATCH] D55226: [Fix][StaticAnalyzer] Bug 39792 - False positive on strcpy targeting struct member

Pierre-vh marked an inline comment as done. Pierre-vh added a comment. Hi again! As I'm quite new to this, I don't know what the next step is. Do we need to wait for more people to review this diff? What happens when it's considered "ready"? How is it committed? (I don't have commit access)

[PATCH] D55321: Do not check for parameters shadowing fields in function declarations

steveire added inline comments. Comment at: test/SemaCXX/warn-shadow.cpp:236 } + void F(int B); // Ok, declaration; not definition. }; aaron.ballman wrote: > lebedev.ri wrote: > > Can you please also add one function with out-of-line definition? > Gladly!

[PATCH] D55269: [CUDA][OpenMP] Fix nvidia-cuda-toolkit detection on Debian/Ubuntu

Hahnfeld added a comment. I think there are some misunderstandings here, or at least I understand things differently than @tra is describing them: AFAICS this change is NOT about replacing `nvcc` by `clang` in any CMake project (be that the OpenMP runtime or any other project outside of LLVM).

[PATCH] D53738: [Fixed Point Arithmetic] Fixed Point Addition

rjmccall added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:1304 +RHSTy = ResultTy; + } + ebevhan wrote: > rjmccall wrote: > > leonardchan wrote: > > > rjmccall wrote: > > > > leonardchan wrote: > > > > > rjmccall wrote: > > > > > > leonardchan

[PATCH] D53738: [Fixed Point Arithmetic] Fixed Point Addition

ebevhan added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:1304 +RHSTy = ResultTy; + } + rjmccall wrote: > ebevhan wrote: > > rjmccall wrote: > > > leonardchan wrote: > > > > rjmccall wrote: > > > > > leonardchan wrote: > > > > > > rjmccall

[PATCH] D55131: [CTU] Add more lit tests and better error handling

martong marked an inline comment as done. martong added inline comments. Comment at: lib/CrossTU/CrossTranslationUnit.cpp:247 llvm::Expected CrossTranslationUnitContext::importDefinition(const FunctionDecl *FD) { ASTImporter = getOrCreateASTImporter(FD->getASTContext());

r348382 - [OpenCL] Diagnose conflicting address spaces in templates.

Author: stulova Date: Wed Dec 5 09:02:22 2018 New Revision: 348382 URL: http://llvm.org/viewvc/llvm-project?rev=348382=rev Log: [OpenCL] Diagnose conflicting address spaces in templates. Added new diagnostic when templates are instantiated with different address space from the one provided in

[PATCH] D55127: [OpenCL] Diagnose conflicting address spaces between template definition and its instantiation

This revision was automatically updated to reflect the committed changes. Closed by commit rC348382: [OpenCL] Diagnose conflicting address spaces in templates. (authored by stulova, committed by ). Changed prior to commit: https://reviews.llvm.org/D55127?vs=176793=176841#toc Repository: rC

[PATCH] D55245: [clang-tidy] Add the abseil-duration-subtraction check

hwright added a comment. Ping. I assume I've got the right reviewers here, but I've also been sending a bunch of stuff your way lately, so if I'm overwhelming review capacity, please let me know. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55245/new/

Re: r348408 - Add dump tests for inherited default template parameters

On Wed, Dec 5, 2018 at 3:24 PM Stephen Kelly via cfe-commits wrote: > > Author: steveire > Date: Wed Dec 5 12:21:13 2018 > New Revision: 348408 > > URL: http://llvm.org/viewvc/llvm-project?rev=348408=rev > Log: > Add dump tests for inherited default template parameters > > Modified: >

Re: r348408 - Add dump tests for inherited default template parameters

On Wed, Dec 5, 2018 at 4:01 PM Stephen Kelly wrote: > > Surely all of the tests specifically about template decls should be moved? If you want to move all of them, feel free. ~Aaron > > On 05/12/2018 20:31, Aaron Ballman wrote: > > On Wed, Dec 5, 2018 at 3:24 PM Stephen Kelly via cfe-commits >

[PATCH] D55133: [CTU] Add statistics

a_sidorin accepted this revision. a_sidorin added a comment. LGTM with a nit. Comment at: lib/CrossTU/CrossTranslationUnit.cpp:171 loadExternalAST(LookupFnName, CrossTUDir, IndexName); - if (!ASTUnitOrError) + if (!ASTUnitOrError) { return

[PATCH] D54014: [Sema] Push and Pop Expression Evaluation Context Records at the start and end of function definitions

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. Thanks! Comment at: clang/lib/Sema/SemaDecl.cpp:13181-13182 +if (!IFace) { + if (!IsLambda) +PopExpressionEvaluationContext(); return

r348431 - Fix title underlines being too short after r348429

Author: pete Date: Wed Dec 5 16:01:44 2018 New Revision: 348431 URL: http://llvm.org/viewvc/llvm-project?rev=348431=rev Log: Fix title underlines being too short after r348429 Modified: cfe/trunk/docs/AutomaticReferenceCounting.rst Modified: cfe/trunk/docs/AutomaticReferenceCounting.rst

[PATCH] D55337: NFC: Move dumpDeclRef to NodeDumper

steveire created this revision. steveire added a reviewer: aaron.ballman. Herald added a subscriber: cfe-commits. Repository: rC Clang https://reviews.llvm.org/D55337 Files: include/clang/AST/TextNodeDumper.h lib/AST/ASTDumper.cpp lib/AST/TextNodeDumper.cpp Index:

[PATCH] D55338: NFC: Move VisitStmt code to dumpStmt

steveire created this revision. steveire added a reviewer: aaron.ballman. Herald added a subscriber: cfe-commits. This call is duplicated in Visits of all direct subclasses of Stmt. Repository: rC Clang https://reviews.llvm.org/D55338 Files: lib/AST/ASTDumper.cpp Index:

[PATCH] D55245: [clang-tidy] Add the abseil-duration-subtraction check

JonasToth added a comment. In D55245#1320546 , @hwright wrote: > Ping. > > I assume I've got the right reviewers here, but I've also been sending a > bunch of stuff your way lately, so if I'm overwhelming review capacity, > please let me know. Hi

[PATCH] D55262: [OpenCL] Fix for TBAA information of pointer after addresspacecast

rjmccall added a comment. Oh, sorry, that wasn't a good example because that's still the natural alignment for `A`. It should be `static_cast<__generic int &>(GPtr->X)`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55262/new/ https://reviews.llvm.org/D55262

r348415 - [Hexagon] Add support for Hexagon V66

Author: kparzysz Date: Wed Dec 5 13:38:35 2018 New Revision: 348415 URL: http://llvm.org/viewvc/llvm-project?rev=348415=rev Log: [Hexagon] Add support for Hexagon V66 Modified: cfe/trunk/include/clang/Driver/Options.td cfe/trunk/lib/Basic/Targets/Hexagon.cpp

r348434 - [Sema] Push and Pop Expression Evaluation Context Records at the start and end of function definitions

Author: leonardchan Date: Wed Dec 5 16:10:36 2018 New Revision: 348434 URL: http://llvm.org/viewvc/llvm-project?rev=348434=rev Log: [Sema] Push and Pop Expression Evaluation Context Records at the start and end of function definitions This patch creates a new context for every function

[PATCH] D54014: [Sema] Push and Pop Expression Evaluation Context Records at the start and end of function definitions

This revision was automatically updated to reflect the committed changes. Closed by commit rC348434: [Sema] Push and Pop Expression Evaluation Context Records at the start and end… (authored by leonardchan, committed by ). Changed prior to commit:

[PATCH] D55346: [clang-tidy] check for using declaration scope and qualification

Naysh created this revision. Naysh added reviewers: EricWF, JonasToth. Herald added subscribers: cfe-commits, xazax.hun, mgorny. This patch adds four new, small checks corresponding to the guidelines in https://abseil.io/tips/119. The checks are: - Alias Free Headers: makes sure header files

  1   2   >