[PATCH] D55862: [Sema] Don't try to account for the size of an incomplete type in CheckArrayAccess

riccibruno updated this revision to Diff 179035. riccibruno added a comment. Used `ArrayTy->getElementType()` Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55862/new/ https://reviews.llvm.org/D55862 Files: lib/Sema/SemaChecking.cpp

r349755 - [Sema][NFC] Add test for static_assert diagnistics with constexpr template functions.

Author: courbet Date: Thu Dec 20 05:30:40 2018 New Revision: 349755 URL: http://llvm.org/viewvc/llvm-project?rev=349755=rev Log: [Sema][NFC] Add test for static_assert diagnistics with constexpr template functions. Modified: cfe/trunk/test/SemaCXX/static-assert-cxx17.cpp Modified:

[PATCH] D55363: [clangd] Expose FileStatus in LSP.

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55363/new/ https://reviews.llvm.org/D55363

[PATCH] D55932: [Sema] Simplfy static_assert diagnostic code.

courbet created this revision. courbet added reviewers: aaron.ballman, Quuxplusone. We can now remove the specific handling of NestedNameQualifiers as it's now handled by the type printer as of r349729. Repository: rC Clang https://reviews.llvm.org/D55932 Files:

[PATCH] D55628: Add support for "labels" on push/pop directives in #pragma clang attribute

aaron.ballman accepted this revision. aaron.ballman marked an inline comment as done. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Comment at: clang/lib/Parse/ParsePragma.cpp:3161 + if (!Tok.is(tok::period)) { +

Re: r311958 - Revert "Revert r311552: [Bash-autocompletion] Add support for static analyzer flags"

Have you had a chance to look at making this change? On Mon, Apr 9, 2018 at 9:08 AM Yuka Takahashi wrote: > Sounds good! > > 2018-04-09 15:03 GMT+02:00 Nico Weber : > >> Yes. >> >> On Mon, Apr 9, 2018 at 9:00 AM, Yuka Takahashi wrote: >> >>> Hi Nico, >>> >>> Thanks for your comment! >>> >>> I

[PATCH] D55916: [clang] Replace getOS() == llvm::Triple::*BSD with isOS*BSD() [NFCI]

mgorny added inline comments. Comment at: lib/Basic/Targets/ARM.cpp:285 default: - if (Triple.getOS() == llvm::Triple::NetBSD) + if (Triple.isOSNetBSD()) setABI("apcs-gnu"); krytarowski wrote: > Actually we could use IsNetBSD and

[PATCH] D42043: c-index: CXString: fix MSAN read-past-end bug

riccibruno added a comment. Is anyone working on this ? This is the only persistent msan failure when doing `check-clang` on my machine. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D42043/new/ https://reviews.llvm.org/D42043

[PATCH] D55710: add pragmas to control Software Pipelining optimisation

aaron.ballman added inline comments. Comment at: include/clang/Basic/AttrDocs.td:2673 + +Check `Software pipelining`, `Modulo scheduling` to get more details on optimisation. + "Check" -- check where? Perhaps "Search for" but I still don't think that's very

[PATCH] D55710: add pragmas to control Software Pipelining optimisation

alexey.lapshin marked an inline comment as done. alexey.lapshin added inline comments. Comment at: include/clang/Basic/AttrDocs.td:2673 + +Check `Software pipelining`, `Modulo scheduling` to get more details on optimisation. + aaron.ballman wrote: > "Check" --

[PATCH] D55363: [clangd] Expose FileStatus in LSP.

hokein updated this revision to Diff 179041. hokein marked 3 inline comments as done. hokein added a comment. address review comments. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55363/new/ https://reviews.llvm.org/D55363 Files:

[clang-tools-extra] r349750 - [clangd] Don't miss the expected type in merge.

Author: hokein Date: Thu Dec 20 05:05:46 2018 New Revision: 349750 URL: http://llvm.org/viewvc/llvm-project?rev=349750=rev Log: [clangd] Don't miss the expected type in merge. Reviewers: ilya-biryukov Subscribers: ioeric, MaskRay, jkorous, arphaman, kadircet, cfe-commits Differential Revision:

[PATCH] D55918: [clangd] Don't miss the expected type in merge.

This revision was automatically updated to reflect the committed changes. Closed by commit rL349750: [clangd] Dont miss the expected type in merge. (authored by hokein, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINCE LAST ACTION

[PATCH] D55930: [gn build] Add build files for clang/lib/{Frontend, Frontend/Rewrite, Serialization}

thakis created this revision. thakis added a reviewer: phosek. https://reviews.llvm.org/D55930 Files: llvm/utils/gn/secondary/BUILD.gn llvm/utils/gn/secondary/clang/include/clang/Serialization/BUILD.gn llvm/utils/gn/secondary/clang/lib/Frontend/BUILD.gn

[PATCH] D55928: [OpenMP] Add flag for preventing the extension to 64 bits for the collapse loop counter

gtbercea updated this revision to Diff 179076. gtbercea marked 4 inline comments as done. gtbercea edited the summary of this revision. gtbercea added a comment. - Address comments. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55928/new/

[PATCH] D55912: [gn build] Add build files for clang/lib/Lex and clang/lib/AST

This revision was automatically updated to reflect the committed changes. Closed by commit rL349756: [gn build] Add build files for clang/lib/Lex and clang/lib/AST (authored by nico, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D55916: [clang] Replace getOS() == llvm::Triple::*BSD with isOS*BSD() [NFCI]

uweigand added a comment. In D55916#1337427 , @uweigand wrote: > This causes test case failures due to no longer linking with -lrt on Linux. Never mind, already fixed :-) Thanks! Repository: rC Clang CHANGES SINCE LAST ACTION

r349743 - [X86][SSE] Auto upgrade PADDS/PSUBS intrinsics to SADD_SAT/SSUB_SAT generic intrinsics (clang)

Author: rksimon Date: Thu Dec 20 03:53:45 2018 New Revision: 349743 URL: http://llvm.org/viewvc/llvm-project?rev=349743=rev Log: [X86][SSE] Auto upgrade PADDS/PSUBS intrinsics to SADD_SAT/SSUB_SAT generic intrinsics (clang) This emits SADD_SAT/SSUB_SAT generic intrinsics for the SSE signed

[PATCH] D55890: [X86][SSE] Auto upgrade PADDS/PSUBS intrinsics to SADD_SAT/SSUB_SAT generic intrinsics (clang)

This revision was automatically updated to reflect the committed changes. Closed by commit rL349743: [X86][SSE] Auto upgrade PADDS/PSUBS intrinsics to SADD_SAT/SSUB_SAT generic… (authored by RKSimon, committed by ). Changed prior to commit: https://reviews.llvm.org/D55890?vs=178946=179036#toc

[PATCH] D55928: [OpenMP] Add flag for preventing the extension to 64 bits for the collapse loop counter

gtbercea created this revision. gtbercea added reviewers: ABataev, caomhin. Herald added subscribers: cfe-commits, guansong. Introduce a compiler flag for cases when the user knows that the collapsed loop counter can be safely represented using at most 32 bits. This will prevent the emission of

[PATCH] D55931: [gn build] Add build file for clang/lib/CodeGen and llvm/lib/ProfileData/Coverage

thakis created this revision. thakis added a reviewer: phosek. Herald added subscribers: jfb, hiraditya. https://reviews.llvm.org/D55931 Files: llvm/utils/gn/secondary/BUILD.gn llvm/utils/gn/secondary/clang/lib/CodeGen/BUILD.gn llvm/utils/gn/secondary/llvm/lib/ProfileData/Coverage/BUILD.gn

[PATCH] D55916: [clang] Replace getOS() == llvm::Triple::*BSD with isOS*BSD() [NFCI]

uweigand added a comment. This causes test case failures due to no longer linking with -lrt on Linux. Comment at: lib/Driver/ToolChains/CommonArgs.cpp:606 CmdArgs.push_back("-lpthread"); -if (TC.getTriple().getOS() != llvm::Triple::OpenBSD) +if

[PATCH] D55924: [gn build] Add build files for clang-format and lib/{Format, Rewrite, Tooling/Core, Tooling/Inclusions}

thakis created this revision. thakis added a reviewer: phosek. https://reviews.llvm.org/D55924 Files: llvm/utils/gn/secondary/BUILD.gn llvm/utils/gn/secondary/clang/lib/Format/BUILD.gn llvm/utils/gn/secondary/clang/lib/Rewrite/BUILD.gn

[PATCH] D55925: [gn build] Add build file for clang/lib/Parse

thakis created this revision. thakis added a reviewer: phosek. Nothing really interesting. One thing to consider is where the clang_tablegen() invocations that generate files that are private to a library should be. The CMake build puts them in clang/include/clang/Parse (in this case), but

[PATCH] D55928: [OpenMP] Add flag for preventing the extension to 64 bits for the collapse loop counter

ABataev added inline comments. Comment at: docs/OpenMPSupport.rst:119 +time. To prevent this conservative choice and use at most 32 bits, +compile your program with the `-fopenmp-max-32bit-collapse-width`. + -fopenmp-optimistic-collapse

[PATCH] D55928: [OpenMP] Add flag for preventing the extension to 64 bits for the collapse loop counter

gtbercea added inline comments. Comment at: include/clang/Basic/LangOptions.def:210 LANGOPT(OpenMPCUDABlocksPerSM , 32, 0, "Number of blocks per SM for CUDA devices.") +LANGOPT(OpenMPMax32BitCollapseWidth , 1, 0, "Use at most 32 bits to represent the collapsed loop nest

[PATCH] D55363: [clangd] Expose FileStatus in LSP.

hokein added a comment. In D55363#1336315 , @ilya-biryukov wrote: > Could we add a capability to the init request to check for this extension? We > don't want to send those notifications to clients that don't have the code to > handle them. yes, I

r349751 - [SystemZ] Fix wrong codegen caused by typos in vecintrin.h

Author: uweigand Date: Thu Dec 20 05:09:09 2018 New Revision: 349751 URL: http://llvm.org/viewvc/llvm-project?rev=349751=rev Log: [SystemZ] Fix wrong codegen caused by typos in vecintrin.h The following two bugs in SystemZ high-level vector intrinsics are fixes by this patch: - The float case

[PATCH] D55363: [clangd] Expose FileStatus in LSP.

hokein added inline comments. Comment at: clangd/index/Merge.cpp:137 S.ReturnType = O.ReturnType; + if (S.Type == "") +S.Type = O.Type; ilya-biryukov wrote: > Accidental change? oops, I rebased this branch on top of my another branch. Fixed.

[PATCH] D55363: [clangd] Expose FileStatus in LSP.

hokein updated this revision to Diff 179047. hokein added a comment. Rebase Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55363/new/ https://reviews.llvm.org/D55363 Files: clangd/ClangdLSPServer.cpp clangd/ClangdLSPServer.h

[PATCH] D55913: [gn build] Add build files for clang/lib/{Analysis, Edit, Sema}

This revision was automatically updated to reflect the committed changes. Closed by commit rL349757: [gn build] Add build files for clang/lib/{Analysis,Edit,Sema} (authored by nico, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D55710: add pragmas to control Software Pipelining optimisation

aaron.ballman added inline comments. Comment at: include/clang/Basic/AttrDocs.td:2673 + +Check `Software pipelining`, `Modulo scheduling` to get more details on optimisation. + alexey.lapshin wrote: > aaron.ballman wrote: > > "Check" -- check where? Perhaps

[PATCH] D55927: [gn build] Add build file for clang/lib/Driver

thakis created this revision. thakis added a reviewer: phosek. Herald added subscribers: fedor.sergeev, aheejin, dschuff. Mostly boring, except for the spurious dependency on StaticAnalyzer/Checkers -- see comments in the code. https://reviews.llvm.org/D55927 Files:

[PATCH] D55916: [clang] Replace getOS() == llvm::Triple::*BSD with isOS*BSD() [NFCI]

mgorny updated this revision to Diff 179031. mgorny marked 2 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55916/new/ https://reviews.llvm.org/D55916 Files: lib/Basic/Targets/AArch64.cpp lib/Basic/Targets/ARM.cpp lib/Basic/Targets/Mips.h

[PATCH] D55918: [clangd] Don't miss the expected type in merge.

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55918/new/ https://reviews.llvm.org/D55918

[PATCH] D55916: [clang] Replace getOS() == llvm::Triple::*BSD with isOS*BSD() [NFCI]

This revision was automatically updated to reflect the committed changes. Closed by commit rC349752: Replace getOS() == llvm::Triple::*BSD with isOS*BSD() [NFCI] (authored by mgorny, committed by ). Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55916/new/

r349752 - Replace getOS() == llvm::Triple::*BSD with isOS*BSD() [NFCI]

Author: mgorny Date: Thu Dec 20 05:09:30 2018 New Revision: 349752 URL: http://llvm.org/viewvc/llvm-project?rev=349752=rev Log: Replace getOS() == llvm::Triple::*BSD with isOS*BSD() [NFCI] Replace multiple comparisons of getOS() value with FreeBSD, NetBSD, OpenBSD and DragonFly with matching

[PATCH] D55363: [clangd] Expose FileStatus in LSP.

ilya-biryukov added inline comments. Comment at: clangd/Protocol.cpp:769 O.map("fallbackFlags", Opts.fallbackFlags); + O.map("fileStatus", Opts.FileStatus); return true; Ah, there's a non-zero chance of name clash here in case the protocol implements

[PATCH] D55363: [clangd] Expose FileStatus in LSP.

hokein updated this revision to Diff 179046. hokein marked 4 inline comments as done. hokein added a comment. Remove details. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55363/new/ https://reviews.llvm.org/D55363 Files:

r349754 - [Driver] Fix accidentally reversed condition in r349752

Author: mgorny Date: Thu Dec 20 05:27:37 2018 New Revision: 349754 URL: http://llvm.org/viewvc/llvm-project?rev=349754=rev Log: [Driver] Fix accidentally reversed condition in r349752 Modified: cfe/trunk/lib/Driver/ToolChains/CommonArgs.cpp Modified:

[clang-tools-extra] r349758 - [clang-tidy] Use translationUnitDecl() instead of a custom matcher.

Author: alexfh Date: Thu Dec 20 05:50:04 2018 New Revision: 349758 URL: http://llvm.org/viewvc/llvm-project?rev=349758=rev Log: [clang-tidy] Use translationUnitDecl() instead of a custom matcher. Modified: clang-tools-extra/trunk/clang-tidy/readability/SimplifyBooleanExprCheck.cpp

Re: r311958 - Revert "Revert r311552: [Bash-autocompletion] Add support for static analyzer flags"

Sorry I totally forgot. Taking a look now, I will add you to a reviewer when I have an alternative patch! Thanks for the reminder. On Thu, 20 Dec 2018 at 15:20, Nico Weber wrote: > > Have you had a chance to look at making this change? > > On Mon, Apr 9, 2018 at 9:08 AM Yuka Takahashi wrote: >>

[PATCH] D55927: [gn build] Add build file for clang/lib/Driver

thakis updated this revision to Diff 179067. thakis added a comment. sync CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55927/new/ https://reviews.llvm.org/D55927 Files: llvm/utils/gn/secondary/BUILD.gn llvm/utils/gn/secondary/clang/include/clang/Driver/BUILD.gn

[PATCH] D55928: [OpenMP] Add flag for preventing the extension to 64 bits for the collapse loop counter

kkwli0 added inline comments. Comment at: docs/OpenMPSupport.rst:119 +time. To prevent this conservative choice and use at most 32 bits, +compile your program with the `-fopenmp-max-32bit-collapse-width`. + ABataev wrote: > -fopenmp-optimistic-collapse How about

[PATCH] D55928: [OpenMP] Add flag for preventing the extension to 64 bits for the collapse loop counter

ABataev added inline comments. Comment at: lib/Driver/ToolChains/Clang.cpp:4429 Args.AddAllArgs(CmdArgs, options::OPT_fopenmp_cuda_blocks_per_sm_EQ); + Args.AddLastArg(CmdArgs, options::OPT_fopenmp_optimistic_collapse, +

[PATCH] D55933: [Sema] Do not print default template parameters.

courbet created this revision. courbet added reviewers: aaron.ballman, Quuxplusone. As a followup to D55270 . Repository: rC Clang https://reviews.llvm.org/D55933 Files: include/clang/AST/NestedNameSpecifier.h lib/AST/NestedNameSpecifier.cpp

[PATCH] D55928: [OpenMP] Add flag for preventing the extension to 64 bits for the collapse loop counter

gtbercea updated this revision to Diff 179078. gtbercea added a comment. - Address comments. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55928/new/ https://reviews.llvm.org/D55928 Files: docs/OpenMPSupport.rst include/clang/Basic/LangOptions.def

[PATCH] D55868: [Fixed Point Arithmetic] Fixed Point Addition Constant Expression Evaluation

ebevhan added inline comments. Comment at: clang/include/clang/Basic/FixedPoint.h:98 public: + APFixedPoint() = default; APFixedPoint(const llvm::APInt , const FixedPointSemantics ) rjmccall wrote: > This should be documented to describe what it does.

[PATCH] D55869: Convert some ObjC retain/release msgSends to runtime calls

rjmccall added reviewers: theraven, js. rjmccall added a comment. Okay. That's also presumably true for open-source runtimes that support ARC; tagging David Chisnall and Jonathan Schleifer to get their input. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55869/new/

[PATCH] D55869: Convert some ObjC retain/release msgSends to runtime calls

js added a comment. In D55869#1337707 , @dexonsmith wrote: > In D55869#1337692 , @rjmccall wrote: > > > Okay. That's also presumably true for open-source runtimes that support > > ARC; tagging David Chisnall and

[PATCH] D55869: Convert some ObjC retain/release msgSends to runtime calls

dexonsmith added a comment. In D55869#1337706 , @js wrote: > The ObjFW runtime itself does not contain anything about release, retain or > autorelease - these are all part of ObjFW (as in the framework). As ObjFW > also supports the Apple runtime, as

[PATCH] D55792: Allow direct navigation to static analysis checker documentation through SARIF exports

NoQ accepted this revision. NoQ added a comment. Looks great, no objections on my end! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55792/new/ https://reviews.llvm.org/D55792 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D55875: [analyzer] pr38668: RegionStore: Do not attempt to cast loaded values of non-scalar types.

NoQ reopened this revision. NoQ added a comment. This revision is now accepted and ready to land. Revert! Comment at: lib/StaticAnalyzer/Core/Store.cpp:410 + QualType OrigTy = R->getValueType(); + This is entirely incorrect. The whole point of this function

[PATCH] D55710: add pragmas to control Software Pipelining optimisation

alexey.lapshin marked an inline comment as done. alexey.lapshin added inline comments. Comment at: include/clang/Basic/AttrDocs.td:2677-2678 +`language extensions +`_ +for further details,

[PATCH] D55869: Convert some ObjC retain/release msgSends to runtime calls

dexonsmith added a comment. In D55869#1337692 , @rjmccall wrote: > Okay. That's also presumably true for open-source runtimes that support ARC; > tagging David Chisnall and Jonathan Schleifer to get their input.

r349796 - [X86] Auto upgrade XOP/AVX512 rotation intrinsics to generic funnel shift intrinsics (clang)

Author: rksimon Date: Thu Dec 20 11:01:13 2018 New Revision: 349796 URL: http://llvm.org/viewvc/llvm-project?rev=349796=rev Log: [X86] Auto upgrade XOP/AVX512 rotation intrinsics to generic funnel shift intrinsics (clang) This emits FSHL/FSHR generic intrinsics for the XOP VPROT and AVX512

[PATCH] D55937: [X86] Auto upgrade XOP/AVX512 rotation intrinsics to generic funnel shift intrinsics (clang)

This revision was automatically updated to reflect the committed changes. Closed by commit rC349796: [X86] Auto upgrade XOP/AVX512 rotation intrinsics to generic funnel shift… (authored by RKSimon, committed by ). Changed prior to commit: https://reviews.llvm.org/D55937?vs=179089=179105#toc

[clang-tools-extra] r349768 - [clangd] Expose FileStatus to LSP.

Author: hokein Date: Thu Dec 20 07:39:12 2018 New Revision: 349768 URL: http://llvm.org/viewvc/llvm-project?rev=349768=rev Log: [clangd] Expose FileStatus to LSP. Summary: Add an LSP extension "textDocument/clangd.fileStatus" to emit file-status information. Reviewers: ilya-biryukov

[PATCH] D55374: [clangd] Show FileStatus in vscode-clangd.

hokein updated this revision to Diff 179082. hokein added a comment. Update the patch to reflect LSP file status latest change. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55374/new/ https://reviews.llvm.org/D55374 Files:

[PATCH] D55374: [clangd] Show FileStatus in vscode-clangd.

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55374/new/ https://reviews.llvm.org/D55374

[clang-tools-extra] r349769 - [clangd] Try to workaround test failure by increasing the timeouts

Author: ibiryukov Date: Thu Dec 20 08:27:19 2018 New Revision: 349769 URL: http://llvm.org/viewvc/llvm-project?rev=349769=rev Log: [clangd] Try to workaround test failure by increasing the timeouts Ideally we'd figure out a way to run this test without any sleeps, this workaround is only there

[PATCH] D55869: Convert some ObjC retain/release msgSends to runtime calls

js added a comment. In D55869#1337711 , @dexonsmith wrote: > In D55869#1337706 , @js wrote: > > > The ObjFW runtime itself does not contain anything about release, retain or > > autorelease - these are all part of

[PATCH] D55937: [X86] Auto upgrade XOP/AVX512 rotation intrinsics to generic funnel shift intrinsics (clang)

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55937/new/ https://reviews.llvm.org/D55937 ___

[PATCH] D55928: [OpenMP] Add flag for preventing the extension to 64 bits for the collapse loop counter

gtbercea added inline comments. Comment at: docs/OpenMPSupport.rst:119 +time. To prevent this conservative choice and use at most 32 bits, +compile your program with the `-fopenmp-max-32bit-collapse-width`. + kkwli0 wrote: > ABataev wrote: > >

[PATCH] D55374: [clangd] Show FileStatus in vscode-clangd.

hokein added a comment. The patch is ready for review now. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55374/new/ https://reviews.llvm.org/D55374 ___ cfe-commits mailing list

[PATCH] D55933: [Sema] Do not print default template parameters.

Quuxplusone added inline comments. Comment at: lib/AST/TypePrinter.cpp:173 + // information about whether default template parameters were actually + // written. + switch (QT.getTypePtr()->getTypeClass()) { FWIW, I don't understand this comment's terminology.

[PATCH] D55792: Allow direct navigation to static analysis checker documentation through SARIF exports

aaron.ballman added a comment. In D55792#1334886 , @Szelethus wrote: > This is awesome. Please wait for either @NoQ or @george.karpenkov to have the > final say. > > Edit: Maybe couple days I guess. I've been digging through these files quite > a lot in

r349776 - Correct the diagnose_if attribute documentation. Fixes PR35845.

Author: aaronballman Date: Thu Dec 20 09:28:32 2018 New Revision: 349776 URL: http://llvm.org/viewvc/llvm-project?rev=349776=rev Log: Correct the diagnose_if attribute documentation. Fixes PR35845. Modified: cfe/trunk/include/clang/Basic/AttrDocs.td Modified:

r349798 - Revert "[analyzer] pr38668: Do not attempt to cast loaded values..."

Author: dergachev Date: Thu Dec 20 11:36:06 2018 New Revision: 349798 URL: http://llvm.org/viewvc/llvm-project?rev=349798=rev Log: Revert "[analyzer] pr38668: Do not attempt to cast loaded values..." This reverts commit r349701. The patch was incorrect. The whole point of CastRetrievedVal() is

[PATCH] D55363: [clangd] Expose FileStatus in LSP.

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE349768: [clangd] Expose FileStatus to LSP. (authored by hokein, committed by ). Changed prior to commit: https://reviews.llvm.org/D55363?vs=179047=179080#toc Repository: rCTE Clang Tools Extra

[PATCH] D55928: [OpenMP] Add flag for preventing the extension to 64 bits for the collapse loop counter

hfinkel added inline comments. Comment at: docs/OpenMPSupport.rst:120 +compile your program with the `-fopenmp-optimistic-collapse`. + + Can you please clarify here what happens when the loop induction variables are already 64 bits. If any of them are already

Re: r349752 - Replace getOS() == llvm::Triple::*BSD with isOS*BSD() [NFCI]

On Thu, Dec 20, 2018 at 01:09:30PM -, Michal Gorny via cfe-commits wrote: > Author: mgorny > Date: Thu Dec 20 05:09:30 2018 > New Revision: 349752 > > URL: http://llvm.org/viewvc/llvm-project?rev=349752=rev > Log: > Replace getOS() == llvm::Triple::*BSD with isOS*BSD() [NFCI] > > Replace

[PATCH] D55869: Convert some ObjC retain/release msgSends to runtime calls

pete added a comment. In D55869#1337723 , @js wrote: > In D55869#1337711 , @dexonsmith > wrote: > > > In D55869#1337706 , @js wrote: > > > > > The ObjFW runtime itself does

[PATCH] D55869: Convert some ObjC retain/release msgSends to runtime calls

rjmccall added a comment. In D55869#1337706 , @js wrote: > Thanks for tagging me! > > The ObjFW runtime itself does not contain anything about release, retain or > autorelease - these are all part of ObjFW (as in the framework). As ObjFW > also supports

[PATCH] D55869: Convert some ObjC retain/release msgSends to runtime calls

rjmccall added a comment. In D55869#1337733 , @pete wrote: > In D55869#1337723 , @js wrote: > > > In D55869#1337711 , @dexonsmith > > wrote: > > > > > In D55869#1337706

r349782 - Use @llvm.objc.clang.arc.use intrinsic instead of clang.arc.use function.

Author: pete Date: Thu Dec 20 10:05:41 2018 New Revision: 349782 URL: http://llvm.org/viewvc/llvm-project?rev=349782=rev Log: Use @llvm.objc.clang.arc.use intrinsic instead of clang.arc.use function. Calls to this function are deleted in the ARC optimizer. However when the ARC optimizer was

[PATCH] D55875: [analyzer] pr38668: RegionStore: Do not attempt to cast loaded values of non-scalar types.

NoQ marked an inline comment as done. NoQ added inline comments. Comment at: lib/StaticAnalyzer/Core/Store.cpp:410 + QualType OrigTy = R->getValueType(); + NoQ wrote: > NoQ wrote: > > This is entirely incorrect. The whole point of this function is to handle

[PATCH] D55792: Allow direct navigation to static analysis checker documentation through SARIF exports

george.karpenkov added a comment. This is amazing, huge thanks for doing this! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55792/new/ https://reviews.llvm.org/D55792 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D55862: [Sema] Don't try to account for the size of an incomplete type in CheckArrayAccess

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55862/new/ https://reviews.llvm.org/D55862 ___

[PATCH] D55928: [OpenMP] Add flag for preventing the extension to 64 bits for the collapse loop counter

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55928/new/ https://reviews.llvm.org/D55928 ___ cfe-commits

[PATCH] D55869: Convert some ObjC retain/release msgSends to runtime calls

js added a comment. Thanks for tagging me! The ObjFW runtime itself does not contain anything about release, retain or autorelease - these are all part of ObjFW (as in the framework). As ObjFW also supports the Apple runtime, as well as mixing with Foundation code, it so far only provides

[PATCH] D55937: [X86] Auto upgrade XOP/AVX512 rotation intrinsics to generic funnel shift intrinsics (clang)

RKSimon created this revision. RKSimon added reviewers: spatel, craig.topper. Herald added a subscriber: llvm-commits. This emits FSHL/FSHR generic intrinsics for the XOP VPROT and AVX512 VPROL/VPROR rotation intrinsics. Repository: rL LLVM https://reviews.llvm.org/D55937 Files:

[PATCH] D55875: [analyzer] pr38668: RegionStore: Do not attempt to cast loaded values of non-scalar types.

NoQ marked an inline comment as done. NoQ added inline comments. Comment at: lib/StaticAnalyzer/Core/Store.cpp:410 + QualType OrigTy = R->getValueType(); + NoQ wrote: > This is entirely incorrect. The whole point of this function is to handle the > case when

[PATCH] D51641: [VFS] Cache the current working directory for the real FS.

labath added subscribers: JDevlieghere, labath. labath added a comment. Might I ask what was the motivation for this change? Performance optimalization? I am asking this because this makes the RealFileSystem return bogus values for the CWD if it changes through means other than the

r349815 - Fix build failures from r349812 due to a missing argument.

Author: aaronballman Date: Thu Dec 20 12:32:59 2018 New Revision: 349815 URL: http://llvm.org/viewvc/llvm-project?rev=349815=rev Log: Fix build failures from r349812 due to a missing argument. Modified: cfe/trunk/unittests/StaticAnalyzer/RegisterCustomCheckersTest.cpp Modified:

[PATCH] D55869: Convert some ObjC retain/release msgSends to runtime calls

theraven added a comment. This should be fine for the GNUstep runtime (the GCC runtime doesn't support ARC at all). My main concern is that it will break already-released versions of the runtime built with a newer version of clang. I can easily enable a new flag in the next release, but

[PATCH] D55931: [gn build] Add build file for clang/lib/CodeGen and llvm/lib/ProfileData/Coverage

This revision was automatically updated to reflect the committed changes. Closed by commit rL349834: [gn build] Add build file for clang/lib/CodeGen and… (authored by nico, committed by ). Changed prior to commit: https://reviews.llvm.org/D55931?vs=179075=179153#toc Repository: rL LLVM

r349835 - [driver] [analyzer] Fix redundant test output.

Author: dergachev Date: Thu Dec 20 13:56:49 2018 New Revision: 349835 URL: http://llvm.org/viewvc/llvm-project?rev=349835=rev Log: [driver] [analyzer] Fix redundant test output. The -c flag causes a .o file to appear every time we run a test. Remove it. Differential Revision:

r349841 - [ObjC] Messages to 'self' in class methods that return 'instancetype' should

Author: arphaman Date: Thu Dec 20 14:11:11 2018 New Revision: 349841 URL: http://llvm.org/viewvc/llvm-project?rev=349841=rev Log: [ObjC] Messages to 'self' in class methods that return 'instancetype' should use the pointer to the class as the result type of the message Prior to this commit,

[PATCH] D36790: [ObjC] Messages to 'self' in class methods that return 'instancetype' should use the pointer to the class as the result type of the message

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rC349841: [ObjC] Messages to self in class methods that return instancetype should (authored by arphaman, committed by ).

[PATCH] D55907: [analyzer] RetainCount: Bluntly suppress the CFRetain detection heuristic on a couple of CM functions.

dcoughlin accepted this revision. dcoughlin added a comment. This revision is now accepted and ready to land. This seems reasonable to me, but please have George take a look too. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55907/new/ https://reviews.llvm.org/D55907

[PATCH] D36790: [ObjC] Messages to 'self' in class methods that return 'instancetype' should use the pointer to the class as the result type of the message

arphaman marked an inline comment as done. arphaman added a comment. Herald added subscribers: dexonsmith, jkorous. Fixed comment, will commit. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D36790/new/ https://reviews.llvm.org/D36790 ___

[PATCH] D55823: [analyzer] Fix backward compatibility issue after D53280 'Emit an error for invalid -analyzer-config inputs'

NoQ added a comment. In D55823#1338337 , @arphaman wrote: > I think `Args.getArgString` might return `nullptr` so that's why you could > crash. Nope, we crash on index lookup. It seems that `Args.size()` is larger than the small vector that we're

[PATCH] D47757: [Sema] Produce diagnostics when unavailable aligned allocation/deallocation functions are called

vsapsai accepted this revision. vsapsai added a comment. The change itself looks correct. Cannot really tell if you need to make changes in other places. For that I rely on Richard's opinion. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D47757/new/

[PATCH] D37035: Implement __builtin_LINE() et. al. to support source location capture.

EricWF updated this revision to Diff 179211. EricWF added a comment. Herald added a reviewer: shafik. Merge with upstream. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D37035/new/ https://reviews.llvm.org/D37035 Files: docs/LanguageExtensions.rst include/clang/AST/ASTContext.h

[PATCH] D55850: [OpenCL] Allow address spaces as method qualifiers

Anastasia marked an inline comment as done. Anastasia added inline comments. Comment at: lib/Parse/ParseDecl.cpp:6162 +} + } + rjmccall wrote: > Anastasia wrote: > > rjmccall wrote: > > > This is enforcing a restriction that users write `const

[PATCH] D55949: Correctly handle function pointers returning a type marked nodiscard

aaron.ballman created this revision. aaron.ballman added reviewers: rsmith, Quuxplusone, erik.pilkington. When a function returns a type and that type was declared `[[nodiscard]]`, we diagnose any unused results from that call as though the function were marked nodiscard. The same behavior

[PATCH] D55793: [clang-tidy] Add duplicated access specifier readability check (PR25403)

m4tx updated this revision to Diff 179138. m4tx marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55793/new/ https://reviews.llvm.org/D55793 Files: clang-tidy/readability/CMakeLists.txt clang-tidy/readability/DuplicatedAccessSpecifiersCheck.cpp

[PATCH] D55793: [clang-tidy] Add duplicated access specifier readability check (PR25403)

m4tx marked 4 inline comments as done. m4tx added a comment. In D55793#1335274 , @lebedev.ri wrote: > In D55793#1335249 , @m4tx wrote: > > > In D55793#1333661 , @lebedev.ri

r349825 - Declares __cpu_model as dso local

Author: hhb Date: Thu Dec 20 13:33:59 2018 New Revision: 349825 URL: http://llvm.org/viewvc/llvm-project?rev=349825=rev Log: Declares __cpu_model as dso local __builtin_cpu_supports and __builtin_cpu_is use information in __cpu_model to decide cpu features. Before this change, __cpu_model was

  1   2   >