[PATCH] D56349: [CMake][Fuchsia] Enable x86 relaxation by default

mcgrathr accepted this revision. mcgrathr added a comment. This revision is now accepted and ready to land. lgtm. Wouldn't hurt to comment that this depends on a linker new enough to support the new reloc types (only reason it's conditional at all) and since we default to lld we don't worry

Re: r350404 - Refactor the way we handle diagnosing unused expression results.

Nice, this is finding bugs: https://bugs.chromium.org/p/chromium/issues/detail?id=919262 However, I noticed that for that case, the same warning is printed twice: ../../third_party/crashpad/crashpad/util/win/process_info.cc(227,36): error: expression result unused [-Werror,-Wunused-value]

Re: r350340 - Validate -add-plugin arguments.

Thanks for the note. 350451 will hopefully help. On Fri, Jan 4, 2019 at 2:18 PM Galina Kistanova via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Hello Nico, > > This commit broke tests on llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast > builder: > >

[PATCH] D56343: [clang-tidy] Refactor: Compose Method on check_clang_tidy.py

LegalizeAdulthood created this revision. LegalizeAdulthood added a reviewer: alexfh. Herald added a subscriber: xazax.hun. Herald added a reviewer: serge-sans-paille. Break up the huge main() function Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D56343 Files:

r350451 - Move -add-plugin validation after -load was executed.

Author: nico Date: Fri Jan 4 17:10:20 2019 New Revision: 350451 URL: http://llvm.org/viewvc/llvm-project?rev=350451=rev Log: Move -add-plugin validation after -load was executed. Moves the code added in r350340 around a bit, to hopefully make the existing plugin tests pass when clang is built

[PATCH] D55662: [Sema][ObjC] Do not warn about repeated uses of weak variables when the variables are accessed in an unevaluated context.

ahatanak added a comment. In D55662#1346077 , @rjmccall wrote: > Hmm. Are we resolving the placeholder expression twice here? That might be > the basic problem. Yes, `CheckPlaceholderExpr` is called in `Sema::DeduceAutoType` to deduce the type of

[PATCH] D56343: [clang-tidy] Refactor: Compose Method on check_clang_tidy.py

LegalizeAdulthood updated this revision to Diff 180349. LegalizeAdulthood added a comment. Extract Function try_run CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56343/new/ https://reviews.llvm.org/D56343 Files: test/clang-tidy/check_clang_tidy.py Index:

Re: r350143 - Add vtable anchor to classes.

This was a cleanup before some other refactoring I wanted to do, but that refactoring has been put on hold for a bit, so I committed this change to improve the codebase a little and not have to redo it later. On Mon, Dec 31, 2018 at 4:50 PM David Blaikie wrote: > While I realize it's in the

[PATCH] D56348: [CMake][Fuchsia] Enable --build-id linker flag by default

phosek created this revision. phosek added a reviewer: mcgrathr. Herald added subscribers: cfe-commits, mgorny. This enables passing --build-id to linker by default. Repository: rC Clang https://reviews.llvm.org/D56348 Files: clang/cmake/caches/Fuchsia-stage2.cmake Index:

Re: r350404 - Refactor the way we handle diagnosing unused expression results.

On Fri, 4 Jan 2019 at 17:33, Nico Weber via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Nice, this is finding bugs: > https://bugs.chromium.org/p/chromium/issues/detail?id=919262 > > However, I noticed that for that case, the same warning is printed twice: > >

[PATCH] D56345: [clang-format] Assert that filenames are not empty

jr created this revision. jr added reviewers: krasimir, djasper. Herald added a subscriber: cfe-commits. Adds asserts to catch empty filenames, which otherwise will cause a crash in SourceManager. The clang-format tool now outputs an error if an empty filename is used. Fixes bug: 34667

r350453 - Let new test from r350340 still pass even after r350451.

Author: nico Date: Fri Jan 4 17:19:14 2019 New Revision: 350453 URL: http://llvm.org/viewvc/llvm-project?rev=350453=rev Log: Let new test from r350340 still pass even after r350451. Modified: cfe/trunk/lib/Frontend/FrontendAction.cpp Modified: cfe/trunk/lib/Frontend/FrontendAction.cpp URL:

[PATCH] D56341: [python] Make the collections import future-proof

jstasiak created this revision. jstasiak added reviewers: mgorny, michaelplatings, serge-sans-paille. Herald added subscribers: cfe-commits, arphaman. On Python 3.7 the old code raises a warning: DeprecationWarning: Using or importing the ABCs from 'collections' instead of from

[PATCH] D56348: [CMake][Fuchsia] Enable --build-id linker flag by default

mcgrathr accepted this revision. mcgrathr added a comment. This revision is now accepted and ready to land. lgtm Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56348/new/ https://reviews.llvm.org/D56348 ___

[PATCH] D56350: [CMake][Fuchsia] Enable experimental new pass manager by default

mcgrathr accepted this revision. mcgrathr added a comment. This revision is now accepted and ready to land. lgtm Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56350/new/ https://reviews.llvm.org/D56350 ___

[PATCH] D56350: [CMake][Fuchsia] Enable experimental new pass manager by default

phosek created this revision. phosek added a reviewer: mcgrathr. Herald added subscribers: cfe-commits, mgorny. This change enableds experimental new pass manager. Repository: rC Clang https://reviews.llvm.org/D56350 Files: clang/cmake/caches/Fuchsia-stage2.cmake Index:

[PATCH] D56349: [CMake][Fuchsia] Enable x86 relaxation by default

phosek created this revision. phosek added a reviewer: mcgrathr. Herald added subscribers: cfe-commits, mgorny. This enables x86 relaxation by default. Repository: rC Clang https://reviews.llvm.org/D56349 Files: clang/cmake/caches/Fuchsia-stage2.cmake Index:

[PATCH] D56318: [HIP] Fix size_t for MSVC environment

rjmccall added a comment. Okay. Is there a reasonable way to make your targets delegate to a different `TargetInfo` implementation for most things so that you can generally match the host target for things like type sizes and alignments? CHANGES SINCE LAST ACTION

[PATCH] D55433: [clang-tidy] Adding a new modernize use nodiscard checker

MyDeveloperDay updated this revision to Diff 180212. MyDeveloperDay marked 3 inline comments as done. MyDeveloperDay added a comment. Address review comments - remove using strings to locate std::function and boost::function arguments using matcher with ``hasAnyName()`` instead - add tests to

[PATCH] D55433: [clang-tidy] Adding a new modernize use nodiscard checker

MyDeveloperDay added inline comments. Comment at: clang-tidy/modernize/UseNodiscardCheck.cpp:30 +// TODO: Find a better way of detecting a function template. +static bool isFunctionTemplate(const QualType ) { + // Try to catch both std::function and boost::function

[PATCH] D56314: [clangd] Don't store completion info if the symbol is not used for code completion.

hokein created this revision. Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay, ioeric, ilya-biryukov. This would save us some memory and disk space: - Dex usage (269 MB vs 278 MB) - Disk (73 MB vs 76 MB) It would save more when we index the main file symbol.

r350386 - [Basic] Extend DiagnosticEngine to store and format Qualifiers.

Author: stulova Date: Fri Jan 4 03:50:36 2019 New Revision: 350386 URL: http://llvm.org/viewvc/llvm-project?rev=350386=rev Log: [Basic] Extend DiagnosticEngine to store and format Qualifiers. Qualifiers can now be streamed into the DiagnosticEngine using regular << operator. If Qualifiers are

[PATCH] D55948: Modify DeclaratorChuck::getFunction to use DeclSpec for qualifiers

Anastasia updated this revision to Diff 180226. Anastasia marked an inline comment as done. Anastasia added a comment. - Added `forEachQualifiers` to `DeclSpec`. - Removed dead code. - Moved lambdas definition inline into the function parameters. CHANGES SINCE LAST ACTION

[PATCH] D56241: expose a control flag for interger to pointer ext warning

Kader marked an inline comment as done. Kader added a comment. @lebedev.ri Thanks. I think do not have commit access. What should be my next step ? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56241/new/ https://reviews.llvm.org/D56241

[PATCH] D55933: [Sema] Do not print default template parameters.

courbet updated this revision to Diff 180220. courbet marked 2 inline comments as done. courbet added a comment. Handle {L,R}Value references. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55933/new/ https://reviews.llvm.org/D55933 Files:

[PATCH] D55933: [Sema] Do not print default template parameters.

courbet added inline comments. Comment at: lib/AST/TypePrinter.cpp:179 +// `X` gets canonicalized to `X`. We disable +// canonicalization so that `printTag()`` can see the template parameters as +// written. Quuxplusone wrote: > Nit: there's an

[PATCH] D56090: Add a matcher for members of an initializer list expression

klimek added inline comments. Comment at: include/clang/ASTMatchers/ASTMatchers.h:3527 + return N < Node.getNumInits() && + InnerMatcher.matches(*Node.getInit(N)->IgnoreParenImpCasts(), Finder, + Builder); aaron.ballman

[PATCH] D56198: [Basic] Extend DiagnosticEngine to store and format Qualifiers

This revision was automatically updated to reflect the committed changes. Closed by commit rC350386: [Basic] Extend DiagnosticEngine to store and format Qualifiers. (authored by stulova, committed by ). Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56198/new/

[PATCH] D55948: Modify DeclaratorChuck::getFunction to use DeclSpec for qualifiers

Anastasia added inline comments. Comment at: lib/Sema/SemaDeclCXX.cpp:8175 DeclaratorChunk::FunctionTypeInfo = D.getFunctionTypeInfo(); - if (FTI.TypeQuals != 0) { -if (FTI.TypeQuals & Qualifiers::Const) - Diag(D.getIdentifierLoc(),

[PATCH] D56298: [OpenMP] Refactor const restriction for reductions

ABataev added a comment. LG Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56298/new/ https://reviews.llvm.org/D56298 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D56299: [OpenMP] Refactor const restriction for linear

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56299/new/ https://reviews.llvm.org/D56299 ___ cfe-commits

Re: [PATCH] D56215: [lld] [ELF] Include default search paths for NetBSD driver

On Fri, Jan 04, 2019 at 05:52:46AM +, Michał Górny via Phabricator via llvm-commits wrote: > mgorny added a comment. > > For the record, another option is to actually fix other software not to call > LD directly. See thousand monkeys. It doesn't really scale. Joerg

r350398 - Prevent unreachable when checking invalid multiversion decls.

Author: erichkeane Date: Fri Jan 4 07:24:06 2019 New Revision: 350398 URL: http://llvm.org/viewvc/llvm-project?rev=350398=rev Log: Prevent unreachable when checking invalid multiversion decls. CPUSpecifc/CPUDispatch call resolution assumed that all declarations that would be passed are valid,

[PATCH] D56113: [OpenMP] Replace predetermined shared for const variable

jdenny marked an inline comment as done. jdenny added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:9736 +static bool rejectConstNotMutableType(Sema , ValueDecl *D, + OpenMPClauseKind CKind, ABataev wrote: >

[PATCH] D56113: [OpenMP] Replace predetermined shared for const variable

ABataev added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:9736 +static bool rejectConstNotMutableType(Sema , ValueDecl *D, + OpenMPClauseKind CKind, ABataev wrote: > This function and the original code has a

[PATCH] D55337: NFC: Move dumpDeclRef to NodeDumper

aaron.ballman added inline comments. Comment at: include/clang/AST/TextNodeDumper.h:28 const comments::FullComment *> { + TextTreeStructure raw_ostream steveire wrote: > aaron.ballman wrote: > > This makes me a

[PATCH] D56318: [HIP] Fix size_t for MSVC environment

rjmccall added a comment. What's the general idea here, that you're going to pretend to be the environment's "standard" CPU target of the right pointer width and try to match the ABI exactly? This seems like a pretty treacherous road to go down. CHANGES SINCE LAST ACTION

[PATCH] D56225: [HIP] Use nul instead of /dev/null when running on windows

rjmccall added inline comments. Comment at: lib/Driver/ToolChains/HIP.cpp:210 std::string BundlerTargetArg = "-targets=host-x86_64-unknown-linux"; - std::string BundlerInputArg = "-inputs=/dev/null"; + std::string BundlerInputArg = "-inputs=" NULL_FILE;

[PATCH] D56113: [OpenMP] Replace predetermined shared for const variable

ABataev added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:9736 +static bool rejectConstNotMutableType(Sema , ValueDecl *D, + OpenMPClauseKind CKind, This function and the original code has a lot of common

[PATCH] D56318: [HIP] Fix size_t for MSVC environment

yaxunl created this revision. yaxunl added reviewers: tra, rjmccall. Herald added subscribers: tpr, nhaehnle, jvesely. In 64 bit MSVC environment size_t is defined as unsigned long long. Fix AMDGPU target info to match it in MSVC environment. https://reviews.llvm.org/D56318 Files:

[PATCH] D55948: Modify DeclaratorChuck::getFunction to use DeclSpec for qualifiers

rjmccall added inline comments. Comment at: lib/Sema/SemaDeclCXX.cpp:8175 DeclaratorChunk::FunctionTypeInfo = D.getFunctionTypeInfo(); - if (FTI.TypeQuals != 0) { -if (FTI.TypeQuals & Qualifiers::Const) - Diag(D.getIdentifierLoc(),

[PATCH] D56215: [lld] [ELF] Include default search paths for NetBSD driver

arichardson added a comment. In D56215#1346061 , @mgorny wrote: > For the record, another option is to actually fix other software not to call > LD directly. Or if you really need to call the linker directly without specifying search paths you could

[PATCH] D55955: Properly diagnose [[nodiscard]] on the body of a range-based for loop

aaron.ballman marked 3 inline comments as done. aaron.ballman added inline comments. Comment at: test/Parser/switch-recovery.cpp:108 expected-error {{no member named 'x' in the global namespace; did you mean simply 'x'?}} \ - expected-warning 2

[PATCH] D56321: [HIP][DRIVER][OFFLOAD] Do not unbundle unsupported file types

ashi1 created this revision. ashi1 added a reviewer: yaxunl. Herald added a subscriber: cfe-commits. The offload bundler action should not unbundle the input file types that does not match the action type. This fixes an issue where .so files are unbundled when the action type is object files.

r350414 - Add two new pragmas for controlling software pipelining optimizations.

Author: aaronballman Date: Fri Jan 4 09:20:00 2019 New Revision: 350414 URL: http://llvm.org/viewvc/llvm-project?rev=350414=rev Log: Add two new pragmas for controlling software pipelining optimizations. This patch adds #pragma clang loop pipeline and #pragma clang loop

[PATCH] D55433: [clang-tidy] Adding a new modernize use nodiscard checker

JonasToth added a comment. Mostly nits left. I think the check is good to go afterwards :) Comment at: clang-tidy/modernize/UseNodiscardCheck.cpp:23 +static bool isAliasedTemplateParamType(QualType ParamType) { + return (ParamType.getCanonicalType()->isTemplateTypeParmType()

[PATCH] D56215: [lld] [ELF] Include default search paths for NetBSD driver

krytarowski added a comment. In D56215#1346342 , @arichardson wrote: > In D56215#1346061 , @mgorny wrote: > > > For the record, another option is to actually fix other software not to > > call LD directly. > > >

[PATCH] D55933: [Sema] Do not print default template parameters.

Quuxplusone added inline comments. Comment at: lib/AST/TypePrinter.cpp:179 +// `X` gets canonicalized to `X`. We disable +// canonicalization so that `printTag()`` can see the template parameters as +// written. courbet wrote: > Quuxplusone wrote: >

Re: [PATCH] D56215: [lld] [ELF] Include default search paths for NetBSD driver

On Fri, Jan 04, 2019 at 02:48:35PM +, Alexander Richardson via Phabricator wrote: > Or if you really need to call the linker directly without specifying > search paths you could also install a shell script as /usr/bin/ld that > passes the appropriate flags to /usr/bin/ld.lld? That's not a

[PATCH] D56215: [lld] [ELF] Include default search paths for NetBSD driver

ruiu added a comment. In D56215#1345880 , @krytarowski wrote: > In D56215#1345845 , @ruiu wrote: > > > Not sure what I understand the point, but as to make lld work on/for > > NetBSD, I wonder if you can just add

[PATCH] D56323: Handle member variables in readability-simplify-boolean-expr

LegalizeAdulthood updated this revision to Diff 180275. LegalizeAdulthood added a comment. Fix typo in id CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56323/new/ https://reviews.llvm.org/D56323 Files: clang-tidy/readability/SimplifyBooleanExprCheck.cpp

[PATCH] D56318: [HIP] Fix size_t for MSVC environment

yaxunl added a comment. In D56318#1346456 , @rjmccall wrote: > What's the general idea here, that you're going to pretend to be the > environment's "standard" CPU target of the right pointer width and try to > match the ABI exactly? This seems like a

[PATCH] D56323: [clang-tidy] Handle member variables in readability-simplify-boolean-expr

LegalizeAdulthood updated this revision to Diff 180276. LegalizeAdulthood added a comment. No, really, fix typo in id Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56323/new/ https://reviews.llvm.org/D56323 Files:

[PATCH] D55955: Properly diagnose [[nodiscard]] on the body of a range-based for loop

aaron.ballman closed this revision. aaron.ballman added a comment. Committed with minor modifications for the range-based for loop changes in r350404. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55955/new/ https://reviews.llvm.org/D55955

[PATCH] D55710: add pragmas to control Software Pipelining optimisation

aaron.ballman closed this revision. aaron.ballman added a comment. I commit this in r350414, thank you for the patch! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55710/new/ https://reviews.llvm.org/D55710 ___ cfe-commits mailing list

[PATCH] D53891: [LTO] Add option to enable LTOUnit splitting, and disable unless needed

tejohnson added a comment. ping Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53891/new/ https://reviews.llvm.org/D53891 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D55865: [ObjC] Add a new attribute to opt-out of implicit callee retain/release in ARC

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from a few minor nits/questions. Comment at: clang/docs/AutomaticReferenceCounting.rst:1747 +contrast with ``__unsafe_unretained``, an

r350404 - Refactor the way we handle diagnosing unused expression results.

Author: aaronballman Date: Fri Jan 4 08:58:14 2019 New Revision: 350404 URL: http://llvm.org/viewvc/llvm-project?rev=350404=rev Log: Refactor the way we handle diagnosing unused expression results. Rather than sprinkle calls to DiagnoseUnusedExprResult() around in places where we want

[PATCH] D56090: Add a matcher for members of an initializer list expression

hwright updated this revision to Diff 180248. hwright added a comment. Removed `IgnoreParenImpCasts` call. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56090/new/ https://reviews.llvm.org/D56090 Files: docs/LibASTMatchersReference.html include/clang/ASTMatchers/ASTMatchers.h

[PATCH] D56090: Add a matcher for members of an initializer list expression

hwright marked 4 inline comments as done. hwright added inline comments. Comment at: include/clang/ASTMatchers/ASTMatchers.h:3527 + return N < Node.getNumInits() && + InnerMatcher.matches(*Node.getInit(N)->IgnoreParenImpCasts(), Finder, +

r350415 - [OPENMP][NVPTX]Use new functions from the runtime library.

Author: abataev Date: Fri Jan 4 09:25:09 2019 New Revision: 350415 URL: http://llvm.org/viewvc/llvm-project?rev=350415=rev Log: [OPENMP][NVPTX]Use new functions from the runtime library. Updated codegen to use the new functions from the runtime library. Modified:

r350422 - [ObjCARC] Add an new attribute, objc_externally_retained

Author: epilk Date: Fri Jan 4 10:33:06 2019 New Revision: 350422 URL: http://llvm.org/viewvc/llvm-project?rev=350422=rev Log: [ObjCARC] Add an new attribute, objc_externally_retained This attribute, called "objc_externally_retained", exposes clang's notion of pseudo-__strong variables in ARC.

[PATCH] D55865: [ObjC] Add a new attribute to opt-out of implicit callee retain/release in ARC

This revision was automatically updated to reflect the committed changes. Closed by commit rL350422: [ObjCARC] Add an new attribute, objc_externally_retained (authored by epilk, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D55620: [ThinLTO] Clang changes to utilize new pass to handle chains of aliases

tejohnson added a comment. ping on the clang side change as well Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55620/new/ https://reviews.llvm.org/D55620 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D56323: Handle member variables in readability-simplify-boolean-expr

LegalizeAdulthood updated this revision to Diff 180274. LegalizeAdulthood added a comment. Fix typo in id CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56323/new/ https://reviews.llvm.org/D56323 Files: clang-tidy/readability/SimplifyBooleanExprCheck.cpp

[PATCH] D56323: Handle member variables in readability-simplify-boolean-expr

LegalizeAdulthood created this revision. LegalizeAdulthood added a reviewer: cfe-commits. LegalizeAdulthood updated this revision to Diff 180274. LegalizeAdulthood added a comment. Fix typo in id - Add readability-simplify-boolean-expr test cases for member variables Fixes #40179

[PATCH] D55620: [ThinLTO] Clang changes to utilize new pass to handle chains of aliases

pcc accepted this revision. pcc added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55620/new/ https://reviews.llvm.org/D55620 ___ cfe-commits mailing

[PATCH] D55433: [clang-tidy] Adding a new modernize use nodiscard checker

MyDeveloperDay updated this revision to Diff 180266. MyDeveloperDay marked 4 inline comments as done. MyDeveloperDay added a comment. Update with view comments from @JonasToth - remove unnecessary static functions - move checks into matchers - remove duplicated diag call CHANGES SINCE LAST

[PATCH] D55433: [clang-tidy] Adding a new modernize use nodiscard checker

MyDeveloperDay marked 3 inline comments as done. MyDeveloperDay added inline comments. Comment at: clang-tidy/modernize/UseNodiscardCheck.cpp:23 +static bool isAliasedTemplateParamType(QualType ParamType) { + return (ParamType.getCanonicalType()->isTemplateTypeParmType() || +

[PATCH] D55620: [ThinLTO] Clang changes to utilize new pass to handle chains of aliases

tejohnson updated this revision to Diff 180272. tejohnson added a comment. Update comment Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55620/new/ https://reviews.llvm.org/D55620 Files: lib/CodeGen/BackendUtil.cpp test/CodeGen/lto-newpm-pipeline.c Index:

[PATCH] D55620: [ThinLTO] Clang changes to utilize new pass to handle chains of aliases

This revision was automatically updated to reflect the committed changes. Closed by commit rL350424: [ThinLTO] Clang changes to utilize new pass to handle chains of aliases (authored by tejohnson, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINCE LAST

[PATCH] D56321: [HIP][DRIVER][OFFLOAD] Do not unbundle unsupported file types

yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. LGTM. Can you rename the lit test as hip-link-shared-library.hip? That is more meaningful. Thanks. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56321/new/

r350426 - [HIP][DRIVER][OFFLOAD] Do not unbundle unsupported file types

Author: aaronenyeshi Date: Fri Jan 4 11:09:20 2019 New Revision: 350426 URL: http://llvm.org/viewvc/llvm-project?rev=350426=rev Log: [HIP][DRIVER][OFFLOAD] Do not unbundle unsupported file types The offload bundler action should not unbundle the input file types that does not match the action

[PATCH] D56318: [HIP] Fix size_t for MSVC environment

rjmccall added a comment. No, no, I understand that you're not changing pointer sizes, but this is one example of trying to match the ABI of the target environment, and I'm trying to understand how far that goes. What does it mean to be in the "MSVC" environment when you're actually just

[PATCH] D56299: [OpenMP] Refactor const restriction for linear

jdenny updated this revision to Diff 180301. jdenny added a comment. Update for changes to earlier patches in series. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56299/new/ https://reviews.llvm.org/D56299 Files: clang/lib/Sema/SemaOpenMP.cpp

[PATCH] D56113: [OpenMP] Replace predetermined shared for const variable

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56113/new/ https://reviews.llvm.org/D56113 ___ cfe-commits

r350433 - Fix default-function-attr.c so that it works on Windows.

Author: pcc Date: Fri Jan 4 12:51:54 2019 New Revision: 350433 URL: http://llvm.org/viewvc/llvm-project?rev=350433=rev Log: Fix default-function-attr.c so that it works on Windows. Modified: cfe/trunk/test/CodeGen/default-function-attr.c Modified:

r350425 - [HIP][DRIVER][OFFLOAD] Do not unbundle unsupported file types

Author: aaronenyeshi Date: Fri Jan 4 11:05:41 2019 New Revision: 350425 URL: http://llvm.org/viewvc/llvm-project?rev=350425=rev Log: [HIP][DRIVER][OFFLOAD] Do not unbundle unsupported file types The offload bundler action should not unbundle the input file types that does not match the action

r350424 - [ThinLTO] Clang changes to utilize new pass to handle chains of aliases

Author: tejohnson Date: Fri Jan 4 11:05:01 2019 New Revision: 350424 URL: http://llvm.org/viewvc/llvm-project?rev=350424=rev Log: [ThinLTO] Clang changes to utilize new pass to handle chains of aliases Summary: As with NameAnonGlobals, invoke the new CanonicalizeAliases via clang when using the

[PATCH] D56299: [OpenMP] Refactor const restriction for linear

jdenny updated this revision to Diff 180283. jdenny added a comment. Update for changes to earlier patches in series. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56299/new/ https://reviews.llvm.org/D56299 Files: clang/lib/Sema/SemaOpenMP.cpp

[PATCH] D56113: [OpenMP] Replace predetermined shared for const variable

ABataev added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:1115 + +static bool isConstNotMutableType(Sema , ValueDecl *D) { + return checkConstNotMutableType(SemaRef, D, /*ReportDiag*/ false, I would say it is better to outlined check as a

Re: r350340 - Validate -add-plugin arguments.

Hello Nico, This commit broke tests on llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast builder: http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast/builds/41673 . . . Failing Tests (2): Clang :: CodeGenCXX/debug-info-class-limited-plugin.test Clang ::

[PATCH] D56321: [HIP][DRIVER][OFFLOAD] Do not unbundle unsupported file types

ashi1 updated this revision to Diff 180289. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56321/new/ https://reviews.llvm.org/D56321 Files: lib/Driver/Driver.cpp test/Driver/hip-link-shared-library.hip Index: test/Driver/hip-link-shared-library.hip

[PATCH] D56318: [HIP] Fix size_t for MSVC environment

yaxunl added a comment. In D56318#1346693 , @rjmccall wrote: > No, no, I understand that you're not changing pointer sizes, but this is one > example of trying to match the ABI of the target environment, and I'm trying > to understand how far that goes.

[PATCH] D56321: [HIP][DRIVER][OFFLOAD] Do not unbundle unsupported file types

ashi1 added a comment. I've commit the changes, but forgot to tag the proper Diff link in the commit message. I just updated it. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56321/new/ https://reviews.llvm.org/D56321 ___ cfe-commits

[PATCH] D56113: [OpenMP] Replace predetermined shared for const variable

jdenny added a comment. Thanks for the review! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56113/new/ https://reviews.llvm.org/D56113 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D56326: [OpenMP 5.0] Parsing/sema support for "omp declare mapper" directive

lildmh created this revision. Herald added subscribers: cfe-commits, jfb, arphaman, guansong, jholewinski. Repository: rC Clang https://reviews.llvm.org/D56326 Files: include/clang/AST/DeclBase.h include/clang/AST/DeclCXX.h include/clang/AST/DeclOpenMP.h

[PATCH] D56321: [HIP][DRIVER][OFFLOAD] Do not unbundle unsupported file types

This revision was automatically updated to reflect the committed changes. Closed by commit rL350426: [HIP][DRIVER][OFFLOAD] Do not unbundle unsupported file types (authored by aaronenyeshi, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D56038: hwasan: Implement lazy thread initialization for the interceptor ABI.

This revision was automatically updated to reflect the committed changes. Closed by commit rC350429: hwasan: Implement lazy thread initialization for the interceptor ABI. (authored by pcc, committed by ). Herald added a subscriber: cfe-commits. Changed prior to commit:

r350429 - hwasan: Implement lazy thread initialization for the interceptor ABI.

Author: pcc Date: Fri Jan 4 11:27:04 2019 New Revision: 350429 URL: http://llvm.org/viewvc/llvm-project?rev=350429=rev Log: hwasan: Implement lazy thread initialization for the interceptor ABI. The problem is similar to D55986 but for threads: a process with the interceptor hwasan library

[PATCH] D48342: [libcxx] Optimize vectors construction of trivial types from an iterator range with const-ness mismatch.

vsapsai updated this revision to Diff 180316. vsapsai added a comment. - Tweak the test. - Use for `__construct_range_forward` approach recommended by @ldionne (it works with C++03). - Use `__is_default_allocator` for `__construct_forward` and `__construct_backward`. Didn't introduce

[PATCH] D48342: [libcxx] Optimize vectors construction of trivial types from an iterator range with const-ness mismatch.

vsapsai added inline comments. Comment at: libcxx/test/std/containers/sequences/vector/vector.cons/construct_iter_iter.pass.cpp:196 test_ctor_under_alloc(); + test_ctor_with_different_value_type(); } Quuxplusone wrote: > I suggest that interesting test

r350441 - [OpenMP] Refactor const restriction for linear

Author: jdenny Date: Fri Jan 4 14:12:13 2019 New Revision: 350441 URL: http://llvm.org/viewvc/llvm-project?rev=350441=rev Log: [OpenMP] Refactor const restriction for linear As discussed in D56113, this patch refactors the implementation of the const restriction for linear to reuse a function

[PATCH] D56299: [OpenMP] Refactor const restriction for linear

This revision was automatically updated to reflect the committed changes. Closed by commit rC350441: [OpenMP] Refactor const restriction for linear (authored by jdenny, committed by ). Changed prior to commit: https://reviews.llvm.org/D56299?vs=180301=180320#toc Repository: rC Clang