[PATCH] D56445: [Sema] Teach Clang that aligned allocation is not supported with macosx10.13

This revision was automatically updated to reflect the committed changes. Closed by commit rL350649: [Sema] Teach Clang that aligned allocation is not supported with macosx10.13 (authored by ldionne, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

r350649 - [Sema] Teach Clang that aligned allocation is not supported with macosx10.13

Author: ldionne Date: Tue Jan 8 12:26:56 2019 New Revision: 350649 URL: http://llvm.org/viewvc/llvm-project?rev=350649=rev Log: [Sema] Teach Clang that aligned allocation is not supported with macosx10.13 Summary: r306722 added diagnostics when aligned allocation is used with deployment targets

r350665 - Implement the TreeStructure interface through the TextNodeDumper

Author: steveire Date: Tue Jan 8 14:32:48 2019 New Revision: 350665 URL: http://llvm.org/viewvc/llvm-project?rev=350665=rev Log: Implement the TreeStructure interface through the TextNodeDumper Summary: This way, when the generic ASTTraverser is extracted from ASTDumper, there can't be any

[PATCH] D55953: Android is not GNU, so don't claim that it is.

This revision was automatically updated to reflect the committed changes. Closed by commit rC350664: Android is not GNU, so dont claim that it is. (authored by danalbert, committed by ). Changed prior to commit: https://reviews.llvm.org/D55953?vs=179140=180741#toc Repository: rC Clang

[PATCH] D56407: Implement the TreeStructure interface through the TextNodeDumper

This revision was automatically updated to reflect the committed changes. Closed by commit rC350665: Implement the TreeStructure interface through the TextNodeDumper (authored by steveire, committed by ). Changed prior to commit: https://reviews.llvm.org/D56407?vs=180552=180742#toc

Re: r346652 - Make clang-based tools find libc++ on MacOS

That looks like it should help. Thanks for the quick fix! On Tue, Jan 8, 2019 at 1:11 PM Ilya Biryukov wrote: > Hi Nico, > > This is clearly a bug, it's supposed to search in a sibling directory. > Are you running clang as './clang' in the scripts? The code seems to > break in that case,

r350643 - Limit COFF 'common' emission to <=32 alignment types.

Author: erichkeane Date: Tue Jan 8 10:44:22 2019 New Revision: 350643 URL: http://llvm.org/viewvc/llvm-project?rev=350643=rev Log: Limit COFF 'common' emission to <=32 alignment types. As reported in PR33035, LLVM crashes if given a common object with an alignment of greater than 32 bits. This

[PATCH] D55224: [clangd] Introduce loading of shards within auto-index

kadircet updated this revision to Diff 180706. kadircet marked 23 inline comments as done. kadircet added a comment. Address comments Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55224/new/ https://reviews.llvm.org/D55224 Files:

[PATCH] D56424: [clang-tidy] Add check for underscores in googletest names.

Eugene.Zelenko added inline comments. Comment at: docs/ReleaseNotes.rst:161 + + Checks that Googletest test and test case names do not contain an underscore, + which is prohibited by the Googletest FAQ. Please synchronize with first statement in documentation.

[PATCH] D56413: [OpenMP] Avoid remainder operations for loop index values on a collapsed loop nest.

gtbercea updated this revision to Diff 180722. gtbercea added a comment. Fix. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56413/new/ https://reviews.llvm.org/D56413 Files: lib/Sema/SemaOpenMP.cpp test/OpenMP/for_codegen.cpp

[PATCH] D56215: [lld] [ELF] Include default search paths for NetBSD driver

joerg added inline comments. Comment at: ELF/Driver.cpp:381 +} +Config->SearchPaths.push_back("/usr/lib"); + } Those need to be sysroot-relative of course. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56215/new/

r350666 - [libclang] Recommit r336590 with a fix for the memory leak in the test

Author: arphaman Date: Tue Jan 8 14:32:51 2019 New Revision: 350666 URL: http://llvm.org/viewvc/llvm-project?rev=350666=rev Log: [libclang] Recommit r336590 with a fix for the memory leak in the test The original commit had a memory leak in the test has a leak as it doesn't dispose of the

r350668 - [Driver] Default to -fno-addrsig on Android.

Author: danalbert Date: Tue Jan 8 14:33:59 2019 New Revision: 350668 URL: http://llvm.org/viewvc/llvm-project?rev=350668=rev Log: [Driver] Default to -fno-addrsig on Android. Summary: The Android NDK still uses GNU binutils by default. Reviewers: srhines, pirama Reviewed By: srhines

[PATCH] D56456: [Driver] Default to -fno-addrsig on Android.

This revision was automatically updated to reflect the committed changes. Closed by commit rL350668: [Driver] Default to -fno-addrsig on Android. (authored by danalbert, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINCE LAST ACTION

[PATCH] D56446: [Driver] Fix libcxx detection on Darwin with clang run as ./clang

ilya-biryukov created this revision. ilya-biryukov added reviewers: arphaman, thakis. Herald added a reviewer: EricWF. Herald added a subscriber: christof. By using '..' instead of fs::parent_path. The intention of the code was to go from 'path/to/clang/bin' to 'path/to/clang/include'. In most

[PATCH] D56424: [clang-tidy] Add check for underscores in googletest names.

Eugene.Zelenko added inline comments. Comment at: clang-tidy/google/AvoidUnderscoreInGoogletestNameCheck.cpp:46 +auto IdentifierInfo = MacroNameToken.getIdentifierInfo(); +if (!IdentifierInfo) { + return; Please elide braces. Repository: rCTE

[PATCH] D56446: [Driver] Fix libcxx detection on Darwin with clang run as ./clang

arphaman accepted this revision. arphaman added a comment. This revision is now accepted and ready to land. That makes sense, LGTM. Thanks! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56446/new/ https://reviews.llvm.org/D56446

[PATCH] D55337: NFC: Move dumpDeclRef to NodeDumper

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. Once D56407 lands, the rebased changes here LGTM Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55337/new/

[PATCH] D56391: Limit COFF 'common' emission to <=32 alignment types.

This revision was automatically updated to reflect the committed changes. Closed by commit rC350643: Limit COFF common emission to =32 alignment types. (authored by erichkeane, committed by ). Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56391/new/

[PATCH] D56413: [OpenMP] Avoid remainder operations for loop index values on a collapsed loop nest.

ABataev added inline comments. Comment at: lib/Sema/SemaOpenMP.cpp:5523 SourceLocation UpdLoc = IS.IncSrcRange.getBegin(); - // Build: Iter = (IV / Div) % IS.NumIters - // where Div is product of previous iterations' IS.NumIters. - ExprResult Iter; -

RE: r350643 - Limit COFF 'common' emission to <=32 alignment types.

That seems like it would make sense to me. COFF isn’t my expertise, so hopefully David/Martin/others can let me know if this is subtly broken elsewhere. From: Shoaib Meenai [mailto:smee...@fb.com] Sent: Tuesday, January 8, 2019 1:09 PM To: Keane, Erich ; cfe-commits@lists.llvm.org; David

[PATCH] D56424: [clang-tidy] Add check for underscores in googletest names.

karepker marked 2 inline comments as done and an inline comment as not done. karepker added inline comments. Comment at: clang-tidy/google/AvoidUnderscoreInGoogletestNameCheck.cpp:27 +static bool isGoogletestTestMacro(StringRef MacroName) { + static const llvm::StringSet<>

[clang-tools-extra] r350660 - [Query] NFC: Port QueryParser to StringRef

Author: steveire Date: Tue Jan 8 14:27:08 2019 New Revision: 350660 URL: http://llvm.org/viewvc/llvm-project?rev=350660=rev Log: [Query] NFC: Port QueryParser to StringRef Summary: There is no reason for it to not be a StringRef. Making it one simplifies existing code, and makes follow-up

[PATCH] D56415: NFC: Port QueryParser to StringRef

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE350660: [Query] NFC: Port QueryParser to StringRef (authored by steveire, committed by ). Changed prior to commit: https://reviews.llvm.org/D56415?vs=180626=180740#toc Repository: rCTE Clang Tools

r350642 - __has_feature(pragma_clang_attribute_namespaces) should be __has_extension

Author: epilk Date: Tue Jan 8 10:24:39 2019 New Revision: 350642 URL: http://llvm.org/viewvc/llvm-project?rev=350642=rev Log: __has_feature(pragma_clang_attribute_namespaces) should be __has_extension Thanks to Richard Smith for pointing this out. Modified:

Re: r350643 - Limit COFF 'common' emission to <=32 alignment types.

Ah, looks like you were originally checking for COFF, and then David suggested checking for MSVC instead? I'm curious about why, although I'm sure the suggestion is legit :) From: cfe-commits on behalf of Shoaib Meenai via cfe-commits Reply-To: Shoaib Meenai Date: Tuesday, January 8, 2019

[PATCH] D56215: [lld] [ELF] Include default search paths for NetBSD driver

ruiu added a comment. To be honest, I don't think I would lgtm a patch that changes lld's default behavior depending on host/target only for NetBSD, and it seems like a NetBSD's issue rather than an lld's issue. As I said, could you please make an effort to pass the flags you need from the

[PATCH] D56215: [lld] [ELF] Include default search paths for NetBSD driver

joerg added a comment. @ruiu: No, it is exactly what you want, since it allows you to point lld into the normal sysroot. Cross-compiling is the default case for the NetBSD toolchain. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56215/new/ https://reviews.llvm.org/D56215

[PATCH] D56215: [lld] [ELF] Include default search paths for NetBSD driver

ruiu added a comment. I want to handle NetBSD in the same way as the other operating systems. I'm sorry to have been saying no to a few recent patches for NetBSD, but I think that's for a good reason, and I don't think you presented a convincing reason why we had to handle only NetBSD

Re: r336716 - Revert r336590 "[libclang] evalute compound statement cursors before trying to evaluate"

Thanks for reverting the commit! Unfortunately I missed the failure back then. I fixed the leak and recommitted the change in r350666. Cheers, Alex On Tue, 10 Jul 2018 at 12:53, Evgeniy Stepanov via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: eugenis > Date: Tue Jul 10 12:49:07

[PATCH] D56424: [clang-tidy] Add check for underscores in googletest names.

MyDeveloperDay added inline comments. Comment at: clang-tidy/google/AvoidUnderscoreInGoogletestNameCheck.cpp:27 +static bool isGoogletestTestMacro(StringRef MacroName) { + static const llvm::StringSet<> MacroNames = {"TEST", "TEST_F", "TEST_P", +

[PATCH] D56413: [OpenMP] Avoid remainder operations for loop index values on a collapsed loop nest.

gtbercea updated this revision to Diff 180713. gtbercea added a comment. Remove redundant initalization. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56413/new/ https://reviews.llvm.org/D56413 Files: lib/Sema/SemaOpenMP.cpp test/OpenMP/for_codegen.cpp

[PATCH] D56424: [clang-tidy] Add check for underscores in googletest names.

karepker updated this revision to Diff 180716. karepker marked 15 inline comments as done. karepker added a comment. Address comments. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56424/new/ https://reviews.llvm.org/D56424 Files:

[PATCH] D56215: [lld] [ELF] Include default search paths for NetBSD driver

joerg added a comment. Thanks, this looks like a good starting point. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56215/new/ https://reviews.llvm.org/D56215 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D56411: [CUDA][HIP][Sema] Fix template kernel with function as template parameter

yaxunl added a comment. In D56411#1349364 , @jlebar wrote: > Without reading the patch in detail (sorry) but looking mainly at the > testcase: It looks like we're not checking how overloading and `__host__ > __device__` functions play into this. Maybe

[PATCH] D56411: [CUDA][HIP][Sema] Fix template kernel with function as template parameter

jlebar added a comment. __host__ void bar() {} __device__ int bar() { return 0; } __host__ __device__ void foo() { int x = bar(); } template __global__ void kernel() { devF();} kernel(); > we DTRT for this case. Here __host__ bar needs to return int since foo() > expects that.

r350644 - [NFC] Don't over-eagerly check block alignment

Author: jfb Date: Tue Jan 8 10:51:38 2019 New Revision: 350644 URL: http://llvm.org/viewvc/llvm-project?rev=350644=rev Log: [NFC] Don't over-eagerly check block alignment Alignment of __block isn't relevant to this test, remove its checking. Modified:

[PATCH] D56413: [OpenMP] Avoid remainder operations for loop index values on a collapsed loop nest.

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56413/new/ https://reviews.llvm.org/D56413 ___ cfe-commits

[PATCH] D56424: [clang-tidy] Add check for underscores in googletest names.

karepker added a comment. In D56424#1349336 , @lebedev.ri wrote: > In D56424#1349218 , @karepker wrote: > > > Clean up comments in test file. > > > For reference, what documentation sources did you read when

[PATCH] D56288: [ELF] Do not enable 'new dtags' on NetBSD by default

mgorny updated this revision to Diff 180718. mgorny added a comment. Updating for completeness. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56288/new/ https://reviews.llvm.org/D56288 Files: ELF/Driver.cpp Index: ELF/Driver.cpp

RE: r350643 - Limit COFF 'common' emission to <=32 alignment types.

Yep, exactly. I looked, and isKnownWindowsMSVCEnvironment checks for OS=Win32, which I believe would be different for other architectures. From: Shoaib Meenai [mailto:smee...@fb.com] Sent: Tuesday, January 8, 2019 12:41 PM To: Keane, Erich ; cfe-commits@lists.llvm.org; David Majnemer Subject:

[PATCH] D56456: [Driver] Default to -fno-addrsig on Android.

danalbert created this revision. danalbert added reviewers: srhines, pirama. The Android NDK still uses GNU binutils by default. Repository: rC Clang https://reviews.llvm.org/D56456 Files: lib/Driver/ToolChains/Clang.cpp test/Driver/addrsig.c Index: test/Driver/addrsig.c

[PATCH] D55433: [clang-tidy] Adding a new modernize use nodiscard checker

MyDeveloperDay added a comment. In D55433#1349709 , @JonasToth wrote: > No problem, thats why we test on real projects first, because there is always > something hidden in C++ :) > > Is there a test for the lambdas?

[PATCH] D56445: [Sema] Teach Clang that aligned allocation is not supported with macosx10.13

ahatanak accepted this revision. ahatanak added a comment. This revision is now accepted and ready to land. LGTM. We should probably check that alignedAllocMinVersion returns the correct versions for other OSes too, but this patch is fine. Repository: rC Clang CHANGES SINCE LAST ACTION

[PATCH] D55483: Introduce the callback attribute and emit !callback metadata

jdoerfert updated this revision to Diff 180710. jdoerfert marked 3 inline comments as done. jdoerfert added a comment. Update encoding, rebase to HEAD Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55483/new/ https://reviews.llvm.org/D55483 Files:

[PATCH] D56413: [OpenMP] Avoid remainder operations for loop index values on a collapsed loop nest.

gtbercea updated this revision to Diff 180711. gtbercea added a comment. Fix update. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56413/new/ https://reviews.llvm.org/D56413 Files: lib/Sema/SemaOpenMP.cpp test/OpenMP/for_codegen.cpp

[PATCH] D56413: [OpenMP] Avoid remainder operations for loop index values on a collapsed loop nest.

gtbercea updated this revision to Diff 180709. gtbercea added a comment. Invert accumulation direction. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56413/new/ https://reviews.llvm.org/D56413 Files: docs/OpenMPSupport.rst

[PATCH] D55483: Introduce the callback attribute and emit !callback metadata

jdoerfert updated this revision to Diff 180714. jdoerfert added a comment. Fix tests Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55483/new/ https://reviews.llvm.org/D55483 Files: include/clang/AST/ASTContext.h include/clang/Basic/Attr.td

[PATCH] D56215: [lld] [ELF] Include default search paths for NetBSD driver

joerg added inline comments. Comment at: ELF/Driver.cpp:779 +// TODO: verify the triple somehow? +Config->TargetTriple = llvm::Triple(Prefix); + } See ToolChain::getTargetAndModeFromProgramName in clang. CHANGES SINCE LAST ACTION

[PATCH] D55953: Android is not GNU, so don't claim that it is.

srhines accepted this revision. srhines added a comment. This revision is now accepted and ready to land. Sorry about the delay. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55953/new/ https://reviews.llvm.org/D55953

r350645 - Fix opencl test broken on windows by r350643.

Author: erichkeane Date: Tue Jan 8 11:10:43 2019 New Revision: 350645 URL: http://llvm.org/viewvc/llvm-project?rev=350645=rev Log: Fix opencl test broken on windows by r350643. Windows doesn't allow common with alignment >32 bits, so these tests were broken in windows mode. This patch makes

Re: r350643 - Limit COFF 'common' emission to <=32 alignment types.

Why does this check for isKnownWindowsMSVCEnvironment specifically? Wouldn't any COFF target (windows-cygnus, windows-gnu, windows-itanium, etc.) have the same limitation, since it's an object file format issue and not an ABI issue? From: cfe-commits on behalf of Erich Keane via cfe-commits

[PATCH] D56215: [lld] [ELF] Include default search paths for NetBSD driver

mgorny updated this revision to Diff 180717. mgorny added a comment. Next version, based on recognizing NetBSD from triple. @joerg, is this a better approach? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56215/new/ https://reviews.llvm.org/D56215 Files: ELF/Config.h

Re: r350643 - Limit COFF 'common' emission to <=32 alignment types.

It checks for both OS=Win32 and Environment=MSVC, so that wouldn't cover other COFF environments. wbs (Martin Storsjo) mentioned on IRC that MinGW adds an aligncomm directive to specify alignment for common symbols, so perhaps that's part of it? From: "Keane, Erich" Date: Tuesday, January 8,

[PATCH] D56215: [lld] [ELF] Include default search paths for NetBSD driver

arichardson added inline comments. Comment at: ELF/Driver.cpp:770 + // Start with a default initial triple + Config->TargetTriple = llvm::Triple(getDefaultTargetTriple()); + If I invoke an unprefixed ld.lld on NetBSD but want to target a different operating

Re: r346652 - Make clang-based tools find libc++ on MacOS

Hi Nico, This is clearly a bug, it's supposed to search in a sibling directory. Are you running clang as './clang' in the scripts? The code seems to break in that case, https://reviews.llvm.org/D56446 should fix this. On Tue, Jan 8, 2019 at 5:12 PM Nico Weber wrote: > It looks like clang now

Re: r350572 - Add a __has_feature check for namespaces on #pragma clang attribute.

On 1/7/19 4:43 PM, Richard Smith wrote: On Mon, 7 Jan 2019 at 16:12, Erik Pilkington via cfe-commits mailto:cfe-commits@lists.llvm.org>> wrote: On 1/7/19 3:51 PM, Richard Smith wrote: On Mon, 7 Jan 2019 at 13:57, Erik Pilkington via cfe-commits

[PATCH] D55224: [clangd] Introduce loading of shards within auto-index

kadircet added inline comments. Comment at: clangd/index/Background.cpp:259 + // if this thread sees the older version but finishes later. This should + // be rare in practice. + DigestIt.first->second = Hash; ilya-biryukov wrote: > kadircet

r350648 - Fix clang for r350647: Missed a function rename

Author: pfaffe Date: Tue Jan 8 12:00:55 2019 New Revision: 350648 URL: http://llvm.org/viewvc/llvm-project?rev=350648=rev Log: Fix clang for r350647: Missed a function rename Modified: cfe/trunk/lib/CodeGen/BackendUtil.cpp Modified: cfe/trunk/lib/CodeGen/BackendUtil.cpp URL:

[PATCH] D56215: [lld] [ELF] Include default search paths for NetBSD driver

ruiu added a comment. I'm sorry to say this but I don't think this is a good approach. Just like changing the default behavior depending on host hurts cross-build and is against the policy of the lld driver, changing the default behavior depending on the target hurts it too. Imagine that you

[PATCH] D56215: [lld] [ELF] Include default search paths for NetBSD driver

mgorny marked an inline comment as done. mgorny added inline comments. Comment at: ELF/Driver.cpp:779 +// TODO: verify the triple somehow? +Config->TargetTriple = llvm::Triple(Prefix); + } joerg wrote: > See ToolChain::getTargetAndModeFromProgramName in

[PATCH] D56215: [lld] [ELF] Include default search paths for NetBSD driver

krytarowski added a comment. In D56215#1350134 , @joerg wrote: > Thanks, this looks like a good starting point. What's the final state you want? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56215/new/ https://reviews.llvm.org/D56215

[PATCH] D56424: [clang-tidy] Add check for underscores in googletest names.

karepker updated this revision to Diff 180727. karepker marked 4 inline comments as done. karepker added a comment. Update release notes documentation to match check documentation more. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56424/new/

[PATCH] D56424: [clang-tidy] Add check for underscores in googletest names.

karepker added inline comments. Comment at: docs/ReleaseNotes.rst:161 + + Checks that Googletest test and test case names do not contain an underscore, + which is prohibited by the Googletest FAQ. Eugene.Zelenko wrote: > Please synchronize with first statement

[PATCH] D56444: [AST] RecursiveASTVisitor visits lambda classes when implicit visitation is on.

JonasToth added a comment. I still see the unit-test crashing for `ExprMutAnalyzer` (just apply these tests https://github.com/JonasToth/clang/blob/fix_crash/unittests/Analysis/ExprMutationAnalyzerTest.cpp and run `check-clang-unit`) The clang-tidy check does not crash anymore, but

r350664 - Android is not GNU, so don't claim that it is.

Author: danalbert Date: Tue Jan 8 14:31:19 2019 New Revision: 350664 URL: http://llvm.org/viewvc/llvm-project?rev=350664=rev Log: Android is not GNU, so don't claim that it is. Reviewers: pirama, srhines Reviewed By: srhines Subscribers: kristina, cfe-commits Differential Revision:

[PATCH] D55488: Add utility for dumping a label with child nodes

steveire updated this revision to Diff 180754. steveire added a comment. Replace std::string with StringRef Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55488/new/ https://reviews.llvm.org/D55488 Files: include/clang/AST/TextNodeDumper.h

r350680 - [libclang] Fix the mismatched delete operator for ExprEvalResult

Author: arphaman Date: Tue Jan 8 15:28:37 2019 New Revision: 350680 URL: http://llvm.org/viewvc/llvm-project?rev=350680=rev Log: [libclang] Fix the mismatched delete operator for ExprEvalResult The '.stringVal' field in ExprEvalResult is allocated using new[], but was freed using a regular

Re: [PATCH] D56444: [AST] RecursiveASTVisitor visits lambda classes when implicit visitation is on.

I'll take a look at the regression, thanks. As noted in the other review thread, the new unit test you linked is broken: the code snippet doesn't compile (a&&), which seems to be the cause of the crash, or at least masks it. On Tue, Jan 8, 2019, 23:20 Jonas Toth via Phabricator <

[PATCH] D56430: Incorrect implicit data-sharing for nested tasks

smateo updated this revision to Diff 180792. smateo added a comment. Renaming the `isParallelRegion` function to `isImplicitTaskingRegion`. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56430/new/ https://reviews.llvm.org/D56430 Files: lib/Sema/SemaOpenMP.cpp

Re: [PATCH] D56215: [lld] [ELF] Include default search paths for NetBSD driver

On Tue, Jan 08, 2019 at 10:58:37PM +, Alexander Richardson via Phabricator via cfe-commits wrote: > arichardson added inline comments. > > > > Comment at: ELF/Driver.cpp:770 > + // Start with a default initial triple > + Config->TargetTriple =

r350677 - [ASTDump] NFC: Move dumpDeclRef to NodeDumper

Author: steveire Date: Tue Jan 8 15:11:24 2019 New Revision: 350677 URL: http://llvm.org/viewvc/llvm-project?rev=350677=rev Log: [ASTDump] NFC: Move dumpDeclRef to NodeDumper Reviewers: aaron.ballman Subscribers: cfe-commits Differential Revision: https://reviews.llvm.org/D55337 Modified:

Re: [PATCH] D56215: [lld] [ELF] Include default search paths for NetBSD driver

On Wed, Jan 09, 2019 at 12:20:06AM +, Kamil Rytarowski via Phabricator via llvm-commits wrote: > krytarowski added inline comments. > > > > Comment at: ELF/Driver.cpp:781 > + } > +} > + > > There is need to add a fallback for a native triple. Not really.

[PATCH] D56469: [ObjC] Allow the use of implemented unavailable methods from within the @implementation context

thakis added a comment. (This would also help with https://crbug.com/917351) Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56469/new/ https://reviews.llvm.org/D56469 ___ cfe-commits mailing list

[PATCH] D56463: [SEH] Pass the frame pointer from SEH finally to finally functions

ssijaric created this revision. ssijaric added reviewers: rnk, efriedma, mstorsjo, TomTan. The following test case, compiled with -OO -target=x86_64-windows-win32, returns an incorrect value. It returns 5, when it should return 9. The problem is that the frame pointer that the first finally

[PATCH] D56466: [CodeGen] Clarify comment about COFF common symbol alignment

smeenai created this revision. smeenai added reviewers: erichkeane, majnemer, mstorsjo. After a discussion on the commit thread, it seems the 32 byte alignment limitation is an MSVC toolchain artifact, not an inherent COFF restriction. Clarify the comment accordingly, since saying COFF in the

Re: r350643 - Limit COFF 'common' emission to <=32 alignment types.

I sent out https://reviews.llvm.org/D56466 to clarify the comment accordingly. From: David Majnemer Date: Tuesday, January 8, 2019 at 3:21 PM To: Shoaib Meenai Cc: "Keane, Erich" , "cfe-commits@lists.llvm.org" , Martin Storsjo Subject: Re: r350643 - Limit COFF 'common' emission to <=32

[PATCH] D55337: NFC: Move dumpDeclRef to NodeDumper

This revision was automatically updated to reflect the committed changes. Closed by commit rC350677: [ASTDump] NFC: Move dumpDeclRef to NodeDumper (authored by steveire, committed by ). Changed prior to commit: https://reviews.llvm.org/D55337?vs=177670=180752#toc Repository: rC Clang

[PATCH] D56215: [lld] [ELF] Include default search paths for NetBSD driver

krytarowski added inline comments. Comment at: ELF/Driver.cpp:781 + } +} + There is need to add a fallback for a native triple. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56215/new/ https://reviews.llvm.org/D56215

[PATCH] D56469: [ObjC] Allow the use of implemented unavailable methods from within the @implementation context

arphaman created this revision. arphaman added a reviewer: erik.pilkington. Herald added subscribers: cfe-commits, dexonsmith, jkorous. In Objective-C, it's common for some frameworks to mark some methods like `init` as unavailable in the `@interface` to prohibit their usage. However, these

[PATCH] D56438: [Modules] Allow modulemap path change for implicitly built modules

dblaikie added a comment. No doubt @rsmith will have a more nuanced/accurate opinion on this than I do, but I would've thought the point of implicit modules is that they don't get moved around & it sounds like that's what this patch is suggesting/supporting, but maybe I haven't understood it

Re: r350643 - Limit COFF 'common' emission to <=32 alignment types.

Yes, the MinGW toolchain can handle this by specifying the alignment of a common symbol using the aligncomm directive. The MSVC toolchain has no such mechanism. This is why the check uses isKnownWindowsMSVCEnvironment. On Tue, Jan 8, 2019 at 1:09 PM Shoaib Meenai wrote: > It checks for both

[PATCH] D56466: [CodeGen] Clarify comment about COFF common symbol alignment

majnemer added inline comments. Comment at: lib/CodeGen/CodeGenModule.cpp:3765-3766 + + // MSVC doesn't support alignments greater than 32 for common symbols, so + // symbols with greater alignment requirements cannot be common. Non-MSVC COFF + // environments support

Re: r336716 - Revert r336590 "[libclang] evalute compound statement cursors before trying to evaluate"

Looks like there was another leak I missed. I'm working on fixing it now. Cheers, Alex On Tue, 8 Jan 2019 at 14:38, Alex L wrote: > Thanks for reverting the commit! Unfortunately I missed the failure back > then. > I fixed the leak and recommitted the change in r350666. > > Cheers, > Alex > >

Re: r336716 - Revert r336590 "[libclang] evalute compound statement cursors before trying to evaluate"

Fixed in r350680. On Tue, 8 Jan 2019 at 15:24, Alex L wrote: > Looks like there was another leak I missed. I'm working on fixing it now. > Cheers, > Alex > > On Tue, 8 Jan 2019 at 14:38, Alex L wrote: > >> Thanks for reverting the commit! Unfortunately I missed the failure back >> then. >> I

[PATCH] D56438: [Modules] Allow modulemap path change for implicitly built modules

yamaguchi added a comment. We have both explicitly and implicitly prebuilt modules, but this patch only relates to implicit ones. I agree that our usecase is a bit unique where we're installing and distributing implicitly built pcm, but I also imagine there might be a usecase where you built

[PATCH] D56466: [CodeGen] Clarify comment about COFF common symbol alignment

smeenai updated this revision to Diff 180771. smeenai added a comment. Refer to link.exe, and then also refer to other linkers in the second half of the comment to match Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56466/new/ https://reviews.llvm.org/D56466

[PATCH] D37035: Implement __builtin_LINE() et. al. to support source location capture.

riccibruno marked an inline comment as done. riccibruno added a comment. I have no more remark, but since I am just a new contributor to clang I am sure people will have more to say about this patch. Thanks ! Comment at: lib/AST/Expr.cpp:2091 +

[PATCH] D56405: Split -Wdelete-non-virtual-dtor into two groups

aaron.ballman added inline comments. Comment at: include/clang/Basic/DiagnosticGroups.td:108-109 def DeleteNonVirtualDtor : DiagGroup<"delete-non-virtual-dtor">; +def DeleteAbstractNonVirtualDtor : DiagGroup<"delete-abstract-non-virtual-dtor", +

[PATCH] D56430: Incorrect implicit data-sharing for nested tasks

ABataev added inline comments. Comment at: lib/Sema/SemaOpenMP.cpp:680 + +bool isParallelRegion(OpenMPDirectiveKind DKind) { + return isOpenMPParallelDirective(DKind) || isOpenMPTeamsDirective(DKind); Better to rename it to `isImplicitTaskingRegion`

[PATCH] D56438: [Modules] Allow modulemap path change for implicitly built modules

yamaguchi created this revision. yamaguchi added reviewers: rsmith, dblaikie. Previous code was comparing the location of "modulemap which is currently loaded and gives a definition of current module" and "the location of the modulemap where the current implicit module was built". This check was

r350627 - [AST][NFC] Pack CXXNoexceptExpr and SubstNonTypeTemplateParmExpr

Author: brunoricci Date: Tue Jan 8 06:44:34 2019 New Revision: 350627 URL: http://llvm.org/viewvc/llvm-project?rev=350627=rev Log: [AST][NFC] Pack CXXNoexceptExpr and SubstNonTypeTemplateParmExpr Use the newly available space in the bit-fields of Stmt. This saves one pointer per

[PATCH] D56407: Implement the TreeStructure interface through the TextNodeDumper

erichkeane added a comment. In D56407#1349672 , @aaron.ballman wrote: > I think this is a good approach to solving the problem, so let's go this > route. Yeah, I agree here. This ends up being a really clean solution. Repository: rC Clang CHANGES

[PATCH] D56391: Limit COFF 'common' emission to <=32 alignment types.

pengfei accepted this revision. pengfei added a comment. This revision is now accepted and ready to land. LGTM, thanks Erich. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56391/new/ https://reviews.llvm.org/D56391 ___ cfe-commits mailing

r350625 - [AST] Pack CXXDependentScopeMemberExpr

Author: brunoricci Date: Tue Jan 8 06:17:00 2019 New Revision: 350625 URL: http://llvm.org/viewvc/llvm-project?rev=350625=rev Log: [AST] Pack CXXDependentScopeMemberExpr Use the newly available space in the bit-fields of Stmt. Additionally store FirstQualifierFoundInScope as a trailing object

[PATCH] D56442: [clangd] Fix a crash when reading an empty index file.

hokein created this revision. hokein added a reviewer: ilya-biryukov. Herald added subscribers: kadircet, arphaman, jkorous, MaskRay, ioeric. Unfortunately, yaml::Input::setCurrentDocument() and yaml::Input::nextDocument() are internal APIs, the way we use them may cause a nullptr accessing when

[PATCH] D56050: [Sema] Diagnose array access preceding the array bounds even when the base type is incomplete.

This revision was automatically updated to reflect the committed changes. Closed by commit rL350622: [Sema] Diagnose array access preceding the array bounds even when the base type… (authored by brunoricci, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

r350622 - [Sema] Diagnose array access preceding the array bounds even when the base type is incomplete.

Author: brunoricci Date: Tue Jan 8 05:52:54 2019 New Revision: 350622 URL: http://llvm.org/viewvc/llvm-project?rev=350622=rev Log: [Sema] Diagnose array access preceding the array bounds even when the base type is incomplete. When the type of the base expression after IgnoreParenCasts is

[PATCH] D56160: [clang-tidy] modernize-use-trailing-return check

Eugene.Zelenko added inline comments. Comment at: clang-tidy/modernize/UseTrailingReturnCheck.cpp:45 +std::string(Message) + +" (no FixIt provided, function argument list end is inside macro)"); +return {}; MyDeveloperDay wrote: >

[PATCH] D56367: [AST] Pack CXXDependentScopeMemberExpr

This revision was automatically updated to reflect the committed changes. Closed by commit rC350625: [AST] Pack CXXDependentScopeMemberExpr (authored by brunoricci, committed by ). Changed prior to commit: https://reviews.llvm.org/D56367?vs=180407=180651#toc Repository: rC Clang CHANGES

  1   2   >