[PATCH] D56469: [ObjC] Allow the use of implemented unavailable methods from within the @implementation context

This revision was automatically updated to reflect the committed changes. Closed by commit rC350768: [ObjC] Allow the use of implemented unavailable methods from within (authored by arphaman, committed by ). Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56469/new/

r350768 - [ObjC] Allow the use of implemented unavailable methods from within

Author: arphaman Date: Wed Jan 9 14:31:37 2019 New Revision: 350768 URL: http://llvm.org/viewvc/llvm-project?rev=350768=rev Log: [ObjC] Allow the use of implemented unavailable methods from within the @implementation context In Objective-C, it's common for some frameworks to mark some methods

r350779 - In nothrow new-expressions, null-check the result if we're going to

Author: rsmith Date: Wed Jan 9 16:03:29 2019 New Revision: 350779 URL: http://llvm.org/viewvc/llvm-project?rev=350779=rev Log: In nothrow new-expressions, null-check the result if we're going to apply sanitizers to it. This avoids a sanitizer false positive that we are initializing a null

[PATCH] D55844: [Fixed Point Arithmetic] Fixed Point Subtraction

rjmccall added inline comments. Comment at: clang/lib/CodeGen/CGExprScalar.cpp:3451 + case BO_Comma: +llvm_unreachable("Found unimplemented fixed point binary operation"); } Please create a separate case for the non-arithmetic operators

[PATCH] D56523: Improve a -Wunguarded-availability note

erik.pilkington created this revision. erik.pilkington added a reviewer: arphaman. Herald added subscribers: dexonsmith, jkorous. Mention the deployment target, and don't say "partial" which doesn't really mean anything to users. rdar://problem/33601513 Repository: rC Clang

r350785 - [X86] Really make the pointer arguments to avx512 gather/scatter intrinsics 'void*' to match gcc and Intel's documentation.

Author: ctopper Date: Wed Jan 9 16:47:25 2019 New Revision: 350785 URL: http://llvm.org/viewvc/llvm-project?rev=350785=rev Log: [X86] Really make the pointer arguments to avx512 gather/scatter intrinsics 'void*' to match gcc and Intel's documentation. The avx2 gather intrinsics are documented

[PATCH] D56160: [clang-tidy] modernize-use-trailing-return check

bernhardmgruber marked an inline comment as done. bernhardmgruber added a comment. I spent some time now to get member pointers as return values working and I am afraid but it seems there is a problem with the clang AST. Given the following code in my check (where `F` is a `FunctionDecl`):

[PATCH] D56160: [clang-tidy] modernize-use-trailing-return check

bernhardmgruber updated this revision to Diff 180973. bernhardmgruber marked 8 inline comments as done. bernhardmgruber added a comment. - Removed detailed diagnostic messages why FixIts could not be generated - Excluded functions returning member pointers for now - All tests run now CHANGES

[PATCH] D56160: [clang-tidy] modernize-use-trailing-return check

bernhardmgruber added inline comments. Comment at: clang-tidy/modernize/UseTrailingReturnCheck.cpp:45 +std::string(Message) + +" (no FixIt provided, function argument list end is inside macro)"); +return {}; Eugene.Zelenko wrote: >

[PATCH] D56530: [X86] Add versions of the avx512 gather intrinsics that take the mask as a vXi1 vector instead of a scalar (clang side)

craig.topper created this revision. craig.topper added reviewers: spatel, RKSimon. This is the clang equivalent of D56527 https://reviews.llvm.org/D56530 Files: include/clang/Basic/BuiltinsX86.def lib/CodeGen/CGBuiltin.cpp test/CodeGen/avx512f-builtins.c

[PATCH] D56529: [X86] Add versions of the avx512 gather intrinsics that take the mask as a vXi1 vector instead of a scalar (clang side)

craig.topper abandoned this revision. craig.topper added a comment. Abandoning because i sent it to llvm-commits instead of cfe-commits. Will redo to get the right mailing list CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56529/new/ https://reviews.llvm.org/D56529

[PATCH] D56530: [X86] Add versions of the avx512 gather intrinsics that take the mask as a vXi1 vector instead of a scalar (clang side)

craig.topper marked an inline comment as done. craig.topper added inline comments. Comment at: include/clang/Basic/BuiltinsX86.def:988 TARGET_BUILTIN(__builtin_ia32_gathersiv8df, "V8dV8dvC*V8iUcIi", "nV:512:", "avx512f") -TARGET_BUILTIN(__builtin_ia32_gathersiv16sf,

[PATCH] D54188: [Sema] Mark target of __attribute__((alias("target"))) used for C

This revision was automatically updated to reflect the committed changes. nickdesaulniers marked an inline comment as done. Closed by commit rL350776: [Sema] Mark target of __attribute__((alias(target))) used for C (authored by nickdesaulniers, committed by ). Herald added a subscriber:

r350776 - [Sema] Mark target of __attribute__((alias("target"))) used for C

Author: nickdesaulniers Date: Wed Jan 9 15:54:55 2019 New Revision: 350776 URL: http://llvm.org/viewvc/llvm-project?rev=350776=rev Log: [Sema] Mark target of __attribute__((alias("target"))) used for C Summary: Prevents -Wunneeded-internal-delcaration warnings when the target has no other

[PATCH] D56411: [CUDA][HIP][Sema] Fix template kernel with function as template parameter

yaxunl updated this revision to Diff 180960. yaxunl added a comment. disable the check for more general cases. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56411/new/ https://reviews.llvm.org/D56411 Files: include/clang/Sema/Sema.h lib/Sema/SemaCUDA.cpp

[PATCH] D56525: [AMDGPU] Separate feature dot-insts

rampitec created this revision. rampitec added reviewers: b-sumner, kzhuravl, msearles. Herald added subscribers: cfe-commits, t-tye, tpr, dstuttard, yaxunl, nhaehnle, wdng, jvesely. clang part Repository: rC Clang https://reviews.llvm.org/D56525 Files:

[PATCH] D50106: [libc++] Fix tuple assignment from type derived from a tuple-like

ldionne added a comment. Herald added subscribers: libcxx-commits, jkorous. Ping! It would be nice to land this in LLVM 8 Repository: rCXX libc++ CHANGES SINCE LAST ACTION https://reviews.llvm.org/D50106/new/ https://reviews.llvm.org/D50106

[PATCH] D55483: Introduce the callback attribute and emit !callback metadata

jdoerfert updated this revision to Diff 180971. jdoerfert added a comment. Allow to use names in the callback metadata Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55483/new/ https://reviews.llvm.org/D55483 Files: include/clang/AST/ASTContext.h

[PATCH] D56525: [AMDGPU] Separate feature dot-insts

This revision was automatically updated to reflect the committed changes. Closed by commit rL350794: [AMDGPU] Separate feature dot-insts (authored by rampitec, committed by ). Changed prior to commit: https://reviews.llvm.org/D56525?vs=180969=180991#toc Repository: rL LLVM CHANGES SINCE

[PATCH] D56532: [clang-tidy] Add the abseil-duration-conversion-cast check

hwright created this revision. hwright added reviewers: hokein, aaron.ballman. hwright added a project: clang-tools-extra. Herald added subscribers: cfe-commits, xazax.hun, mgorny. This suggests simplifying expressions which are casting conversion functions, such as

[PATCH] D56504: [WebAssembly] Add simd128-unimplemented feature, gate builtins

tlively updated this revision to Diff 180989. tlively marked 3 inline comments as done. tlively added a comment. - Fix formatting, fix and test macro name Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56504/new/ https://reviews.llvm.org/D56504 Files:

[PATCH] D56504: [WebAssembly] Add simd128-unimplemented feature, gate builtins

tlively added inline comments. Comment at: lib/Basic/Targets/WebAssembly.cpp:89 +// features control availability of builtins +setSIMDLevel(Features, SIMDLevel); +if (HasNontrappingFPToInt) aheejin wrote: > Minor thing, but should we extract this as

[PATCH] D56518: Change the symbol for the default Swift CFString class.

millenomi created this revision. Herald added a subscriber: cfe-commits. Required for the work in https://github.com/apple/swift-corelibs-foundation/pull/1799 Repository: rC Clang https://reviews.llvm.org/D56518 Files: lib/CodeGen/CodeGenModule.cpp Index: lib/CodeGen/CodeGenModule.cpp

[PATCH] D54188: [Sema] Mark target of __attribute__((alias("target"))) used for C

rjmccall added a comment. Don't worry, that's a familiar mistake. :) LGTM. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54188/new/ https://reviews.llvm.org/D54188 ___ cfe-commits mailing list

[PATCH] D55492: Implement Attr dumping in terms of visitors

steveire updated this revision to Diff 180943. steveire added a comment. Updates Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55492/new/ https://reviews.llvm.org/D55492 Files: include/clang/AST/AttrVisitor.h include/clang/AST/CMakeLists.txt

[PATCH] D56522: [SemaCXX] add -Woverride-init alias to -Winitializer-overrides

rsmith accepted this revision. rsmith added inline comments. This revision is now accepted and ready to land. Comment at: include/clang/Basic/DiagnosticGroups.td:364 def InitializerOverrides : DiagGroup<"initializer-overrides">; +// -Woverride-init = -Winitializer-overrides

[PATCH] D56504: [WebAssembly] Add unimplemented-simd128 feature, gate builtins

aheejin added inline comments. Comment at: include/clang/Basic/BuiltinsWebAssembly.def:53 // Saturating fp-to-int conversions -BUILTIN(__builtin_wasm_trunc_saturate_s_i32_f32, "if", "nc") -BUILTIN(__builtin_wasm_trunc_saturate_u_i32_f32, "if", "nc")

[PATCH] D55492: Implement Attr dumping in terms of visitors

steveire marked an inline comment as done. steveire added inline comments. Comment at: utils/TableGen/ClangAttrEmitter.cpp:3726 +functionContent = SS.str(); +if (SS.tell()) { + OS << " void Visit" << R.getName() << "Attr(const " << R.getName()

[PATCH] D55491: Implement TemplateArgument dumping in terms of Visitor

steveire updated this revision to Diff 180947. steveire added a comment. Rebase Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55491/new/ https://reviews.llvm.org/D55491 Files: include/clang/AST/TemplateArgumentVisitor.h include/clang/AST/TextNodeDumper.h

[PATCH] D56522: [SemaCXX] add -Woverride-init alias to -Winitializer-overrides

nickdesaulniers created this revision. nickdesaulniers added a reviewer: rsmith. Herald added a subscriber: cfe-commits. https://bugs.llvm.org/show_bug.cgi?id=40251 https://github.com/ClangBuiltLinux/linux/issues/307 Repository: rC Clang https://reviews.llvm.org/D56522 Files:

[PATCH] D55483: Introduce the callback attribute and emit !callback metadata

jdoerfert marked 3 inline comments as done. jdoerfert added inline comments. Comment at: include/clang/Basic/Attr.td:1204 + VariadicUnsignedArgument<"PayloadIndices">]; + let Subjects = SubjectList<[Function]>; + let Documentation = [Undocumented];

[PATCH] D56525: [AMDGPU] Separate feature dot-insts

kzhuravl accepted this revision. kzhuravl added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56525/new/ https://reviews.llvm.org/D56525 ___

r350794 - [AMDGPU] Separate feature dot-insts

Author: rampitec Date: Wed Jan 9 19:25:47 2019 New Revision: 350794 URL: http://llvm.org/viewvc/llvm-project?rev=350794=rev Log: [AMDGPU] Separate feature dot-insts Differential Revision: https://reviews.llvm.org/D56525 Modified: cfe/trunk/include/clang/Basic/BuiltinsAMDGPU.def

[PATCH] D47819: [compiler-rt] [test] Support using libtirpc on Linux

mgorny planned changes to this revision. mgorny added a comment. Need to update this for the new idea of not using libtirpc at all. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D47819/new/ https://reviews.llvm.org/D47819 ___ cfe-commits

[PATCH] D56411: [CUDA][HIP][Sema] Fix template kernel with function as template parameter

yaxunl added a comment. In D56411#1351824 , @rjmccall wrote: > But why? Why do you want to limit this to just template arguments instead of > all sorts of similar contexts? I updated the patch to disable the check for unevaluated expr context and

[PATCH] D55488: Add utility for dumping a label with child nodes

steveire updated this revision to Diff 180935. steveire added a comment. Nits Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55488/new/ https://reviews.llvm.org/D55488 Files: include/clang/AST/TextNodeDumper.h lib/AST/ASTDumper.cpp

[libunwind] r350787 - Revert "[Sparc] Add Sparc V8 support"

Author: jgorbe Date: Wed Jan 9 17:08:31 2019 New Revision: 350787 URL: http://llvm.org/viewvc/llvm-project?rev=350787=rev Log: Revert "[Sparc] Add Sparc V8 support" This reverts commit r350705. Modified: libunwind/trunk/include/__libunwind_config.h libunwind/trunk/include/libunwind.h

[PATCH] D56160: [clang-tidy] modernize-use-trailing-return check

bernhardmgruber added a comment. I am satisfied with the proposed feature set for now. I will try to run the check on LLVM itself in the next days as a final test. Are there anymore feature requests or changes from your sides? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56160/new/

[PATCH] D56504: [WebAssembly] Add unimplemented-simd128 feature, gate builtins

tlively updated this revision to Diff 180984. tlively added a comment. - Match the new naming scheme from rL350791 Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56504/new/ https://reviews.llvm.org/D56504 Files:

r350792 - Refactor declarations of ASTContext allocate functions into its own header.

Author: rtrieu Date: Wed Jan 9 19:23:25 2019 New Revision: 350792 URL: http://llvm.org/viewvc/llvm-project?rev=350792=rev Log: Refactor declarations of ASTContext allocate functions into its own header. Forward declarations of the allocate functions combine with the forward declaration of the

[PATCH] D55662: [Sema] If CheckPlaceholderExpr rewrites a placeholder expression when the type of an auto variable is being deduced, use the rewritten expression when performing initialization of the

ahatanak marked an inline comment as done. ahatanak added a comment. In D55662#1349329 , @rjmccall wrote: > Oh, and please update the commit message to primarily talk about the changes > to placeholder checking. You can discuss the impact on the >

[PATCH] D56411: [CUDA][HIP][Sema] Fix template kernel with function as template parameter

rjmccall added a comment. This patch still doesn't make any sense. You don't need to do any special validation when passing a function as a template argument. When Sema instantiates the template definition, it'll rebuild the expressions that refer to the template parameter, which will

[PATCH] D56504: [WebAssembly] Add simd128-unimplemented feature, gate builtins

aheejin added inline comments. Comment at: include/clang/Basic/BuiltinsWebAssembly.def:53 // Saturating fp-to-int conversions -BUILTIN(__builtin_wasm_trunc_saturate_s_i32_f32, "if", "nc") -BUILTIN(__builtin_wasm_trunc_saturate_u_i32_f32, "if", "nc")

[clang-tools-extra] r350797 - Remove unnecessary include.

Author: rtrieu Date: Wed Jan 9 20:53:10 2019 New Revision: 350797 URL: http://llvm.org/viewvc/llvm-project?rev=350797=rev Log: Remove unnecessary include. QuerySession.h does not need anything from Query.h, so it does not need to include it. Modified:

[PATCH] D54996: [libclang] Fix clang_Cursor_isAnonymous

yvvan added a comment. Good point :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54996/new/ https://reviews.llvm.org/D54996 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D55662: [Sema] If CheckPlaceholderExpr rewrites a placeholder expression when the type of an auto variable is being deduced, use the rewritten expression when performing initialization of the

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Sounds good. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55662/new/ https://reviews.llvm.org/D55662 ___

[PATCH] D55662: [Sema] If CheckPlaceholderExpr rewrites a placeholder expression when the type of an auto variable is being deduced, use the rewritten expression when performing initialization of the

ahatanak updated this revision to Diff 180993. ahatanak retitled this revision from "[Sema][ObjC] Do not warn about repeated uses of weak variables when the variables are accessed in an unevaluated context." to "[Sema] If CheckPlaceholderExpr rewrites a placeholder expression when the type of

[PATCH] D54996: [libclang] Fix clang_Cursor_isAnonymous

nik requested changes to this revision. nik added inline comments. This revision now requires changes to proceed. Comment at: test/Index/print-type.cpp:202 // CHECK: CallExpr=Bar:17:3 [type=outer::inner::Bar] [typekind=Elaborated] [canonicaltype=outer::inner::Bar]

[PATCH] D56488: clang-cl: Align help texts for /O1 and O2

thakis created this revision. thakis added a reviewer: hans. Makes it a bit easier to see what exactly the difference is. Also use "same as" instead of "equivalent to", because that's faster to read. https://reviews.llvm.org/D56488 Files: clang/include/clang/Driver/CLCompatOptions.td

[PATCH] D56489: clang-cl: Fix help text for /O: '/O2y-' means '/O2 /Oy-', not '/O2 /y-'

thakis created this revision. thakis added a reviewer: hans. https://reviews.llvm.org/D56489 Files: clang/include/clang/Driver/CLCompatOptions.td Index: clang/include/clang/Driver/CLCompatOptions.td === ---

[PATCH] D56314: [clangd] Don't store completion info if the symbol is not used for code completion.

ilya-biryukov accepted this revision. ilya-biryukov added a comment. LGTM again :-) I bet the savings are less now that we're always storing the comments in the static index, so the numbers in the description might be outdated. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION

[PATCH] D56444: [AST] RecursiveASTVisitor visits lambda classes when implicit visitation is on.

sammccall added a comment. In D56444#1351056 , @aaron.ballman wrote: > Given that, I kind of think we should have functionDecl() match only > functions, and give users some other way to match the semantic declarations > in a consistent manner.

[PATCH] D56326: [OpenMP 5.0] Parsing/sema support for "omp declare mapper" directive

ABataev added inline comments. Comment at: lib/AST/DeclOpenMP.cpp:164 + if (NumClauses) { +Clauses = (OMPClause **)C.Allocate(sizeof(OMPClause *) * NumClauses); +setClauses(CL); No, bad idea. Use tail allocation for the clauses. Check the implementation

[PATCH] D56444: [AST] RecursiveASTVisitor visits lambda classes when implicit visitation is on.

aaron.ballman added a comment. In D56444#1351067 , @klimek wrote: > In D56444#1351056 , @aaron.ballman > wrote: > > > In D56444#1350849 , @JonasToth > > wrote: > > > > >

[PATCH] D56444: [AST] RecursiveASTVisitor visits lambda classes when implicit visitation is on.

aaron.ballman added a comment. In D56444#1351096 , @sammccall wrote: > In D56444#1351056 , @aaron.ballman > wrote: > > > Given that, I kind of think we should have functionDecl() match only > > functions, and

[PATCH] D55488: Add utility for dumping a label with child nodes

aaron.ballman added a comment. @rsmith -- do you have opinions on the new format for how we display the child node? I think this is a more clear approach, but a second opinion would be nice. Comment at: include/clang/AST/TextNodeDumper.h:43 + /// Add a child of the current

[PATCH] D56444: [AST] RecursiveASTVisitor visits lambda classes when implicit visitation is on.

steveire added a comment. In D56444#1351145 , @sammccall wrote: > In D56444#1351128 , @aaron.ballman > wrote: > > > In D56444#1351127 , @steveire > > wrote: > > > > > I

[PATCH] D56492: [clangd] Add Documentations for member completions.

hokein created this revision. hokein added a reviewer: ilya-biryukov. Herald added subscribers: kadircet, arphaman, jkorous, MaskRay, ioeric. We are missing docs for class member completion -- we don't store comments in the preamble, so Sema doesn't return any docs. To get docs for class members,

[PATCH] D56444: [AST] RecursiveASTVisitor visits lambda classes when implicit visitation is on.

steveire added a comment. In D56444#1351150 , @sammccall wrote: > In D56444#1351130 , @steveire wrote: > > > In D56444#1351125 , @aaron.ballman > > wrote: > > > > > if the

[PATCH] D56444: [AST] RecursiveASTVisitor visits lambda classes when implicit visitation is on.

klimek added a comment. In D56444#1351056 , @aaron.ballman wrote: > In D56444#1350849 , @JonasToth wrote: > > > In D56444#1350746 , @sammccall > > wrote: > > > > >

[PATCH] D55433: [clang-tidy] Adding a new modernize use nodiscard checker

MyDeveloperDay added a comment. In D55433#1350999 , @JonasToth wrote: > LGTM! > You verified that your fixes, fix the issues in LLVM? But it looks good to > go. They look good, you asked before... > P.S. did you request commit rights already? I do

r350727 - Remove dependency-related arguments in clang-check.

Author: alexfh Date: Wed Jan 9 07:00:06 2019 New Revision: 350727 URL: http://llvm.org/viewvc/llvm-project?rev=350727=rev Log: Remove dependency-related arguments in clang-check. This is the default behavior of clang tools, but clang-check overrides default argument adjusters for some reason.

[PATCH] D56444: [AST] RecursiveASTVisitor visits lambda classes when implicit visitation is on.

steveire added a comment. In D56444#1351096 , @sammccall wrote: > In D56444#1351056 , @aaron.ballman > wrote: > > > Given that, I kind of think we should have functionDecl() match only > > functions, and give

[PATCH] D56444: [AST] RecursiveASTVisitor visits lambda classes when implicit visitation is on.

steveire added a comment. In D56444#1351125 , @aaron.ballman wrote: > if the location isn't somewhere in user code, then don't consider the node or > its children for traversal. However, that may be insufficient and equally as > mysterious behavior.

[PATCH] D56444: [AST] RecursiveASTVisitor visits lambda classes when implicit visitation is on.

sammccall added a comment. In D56444#1351128 , @aaron.ballman wrote: > In D56444#1351127 , @steveire wrote: > > > I suggest not trying to make any such drastic changes for 8.0, try to fix > > the bug in a minimal

[PATCH] D56492: [clangd] Add Documentations for member completions.

hokein updated this revision to Diff 180843. hokein added a comment. Add a comment. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56492/new/ https://reviews.llvm.org/D56492 Files: clangd/CodeComplete.cpp unittests/clangd/CodeCompleteTests.cpp

[PATCH] D56314: [clangd] Don't store completion info if the symbol is not used for code completion.

hokein updated this revision to Diff 180827. hokein marked an inline comment as done. hokein added a comment. address review comments Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56314/new/ https://reviews.llvm.org/D56314 Files:

[PATCH] D56446: [Driver] Fix libcxx detection on Darwin with clang run as ./clang

ilya-biryukov added a comment. Sorry about the delay. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56446/new/ https://reviews.llvm.org/D56446 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D56444: [AST] RecursiveASTVisitor visits lambda classes when implicit visitation is on.

aaron.ballman added a comment. In D56444#1350849 , @JonasToth wrote: > In D56444#1350746 , @sammccall wrote: > > > @klimek: would it be better to preserve the odd behavior of the > > `functionDecl()` matcher, and

[PATCH] D56444: [AST] RecursiveASTVisitor visits lambda classes when implicit visitation is on.

aaron.ballman added a comment. In D56444#1351127 , @steveire wrote: > I suggest not trying to make any such drastic changes for 8.0, try to fix the > bug in a minimal way if possible, and have a more considered approach to the > future of AST Matchers

[PATCH] D56444: [AST] RecursiveASTVisitor visits lambda classes when implicit visitation is on.

steveire added a comment. In D56444#1351130 , @steveire wrote: > In D56444#1351125 , @aaron.ballman > wrote: > > > if the location isn't somewhere in user code, then don't consider the node > > or its children

[PATCH] D55781: Make CC mangling conditional on the ABI version

probinson added a comment. Herald added a subscriber: mstorsjo. Sorry for not noticing this sooner. The TL;DR is, the current patch does not affect PS4, so go ahead; but see the long version for other considerations. First, the general point: The PS4 ABI does not fit neatly into the sequential

[PATCH] D56444: [AST] RecursiveASTVisitor visits lambda classes when implicit visitation is on.

sammccall added a comment. In D56444#1351130 , @steveire wrote: > In D56444#1351125 , @aaron.ballman > wrote: > > > if the location isn't somewhere in user code, then don't consider the node > > or its children

RE: r350643 - Limit COFF 'common' emission to <=32 alignment types.

Thank you for that! From: Shoaib Meenai [mailto:smee...@fb.com] Sent: Tuesday, January 8, 2019 4:48 PM To: David Majnemer Cc: Keane, Erich ; cfe-commits@lists.llvm.org; Martin Storsjo Subject: Re: r350643 - Limit COFF 'common' emission to <=32 alignment types. I sent out

[PATCH] D56430: Incorrect implicit data-sharing for nested tasks

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. In D56430#1350706 , @smateo wrote: > Renaming the `isParallelRegion` function to `isImplicitTaskingRegion`. > > Shall we rename the

r350724 - Fix typo in comment

Author: nico Date: Wed Jan 9 06:19:16 2019 New Revision: 350724 URL: http://llvm.org/viewvc/llvm-project?rev=350724=rev Log: Fix typo in comment Modified: cfe/trunk/include/clang/Sema/Sema.h Modified: cfe/trunk/include/clang/Sema/Sema.h URL:

[PATCH] D55224: [clangd] Introduce loading of shards within auto-index

ilya-biryukov added inline comments. Comment at: clangd/SourceCode.h:21 #include "clang/Tooling/Core/Replacement.h" +#include "llvm/Support/Path.h" #include "llvm/Support/SHA1.h" Looks redundant. Remove? Comment at:

[libunwind] r350705 - [Sparc] Add Sparc V8 support

Author: dcederman Date: Wed Jan 9 04:06:05 2019 New Revision: 350705 URL: http://llvm.org/viewvc/llvm-project?rev=350705=rev Log: [Sparc] Add Sparc V8 support Summary: Adds the register class implementation for Sparc. Adds support for DW_CFA_GNU_window_save. Adds save and restore context

[PATCH] D56444: [AST] RecursiveASTVisitor visits lambda classes when implicit visitation is on.

steveire added a comment. In D56444#1350946 , @JonasToth wrote: > Should still be fixed for 8.0 (probably with this patch). The refactoring is > more realistic to land in 9.0 i guess? That's why I said timing is unfortunate :). Repository: rC Clang

Re: r346652 - Make clang-based tools find libc++ on MacOS

Glad to help. The fix has landed. Let me know if the problem persists after it's integrated. On Tue, Jan 8, 2019 at 7:36 PM Nico Weber wrote: > That looks like it should help. Thanks for the quick fix! > > On Tue, Jan 8, 2019 at 1:11 PM Ilya Biryukov wrote: > >> Hi Nico, >> >> This is clearly

[PATCH] D56323: [clang-tidy] Handle member variables in readability-simplify-boolean-expr

JonasToth added a comment. @LegalizeAdulthood your stuck on the commit right things right? If you want I can commit for you (maybe even later) as you said you are limited on time. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56323/new/ https://reviews.llvm.org/D56323

[PATCH] D56424: [clang-tidy] Add check for underscores in googletest names.

hokein added inline comments. Comment at: clang-tidy/google/AvoidUnderscoreInGoogletestNameCheck.cpp:27 +static bool isGoogletestTestMacro(StringRef MacroName) { + static const llvm::StringSet<> MacroNames = {"TEST", "TEST_F", "TEST_P", +

[PATCH] D55948: Modify DeclaratorChuck::getFunction to use DeclSpec for qualifiers

This revision was automatically updated to reflect the committed changes. Closed by commit rC350703: Use DeclSpec for quals in DeclaratorChunk::FunctionTypeInfo. (authored by stulova, committed by ). Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55948/new/

[PATCH] D56444: [AST] RecursiveASTVisitor visits lambda classes when implicit visitation is on.

JonasToth added a comment. In D56444#1350897 , @steveire wrote: > The timing of this is unfortunate because the change will not be needed soon. > Refactoring is underway to extract a generic traverser from ASTDumper. Then > the parent/child traversal of

[PATCH] D56446: [Driver] Fix libcxx detection on Darwin with clang run as ./clang

This revision was automatically updated to reflect the committed changes. Closed by commit rC350714: [Driver] Fix libcxx detection on Darwin with clang run as ./clang (authored by ibiryukov, committed by ). Changed prior to commit: https://reviews.llvm.org/D56446?vs=180691=180822#toc

[clang-tools-extra] r350715 - Fix clang-tidy test after r350714. NFC

Author: ibiryukov Date: Wed Jan 9 05:08:31 2019 New Revision: 350715 URL: http://llvm.org/viewvc/llvm-project?rev=350715=rev Log: Fix clang-tidy test after r350714. NFC Added: clang-tools-extra/trunk/test/clang-tidy/Inputs/mock-libcxx/bin/

[PATCH] D56314: [clangd] Don't store completion info if the symbol is not used for code completion.

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM Comment at: clangd/index/Index.h:188 /// candidate list. For example, "(X x, Y y) const" is a function signature. + /// This field is only meaningful

[PATCH] D56483: [clangd] Add a test for SignatureHelp on dynamic index.

This revision was automatically updated to reflect the committed changes. Closed by commit rL350720: [clangd] Add a test for SignatureHelp on dynamic index. (authored by hokein, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINCE LAST ACTION

[clang-tools-extra] r350720 - [clangd] Add a test for SignatureHelp on dynamic index.

Author: hokein Date: Wed Jan 9 05:42:03 2019 New Revision: 350720 URL: http://llvm.org/viewvc/llvm-project?rev=350720=rev Log: [clangd] Add a test for SignatureHelp on dynamic index. Summary: This would catch regressions caused by future changes of the index. Reviewers: ilya-biryukov

[PATCH] D56483: [clangd] Add a test for SignatureHelp on dynamic index.

hokein created this revision. hokein added a reviewer: ilya-biryukov. Herald added subscribers: kadircet, arphaman, jkorous, MaskRay, ioeric. This would catch regressions caused by future changes of the index. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D56483 Files:

[PATCH] D55224: [clangd] Introduce loading of shards within auto-index

ilya-biryukov added inline comments. Comment at: clangd/index/Background.cpp:259 + // if this thread sees the older version but finishes later. This should + // be rare in practice. + DigestIt.first->second = Hash; kadircet wrote: > ilya-biryukov

[PATCH] D55224: [clangd] Introduce loading of shards within auto-index

ilya-biryukov added inline comments. Comment at: clangd/SourceCode.h:107 +// "/tmp/build/foo.h" +std::string makeCanonicalPath(llvm::StringRef AbsolutePath, + const SourceManager ); This changes should go away after the rebase,

[PATCH] D56314: [clangd] Don't store completion info if the symbol is not used for code completion.

hokein updated this revision to Diff 180808. hokein marked 2 inline comments as done. hokein added a comment. Address comments, store docs. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56314/new/ https://reviews.llvm.org/D56314 Files:

[PATCH] D56314: [clangd] Don't store completion info if the symbol is not used for code completion.

hokein added inline comments. Comment at: clangd/index/SymbolCollector.cpp:543 + + if (!(S.Flags & Symbol::IndexedForCodeCompletion)) +return Insert(S); ilya-biryukov wrote: > hokein wrote: > > ilya-biryukov wrote: > > > Most of the fields updated at the

r350703 - Use DeclSpec for quals in DeclaratorChunk::FunctionTypeInfo.

Author: stulova Date: Wed Jan 9 03:25:09 2019 New Revision: 350703 URL: http://llvm.org/viewvc/llvm-project?rev=350703=rev Log: Use DeclSpec for quals in DeclaratorChunk::FunctionTypeInfo. Rather than duplicating data fields, use DeclSpec directly to store the qualifiers for the

[PATCH] D56444: [AST] RecursiveASTVisitor visits lambda classes when implicit visitation is on.

sammccall added a comment. In D56444#1350897 , @steveire wrote: > The timing of this is unfortunate because the change will not be needed soon. RecursiveASTVisitor should be fixed (even if it won't be used for the parent map) unless it's going away

[PATCH] D56444: [AST] RecursiveASTVisitor visits lambda classes when implicit visitation is on.

steveire added a comment. In D56444#1350935 , @sammccall wrote: > In D56444#1350897 , @steveire wrote: > > > > > > I'm not inclined to hold off fixing this bug though, because: > > - it's blocking other patches,

[PATCH] D55224: [clangd] Introduce loading of shards within auto-index

kadircet added a comment. There seems to be no unexpected changes after rebase Comment at: clangd/index/Background.cpp:259 + // if this thread sees the older version but finishes later. This should + // be rare in practice. + DigestIt.first->second = Hash;

[PATCH] D56483: [clangd] Add a test for SignatureHelp on dynamic index.

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. Many thanks! Should've been there from the start, sorry about the inconvenience Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION

[PATCH] D56062: [compiler-rt] [test] Detect glibc-2.27+ and XFAIL appropriate tests

This revision was automatically updated to reflect the committed changes. Closed by commit rCRT350717: [test] Detect glibc-2.27+ and XFAIL appropriate tests (authored by mgorny, committed by ). Changed prior to commit: https://reviews.llvm.org/D56062?vs=179456=180824#toc Repository: rCRT

  1   2   >