[clang-tools-extra] r350803 - [clangd] Don't store completion info if the symbol is not used for code completion.

Author: hokein Date: Thu Jan 10 01:22:40 2019 New Revision: 350803 URL: http://llvm.org/viewvc/llvm-project?rev=350803=rev Log: [clangd] Don't store completion info if the symbol is not used for code completion. Summary: This would save us some memory and disk space: - Dex usage (261 MB vs

[PATCH] D56314: [clangd] Don't store completion info if the symbol is not used for code completion.

This revision was automatically updated to reflect the committed changes. Closed by commit rL350803: [clangd] Dont store completion info if the symbol is not used for code… (authored by hokein, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINCE LAST

[PATCH] D54996: [libclang] Fix clang_Cursor_isAnonymous

This revision was automatically updated to reflect the committed changes. Closed by commit rL350805: [libclang] Fix clang_Cursor_isAnonymous (authored by yvvan, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D54071: [Bug 39548][Clang] PGO bootstrap fails with python3: errors in perf-helper.py

serge-sans-paille added a comment. @Romain-Geissler-1A sure thing. Can you rebase your patch on master first? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54071/new/ https://reviews.llvm.org/D54071 ___ cfe-commits

r350805 - [libclang] Fix clang_Cursor_isAnonymous

Author: yvvan Date: Thu Jan 10 01:34:44 2019 New Revision: 350805 URL: http://llvm.org/viewvc/llvm-project?rev=350805=rev Log: [libclang] Fix clang_Cursor_isAnonymous Use the same logic as in TypePrinter::printTag to determine that the tag is anonymous and the separate check for namespaces.

[PATCH] D54996: [libclang] Fix clang_Cursor_isAnonymous

yvvan updated this revision to Diff 181005. yvvan added a comment. Replace the absolute path with {{.*}} to be independent from the machine. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54996/new/ https://reviews.llvm.org/D54996 Files: test/Index/print-type.cpp

[PATCH] D56492: [clangd] Add Documentations for member completions.

hokein updated this revision to Diff 181009. hokein marked 3 inline comments as done. hokein added a comment. Address comments. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56492/new/ https://reviews.llvm.org/D56492 Files:

r350817 - Correct the spelling of helpURI to helpUri.

Author: aaronballman Date: Thu Jan 10 05:19:48 2019 New Revision: 350817 URL: http://llvm.org/viewvc/llvm-project?rev=350817=rev Log: Correct the spelling of helpURI to helpUri. JSON is case sensitive and the SARIF spec uses the corrected spelling. Modified:

[PATCH] D56540: [clangd] Clean the cache of file statuses on vscode-clangd when clangd crashes.

hokein created this revision. hokein added a reviewer: ilya-biryukov. Herald added subscribers: kadircet, arphaman, jkorous, MaskRay, ioeric. Clear the cached file statuses, otherwise We will leave some garbage texts on the status bar when clangd crashes. Repository: rCTE Clang Tools Extra

[PATCH] D56509: [AST] Remove ASTContext from getThisType (NFC)

mikael accepted this revision. mikael added a comment. This revision is now accepted and ready to land. The changes looks good to me. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56509/new/ https://reviews.llvm.org/D56509

[PATCH] D55224: [clangd] Introduce loading of shards within auto-index

ilya-biryukov added inline comments. Comment at: clangd/URI.h:131 +/// Resolves URI to file paths with cache. +class URIToFileCache { +public: Maybe move it into the `Backgroud.cpp`, e.g. as a private member of `BackoundIndex`? We don't have other use-case for

[PATCH] D55224: [clangd] Introduce loading of shards within auto-index

ilya-biryukov added a comment. As discussed offline, let's remove the parts of the change that were aiming to fix the consistency issues, the issues were there before this patch, the fix is getting complicated and doesn't really solve all of the problems. All of that suggests it's out of scope

[PATCH] D55224: [clangd] Introduce loading of shards within auto-index

kadircet updated this revision to Diff 181044. kadircet marked 10 inline comments as done. kadircet added a comment. Address comments & revert last changes Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55224/new/ https://reviews.llvm.org/D55224

[PATCH] D50106: [libc++] Fix tuple assignment from type derived from a tuple-like

EricWF requested changes to this revision. EricWF added a comment. This revision now requires changes to proceed. Our constructors still have the same bug,. Are you planning on fixing those as well? Doing so will require a metric butt-tonne of overloads. If you're not planning on fixing the

[PATCH] D54945: This commit adds a chapter about clang-tidy integrations

MarinaKalashina updated this revision to Diff 181018. MarinaKalashina added a comment. Extracting 'Getting Involved' and 'Clang-tidy integrations' to separate pages linked in See Also. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54945/new/ https://reviews.llvm.org/D54945 Files:

[PATCH] D56492: [clangd] Add Documentations for member completions.

sammccall added a comment. I think the design should be more thoroughly considered here. - what are the latency consequences of the extra index lookup in different scenarios? - how does this compare to doing it at LSP resolve time instead? - if we're going to do the extra lookup, can we make

[PATCH] D56160: [clang-tidy] modernize-use-trailing-return check

bernhardmgruber updated this revision to Diff 181015. bernhardmgruber added a comment. rebased on current master (there was a conflict in the release notes) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56160/new/ https://reviews.llvm.org/D56160 Files:

[PATCH] D56411: [CUDA][HIP][Sema] Fix template kernel with function as template parameter

yaxunl added a comment. In D56411#1352332 , @rjmccall wrote: > This patch still doesn't make any sense. You don't need to do any special > validation when passing a function as a template argument. When Sema > instantiates the template definition,

[PATCH] D56539: [clangd] Drop documentation in static index if symbols are not indexed for completion.

hokein created this revision. hokein added a reviewer: ilya-biryukov. Herald added subscribers: kadircet, arphaman, jkorous, MaskRay, ioeric. This is a further optimization of r350803, we drop docs in static index for symbols not being indexed for completion, while keeping the docs in dynamic

[PATCH] D54945: This commit adds a chapter about clang-tidy integrations

MarinaKalashina added a comment. @alexfh Thank you, please see the updated structure. @Eugene.Zelenko Done, the only warnings I got were about the table rows width. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54945/new/ https://reviews.llvm.org/D54945

[clang-tools-extra] r350814 - [clang-tidy] Fix case of local variables in modernize-use-nodiscard checker

Author: jonastoth Date: Thu Jan 10 03:56:44 2019 New Revision: 350814 URL: http://llvm.org/viewvc/llvm-project?rev=350814=rev Log: [clang-tidy] Fix case of local variables in modernize-use-nodiscard checker Summary: Correct the case of the local variables.. Rational: I want to be able to run

[PATCH] D56444: [AST] RecursiveASTVisitor visits lambda classes when implicit visitation is on.

klimek added a comment. Just in general, I'd like to add that my experience over the years dealing with folks trying to do AST matchers is that the inability to express something is much more of a problem than matching too much, simply because the test cases people think of are usually small,

[PATCH] D56523: Improve a -Wunguarded-availability note

jkorous added a reviewer: jkorous. jkorous added a comment. Hi Erik, this looks neat! Comment at: clang/test/Sema/availability-guard-format.mm:6 @interface foo -- (void) method_bar __attribute__((availability(macosx, introduced = 10_12))); // expected-note {{'method_bar' has

[PATCH] D51641: [VFS] Cache the current working directory for the real FS.

sammccall added a comment. In D51641#1351283 , @labath wrote: > I wholeheartedly support an openat(2) based VFS, as the current one falls > short of the expectations you have of it and is pretty broken right now. Let me bait-and-switch then... D56545

[PATCH] D50766: Fix false positive unsequenced access and modification warning in array subscript expression.

stryku added a comment. Hi again, since I don't have commit rights, could you please merge this patch into the project sources? Thanks in advance. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D50766/new/ https://reviews.llvm.org/D50766

[PATCH] D51641: [VFS] Cache the current working directory for the real FS.

labath added a comment. In D51641#1352782 , @sammccall wrote: > > In fact, it still happens now, because the VFS is so bad at having a local > > CWD. So, the only reason we actually discovered this was because > > VFS->getCurrentWorkingDirectory

[PATCH] D53928: Enable builtins necessary for SLEEF [AArch64] vectorized trigonometry libm functions

steleman added a comment. Ping! Yes, I know, everyone was away for the holidays. :-) Could someone please take a look at this. We'd like to make sure everything is OK on this side before D53927 can proceed. Yes, it's a bit of a circular dependency in that

[PATCH] D56160: [clang-tidy] modernize-use-trailing-return check

bernhardmgruber updated this revision to Diff 181051. bernhardmgruber added a comment. Fixed a warning when building with gcc. Added -fdeclspec when running tests to let them compile on Linux as well. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56160/new/

Re: r350776 - [Sema] Mark target of __attribute__((alias("target"))) used for C

Aren't C names sometimes slightly mangled too? For example, on macOS they're prefixed by a _, doesn't that have to be undone there? On Wed, Jan 9, 2019 at 6:58 PM Nick Desaulniers via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: nickdesaulniers > Date: Wed Jan 9 15:54:55 2019 >

[PATCH] D53199: Fix the behavior of clang's -w flag.

jyknight added a comment. Ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53199/new/ https://reviews.llvm.org/D53199 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D55492: Implement Attr dumping in terms of visitors

aaron.ballman added inline comments. Comment at: include/clang/AST/TextNodeDumper.h:187 + +// Implements Visit methods for Attrs +#include "clang/AST/AttrTextNodeDump.inc" Add a full stop to the end of the comment. Comment at:

[PATCH] D56215: [lld] [ELF] Include default search paths for NetBSD driver

krytarowski added a comment. @joerg if you think that this patch is OK, please click accept so we can be aware that this is what you want. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56215/new/ https://reviews.llvm.org/D56215 ___

[PATCH] D56225: [HIP] Use nul instead of /dev/null when running on windows

yaxunl marked an inline comment as done. yaxunl added inline comments. Comment at: lib/Driver/ToolChains/HIP.cpp:210 std::string BundlerTargetArg = "-targets=host-x86_64-unknown-linux"; - std::string BundlerInputArg = "-inputs=/dev/null"; + std::string BundlerInputArg =

[PATCH] D55488: Add utility for dumping a label with child nodes

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. Aside from cosmetic nits, this LGTM. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55488/new/ https://reviews.llvm.org/D55488

[PATCH] D56318: [HIP] Fix size_t for MSVC environment

yaxunl added a comment. In D56318#1346991 , @rjmccall wrote: > Okay. Is there a reasonable way to make your targets delegate to a different > `TargetInfo` implementation for most things so that you can generally match > the host target for things like

[PATCH] D55491: Implement TemplateArgument dumping in terms of Visitor

aaron.ballman added inline comments. Comment at: include/clang/AST/TemplateArgumentVisitor.h:23 + +template struct make_ref { using type = T &; }; +template struct make_const_ref { using type = const T &; }; `std::add_lvalue_reference<>` already does this, so

[PATCH] D55224: [clangd] Introduce loading of shards within auto-index

ilya-biryukov added a comment. Only one important comment about bringing back the comment. Comment at: clangd/index/Background.cpp:224 +auto NeedsReIndexing = loadShards(std::move(ChangedFiles)); +// Run indexing for files that needs to be updated. +

[PATCH] D56405: Split -Wdelete-non-virtual-dtor into two groups

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56405/new/ https://reviews.llvm.org/D56405 ___ cfe-commits mailing

[PATCH] D56441: [analyzer][CrossTU][NFC] Generalize to external definitions instead of external functions

r.stahl updated this revision to Diff 181073. r.stahl added a comment. addressed review comments Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56441/new/ https://reviews.llvm.org/D56441 Files: include/clang/Basic/DiagnosticCrossTUKinds.td

[PATCH] D55224: [clangd] Introduce loading of shards within auto-index

kadircet updated this revision to Diff 181072. kadircet marked 2 inline comments as done. kadircet added a comment. Address comments Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55224/new/ https://reviews.llvm.org/D55224 Files:

[PATCH] D55224: [clangd] Introduce loading of shards within auto-index

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE350847: [clangd] Introduce loading of shards within auto-index (authored by kadircet, committed by ). Changed prior to commit: https://reviews.llvm.org/D55224?vs=181072=181075#toc Repository: rCTE

[clang-tools-extra] r350847 - [clangd] Introduce loading of shards within auto-index

Author: kadircet Date: Thu Jan 10 09:03:04 2019 New Revision: 350847 URL: http://llvm.org/viewvc/llvm-project?rev=350847=rev Log: [clangd] Introduce loading of shards within auto-index Summary: Whenever a change happens on a CDB, load shards associated with that CDB before issuing re-index

[PATCH] D56532: [clang-tidy] Add the abseil-duration-conversion-cast check

MyDeveloperDay added a comment. nit's come from running running validate_check.py on the rst file from D55523: [clang-tidy] Linting .rst documentation $ ../clang-tidy/validate_check.py --rst abseil-duration-conversion-cast.rst Checking

r350852 - [analyzer][CrossTU][NFC] Generalize to external definitions instead of external functions

Author: r.stahl Date: Thu Jan 10 09:44:04 2019 New Revision: 350852 URL: http://llvm.org/viewvc/llvm-project?rev=350852=rev Log: [analyzer][CrossTU][NFC] Generalize to external definitions instead of external functions Summary: This is just changing naming and documentation to be general about

[PATCH] D56441: [analyzer][CrossTU][NFC] Generalize to external definitions instead of external functions

This revision was automatically updated to reflect the committed changes. Closed by commit rL350852: [analyzer][CrossTU][NFC] Generalize to external definitions instead of external… (authored by r.stahl, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

Re: r350776 - [Sema] Mark target of __attribute__((alias("target"))) used for C

On Thu, Jan 10, 2019 at 7:26 AM Nico Weber wrote: > > Aren't C names sometimes slightly mangled too? For example, on macOS they're > prefixed by a _, doesn't that have to be undone there? Sure, but short of instantiating a demangler in Sema or rewriting how Clang checks for unused variables,

[PATCH] D56444: [AST] RecursiveASTVisitor visits lambda classes when implicit visitation is on.

sammccall added a comment. (Sorry, I forgot to mention: the corresponding clang-tidy fix is in D56552 - I didn't manage to switch to monorepo yet :-/) Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56444/new/

r350864 - [analyzer] [RetainCountChecker] [NFC] Remove SummaryLog

Author: george.karpenkov Date: Thu Jan 10 10:15:17 2019 New Revision: 350864 URL: http://llvm.org/viewvc/llvm-project?rev=350864=rev Log: [analyzer] [RetainCountChecker] [NFC] Remove SummaryLog The complicated machinery for passing the summary log around is actually only used for one thing! To

r350866 - [analyzer] [NFC] Reverse the argument order for "diff" in tests

Author: george.karpenkov Date: Thu Jan 10 10:15:44 2019 New Revision: 350866 URL: http://llvm.org/viewvc/llvm-project?rev=350866=rev Log: [analyzer] [NFC] Reverse the argument order for "diff" in tests The current argument order has "expected" and "actual" the wrong way around, so that the diff

r350869 - [analyzer] Update the category name for RetainCountChecker reports

Author: george.karpenkov Date: Thu Jan 10 10:16:25 2019 New Revision: 350869 URL: http://llvm.org/viewvc/llvm-project?rev=350869=rev Log: [analyzer] Update the category name for RetainCountChecker reports ..now that it includes OSObjects rdar://46509986 Differential Revision:

r350868 - [analyzer] [NFC] [RetainCountChecker] Remove dead unused map

Author: george.karpenkov Date: Thu Jan 10 10:16:10 2019 New Revision: 350868 URL: http://llvm.org/viewvc/llvm-project?rev=350868=rev Log: [analyzer] [NFC] [RetainCountChecker] Remove dead unused map Differential Revision: https://reviews.llvm.org/D56402 Modified:

[PATCH] D56523: Improve a -Wunguarded-availability note

erik.pilkington marked an inline comment as done. erik.pilkington added inline comments. Comment at: clang/test/Sema/availability-guard-format.mm:6 @interface foo -- (void) method_bar __attribute__((availability(macosx, introduced = 10_12))); // expected-note {{'method_bar'

[PATCH] D55491: Implement TemplateArgument dumping in terms of Visitor

aaron.ballman added inline comments. Comment at: lib/AST/ASTDumper.cpp:449-450 +void VisitPackTemplateArgument(const TemplateArgument ) { + for (TemplateArgument::pack_iterator I = TA.pack_begin(), + E = TA.pack_end(); +

[PATCH] D56405: Split -Wdelete-non-virtual-dtor into two groups

This revision was automatically updated to reflect the committed changes. Closed by commit rC350856: Split -Wdelete-non-virtual-dtor into two groups (authored by epilk, committed by ). Changed prior to commit: https://reviews.llvm.org/D56405?vs=180690=181081#toc Repository: rC Clang

[PATCH] D56444: [AST] RecursiveASTVisitor visits lambda classes when implicit visitation is on.

sammccall added a reviewer: ilya-biryukov. sammccall added a comment. In D56444#1351714 , @JonasToth wrote: > @sammccall I (hopefully) fixed the type-issue in my test-cases. They > nevertheless fail both on me, on latest llvm+clang+your patch. Clang-tidy

[PATCH] D56552: [clang-tidy] update FunctionSizeCheck for D56444

sammccall created this revision. sammccall added reviewers: JonasToth, aaron.ballman. Herald added subscribers: cfe-commits, xazax.hun. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D56552 Files: clang-tidy/readability/FunctionSizeCheck.cpp Index:

r350861 - [analyzer] [RetainCountChecker] Remove redundant enum UnarySummaryKind

Author: george.karpenkov Date: Thu Jan 10 10:14:38 2019 New Revision: 350861 URL: http://llvm.org/viewvc/llvm-project?rev=350861=rev Log: [analyzer] [RetainCountChecker] Remove redundant enum UnarySummaryKind Differential Revision: https://reviews.llvm.org/D56072 Modified:

r350865 - [analyzer] [NFC] Reduce redundancy in RetainSummaryManager by using a function

Author: george.karpenkov Date: Thu Jan 10 10:15:30 2019 New Revision: 350865 URL: http://llvm.org/viewvc/llvm-project?rev=350865=rev Log: [analyzer] [NFC] Reduce redundancy in RetainSummaryManager by using a function Differential Revision: https://reviews.llvm.org/D56282 Modified:

r350859 - [analyzer] [RetainCountChecker] [NFC] Remove redundant enum items *Msg, as the object type is already communicated by a separate field

Author: george.karpenkov Date: Thu Jan 10 10:14:12 2019 New Revision: 350859 URL: http://llvm.org/viewvc/llvm-project?rev=350859=rev Log: [analyzer] [RetainCountChecker] [NFC] Remove redundant enum items *Msg, as the object type is already communicated by a separate field Differential Revision:

r350862 - [analyzer] [RetainCountChecker] [NFC] Refactor the way attributes are handled

Author: george.karpenkov Date: Thu Jan 10 10:14:51 2019 New Revision: 350862 URL: http://llvm.org/viewvc/llvm-project?rev=350862=rev Log: [analyzer] [RetainCountChecker] [NFC] Refactor the way attributes are handled Make sure all checks for attributes go through a centralized function, which

r350863 - [analyzer] [RetainCountChecker] [NFC] Another minor cleanup

Author: george.karpenkov Date: Thu Jan 10 10:15:04 2019 New Revision: 350863 URL: http://llvm.org/viewvc/llvm-project?rev=350863=rev Log: [analyzer] [RetainCountChecker] [NFC] Another minor cleanup Differential Revision: https://reviews.llvm.org/D56224 Modified:

r350860 - [analyzer] [RetainCountChecker] Remove obsolete "MakeCollectable" enum value

Author: george.karpenkov Date: Thu Jan 10 10:14:25 2019 New Revision: 350860 URL: http://llvm.org/viewvc/llvm-project?rev=350860=rev Log: [analyzer] [RetainCountChecker] Remove obsolete "MakeCollectable" enum value Differential Revision: https://reviews.llvm.org/D56071 Modified:

[PATCH] D55224: [clangd] Introduce loading of shards within auto-index

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM. Ship it! Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55224/new/ https://reviews.llvm.org/D55224

[PATCH] D55491: Implement TemplateArgument dumping in terms of Visitor

steveire marked an inline comment as done. steveire added inline comments. Comment at: lib/AST/ASTDumper.cpp:449-450 +void VisitPackTemplateArgument(const TemplateArgument ) { + for (TemplateArgument::pack_iterator I = TA.pack_begin(), +

[PATCH] D56318: [HIP] Fix size_t for MSVC environment

rjmccall added a comment. If I was only concerned about `size_t`, your current solution would be fine. My concern is that you really need to match *all* of the associated CPU target's ABI choices, so your target really ought to be forwarding everything to that target by default and only

r350856 - Split -Wdelete-non-virtual-dtor into two groups

Author: epilk Date: Thu Jan 10 10:03:07 2019 New Revision: 350856 URL: http://llvm.org/viewvc/llvm-project?rev=350856=rev Log: Split -Wdelete-non-virtual-dtor into two groups This group controls two diagnostics: deleting an abstract class with a non-virtual dtor, which is a guaranteed crash, and

r350858 - [analyzer] [NFC] Track object type with ArgEffect in RetainCountChecker.

Author: george.karpenkov Date: Thu Jan 10 10:13:59 2019 New Revision: 350858 URL: http://llvm.org/viewvc/llvm-project?rev=350858=rev Log: [analyzer] [NFC] Track object type with ArgEffect in RetainCountChecker. This would be needed in the future. https://reviews.llvm.org/D56040 Modified:

r350857 - [analyzer] [NFC] Move ObjKind into a separate top-level enum in RetainSummaryManager.

Author: george.karpenkov Date: Thu Jan 10 10:13:46 2019 New Revision: 350857 URL: http://llvm.org/viewvc/llvm-project?rev=350857=rev Log: [analyzer] [NFC] Move ObjKind into a separate top-level enum in RetainSummaryManager. Allows using it in future outside of RetEffect. Differential Revision:

[PATCH] D56225: [HIP] Use nul instead of /dev/null when running on windows

rjmccall accepted this revision. rjmccall added inline comments. This revision is now accepted and ready to land. Comment at: lib/Driver/ToolChains/HIP.cpp:210 std::string BundlerTargetArg = "-targets=host-x86_64-unknown-linux"; - std::string BundlerInputArg =

r350874 - Fix false positive unsequenced access and modification warning in array subscript expression.

Author: rakete Date: Thu Jan 10 11:03:33 2019 New Revision: 350874 URL: http://llvm.org/viewvc/llvm-project?rev=350874=rev Log: Fix false positive unsequenced access and modification warning in array subscript expression. Summary: In the [expr.sub] p1, we can read that for a given E1[E2],

[PATCH] D56522: [SemaCXX] add -Woverride-init alias to -Winitializer-overrides

nickdesaulniers updated this revision to Diff 181108. nickdesaulniers added a comment. - add gcc compat comment Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56522/new/ https://reviews.llvm.org/D56522 Files: docs/DiagnosticsReference.rst

[PATCH] D50766: Fix false positive unsequenced access and modification warning in array subscript expression.

This revision was automatically updated to reflect the committed changes. Closed by commit rC350874: Fix false positive unsequenced access and modification warning in array… (authored by Rakete, committed by ). Repository: rC Clang CHANGES SINCE LAST ACTION

[PATCH] D56523: Improve a -Wunguarded-availability note

dexonsmith added inline comments. Comment at: clang/test/Sema/availability-guard-format.mm:6 @interface foo -- (void) method_bar __attribute__((availability(macosx, introduced = 10_12))); // expected-note {{'method_bar' has been explicitly marked partial here}} +- (void)

r350877 - [SemaCXX] add -Woverride-init alias to -Winitializer-overrides

Author: nickdesaulniers Date: Thu Jan 10 11:12:39 2019 New Revision: 350877 URL: http://llvm.org/viewvc/llvm-project?rev=350877=rev Log: [SemaCXX] add -Woverride-init alias to -Winitializer-overrides Summary: https://bugs.llvm.org/show_bug.cgi?id=40251

[PATCH] D56066: [OpenCL] Address space for default class members

Anastasia updated this revision to Diff 181112. Anastasia added a comment. Modified conversion sequence to perform address space conversion after temporary materialization conversion. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56066/new/ https://reviews.llvm.org/D56066 Files:

[PATCH] D56066: [OpenCL] Address space for default class members

Anastasia updated this revision to Diff 181114. Anastasia added a comment. Removed FIXME that this patch fixes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56066/new/ https://reviews.llvm.org/D56066 Files: include/clang/Sema/Sema.h lib/AST/Expr.cpp lib/CodeGen/CGCall.cpp

[PATCH] D49466: Initial implementation of -fmacro-prefix-map and -ffile-prefix-map

dankm added a comment. In D49466#1296790 , @ChristophBerg wrote: > PostgreSQL 11 is now using LLVM to do JITing of SQL expressions. We'd need > this feature to strip the build directory off the .bc bitcode files so the > .deb packages build

[PATCH] D49466: Initial implementation of -fmacro-prefix-map and -ffile-prefix-map

dankm added inline comments. Comment at: lib/Lex/PPMacroExpansion.cpp:1460 + for (const auto : MacroPrefixMap) +if (Path.startswith(Entry.first)) + return (Twine(Entry.second) + Path.substr(Entry.first.size())).str(); Lekensteyn wrote: > joerg wrote:

[PATCH] D56066: [OpenCL] Address space for default class members

rjmccall added inline comments. Comment at: lib/AST/Expr.cpp:1618 assert(getValueKindForType(Ty) == Expr::getValueKindForType(SETy)); -if (!isGLValue()) +if (!isGLValue() && !getSubExpr()->isXValue()) { Ty = Ty->getPointeeType(); What's this

[PATCH] D54945: This commit adds a chapter about clang-tidy integrations

Eugene.Zelenko added inline comments. Comment at: docs/clang-tidy/integrations.rst:118 +allows to use a custom :program:`clang-tidy` binary. \ No newline at end of file Please add newline. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54945/new/

[PATCH] D56402: [analyzer] [NFC] [RetainCountChecker] Remove dead unused map

This revision was automatically updated to reflect the committed changes. Closed by commit rC350868: [analyzer] [NFC] [RetainCountChecker] Remove dead unused map (authored by george.karpenkov, committed by ). Herald added a subscriber: cfe-commits. Changed prior to commit:

[PATCH] D56318: [HIP] Fix size_t for MSVC environment

yaxunl added a comment. In D56318#1352962 , @rjmccall wrote: > If I was only concerned about `size_t`, your current solution would be fine. > My concern is that you really need to match *all* of the associated CPU > target's ABI choices, so your target

[PATCH] D56444: [AST] RecursiveASTVisitor visits lambda classes when implicit visitation is on.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM with one minor testing request (conditional on the test passing, of course). Comment at: unittests/Tooling/RecursiveASTVisitorTests/LambdaExpr.cpp:68 }

[PATCH] D55646: [ASTImporter] Make ODR diagnostics warning by default

aaron.ballman added a comment. In general, I agree that it doesn't make sense for ODR violations (with false positives) to trigger error diagnostics while performing AST merging, so downgrading this to warnings is a good idea. However, I do worry about impacting modules and C compatibility

r350870 - [analyzer] [hotfix] Fix the tests

Author: george.karpenkov Date: Thu Jan 10 10:28:10 2019 New Revision: 350870 URL: http://llvm.org/viewvc/llvm-project?rev=350870=rev Log: [analyzer] [hotfix] Fix the tests The error must have crept during the cherry-pick. Modified:

[PATCH] D56318: [HIP] Fix size_t for MSVC environment

rjmccall added a comment. No, I understand that things like the function-call ABI should be different from the associated host ABI, but things like the size of `long` and the bit-field layout algorithm presumably shouldn't be, and that's the sort of thing that's configured by `TargetInfo`.

[PATCH] D56552: [clang-tidy] update FunctionSizeCheck for D56444

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56552/new/ https://reviews.llvm.org/D56552

[PATCH] D41941: [WebAssembly] Change int_fast16_t to 32-bit

sunfish added a comment. As @nw points out, clang's lib/Headers/stdint.h doesn't support this yet. Unless anyone feels strongly, I now propose we close this and just leave int_fast16_t/uint_fast16_t as-is. Repository: rC Clang CHANGES SINCE LAST ACTION

[PATCH] D56318: [HIP] Fix size_t for MSVC environment

yaxunl added a comment. In D56318#1353106 , @rjmccall wrote: > No, I understand that things like the function-call ABI should be different > from the associated host ABI, but things like the size of `long` and the > bit-field layout algorithm presumably

[PATCH] D53541: [COFF, ARM64] Do not emit x86_seh_recoverfp intrinsic

mgrang updated this revision to Diff 181106. mgrang retitled this revision from "[COFF, ARM64] Support SEH for ARM64 Windows" to "[COFF, ARM64] Do not emit x86_seh_recoverfp intrinsic". CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53541/new/ https://reviews.llvm.org/D53541 Files:

[PATCH] D43540: [WebAssembly] Enable -Werror=strict-prototypes by default

sunfish added a comment. With https://reviews.llvm.org/D48471 and related work, it's not less urgent to do this. And since there were objections to having target-specific warnings anyway, let's close this. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D43540/new/

[PATCH] D56522: [SemaCXX] add -Woverride-init alias to -Winitializer-overrides

This revision was automatically updated to reflect the committed changes. Closed by commit rL350877: [SemaCXX] add -Woverride-init alias to -Winitializer-overrides (authored by nickdesaulniers, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINCE LAST

r350878 - fixup: sphinx warning

Author: nickdesaulniers Date: Thu Jan 10 11:26:35 2019 New Revision: 350878 URL: http://llvm.org/viewvc/llvm-project?rev=350878=rev Log: fixup: sphinx warning Fixes the sphinx warning: tools/clang/docs/DiagnosticsReference.rst:7889: WARNING: Title underline too short. That I just introduced in

[PATCH] D56318: [HIP] Fix size_t for MSVC environment

rjmccall added a comment. In D56318#1353116 , @yaxunl wrote: > In D56318#1353106 , @rjmccall wrote: > > > No, I understand that things like the function-call ABI should be different > > from the associated host

[PATCH] D56554: [ELF] Add '-z nognustack' opt to suppress emitting PT_GNU_STACK

mgorny created this revision. mgorny added reviewers: ruiu, krytarowski. Herald added subscribers: llvm-commits, arichardson, emaste. Herald added a reviewer: espindola. Add a new '-z nognustack' option that suppresses emitting PT_GNU_STACK segment. This segment is not supported at all on NetBSD

[PATCH] D56109: [sanitizer_common] Define __sanitizer_FILE on NetBSD

This revision was automatically updated to reflect the committed changes. Closed by commit rCRT350882: [sanitizer_common] Define __sanitizer_FILE on NetBSD (authored by mgorny, committed by ). Repository: rCRT Compiler Runtime CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56109/new/

[PATCH] D47817: [compiler-rt] [sanitizer_common] Remove support for tirpc/rpc/xdr.h

This revision was automatically updated to reflect the committed changes. Closed by commit rL350881: [sanitizer_common] Remove support for tirpc/rpc/xdr.h (authored by mgorny, committed by ). Herald added a subscriber: delcypher. Changed prior to commit:

[PATCH] D56554: [ELF] Add '-z nognustack' opt to suppress emitting PT_GNU_STACK

krytarowski added inline comments. Comment at: docs/ld.lld.1:515 +.Dv PT_GNU_STACK +segment. .It Cm norelro section? Repository: rLLD LLVM Linker CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56554/new/ https://reviews.llvm.org/D56554

[PATCH] D56532: [clang-tidy] Add the abseil-duration-conversion-cast check

hwright added inline comments. Comment at: docs/clang-tidy/checks/abseil-duration-conversion-cast.rst:20 + + + // Original - Cast from a double to an integer MyDeveloperDay wrote: > nit: double blank line This is intentional (and consistent with other examples

[PATCH] D56554: [ELF] Add '-z nognustack' opt to suppress emitting PT_GNU_STACK

krytarowski added a comment. Looks good, we don't GNU STACK on NetBSD. Repository: rLLD LLVM Linker CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56554/new/ https://reviews.llvm.org/D56554 ___ cfe-commits mailing list

  1   2   >