r351011 - [ASTDump] Change parameter to StringRef

Author: steveire Date: Sat Jan 12 07:45:05 2019 New Revision: 351011 URL: http://llvm.org/viewvc/llvm-project?rev=351011=rev Log: [ASTDump] Change parameter to StringRef Modified: cfe/trunk/include/clang/AST/TextNodeDumper.h cfe/trunk/lib/AST/TextNodeDumper.cpp Modified:

[PATCH] D56642: NFC: Move dump of type nodes to NodeDumper

steveire created this revision. steveire added a reviewer: aaron.ballman. Herald added a subscriber: cfe-commits. Repository: rC Clang https://reviews.llvm.org/D56642 Files: include/clang/AST/TextNodeDumper.h lib/AST/ASTDumper.cpp lib/AST/TextNodeDumper.cpp Index:

[PATCH] D56642: NFC: Move dump of type nodes to NodeDumper

steveire updated this revision to Diff 181452. steveire added a comment. Format Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56642/new/ https://reviews.llvm.org/D56642 Files: include/clang/AST/TextNodeDumper.h lib/AST/ASTDumper.cpp

[PATCH] D55340: NFC: Move dump of individual Stmts to TextNodeDumper

ham99922 reopened this revision. ham99922 added a comment. This revision is now accepted and ready to land. https://accounts.snapchat.com/accounts/login?continue=https%3A%2F%2Faccounts.snapchat.com%2Faccounts%2Fchang{F7814861} Repository: rL LLVM CHANGES SINCE LAST ACTION

r351014 - [ASTDump] NFC: Move dump of individual Stmts to TextNodeDumper

Author: steveire Date: Sat Jan 12 08:53:27 2019 New Revision: 351014 URL: http://llvm.org/viewvc/llvm-project?rev=351014=rev Log: [ASTDump] NFC: Move dump of individual Stmts to TextNodeDumper Reviewers: aaron.ballman Subscribers: cfe-commits Differential Revision:

[PATCH] D55340: NFC: Move dump of individual Stmts to TextNodeDumper

This revision was automatically updated to reflect the committed changes. Closed by commit rL351014: [ASTDump] NFC: Move dump of individual Stmts to TextNodeDumper (authored by steveire, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

r351007 - [analyzer] Fix unused variable warnings in Release builds

Author: d0k Date: Sat Jan 12 04:43:53 2019 New Revision: 351007 URL: http://llvm.org/viewvc/llvm-project?rev=351007=rev Log: [analyzer] Fix unused variable warnings in Release builds This was just an inlined version of isa. NFC. Modified: cfe/trunk/lib/StaticAnalyzer/Core/CallEvent.cpp

r351015 - NFC: Make utility private

Author: steveire Date: Sat Jan 12 09:07:05 2019 New Revision: 351015 URL: http://llvm.org/viewvc/llvm-project?rev=351015=rev Log: NFC: Make utility private No callers are external to the class anymore. Modified: cfe/trunk/include/clang/AST/TextNodeDumper.h Modified:

[PATCH] D55491: Implement TemplateArgument dumping in terms of Visitor

steveire added a comment. In D55491#1355105 , @thakis wrote: > Out of interest, what's the motivation for this? It seems to add way more > code than it removes, so there must be some other advantage, but the patch > description doesn't say. The reason

r351012 - Implement TemplateArgument dumping in terms of Visitor

Author: steveire Date: Sat Jan 12 08:35:37 2019 New Revision: 351012 URL: http://llvm.org/viewvc/llvm-project?rev=351012=rev Log: Implement TemplateArgument dumping in terms of Visitor Summary: Split the output streaming from the traversal to other AST nodes. Reviewers: aaron.ballman

[PATCH] D55491: Implement TemplateArgument dumping in terms of Visitor

This revision was automatically updated to reflect the committed changes. Closed by commit rL351012: Implement TemplateArgument dumping in terms of Visitor (authored by steveire, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D56639: NFC: Move Type Visit implementation to TextNodeDumper

steveire created this revision. steveire added a reviewer: aaron.ballman. Herald added a subscriber: cfe-commits. Repository: rC Clang https://reviews.llvm.org/D56639 Files: include/clang/AST/TextNodeDumper.h lib/AST/ASTDumper.cpp lib/AST/TextNodeDumper.cpp Index:

[PATCH] D56641: NFC: Move dumping of QualType node to TextNodeDumper

steveire created this revision. steveire added a reviewer: aaron.ballman. Herald added a subscriber: cfe-commits. Repository: rC Clang https://reviews.llvm.org/D56641 Files: include/clang/AST/TextNodeDumper.h lib/AST/ASTDumper.cpp lib/AST/TextNodeDumper.cpp Index:

[PATCH] D56640: NFC: Canonicalize handling of TypeLocInfo

steveire created this revision. steveire added a reviewer: aaron.ballman. Herald added a subscriber: cfe-commits. No need to avoid the Visit method. Repository: rC Clang https://reviews.llvm.org/D56640 Files: lib/AST/ASTDumper.cpp Index: lib/AST/ASTDumper.cpp

[PATCH] D56581: [ASTImporter] Set the described template if not set

a_sidorin added a comment. Hello Gabor, This looks good, but as Shafik mentioned, adding a test would be nice. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56581/new/ https://reviews.llvm.org/D56581 ___

[PATCH] D55491: Implement TemplateArgument dumping in terms of Visitor

steveire marked an inline comment as done. steveire added inline comments. Comment at: include/clang/AST/TemplateArgumentVisitor.h:24 +/// A simple visitor class that helps create template argument visitors. +template class Ref, typename ImplClass, + typename RetTy =

[PATCH] D56607: [clang] [NetBSD] Enable additional sanitizer types

This revision was automatically updated to reflect the committed changes. Closed by commit rL351002: [NetBSD] Enable additional sanitizer types (authored by mgorny, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

r351002 - [NetBSD] Enable additional sanitizer types

Author: mgorny Date: Sat Jan 12 03:18:35 2019 New Revision: 351002 URL: http://llvm.org/viewvc/llvm-project?rev=351002=rev Log: [NetBSD] Enable additional sanitizer types Differential Revision: https://reviews.llvm.org/D56607 Modified: cfe/trunk/lib/Driver/ToolChains/NetBSD.cpp

[PATCH] D55250: [clangd] Enhance macro hover to see full definition

malaperle marked 2 inline comments as done. malaperle added inline comments. Comment at: clangd/XRefs.cpp:572 + + // Try to get the full definition, not just the name + SourceLocation StartLoc = Decl.Info->getDefinitionLoc(); simark wrote: > hokein wrote: > >

[PATCH] D55394: Re-order type param children of ObjC nodes

steveire marked an inline comment as done. steveire added inline comments. Comment at: test/AST/ast-dump-decl.m:90 // CHECK-NEXT: -ObjCProtocol {{.+}} 'P' +// CHECK-NEXT: -ObjCTypeParamDecl {{.+}} col:33 T 'id':'id' aaron.ballman wrote: > It seems

[PATCH] D56643: NFC: Move Decl node handling to TextNodeDumper

steveire created this revision. steveire added a reviewer: aaron.ballman. Herald added a subscriber: cfe-commits. Repository: rC Clang https://reviews.llvm.org/D56643 Files: include/clang/AST/TextNodeDumper.h lib/AST/ASTDumper.cpp lib/AST/TextNodeDumper.cpp Index:

[PATCH] D49466: Initial implementation of -fmacro-prefix-map and -ffile-prefix-map

Lekensteyn accepted this revision. Lekensteyn added a comment. This revision is now accepted and ready to land. Tests pass here, using it on a large CMake project with a CMAKE_BUILD_TYPE=Debug and c/cxxflags `-ffile-prefix-map=$builddir= -ffile-prefix-map=$srcdir/= -fuse-ld=lld` successfully

[PATCH] D56644: [clang-tidy] readability-container-size-empty handle std::string length()

lebedev.ri added a comment. In D56644#1355436 , @Quolyk wrote: > For now, I just added tests. I have several questions, as I'm beginner > (`ContainerSizeEmptyCheck.cpp`). > > 1. Do I have to extend `ValidContainer`, so it recognises `::std::string` >

[PATCH] D56644: [clang-tidy] readability-container-size-empty handle std::string length()

Quolyk added a comment. For now, I just added tests. I have several questions, as I'm beginner (`ContainerSizeEmptyCheck.cpp`). 1. Do I have to extend `ValidContainer`, so it recognises `::std::string` with `length()` method as valid container too or we can assume `::std::string` as valid

[PATCH] D56644: [clang-tidy] readability-container-size-empty handle std::string length()

lebedev.ri added a comment. Either this is a NFC change with just tests, or the actual fix is missing. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56644/new/ https://reviews.llvm.org/D56644 ___

[PATCH] D56644: [clang-tidy] readability-container-size-empty handle std::string length()

Quolyk added a comment. In D56644#1355434 , @lebedev.ri wrote: > Either this is a NFC change with just tests, or the actual fix is missing. Right, it's WIP for now. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION

[PATCH] D56644: [clang-tidy] readability-container-size-empty handle std::string length()

Quolyk created this revision. Quolyk added reviewers: Eugene.Zelenko, omtcyfz, aaron.ballman, alexfh. Herald added subscribers: cfe-commits, xazax.hun. Extends readability-container-size-empty to check std::string length() similar to size(). Motivation: