Re: r352055 - Fix failing buildbots

Sounds good to me, easy enough for me to test here. And I'll count that as a review. I've given it a try in rC352956. We can see how that bot feels about it. Dave > Dave, > > The idea to check explicitly the triple inside the test function is quite > convincing. Will you try to fix it that

[clang-tools-extra] r352957 - [clangd] Fix heap-use-after-free after r352868

Author: ioeric Date: Sat Feb 2 02:35:39 2019 New Revision: 352957 URL: http://llvm.org/viewvc/llvm-project?rev=352957=rev Log: [clangd] Fix heap-use-after-free after r352868 Modified: clang-tools-extra/trunk/unittests/clangd/QualityTests.cpp Modified:

r352956 - [ASTImporter] Fix up test that only works on X86.

Author: dmgreen Date: Sat Feb 2 00:31:22 2019 New Revision: 352956 URL: http://llvm.org/viewvc/llvm-project?rev=352956=rev Log: [ASTImporter] Fix up test that only works on X86. The test will fail if the default target triple is not X86, even if the host platform is. So move the check into the

[PATCH] D57540: [C++17] Don't crash while diagnosing different access specifier of a deduction guide.

Rakete marked an inline comment as done. Rakete added inline comments. Comment at: test/SemaCXX/cxx1z-class-template-argument-deduction.cpp:360-361 + struct Type { +Typo(); // expected-error{{deduction guide must be declared in the same scope}} +//

[PATCH] D51866: [analyzer][UninitializedObjectChecker] New flag to ignore guarded uninitialized fields

This revision was automatically updated to reflect the committed changes. Closed by commit rL352959: [analyzer][UninitializedObjectChecker] New flag to ignore guarded uninitialized… (authored by Szelethus, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits.

r352959 - [analyzer][UninitializedObjectChecker] New flag to ignore guarded uninitialized fields

Author: szelethus Date: Sat Feb 2 06:50:04 2019 New Revision: 352959 URL: http://llvm.org/viewvc/llvm-project?rev=352959=rev Log: [analyzer][UninitializedObjectChecker] New flag to ignore guarded uninitialized fields This patch is an implementation of the ideas discussed on the mailing

[PATCH] D46421: [analyzer][CrossTU] Extend CTU to VarDecls with initializer

martong added a comment. > I think you should change back to getInit() I am not entirely sure about this because the initalizer may not be attached to the canonical decl. `getInit()` gives the initializer of one given specific Decl, however, `getAnyInitializer()` searches through the whole

Re: r352055 - Fix failing buildbots

Thank you for taking care of this! As I see now the hexagon build bot is happy and the other bots too. Thanks again, Gábor On Sat, 2 Feb 2019, 09:34 David Green Sounds good to me, easy enough for me to test here. And I'll count that as > a review. > > > I've given it a try in rC352956. We can

r352980 - Fix handling of usual deallocation functions in various configuratios.

Author: ericwf Date: Sat Feb 2 19:44:31 2019 New Revision: 352980 URL: http://llvm.org/viewvc/llvm-project?rev=352980=rev Log: Fix handling of usual deallocation functions in various configuratios. Clang allows users to enable or disable various types of allocation and deallocation regardless

r352983 - Correct test my *really really* overaligning a type.

Author: ericwf Date: Sat Feb 2 20:10:38 2019 New Revision: 352983 URL: http://llvm.org/viewvc/llvm-project?rev=352983=rev Log: Correct test my *really really* overaligning a type. Modified: cfe/trunk/test/SemaCXX/extended-usual-deallocation-functions.cpp Modified:

[PATCH] D55250: [clangd] Enhance macro hover to see full definition

malaperle updated this revision to Diff 184928. malaperle marked 2 inline comments as done. malaperle added a comment. Herald added a project: clang. Address comments. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55250/new/

[PATCH] D57645: [C++2a] Fix PR40576: Turn destroying delete off prior to C++2a. Add -fdestroying-delete

EricWF created this revision. EricWF added reviewers: ckennelly, rsmith. Herald added a project: clang. Defining new names in namespace `std` is technically a non-conforming extensions. This makes it difficult for libc++ to backport C++20 destroying delete. This patch should make it easier for

[PATCH] D57207: [clang-tidy] Make google-objc-function-naming ignore implicit functions 

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE352968: [clang-tidy] Make google-objc-function-naming ignore implicit functions  (authored by stephanemoore, committed by ). Herald added a project: clang. Changed prior to commit:

[PATCH] D56935: [NewPM] Add support for new-PM plugins to clang

This revision was automatically updated to reflect the committed changes. Closed by commit rC352972: [NewPM] Add support for new-PM plugins to clang (authored by pfaffe, committed by ). Changed prior to commit: https://reviews.llvm.org/D56935?vs=183715=184922#toc Repository: rC Clang

r352972 - [NewPM] Add support for new-PM plugins to clang

Author: pfaffe Date: Sat Feb 2 15:19:32 2019 New Revision: 352972 URL: http://llvm.org/viewvc/llvm-project?rev=352972=rev Log: [NewPM] Add support for new-PM plugins to clang Summary: This adds support for new-PM plugin loading to clang. The option `-fpass-plugin=` may be used to specify a

[PATCH] D56935: [NewPM] Add support for new-PM plugins to clang

philip.pfaffe added a comment. Landed it for you in r352972. Thanks! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56935/new/ https://reviews.llvm.org/D56935 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D57642: [X86] Update clobber list in a test after D57641. Remove filter for 'fpsw' in MS inline asm clobber list generation since the backend now uses 'fpsr'.

craig.topper created this revision. craig.topper added a reviewer: rnk. Herald added subscribers: cfe-commits, eraman. Herald added a project: clang. The backend used to print the x87 FPSW register as 'fpsw', but gcc inline asm uses 'fpsr'. After D57641 , the

[PATCH] D57207: [clang-tidy] Make google-objc-function-naming ignore implicit functions 

stephanemoore marked an inline comment as done. stephanemoore added inline comments. Comment at: test/clang-tidy/google-objc-function-naming.m:3 +#import + It turns out importing is problematic and breaks the build (though everything built successfully for

[libunwind] r352965 - [libunwind] Remove the remote unwinding support

Author: phosek Date: Sat Feb 2 12:54:03 2019 New Revision: 352965 URL: http://llvm.org/viewvc/llvm-project?rev=352965=rev Log: [libunwind] Remove the remote unwinding support This is unfinished, unused and incomplete. This could be brought back in the future if there's a desire to build a more

[PATCH] D57573: Disable tidy checks with too many hits

alexfh added a comment. I wonder whether a list of specific checks (without wildcards) would make more sense for llvm? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57573/new/ https://reviews.llvm.org/D57573 ___

[PATCH] D57497: [RISCV] Passing -G value to RISCV backend

apazos added a comment. Hi Shiva, I think you need to check for and pass along the -G option to the linker (gnutools::Linker and RISCV::Linker) and will be available for LTO. Check Hexagon, it passes the threshold value to the assembler (via -gpsize) and linker (via -G). Repository: rC

[PATCH] D57592: Replace uses of %T with %t in from previous frontend test differential

thakis added a comment. Done, thanks for the patch! Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57592/new/ https://reviews.llvm.org/D57592 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D57592: Replace uses of %T with %t in from previous frontend test differential

This revision was automatically updated to reflect the committed changes. Closed by commit rL352971: Replace uses of %T with %t in from previous frontend test differential (authored by nico, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to

r352971 - Replace uses of %T with %t in from previous frontend test differential

Author: nico Date: Sat Feb 2 15:16:30 2019 New Revision: 352971 URL: http://llvm.org/viewvc/llvm-project?rev=352971=rev Log: Replace uses of %T with %t in from previous frontend test differential After committing a change I had made to a few frontend tests, it was pointed out to me that %T is

[PATCH] D56353: Replace cc1 options '-mdisable-fp-elim' and '-momit-leaf-frame-pointer' with'-mframe-pointer='

tabloid.adroit added a comment. Herald added a project: clang. ping Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56353/new/ https://reviews.llvm.org/D56353 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang-tools-extra] r352964 - [clang-tidy] Rename time lookup functions; NFC

Author: hwright Date: Sat Feb 2 11:57:37 2019 New Revision: 352964 URL: http://llvm.org/viewvc/llvm-project?rev=352964=rev Log: [clang-tidy] Rename time lookup functions; NFC Modified: clang-tools-extra/trunk/clang-tidy/abseil/DurationAdditionCheck.cpp

[libunwind] r352966 - [libunwind] Provide placement new definition

Author: phosek Date: Sat Feb 2 13:15:49 2019 New Revision: 352966 URL: http://llvm.org/viewvc/llvm-project?rev=352966=rev Log: [libunwind] Provide placement new definition While Clang automatically generates the code for placement new, g++ doesn't do that so we need to provide our own