[PATCH] D57664: [opaque pointer types] Fix the CallInfo passed to EmitCall in some edge cases.

jyknight created this revision. jyknight added reviewers: dblaikie, rsmith. Herald added a subscriber: Anastasia. Herald added a project: clang. Currently, EmitCall emits a call instruction with a function type derived from the pointee-type of the callee. This *should* be the same as the type

[PATCH] D57665: [clang-tidy] Handle unions with existing default-member-init

malcolm.parsons created this revision. malcolm.parsons added reviewers: aaron.ballman, alexfh. Herald added subscribers: cfe-commits, xazax.hun. Herald added a project: clang. clang-tidy's modernize-use-default-member-init was crashing for unions with an existing default member initializer.

[PATCH] D57497: [RISCV] Passing small data limitation value to RISCV backend

apazos added a comment. I don't see -plugin-opt=-riscv-ssection-threshold=.. being passed. tools::gnutools::Linker::ConstructJob is being invoked with target riscv32-unknown-linux-gnu It has to work for riscv32-unknown-linux-gnu and riscv32-unknown-elf Repository: rC Clang CHANGES SINCE

[PATCH] D57649: [ASTDump] Add a flag indicating whether a CXXThisExpr is implicit

steveire added a comment. I have no objection to this, but I wonder whether all state accessible from all nodes should be part of the AST dump. Where do you think the line is? Is there anything else missing currently from other nodes? Repository: rC Clang CHANGES SINCE LAST ACTION

[PATCH] D57649: [ASTDump] Add a flag indicating whether a CXXThisExpr is implicit

riccibruno added a comment. Thanks for the review ! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57649/new/ https://reviews.llvm.org/D57649 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D57662: [clang-tidy] Parallelise clang-tidy-diff.py

zinovy.nis created this revision. zinovy.nis added reviewers: alexfh, ehsan. zinovy.nis added a project: clang-tools-extra. Herald added subscribers: cfe-commits, xazax.hun. Herald added a reviewer: serge-sans-paille. Herald added a project: clang. This patch has 2 rationales: - large patches

r353006 - [AST] Update the comments of the various Expr::Ignore* + Related cleanups

Author: brunoricci Date: Sun Feb 3 11:50:56 2019 New Revision: 353006 URL: http://llvm.org/viewvc/llvm-project?rev=353006=rev Log: [AST] Update the comments of the various Expr::Ignore* + Related cleanups The description of what the various Expr::Ignore* do has drifted from the actual

[PATCH] D57266: [AST] Update the comments of the various Expr::Ignore* + Related cleanups

This revision was automatically updated to reflect the committed changes. Closed by commit rL353006: [AST] Update the comments of the various Expr::Ignore* + Related cleanups (authored by brunoricci, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed

[PATCH] D57655: clang-format with UseTab: Always sometimes doesn't insert the right amount of tabs.

hyklv created this revision. hyklv added reviewers: alexfh, djasper. Herald added a project: clang. Herald added a subscriber: cfe-commits. Hi, I'm trying to get clang-format suited for our code layout. I've set it up to align declarations and trailing comments. Tab size is 4; UseTab is set to

r353003 - [ASTDump] Add a flag indicating whether a CXXThisExpr is implicit

Author: brunoricci Date: Sun Feb 3 10:20:27 2019 New Revision: 353003 URL: http://llvm.org/viewvc/llvm-project?rev=353003=rev Log: [ASTDump] Add a flag indicating whether a CXXThisExpr is implicit There is currently no way to distinguish implicit from explicit CXXThisExpr in the AST dump

[PATCH] D57649: [ASTDump] Add a flag indicating whether a CXXThisExpr is implicit

aaron.ballman added a comment. In D57649#1382470 , @riccibruno wrote: > Though it is a subjective distinction and in the end if someone need a flag > it is going to be added I guess. That's the crux of how we've decided what information to expose in

[PATCH] D57659: [Sema] SequenceChecker: Add some comments + related small NFCs in preparation of the following patches

riccibruno created this revision. riccibruno added reviewers: aaron.ballman, rsmith. riccibruno added a project: clang. Herald added a subscriber: cfe-commits. Do the following NFCs, before doing anything more substantial: 1. Add some comments to hopefully reduce the amount of code staring for

[PATCH] D57660: [Sema] SequenceChecker: Handle references and members

riccibruno created this revision. riccibruno added reviewers: aaron.ballman, rsmith. riccibruno added a project: clang. Herald added a subscriber: cfe-commits. Teach the unsequenced operation checker about references and members. To do this introduce a class `MemoryLocation` which will

[PATCH] D57634: Support for GCC's `__builtin_va_arg_pack{,_len}`

erik.pilkington abandoned this revision. erik.pilkington added a comment. Tentatively marking as abandoned, Eli suggested a different approach in the LLVM review which I'm going to look into. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57634/new/

[PATCH] D57649: [ASTDump] Add a flag indicating whether a CXXThisExpr is implicit

riccibruno added a comment. In D57649#1382477 , @aaron.ballman wrote: > In D57649#1382470 , @riccibruno > wrote: > > > Though it is a subjective distinction and in the end if someone need a flag > > it is going

[PATCH] D57655: clang-format with UseTab: Always sometimes doesn't insert the right amount of tabs.

lebedev.ri requested changes to this revision. lebedev.ri added a comment. This revision now requires changes to proceed. Test? Is this a fix, or a new formatting style? Comment at: WhitespaceManager.cpp:3-6 +// The LLVM Compiler Infrastructure // +// This

[PATCH] D57649: [ASTDump] Add a flag indicating whether a CXXThisExpr is implicit

riccibruno added a comment. In D57649#1382453 , @steveire wrote: > I have no objection to this, but I wonder whether all state accessible from > all nodes should be part of the AST dump. Where do you think the line is? Is > there anything else missing

[PATCH] D57649: [ASTDump] Add a flag indicating whether a CXXThisExpr is implicit

This revision was automatically updated to reflect the committed changes. Closed by commit rC353003: [ASTDump] Add a flag indicating whether a CXXThisExpr is implicit (authored by brunoricci, committed by ). Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57649/new/

[PATCH] D57661: [Sema] SequenceChecker: Add tests for references and members.

riccibruno created this revision. riccibruno added reviewers: aaron.ballman, rsmith. riccibruno added a project: clang. Herald added a subscriber: cfe-commits. Tests for D57660 . Repository: rC Clang https://reviews.llvm.org/D57661 Files:

r353009 - [opaque pointer types] Trivial changes towards CallInst requiring

Author: jyknight Date: Sun Feb 3 13:53:49 2019 New Revision: 353009 URL: http://llvm.org/viewvc/llvm-project?rev=353009=rev Log: [opaque pointer types] Trivial changes towards CallInst requiring explicit function types. Modified: cfe/trunk/lib/CodeGen/CGBuiltin.cpp

[libunwind] r353010 - Provide a placement new definition for the SEH version of UnwindCursor

Author: mstorsjo Date: Sun Feb 3 14:16:53 2019 New Revision: 353010 URL: http://llvm.org/viewvc/llvm-project?rev=353010=rev Log: Provide a placement new definition for the SEH version of UnwindCursor This fixes compilation after SVN r352966 in SEH mode. Modified:

[PATCH] D57665: [clang-tidy] Handle unions with existing default-member-init

riccibruno added a comment. Just to make sure I understand the issue correctly (and so please correct me if I am wrong): The union member `e` leads to an `IndirectFieldDecl` in the record for `UnionExisting`. Then `CXXCtorInitializer::getMember` returns null since the initialized member is

[PATCH] D57661: [Sema] SequenceChecker: Add tests for references and members.

riccibruno added a comment. I realized I need to add tests for (at least) anonymous unions/structs and local classes, but I am sure I missing lots of interesting cases. Feel free to suggest anything you might think of. Repository: rC Clang CHANGES SINCE LAST ACTION

[PATCH] D57665: [clang-tidy] Handle unions with existing default-member-init

JonasToth accepted this revision. JonasToth added a comment. This revision is now accepted and ready to land. LGTM, please close the bug report and notify for the fix with the request to check in the real-project if it actually fixes the issue. Thanks :) Repository: rG LLVM Github Monorepo

[PATCH] D56370: [clangd] Add support for type hierarchy (super types only for now)

nridge updated this revision to Diff 184984. nridge edited the summary of this revision. nridge added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. This completes the implementation of the revised spec (for supertypes only) Repository: rG LLVM Github

[PATCH] D56370: [clangd] Add support for type hierarchy (super types only for now)

nridge updated this revision to Diff 184985. nridge added a comment. remove unrelated file Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56370/new/ https://reviews.llvm.org/D56370 Files: clang-tools-extra/clangd/ClangdLSPServer.cpp

[PATCH] D56370: [clangd] Add support for type hierarchy (super types only for now)

nridge marked 3 inline comments as done. nridge added inline comments. Comment at: clang-tools-extra/clangd/XRefs.cpp:820 +// TODO: Reduce duplication between this function and declToSym(). +static llvm::Optional I am open to feedback on whether we want to

[PATCH] D57497: [RISCV] Passing small data limitation value to RISCV backend

shiva0217 updated this revision to Diff 184936. shiva0217 retitled this revision from "[RISCV] Passing -G value to RISCV backend" to "[RISCV] Passing small data limitation value to RISCV backend". shiva0217 edited the summary of this revision. shiva0217 added a comment. 1. Setting small data

[PATCH] D45978: dllexport const variables must have external linkage.

zahiraam added a comment. In D45978#1379901 , @rnk wrote: > I'm still not sure this is the best place to make this change, but the > functionality is important. There are still unaddressed comments (no need to > check MSVCCompatibility, formatting), and

[PATCH] D57497: [RISCV] Passing small data limitation value to RISCV backend

shiva0217 added a comment. In D57497#1382206 , @apazos wrote: > Hi Shiva, I think you need to check for and pass along the -G option to the > linker (gnutools::Linker and RISCV::Linker) and will be available for LTO. > Check Hexagon, it passes the

[PATCH] D57645: [C++2a] Fix PR40576: Turn destroying delete off prior to C++2a. Add -fdestroying-delete

riccibruno added inline comments. Comment at: lib/AST/DeclCXX.cpp:2070 + if (isDestroyingOperatorDelete()) { +if (!getASTContext().getLangOpts().DestroyingDelete) + return false; Just use the AST context you have above ? Repository: rC Clang

[PATCH] D45741: Python bindings: Fix handling of file bodies with multi-byte characters

mheinzler abandoned this revision. mheinzler added a comment. Herald added a subscriber: arphaman. Herald added a reviewer: serge-sans-paille. Herald added a project: clang. I'm closing this because it has been fixed in master by: https://reviews.llvm.org/D56429 Repository: rC Clang CHANGES

[clang-tools-extra] r352991 - Remove trailing semicolon. NFCI.

Author: rksimon Date: Sun Feb 3 06:11:32 2019 New Revision: 352991 URL: http://llvm.org/viewvc/llvm-project?rev=352991=rev Log: Remove trailing semicolon. NFCI. Modified: clang-tools-extra/trunk/clangd/refactor/tweaks/SwapIfBranches.cpp Modified:

r352995 - [objc-gnustep] Fix encoding of ivar size for _Bool.

Author: theraven Date: Sun Feb 3 07:05:52 2019 New Revision: 352995 URL: http://llvm.org/viewvc/llvm-project?rev=352995=rev Log: [objc-gnustep] Fix encoding of ivar size for _Bool. Modified: cfe/trunk/lib/CodeGen/CGObjCGNU.cpp cfe/trunk/test/CodeGenObjC/gnustep2-ivar-offset.m Modified:

[PATCH] D57592: Replace uses of %T with %t in from previous frontend test differential

krytarowski added a comment. The NetBSD buildbot breaks in these tests now: http://lab.llvm.org:8011/builders/lldb-amd64-ninja-netbsd8/builds/18721 Both tests break in a similar way: Command Output (stderr): -- + : 'RUN: at line 1' + not /home/motus/netbsd8/netbsd8/build/bin/clang -cc1

[PATCH] D57649: [ASTDump] Add a flag indicating whether a CXXThisExpr is implicit

riccibruno created this revision. riccibruno added a reviewer: steveire. riccibruno added a project: clang. Herald added a subscriber: cfe-commits. There is current no way to distinguish implicit from explicit `CXXThisExpr` in the AST dump output. Repository: rC Clang

[PATCH] D57497: [RISCV] Passing small data limitation value to RISCV backend

apazos added a comment. Hi Shiva, I will check, but I think you need to also modify gnutools:Linker because riscv::Linker is called for baremetal. I think you need in both places. The way I check is by invoking -flto -v from clang and look at the arguments passed to the compiler and linker

[PATCH] D57626: Disallow trivial_abi on a class if all copy and move constructors are deleted

Quuxplusone added a comment. Can you give more intuition on why classes with no copy/move operations should be forced non-trivial-abi? Let's take this specific example: struct [[clang::trivial_abi]] lock_guard { mutex *m; explicit lock_guard(mutex *m) : m(m) { m->lock(); }

[PATCH] D57592: Replace uses of %T with %t in from previous frontend test differential

riccibruno added a comment. > The NetBSD buildbot breaks in these tests now: Pretty much every bot is red because of this patch (http://lab.llvm.org:8011/one_line_per_build) so yes, please fix. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57592/new/

[PATCH] D57266: [AST] Update the comments of the various Expr::Ignore* + Related cleanups

riccibruno updated this revision to Diff 184945. riccibruno marked 4 inline comments as done. riccibruno added a comment. Addressed Aaron's comments. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57266/new/ https://reviews.llvm.org/D57266 Files:

r352996 - Hot fix two test regressions (%T vs %t)

Author: davezarzycki Date: Sun Feb 3 07:49:11 2019 New Revision: 352996 URL: http://llvm.org/viewvc/llvm-project?rev=352996=rev Log: Hot fix two test regressions (%T vs %t) Different Unix "errno" values are returned for the following scenarios: $ echo test >

[PATCH] D57267: [AST] Factor out the logic of the various Expr::Ignore*

riccibruno added inline comments. Comment at: lib/AST/Expr.cpp:2562 +return ICE->getSubExpr(); + + else if (auto *FE = dyn_cast_or_null(E)) It is something that is actually possible to audit. I did look at where each of the skipped node are created and it

[PATCH] D57267: [AST] Factor out the logic of the various Expr::Ignore*

riccibruno updated this revision to Diff 184944. riccibruno marked 6 inline comments as done. riccibruno added a comment. Rebased and addressed Aaron's comments, except for the null check issue on which I am still undecided. Repository: rC Clang CHANGES SINCE LAST ACTION

[PATCH] D57472: [AST] Extract ASTDumpTraverser class from ASTDumper

This revision was automatically updated to reflect the committed changes. Closed by commit rL352989: [AST] Extract ASTNodeTraverser class from ASTDumper (authored by steveire, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

r352989 - [AST] Extract ASTNodeTraverser class from ASTDumper

Author: steveire Date: Sun Feb 3 06:06:54 2019 New Revision: 352989 URL: http://llvm.org/viewvc/llvm-project?rev=352989=rev Log: [AST] Extract ASTNodeTraverser class from ASTDumper Summary: This new traverser class allows clients to re-use the traversal logic which was previously part of

[clang-tools-extra] r352990 - Remove trailing semicolon. NFCI.

Author: rksimon Date: Sun Feb 3 06:08:30 2019 New Revision: 352990 URL: http://llvm.org/viewvc/llvm-project?rev=352990=rev Log: Remove trailing semicolon. NFCI. Modified: clang-tools-extra/trunk/clangd/ClangdLSPServer.cpp Modified: clang-tools-extra/trunk/clangd/ClangdLSPServer.cpp URL:

[PATCH] D57592: Replace uses of %T with %t in from previous frontend test differential

davezarzycki added a comment. Hot fix: r352996 Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57592/new/ https://reviews.llvm.org/D57592 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D57497: [RISCV] Passing small data limitation value to RISCV backend

shiva0217 updated this revision to Diff 184988. shiva0217 added a comment. Support passing small data limitation for target riscv32-unknown-linux-gnu with LTO enabled. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57497/new/ https://reviews.llvm.org/D57497

[PATCH] D57497: [RISCV] Passing small data limitation value to RISCV backend

shiva0217 added a comment. In D57497#1382393 , @apazos wrote: > I don't see -plugin-opt=-riscv-ssection-threshold=.. being passed. > tools::gnutools::Linker::ConstructJob is being invoked with target > riscv32-unknown-linux-gnu > It has to work for

[PATCH] D57220: Test fix for isViableInline remark message

yrouban closed this revision. yrouban added a comment. Landed along with D57089 (see rC352849 ). Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57220/new/ https://reviews.llvm.org/D57220

[PATCH] D57220: Test fix for isViableInline remark message

yrouban marked an inline comment as done. yrouban added inline comments. Comment at: test/Frontend/optimization-remark-with-hotness.c:63 // NO_PGO: '-fdiagnostics-hotness-threshold=' requires profile-guided optimization information // expected-remark@+1 {{foo inlined into

r353018 - [OpenMP] Adding support to the mutexinoutset dep-type

Author: smateo Date: Sun Feb 3 23:33:19 2019 New Revision: 353018 URL: http://llvm.org/viewvc/llvm-project?rev=353018=rev Log: [OpenMP] Adding support to the mutexinoutset dep-type Summary: this commit adds support to a new dependence type introduced in OpenMP 5.0. The LLVM OpenMP RTL already

[PATCH] D57576: Adding support to the OpenMP mutexinoutset dependency type

This revision was automatically updated to reflect the committed changes. Closed by commit rC353018: [OpenMP] Adding support to the mutexinoutset dep-type (authored by smateo, committed by ). Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57576/new/