[PATCH] D57905: [ASTImporter][ASTImporterSpecificLookup] Add test for different operators

This revision was automatically updated to reflect the committed changes. Closed by commit rC353505: [ASTImporter][ASTImporterSpecificLookup] Add test for different operators (authored by martong, committed by ). Changed prior to commit: https://reviews.llvm.org/D57905?vs=185924=185925#toc

[PATCH] D45978: dllexport const variables must have external linkage.

zahiraam updated this revision to Diff 185920. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D45978/new/ https://reviews.llvm.org/D45978 Files: test/Sema/dllexport-1.cpp test/Sema/dllexport-2.cpp test/Sema/dllexport.c Index: test/Sema/dllexport.c

[PATCH] D57905: [ASTImporter][ASTImporterSpecificLookup] Add test for different operators

martong updated this revision to Diff 185924. martong marked an inline comment as done. martong added a comment. - Add comment above ASSERT_NE Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57905/new/ https://reviews.llvm.org/D57905 Files:

[PATCH] D57906: [CTU] Do not allow different CPP dialects in CTU

martong added inline comments. Comment at: lib/CrossTU/CrossTranslationUnit.cpp:232 + + // We do not support CTU across languages (C vs C++). if (LangTo.CPlusPlus != LangFrom.CPlusPlus) { a_sidorin wrote: > The comment change looks strange. Ok, I reverted

[PATCH] D57906: [CTU] Do not allow different CPP dialects in CTU

martong updated this revision to Diff 185926. martong marked 4 inline comments as done. martong added a comment. - Revert comment change - Add lang_dialect_mismatch and stats for that Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57906/new/

[PATCH] D57896: Variable names rule

michaelplatings added a comment. In D57896#1389067 , @lebedev.ri wrote: > 1. Does clang-tidy warn on every single existing variable now? > 2. It might be best to give this more visibility, by submitting a mail to > llvm-dev, with a **noticeable**

[PATCH] D57739: [clangd] Format tweak's replacements.

sammccall added a comment. In D57739#1385144 , @hokein wrote: > In D57739#1384844 , @ilya-biryukov > wrote: > > > Could we move the code to the `Tweak` itself, so that all the callers would > > get the

[PATCH] D57902: [AST] Fix structural inequivalence of operators

martong marked 2 inline comments as done. martong added inline comments. Comment at: unittests/AST/StructuralEquivalenceTest.cpp:251 + +TEST_F(StructuralEquivalenceFunctionTest, CtorVsDtor) { + auto t = makeDecls( shafik wrote: > Curious, is this test just for

[PATCH] D45978: dllexport const variables must have external linkage.

zahiraam added a comment. In D45978#1387385 , @aaron.ballman wrote: > Can you add tests for C mode as well, as it seems the behavior differs there. Aaron, Let me know if that is enough. Thanks. CHANGES SINCE LAST ACTION

[PATCH] D57898: [RFC] Split constant structures generated by -ftrivial-auto-var-init when emitting initializators

glider marked 2 inline comments as not done. glider added a comment. Sorry, didn't mean to mark these done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57898/new/ https://reviews.llvm.org/D57898 ___ cfe-commits mailing list

[PATCH] D57898: [RFC] Split constant structures generated by -ftrivial-auto-var-init when emitting initializators

glider marked 2 inline comments as done. glider added inline comments. Comment at: tools/clang/lib/CodeGen/CGDecl.cpp:1143 +const llvm::StructLayout *Layout = +CGM.getDataLayout().getStructLayout(cast(Ty)); +for (unsigned i = 0; i != constant->getNumOperands();

r353505 - [ASTImporter][ASTImporterSpecificLookup] Add test for different operators

Author: martong Date: Fri Feb 8 01:19:34 2019 New Revision: 353505 URL: http://llvm.org/viewvc/llvm-project?rev=353505=rev Log: [ASTImporter][ASTImporterSpecificLookup] Add test for different operators Summary: This is to check that operators are handled properly in `ASTImporterSpecificLookup`.

r353504 - [AST] Fix structural inequivalence of operators

Author: martong Date: Fri Feb 8 00:55:32 2019 New Revision: 353504 URL: http://llvm.org/viewvc/llvm-project?rev=353504=rev Log: [AST] Fix structural inequivalence of operators Summary: Operators kind was not checked, so we reported e.g. op- to be equal with op+ Reviewers: shafik, a_sidorin,

[PATCH] D57902: [AST] Fix structural inequivalence of operators

This revision was automatically updated to reflect the committed changes. martong marked an inline comment as done. Closed by commit rC353504: [AST] Fix structural inequivalence of operators (authored by martong, committed by ). Changed prior to commit:

[PATCH] D57883: [clang-tidy] refactor ExceptionAnalyzer further to give ternary answer

JonasToth updated this revision to Diff 185939. JonasToth added a comment. - [Refactor] move support classes into the analyzer - [Refactor] move bigger methods into implementation file Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57883/new/

[PATCH] D57883: [clang-tidy] refactor ExceptionAnalyzer further to give ternary answer

JonasToth marked 2 inline comments as done. JonasToth added a comment. Good idea :) Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57883/new/ https://reviews.llvm.org/D57883 ___ cfe-commits mailing list

[PATCH] D57577: Make predefined FLT16 macros conditional on support for the type

nemanjai added a comment. Does anyone have any further comments or objections to this patch? I would like to commit this and close the PR. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57577/new/ https://reviews.llvm.org/D57577

[PATCH] D57739: [clangd] Format tweak's replacements.

ilya-biryukov added a comment. In D57739#1390321 , @sammccall wrote: > It's not about stability or whether the functionality is desired, but > layering. > Unit tests having narrow scope is a good thing - if we want system tests > that check

[PATCH] D57949: [clang][Index] Add a knob to index function parameters in declarations

kadircet updated this revision to Diff 185962. kadircet added a comment. - Also delete comment Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57949/new/ https://reviews.llvm.org/D57949 Files: include/clang/Index/IndexingAction.h lib/Index/IndexDecl.cpp

[PATCH] D54978: Move the SMT API to LLVM

thakis added a comment. In D54978#1389260 , @shakeel.mahate wrote: > The ninja build also fails That's not the ninja build, that's the GN build. If you use that, please read llvm/utils/gn/README.rst. If something like this happens, it's on you (and

[PATCH] D57943: [clangd] **Prototype**: clang-tidy-based tweaks

hokein updated this revision to Diff 185941. hokein added a comment. Update Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57943/new/ https://reviews.llvm.org/D57943 Files: clangd/refactor/tweaks/CMakeLists.txt

[PATCH] D57944: [clangd] Fix an assertion in TypoCorrection.

This revision was automatically updated to reflect the committed changes. ioeric marked an inline comment as done. Closed by commit rL353514: [clangd] Fix an assertion in TypoCorrection. (authored by ioeric, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits.

[PATCH] D57948: [Sema] Fix a regression introduced in "[AST][Sema] Remove CallExpr::setNumArgs"

riccibruno created this revision. riccibruno added a reviewer: aaron.ballman. riccibruno added a project: clang. Herald added a subscriber: cfe-commits. D54902 removed `CallExpr::setNumArgs` in preparation of tail-allocating the arguments of `CallExpr`. It did

[PATCH] D57739: [clangd] Format tweak's replacements.

ilya-biryukov added a comment. In D57739#1390252 , @sammccall wrote: > I agree with this concern, and don't think this is an appropriate layer to be > aware of styling or failing on format errors. Can we consider moving the > formatting to clangdserver

[PATCH] D57893: [analyzer] Fix function macro crash

Szelethus accepted this revision. Szelethus added a comment. This revision is now accepted and ready to land. Awesome, thanks! Will commit around next Friday. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57893/new/ https://reviews.llvm.org/D57893

[PATCH] D57267: [AST] Factor out the logic of the various Expr::Ignore*

riccibruno added subscribers: rnk, void. riccibruno added a comment. @void @rnk Perhaps you can comment on this: currently `Expr::IgnoreImpCasts` skips `FullExpr`s, but `Expr::IgnoreParenImpCasts` only skips (via `IgnoreParens`) `ConstantExpr`s. Is there any reason for this inconsistency ? I

[PATCH] D54978: Move the SMT API to LLVM

thakis added a comment. In D54978#1389110 , @brzycki wrote: > This commit is causing a build-break for our nightly cross compilers of arm > and aarch64. The immediately preceding commit of D54977 > does not break with

[PATCH] D57127: [analyzer] Port RetainSummaryManager to the new GenericCall interface, decouple ARCMT from the analyzer

thakis added a comment. Herald added a project: clang. Did you see the "Should we remove this check that currently requires ENABLE_ARCMT => ENABLE_SA? http://llvm-cs.pcc.me.uk/tools/clang/CMakeLists.txt#441; question? In D57127#1373949 ,

[PATCH] D57936: [CodeGenObjC] When available, emit a direct call to objc_alloc_init(cls) instead of [objc_alloc(cls) init]

gparker42 added inline comments. Comment at: clang/lib/CodeGen/CGObjC.cpp:459 + llvm::Value *Receiver = + CGF.CGM.getObjCRuntime().GetClass(CGF, ObjTy->getInterface()); + return CGF.EmitObjCAllocInit(Receiver, CGF.ConvertType(OME->getType())); gparker42

[PATCH] D57739: [clangd] Format tweak's replacements.

sammccall added a comment. In D57739#1390315 , @ilya-biryukov wrote: > In D57739#1390252 , @sammccall wrote: > > > I agree with this concern, and don't think this is an appropriate layer to > > be aware of

[PATCH] D57943: [clangd] **Prototype**: clang-tidy-based tweaks

hokein added a comment. This is my experiment of playing around tweaks, I think we'll need this. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57943/new/ https://reviews.llvm.org/D57943 ___ cfe-commits

[PATCH] D40988: Clang-format: add finer-grained options for putting all arguments on one line

aol-nnov added a comment. would love such a feature too! also, there is kind of similar review https://reviews.llvm.org/D14484?id=39647 (by @djasper , also rejected. which is really sad) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D40988/new/ https://reviews.llvm.org/D40988

[PATCH] D56370: [clangd] Add support for type hierarchy (super types only for now)

sammccall added a comment. Updated reviewers line to reflect (I think) current reality so this doesn't get lost, but feel free to reassign as you'd prefer. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56370/new/ https://reviews.llvm.org/D56370

[PATCH] D57946: [libclang] Add attribute support for 'convergent'.

hhlin created this revision. hhlin added reviewers: yvvan, aaron.ballman, Anastasia. hhlin created this object with visibility "All Users". Herald added subscribers: cfe-commits, arphaman. Herald added a reviewer: serge-sans-paille. Herald added a project: clang. This bumps CINDEX_VERSION_MINOR

[PATCH] D57577: Make predefined FLT16 macros conditional on support for the type

SjoerdMeijer accepted this revision. SjoerdMeijer added a comment. This revision is now accepted and ready to land. Looks okay to me, with one nit inline. Comment at: test/Preprocessor/init.c:9169 // WEBASSEMBLY-NEXT:#define __FLOAT128__ 1 -// WEBASSEMBLY-NEXT:#define

[PATCH] D57893: [analyzer] Fix function macro crash

bruntib updated this revision to Diff 185957. bruntib added a comment. I've added a test case. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57893/new/ https://reviews.llvm.org/D57893 Files: lib/StaticAnalyzer/Core/PlistDiagnostics.cpp

[PATCH] D57951: [Lex] Allow to set missing include error to not fatal

yvvan created this revision. yvvan added reviewers: ilya-biryukov, nik. For IDE it's a nice feature to not get a fatal error and continue preprocessing even if the file is missing. This allows include further files and get more relevant information about the current translation unit.

[clang-tools-extra] r353523 - [clang-tidy][NFC] Test commit. Add missing comma.

Author: ymandel Date: Fri Feb 8 06:57:22 2019 New Revision: 353523 URL: http://llvm.org/viewvc/llvm-project?rev=353523=rev Log: [clang-tidy][NFC] Test commit. Add missing comma. Modified: clang-tools-extra/trunk/clang-tidy/readability/ConstReturnTypeCheck.cpp Modified:

[PATCH] D56370: [clangd] Add support for type hierarchy (super types only for now)

kadircet added a subscriber: sammccall. kadircet added a comment. Implementation LG, but I am not sure about adding a functionality on a proposal that might change. WDYT @sammccall ? Comment at: clang-tools-extra/clangd/FindSymbols.cpp:16 #include "SourceCode.h" +#include

[PATCH] D57944: [clangd] Fix an assertion in TypoCorrection.

ioeric created this revision. ioeric added reviewers: sammccall, hokein. Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. https://github.com/clangd/clangd/issues/7 Repository: rCTE Clang Tools Extra

[PATCH] D55250: [clangd] Enhance macro hover to see full definition

malaperle updated this revision to Diff 185959. malaperle marked an inline comment as not done. malaperle added a comment. Remove temporary code. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55250/new/ https://reviews.llvm.org/D55250 Files:

[PATCH] D57950: [clangd] Index parameters in function decls

kadircet planned changes to this revision. kadircet added a comment. Also enable `IndexParametersInDeclarations` in symbolcollector Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57950/new/ https://reviews.llvm.org/D57950

[PATCH] D57949: [clang][Index] Add a knob to index function parameters in declarations

kadircet created this revision. kadircet added reviewers: hokein, akyrtzi. Herald added subscribers: cfe-commits, arphaman, ioeric, ilya-biryukov. Herald added a project: clang. Parameters in declarations are useful for clangd, so that we can provide symbol information for them as well. It also

[PATCH] D57950: [clangd] Index parameters in function decls

kadircet created this revision. kadircet added a reviewer: hokein. Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay, ioeric, ilya-biryukov. Herald added a project: clang. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D57950 Files: clangd/XRefs.cpp

[PATCH] D57943: [clangd] **Prototype**: clang-tidy-based tweaks

hokein created this revision. Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay, ioeric, ilya-biryukov, mgorny. Herald added a project: clang. clang-tidy has already provided some simple refactoring-like checks (e.g. modernize-use-auto, modernize-use-using), so we can

[PATCH] D57896: Variable names rule

MyDeveloperDay added a comment. > I personally would be happy to change the settings from `camelBack` to > `aNy_CasE`. Should we come up with a new style? UpperOrLowerCamelCase, I don't mind going and doing that in the readability-identifier-naming check, given that I just wrote up all the

[PATCH] D57949: [clang][Index] Add a knob to index function parameters in declarations

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. The change looks reasonable, I'd wait for a few days before commit in case anyone has concerns. Comment at: include/clang/Index/IndexingAction.h:47 bool

[PATCH] D57063: [CMake] Unify scripts for generating VCS headers

mgorny added a comment. (apparently because the `CMAKE_MODULE_PATH` logic relies on going backwards to find `cmake/modules` and does not account that the modules will actually be in the same directory) Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57063/new/

[PATCH] D57063: [CMake] Unify scripts for generating VCS headers

mgorny added a comment. @phosek, I'm sorry to say but this is apparently breaking stand-alone clang builds: FAILED: lib/Basic/VCSVersion.inc cd /var/tmp/portage/sys-devel/clang-/work/x/y/clang--abi_x86_64.amd64/lib/Basic && /usr/bin/cmake -DNAMES="LLVM;CLANG" -DLLVM_SOURCE_DIR=

[PATCH] D57936: [CodeGenObjC] When available, emit a direct call to objc_alloc_init(cls) instead of [objc_alloc(cls) init]

gparker42 added inline comments. Comment at: clang/lib/CodeGen/CGObjC.cpp:459 + llvm::Value *Receiver = + CGF.CGM.getObjCRuntime().GetClass(CGF, ObjTy->getInterface()); + return CGF.EmitObjCAllocInit(Receiver, CGF.ConvertType(OME->getType())); rjmccall

[PATCH] D57852: [clang-tidy] Don't use assignment for value-initialized enums

JonasToth accepted this revision. JonasToth added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57852/new/ https://reviews.llvm.org/D57852

[PATCH] D56370: [clangd] Add support for type hierarchy (super types only for now)

sammccall added a comment. In D56370#1390283 , @kadircet wrote: > Implementation LG, but I am not sure about adding a functionality on a > proposal that might change. WDYT @sammccall ? We discussed this a bit on the thread, I think we should follow the

[PATCH] D57674: [clang-tidy] Add options to bugprone-argument-comment to add missing argument comments to literals

MyDeveloperDay updated this revision to Diff 185947. MyDeveloperDay marked 2 inline comments as done. MyDeveloperDay added a comment. Pre-Commit Changes - add FIXME wording to test - move local header include after libraries - rebase CHANGES SINCE LAST ACTION

[PATCH] D57944: [clangd] Fix an assertion in TypoCorrection.

hokein accepted this revision. hokein added inline comments. This revision is now accepted and ready to land. Comment at: clangd/IncludeFixer.cpp:195 -assert(S && "Enclosing scope must be set."); - UnresolvedName Unresolved; Unresolved.Name = Typo.getAsString();

[clang-tools-extra] r353514 - [clangd] Fix an assertion in TypoCorrection.

Author: ioeric Date: Fri Feb 8 05:27:47 2019 New Revision: 353514 URL: http://llvm.org/viewvc/llvm-project?rev=353514=rev Log: [clangd] Fix an assertion in TypoCorrection. Summary: https://github.com/clangd/clangd/issues/7 Reviewers: sammccall, hokein Subscribers: ilya-biryukov, MaskRay,

[PATCH] D57951: [Lex] Allow to set missing include error to not fatal

yvvan added a comment. I've tested it with libclang. If something else is needed for proper clangd args forwarding - let me know. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57951/new/ https://reviews.llvm.org/D57951 ___ cfe-commits

[PATCH] D57906: [CTU] Do not allow different CPP dialects in CTU

r.stahl added inline comments. Comment at: lib/CrossTU/CrossTranslationUnit.cpp:255 + // in the other unit it has none. + if (LangTo.CPlusPlus11 != LangFrom.CPlusPlus11 || + LangTo.CPlusPlus14 != LangFrom.CPlusPlus14 || This is likely to become a bug in

[PATCH] D57906: [CTU] Do not allow different CPP dialects in CTU

Quuxplusone added a comment. > Consider this STL code: > > template > struct __alloc_traits > #if __cplusplus >= 201103L > : std::allocator_traits<_Alloc> > #endif > { // ... > }; > > > This class template would create ODR errors during merging the two units, > since in

[PATCH] D57923: [Format/ObjC] Fix [foo bar]->baz formatting as lambda arrow

This revision was automatically updated to reflect the committed changes. Closed by commit rC353531: [Format/ObjC] Fix [foo bar]-baz formatting as lambda arrow (authored by benhamilton, committed by ). Changed prior to commit: https://reviews.llvm.org/D57923?vs=185859=185975#toc Repository:

[PATCH] D56849: [ASTMatchers][NFC] Update comments on assorted `CXXMemberCallExpr` matchers.

ymandel updated this revision to Diff 185977. ymandel added a comment. Sync with head. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56849/new/ https://reviews.llvm.org/D56849 Files: clang/docs/LibASTMatchersReference.html

[PATCH] D40720: No -fsanitize=function warning when calling noexcept function through non-noexcept pointer in C++17

riccibruno added a comment. Herald added a project: clang. It seems to be causing https://bugs.llvm.org/show_bug.cgi?id=40658. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D40720/new/ https://reviews.llvm.org/D40720

[PATCH] D54978: Move the SMT API to LLVM

thakis added a comment. Thanks for the analysis. I think it's fine if you revert, given that. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54978/new/ https://reviews.llvm.org/D54978 ___ cfe-commits mailing list

Re: [PATCH] D57898: [RFC] Split constant structures generated by -ftrivial-auto-var-init when emitting initializators

Still unsure about the heuristic here. I believe that for auto-initialization we want to be quite aggressive with these splits (unlike for regular constant stores). Perhaps we should do the split in the case all bytes are pattern bytes? (This is probably another use case for `forInit`) On Fri,

[clang-tools-extra] r353525 - [clang-tidy][NFC] Fix typo.

Author: ymandel Date: Fri Feb 8 07:05:57 2019 New Revision: 353525 URL: http://llvm.org/viewvc/llvm-project?rev=353525=rev Log: [clang-tidy][NFC] Fix typo. Fix placement of comma from previous (test) commit. Modified: clang-tools-extra/trunk/clang-tidy/readability/ConstReturnTypeCheck.cpp

[PATCH] D57946: [libclang] Add attribute support for 'convergent'.

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57946/new/ https://reviews.llvm.org/D57946

r353532 - [ASTMatchers][NFC] Update comments on assorted `CXXMemberCallExpr` matchers.

Author: ymandel Date: Fri Feb 8 08:00:44 2019 New Revision: 353532 URL: http://llvm.org/viewvc/llvm-project?rev=353532=rev Log: [ASTMatchers][NFC] Update comments on assorted `CXXMemberCallExpr` matchers. Specifically: * fixes the comments on `hasObjectExpression`, * clarifies comments on

[PATCH] D56849: [ASTMatchers][NFC] Update comments on assorted `CXXMemberCallExpr` matchers.

This revision was automatically updated to reflect the committed changes. Closed by commit rC353532: [ASTMatchers][NFC] Update comments on assorted `CXXMemberCallExpr` matchers. (authored by ymandel, committed by ). Changed prior to commit: https://reviews.llvm.org/D56849?vs=185977=185978#toc

[clang-tools-extra] r353535 - [clang-tidy] Add options to bugprone-argument-comment to add missing argument comments to literals

Author: paulhoad Date: Fri Feb 8 09:00:01 2019 New Revision: 353535 URL: http://llvm.org/viewvc/llvm-project?rev=353535=rev Log: [clang-tidy] Add options to bugprone-argument-comment to add missing argument comments to literals bugprone-argument-comment only supports identifying those comments

[PATCH] D57898: CodeGen: Fix PR40605: split constant structures generated by -ftrivial-auto-var-init when emitting initializators

jfb added a comment. Can you add a link to bug 40605 in the commit message? > I'm not quite sure how to show the resulting difference in code. Do you mean > we need Clang to support both modes and to compare the resulting assembly? I only meant tests that show codegen, as you've now added

[PATCH] D54978: Move the SMT API to LLVM

brzycki added a comment. > From what I understand, setting `-DLLVM_ENABLE_Z3_SOLVER=OFF` is supposed to > work Hello @thakis, I have reduced it down to the minimal required flags on Ubuntu 18.04. I ran this on llvm-project SHA b0a227049fda9d0d229ea801ae77bf1b812f7328

r353541 - Revert "[OPENMP]Initial support for the delayed diagnostics."

Author: abataev Date: Fri Feb 8 09:42:00 2019 New Revision: 353541 URL: http://llvm.org/viewvc/llvm-project?rev=353541=rev Log: Revert "[OPENMP]Initial support for the delayed diagnostics." This reverts commit r353540. Erroneously committed, need to fix the message and description. Modified:

r353542 - [OPENMP]Delay emission of the error messages for the exceptions.

Author: abataev Date: Fri Feb 8 10:02:25 2019 New Revision: 353542 URL: http://llvm.org/viewvc/llvm-project?rev=353542=rev Log: [OPENMP]Delay emission of the error messages for the exceptions. Fixed diagnostic emission for the exceptions support in case of the compilation of OpenMP code for the

[PATCH] D57950: [clangd] Index parameters in function decls

kadircet updated this revision to Diff 185967. kadircet added a comment. This revision is now accepted and ready to land. Also index function params in findrefs Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57950/new/

r353531 - [Format/ObjC] Fix [foo bar]->baz formatting as lambda arrow

Author: benhamilton Date: Fri Feb 8 07:55:18 2019 New Revision: 353531 URL: http://llvm.org/viewvc/llvm-project?rev=353531=rev Log: [Format/ObjC] Fix [foo bar]->baz formatting as lambda arrow Summary: Currently, `UnwrappedLineParser` thinks an arrow token after an ObjC method expression is a

[PATCH] D57265: [PM/CC1] Add -f[no-]split-cold-code CC1 options to toggle splitting

tejohnson added a comment. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Overall it looks ok to me, but I'd like Chandler to comment regarding the preferred way to do this with the new PM, since we don't tend to use booleans there in the PassBuilder to control passes.

[PATCH] D57898: CodeGen: Fix PR40605: split constant structures generated by -ftrivial-auto-var-init when emitting initializators

glider added a comment. Re: case when STy != Loc.getElementType() - this is already covered by other Clang tests. I'm still unsure about the heuristic here. I believe that for auto-initialization we want to be quite aggressive with these splits (unlike for regular constant stores). Perhaps we

[PATCH] D57893: [analyzer] Fix function macro crash

bruntib updated this revision to Diff 185971. bruntib added a comment. There was another place where this crash could have happened. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57893/new/ https://reviews.llvm.org/D57893 Files: lib/StaticAnalyzer/Core/PlistDiagnostics.cpp

[PATCH] D57898: CodeGen: Fix PR40605: split constant structures generated by -ftrivial-auto-var-init when emitting initializators

glider updated this revision to Diff 185990. glider retitled this revision from "[RFC] Split constant structures generated by -ftrivial-auto-var-init when emitting initializators" to "CodeGen: Fix PR40605: split constant structures generated by -ftrivial-auto-var-init when emitting

[PATCH] D57674: [clang-tidy] Add options to bugprone-argument-comment to add missing argument comments to literals

This revision was automatically updated to reflect the committed changes. Closed by commit rL353535: [clang-tidy] Add options to bugprone-argument-comment to add missing argument… (authored by paulhoad, committed by ). Herald added a project: LLVM. Changed prior to commit:

r353540 - [OPENMP]Initial support for the delayed diagnostics.

Author: abataev Date: Fri Feb 8 09:38:09 2019 New Revision: 353540 URL: http://llvm.org/viewvc/llvm-project?rev=353540=rev Log: [OPENMP]Initial support for the delayed diagnostics. It is important to delay the emission of the diagnostic messages for the functions unless it is proved that the

[PATCH] D57961: [X86] Add explicit alignment to __m128/__m128i/__m128d/etc. to allow matching of MSVC behavior with #pragma pack.

craig.topper created this revision. craig.topper added reviewers: rnk, erichkeane, spatel, RKSimon. Herald added a project: clang. With MSVC, #pragma pack is ignored when there is explicit alignment. This differs from gcc. Clang emulates this difference when compiling for Windows. It appears

[PATCH] D57961: [X86] Add explicit alignment to __m128/__m128i/__m128d/etc. to allow matching of MSVC behavior with #pragma pack.

erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. The justification is correct based on my research into this problem, and the code changes themselves look correct. I cannot think of any reason why re-stating the alignment will

[PATCH] D57086: Ignore trailing NullStmts in StmtExprs for GCC compatibility

rsmith added a comment. You'll also need to update `TreeTransform::TransformCompoundStmt`. (And please add some tests for template instantiation.) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57086/new/ https://reviews.llvm.org/D57086

[PATCH] D57267: [AST] Factor out the logic of the various Expr::Ignore*

riccibruno added a comment. > I don't think there was an explicit reason beyond "I didn't need to do it at > the time". So probably just an oversight on my part. I don't know the code > nearly as well as @rnk, so I could be wrong, but I think the existing tests > should tell you if something

[PATCH] D57267: [AST] Factor out the logic of the various Expr::Ignore*

riccibruno added a comment. > FWIW, I was rather disappointed in a recent review to learn that > IgnoreParens() means "ignore parens... and a whole bunch of other stuff like > generic selection expressions". +1 Indeed. Repository: rC Clang CHANGES SINCE LAST ACTION

r353566 - [analyzer] Opt-in C Style Cast Checker for OSObject pointers

Author: george.karpenkov Date: Fri Feb 8 13:09:00 2019 New Revision: 353566 URL: http://llvm.org/viewvc/llvm-project?rev=353566=rev Log: [analyzer] Opt-in C Style Cast Checker for OSObject pointers Differential Revision: https://reviews.llvm.org/D57261 Added:

[PATCH] D57898: CodeGen: Fix PR40605: split constant structures generated by -ftrivial-auto-var-init when emitting initializators

glider added a comment. > Can you add a link to bug 40605 in the commit message? It's in the title now, doesn't that count? :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57898/new/ https://reviews.llvm.org/D57898 ___ cfe-commits

[PATCH] D57961: [X86] Add explicit alignment to __m128/__m128i/__m128d/etc. to allow matching of MSVC behavior with #pragma pack.

rnk accepted this revision. rnk added a subscriber: rjmccall. rnk added a comment. Sounds good. This change reminded me of D46042 , https://crbug.com/849251, and rL333791 , which I had to revert, and I don't think it relanded.

[PATCH] D57965: Clean up ObjCPropertyDecl printing

dgoldman created this revision. Herald added subscribers: cfe-commits, jfb, arphaman. Herald added a project: clang. - `@property(attr, attr2)` instead of `@property ( attr,attr2 )`. - Change priority of attributes (see code/comments inline). - Support for printing weak and unsafe_unretained

[PATCH] D57918: Add an attribute that causes clang to emit fortified calls to C stdlib functions

erik.pilkington updated this revision to Diff 186013. erik.pilkington marked 5 inline comments as done. erik.pilkington added a comment. Address John's comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57918/new/ https://reviews.llvm.org/D57918 Files:

[PATCH] D57918: Add an attribute that causes clang to emit fortified calls to C stdlib functions

erik.pilkington added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:986 + } + }]; +} rjmccall wrote: > Probably worth clarifying somewhere in here that only a specific set of > stdlib functions are supported. I don't know that it's

[PATCH] D57918: Add an attribute that causes clang to emit fortified calls to C stdlib functions

erik.pilkington added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:987 + +Only a specific set of standard library functions are supported: + - memcpy aaron.ballman wrote: > And we don't have Annex K versions for any of these, like

[PATCH] D57918: Add an attribute that causes clang to emit fortified calls to C stdlib functions

erik.pilkington updated this revision to Diff 186028. erik.pilkington marked 2 inline comments as done. erik.pilkington added a comment. Describe what the arguments do in the docs. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57918/new/ https://reviews.llvm.org/D57918 Files:

[PATCH] D57270: [ObjC] Fix non-canonical types preventing type arguments substitution.

vsapsai added a comment. Ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57270/new/ https://reviews.llvm.org/D57270 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D57628: [index] Improve indexing support for MSPropertyDecl.

vsapsai added a comment. Ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57628/new/ https://reviews.llvm.org/D57628 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D57874: [WebAssembly] Make thread-related options consistent

tlively added a comment. In D57874#1391116 , @tlively wrote: > In D57874#1389953 , @aheejin wrote: > > > - `-matomics` means `-mthread-model posix` > > > Why should this be the case? Atomic instructions are

[PATCH] D57874: [WebAssembly] Make thread-related options consistent

tlively added a comment. In D57874#1389953 , @aheejin wrote: > - `-matomics` means `-mthread-model posix` Why should this be the case? Atomic instructions are necessary for multithreading, but I wouldn't think multithreading would be necessary for

Re: r328173 - Improve -Winfinite-recursion

Hi Robert I ping'ed this commit on Phabricator with an example of false positive introduced by this patch. Can you take a look? Thanks Steven > On Mar 21, 2018, at 8:16 PM, Robert Widmann via cfe-commits > wrote: > > Author: codafi > Date: Wed Mar 21 20:16:23 2018 > New Revision: 328173 >

[PATCH] D57918: Add an attribute that causes clang to emit fortified calls to C stdlib functions

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/Attr.td:1572 + let Spellings = [Clang<"fortify_stdlib">]; + let Args = [IntArgument<"Type">, IntArgument<"Flag">]; + let Subjects = SubjectList<[Function]>; Nothing in the docs

[PATCH] D57267: [AST] Factor out the logic of the various Expr::Ignore*

void added a comment. In D57267#1390484 , @riccibruno wrote: > @void @rnk Perhaps you can comment on this: currently `Expr::IgnoreImpCasts` > skips `FullExpr`s, but `Expr::IgnoreParenImpCasts` only skips (via > `IgnoreParens`) `ConstantExpr`s. Is there

  1   2   >