[PATCH] D56571: [RFC prototype] Implementation of asm-goto support in clang

nickdesaulniers added inline comments. Comment at: test/CodeGen/asm.c:276 + return 1; +} I don't understand why, but this particular test case I cannot compile standalone without `-emit-llvm`. ``` int t32(int cond) { asm goto("testl %0, %0; jne %l1;" :: "r"(c

[PATCH] D56571: [RFC prototype] Implementation of asm-goto support in clang

nickdesaulniers marked an inline comment as done. nickdesaulniers added inline comments. Comment at: test/CodeGen/asm.c:276 + return 1; +} nickdesaulniers wrote: > I don't understand why, but this particular test case I cannot compile > standalone without `-emi

[PATCH] D44865: [libc++] Implement P0608R3 - A sane variant converting constructor

lichray added a comment. Ping @mclow.lists @EricWF ; the patch still applies, is there any other thing I need to address? Repository: rCXX libc++ CHANGES SINCE LAST ACTION https://reviews.llvm.org/D44865/new/ https://reviews.llvm.org/D44865

[PATCH] D33841: [clang-tidy] redundant keyword check

MyDeveloperDay added inline comments. Comment at: clang-tidy/readability/RedundantExternCheck.cpp:45 + + int offset = Text.find("extern"); + current convention would be that this should be Offset CHANGES SINCE LAST ACTION https://reviews.llvm.org/D33841/new/

[PATCH] D58016: fixes copy constructor generation of classes containing 0-length arrays followed by exactly 1 trivial field (fixes #40682)

jbigalet created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D58016 Files: clang/lib/CodeGen/CGClass.cpp Index: clang/lib/CodeGen/CGClass.cpp =

[PATCH] D58016: fixes copy constructor generation of classes containing 0-length arrays followed by exactly 1 trivial field (fixes #40682)

lebedev.ri added a comment. Test? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58016/new/ https://reviews.llvm.org/D58016 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org

[PATCH] D58016: fixes copy constructor generation of classes containing 0-length arrays followed by exactly 1 trivial field (fixes #40682)

jbigalet added a comment. Fixes #40682 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58016/new/ https://reviews.llvm.org/D58016 ___ cfe-commits mailing lis

[PATCH] D58016: fixes copy constructor generation of classes containing 0-length arrays followed by exactly 1 trivial field (fixes #40682)

jbigalet added a comment. @lebedev.ri not a test, did I forgot to add anything? (sorry, it's my first time here) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58016/new/ https://reviews.llvm.org/D58016 __

[PATCH] D54978: Move the SMT API to LLVM

mikhail.ramalho reopened this revision. mikhail.ramalho added a comment. This revision is now accepted and ready to land. Reopening the revision as it was reverted. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54978/new/ https://reviews.llvm.org/D54978 __

[PATCH] D54978: Move the SMT API to LLVM

mikhail.ramalho added a comment. @brzycki, I can't reproduce your error. Maybe you're missing `-DLLVM_ENABLE_Z3_SOLVER=OFF`? $ cmake -GNinja ../llvm -DLLVM_ENABLE_PROJECTS=clang -DBUILD_SHARED_LIBS=ON -DCMAKE_INSTALL_PREFIX=/home/mgadelha/myclang -DCMAKE_LINKER=/usr/bin/ld.gold -DLLVM_ENABLE

[PATCH] D54399: Move ExprMutationAnalyzer to Tooling/Analysis (1/3)

shuaiwang added a comment. In D54399#1391975 , @lebedev.ri wrote: > In D54399#1391935 , @shuaiwang wrote: > > > Hi @rsmith what do you think of just get this in since Eric is not > > responding? Or do you think I s

r353653 - Fix clang tests broken by r353547 that depend on InstrProf

Author: rnk Date: Sun Feb 10 12:17:07 2019 New Revision: 353653 URL: http://llvm.org/viewvc/llvm-project?rev=353653&view=rev Log: Fix clang tests broken by r353547 that depend on InstrProf Modified: cfe/trunk/test/CoverageMapping/unused_names.c cfe/trunk/test/Profile/cxx-lambda.cpp cf

r353654 - Fix test to pass on LLP64 targets

Author: rnk Date: Sun Feb 10 12:20:26 2019 New Revision: 353654 URL: http://llvm.org/viewvc/llvm-project?rev=353654&view=rev Log: Fix test to pass on LLP64 targets Modified: cfe/trunk/test/Analysis/osobjectcstylecastchecker_test.cpp Modified: cfe/trunk/test/Analysis/osobjectcstylecastchecker

[PATCH] D57893: [analyzer] Fix function macro crash

bruntib updated this revision to Diff 186161. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57893/new/ https://reviews.llvm.org/D57893 Files: lib/StaticAnalyzer/Core/PlistDiagnostics.cpp test/Analysis/Inputs/expected-plists/plist-macros-with-expansion.cpp.plist test/Analysis/plist-

[PATCH] D58016: fixes copy constructor generation of classes containing 0-length arrays followed by exactly 1 trivial field (fixes #40682)

jbigalet updated this revision to Diff 186162. jbigalet added a comment. regression test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58016/new/ https://reviews.llvm.org/D58016 Files: clang/lib/CodeGen/CGClass.cpp clang/test/CodeGenCXX/pod-me

r353656 - long double is double on OpenBSD/NetBSD/PPC.

Author: brad Date: Sun Feb 10 18:53:16 2019 New Revision: 353656 URL: http://llvm.org/viewvc/llvm-project?rev=353656&view=rev Log: long double is double on OpenBSD/NetBSD/PPC. Patch by George Koehler. Modified: cfe/trunk/lib/Basic/Targets/PPC.h cfe/trunk/test/CodeGen/powerpc_types.c Mod

r353658 - [CMake][Fuchsia] Drop libclang.so from distribution

Author: phosek Date: Sun Feb 10 21:38:01 2019 New Revision: 353658 URL: http://llvm.org/viewvc/llvm-project?rev=353658&view=rev Log: [CMake][Fuchsia] Drop libclang.so from distribution This is no longer needed now that all users have switched to clangd. Modified: cfe/trunk/cmake/caches/Fuchs

[PATCH] D57662: [clang-tidy] Parallelise clang-tidy-diff.py

zinovy.nis added a comment. Gentle ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57662/new/ https://reviews.llvm.org/D57662 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co