[PATCH] D58126: [clangd] Fix a lit-test.

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE353857: [clangd] Fix a lit-test. (authored by kadircet, committed by ). Changed prior to commit: https://reviews.llvm.org/D58126?vs=186475=186490#toc Repository: rCTE Clang Tools Extra CHANGES

Re: r353729 - Attempt to pacify bots more after r353718 and r353725

On 2/12/19 1:41 PM, Nico Weber wrote: > Thanks for reporting that this depends on the host compiler. > > I disabled the test again in r353836 and will look into why the output > is different depending on if host cc is gcc or clang. > Good. Thanks! When I've seen things like this before it's

[PATCH] D45978: dllexport const variables must have external linkage.

aaron.ballman added a comment. Oops, sorry, I think I added some comments to a previous revision of the review. To recap: 1. Remove the CHECK line from test/Sema/dllexport-1.cpp 2. Remove the second RUN line from test/Sema/dllexport-1.cpp and test/Sema/dllexport-2.cpp 3. Possibly remove the

[clang-tools-extra] r353857 - [clangd] Fix a lit-test.

Author: kadircet Date: Tue Feb 12 08:54:47 2019 New Revision: 353857 URL: http://llvm.org/viewvc/llvm-project?rev=353857=rev Log: [clangd] Fix a lit-test. Summary: Fixes https://bugs.llvm.org/show_bug.cgi?id=40593. Non-percent-encoded chars doesn't cause any problems on the input-side since we

[PATCH] D58121: [analyzer][WIP] Attempt to fix traversing bindings of non-base regions in ClusterAnalysis

xazax.hun updated this revision to Diff 186489. xazax.hun marked an inline comment as done. xazax.hun edited the summary of this revision. xazax.hun added a comment. Herald added a subscriber: jdoerfert. - Fix test failures. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58121/new/

[PATCH] D54978: Move the SMT API to LLVM

thakis added a comment. Herald added a subscriber: jdoerfert. >> If so, I don't understand why the default setting is important to you and >> why this doesn't work for you. (I don't disagree with the default being off, >> I'm just confused why things don't work for you.) > > As I have stated

[PATCH] D58095: [clang-tidy] Make google-objc-function-naming ignore implicit functions 

aaron.ballman added inline comments. Herald added a subscriber: jdoerfert. Comment at: clang-tools-extra/test/clang-tidy/google-objc-function-naming.m:10 +// function would be declared in a system header. +int printf(const char *, ...); // NOLINT(google-objc-function-naming) +

[PATCH] D45978: dllexport const variables must have external linkage.

zahiraam updated this revision to Diff 186460. zahiraam marked 3 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D45978/new/ https://reviews.llvm.org/D45978 Files: lib/Sema/SemaDecl.cpp test/CodeGen/dllexport.c test/Sema/dllexport-1.cpp

[PATCH] D45978: dllexport const variables must have external linkage.

zahiraam added a subscriber: z. zahiraam added inline comments. Comment at: test/Sema/dllexport-1.c:8 + +// CHECK: @y = common dso_local dllexport global i32 0, align 4 + aaron.ballman wrote: > Are x and z also exported as expected? Only x and y are exported.

[PATCH] D58121: [analyzer][WIP] Attempt to fix traversing bindings of non-base regions in ClusterAnalysis

xazax.hun created this revision. xazax.hun added a reviewer: NoQ. Herald added subscribers: gamesh411, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, whisperity. Herald added a project: clang. Follow up for a problem described in

[PATCH] D57898: CodeGen: Fix PR40605: split constant structures generated by -ftrivial-auto-var-init when emitting initializators

glider updated this revision to Diff 186469. glider marked an inline comment as done. glider added a subscriber: pcc. glider added a comment. Added a helper function to decide whether we want to break the structure or not. Right now it only checks for optimization level and structure size. The

[PATCH] D58126: [clangd] Fix a lit-test.

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay, ioeric, ilya-biryukov. Herald added a project: clang. Fixes https://bugs.llvm.org/show_bug.cgi?id=40593. Non-percent-encoded chars doesn't cause any problems

[PATCH] D58133: [clangd] Testcase for bug 39811

kadircet created this revision. Herald added subscribers: cfe-commits, jdoerfert, arphaman, jkorous, MaskRay, ioeric, ilya-biryukov. Herald added a project: clang. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D58133 Files: unittests/clangd/XRefsTests.cpp Index:

Re: r353729 - Attempt to pacify bots more after r353718 and r353725

Thanks for reporting that this depends on the host compiler. I disabled the test again in r353836 and will look into why the output is different depending on if host cc is gcc or clang. On Tue, Feb 12, 2019 at 2:40 AM Mikael Holmén wrote: > Same thing for me with our downstream build bots. > >

r353838 - Renaming this diagnostic to not conflict with another; NFC.

Author: aaronballman Date: Tue Feb 12 05:13:35 2019 New Revision: 353838 URL: http://llvm.org/viewvc/llvm-project?rev=353838=rev Log: Renaming this diagnostic to not conflict with another; NFC. Amends r353837 which renamed the diagnostics to conflict. Modified:

[PATCH] D57984: PR40642: Fix determination of whether the final statement of a statementexpression is a discarded-value expression.

aaron.ballman added a comment. Considering that this has been fertile ground for buggy edge cases, should we revert my original changes from the 8.0 branch to give this more time to bake on trunk before releasing? Or do you think this is fine to move onto the release branch once finalized?

[PATCH] D57236: [ASTImporter] Unify redecl chain tests as type parameterized tests

martong updated this revision to Diff 186445. martong added a comment. Herald added a subscriber: jdoerfert. - Remove numbers when possible - Use disabled tests instead of commented out tests Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57236/new/

[PATCH] D58120: [Builtins] Treat `bcmp` as a builtin.

courbet created this revision. courbet added a reviewer: jyknight. Herald added a subscriber: kristina. Herald added a project: clang. This makes it consistent with `memcmp` and `__builtin_bcmp`. Also see the discussion in https://reviews.llvm.org/D56593. Repository: rC Clang

[PATCH] D57898: CodeGen: Fix PR40605: split constant structures generated by -ftrivial-auto-var-init when emitting initializators

glider marked 4 inline comments as done. glider added inline comments. Herald added a subscriber: jdoerfert. Comment at: tools/clang/test/CodeGenCXX/auto-var-init.cpp:496 // ZERO-LABEL: @test_smallpartinit_uninit() // ZERO: call void @llvm.memset{{.*}}, i8 0,

[PATCH] D58067: [Analyzer] Crash fix for FindLastStoreBRVisitor

baloghadamsoftware updated this revision to Diff 186470. baloghadamsoftware marked 3 inline comments as not done. baloghadamsoftware added a comment. Herald added a subscriber: jdoerfert. Function renamed, comment updated. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58067/new/

[PATCH] D58065: [analyzer] Document the frontend library

Szelethus added a comment. Herald added a subscriber: jdoerfert. Please, in the first round of reviews, if you could make high level comments about what should or should not be here would be great, perfectly wrapping around the 80 column limit and finding typos don't concern me as much before

[PATCH] D58134: [Analysis] -Wunreachable-code shouldn't fire on the increment of a foreach loop

sammccall created this revision. sammccall added reviewers: ilya-biryukov, ioeric. Herald added a project: clang. Herald added a subscriber: cfe-commits. The idea is that the code here isn't written, so doesn't indicate a bug. Similar to code expanded from macros. This means the warning no

[PATCH] D17444: PR26672: [MSVC] Clang does not recognize "static_assert" keyword in C mode

thakis added a comment. Herald added a subscriber: jdoerfert. I don't have an opinion if this patch here or the assert wrapper is better, but I feel somewhat strongly that we should land one or the other so that the standard C program #include static_assert(4 == 4 , ""); builds in

r353839 - Renaming yet another diagnostic to not conflict; NFC.

Author: aaronballman Date: Tue Feb 12 05:19:02 2019 New Revision: 353839 URL: http://llvm.org/viewvc/llvm-project?rev=353839=rev Log: Renaming yet another diagnostic to not conflict; NFC. Modified: cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td cfe/trunk/lib/Sema/SemaDeclAttr.cpp

[PATCH] D57236: [ASTImporter] Unify redecl chain tests as type parameterized tests

martong marked 4 inline comments as done. martong added a comment. Thanks for the review Alexei! Comment at: unittests/AST/ASTImporterTest.cpp:3549 + void TypedTest_ImportDefinitionThenPrototype() { +Decl *FromTU0 = getTuDecl(getDefinition(), Lang_CXX, "input0.cc"); +

[PATCH] D58122: Restore Check for Unreachable Exit Block in -Winfinite-recursion

CodaFi created this revision. CodaFi added reviewers: steven_wu, rtrieu. Herald added a project: clang. Herald added a subscriber: cfe-commits. When this was rewritten in D43737 , the logic changed to better explore infinite loops. The check for a reachable exit

[PATCH] D45978: dllexport const variables must have external linkage.

aaron.ballman added inline comments. Comment at: test/Sema/dllexport-1.c:1 +// RUN: %clang_cc1 -triple i686-win32 -emit-llvm -fms-extensions -std=c99 < %s| FileCheck %s +// RUN: %clang_cc1 -triple x86_64-win32 -emit-llvm -fms-extensions -std=c11 < %s | FileCheck %s

r353836 - Disable test after r353718, r353725, r353729 while I investigate

Author: nico Date: Tue Feb 12 04:40:56 2019 New Revision: 353836 URL: http://llvm.org/viewvc/llvm-project?rev=353836=rev Log: Disable test after r353718, r353725, r353729 while I investigate Modified: cfe/trunk/test/CodeGen/ms-x86-intrinsics.c Modified:

r353837 - Fixing a typo; NFC.

Author: aaronballman Date: Tue Feb 12 05:04:11 2019 New Revision: 353837 URL: http://llvm.org/viewvc/llvm-project?rev=353837=rev Log: Fixing a typo; NFC. Modified: cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td cfe/trunk/lib/Sema/SemaDeclAttr.cpp Modified:

[PATCH] D58111: [Sema] Fix a crash in access checking for deduction guides

ilya-biryukov updated this revision to Diff 186447. ilya-biryukov marked an inline comment as done. ilya-biryukov added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58111/new/ https://reviews.llvm.org/D58111 Files:

[PATCH] D58111: [Sema] Fix a crash in access checking for deduction guides

This revision was automatically updated to reflect the committed changes. Closed by commit rC353840: [Sema] Fix a crash in access checking for deduction guides (authored by ibiryukov, committed by ). Changed prior to commit: https://reviews.llvm.org/D58111?vs=186447=186450#toc Repository:

r353840 - [Sema] Fix a crash in access checking for deduction guides

Author: ibiryukov Date: Tue Feb 12 06:21:44 2019 New Revision: 353840 URL: http://llvm.org/viewvc/llvm-project?rev=353840=rev Log: [Sema] Fix a crash in access checking for deduction guides Summary: See the added test for a repro. Reviewers: sammccall Reviewed By: sammccall Subscribers:

[PATCH] D58074: [OpenMP 5.0] Parsing/sema support for map clause with mapper modifier

ABataev added a comment. Herald added a subscriber: jdoerfert. Also, need some kind of the stubbed codegen for the mapper Comment at: include/clang/AST/OpenMPClause.h:4236 + static OMPMapClause * + Create(const ASTContext , SourceLocation StartLoc, SourceLocation LParenLoc,

[PATCH] D57230: [analyzer] Toning down invalidation a bit

xazax.hun added a comment. Herald added a subscriber: jdoerfert. Experimental patch is up in https://reviews.llvm.org/D58121 Unfortunately, it is not perfect yet. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57230/new/ https://reviews.llvm.org/D57230

[PATCH] D54978: Move the SMT API to LLVM

brzycki added a comment. In D54978#1394613 , @thakis wrote: > Got it now, sorry about being dense. No problem, I appreciate you looking into this. :) I hope to have some time in the next few days to help out and debug this further. Repository: rC

[PATCH] D58126: [clangd] Fix a lit-test.

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Hmm, this removes a useful assertion, and still leaves us sending invalid (or at least non-canonical) URIs in the input. But I don't see a better fix really - lit tests are painful :-(

[PATCH] D57948: [Sema] Fix a regression introduced in "[AST][Sema] Remove CallExpr::setNumArgs"

riccibruno updated this revision to Diff 186449. riccibruno added a comment. Rewrote the patch to make it local to `BuildResolvedCallExpr`. It is still a hack though. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57948/new/ https://reviews.llvm.org/D57948

r353853 - [CMake][Fuchsia] Pass -ldl -lpthread LDFLAGS to second stage

Author: phosek Date: Tue Feb 12 08:24:46 2019 New Revision: 353853 URL: http://llvm.org/viewvc/llvm-project?rev=353853=rev Log: [CMake][Fuchsia] Pass -ldl -lpthread LDFLAGS to second stage We're using static libc++ for the second stage which requires explicitly linking -ldl and -lpthread.

[PATCH] D58128: [PowerPC] Stop defining _ARCH_PWR6X on POWER7 and up

hubert.reinterpretcast created this revision. hubert.reinterpretcast added reviewers: echristo, hfinkel, kbarton, nemanjai, wschmidt. Herald added a subscriber: jsji. Herald added a project: clang. The predefined macro `_ARCH_PWR6X` is associated with GCC's `-mcpu=power6x` option, which enables

[PATCH] D58074: [OpenMP 5.0] Parsing/sema support for map clause with mapper modifier

lildmh marked 11 inline comments as done. lildmh added a comment. Hi Alexey, Thanks very much for your quick review! For the codegen, currently I'm thinking to do it within declare target codegen functions. So there is not a very clear interface to do mapper codegen (also, there is not a

[PATCH] D58074: [OpenMP 5.0] Parsing/sema support for map clause with mapper modifier

ABataev added inline comments. Comment at: lib/Sema/SemaLookup.cpp:1074 + if (NameKind == LookupOMPMapperName) { +// Skip out-of-scope declarations. lildmh wrote: > ABataev wrote: > > lildmh wrote: > > > ABataev wrote: > > > > Why do we need special

[PATCH] D57232: [ASTImporter] Check visibility/linkage of functions and variables

shafik accepted this revision. shafik added a comment. This revision is now accepted and ready to land. Herald added a subscriber: jdoerfert. I ran `check-lldb` locally and it looks good. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57232/new/

Re: [PATCH] D57984: PR40642: Fix determination of whether the final statement of a statementexpression is a discarded-value expression.

On Tue, 12 Feb 2019, 05:28 Aaron Ballman via Phabricator via cfe-commits, < cfe-commits@lists.llvm.org> wrote: > aaron.ballman added a comment. > > Considering that this has been fertile ground for buggy edge cases, should > we revert my original changes from the 8.0 branch to give this more time

[PATCH] D56871: [AMDGPU] Require at least protected visibility for certain symbols

This revision was automatically updated to reflect the committed changes. Closed by commit rL353870: [AMDGPU] Require at least protected visibility for certain symbols (authored by scott.linder, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior

[PATCH] D57662: [clang-tidy] Parallelise clang-tidy-diff.py

zinovy.nis updated this revision to Diff 186514. zinovy.nis added a comment. `-j` and `-export-fixes` were made mutually exclusive. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57662/new/ https://reviews.llvm.org/D57662 Files: clang-tidy/tool/clang-tidy-diff.py Index:

[PATCH] D58074: [OpenMP 5.0] Parsing/sema support for map clause with mapper modifier

lildmh updated this revision to Diff 186492. lildmh marked 3 inline comments as done. lildmh added a comment. Fix part of Alexey's comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58074/new/ https://reviews.llvm.org/D58074 Files: include/clang/AST/OpenMPClause.h

[PATCH] D58135: [clangd] Handle a few more diag kinds in include fixer.

ioeric created this revision. ioeric added a reviewer: sammccall. Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D58135 Files: clangd/IncludeFixer.cpp

[PATCH] D58128: [PowerPC] Stop defining _ARCH_PWR6X on POWER7 and up

hfinkel accepted this revision. hfinkel added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58128/new/ https://reviews.llvm.org/D58128 ___ cfe-commits

[PATCH] D58135: [clangd] Handle a few more diag kinds in include fixer.

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Nice! Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58135/new/ https://reviews.llvm.org/D58135

[PATCH] D58074: [OpenMP 5.0] Parsing/sema support for map clause with mapper modifier

lildmh marked 2 inline comments as done. lildmh added inline comments. Comment at: include/clang/AST/OpenMPClause.h:4236 + static OMPMapClause * + Create(const ASTContext , SourceLocation StartLoc, SourceLocation LParenLoc, + SourceLocation EndLoc, ArrayRef Vars,

[PATCH] D58074: [OpenMP 5.0] Parsing/sema support for map clause with mapper modifier

lildmh marked an inline comment as done. lildmh added inline comments. Comment at: lib/Sema/SemaLookup.cpp:1074 + if (NameKind == LookupOMPMapperName) { +// Skip out-of-scope declarations. ABataev wrote: > lildmh wrote: > > ABataev wrote: > > > lildmh

[PATCH] D54978: Move the SMT API to LLVM

brzycki added a comment. The following patch: diff --git a/llvm/cmake/modules/CrossCompile.cmake b/llvm/cmake/modules/CrossCompile.cmake index bc3b210f018..0c30b88f80f 100644 --- a/llvm/cmake/modules/CrossCompile.cmake +++ b/llvm/cmake/modules/CrossCompile.cmake @@ -53,6 +53,7 @@

r353870 - [AMDGPU] Require at least protected visibility for certain symbols

Author: scott.linder Date: Tue Feb 12 10:30:38 2019 New Revision: 353870 URL: http://llvm.org/viewvc/llvm-project?rev=353870=rev Log: [AMDGPU] Require at least protected visibility for certain symbols This allows the global visibility controls to be restrictive while still populating the dynamic

[PATCH] D57977: [HIP] compile option code-object-v3 propagate to llc

kzhuravl added a comment. Can you add some tests? Preferably with -mxnack/-mno-xnack, -msram-ecc/-mno-sram-ecc, -mcode-object-v3/-mno-code-object-v3 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57977/new/ https://reviews.llvm.org/D57977

[PATCH] D57736: [WebAssembly] Bulk memory intrinsics and builtins

tlively updated this revision to Diff 186504. tlively added a comment. - Update tests to check full polymorphism of llvm.memcpy and llvm.memmove Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57736/new/ https://reviews.llvm.org/D57736 Files:

[PATCH] D56305: [AArch64] Support reserving arbitrary general purpose registers

trong accepted this revision. trong added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Driver/ToolChains/Arch/AArch64.cpp:318 + if (Args.hasArg(options::OPT_ffixed_x0)) +Features.push_back("+reserve-x0"); trong

[PATCH] D58072: Make ModuleDependencyCollector's method virtual (NFC)

bruno added a comment. I missed that the `DependencyCollector` already marks them virtual, you are just making it obvious here. I think you can omit the ones that are already virtual and only add to the ones that are on the intend of this patch. Repository: rC Clang CHANGES SINCE LAST

[PATCH] D57961: [X86] Add explicit alignment to __m128/__m128i/__m128d/etc. to allow matching of MSVC behavior with #pragma pack.

rnk added a comment. I audited all the intrin header uses of __packed__, and I think this was the only one that was missing, so I'll try to fix forward. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57961/new/ https://reviews.llvm.org/D57961

[PATCH] D57977: [HIP] compile option code-object-v3 propagate to llc

kzhuravl accepted this revision. kzhuravl added a comment. This revision is now accepted and ready to land. LGTM. Please make sure to update your commit message as your patch processes all m options now. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57977/new/

[PATCH] D56305: [AArch64] Support reserving arbitrary general purpose registers

trong added inline comments. Herald added a project: LLVM. Comment at: clang/lib/Driver/ToolChains/Arch/AArch64.cpp:318 + if (Args.hasArg(options::OPT_ffixed_x0)) +Features.push_back("+reserve-x0"); phosek wrote: > trong wrote: > > What happens (should

[PATCH] D58107: [MinGW] Add the profiling library when necessary

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58107/new/ https://reviews.llvm.org/D58107 ___ cfe-commits mailing

[PATCH] D58106: [compiler-rt] [profile] Provide lprofGetHostName for all windows environments

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm Repository: rCRT Compiler Runtime CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58106/new/ https://reviews.llvm.org/D58106 ___

[PATCH] D58137: [clang-tidy] Add the abseil-time-subtraction check

Eugene.Zelenko added inline comments. Comment at: docs/ReleaseNotes.rst:91 + + Finds and fixes `absl::Time` subtraction expressions to do subtraction + in the Time domain instead of the numeric domain. Please use two not one ` for language constructs.

r353877 - Disable PIC/PIE for MSP430 target

Author: asl Date: Tue Feb 12 12:46:00 2019 New Revision: 353877 URL: http://llvm.org/viewvc/llvm-project?rev=353877=rev Log: Disable PIC/PIE for MSP430 target Relocatable code generation is meaningless on MSP430, as the platform is too small to use shared libraries. Patch by Dmitry Mikushev!

[PATCH] D56927: Disable PIC/PIE for MSP430 target

This revision was automatically updated to reflect the committed changes. Closed by commit rL353877: Disable PIC/PIE for MSP430 target (authored by asl, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINCE LAST ACTION

[PATCH] D58072: Make ModuleDependencyCollector's method virtual (NFC)

JDevlieghere added a comment. Alright, I'll split this up in two patches Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58072/new/ https://reviews.llvm.org/D58072 ___ cfe-commits mailing list

[PATCH] D57961: [X86] Add explicit alignment to __m128/__m128i/__m128d/etc. to allow matching of MSVC behavior with #pragma pack.

rnk added a comment. Herald added a subscriber: jdoerfert. Hm, looks like this broke a bunch of code in chromium: bad build: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/ToTWin%28dbg%29/2342 good build:

[PATCH] D54978: Move the SMT API to LLVM

ddcc added a comment. In D54978#1395268 , @brzycki wrote: > I think I found why others are struggling to recreate this issue. I did not > have the package `z3/bionic` installed. This provides the `/usr/bin/z3` > executable which

[PATCH] D57898: CodeGen: Fix PR40605: split constant structures generated by -ftrivial-auto-var-init when emitting initializators

jfb added a comment. Overall this LGTM besides a few nits, and wanting input from @rjmccall. As follow-ups (which I can take on): - Handle the case where the types don't match (because `Loc` was adjusted). - Handle small arrays (and any other cases where the struct stores get broken down into

[PATCH] D58074: [OpenMP 5.0] Parsing/sema support for map clause with mapper modifier

ABataev added a comment. In D58074#1394993 , @lildmh wrote: > Hi Alexey, > > Thanks very much for your quick review! > > For the codegen, currently I'm thinking to do it within declare target > codegen functions. So there is not a very clear interface to

[PATCH] D58074: [OpenMP 5.0] Parsing/sema support for map clause with mapper modifier

ABataev added inline comments. Comment at: lib/Sema/SemaLookup.cpp:1074 + if (NameKind == LookupOMPMapperName) { +// Skip out-of-scope declarations. lildmh wrote: > ABataev wrote: > > lildmh wrote: > > > ABataev wrote: > > > > lildmh wrote: > > > > >

[PATCH] D58074: [OpenMP 5.0] Parsing/sema support for map clause with mapper modifier

ABataev added inline comments. Comment at: lib/Sema/SemaLookup.cpp:1074 + if (NameKind == LookupOMPMapperName) { +// Skip out-of-scope declarations. lildmh wrote: > ABataev wrote: > > lildmh wrote: > > > ABataev wrote: > > > > lildmh wrote: > > > > >

[PATCH] D57977: [HIP] compile option code-object-v3 propagate to llc

ashi1 updated this revision to Diff 186519. ashi1 added a comment. Herald added a subscriber: jdoerfert. Changed patch to us handleTargetFeatures, to consume all -m options passed into clang. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57977/new/ https://reviews.llvm.org/D57977

[PATCH] D58074: [OpenMP 5.0] Parsing/sema support for map clause with mapper modifier

kkwli0 added inline comments. Comment at: include/clang/AST/OpenMPClause.h:4077 + /// C++ nested name specifier for the assoicated user-defined mapper. + NestedNameSpecifierLoc MapperQualifierLoc; assoicated -> associated Comment at:

[PATCH] D57991: [Driver][Darwin] Emit an error when using -pg on OS without support for it.

vsapsai updated this revision to Diff 186522. vsapsai added a comment. Herald added a subscriber: jdoerfert. - Use `%select` per Steven's recommendation. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57991/new/ https://reviews.llvm.org/D57991 Files:

[PATCH] D57977: [HIP] compile option code-object-v3 propagate to llc

ashi1 updated this revision to Diff 186528. ashi1 added a comment. I've added a lit test to check for options such as -mxnack/-mno-xnack, -msram-ecc/-mno-sram-ecc, -mcode-object-v3/-mno-code-object-v3 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57977/new/

[PATCH] D57977: [HIP] compile option code-object-v3 propagate to llc

kzhuravl added a comment. Is it still code object v2 by default? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57977/new/ https://reviews.llvm.org/D57977 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r353878 - [X86] Use __m128_u for _mm_loadu_ps after r353555

Author: rnk Date: Tue Feb 12 13:04:21 2019 New Revision: 353878 URL: http://llvm.org/viewvc/llvm-project?rev=353878=rev Log: [X86] Use __m128_u for _mm_loadu_ps after r353555 Add secondary triple to existing SSE test for it. I audited other uses of __attribute__((__packed__)) in the intrinsic

[PATCH] D58062: Support framework import/include auto-completion

dgoldman updated this revision to Diff 186524. dgoldman marked 9 inline comments as done. dgoldman added a comment. Herald added a subscriber: jdoerfert. - Misc fixes Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58062/new/ https://reviews.llvm.org/D58062

r353875 - [NFC] typo

Author: jfb Date: Tue Feb 12 12:19:16 2019 New Revision: 353875 URL: http://llvm.org/viewvc/llvm-project?rev=353875=rev Log: [NFC] typo Modified: cfe/trunk/include/clang/AST/Decl.h Modified: cfe/trunk/include/clang/AST/Decl.h URL:

[PATCH] D54978: Move the SMT API to LLVM

brzycki added a comment. I think I found why others are struggling to recreate this issue. I did not have the package `z3/bionic` installed. This provides the `/usr/bin/z3` executable which `llvm/cmake/modules/FindZ3.cmake` relies upon to determine the correct `Z3_VERSION_STRING`. If I

[PATCH] D57898: CodeGen: Fix PR40605: split constant structures generated by -ftrivial-auto-var-init when emitting initializators

glider added a comment. This patch shaved off 2.5% of performance slowdown on https://github.com/kamalmarhubi/linux-ipc-benchmarks/blob/master/af_inet_loopback.c on a kernel built in pattern-initialization mode. The .rodata size went down by only 12K (0.5%, since we now split only structures

[PATCH] D58137: [clang-tidy] Add the abseil-time-subtraction check

hwright created this revision. hwright added reviewers: ioeric, hokein, JonasToth, aaron.ballman. hwright added a project: clang-tools-extra. Herald added subscribers: cfe-commits, jdoerfert, xazax.hun, mgorny. Herald added a project: clang. Repository: rCTE Clang Tools Extra

[PATCH] D58074: [OpenMP 5.0] Parsing/sema support for map clause with mapper modifier

lildmh marked an inline comment as done. lildmh added inline comments. Comment at: lib/Sema/SemaLookup.cpp:1074 + if (NameKind == LookupOMPMapperName) { +// Skip out-of-scope declarations. ABataev wrote: > lildmh wrote: > > ABataev wrote: > > > lildmh

[PATCH] D57977: [HIP] compile option code-object-v3 propagate to llc

ashi1 added a comment. Yes, but it will need this PR: https://github.com/ROCm-Developer-Tools/HIP/pull/910 So that the default is set. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57977/new/ https://reviews.llvm.org/D57977 ___

[PATCH] D58147: [CodeGen] Fix calling llvm.var.annotation outside of a basic block.

vsapsai created this revision. vsapsai added a reviewer: rjmccall. Herald added subscribers: dexonsmith, jkorous, aprantl. When we have an annotated local variable after a function returns, we generate IR that fails verification with the error > Instruction referencing instruction not embedded

[PATCH] D58060: Fix diagnostic for addr spaces in static_cast

rjmccall added inline comments. Comment at: include/clang/Basic/DiagnosticSemaKinds.td:1830 + "binding value %diff{of type $ to reference to type $|to reference}0,1 " + "changes address space">; def err_reference_bind_failed : Error< We say that references

[PATCH] D57978: [CodeGen] Generate follow-up metadata for loops with more than one transformation.

rjmccall resigned from this revision. rjmccall added a comment. Herald added a subscriber: jdoerfert. Sorry, this is deep in the loop analysis code, and I don't remember anything about this stuff, so I'm not sure I'm going to be a useful reviewer. Repository: rC Clang CHANGES SINCE LAST

[PATCH] D58057: Allow bundle size to be 0 in clang-offload-bundler

rjmccall added a comment. I really don't understand this well enough to review. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58057/new/ https://reviews.llvm.org/D58057 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D54978: Move the SMT API to LLVM

mikhail.ramalho added a comment. Looks like my last email got lost: I'm wondering if we can remove the binary requirement all together: is it possible to run a small program that would return EXIT_SUCCESS if the library is the correct version? Something like: #include int main() {

[PATCH] D50488: [Analyzer] Checker for non-determinism caused by sorting of pointer-like elements

mgrang added a comment. Reviving this now that I have some cycles to work on this. So I tried running this on csa-testbench projects but I didn't have much success. I always run into a bunch of build/env related errors: 15:05:20 [libcxx] Checking out project... [ERROR] Unknown option:

[PATCH] D58122: Restore Check for Unreachable Exit Block in -Winfinite-recursion

rtrieu accepted this revision. rtrieu added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58122/new/ https://reviews.llvm.org/D58122 ___ cfe-commits

[PATCH] D58095: [clang-tidy] Make google-objc-function-naming ignore implicit functions 

stephanemoore added inline comments. Comment at: clang-tools-extra/test/clang-tidy/google-objc-function-naming.m:10 +// function would be declared in a system header. +int printf(const char *, ...); // NOLINT(google-objc-function-naming) + aaron.ballman wrote:

[PATCH] D56370: [clangd] Add support for type hierarchy (super types only for now)

sammccall added inline comments. Comment at: clang-tools-extra/clangd/ClangdServer.cpp:543 + return CB(InpAST.takeError()); +CB(clangd::getTypeHierarchy(InpAST->AST, Item.range.start, Resolve, +Direction)); nridge wrote:

[PATCH] D54978: Move the SMT API to LLVM

ddcc added a comment. In D54978#1395425 , @brzycki wrote: > This works for everything I could throw at it. If you think it's reasonable I > can open another ticket and have the code reviewed as a separate fix. Sounds good to me, although I think it'd

[PATCH] D56305: [AArch64] Support reserving arbitrary general purpose registers

phosek updated this revision to Diff 186583. phosek marked 5 inline comments as done. phosek edited the summary of this revision. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56305/new/ https://reviews.llvm.org/D56305 Files:

[PATCH] D58164: Block+lambda: allow reference capture

jfb created this revision. jfb added reviewers: rjmccall, ahatanak. Herald added subscribers: cfe-commits, dexonsmith, jkorous. Herald added a project: clang. Capturing a C++ object by reference wasn't quite working when mixing block and lambda. Repository: rC Clang

[libunwind] r353915 - [CMake] Don't cache LLVM_MAIN_SRC_DIR

Author: phosek Date: Tue Feb 12 23:09:26 2019 New Revision: 353915 URL: http://llvm.org/viewvc/llvm-project?rev=353915=rev Log: [CMake] Don't cache LLVM_MAIN_SRC_DIR If we're not in a standalone build, this variable should be already set, so there's no need to set it again or to cache it.

[PATCH] D58095: [clang-tidy] Make google-objc-function-naming ignore implicit functions 

stephanemoore marked an inline comment as done. stephanemoore added inline comments. Comment at: clang-tools-extra/test/clang-tidy/Inputs/Headers/stdio.h:1 +#ifndef _STDIO_H_ +#define _STDIO_H_ stephanemoore wrote: > I noticed that some of the other example

[PATCH] D58106: [compiler-rt] [profile] Provide lprofGetHostName for all windows environments

This revision was automatically updated to reflect the committed changes. Closed by commit rL353918: [profile] Provide lprofGetHostName for all windows environments (authored by mstorsjo, committed by ). Herald added a subscriber: delcypher. Changed prior to commit:

  1   2   >