[PATCH] D53928: Enable builtins necessary for SLEEF [AArch64] vectorized trigonometry libm functions

rengolin accepted this revision. rengolin added a comment. This revision is now accepted and ready to land. Thanks, LGTM! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53928/new/ https://reviews.llvm.org/D53928 ___

[PATCH] D53633: [AArch64] Implement FP16FML intrinsics

SjoerdMeijer added inline comments. Comment at: cfe/trunk/test/CodeGen/aarch64-neon-fp16fml.c:12 + +float32x2_t test_vfmlal_low_u32(float32x2_t a, float16x4_t b, float16x4_t c) { +// CHECK-LABEL: define <2 x float> @test_vfmlal_low_u32(<2 x float> %a, <4 x half> %b, <4 x half>

[PATCH] D57910: [ASTImporter] Find previous friend function template

martong added a comment. Ping Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57910/new/ https://reviews.llvm.org/D57910 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r354109 - Revert "[Analysis] -Wunreachable-code shouldn't fire on the increment of a foreach loop"

Author: sammccall Date: Fri Feb 15 01:18:49 2019 New Revision: 354109 URL: http://llvm.org/viewvc/llvm-project?rev=354109=rev Log: Revert "[Analysis] -Wunreachable-code shouldn't fire on the increment of a foreach loop" This reverts commit r354102. Modified:

[PATCH] D57590: [ASTImporter] Improve import of FileID.

martong added a comment. Herald added a subscriber: cfe-commits. Ping Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57590/new/ https://reviews.llvm.org/D57590 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D58275: [clangd] Support utf-8 offsets (rather than utf-16) as a protocol extension

sammccall created this revision. sammccall added a reviewer: hokein. Herald added subscribers: cfe-commits, jdoerfert, kadircet, arphaman, jkorous, MaskRay, ioeric, ilya-biryukov. Herald added a project: clang. Still some pieces to go here: unit tests for new SourceCode functionality and a

r354140 - [clang] Create install targets for non-shared libraries

Author: smeenai Date: Fri Feb 15 07:59:02 2019 New Revision: 354140 URL: http://llvm.org/viewvc/llvm-project?rev=354140=rev Log: [clang] Create install targets for non-shared libraries I don't see a reason for these to not have install targets created, which in turn allows them to be bundled in

r354141 - [clang] Add build and install targets for clang libraries

Author: smeenai Date: Fri Feb 15 07:59:04 2019 New Revision: 354141 URL: http://llvm.org/viewvc/llvm-project?rev=354141=rev Log: [clang] Add build and install targets for clang libraries This is modeled after the existing llvm-libraries target. It's a convenient way to include all clang

r354147 - Variable auto-init of blocks capturing self after init bugfix

Author: jfb Date: Fri Feb 15 09:26:29 2019 New Revision: 354147 URL: http://llvm.org/viewvc/llvm-project?rev=354147=rev Log: Variable auto-init of blocks capturing self after init bugfix Summary: Blocks that capture themselves (and escape) after initialization currently codegen wrong because

[PATCH] D58269: [clang] Add build and install targets for clang libraries

This revision was automatically updated to reflect the committed changes. Closed by commit rC354141: [clang] Add build and install targets for clang libraries (authored by smeenai, committed by ). Changed prior to commit: https://reviews.llvm.org/D58269?vs=186957=187019#toc Repository: rC

[PATCH] D58268: [clang] Create install targets for non-shared libraries

This revision was automatically updated to reflect the committed changes. Closed by commit rC354140: [clang] Create install targets for non-shared libraries (authored by smeenai, committed by ). Changed prior to commit: https://reviews.llvm.org/D58268?vs=186955=187018#toc Repository: rC

[PATCH] D58284: [clang] Switch to LLVM_ENABLE_IDE

smeenai added a subscriber: lebedev.ri. smeenai added a comment. CC @lebedev.ri, since I believe you raised some issues during the corresponding LLVM change but those were addressed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58284/new/

[PATCH] D58284: [clang] Switch to LLVM_ENABLE_IDE

smeenai created this revision. smeenai added reviewers: beanz, phosek. Herald added subscribers: jdoerfert, arphaman, mgorny. Herald added a project: clang. r344555 switched LLVM to guarding install targets with LLVM_ENABLE_IDE instead of CMAKE_CONFIGURATION_TYPES, which expresses the intent more

[PATCH] D58284: [clang] Switch to LLVM_ENABLE_IDE

lebedev.ri added a comment. In D58284#1399443 , @smeenai wrote: > CC @lebedev.ri, since I believe you raised some issues during the > corresponding LLVM change but those were addressed. Yeah, i don't think i have any comments here. The logic to pick

[PATCH] D58284: [clang] Switch to LLVM_ENABLE_IDE

smeenai added a comment. In D58284#1399446 , @lebedev.ri wrote: > In D58284#1399443 , @smeenai wrote: > > > CC @lebedev.ri, since I believe you raised some issues during the > > corresponding LLVM change but those

[PATCH] D58062: Support framework import/include auto-completion

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Great, thank you! Want me to land this? (You can certainly get your own commit access at this point if you like: https://llvm.org/docs/DeveloperPolicy.html#obtaining-commit-access and

[PATCH] D58218: Variable auto-init of blocks capturing self after init bugfix

This revision was automatically updated to reflect the committed changes. Closed by commit rL354147: Variable auto-init of blocks capturing self after init bugfix (authored by jfb, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LLVM

r354121 - [OpenCL][PR40707] Allow OpenCL C types in C++ mode.

Author: stulova Date: Fri Feb 15 04:07:57 2019 New Revision: 354121 URL: http://llvm.org/viewvc/llvm-project?rev=354121=rev Log: [OpenCL][PR40707] Allow OpenCL C types in C++ mode. Allow all OpenCL types to be parsed in C++ mode. Modified:

Re: r353943 - [Analyzer] Crash fix for FindLastStoreBRVisitor

Merged to release_80 in r354130. Please let me know if there are any follow-ups. On Wed, Feb 13, 2019 at 1:25 PM Adam Balogh via cfe-commits wrote: > > Author: baloghadamsoftware > Date: Wed Feb 13 04:25:47 2019 > New Revision: 353943 > > URL: http://llvm.org/viewvc/llvm-project?rev=353943=rev >

[PATCH] D57662: [clang-tidy] Parallelise clang-tidy-diff.py

alexfh added inline comments. Comment at: clang-tidy/tool/clang-tidy-diff.py:98 + parser.add_argument('-j', type=int, default=0, + help='number of tidy instances to be run in parallel.') The "clang-tidy runs are independent" assumption is

[PATCH] D56644: [clang-tidy] readability-container-size-empty handle std::string length()

alexfh added inline comments. Herald added a project: clang. Comment at: clang-tidy/readability/ContainerSizeEmptyCheck.cpp:65 hasType(references(ValidContainer), -callee(cxxMethodDecl(hasName("size"))),

Re: r354109 - Revert "[Analysis] -Wunreachable-code shouldn't fire on the increment of a foreach loop"

When reverting something, can you say why you're reverting in the commit message please? On Fri, Feb 15, 2019 at 4:18 AM Sam McCall via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: sammccall > Date: Fri Feb 15 01:18:49 2019 > New Revision: 354109 > > URL:

[PATCH] D57855: [analyzer] Reimplement checker options

Szelethus added a comment. I guess removing some of the checker option descriptions from `lib/StataicAnalyzer/Checkers/` would be nice too, to easy on maintenance. One could always just use `-analyzer-checker-option-help` whenever in doubt. CHANGES SINCE LAST ACTION

[PATCH] D57112: [ASTTypeTraits] OMPClause handling

lebedev.ri added a subscriber: alexfh. lebedev.ri added a comment. Herald added a subscriber: jdoerfert. Ping @hokein / @alexfh (as per git blame). Not sure who is best suited to review this. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57112/new/

[PATCH] D58239: [clangd] Cache include fixes for diagnostics caused by the same unresolved name or incomplete type.

sammccall added inline comments. Comment at: clangd/IncludeFixer.cpp:130 + // FIXME: consider batching the requests for all diagnostics. llvm::Optional Matched; Index.lookup(Req, [&](const Symbol ) { oops - this seems broken (in both the old and new

[PATCH] D58179: [OpenCL][PR40707] Allow OpenCL C types in C++ mode

keryell added a comment. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58179/new/ https://reviews.llvm.org/D58179 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D57948: [Sema] Fix a regression introduced in "[AST][Sema] Remove CallExpr::setNumArgs"

riccibruno added a subscriber: hans. riccibruno added a comment. (Following up on a discussion on IRC) I have looked at what would be needed to revert the set of patches which introduced this change, but this results in a >1k lines diff which do not apply cleanly. I think it might be safer to

[PATCH] D58239: [clangd] Cache include fixes for diagnostics caused by the same unresolved name or incomplete type.

sammccall added a comment. (big thumbs up to the caching overall of course!) Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58239/new/ https://reviews.llvm.org/D58239 ___ cfe-commits mailing list

[PATCH] D58277: [OpenCL] Change type of block pointer for OpenCL

AlexeySotkin created this revision. AlexeySotkin added reviewers: Anastasia, yaxunl, svenvh. Herald added a project: clang. For some reason OpenCL blocks in LLVM IR are represented as function pointers. These pointers do not point to any real function and never get called. Actually they point to

[PATCH] D58278: Prepare ground for re-lexing modular headers.

alexfh created this revision. alexfh added reviewers: bkramer, klimek, rsmith. Herald added subscribers: jdoerfert, jsji, kbarton, nemanjai. Herald added a project: clang. When a clang tool runs on a translation unit that uses modular headers, no PPCallbacks will be invoked for the code in the

r354127 - [Analyzer] Fix for test file of bug 40625

Author: baloghadamsoftware Date: Fri Feb 15 04:33:42 2019 New Revision: 354127 URL: http://llvm.org/viewvc/llvm-project?rev=354127=rev Log: [Analyzer] Fix for test file of bug 40625 Test fixed and changed to true positive, FIXME about false positive removed. Modified:

Re: r354136 - Exteded test of .

No -- That was supposed to be a single commit. I used the git llvm push expecting it to commit the diff that I saw through arc diff, but instead got the four separate commits. I should have squashed the 4 (local) commits into a single commit beforehand but missed that step. Should rollback those

[PATCH] D58179: [OpenCL][PR40707] Allow OpenCL C types in C++ mode

svenvh accepted this revision. svenvh added a comment. This revision is now accepted and ready to land. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58179/new/ https://reviews.llvm.org/D58179 ___ cfe-commits mailing list

[PATCH] D58275: [clangd] Support utf-8 offsets (rather than utf-16) as a protocol extension

sammccall updated this revision to Diff 187002. sammccall added a comment. Add tests, command-line flag, and misc cleanups. No flag for clangd-indexer yet. It's surprisingly hard with the executor API :-( Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION

[PATCH] D23610: [ARM] Add pre-defined macros for ROPI and RWPI

kahmed added a comment. Herald added subscribers: llvm-commits, jdoerfert, kristof.beyls, javed.absar. Herald added a project: LLVM. Ping Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D23610/new/ https://reviews.llvm.org/D23610

[PATCH] D58189: [clang][Index] Fix usage of IndexImplicitInstantiation

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58189/new/ https://reviews.llvm.org/D58189 ___

[PATCH] D56850: [ASTMatchers][NFC] Add tests for assorted `CXXMemberCallExpr` matchers.

ymandel updated this revision to Diff 187003. ymandel added a comment. Herald added a project: clang. Sync to head. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56850/new/ https://reviews.llvm.org/D56850 Files:

[PATCH] D58074: [OpenMP 5.0] Parsing/sema support for map clause with mapper modifier

ABataev added inline comments. Comment at: include/clang/AST/OpenMPClause.h:3626 + struct OMPMappableExprListSizeTy { +unsigned NumVars; +unsigned NumUniqueDeclarations; Add default initializers for the fields Comment at:

r354120 - [ASTImporter] Import every Decl in lambda record

Author: martong Date: Fri Feb 15 04:04:05 2019 New Revision: 354120 URL: http://llvm.org/viewvc/llvm-project?rev=354120=rev Log: [ASTImporter] Import every Decl in lambda record Summary: Previously only the fields were imported. Now every Decl is imported. This way the destructor decl is not

[PATCH] D57740: [ASTImporter] Import every Decl in lambda record

This revision was automatically updated to reflect the committed changes. Closed by commit rL354120: [ASTImporter] Import every Decl in lambda record (authored by martong, committed by ). Herald added subscribers: llvm-commits, jdoerfert. Herald added a project: LLVM. Changed prior to commit:

Re: r354074 - [Sema] Fix-up a -Wfloat-conversion diagnostic

Merged in r354129. Please let me know if there are any follow-ups. Thanks, Hans On Fri, Feb 15, 2019 at 12:16 AM Erik Pilkington wrote: > > Hans, can you merge this diagnostic regression fix into LLVM 8? > > Thanks! > > > On Feb 14, 2019, at 2:48 PM, Erik Pilkington via cfe-commits > > wrote:

Re: r354075 - [clang][FileManager] fillRealPathName even if we aren't opening the file

Did you do any performance testing to check if this slows down clang? On Thu, Feb 14, 2019 at 6:02 PM Jan Korous via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: jkorous > Date: Thu Feb 14 15:02:35 2019 > New Revision: 354075 > > URL:

r354134 - Added test for matcher On.

Author: ymandel Date: Fri Feb 15 06:43:06 2019 New Revision: 354134 URL: http://llvm.org/viewvc/llvm-project?rev=354134=rev Log: Added test for matcher On. Modified: cfe/trunk/unittests/ASTMatchers/ASTMatchersTraversalTest.cpp Modified:

r354136 - Exteded test of .

Author: ymandel Date: Fri Feb 15 06:43:10 2019 New Revision: 354136 URL: http://llvm.org/viewvc/llvm-project?rev=354136=rev Log: Exteded test of . Modified: cfe/trunk/unittests/ASTMatchers/ASTMatchersTraversalTest.cpp Modified: cfe/trunk/unittests/ASTMatchers/ASTMatchersTraversalTest.cpp

r354135 - Remove unnecessary expectation.

Author: ymandel Date: Fri Feb 15 06:43:08 2019 New Revision: 354135 URL: http://llvm.org/viewvc/llvm-project?rev=354135=rev Log: Remove unnecessary expectation. Modified: cfe/trunk/unittests/ASTMatchers/ASTMatchersTraversalTest.cpp Modified:

[PATCH] D56850: [ASTMatchers][NFC] Add tests for assorted `CXXMemberCallExpr` matchers.

This revision was automatically updated to reflect the committed changes. Closed by commit rL354133: Add tests for assorted `CXXMemberCallExpr` matchers. (authored by ymandel, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

r354133 - Add tests for assorted `CXXMemberCallExpr` matchers.

Author: ymandel Date: Fri Feb 15 06:43:03 2019 New Revision: 354133 URL: http://llvm.org/viewvc/llvm-project?rev=354133=rev Log: Add tests for assorted `CXXMemberCallExpr` matchers. Summary: Add tests for matchers `on`, `onImplicitObjectArgument` and `hasObjectExpression`. Reviewers: alexfh,

[PATCH] D58275: [clangd] Support utf-8 offsets (rather than utf-16) as a protocol extension

hokein added a comment. The code looks good. For this protocol extension, we need supports from other LSP clients, I think we may want to propose this extension to the LSP specification, so that all LSP servers/clients respect it. Comment at: clangd/Protocol.h:377 + + ///

[PATCH] D57956: [www] Add ASTImporter fuzzer project.

teemperor closed this revision. teemperor added a comment. landed in llvm-svn: 354043 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57956/new/ https://reviews.llvm.org/D57956 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: r354136 - Exteded test of .

On Fri, Feb 15, 2019 at 5:42 PM Yitzhak Mandelbaum via cfe-commits wrote: > > Author: ymandel > Date: Fri Feb 15 06:43:10 2019 > New Revision: 354136 > > URL: http://llvm.org/viewvc/llvm-project?rev=354136=rev > Log: > Exteded test of . Were last few commits were meant to be committed?

[clang-tools-extra] r354116 - [clangd] Unlink VFS working dir from OS working dir. Reland of r351051

Author: sammccall Date: Fri Feb 15 03:04:25 2019 New Revision: 354116 URL: http://llvm.org/viewvc/llvm-project?rev=354116=rev Log: [clangd] Unlink VFS working dir from OS working dir. Reland of r351051 Modified: clang-tools-extra/trunk/clangd/FSProvider.cpp Modified:

[PATCH] D58189: [clang][Index] Fix usage of IndexImplicitInstantiation

kadircet updated this revision to Diff 186995. kadircet marked 6 inline comments as done. kadircet added a comment. Address comments Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58189/new/ https://reviews.llvm.org/D58189 Files:

[PATCH] D58149: [clang] Make sure C99/C11 features in are provided in C++11

ldionne added a comment. I agree with the comments. I think we should strive to be strictly conforming. I make that argument all the time for libc++, so I'll be consistent :-). https://reviews.llvm.org/D58289 Repository: rC Clang CHANGES SINCE LAST ACTION

[PATCH] D56571: [RFC prototype] Implementation of asm-goto support in clang

jyu2 updated this revision to Diff 187036. jyu2 marked an inline comment as done. jyu2 added a comment. Review comment addressed CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56571/new/ https://reviews.llvm.org/D56571 Files: include/clang/AST/Stmt.h

[PATCH] D57948: [Sema] Fix a regression introduced in "[AST][Sema] Remove CallExpr::setNumArgs"

aaron.ballman added a subscriber: hansw. aaron.ballman added a comment. In D57948#1399403 , @riccibruno wrote: > (Following up on a discussion on IRC) I have looked at what would be needed > to revert the set of patches which introduced this change, but

[PATCH] D58292: Add support for importing ChooseExpr AST nodes.

tmroeder created this revision. Herald added a reviewer: shafik. Herald added subscribers: cfe-commits, jdoerfert. Herald added a project: clang. This allows ASTs to be merged when they contain ChooseExpr (the GNU __builtin_choose_expr construction). This is needed, for example, for cross-CTU

[PATCH] D58293: [clang][Index] Enable indexing of Template Type Parameters behind a flag

kadircet created this revision. kadircet added reviewers: ilya-biryukov, akyrtzi. Herald added subscribers: cfe-commits, arphaman, ioeric, kristof.beyls, javed.absar. Herald added a project: clang. clangd uses indexing api to provide references and it was not possible to perform symbol

[PATCH] D58291: [clangd] Include textual diagnostic ID as Diagnostic.code.

sammccall updated this revision to Diff 187048. sammccall added a comment. Unit test. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58291/new/ https://reviews.llvm.org/D58291 Files: clangd/Diagnostics.cpp clangd/Diagnostics.h

Re: r354075 - [clang][FileManager] fillRealPathName even if we aren't opening the file

Hello Jan, It looks like this commit broke tests on couple of win builders: http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/builds/23655 http://lab.llvm.org:8011/builders/llvm-clang-x86_64-expensive-checks-win . . . Failing Tests (1): Clang-Unit ::

[PATCH] D49466: Initial implementation of -fmacro-prefix-map and -ffile-prefix-map

raj.khem added inline comments. Comment at: lib/CodeGen/CGDebugInfo.cpp:476 for (const auto : DebugPrefixMap) -if (Path.startswith(Entry.first)) - return (Twine(Entry.second) + Path.substr(Entry.first.size())).str(); - return Path.str(); +if

[PATCH] D49466: Initial implementation of -fmacro-prefix-map and -ffile-prefix-map

raj.khem added inline comments. Comment at: lib/CodeGen/CGDebugInfo.cpp:476 for (const auto : DebugPrefixMap) -if (Path.startswith(Entry.first)) - return (Twine(Entry.second) + Path.substr(Entry.first.size())).str(); - return Path.str(); +if

[PATCH] D58297: [Sema] SequenceChecker: C++17 sequencing rules for built-in operators <<, >>, .*, ->*, =, op=

riccibruno created this revision. riccibruno added reviewers: rsmith, rjmccall, aaron.ballman. riccibruno added a project: clang. Herald added subscribers: cfe-commits, jdoerfert. Implement the C++17 sequencing rules for the built-in operators `<<`, `>>`, `.*`, `->*`, `=` and `op=`.

[PATCH] D57747: [Sema] SequenceChecker: Fix handling of operator ||, && and ?:

riccibruno updated this revision to Diff 187057. riccibruno marked an inline comment as done. riccibruno added a comment. Herald added a subscriber: jdoerfert. Rebased Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57747/new/ https://reviews.llvm.org/D57747

[PATCH] D58292: Add support for importing ChooseExpr AST nodes.

shafik added a comment. This looks reasonable, I will wait for @martong and/or @a_sidorin to review. FYI LLDB is the other big user of ASTImpoter so it is helpful if you can run `check-lldb` especially on MacOS so you can to catch regressions before committing. After committing please make

r354165 - Relax assertion to account for private framework modules, too.

Author: adrian Date: Fri Feb 15 12:24:26 2019 New Revision: 354165 URL: http://llvm.org/viewvc/llvm-project?rev=354165=rev Log: Relax assertion to account for private framework modules, too. rdar://problem/48116069 Modified: cfe/trunk/lib/CodeGen/CGDebugInfo.cpp

[PATCH] D56571: [RFC prototype] Implementation of asm-goto support in clang

jyu2 added inline comments. Comment at: lib/Sema/JumpDiagnostics.cpp:675 + // asm-goto. + //if (!IsAsmGoto && IndirectJumpTargets.empty()) { + if (JumpTargets.empty()) { efriedma wrote: > Commented-out code? > > We probably don't need a diagnostic for an asm

r354166 - [Driver] Default all Android ARM targets to NEON.

Author: danalbert Date: Fri Feb 15 12:31:54 2019 New Revision: 354166 URL: http://llvm.org/viewvc/llvm-project?rev=354166=rev Log: [Driver] Default all Android ARM targets to NEON. Summary: There are an insignificant number of ARM Android devices that don't support NEON. Default to using NEON

[PATCH] D58153: [Driver] Default all Android ARM targets to NEON.

This revision was automatically updated to reflect the committed changes. Closed by commit rL354166: [Driver] Default all Android ARM targets to NEON. (authored by danalbert, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D58062: Support framework import/include auto-completion

dgoldman added a comment. In D58062#1399499 , @sammccall wrote: > Great, thank you! Want me to land this? > > (You can certainly get your own commit access at this point if you like: > https://llvm.org/docs/DeveloperPolicy.html#obtaining-commit-access

r354151 - [Sema][NFC] SequenceChecker: Add tests for references/members, and prepare for the C++17 tests

Author: brunoricci Date: Fri Feb 15 10:12:58 2019 New Revision: 354151 URL: http://llvm.org/viewvc/llvm-project?rev=354151=rev Log: [Sema][NFC] SequenceChecker: Add tests for references/members, and prepare for the C++17 tests Add some tests for unsequenced operations with members and

[PATCH] D57660: [Sema] SequenceChecker: Handle references and members

riccibruno updated this revision to Diff 187035. riccibruno added a comment. Herald added a subscriber: jdoerfert. Rebased. Does this implementation make sense ? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57660/new/ https://reviews.llvm.org/D57660 Files:

r354162 - [MSVC] Recognize `static_assert` keyword in C and C++98

Author: rnk Date: Fri Feb 15 11:59:45 2019 New Revision: 354162 URL: http://llvm.org/viewvc/llvm-project?rev=354162=rev Log: [MSVC] Recognize `static_assert` keyword in C and C++98 Summary: The main effect is that clang now accepts the following conforming C11 code with MSVC headers: #include

[PATCH] D17444: [MSVC] Recognize "static_assert" keyword in C mode

This revision was automatically updated to reflect the committed changes. Closed by commit rC354162: [MSVC] Recognize `static_assert` keyword in C and C++98 (authored by rnk, committed by ). Changed prior to commit: https://reviews.llvm.org/D17444?vs=186741=187061#toc Repository: rC Clang

[PATCH] D57270: [ObjC] Fix non-canonical types preventing type arguments substitution.

This revision was automatically updated to reflect the committed changes. Closed by commit rL354164: [ObjC] Fix non-canonical types preventing type arguments substitution. (authored by vsapsai, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior

r354164 - [ObjC] Fix non-canonical types preventing type arguments substitution.

Author: vsapsai Date: Fri Feb 15 12:17:45 2019 New Revision: 354164 URL: http://llvm.org/viewvc/llvm-project?rev=354164=rev Log: [ObjC] Fix non-canonical types preventing type arguments substitution. `QualType::substObjCTypeArgs` doesn't go past non-canonical types and as the result misses some

[PATCH] D58292: Add support for importing ChooseExpr AST nodes.

aaron.ballman added a reviewer: aaron.ballman. aaron.ballman added a comment. Please be sure to update Registry.cpp to expose the new AST matcher to the dynamic matcher infrastructure, regenerate the AST matcher documentation (run clang\docs\tools\dump_ast_matchers.py), and add tests for the

Re: r354091 - Fix implementation of [temp.local]p4.

On Thu, 14 Feb 2019, 18:35 Francis Visoiu Mistrih via cfe-commits, < cfe-commits@lists.llvm.org> wrote: > Hi Richard, > > This seems to now emit an error when building the sanitizer tests: > http://green.lab.llvm.org/green/job/clang-stage1-configure-RA/53965/consoleFull > . > > I managed to

[PATCH] D58074: [OpenMP 5.0] Parsing/sema support for map clause with mapper modifier

lildmh added inline comments. Comment at: include/clang/AST/OpenMPClause.h:3682-3685 + OpenMPClauseKind K, SourceLocation StartLoc, SourceLocation LParenLoc, + SourceLocation EndLoc, OMPMappableExprListSizeTy Sizes, + NestedNameSpecifierLoc *MapperQualifierLocP =

[PATCH] D58074: [OpenMP 5.0] Parsing/sema support for map clause with mapper modifier

ABataev added inline comments. Comment at: include/clang/AST/OpenMPClause.h:3666 + OMPMappableExprListClause( + OpenMPClauseKind K, OMPMappableExprListLocTy Locs, + OMPMappableExprListSizeTy Sizes, Pass those new structures by const reference, not by

[PATCH] D58275: [clangd] Support utf-8 offsets (rather than utf-16) as a protocol extension

sammccall added a comment. In D58275#1399195 , @hokein wrote: > The code looks good. For this protocol extension, we need supports from other > LSP clients, I think we may want to propose this extension to the LSP > specification, so that all LSP

[PATCH] D58189: [clang][Index] Fix usage of IndexImplicitInstantiation

kadircet added inline comments. Comment at: unittests/Index/IndexTests.cpp:40 +Position P; +P.Line = static_cast(SM.getLineNumber(FID, Offset)) - 1; +P.Column = SM.getColumnNumber(FID, Offset) - 1; ilya-biryukov wrote: > Why do we need to

[PATCH] D57087: [clang-tidy] add OverrideMacro to modernize-use-override check

alexfh requested changes to this revision. alexfh added inline comments. This revision now requires changes to proceed. Herald added a subscriber: jdoerfert. Comment at: clang-tidy/modernize/UseOverrideCheck.cpp:32 +: ClangTidyCheck(Name, Context), +

[PATCH] D57662: [clang-tidy] Parallelise clang-tidy-diff.py

zinovy.nis marked an inline comment as done. zinovy.nis added inline comments. Comment at: clang-tidy/tool/clang-tidy-diff.py:98 + parser.add_argument('-j', type=int, default=0, + help='number of tidy instances to be run in parallel.')

[PATCH] D56851: [ASTMatchers] Adds `CXXMemberCallExpr` matcher `invokedAtType`.

ymandel marked 3 inline comments as done. ymandel added inline comments. Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:3300 +/// matches `x.m()` and `p->m()`. +AST_MATCHER_P_OVERLOAD(clang::CXXMemberCallExpr, invokedAtType, +

[PATCH] D58189: [clang][Index] Fix usage of IndexImplicitInstantiation

kadircet updated this revision to Diff 187014. kadircet added a comment. - Get rid of redundant test Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58189/new/ https://reviews.llvm.org/D58189 Files: lib/Index/IndexTypeSourceInfo.cpp

[PATCH] D53633: [AArch64] Implement FP16FML intrinsics

SjoerdMeijer added inline comments. Comment at: cfe/trunk/test/CodeGen/aarch64-neon-fp16fml.c:12 + +float32x2_t test_vfmlal_low_u32(float32x2_t a, float16x4_t b, float16x4_t c) { +// CHECK-LABEL: define <2 x float> @test_vfmlal_low_u32(<2 x float> %a, <4 x half> %b, <4 x half>

[PATCH] D57112: [ASTTypeTraits] OMPClause handling

alexfh added a comment. In D57112#1399516 , @lebedev.ri wrote: > Ping @hokein / @alexfh (as per git blame). > Not sure who is best suited to review this. I only made a couple of random fixes to these files, so I don't feel particularly competent to

[PATCH] D58074: [OpenMP 5.0] Parsing/sema support for map clause with mapper modifier

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. In D58074#1399881 , @lildmh wrote: > Thanks for the catch! I also change the name from `OMPMappableExprListLocTy` > to `OMPVarListLocTy` to be more

[PATCH] D50488: [Analyzer] Checker for non-determinism caused by sorting of pointer-like elements

mgrang added a comment. I hacked around the run_experiments.py to set CMAKE_C_FLAGS and now I see the following error in stats.html. Note: I see the same error with an existing checker like PointerArithmChecker. And I do not hit this assert when I run the checker outside of csa-testbench.

[PATCH] D57579: [analyzer][WIP] Enable subcheckers to possess checker options

NoQ accepted this revision. NoQ added a comment. Herald added a subscriber: jdoerfert. > since I couldn't reproduce the error Me neither, actually :/ This patch does provide a backup plan and it makes the code prettier, so we should definitely land it and i'm really greatful for it, but the

[PATCH] D58065: [analyzer] Document the frontend library

NoQ added a comment. Had a look. Great stuff, just as planned :) Old fanboy wisdom: Try to avoid documenting bugs you want to fix! But i don't have many high-level comments here - only appreciation of the effort. In D58065#1394864 , @Szelethus wrote: >

[PATCH] D58292: Add support for importing ChooseExpr AST nodes.

tmroeder updated this revision to Diff 187113. tmroeder added a comment. Updated Registry.cpp, regenerated the documentation, and added direct tests for the matcher. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58292/new/ https://reviews.llvm.org/D58292

[PATCH] D58254: [Sema] Diagnose floating point conversions based on target semantics

This revision was automatically updated to reflect the committed changes. Closed by commit rC354190: [Sema] Diagnose floating point conversions based on target semantics (authored by epilk, committed by ). Herald added a project: clang. Changed prior to commit:

r354190 - [Sema] Diagnose floating point conversions based on target semantics

Author: epilk Date: Fri Feb 15 17:11:47 2019 New Revision: 354190 URL: http://llvm.org/viewvc/llvm-project?rev=354190=rev Log: [Sema] Diagnose floating point conversions based on target semantics ...instead of just comparing rank. Also, fix a bad warning about _Float16, since its declared out of

[PATCH] D56571: [RFC prototype] Implementation of asm-goto support in clang

rsmith added inline comments. Herald added a reviewer: martong. Comment at: lib/AST/StmtProfile.cpp:324 VisitStringLiteral(S->getClobberStringLiteral(I)); + ID.AddInteger(S->getNumLabels()); } Don't we also need to profile the labels themselves?

r354192 - Fix some tests I broke in r354190

Author: epilk Date: Fri Feb 15 17:51:19 2019 New Revision: 354192 URL: http://llvm.org/viewvc/llvm-project?rev=354192=rev Log: Fix some tests I broke in r354190 This was breaking on MSVC, since long double and double have the same semantics there. Modified:

[PATCH] D58121: [analyzer][WIP] Attempt to fix traversing bindings of non-base regions in ClusterAnalysis

NoQ added a comment. After staring at this for an hour or two, i didn't manage to force myself to understand how our cluster analysis works here, but i totally agree that it's most likely broken; i guess, we should eventually move away from the idea that everything works through base regions,

[PATCH] D57655: clang-format with UseTab: Always sometimes doesn't insert the right amount of tabs.

This revision was automatically updated to reflect the committed changes. Closed by commit rC354183: clang-format with UseTab: Always sometimes doesnt insert the right amount of… (authored by alexfh, committed by ). Changed prior to commit: https://reviews.llvm.org/D57655?vs=186629=187096#toc

r354183 - clang-format with UseTab: Always sometimes doesn't insert the right amount of tabs.

Author: alexfh Date: Fri Feb 15 15:07:43 2019 New Revision: 354183 URL: http://llvm.org/viewvc/llvm-project?rev=354183=rev Log: clang-format with UseTab: Always sometimes doesn't insert the right amount of tabs. Trailing comments are not always aligned properly when UseTab is set to Always.

Re: r354091 - Fix implementation of [temp.local]p4.

> On Feb 15, 2019, at 1:53 PM, Richard Smith wrote: > > On Fri, 15 Feb 2019 at 09:56, Richard Smith > wrote: >> >> On Thu, 14 Feb 2019, 18:35 Francis Visoiu Mistrih via cfe-commits, >> wrote: >>> >>> Hi Richard, >>> >>> This seems to now emit an error when

  1   2   >