[PATCH] D58404: [clang-format] Add basic support for formatting C# files

MyDeveloperDay updated this revision to Diff 188239. MyDeveloperDay added a subscriber: llvm-commits. MyDeveloperDay added a comment. Fix a crash running clang-format over large C# code base Add support for C# Null Coalescing CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58404/new/ http

r354817 - [OpenMP 5.0] Parsing/sema support for from clause with mapper modifier.

Author: meinersbur Date: Mon Feb 25 12:34:15 2019 New Revision: 354817 URL: http://llvm.org/viewvc/llvm-project?rev=354817&view=rev Log: [OpenMP 5.0] Parsing/sema support for from clause with mapper modifier. This patch implements the parsing and sema support for the OpenMP 'from'-clause with pot

[PATCH] D58638: [OpenMP 5.0] Parsing/sema support for from clause with mapper modifier

This revision was automatically updated to reflect the committed changes. Closed by commit rL354817: [OpenMP 5.0] Parsing/sema support for from clause with mapper modifier. (authored by Meinersbur, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prio

[PATCH] D58091: Customize warnings for missing built-in type

bcain added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:592 +: Warning<"declaration of built-in function '%0' requires the declaration" +" of the 'jmp_buf' type, commonly proived in the header .">, + InGroup>; "proiv

r354823 - [libclang] Fix a trivial error introduced in D57946.

Author: emilio Date: Mon Feb 25 13:15:34 2019 New Revision: 354823 URL: http://llvm.org/viewvc/llvm-project?rev=354823&view=rev Log: [libclang] Fix a trivial error introduced in D57946. The value for CXCursor_ConvergentAttr is not 420. I'm not really sure how easy it is to test this, and I'm not

[PATCH] D58571: [libclang] Fix a trivial error introduced in D57946.

This revision was automatically updated to reflect the committed changes. Closed by commit rL354823: [libclang] Fix a trivial error introduced in D57946. (authored by emilio, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://

r354824 - [libclang] Expose warn_unused and warn_unused_result attributes.

Author: emilio Date: Mon Feb 25 13:24:52 2019 New Revision: 354824 URL: http://llvm.org/viewvc/llvm-project?rev=354824&view=rev Log: [libclang] Expose warn_unused and warn_unused_result attributes. This is helpful to properly detect them, and fixing issues like https://github.com/rust-lang/rust-b

[PATCH] D58570: [libclang] Expose warn_unused and warn_unused_result attributes.

This revision was automatically updated to reflect the committed changes. Closed by commit rC354824: [libclang] Expose warn_unused and warn_unused_result attributes. (authored by emilio, committed by ). Herald added a reviewer: serge-sans-paille. Changed prior to commit: https://reviews.llvm.or

[PATCH] D58570: [libclang] Expose warn_unused and warn_unused_result attributes.

emilio added a comment. Landed with that change, thanks for the review @anastasia! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58570/new/ https://reviews.llvm.org/D58570 ___ cfe-commits mailing list cfe-commits@lis

[PATCH] D58569: [libclang] Avoid crashing when getting layout info of an undeduced type.

emilio updated this revision to Diff 188254. emilio marked an inline comment as done. emilio added a comment. Add CHECK tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58569/new/ https://reviews.llvm.org/D58569 Files: clang/include/clang-c/

[PATCH] D58321: [WIP] Support for relative vtables

leonardchan updated this revision to Diff 188256. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58321/new/ https://reviews.llvm.org/D58321 Files: clang/include/clang/AST/DeclCXX.h clang/include/clang/AST/VTableBuilder.h clang/include/clang/Bas

[PATCH] D58321: [WIP] Support for relative vtables

leonardchan added a comment. In D58321#1407362 , @pcc wrote: > Can we start with a patch that just exposes a flag that enables the relative > ABI unconditionally, and remove all the platform ABI compatibility stuff? Done. Removed the checks requiring LT

[PATCH] D58089: Add missing library dependencies in CMakeLists.txt

comex added a comment. Ping. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58089/new/ https://reviews.llvm.org/D58089 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-b

[PATCH] D58541: [CodeComplete] Propagate preferred type for function arguments in more cases

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58541/new/ https://reviews.llvm.org/D58541

r354826 - [CodeGenObjC] Fix a nullptr dyn_cast

Author: epilk Date: Mon Feb 25 13:35:14 2019 New Revision: 354826 URL: http://llvm.org/viewvc/llvm-project?rev=354826&view=rev Log: [CodeGenObjC] Fix a nullptr dyn_cast ObjCMessageExpr::getInstanceReceiver returns nullptr if the receiver is 'super'. Make this check more strict, since we don't car

Re: r354795 - Make static counters in ASTContext non-static.

Thank you for taking care of this! That's a bug indeed. Will recommit with a fix. On Mon, Feb 25, 2019 at 9:25 PM Vlad Tsyrklevich wrote: > I've reverted this commit in r354812, it was causing MSan failures like > http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/builds/29886/steps/c

r354827 - Reapply "Make static counters in ASTContext non-static." with fixes.

Author: alexfh Date: Mon Feb 25 14:22:09 2019 New Revision: 354827 URL: http://llvm.org/viewvc/llvm-project?rev=354827&view=rev Log: Reapply "Make static counters in ASTContext non-static." with fixes. This reverts commit e50038e4dc53caee1acc811362ac0b15e00ef5eb. Modified: cfe/trunk/include/

Re: r354795 - Make static counters in ASTContext non-static.

Done. r354827 should be better. On Mon, Feb 25, 2019 at 11:18 PM Alexander Kornienko wrote: > Thank you for taking care of this! That's a bug indeed. Will recommit with > a fix. > > On Mon, Feb 25, 2019 at 9:25 PM Vlad Tsyrklevich > wrote: > >> I've reverted this commit in r354812, it was causi

[PATCH] D57898: CodeGen: Fix PR40605: split constant structures generated by -ftrivial-auto-var-init when emitting initializators

jfb added a comment. I think (with test updates) this will be good to go once D58188 lands. Comment at: tools/clang/lib/CodeGen/CGDecl.cpp:1158 + llvm::StructType *STy = dyn_cast(Ty); + if (STy && (STy == Loc.getElementType()) && + shou

r354831 - [NFC] Reorder some mis-ordered tests

Author: jfb Date: Mon Feb 25 15:09:34 2019 New Revision: 354831 URL: http://llvm.org/viewvc/llvm-project?rev=354831&view=rev Log: [NFC] Reorder some mis-ordered tests I somehow had misaligned some of the tests when I originally wrote this. Re-order them properly. Modified: cfe/trunk/test/Co

[PATCH] D58292: Add support for importing ChooseExpr AST nodes.

tmroeder updated this revision to Diff 188262. tmroeder added a comment. Updating after switching to the git monorepo model. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58292/new/ https://reviews.llvm.org/D58292 Files: clang/docs/LibASTMatcher

[PATCH] D58649: Fix inline assembler constraint validation

joerg created this revision. joerg added a reviewer: compnerd. Herald added a subscriber: eraman. The current constraint logic is both too lax and too strict. It fails for input outside the [INT_MIN..INT_MAX] range, but it also implicitly accepts 0 as value when it should not. Adjust logic to ha

[PATCH] D58292: Add support for importing ChooseExpr AST nodes.

This revision was automatically updated to reflect the committed changes. Closed by commit rL354832: [ASTImporter] Add support for importing ChooseExpr AST nodes. (authored by tmroeder, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D58658: [OpenCL] Fix assertion due to blocks

yaxunl created this revision. yaxunl added a reviewer: Anastasia. Herald added subscribers: kristof.beyls, javed.absar. A recent change caused assertion in CodeGenFunction::EmitBlockCallExpr when a block is called. There is code if (!isa(E->getCalleeDecl())) Func = CGM.getOpenCLRuntime().

[PATCH] D58659: [Sema] Fix assertion when `auto` parameter in lambda has an attribute.

vsapsai created this revision. vsapsai added reviewers: rsmith, arphaman. Herald added subscribers: jdoerfert, dexonsmith, jkorous. Fixes the assertion > no Attr* for AttributedType* > UNREACHABLE executed at llvm-project/clang/lib/Sema/SemaType.cpp:298! In `TypeProcessingState::getAttributedTy

[PATCH] D58659: [Sema] Fix assertion when `auto` parameter in lambda has an attribute.

vsapsai added a comment. Have doubts that checking only the outermost type for being `AttributedType` after `Sema::ReplaceAutoType` is sufficient but haven't found a counterexample yet. Decided to post the proposed fix to see if others have any ideas. CHANGES SINCE LAST ACTION https://review

[PATCH] D58137: [clang-tidy] Add the abseil-time-subtraction check

hwright updated this revision to Diff 188289. hwright marked 5 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58137/new/ https://reviews.llvm.org/D58137 Files: clang-tidy/abseil/AbseilTidyModule.cpp clang-tidy/abseil/CMakeLists.txt clang-tidy/abseil/Duration

[PATCH] D58137: [clang-tidy] Add the abseil-time-subtraction check

hwright added inline comments. Comment at: clang-tidy/abseil/TimeSubtractionCheck.cpp:97 +void TimeSubtractionCheck::check(const MatchFinder::MatchResult &Result) { + const auto *BinOp = Result.Nodes.getNodeAs("binop"); + std::string inverse_name = JonasToth wr

r354838 - [MS] Fix for Bug 8446, template instantiation without a 'typename' keyword

Author: rnk Date: Mon Feb 25 18:22:17 2019 New Revision: 354838 URL: http://llvm.org/viewvc/llvm-project?rev=354838&view=rev Log: [MS] Fix for Bug 8446, template instantiation without a 'typename' keyword Patch by Zahira Ammarguellat! Differential Revision: https://reviews.llvm.org/D41950 Added

r354839 - Revert r354832 "[ASTImporter] Add support for importing ChooseExpr AST nodes."

Author: rnk Date: Mon Feb 25 18:22:22 2019 New Revision: 354839 URL: http://llvm.org/viewvc/llvm-project?rev=354839&view=rev Log: Revert r354832 "[ASTImporter] Add support for importing ChooseExpr AST nodes." Test does not pass on Windows Removed: cfe/trunk/test/ASTMerge/ Modified: cfe/t

[PATCH] D41950: Fix for Bug 8446. Template instantiation without a 'typename' keyword.

This revision was automatically updated to reflect the committed changes. Closed by commit rC354838: [MS] Fix for Bug 8446, template instantiation without a 'typename' keyword (authored by rnk, committed by ). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rC

[PATCH] D58292: Add support for importing ChooseExpr AST nodes.

rnk added a comment. I had to revert this in rL354839 because one of the tests didn't pass on Windows: http://lab.llvm.org:8011/builders/clang-x64-windows-msvc/builds/4641 Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58292/new/

[PATCH] D41950: Fix for Bug 8446. Template instantiation without a 'typename' keyword.

rnk added a comment. In D41950#1409332 , @zahiraam wrote: > I don't think I have commit right can you please commit it. Thanks. Sure, done! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D41950/new/ https://reviews.llvm.o

[PATCH] D58530: Add PragmaHandler for MSVC pragma execution_character_set

rnk added a comment. Looks good and thorough, but it needs tests. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58530/new/ https://reviews.llvm.org/D58530 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https

[PATCH] D37994: Implement LWG2946: More ambiguity in `string` vs. `string_view`

mclow.lists abandoned this revision. mclow.lists added a comment. Herald added a subscriber: jdoerfert. This appears to have been applied in a slightly different form. Certainly the functionality is there. Closing. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D37994/new/ https://review

r354832 - [ASTImporter] Add support for importing ChooseExpr AST nodes.

Author: tmroeder Date: Mon Feb 25 15:24:58 2019 New Revision: 354832 URL: http://llvm.org/viewvc/llvm-project?rev=354832&view=rev Log: [ASTImporter] Add support for importing ChooseExpr AST nodes. Summary: This allows ASTs to be merged when they contain ChooseExpr (the GNU __builtin_choose_expr c

r354843 - [CGDebugInfo] Set NonTrivial DIFlag to a c++ record if it's not trivial

Author: asmith Date: Mon Feb 25 19:49:05 2019 New Revision: 354843 URL: http://llvm.org/viewvc/llvm-project?rev=354843&view=rev Log: [CGDebugInfo] Set NonTrivial DIFlag to a c++ record if it's not trivial This goes with https://reviews.llvm.org/D44406 Modified: cfe/trunk/lib/CodeGen/CGDebug

[PATCH] D52956: Support `-fno-visibility-inlines-hidden`

smeenai added a comment. I tried committing this for you, but it doesn't apply to master. Could you rebase? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D52956/new/ https://reviews.llvm.org/D52956 ___ cfe-commits ma

[PATCH] D58663: [ASTImporter] Add support for importing ChooseExpr AST nodes.

tmroeder created this revision. tmroeder added reviewers: shafik, a_sidorin, martong, aaron.ballman, rnk. tmroeder added a project: clang. Herald added a reviewer: a.sidorin. This allows ASTs to be merged when they contain ChooseExpr (the GNU __builtin_choose_expr construction). This is needed, fo

[PATCH] D58514: Avoid needlessly copying blocks that initialize or are assigned to local auto variables to the heap

rjmccall added a comment. Okay, one last minor request, then LGTM. Comment at: lib/CodeGen/CGObjC.cpp:2953 + return asImpl().visitExpr(e); +} + Oh, I'd forgotten this wasn't a normal expression visitor. Well, okay, this isn't too bad. Comm

[PATCH] D58663: [ASTImporter] Add support for importing ChooseExpr AST nodes.

tmroeder updated this revision to Diff 188307. tmroeder added a comment. Dropped the C++ part of the ImportChooseExpr test entirely. This is the part that was breaking the tests on Windows, and after further experimentation, it turns out that clang on Windows never expands the template under th

[PATCH] D58634: [PR40778] Generate address space conversion when binding reference to a temporary value in different address space

rjmccall added inline comments. Comment at: lib/CodeGen/CGCall.cpp:4067 + IRFuncTy->getParamType(FirstIRArg)->isPointerTy()) +V = Builder.CreatePointerBitCastOrAddrSpaceCast( +V, IRFuncTy->getParamType(FirstIRArg)); Anasta

[PATCH] D56411: [CUDA][HIP][Sema] Fix template kernel with function as template parameter

rjmccall added a comment. In D56411#1406212 , @yaxunl wrote: > I would like to fix the validation issue only and leave the overload > resolution issue for future. As I understand it, the "validation issue" is just that you'd like a diagnostic to be emi

[PATCH] D58321: [WIP] Support for relative vtables

rjmccall added inline comments. Comment at: clang/include/clang/Driver/Options.td:1250 + Group, Flags<[CC1Option]>, + HelpText<"Use the unstable C++ class ABI for classes with hidden LTO visibility">; def flto_jobs_EQ : Joined<["-"], "flto-jobs=">, Please mak

[PATCH] D58569: [libclang] Avoid crashing when getting layout info of an undeduced type.

emilio marked 2 inline comments as done. emilio added a comment. Huh, somehow forgot to press "Submit" this morning :) Comment at: clang/tools/c-index-test/c-index-test.c:1695 +CXType RT = clang_getResultType(T); +if (RT.kind != CXType_Invalid) + PrintSingleTypeSiz

[PATCH] D58609: [clang-tidy] bugprone-string-integer-assignment: Reduce false positives.

courbet updated this revision to Diff 188316. courbet added a comment. - more tests Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58609/new/ https://reviews.llvm.org/D58609 Files: clang-tidy/bugprone/StringIntegerAssignmentCheck.cpp test/clang-

[clang-tools-extra] r354765 - [clangd] Add thread priority lowering for MacOS as well

Author: kadircet Date: Mon Feb 25 01:19:26 2019 New Revision: 354765 URL: http://llvm.org/viewvc/llvm-project?rev=354765&view=rev Log: [clangd] Add thread priority lowering for MacOS as well Reviewers: ilya-biryukov Subscribers: ioeric, MaskRay, jkorous, arphaman, cfe-commits Tags: #clang Diff

[PATCH] D58492: [clangd] Add thread priority lowering for MacOS as well

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE354765: [clangd] Add thread priority lowering for MacOS as well (authored by kadircet, committed by ). Changed prior to commit: https://reviews.llvm.org/D58492?vs=187908&id=188106#toc Repository: r

[PATCH] D58035: [clang/DIVar] Emit flag for params that have unchanged values

djtodoro marked an inline comment as done. djtodoro added a comment. > I'm not quite sure what this differential is about, but i feel like > mentioning ExprMutationAnalyzer lib in clang-tidy / clang-tools-extra. >> Alternatively perhaps you could re-use getMemoryLocation() from D57660 >>

[PATCH] D57883: [clang-tidy] refactor ExceptionAnalyzer further to give ternary answer

bjope added subscribers: dyung, bjope. bjope added inline comments. Herald added a subscriber: Charusso. Comment at: clang-tidy/utils/ExceptionAnalyzer.h:112 +/// throw, if it's unknown or if it won't throw. +enum State Behaviour : 2; + (post-commit comme

[PATCH] D57883: [clang-tidy] refactor ExceptionAnalyzer further to give ternary answer

bjope added a subscriber: sammccall. bjope added a comment. Maybe @sammccall remembers why it was decided to rewrite the enum into constexpr:s in https://reviews.llvm.org/rCTE319608 ? Do we need a similar solution here? Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://

[PATCH] D58035: [clang/DIVar] Emit flag for params that have unchanged values

djtodoro updated this revision to Diff 188110. djtodoro added a comment. Herald added a subscriber: jdoerfert. - Handle all kinds of expressions when mark a param's modification CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58035/new/ https://reviews.llvm.org/D58035 Files: include/cl

[PATCH] D58600: [clangd] Emit source to Diagnostic.

hokein created this revision. hokein added a reviewer: ilya-biryukov. Herald added subscribers: kadircet, arphaman, jkorous, MaskRay, ioeric. Herald added a project: clang. Set "clang", "clang-tidy" as the source to the diagnostics, so that client can distinguish diagnostics from clang-tidy. Rep

[PATCH] D58541: [CodeComplete] Propagate preferred type for function arguments in more cases

kadircet added inline comments. Herald added a subscriber: Charusso. Comment at: clang/include/clang/Sema/Sema.h:294 + /// function_ref, clients should make sure all calls to get() with the same + /// location happen while function_ref is alive. + void enterFunctionArgument(So

[PATCH] D58571: [libclang] Fix a trivial error introduced in D57946.

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. Herald added a subscriber: Charusso. LGTM! Thanks! I guess we are missing a python test? No idea why we are not testing it though... Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D58541: [CodeComplete] Propagate preferred type for function arguments in more cases

xbolva00 added inline comments. Comment at: clang/lib/Sema/SemaCodeComplete.cpp:494 default: assert(false && "unhnalded unary op"); return QualType(); Typo? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D58570: [libclang] Expose warn_unused and warn_unused_result attributes.

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Although for consistency we could add this into python bindings too. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58570/new/ https:

[PATCH] D58601: Fixed grammar in index.rst

gribozavr created this revision. Herald added a subscriber: arphaman. Herald added a project: clang. gribozavr added a reviewer: ilya-biryukov. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D58601 Files: clang-tools-extra/docs/index.rst Index: clang-tools-extra/docs/index.rs

[PATCH] D58602: Removed an unhelpful comment in index.rst

gribozavr created this revision. gribozavr added a reviewer: ilya-biryukov. Herald added subscribers: jdoerfert, arphaman. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D58602 Files: clang-tools-extra/docs/index.rst Index: clang-tools-extra/doc

[PATCH] D58603: Updated the documentation build instructions for the current CMake build system

gribozavr created this revision. gribozavr added a reviewer: ilya-biryukov. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D58603 Files: clang-tools-extra/docs/README.txt Index: clang-tools-extra/docs/README.txt =

[PATCH] D58569: [libclang] Avoid crashing when getting layout info of an undeduced type.

Anastasia added inline comments. Comment at: clang/tools/c-index-test/c-index-test.c:1695 +CXType RT = clang_getResultType(T); +if (RT.kind != CXType_Invalid) + PrintSingleTypeSize(RT, " [resulttype=%s] [resulttypekind=%s]", Should it not return unde

[PATCH] D58504: [OpenCL][8.0.0 Release] Notes for OpenCL

Anastasia updated this revision to Diff 188122. Anastasia added a comment. Updated the section title! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58504/new/ https://reviews.llvm.org/D58504 Files: docs/ReleaseNotes.rst Index: docs/ReleaseNotes.rst =

[PATCH] D58504: [OpenCL][8.0.0 Release] Notes for OpenCL

Anastasia marked an inline comment as done. Anastasia added inline comments. Comment at: docs/ReleaseNotes.rst:228 -OpenCL C Language Changes in Clang +OpenCL Language Changes in Clang -- Anastasia wrote: > AlexeySotkin wrote: >

r354773 - [SYCL] Add clang front-end option to enable SYCL device compilation flow.

Author: bader Date: Mon Feb 25 03:48:48 2019 New Revision: 354773 URL: http://llvm.org/viewvc/llvm-project?rev=354773&view=rev Log: [SYCL] Add clang front-end option to enable SYCL device compilation flow. Patch by Mariya Podchishchaeva Added: cfe/trunk/test/Preprocessor/sycl-macro.cpp (w

[PATCH] D57768: [SYCL] Add clang front-end option to enable SYCL device compilation flow.

bader closed this revision. bader added a comment. Committed: https://reviews.llvm.org/rL354773 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57768/new/ https://reviews.llvm.org/D57768 ___ cfe-commits

[PATCH] D58604: [clang-tidy] misc-string-integer-assignment: ignore toupper/tolower

courbet created this revision. courbet added reviewers: xazax.hun, alexfh. Herald added subscribers: cfe-commits, rnkovacs. Herald added a project: clang. Tis represents ~20% of false positives. See PR27723. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D58604 Files: clang-ti

[PATCH] D57914: [Driver] Allow enum SanitizerOrdinal to represent more than 64 different sanitizer checks, NFC.

pgousseau updated this revision to Diff 188128. pgousseau added a comment. Herald added a subscriber: jfb. Fix bad use of reference as pointed out, aliased SanitizerKind to SanitizerMasks<> instead. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57914/new/ https://reviews.llvm.org/D5791

[PATCH] D58341: [clangd] Index UsingDecls

hokein added a comment. Thanks for the explanation. In D58341#1401365 , @ilya-biryukov wrote: > In D58341#1401295 , @hokein wrote: > > > std::strcmp is a fair case here. Sema seems not returning using-decls as >

[PATCH] D58606: [clang-tidy] misc-string-integer-assignment: fix false positive

courbet created this revision. courbet added reviewers: xazax.hun, alexfh. Herald added subscribers: cfe-commits, rnkovacs. Herald added a project: clang. using CodePoint = uint32_t; CodePoint cp; casic_string s; s += cp; Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D58606 Fil

[PATCH] D58607: Moved clangd docs to a separate directory in preparation to restructure them into multiple files

gribozavr created this revision. gribozavr added a reviewer: ilya-biryukov. Herald added subscribers: jdoerfert, kadircet, arphaman, jkorous, MaskRay, ioeric. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D58607 Files: clang-tools-extra/docs/cla

[PATCH] D58607: Moved clangd docs to a separate directory in preparation to restructure them into multiple files

ilya-biryukov added inline comments. Comment at: clang-tools-extra/docs/clangd.rst:1 - -Clangd - +:orphan: Having this does page not seem useful in the long-run. Do we plan to remove it later? Or maybe there a way to create a redirect i

[PATCH] D58607: Moved clangd docs to a separate directory in preparation to restructure them into multiple files

gribozavr marked an inline comment as done. gribozavr added inline comments. Comment at: clang-tools-extra/docs/clangd.rst:1 - -Clangd - +:orphan: ilya-biryukov wrote: > Having this does page not seem useful in the long-run. > Do we plan

[PATCH] D58602: Removed an unhelpful comment in index.rst

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58602/new/ https://reviews.llvm.org/D58602 _

[PATCH] D58603: Updated the documentation build instructions for the current CMake build system

ilya-biryukov added inline comments. Comment at: clang-tools-extra/docs/README.txt:5 -Sphinx and doxygen documentation is generated by executing make. +You can generate documentation in HTML format from files in +clang-tools-extra/docs by building the docs-clang-tools-html targ

[PATCH] D58601: Fixed grammar in index.rst

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58601/new/ https://reviews.llvm.org/D58601 _

[PATCH] D58603: Updated the documentation build instructions for the current CMake build system

gribozavr updated this revision to Diff 188133. gribozavr marked 2 inline comments as done. gribozavr added a comment. . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58603/new/ https://reviews.llvm.org/D58603 Files: clang-tools-extra/docs/READM

[PATCH] D58603: Updated the documentation build instructions for the current CMake build system

ilya-biryukov marked an inline comment as done. ilya-biryukov added inline comments. Comment at: clang-tools-extra/docs/README.txt:6 +You can generate documentation in HTML format from files in +clang-tools-extra/docs by building the docs-clang-tools-html target. --

[clang-tools-extra] r354777 - Removed an unhelpful comment in index.rst

Author: gribozavr Date: Mon Feb 25 04:48:52 2019 New Revision: 354777 URL: http://llvm.org/viewvc/llvm-project?rev=354777&view=rev Log: Removed an unhelpful comment in index.rst Reviewers: ilya-biryukov Subscribers: arphaman, jdoerfert, cfe-commits Tags: #clang Differential Revision: https://r

[clang-tools-extra] r354778 - Fixed grammar in index.rst

Author: gribozavr Date: Mon Feb 25 04:49:27 2019 New Revision: 354778 URL: http://llvm.org/viewvc/llvm-project?rev=354778&view=rev Log: Fixed grammar in index.rst Subscribers: arphaman, cfe-commits Tags: #clang Differential Revision: https://reviews.llvm.org/D58601 Modified: clang-tools-ex

[PATCH] D58606: [clang-tidy] misc-string-integer-assignment: fix false positive

xazax.hun added a comment. The change looks good but it would be great to have a regression test as well. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58606/new/ https://reviews.llvm.org/D58606 ___ cfe

[PATCH] D58602: Removed an unhelpful comment in index.rst

This revision was automatically updated to reflect the committed changes. Closed by commit rL354777: Removed an unhelpful comment in index.rst (authored by gribozavr, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.

[PATCH] D58601: Fixed grammar in index.rst

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE354778: Fixed grammar in index.rst (authored by gribozavr, committed by ). Changed prior to commit: https://reviews.llvm.org/D58601?vs=188117&id=188135#toc Repository: rCTE Clang Tools Extra CHANG

[PATCH] D58603: Updated the documentation build instructions for the current CMake build system

gribozavr added inline comments. Comment at: clang-tools-extra/docs/README.txt:6 +You can generate documentation in HTML format from files in +clang-tools-extra/docs by building the docs-clang-tools-html target. ilya-biryukov wrote: > ilya-biryukov wrote: > > C

[PATCH] D58604: [clang-tidy] misc-string-integer-assignment: ignore toupper/tolower

xazax.hun accepted this revision. xazax.hun added a comment. This revision is now accepted and ready to land. LGTM! Thanks for working on this. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58604/new/ https://reviews.llvm.org/D58604 _

[clang-tools-extra] r354779 - Updated the documentation build instructions for the current CMake build system

Author: gribozavr Date: Mon Feb 25 05:03:44 2019 New Revision: 354779 URL: http://llvm.org/viewvc/llvm-project?rev=354779&view=rev Log: Updated the documentation build instructions for the current CMake build system Reviewers: ilya-biryukov Subscribers: cfe-commits Tags: #clang Differential Re

[PATCH] D58607: Moved clangd docs to a separate directory in preparation to restructure them into multiple files

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang-tools-extra/docs/clangd.rst:1 - -Clangd - +:orphan: gribozavr wrote: > ilya-biryukov wrote: >

[PATCH] D58603: Updated the documentation build instructions for the current CMake build system

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58603/new/ https://reviews.llvm.org/D58603 _

[PATCH] D58603: Updated the documentation build instructions for the current CMake build system

This revision was automatically updated to reflect the committed changes. Closed by commit rL354779: Updated the documentation build instructions for the current CMake build system (authored by gribozavr, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Chang

[PATCH] D58609: [clang-tidy] bugprone-string-integer-assignment: Reduce false positives.

courbet created this revision. courbet added reviewers: xazax.hun, alexfh. Herald added subscribers: cfe-commits, jdoerfert, rnkovacs. Herald added a project: clang. Detect a few expressions as likely character expressions, see PR27723. Repository: rCTE Clang Tools Extra https://reviews.llvm.

[clang-tools-extra] r354780 - [clang-tidy] misc-string-integer-assignment: ignore toupper/tolower

Author: courbet Date: Mon Feb 25 05:09:02 2019 New Revision: 354780 URL: http://llvm.org/viewvc/llvm-project?rev=354780&view=rev Log: [clang-tidy] misc-string-integer-assignment: ignore toupper/tolower Summary: Tis represents ~20% of false positives. See PR27723. Reviewers: xazax.hun, alexfh Su

[PATCH] D58604: [clang-tidy] misc-string-integer-assignment: ignore toupper/tolower

courbet added a comment. Thanks. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58604/new/ https://reviews.llvm.org/D58604 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/c

[PATCH] D58604: [clang-tidy] misc-string-integer-assignment: ignore toupper/tolower

This revision was automatically updated to reflect the committed changes. Closed by commit rL354780: [clang-tidy] misc-string-integer-assignment: ignore toupper/tolower (authored by courbet, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LL

[PATCH] D58611: Fixed typos in tests: s/CHEKC/CHECK/

gribozavr created this revision. gribozavr added a reviewer: ilya-biryukov. Herald added subscribers: cfe-commits, jsji, javed.absar, nemanjai. Herald added projects: clang, LLVM. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D58611 Files: clang/test/CodeGenObjC/dllstorage.m

[PATCH] D58611: Fixed typos in tests: s/CHEKC/CHECK/

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58611/new/ https://reviews.llvm.org/D58611 _

[PATCH] D58612: Use std::atomic<> for static counters.

alexfh created this revision. alexfh added a reviewer: ilya-biryukov. Herald added a subscriber: jfb. Herald added a project: clang. Fixes a data race and makes it possible to run clang-based tools in multithreaded environment with TSan. Repository: rG LLVM Github Monorepo https://reviews.llv

r354785 - Fixed typos in tests: s/CHEKC/CHECK/

Author: gribozavr Date: Mon Feb 25 05:41:59 2019 New Revision: 354785 URL: http://llvm.org/viewvc/llvm-project?rev=354785&view=rev Log: Fixed typos in tests: s/CHEKC/CHECK/ Reviewers: ilya-biryukov Subscribers: nemanjai, javed.absar, jsji, cfe-commits, llvm-commits Tags: #clang, #llvm Differen

[PATCH] D58612: Use std::atomic<> for static counters.

riccibruno added a comment. Hmm. These are not the only static variables which are used for statistics (eg: in `DeclBase.cpp`). Would it make sense instead to keep all of the statistics in the AST context (without making them atomic) ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang-tools-extra] r354786 - Moved clangd docs to a separate directory in preparation to restructure them into multiple files

Author: gribozavr Date: Mon Feb 25 05:43:48 2019 New Revision: 354786 URL: http://llvm.org/viewvc/llvm-project?rev=354786&view=rev Log: Moved clangd docs to a separate directory in preparation to restructure them into multiple files Reviewers: ilya-biryukov Subscribers: ioeric, MaskRay, jkorous

[PATCH] D58611: Fixed typos in tests: s/CHEKC/CHECK/

This revision was automatically updated to reflect the committed changes. Closed by commit rC354785: Fixed typos in tests: s/CHEKC/CHECK/ (authored by gribozavr, committed by ). Changed prior to commit: https://reviews.llvm.org/D58611?vs=188143&id=188150#toc Repository: rC Clang CHANGES SIN

[PATCH] D58607: Moved clangd docs to a separate directory in preparation to restructure them into multiple files

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE354786: Moved clangd docs to a separate directory in preparation to restructure them… (authored by gribozavr, committed by ). Changed prior to commit: https://reviews.llvm.org/D58607?vs=188131&id=1881

  1   2   >