[PATCH] D58448: [clangd] Improve global code completion when scope specifier is unresolved.

ioeric updated this revision to Diff 188512. ioeric added a comment. - Rebase and minor cleanup Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58448/new/ https://reviews.llvm.org/D58448 Files: clangd/CodeComplete.cpp

[clang-tools-extra] r354957 - [clangd] Set thread priority on Windows

Author: ibiryukov Date: Wed Feb 27 02:16:03 2019 New Revision: 354957 URL: http://llvm.org/viewvc/llvm-project?rev=354957=rev Log: [clangd] Set thread priority on Windows Reviewers: kadircet, gribozavr Reviewed By: kadircet, gribozavr Subscribers: ioeric, MaskRay, jkorous, arphaman,

[PATCH] D58710: Added more detailed documentation for clangd

gribozavr updated this revision to Diff 188527. gribozavr added a comment. . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58710/new/ https://reviews.llvm.org/D58710 Files: clang-tools-extra/docs/clangd/ApplyClangTidyFixInVSCode.gif

[PATCH] D56160: [clang-tidy] modernize-use-trailing-return check

bernhardmgruber updated this revision to Diff 188528. bernhardmgruber marked 2 inline comments as done. bernhardmgruber added a comment. Herald added a subscriber: jdoerfert. - rebased onto current master - implemented a basic check for name collisions of unqualified names in the return type

[PATCH] D57716: [CUDA][HIP] Check calling convention based on function target

yaxunl marked an inline comment as done. yaxunl added inline comments. Comment at: lib/Sema/SemaDeclAttr.cpp:4620 const TargetInfo = Context.getTargetInfo(); - TargetInfo::CallingConvCheckResult A = TI.checkCallingConvention(CC); + auto *Aux = Context.getAuxTargetInfo(); +

Re: [clang-tools-extra] r354765 - [clangd] Add thread priority lowering for MacOS as well

Merged to release_80 in r354983. On Mon, Feb 25, 2019 at 10:18 AM Kadir Cetinkaya via cfe-commits wrote: > > Author: kadircet > Date: Mon Feb 25 01:19:26 2019 > New Revision: 354765 > > URL: http://llvm.org/viewvc/llvm-project?rev=354765=rev > Log: > [clangd] Add thread priority lowering for

[PATCH] D58710: Added more detailed documentation for clangd

ilya-biryukov added inline comments. Comment at: clang-tools-extra/docs/clangd/Features.rst:41 + +**(New in v9)** +If a missing symbol was seen in a file you've edited recently, clangd will It feels wrong to have announcements of the `9.0` features in the `8.0`

[PATCH] D58710: Added more detailed documentation for clangd

gribozavr updated this revision to Diff 188535. gribozavr added a comment. . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58710/new/ https://reviews.llvm.org/D58710 Files: clang-tools-extra/docs/_static/clang-tools-extra-styles.css

r355000 - [ASTImporter] Improve import of FileID.

Author: balazske Date: Wed Feb 27 08:31:48 2019 New Revision: 355000 URL: http://llvm.org/viewvc/llvm-project?rev=355000=rev Log: [ASTImporter] Improve import of FileID. Summary: Even if the content cache has a directory and filename, it may be a virtual file. The old code returned with error

[PATCH] D58710: Added more detailed documentation for clangd

gribozavr updated this revision to Diff 188521. gribozavr marked 2 inline comments as done. gribozavr added a comment. Addressed review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58710/new/ https://reviews.llvm.org/D58710 Files:

[PATCH] D56160: [clang-tidy] modernize-use-trailing-return check

lebedev.ri added a comment. I just noticed, i don't like the naming choice in the check. `UseTrailingReturn` what is the "trailing return"? This is about "trailing return *type*", no? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56160/new/ https://reviews.llvm.org/D56160

[PATCH] D58710: Added more detailed documentation for clangd

gribozavr updated this revision to Diff 188531. gribozavr added a comment. Herald added a reviewer: serge-sans-paille. Added custom CSS for the details tag. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58710/new/ https://reviews.llvm.org/D58710

[PATCH] D56160: [clang-tidy] modernize-use-trailing-return check

JonasToth added a comment. > It took me far too long to come up with an update. Honestly, I was quite > demotivated as it turned out preventing name collisions of unqualifed names > after the rewrite was more difficult than I thought. Especially because this > error occurs sparsely when I test

[PATCH] D58710: Added more detailed documentation for clangd

gribozavr marked an inline comment as done. gribozavr added inline comments. Comment at: clang-tools-extra/docs/clangd/Installation.rst:360 + +- Pass an experimental `-background-index` command line argument. With + this feature enabled, clangd incrementally builds an index of

[PATCH] D56160: [clang-tidy] modernize-use-trailing-return check

bernhardmgruber marked 2 inline comments as done. bernhardmgruber added a comment. Hi guys! It took me far too long to come up with an update. Honestly, I was quite demotivated as it turned out preventing name collisions of unqualifed names after the rewrite was more difficult than I thought.

[PATCH] D58710: Added more detailed documentation for clangd

gribozavr updated this revision to Diff 188536. gribozavr added a comment. Removed mentions of clangd v9. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58710/new/ https://reviews.llvm.org/D58710 Files:

[PATCH] D58710: Added more detailed documentation for clangd

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58710/new/ https://reviews.llvm.org/D58710

[PATCH] D58717: Added documentation for clangd v9+ features

gribozavr created this revision. gribozavr added a reviewer: ilya-biryukov. Herald added subscribers: cfe-commits, jdoerfert, kadircet, arphaman, jkorous, MaskRay, ioeric. Herald added a project: clang. ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now

[PATCH] D58717: Added documentation for clangd v9+ features

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58717/new/ https://reviews.llvm.org/D58717

[clang-tools-extra] r354994 - Added documentation for clangd v9+ features

Author: gribozavr Date: Wed Feb 27 08:08:04 2019 New Revision: 354994 URL: http://llvm.org/viewvc/llvm-project?rev=354994=rev Log: Added documentation for clangd v9+ features Reviewers: ilya-biryukov Subscribers: ioeric, MaskRay, jkorous, arphaman, kadircet, jdoerfert, cfe-commits Tags:

[PATCH] D57590: [ASTImporter] Improve import of FileID.

This revision was automatically updated to reflect the committed changes. Closed by commit rC355000: [ASTImporter] Improve import of FileID. (authored by balazske, committed by ). Changed prior to commit: https://reviews.llvm.org/D57590?vs=184760=188553#toc Repository: rC Clang CHANGES

[PATCH] D58721: Added release notes for clangd 8

gribozavr created this revision. gribozavr added a reviewer: ilya-biryukov. Herald added subscribers: cfe-commits, jdoerfert, kadircet, arphaman, jkorous, MaskRay, ioeric. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D58721 Files:

Re: [clang-tools-extra] r353422 - [clangd] Reduce number of threads used by BackgroundIndex to number of physical cores.

Merged to release_80 in r354980. On Thu, Feb 7, 2019 at 5:04 PM Kadir Cetinkaya via cfe-commits wrote: > > Author: kadircet > Date: Thu Feb 7 08:04:30 2019 > New Revision: 353422 > > URL: http://llvm.org/viewvc/llvm-project?rev=353422=rev > Log: > [clangd] Reduce number of threads used by

[PATCH] D58710: Added more detailed documentation for clangd

ilya-biryukov added a comment. It feels we have two groups of docs here, do you think it would be useful to split them more explicitly? Specifically, we have: 1. User documentation - Getting started with clangd - Features 2. Developer documentation - Protocol extensions - Compiling

[PATCH] D57898: CodeGen: Fix PR40605

glider updated this revision to Diff 188548. glider marked an inline comment as done. glider retitled this revision from "CodeGen: Fix PR40605: split constant structures generated by -ftrivial-auto-var-init when emitting initializators" to "CodeGen: Fix PR40605". glider edited the summary of

Re: [clang-tools-extra] r354957 - [clangd] Set thread priority on Windows

Merged to release_80 in r354984. On Wed, Feb 27, 2019 at 11:15 AM Ilya Biryukov via cfe-commits wrote: > > Author: ibiryukov > Date: Wed Feb 27 02:16:03 2019 > New Revision: 354957 > > URL: http://llvm.org/viewvc/llvm-project?rev=354957=rev > Log: > [clangd] Set thread priority on Windows > >

[PATCH] D58710: Added more detailed documentation for clangd

gribozavr updated this revision to Diff 188534. gribozavr added a comment. Separated user and developer documentation Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58710/new/ https://reviews.llvm.org/D58710 Files:

[clang-tools-extra] r354992 - Added more detailed documentation for clangd

Author: gribozavr Date: Wed Feb 27 07:53:05 2019 New Revision: 354992 URL: http://llvm.org/viewvc/llvm-project?rev=354992=rev Log: Added more detailed documentation for clangd Summary: The text was written mostly by Sam McCall, screenshots are mostly made by me. Reviewers: ilya-biryukov

[PATCH] D58710: Added more detailed documentation for clangd

This revision was automatically updated to reflect the committed changes. Closed by commit rL354992: Added more detailed documentation for clangd (authored by gribozavr, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D58717: Added documentation for clangd v9+ features

This revision was automatically updated to reflect the committed changes. Closed by commit rL354994: Added documentation for clangd v9+ features (authored by gribozavr, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D57898: CodeGen: Fix PR40605

glider added a comment. Rebased the code, updated the tests, added FIXME. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57898/new/ https://reviews.llvm.org/D57898 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D58710: Added more detailed documentation for clangd

gribozavr marked 4 inline comments as done. gribozavr added inline comments. Comment at: clang-tools-extra/docs/clangd/Installation.rst:360 + +- Pass an experimental `-background-index` command line argument. With + this feature enabled, clangd incrementally builds an index of

Re: [clang-tools-extra] r354505 - [clangd] Store index in '.clangd/index' instead of '.clangd-index'

Merged to release_80 in r354982. On Wed, Feb 20, 2019 at 8:07 PM Ilya Biryukov via cfe-commits wrote: > > Author: ibiryukov > Date: Wed Feb 20 11:08:06 2019 > New Revision: 354505 > > URL: http://llvm.org/viewvc/llvm-project?rev=354505=rev > Log: > [clangd] Store index in '.clangd/index' instead

[PATCH] D57716: [CUDA][HIP] Check calling convention based on function target

yaxunl marked an inline comment as done. yaxunl added inline comments. Comment at: lib/Sema/SemaDeclAttr.cpp:4620 const TargetInfo = Context.getTargetInfo(); - TargetInfo::CallingConvCheckResult A = TI.checkCallingConvention(CC); + auto *Aux = Context.getAuxTargetInfo(); +

r354990 - [NFC] minor revision of r354929 [CUDA][HIP] Check calling convention based on function target

Author: yaxunl Date: Wed Feb 27 07:46:29 2019 New Revision: 354990 URL: http://llvm.org/viewvc/llvm-project?rev=354990=rev Log: [NFC] minor revision of r354929 [CUDA][HIP] Check calling convention based on function target Add comments and move a variable to if block. Differential Revision:

[PATCH] D58665: [analyzer] Handle comparison between non-default AS symbol and constant

dstenb updated this revision to Diff 188538. dstenb added a comment. Address comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58665/new/ https://reviews.llvm.org/D58665 Files: lib/StaticAnalyzer/Core/SimpleSValBuilder.cpp test/Analysis/ptr-cmp-const-trunc.cl Index:

[PATCH] D54395: [clang-tidy] implement utility-function to add 'const' to variables

JonasToth added a comment. Herald added a subscriber: jdoerfert. another ping. @alexfh and @aaron.ballman you commented on prior versions. Would be nice if you could take a (final) look at this patch! Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION

[PATCH] D58719: [PR40778][Sema] Adjust address space of operands in builtin operators

Anastasia created this revision. Anastasia added reviewers: rjmccall, ebevhan. Adjust address space for references and pointer operands of builtin operators. Currently this patch only changes addr space for OpenCL in assignment operator, that is needed to fix the bug in the testcase reported

[PATCH] D58236: Make address space conversions a bit stricter.

ebevhan marked an inline comment as done. ebevhan added inline comments. Comment at: test/SemaOpenCL/address-spaces.cl:87 + + // FIXME: This doesn't seem right. This should be an error, not a warning. + __local int * __global * __private * lll; Anastasia

[clang-tools-extra] r354963 - [clangd] Improve global code completion when scope specifier is unresolved.

Author: ioeric Date: Wed Feb 27 03:42:37 2019 New Revision: 354963 URL: http://llvm.org/viewvc/llvm-project?rev=354963=rev Log: [clangd] Improve global code completion when scope specifier is unresolved. Summary: Suppose `clangd::` is unresolved in the following example. Currently, we simply use

[PATCH] D57590: [ASTImporter] Improve import of FileID.

balazske added a comment. Currently there is no direct test for `ASTImporter` `FileID` (and other non-Decl) import. These are tested indirectly by other import tests. There is something that fails in a macOS LLDB test without this. Repository: rC Clang CHANGES SINCE LAST ACTION

[PATCH] D58710: Added more detailed documentation for clangd

gribozavr created this revision. gribozavr added a reviewer: ilya-biryukov. Herald added subscribers: cfe-commits, jdoerfert, kadircet, arphaman, jkorous, MaskRay, ioeric. Herald added a project: clang. The text was written mostly by Sam McCall, screenshots are mostly made by me. Repository:

[PATCH] D58708: [PR40778] Preserve addr space in Derived to Base cast

Anastasia created this revision. Anastasia added a reviewer: rjmccall. Herald added a subscriber: ebevhan. The address space for the Base class pointer when up-casting from Derived should be taken from the Derived class pointer. https://reviews.llvm.org/D58708 Files: lib/CodeGen/CGClass.cpp

[PATCH] D58448: [clangd] Improve global code completion when scope specifier is unresolved.

This revision was automatically updated to reflect the committed changes. Closed by commit rL354963: [clangd] Improve global code completion when scope specifier is unresolved. (authored by ioeric, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository:

[PATCH] D58683: [clangd] Set thread priority on Windows

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE354957: [clangd] Set thread priority on Windows (authored by ibiryukov, committed by ). Changed prior to commit: https://reviews.llvm.org/D58683?vs=188396=188505#toc Repository: rCTE Clang Tools

[PATCH] D58600: [clangd] Emit source to Diagnostic.

ilya-biryukov added inline comments. Comment at: clangd/ClangdUnit.cpp:380 if (Preamble) Diags.insert(Diags.begin(), Preamble->Diags.begin(), Preamble->Diags.end()); return ParsedAST(std::move(Preamble), std::move(Clang), std::move(Action), Preamble

[PATCH] D58710: Added more detailed documentation for clangd

ilya-biryukov added a reviewer: ioeric. ilya-biryukov added a comment. Still looking at it, a few quick notes. Also added ioeric for an extra pair of eyes (it's a large change!). Comment at: clang-tools-extra/docs/clangd/Installation.rst:360 + +- Pass an experimental

[PATCH] D58137: [clang-tidy] Add the abseil-time-subtraction check

JonasToth accepted this revision. JonasToth added a comment. This revision is now accepted and ready to land. I am happy now :) Thank you for the patch, LGTM Comment at: test/clang-tidy/abseil-time-subtraction.cpp:12 + + d = absl::Hours(absl::ToUnixHours(t) - x); + //

[PATCH] D58606: [clang-tidy] misc-string-integer-assignment: fix false positive

JonasToth accepted this revision. JonasToth added a comment. This revision is now accepted and ready to land. LGTM. is there a bug or similar? If yes please mention it somewhere in the summary or so and close it :) Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION

[PATCH] D58609: [clang-tidy] bugprone-string-integer-assignment: Reduce false positives.

JonasToth added inline comments. Comment at: clang-tidy/bugprone/StringIntegerAssignmentCheck.cpp:54 + (RHS->EvaluateAsInt(RHSVal, Ctx, Expr::SE_AllowSideEffects) || + LHS->EvaluateAsInt(RHSVal, Ctx, Expr::SE_AllowSideEffects))) { +return true;

[PATCH] D57883: [clang-tidy] refactor ExceptionAnalyzer further to give ternary answer

bjope added inline comments. Comment at: clang-tidy/utils/ExceptionAnalyzer.h:112 +/// throw, if it's unknown or if it won't throw. +enum State Behaviour : 2; + JonasToth wrote: > bjope wrote: > > (post-commit comments) > > > > I've seen that @dyung did

[PATCH] D58236: Make address space conversions a bit stricter.

ebevhan updated this revision to Diff 188504. ebevhan marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58236/new/ https://reviews.llvm.org/D58236 Files: include/clang/Basic/DiagnosticSemaKinds.td include/clang/Sema/Sema.h lib/Sema/SemaCast.cpp

r354968 - AttrDocs.td: fix broken bullet-point indentation

Author: hans Date: Wed Feb 27 05:11:37 2019 New Revision: 354968 URL: http://llvm.org/viewvc/llvm-project?rev=354968=rev Log: AttrDocs.td: fix broken bullet-point indentation Modified: cfe/trunk/include/clang/Basic/AttrDocs.td Modified: cfe/trunk/include/clang/Basic/AttrDocs.td URL:

[PATCH] D58721: Added release notes for clangd 8

This revision was automatically updated to reflect the committed changes. Closed by commit rL355004: Added release notes for clangd 8 (authored by hans, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

r355012 - Avoid needlessly copying a block to the heap when a block literal

Author: ahatanak Date: Wed Feb 27 10:17:16 2019 New Revision: 355012 URL: http://llvm.org/viewvc/llvm-project?rev=355012=rev Log: Avoid needlessly copying a block to the heap when a block literal initializes a local auto variable or is assigned to a local auto variable that is declared in the

r355017 - Add triples to the test I committed in r355012 to fix windows bots.

Author: ahatanak Date: Wed Feb 27 10:59:52 2019 New Revision: 355017 URL: http://llvm.org/viewvc/llvm-project?rev=355017=rev Log: Add triples to the test I committed in r355012 to fix windows bots. Modified: cfe/trunk/test/PCH/arc-blocks.mm Modified: cfe/trunk/test/PCH/arc-blocks.mm URL:

[PATCH] D56943: [clang-format][NFC] Allow getLLVMStyle() to take a language

rupprecht updated this revision to Diff 188584. rupprecht marked 2 inline comments as done. rupprecht added a comment. Revert getLLVMStyle(LK_Cpp) fixes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56943/new/ https://reviews.llvm.org/D56943

[PATCH] D56943: [clang-format][NFC] Allow getLLVMStyle() to take a language

rupprecht added inline comments. Comment at: clang/lib/Format/ContinuationIndenter.cpp:193 RawStringFormat.Language, )) { -PredefinedStyle = getLLVMStyle(); +PredefinedStyle = getLLVMStyle(FormatStyle::LK_Cpp);

[PATCH] D58666: [OpenCL] Undefine cl_intel_planar_yuv extension

Anastasia added inline comments. Comment at: test/SemaOpenCL/extension-begin.cl:26 + #ifndef IMPLICIT_INCLUDE #include "extension-begin.h" sidorovd wrote: > Anastasia wrote: > > Can we also test that macro `my_ext` is not defined here but defined above? > > >

[PATCH] D57914: [Driver] Allow enum SanitizerOrdinal to represent more than 64 different sanitizer checks, NFC.

pgousseau reopened this revision. pgousseau added a comment. This revision is now accepted and ready to land. Reopening because of buildbot failure http://green.lab.llvm.org/green/job/lldb-cmake/20537/ I have not been able to reproduce the error, the order of includes must be different on the

[PATCH] D58346: [Sema] Change addr space diagnostics in casts to follow C++ style

Anastasia updated this revision to Diff 188577. Anastasia added a comment. - Added a comment to explain OpenCL check. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58346/new/ https://reviews.llvm.org/D58346 Files: include/clang/Basic/DiagnosticSemaKinds.td lib/Sema/SemaCast.cpp

[PATCH] D58729: Emit boxed expression as a compile-time constant if the expression inside the parentheses is a string literal

ahatanak created this revision. ahatanak added reviewers: rjmccall, arphaman. ahatanak added a project: clang. Herald added subscribers: jdoerfert, dexonsmith, jkorous. clang currently emits an expression like `@("abc")` as a message send to `stringWithUTF8String`. This patch makes changes so

[PATCH] D58719: [PR40778][Sema] Adjust address space of operands in builtin operators

Anastasia updated this revision to Diff 188566. Anastasia edited the summary of this revision. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58719/new/ https://reviews.llvm.org/D58719 Files: lib/Sema/SemaOverload.cpp test/CodeGenOpenCLCXX/addrspace-operators.cl Index:

[PATCH] D58724: [gnustep-objc] Make the GNUstep v2 ABI work for Windows DLLs.

theraven added a comment. This review is mostly so that @DHowett-MSFT can check that I didn't break his patches too badly in the cleanup and test that they still do allow building Objective-C DLLs on Windows. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D58724: [gnustep-objc] Make the GNUstep v2 ABI work for Windows DLLs.

theraven created this revision. theraven added a reviewer: DHowett-MSFT. Herald added a project: clang. Herald added a subscriber: cfe-commits. theraven added a comment. This review is mostly so that @DHowett-MSFT can check that I didn't break his patches too badly in the cleanup and test that

[libclc] r355016 - Creating release candidate rc3 from release_800 branch

Author: hans Date: Wed Feb 27 10:49:24 2019 New Revision: 355016 URL: http://llvm.org/viewvc/llvm-project?rev=355016=rev Log: Creating release candidate rc3 from release_800 branch Added: libclc/tags/RELEASE_800/rc3/ - copied from r355015, libclc/branches/release_80/

[PATCH] D52835: [Diagnostics] Check integer to floating point number implicit conversions

xbolva00 added a comment. @aaron.ballman does it make sense to warn for this case only in C mode? Since this case in C++ is handled by -Wnarrowing, as we see from tests. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D52835/new/ https://reviews.llvm.org/D52835

[PATCH] D58721: Added release notes for clangd 8

gribozavr updated this revision to Diff 188555. gribozavr added a comment. . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58721/new/ https://reviews.llvm.org/D58721 Files: clang-tools-extra/docs/ReleaseNotes.rst

[PATCH] D58346: [Sema] Change addr space diagnostics in casts to follow C++ style

Anastasia marked an inline comment as done. Anastasia added inline comments. Comment at: lib/Sema/SemaCast.cpp:2309 +auto DestPointeeTypeWithoutAS = Self.Context.removeAddrSpaceQualType( +DestPointeeType.getCanonicalType()); +return

[PATCH] D58418: [clang][DirectoryWatcher] Upstream DirectoryWatcher

jkorous updated this revision to Diff 188586. jkorous added a comment. - moved checks for CoreServices/inotify to cmake CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58418/new/ https://reviews.llvm.org/D58418 Files: clang/include/clang/DirectoryWatcher/DirectoryWatcher.h

[PATCH] D58721: Added release notes for clangd 8

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang-tools-extra/docs/ReleaseNotes.rst:76 + +- clangd has a new LSP extension that allows the client to request code actions + to be sent

[PATCH] D58236: Make address space conversions a bit stricter.

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks a lot for fixing this old bug! Btw, do you plan to look at generalizing this to C++ as well? I don't feel we need anything for mixing OpenCL with GNU style address spaces

[PATCH] D57716: [CUDA][HIP] Check calling convention based on function target

rjmccall added inline comments. Comment at: lib/Sema/SemaDeclAttr.cpp:4620 const TargetInfo = Context.getTargetInfo(); - TargetInfo::CallingConvCheckResult A = TI.checkCallingConvention(CC); + auto *Aux = Context.getAuxTargetInfo(); + if (LangOpts.CUDA) {

[PATCH] D58719: [PR40778][Sema] Adjust address space of operands in builtin operators

rjmccall added a comment. I think the right model is that a builtin operator candidate exists for all possible address-space qualifiers on the pointer/reference pointee, and it should be straightforward to only actually add candidates for the qualifier used by the corresponding operand.

[PATCH] D58236: Make address space conversions a bit stricter.

efriedma added a comment. Generally, with an explicit cast, C allows any pointer cast with a reasonable interpretation, even if the underlying operation is suspicious. For example, you can cast an "long*" to a "int*" (as in "(int*)(long*)p") without any complaint, even though dereferencing

[libunwind] r355016 - Creating release candidate rc3 from release_800 branch

Author: hans Date: Wed Feb 27 10:49:24 2019 New Revision: 355016 URL: http://llvm.org/viewvc/llvm-project?rev=355016=rev Log: Creating release candidate rc3 from release_800 branch Added: libunwind/tags/RELEASE_800/rc3/ - copied from r355015, libunwind/branches/release_80/

[PATCH] D58062: Support framework import/include auto-completion

dgoldman closed this revision. dgoldman added a comment. Closed via rL355008 Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58062/new/ https://reviews.llvm.org/D58062 ___

[PATCH] D57914: [Driver] Allow enum SanitizerOrdinal to represent more than 64 different sanitizer checks, NFC.

pgousseau updated this revision to Diff 188576. pgousseau added a comment. move hash_value declaration to clang's namespace to solve lldb cmake bot build error. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57914/new/ https://reviews.llvm.org/D57914 Files:

[PATCH] D58708: [PR40778] Preserve addr space in Derived to Base cast

rjmccall added inline comments. Comment at: lib/Sema/SemaExpr.cpp:2670 } else { DestType = DestRecordType; FromRecordType = FromType; This path (when the object is a gl-value) also needs an address-space qualifier, so you should probably add

[PATCH] D58514: Avoid needlessly copying blocks that initialize or are assigned to local auto variables to the heap

ahatanak closed this revision. ahatanak added a comment. Fixed in r355012. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58514/new/ https://reviews.llvm.org/D58514 ___ cfe-commits mailing list

[PATCH] D58236: Make address space conversions a bit stricter.

rjmccall added inline comments. Comment at: test/SemaOpenCL/address-spaces.cl:87 + + // FIXME: This doesn't seem right. This should be an error, not a warning. + __local int * __global * __private * lll; Anastasia wrote: > ebevhan wrote: > > Anastasia wrote: >

[PATCH] D57898: CodeGen: Fix PR40605

jfb added a comment. Can you change the title to be more descriptive? Small test fixes, otherwise this LGTM, will check box after update. Comment at: clang/test/CodeGenCXX/auto-var-init.cpp:123 +// PATTERN-NOT-O1: @__const.test_int1_custom.custom +// ZERO-NOT-O1:

[PATCH] D58418: [clang][DirectoryWatcher] Upstream DirectoryWatcher

xbolva00 added a comment. Maybe move it to LLVM? As this watcher may be useful for other projects in the future? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58418/new/ https://reviews.llvm.org/D58418 ___ cfe-commits mailing list

[PATCH] D58729: Emit boxed expression as a compile-time constant if the expression inside the parentheses is a string literal

rjmccall added inline comments. Comment at: lib/CodeGen/CGExprConstant.cpp:1793 + "this boxed expression can't be emitted as a compile-time constant"); + return emitConstantObjCStringLiteral(cast(E->getSubExpr()), + E->getType(),

[PATCH] D58478: [index-while-building] FileIndexRecord

nathawes accepted this revision. nathawes added a comment. This revision is now accepted and ready to land. Looks good to me. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58478/new/ https://reviews.llvm.org/D58478 ___ cfe-commits mailing

r355035 - [clang][index-while-building] FileIndexRecord

Author: jkorous Date: Wed Feb 27 13:47:40 2019 New Revision: 355035 URL: http://llvm.org/viewvc/llvm-project?rev=355035=rev Log: [clang][index-while-building] FileIndexRecord Basic data structures for index Tests are missing from this patch - will be covered properly by tests for the whole

r355036 - [clang][index-while-building][NFC] FileIndexRecord - Comments, replace auto with type

Author: jkorous Date: Wed Feb 27 13:48:02 2019 New Revision: 355036 URL: http://llvm.org/viewvc/llvm-project?rev=355036=rev Log: [clang][index-while-building][NFC] FileIndexRecord - Comments, replace auto with type Differential Revision: https://reviews.llvm.org/D58478 Modified:

[PATCH] D58478: [index-while-building] FileIndexRecord

This revision was automatically updated to reflect the committed changes. Closed by commit rC355035: [clang][index-while-building] FileIndexRecord (authored by jkorous, committed by ). Changed prior to commit: https://reviews.llvm.org/D58478?vs=187863=188614#toc Repository: rC Clang

[PATCH] D58537: lib/Header: Simplify CMakeLists.txt

smeenai accepted this revision. smeenai added a comment. LGTM, thanks! Comment at: clang/lib/Headers/CMakeLists.txt:136 list(APPEND out_files ${dst}) + # The list function only updates out_files in the current scope. We need + # call set in order to also update the

[PATCH] D56160: [clang-tidy] modernize-use-trailing-return-type check

lebedev.ri added a comment. In D56160#1412701 , @bernhardmgruber wrote: > - renamed the check to modernize-use-trailing-return-type Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56160/new/ https://reviews.llvm.org/D56160

[PATCH] D58731: [clang-tidy] added cppcoreguidelines-explicit-virtual-functions

alexfh added a comment. Thank you for the contribution! Please see the comments inline. Comment at: clang-tidy/modernize/UseOverrideCheck.cpp:22 // Only register the matcher for C++11. - if (getLangOpts().CPlusPlus11) -

[PATCH] D58731: [clang-tidy] added cppcoreguidelines-explicit-virtual-functions

alexfh added inline comments. Comment at: clang-tidy/modernize/UseOverrideCheck.h:23 + : ClangTidyCheck(Name, Context), +IgnoreDestructors(Options.get("IgnoreDestructors", false)) {} void registerMatchers(ast_matchers::MatchFinder *Finder) override;

[clang-tools-extra] r355024 - [clang-tidy] Add the abseil-time-subtraction check

Author: hwright Date: Wed Feb 27 12:08:50 2019 New Revision: 355024 URL: http://llvm.org/viewvc/llvm-project?rev=355024=rev Log: [clang-tidy] Add the abseil-time-subtraction check Differential Revision: https://reviews.llvm.org/D58137 Added:

[PATCH] D58731: [clang-tidy] added cppcoreguidelines-explicit-virtual-functions

JonasToth added a comment. I think this change is worth mentioning in the release notes as well (cte/docs/ReleaseNotes.rst) Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58731/new/ https://reviews.llvm.org/D58731

[PATCH] D58731: [clang-tidy] added cppcoreguidelines-explicit-virtual-functions

JonasToth added a comment. Welcome to the LLVM community and thank you for the patch lewmpk! Please add unit tests for the changes you made to the check. They live in `clang-tools-extra/test/clang-tidy/modernize-`. It is common to add a additional test-file to ensure the configuration

r355027 - [OPENMP]Delay emission of the error for unsupported types.

Author: abataev Date: Wed Feb 27 12:29:45 2019 New Revision: 355027 URL: http://llvm.org/viewvc/llvm-project?rev=355027=rev Log: [OPENMP]Delay emission of the error for unsupported types. If the type is unsupported on the device side, it still must be emitted, but we should emit errors for

[PATCH] D58731: [clang-tidy] added cppcoreguidelines-explicit-virtual-functions

MyDeveloperDay added a comment. Please resubmit this patch with full context git diff --cached -U99 > patch_to_submitt.diff You need to add some documention describing the new option into the check in docs/clang-tidy/checks/modernize .rst Repository: rCTE Clang Tools Extra

[PATCH] D58737: [InstrProf] Use separate comdat group for data and counters

rnk created this revision. rnk added reviewers: xur, vsk. Herald added subscribers: Sanitizers, cfe-commits, hiraditya, eraman. Herald added projects: clang, Sanitizers, LLVM. I hadn't realized that instrumentation runs before inlining, so we can't use the function as the comdat group. Doing so

r355033 - Use Secure PLT as default on NetBSD/PowerPC.

Author: joerg Date: Wed Feb 27 13:46:01 2019 New Revision: 355033 URL: http://llvm.org/viewvc/llvm-project?rev=355033=rev Log: Use Secure PLT as default on NetBSD/PowerPC. Modified: cfe/trunk/lib/Driver/ToolChains/Arch/PPC.cpp cfe/trunk/test/Driver/netbsd.c Modified:

[PATCH] D56943: [clang-format][NFC] Allow getLLVMStyle() to take a language

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. I think I've seen you need this for another patch, so in the absence of the code owners this LGTM, and thank you for removing all the changes to the tests in the previous

  1   2   >