[PATCH] D58764: [clang-tidy] ignore predefined expressions in cppcoreguidelines-pro-bounds-array-to-pointer-decay check

lebedev.ri requested changes to this revision. lebedev.ri added a comment. This revision now requires changes to proceed. See D22196 . Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58764/new/

[PATCH] D58772: [clangd] Enable SuggestMissingIncludes by default.

ioeric created this revision. ioeric added a reviewer: kadircet. Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. This seems to work stably now. Turn on by default. Repository: rCTE Clang Tools Extra

[PATCH] D58060: Fix diagnostic for addr spaces in static_cast

Anastasia added a comment. Btw, I have changed the diagnostic wording... does this change make sense now? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58060/new/ https://reviews.llvm.org/D58060 ___ cfe-commits mailing list

[PATCH] D58418: [clang][DirectoryWatcher] Upstream DirectoryWatcher

davezarzycki added a comment. Can we please revert this code? One cannot use dynamic_cast on a char *. Did you mean reinterpret_cast? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58418/new/ https://reviews.llvm.org/D58418 ___ cfe-commits

[PATCH] D58774: Moved Symbol into its own header and implementation file

gribozavr updated this revision to Diff 188714. gribozavr added a comment. Herald added a subscriber: mgrang. Also moved the SymbolSlab implementation into Symbol.cpp Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58774/new/

[PATCH] D58777: [analyzer] Fix an assertation failurure for invalid sourcelocation, add a new debug checker

Szelethus updated this revision to Diff 188713. Szelethus added a comment. Added context. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58777/new/ https://reviews.llvm.org/D58777 Files: docs/analyzer/developer-docs/DebugChecks.rst include/clang/StaticAnalyzer/Checkers/Checkers.td

[clang-tools-extra] r355088 - Moved Symbol into its own header and implementation file

Author: gribozavr Date: Thu Feb 28 05:23:03 2019 New Revision: 355088 URL: http://llvm.org/viewvc/llvm-project?rev=355088=rev Log: Moved Symbol into its own header and implementation file Reviewers: ioeric Subscribers: mgorny, jkorous, arphaman, kadircet, jdoerfert, cfe-commits Tags: #clang

[PATCH] D58649: Fix inline assembler constraint validation

joerg marked an inline comment as done. joerg added inline comments. Comment at: include/clang/Basic/TargetInfo.h:860 + if (!ImmSet.empty()) +return ImmSet.count(Value.getZExtValue()) != 0; + return !ImmRange.isConstrained || (Value.sge(ImmRange.Min) &&

[PATCH] D58774: Moved Symbol into its own header and implementation file

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE355088: Moved Symbol into its own header and implementation file (authored by gribozavr, committed by ). Changed prior to commit: https://reviews.llvm.org/D58774?vs=188714=188715#toc Repository:

[PATCH] D54395: [clang-tidy] implement utility-function to add 'const' to variables

JonasToth updated this revision to Diff 188716. JonasToth marked 3 inline comments as done. JonasToth added a comment. - address review comments - rebase to master Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54395/new/

[PATCH] D58778: Moved Ref into its own header and implementation file

gribozavr updated this revision to Diff 188723. gribozavr marked an inline comment as done. gribozavr added a comment. Added a license header. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58778/new/ https://reviews.llvm.org/D58778 Files:

[PATCH] D58609: [clang-tidy] bugprone-string-integer-assignment: Reduce false positives.

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE355089: [clang-tidy] bugprone-string-integer-assignment: Reduce false positives. (authored by courbet, committed by ). Changed prior to commit: https://reviews.llvm.org/D58609?vs=188690=188722#toc

[PATCH] D58609: [clang-tidy] bugprone-string-integer-assignment: Reduce false positives.

courbet added a comment. Thanks. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58609/new/ https://reviews.llvm.org/D58609 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D58781: Added missing license headers

ioeric accepted this revision. ioeric added a comment. This revision is now accepted and ready to land. lg. thanks!!! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58781/new/ https://reviews.llvm.org/D58781

[PATCH] D58606: [clang-tidy] misc-string-integer-assignment: fix false positive

This revision was automatically updated to reflect the committed changes. Closed by commit rL355076: [clang-tidy] misc-string-integer-assignment: fix false positive (authored by courbet, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LLVM

[PATCH] D58768: Moved SymbolLocation into its own header and implementation file

gribozavr created this revision. gribozavr added a reviewer: ioeric. Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, mgorny. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D58768 Files: clang-tools-extra/clangd/CMakeLists.txt

[PATCH] D58769: Moved DenseMap support for SymbolID into SymbolID.h

gribozavr created this revision. gribozavr added a reviewer: ioeric. Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D58769 Files: clang-tools-extra/clangd/index/Index.h

[PATCH] D58769: Moved DenseMap support for SymbolID into SymbolID.h

gribozavr closed this revision. gribozavr added a comment. Committed as https://reviews.llvm.org/rL355081. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58769/new/ https://reviews.llvm.org/D58769 ___

[PATCH] D56830: Prototype for include-fixer workflow in clangd. [NOT FOR REVIEW]

ioeric abandoned this revision. ioeric added a comment. Herald added a subscriber: jdoerfert. Herald added a project: clang. Include-fixer has been landed in clangd. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56830/new/

[PATCH] D58773: Moved SymbolOrigin into its own header and implementation file

gribozavr added a comment. SymbolOrigin is used by itself, for example, in CodeComplete.h to define `struct CodeCompletion`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58773/new/ https://reviews.llvm.org/D58773

[PATCH] D58773: Moved SymbolOrigin into its own header and implementation file

ioeric accepted this revision. ioeric added a comment. This revision is now accepted and ready to land. In D58773#1413486 , @gribozavr wrote: > SymbolOrigin is used by itself, for example, in CodeComplete.h to define > `struct CodeCompletion`. Fair

[PATCH] D58666: [OpenCL] Undefine cl_intel_planar_yuv extension

sidorovd marked an inline comment as done. sidorovd added inline comments. Comment at: test/SemaOpenCL/extension-begin.cl:26 + #ifndef IMPLICIT_INCLUDE #include "extension-begin.h" Anastasia wrote: > sidorovd wrote: > > Anastasia wrote: > > > sidorovd wrote: >

[PATCH] D54395: [clang-tidy] implement utility-function to add 'const' to variables

JonasToth marked an inline comment as done. JonasToth added inline comments. Comment at: unittests/clang-tidy/AddConstTest.cpp:15 + +template alexfh wrote: > What's the point of default values of template arguments here? Wups, relict of older version.

[PATCH] D58764: [clang-tidy] ignore predefined expressions in cppcoreguidelines-pro-bounds-array-to-pointer-decay check

JonasToth added a comment. You can abondon this. A short justification (with reference to the other revision) on the bug report would be great! Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58764/new/ https://reviews.llvm.org/D58764

[PATCH] D58782: Use ArrayRef::copy, instead of copying data manually

gribozavr created this revision. gribozavr added a reviewer: ioeric. Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D58782 Files: clang-tools-extra/clangd/index/Ref.cpp Index:

[PATCH] D58731: [clang-tidy] added cppcoreguidelines-explicit-virtual-functions

alexfh added a comment. In D58731#1413552 , @JonasToth wrote: > In D58731#1413498 , @MyDeveloperDay > wrote: > > > In D58731#1413476 , @lewmpk wrote: > > > > > I'm happy to

[PATCH] D57898: CodeGen: Fix PR40605 by splitting constant struct initializers

glider added inline comments. Comment at: clang/test/CodeGenCXX/auto-var-init.cpp:130 +// PATTERN-NOT-O1: @__const.test_bool4_custom.custom +// ZERO-NOT-O1: @__const.test_bool4_custom.custom + jfb wrote: > `-NOT` is in the wrong place above. Hm, I wonder if lit

[PATCH] D58773: Moved SymbolOrigin into its own header and implementation file

ioeric added a comment. I'm not sure if SymbolOrigin is interesting enough to be its own library. It's usually only used along with Symbol. Maybe we could pull a library Symbol.h instead and put SymbolOrigin by Symbol? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D58774: Moved Symbol into its own header and implementation file

gribozavr created this revision. gribozavr added a reviewer: ioeric. Herald added subscribers: cfe-commits, jdoerfert, kadircet, arphaman, jkorous, mgorny. Herald added a project: clang. gribozavr added a parent revision: D58773: Moved SymbolOrigin into its own header and implementation file.

[PATCH] D56160: [clang-tidy] modernize-use-trailing-return-type check

JonasToth added a comment. From my side only the nits are left. Comment at: clang-tidy/modernize/UseTrailingReturnTypeCheck.cpp:94 + bool VisitDeclRefExpr(DeclRefExpr *S) { +const DeclarationName Name = S->getNameInfo().getName(); +if (!S->getQualifierLoc() &&

[PATCH] D58778: Moved Ref into its own header and implementation file

ioeric added inline comments. Comment at: clang-tools-extra/clangd/index/Ref.cpp:1 +#include "Ref.h" + License? Comment at: clang-tools-extra/clangd/index/SymbolCollector.cpp:14 #include "CodeCompletionStrings.h" +#include "ExpectedTypes.h"

[PATCH] D58743: Handle built-in when importing SourceLocation and FileID

martong accepted this revision. martong added a reviewer: balazske. martong added a subscriber: balazske. martong added a comment. Shafik, this looks good to me, once teemperor's comments are addressed. Note, I added @balazske as a reviewer, he recently worked with importing the FileIDs, he may

[PATCH] D58778: Moved Ref into its own header and implementation file

This revision was automatically updated to reflect the committed changes. gribozavr marked an inline comment as done. Closed by commit rL355090: Moved Ref into its own header and implementation file (authored by gribozavr, committed by ). Herald added subscribers: llvm-commits, ilya-biryukov.

[PATCH] D58781: Added missing license headers

gribozavr created this revision. gribozavr added a reviewer: ioeric. Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D58781 Files: clang-tools-extra/clangd/ExpectedTypes.cpp

[PATCH] D58609: [clang-tidy] bugprone-string-integer-assignment: Reduce false positives.

courbet updated this revision to Diff 188690. courbet marked an inline comment as done. courbet added a comment. - rebase - -more cosmetics Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58609/new/ https://reviews.llvm.org/D58609 Files:

[clang-tools-extra] r355082 - Moved SymbolLocation into its own header and implementation file

Author: gribozavr Date: Thu Feb 28 03:02:01 2019 New Revision: 355082 URL: http://llvm.org/viewvc/llvm-project?rev=355082=rev Log: Moved SymbolLocation into its own header and implementation file Reviewers: ioeric Subscribers: mgorny, jkorous, arphaman, kadircet, cfe-commits Tags: #clang

[PATCH] D58236: Make address space conversions a bit stricter.

Anastasia added a comment. > Along those lines, in general, the normal C rules should allow casting `foo*` > to `bar*` for any object types foo and bar, even if foo and bar are pointers > with address spaces, like `__local int *` and `__global int *`. I don't see > anything in the OpenCL

[PATCH] D58768: Moved SymbolLocation into its own header and implementation file

ioeric added a comment. I think another option here is to move Symbol+SymbolLocations to a Symbol.h library. SymbolLocation is often used along with Symbol. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58768/new/ https://reviews.llvm.org/D58768

[clang-tools-extra] r355081 - Moved DenseMap support for SymbolID into SymbolID.h

Author: gribozavr Date: Thu Feb 28 03:00:44 2019 New Revision: 355081 URL: http://llvm.org/viewvc/llvm-project?rev=355081=rev Log: Moved DenseMap support for SymbolID into SymbolID.h Modified: clang-tools-extra/trunk/clangd/index/Index.h clang-tools-extra/trunk/clangd/index/SymbolID.h

[PATCH] D58731: [clang-tidy] added cppcoreguidelines-explicit-virtual-functions

JonasToth added a comment. In D58731#1413498 , @MyDeveloperDay wrote: > In D58731#1413476 , @lewmpk wrote: > > > I'm happy to land this ASAP but I don't have commit rights > > > So one of us could land it for

[PATCH] D58774: Moved Symbol into its own header and implementation file

ioeric added inline comments. Comment at: clang-tools-extra/clangd/index/Index.cpp:19 -llvm::raw_ostream <<(llvm::raw_ostream , Symbol::SymbolFlag F) { - if (F == Symbol::None) -return OS << "None"; - std::string S; - if (F & Symbol::Deprecated) -S += "deprecated|";

[clang-tools-extra] r355086 - Moved SymbolOrigin into its own header and implementation file

Author: gribozavr Date: Thu Feb 28 04:31:49 2019 New Revision: 355086 URL: http://llvm.org/viewvc/llvm-project?rev=355086=rev Log: Moved SymbolOrigin into its own header and implementation file Reviewers: ioeric Subscribers: mgorny, jkorous, arphaman, kadircet, jdoerfert, cfe-commits Tags:

[PATCH] D58774: Moved Symbol into its own header and implementation file

gribozavr updated this revision to Diff 188712. gribozavr added a comment. Moving SymbolSlab as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58774/new/ https://reviews.llvm.org/D58774 Files: clang-tools-extra/clangd/CMakeLists.txt

[PATCH] D58774: Moved Symbol into its own header and implementation file

gribozavr added a comment. Moved SymbolSlab as well, PTAL. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58774/new/ https://reviews.llvm.org/D58774 ___ cfe-commits mailing list

[clang-tools-extra] r355089 - [clang-tidy] bugprone-string-integer-assignment: Reduce false positives.

Author: courbet Date: Thu Feb 28 05:39:01 2019 New Revision: 355089 URL: http://llvm.org/viewvc/llvm-project?rev=355089=rev Log: [clang-tidy] bugprone-string-integer-assignment: Reduce false positives. Summary: Detect a few expressions as likely character expressions, see PR27723. Reviewers:

[clang-tools-extra] r355092 - Added missing license headers

Author: gribozavr Date: Thu Feb 28 06:01:11 2019 New Revision: 355092 URL: http://llvm.org/viewvc/llvm-project?rev=355092=rev Log: Added missing license headers Reviewers: ioeric Subscribers: jkorous, arphaman, kadircet, cfe-commits Tags: #clang Differential Revision:

[PATCH] D58781: Added missing license headers

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE355092: Added missing license headers (authored by gribozavr, committed by ). Changed prior to commit: https://reviews.llvm.org/D58781?vs=188726=188731#toc Repository: rCTE Clang Tools Extra

[PATCH] D57898: CodeGen: Fix PR40605 by splitting constant struct initializers

glider updated this revision to Diff 188694. glider marked 3 inline comments as done. glider retitled this revision from "CodeGen: Fix PR40605" to "CodeGen: Fix PR40605 by splitting constant struct initializers". CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57898/new/

[PATCH] D58764: [clang-tidy] ignore predefined expressions in cppcoreguidelines-pro-bounds-array-to-pointer-decay check

lewmpk added a comment. Okk, it seems that the consensus is that `__FUNCTION__` should not be cast to `char*`. ( I'll research a bit before I pick up a task in the future :) ) I'm happy to abandon this diff - any objections? Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION

[PATCH] D58731: [clang-tidy] added cppcoreguidelines-explicit-virtual-functions

lewmpk added a comment. I'm happy to land this ASAP but I don't have commit rights CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58731/new/ https://reviews.llvm.org/D58731 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D57087: [clang-tidy] add OverrideMacro to modernize-use-override check

lewmpk added a comment. I'm happy to land this ASAP but I don't have commit rights CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57087/new/ https://reviews.llvm.org/D57087 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D58773: Moved SymbolOrigin into its own header and implementation file

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE355086: Moved SymbolOrigin into its own header and implementation file (authored by gribozavr, committed by ). Changed prior to commit: https://reviews.llvm.org/D58773?vs=188703=188709#toc

[PATCH] D58774: Moved Symbol into its own header and implementation file

ioeric added a comment. The design of Symbol and SymbolSlab are closely related. I would suggest putting them close together in the same library. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58774/new/ https://reviews.llvm.org/D58774

[PATCH] D58777: [analyzer] Fix an assertation failurure for invalid sourcelocation, add a new debug checker

Szelethus created this revision. Szelethus added reviewers: NoQ, xazax.hun, rnkovacs, baloghadamsoftware, Charusso. Szelethus added a project: clang. Herald added subscribers: cfe-commits, gamesh411, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, szepet, whisperity. For a rather short code

[PATCH] D58609: [clang-tidy] bugprone-string-integer-assignment: Reduce false positives.

JonasToth accepted this revision. JonasToth added a comment. This revision is now accepted and ready to land. LGTM. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58609/new/ https://reviews.llvm.org/D58609

[PATCH] D58778: Moved Ref into its own header and implementation file

gribozavr marked 2 inline comments as done. gribozavr added inline comments. Comment at: clang-tools-extra/clangd/index/Ref.cpp:1 +#include "Ref.h" + ioeric wrote: > License? Added. Comment at:

[PATCH] D58778: Moved Ref into its own header and implementation file

gribozavr updated this revision to Diff 188724. gribozavr marked 2 inline comments as done. gribozavr added a comment. Added a missing include. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58778/new/ https://reviews.llvm.org/D58778 Files:

[PATCH] D58764: [clang-tidy] ignore predefined expressions in cppcoreguidelines-pro-bounds-array-to-pointer-decay check

lewmpk created this revision. lewmpk added a reviewer: clang-tools-extra. lewmpk added projects: clang, clang-tools-extra. Herald added subscribers: cfe-commits, kbarton, xazax.hun, nemanjai. Bugzilla: 40852 c++ int main() { const char* a = __FILE__; const char* b = __FUNCTION__;

[PATCH] D58346: [Sema] Change addr space diagnostics in casts to follow C++ style

Anastasia marked an inline comment as done. Anastasia added inline comments. Comment at: lib/Sema/SemaCast.cpp:2309 +auto DestPointeeTypeWithoutAS = Self.Context.removeAddrSpaceQualType( +DestPointeeType.getCanonicalType()); +return

[PATCH] D58731: [clang-tidy] added cppcoreguidelines-explicit-virtual-functions

MyDeveloperDay added a comment. In D58731#1413476 , @lewmpk wrote: > I'm happy to land this ASAP but I don't have commit rights So one of us could land it for you.. (I've not personally done that before as I'm a bit green too! but I do have commit

[clang-tools-extra] r355090 - Moved Ref into its own header and implementation file

Author: gribozavr Date: Thu Feb 28 05:49:25 2019 New Revision: 355090 URL: http://llvm.org/viewvc/llvm-project?rev=355090=rev Log: Moved Ref into its own header and implementation file Reviewers: ioeric Subscribers: mgorny, jkorous, mgrang, arphaman, kadircet, cfe-commits Tags: #clang

[PATCH] D58782: Use ArrayRef::copy, instead of copying data manually

lebedev.ri added a comment. Would it please be possible to write actual commit / DR titles, i.e. include appropriate `[tag]`s into them, and ideally proper commit messages, too? It really clutters -commit list listing otherwise. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang-tools-extra] r355091 - Use ArrayRef::copy, instead of copying data manually

Author: gribozavr Date: Thu Feb 28 06:00:26 2019 New Revision: 355091 URL: http://llvm.org/viewvc/llvm-project?rev=355091=rev Log: Use ArrayRef::copy, instead of copying data manually Reviewers: ioeric Subscribers: jkorous, arphaman, kadircet, cfe-commits Tags: #clang Differential Revision:

[PATCH] D58782: Use ArrayRef::copy, instead of copying data manually

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE355091: Use ArrayRef::copy, instead of copying data manually (authored by gribozavr, committed by ). Changed prior to commit: https://reviews.llvm.org/D58782?vs=188729=188730#toc Repository: rCTE

[PATCH] D58743: Handle built-in when importing SourceLocation and FileID

balazske added inline comments. Comment at: include/clang/AST/ASTImporter.h:342 // FIXME: Remove this version. -FileID Import(FileID); +FileID Import(FileID, bool isBuiltin=false); teemperor wrote: > `IsBuiltin`, not `isBuiltin` `IsBuiltin =

[clang-tools-extra] r355076 - [clang-tidy] misc-string-integer-assignment: fix false positive

Author: courbet Date: Thu Feb 28 02:33:32 2019 New Revision: 355076 URL: http://llvm.org/viewvc/llvm-project?rev=355076=rev Log: [clang-tidy] misc-string-integer-assignment: fix false positive Summary: using CodePoint = uint32_t; CodePoint cp; basic_string s; s += cp; See PR27723. Reviewers:

[PATCH] D58782: Use ArrayRef::copy, instead of copying data manually

ioeric accepted this revision. ioeric added a comment. This revision is now accepted and ready to land. Nice! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58782/new/ https://reviews.llvm.org/D58782

[PATCH] D58731: [clang-tidy] added cppcoreguidelines-explicit-virtual-functions

MyDeveloperDay added a comment. In D58731#1413695 , @alexfh wrote: > In D58731#1413552 , @JonasToth wrote: > > > In D58731#1413498 , > > @MyDeveloperDay wrote: > > > > > In

[clang-tools-extra] r355100 - [clang-tidy] include cppcoreguidelines-explicit-virtual-functions in list of checks and fix redirection

Author: jonastoth Date: Thu Feb 28 07:47:10 2019 New Revision: 355100 URL: http://llvm.org/viewvc/llvm-project?rev=355100=rev Log: [clang-tidy] include cppcoreguidelines-explicit-virtual-functions in list of checks and fix redirection Modified:

[PATCH] D57914: [Driver] Allow enum SanitizerOrdinal to represent more than 64 different sanitizer checks, NFC.

pgousseau updated this revision to Diff 188748. pgousseau added a comment. Change `hash_value()` declaration's location as suggested. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57914/new/ https://reviews.llvm.org/D57914 Files: include/clang/Basic/Attr.td

[PATCH] D52150: [clang-format] BeforeHash added to IndentPPDirectives

MyDeveloperDay added a comment. While we wait for code review I've landed this currently unaccepted clang-format revision into https://github.com/mydeveloperday/clang-experimental/releases for those wishing to try/test or provide feedback CHANGES SINCE LAST ACTION

[PATCH] D58731: [clang-tidy] added cppcoreguidelines-explicit-virtual-functions

MyDeveloperDay added a comment. @JonasToth I left a comment in the commit needed to fix the index.rst, which I don't think your later review fixes, sphinx complained about the rst file being an unreferenced octtree https://reviews.llvm.org/rG5fbeff797a9dba504f08f14c4fa59b6f1076fe72#inline-2691

[PATCH] D58731: [clang-tidy] added cppcoreguidelines-explicit-virtual-functions

This revision was automatically updated to reflect the committed changes. Closed by commit rL355093: [clang-tidy] added cppcoreguidelines-explicit-virtual-functions (authored by JonasToth, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to

[clang-tools-extra] r355093 - [clang-tidy] added cppcoreguidelines-explicit-virtual-functions

Author: jonastoth Date: Thu Feb 28 06:55:12 2019 New Revision: 355093 URL: http://llvm.org/viewvc/llvm-project?rev=355093=rev Log: [clang-tidy] added cppcoreguidelines-explicit-virtual-functions Addresses the bugzilla bug #30397. (https://bugs.llvm.org/show_bug.cgi?id=30397)

[PATCH] D57906: [CTU] Do not allow different CPP dialects in CTU

xazax.hun accepted this revision. xazax.hun added a comment. This revision is now accepted and ready to land. LGTM! I think we should commit this as is for now but maybe adding a TODO comment to summarize the problem would be nice. Maybe we could have an isSameDialect or similar method within

r355106 - Partial revert of r353952: [HIP] Handle compile -m options and propagate into LLC

Author: yaxunl Date: Thu Feb 28 09:08:26 2019 New Revision: 355106 URL: http://llvm.org/viewvc/llvm-project?rev=355106=rev Log: Partial revert of r353952: [HIP] Handle compile -m options and propagate into LLC Remove comments and tests about passing -mcode-object-v3 to driver since it does not

[PATCH] D58346: [Sema] Change addr space diagnostics in casts to follow C++ style

rjmccall added a comment. Hmm. Yeah, Embedded C allows these casts, so contra my previous comment, I think we can't make them ill-formed outside of OpenCL mode. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58346/new/ https://reviews.llvm.org/D58346

[PATCH] D58502: [ASTImporter] Fix redecl failures of Class and ClassTemplate

martong added a comment. @shafik, Could you please take a look? I have run the LLDB tests on our macOS and I could not discover any regression. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58502/new/ https://reviews.llvm.org/D58502

[PATCH] D58494: [ASTImporter] Handle redecl chain of FunctionTemplateDecls

martong added a comment. @shafik, Could you please take a look? I have run the LLDB tests on our macOS and I could not discover any regression. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58494/new/ https://reviews.llvm.org/D58494

[PATCH] D58537: lib/Header: Simplify CMakeLists.txt

tstellar updated this revision to Diff 188749. tstellar added a comment. Fix an issue with the generated arm headers that I discovered after doing some more testing. Also, remove comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58537/new/

[PATCH] D57914: [Driver] Allow enum SanitizerOrdinal to represent more than 64 different sanitizer checks, NFC.

riccibruno requested changes to this revision. riccibruno added inline comments. This revision now requires changes to proceed. Comment at: include/clang/Basic/Sanitizers.h:29 +class hash_code; +} What ? You are forward-declaring `hash_code` here and using it

[PATCH] D58731: [clang-tidy] added cppcoreguidelines-explicit-virtual-functions

JonasToth added a comment. Thank you for the patch! Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58731/new/ https://reviews.llvm.org/D58731 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang-tools-extra] r355098 - [clang-tidy] documentation fixing the actual correct file

Author: jonastoth Date: Thu Feb 28 07:39:47 2019 New Revision: 355098 URL: http://llvm.org/viewvc/llvm-project?rev=355098=rev Log: [clang-tidy] documentation fixing the actual correct file Modified: clang-tools-extra/trunk/docs/clang-tidy/checks/abseil-time-subtraction.rst Modified:

[clang-tools-extra] r355094 - [clang-tidy] attempt to fix documentation build-error

Author: jonastoth Date: Thu Feb 28 07:01:17 2019 New Revision: 355094 URL: http://llvm.org/viewvc/llvm-project?rev=355094=rev Log: [clang-tidy] attempt to fix documentation build-error Modified: clang-tools-extra/trunk/docs/clang-tidy/checks/abseil-time-subtraction.rst Modified:

[PATCH] D54881: [clang-format] Prevent Clang-Format from editing leading whitespace on lines outside of the format range

russellmcc added a comment. Herald added a subscriber: jdoerfert. Bump! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54881/new/ https://reviews.llvm.org/D54881 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D40988: Clang-format: add finer-grained options for putting all arguments on one line

russellmcc added a comment. Bump! Would really appreciate any feedback on this! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D40988/new/ https://reviews.llvm.org/D40988 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D57914: [Driver] Allow enum SanitizerOrdinal to represent more than 64 different sanitizer checks, NFC.

pgousseau marked an inline comment as done. pgousseau added inline comments. Comment at: include/clang/Basic/Sanitizers.h:29 +class hash_code; +} riccibruno wrote: > What ? You are forward-declaring `hash_code` here and using it as a value a > few lines

[clang-tools-extra] r355108 - [clang-tidy] fix documentation link in list of clang-tidy checks

Author: jonastoth Date: Thu Feb 28 09:53:51 2019 New Revision: 355108 URL: http://llvm.org/viewvc/llvm-project?rev=355108=rev Log: [clang-tidy] fix documentation link in list of clang-tidy checks Modified: clang-tools-extra/trunk/docs/clang-tidy/checks/list.rst Modified:

[clang-tools-extra] r355097 - [clang-tidy] tryfix documenation continued

Author: jonastoth Date: Thu Feb 28 07:28:36 2019 New Revision: 355097 URL: http://llvm.org/viewvc/llvm-project?rev=355097=rev Log: [clang-tidy] tryfix documenation continued Modified: clang-tools-extra/trunk/docs/clang-tidy/checks/abseil-duration-subtraction.rst Modified:

[clang-tools-extra] r355102 - [clang-tidy] redirection in list of checks adjusted

Author: jonastoth Date: Thu Feb 28 07:56:40 2019 New Revision: 355102 URL: http://llvm.org/viewvc/llvm-project?rev=355102=rev Log: [clang-tidy] redirection in list of checks adjusted Modified: clang-tools-extra/trunk/docs/clang-tidy/checks/list.rst Modified:

[clang-tools-extra] r355095 - [clang-tidy] another issue in documentation, double empty line seemed to confuse code-block

Author: jonastoth Date: Thu Feb 28 07:18:54 2019 New Revision: 355095 URL: http://llvm.org/viewvc/llvm-project?rev=355095=rev Log: [clang-tidy] another issue in documentation, double empty line seemed to confuse code-block Modified:

[PATCH] D57906: [CTU] Do not allow different CPP dialects in CTU

This revision was automatically updated to reflect the committed changes. martong marked an inline comment as done. Closed by commit rC355096: [CTU] Do not allow different CPP dialects in CTU (authored by martong, committed by ). Changed prior to commit:

r355096 - [CTU] Do not allow different CPP dialects in CTU

Author: martong Date: Thu Feb 28 07:24:59 2019 New Revision: 355096 URL: http://llvm.org/viewvc/llvm-project?rev=355096=rev Log: [CTU] Do not allow different CPP dialects in CTU Summary: If CPP dialects are different then return with error. Consider this STL code: template struct

[PATCH] D58724: [gnustep-objc] Make the GNUstep v2 ABI work for Windows DLLs.

theraven marked 2 inline comments as done. theraven added inline comments. Comment at: clang/lib/CodeGen/CGObjCGNU.cpp:188 + StringRef SymbolPrefix() { +return CGM.getTriple().isOSBinFormatCOFF() ? "_" : "._"; DHowett-MSFT wrote: > Should this be

[PATCH] D57914: [Driver] Allow enum SanitizerOrdinal to represent more than 64 different sanitizer checks, NFC.

riccibruno added inline comments. Comment at: include/clang/Basic/Sanitizers.h:29 +class hash_code; +} pgousseau wrote: > riccibruno wrote: > > What ? You are forward-declaring `hash_code` here and using it as a value a > > few lines later. Just include

[PATCH] D57914: [Driver] Allow enum SanitizerOrdinal to represent more than 64 different sanitizer checks, NFC.

pgousseau marked 2 inline comments as done. pgousseau added inline comments. Comment at: include/clang/Basic/Sanitizers.h:29 +class hash_code; +} riccibruno wrote: > pgousseau wrote: > > riccibruno wrote: > > > What ? You are forward-declaring `hash_code` here

[PATCH] D17741: adds __FILE_BASENAME__ builtin macro

kristina added a comment. If the author is still missing at the end of next week, any objections to me resubmitting a similar patch that just implements `__FILE_NAME__` or `__BASE_NAME__` (Need a few more opinions here I guess, personally I think `__FILE_NAME__` makes more sense)? I'll carve

[PATCH] D58666: [OpenCL] Undefine cl_intel_planar_yuv extension

Anastasia added inline comments. Comment at: test/SemaOpenCL/extension-begin.cl:26 + #ifndef IMPLICIT_INCLUDE #include "extension-begin.h" sidorovd wrote: > Anastasia wrote: > > sidorovd wrote: > > > Anastasia wrote: > > > > Can we also test that macro

[PATCH] D58768: Moved SymbolLocation into its own header and implementation file

This revision was automatically updated to reflect the committed changes. Closed by commit rL355082: Moved SymbolLocation into its own header and implementation file (authored by gribozavr, committed by ). Herald added subscribers: llvm-commits, ilya-biryukov. Herald added a project: LLVM.

[PATCH] D58773: Moved SymbolOrigin into its own header and implementation file

gribozavr created this revision. gribozavr added a reviewer: ioeric. Herald added subscribers: cfe-commits, jdoerfert, kadircet, arphaman, jkorous, mgorny. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D58773 Files:

  1   2   >