This revision was automatically updated to reflect the committed changes.
Closed by commit rL355266: [clang-format] clang-format off/on not respected
when using C Style comments (authored by paulhoad, committed by ).
Herald added a project: LLVM.
Changed prior to commit:
Author: paulhoad
Date: Sat Mar 2 01:08:51 2019
New Revision: 355266
URL: http://llvm.org/viewvc/llvm-project?rev=355266=rev
Log:
[clang-format] clang-format off/on not respected when using C Style comments
Summary:
If the clang-format on/off is in a /* comment */ then the sorting of headers is
MyDeveloperDay accepted this revision.
MyDeveloperDay added a comment.
Thank you for helping to address one of the many clang-format issues from
bugzilla, I'm not the code owner here but this looks good to me. If we want to
address the many issues we need to be able to move forwards.
CHANGES
lewmpk updated this revision to Diff 189055.
lewmpk added a comment.
added support for boost lockable types
Repository:
rCTE Clang Tools Extra
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D58818/new/
https://reviews.llvm.org/D58818
Files:
lewmpk marked 7 inline comments as done.
lewmpk added inline comments.
Comment at: test/clang-tidy/cppcoreguidelines-use-raii-locks.cpp:4
+// Mock implementation of std::mutex
+namespace std {
+struct mutex {
JonasToth wrote:
> Please add more tests
>
> What
Author: jyknight
Date: Sat Mar 2 12:22:48 2019
New Revision: 355278
URL: http://llvm.org/viewvc/llvm-project?rev=355278=rev
Log:
Make the new SanitizerMask code added in r355190 constexpr.
Then, as a consequence, remove the complex set of workarounds for
initialization order -- which are
joerg added a comment.
Can you include a patch for something like (int *)0xdeadbeef on amd64?
That's a valid value for "n", but clearly too large for int. Thanks for looking
at this, it is one of the two large remaining show stoppers for the asm
constraint check.
CHANGES SINCE LAST
to-miz updated this revision to Diff 189048.
to-miz added a comment.
Added an entry to ReleaseNotes.rst about the new option.
This diff doesn't contain unrelated formatting changes due to running
clang-format on some source files that apparently weren't formatted before.
CHANGES SINCE LAST
lewmpk updated this revision to Diff 189054.
lewmpk added a comment.
refactor and improved tests
Repository:
rCTE Clang Tools Extra
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D58818/new/
https://reviews.llvm.org/D58818
Files:
clang-tidy/cppcoreguidelines/CMakeLists.txt
JonasToth added inline comments.
Comment at: test/clang-tidy/cppcoreguidelines-use-raii-locks.cpp:4
+// Mock implementation of std::mutex
+namespace std {
+struct mutex {
lewmpk wrote:
> JonasToth wrote:
> > Please add more tests
> >
> > What happens for this?
Author: jyknight
Date: Sat Mar 2 13:55:36 2019
New Revision: 355280
URL: http://llvm.org/viewvc/llvm-project?rev=355280=rev
Log:
Tweak r355278 for compatibility with gcc 6 and earlier.
Modified:
cfe/trunk/lib/Basic/Sanitizers.cpp
Modified: cfe/trunk/lib/Basic/Sanitizers.cpp
URL:
nridge updated this revision to Diff 189065.
nridge added a comment.
Rebased.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D56370/new/
https://reviews.llvm.org/D56370
Files:
clang-tools-extra/clangd/ClangdLSPServer.cpp
Eugene.Zelenko added inline comments.
Comment at: clang-tidy/cppcoreguidelines/UseRaiiLocksCheck.cpp:29
+
+DeclRefExpr *findDeclRefExpr(const CXXMemberCallExpr *MemberCallExpr) {
+ auto *ObjectExpr = MemberCallExpr->getImplicitObjectArgument();
Please use
jyknight added a comment.
The intricate initialization-order workarounds apparently don't work in all
build modes, so I've updated this code to have constexpr functions and
initializations in r355278.
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D57914/new/
JonasToth added inline comments.
Comment at: test/clang-tidy/cppcoreguidelines-use-raii-locks.cpp:90
+ for (auto i = 0; i < 3; i++) {
+m.lock();
+// CHECK-MESSAGES: :[[@LINE-1]]:5: warning: use RAII
I got another one that I think defeats the analysis:
Author: jyknight
Date: Sat Mar 2 13:20:30 2019
New Revision: 355279
URL: http://llvm.org/viewvc/llvm-project?rev=355279=rev
Log:
Tweak r355278 for compatibility with gcc 6 and earlier.
Modified:
cfe/trunk/lib/Basic/Sanitizers.cpp
Modified: cfe/trunk/lib/Basic/Sanitizers.cpp
URL:
xbolva00 created this revision.
xbolva00 added reviewers: RKSimon, aaron.ballman.
Herald added subscribers: cfe-commits, jdoerfert.
Herald added a project: clang.
Follow up for (abandoned) patch https://reviews.llvm.org/D45401
Fixes https://bugs.llvm.org/show_bug.cgi?id=34180
Repository:
rC
nridge created this revision.
nridge added reviewers: sammccall, kadircet.
Herald added subscribers: cfe-commits, jdoerfert, arphaman, mgrang, jkorous,
MaskRay, ioeric, ilya-biryukov.
Herald added a project: clang.
This is an early draft of an implementation of type hierarchy subtypes.
There is
xbolva00 updated this revision to Diff 189072.
xbolva00 added a comment.
Removed extra new line, changed test
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D58882/new/
https://reviews.llvm.org/D58882
Files:
include/clang/Basic/DiagnosticGroups.td
xbolva00 updated this revision to Diff 189073.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D58882/new/
https://reviews.llvm.org/D58882
Files:
include/clang/Basic/DiagnosticGroups.td
include/clang/Basic/DiagnosticSemaKinds.td
lib/Sema/SemaExpr.cpp
xbolva00 created this revision.
xbolva00 added a reviewer: rsmith.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
"Taking the address of a standard library function is not allowed" -
https://usingstdcpp.org/2018/03/18/jacksonville18-iso-cpp-report/
Repository:
rC
21 matches
Mail list logo
