[PATCH] D59010: [DebugInfo] Add test cases for FlagNonTrivial

This revision was automatically updated to reflect the committed changes. Closed by commit rC355890: [DebugInfo] Add test cases for FlagNonTrivial (authored by asmith, committed by ). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rC Clang CHANGES SINCE

Buildbot numbers for the week of 02/17/2019 - 02/23/2019

Hello everyone, Below are some buildbot numbers for the week of 02/17/2019 - 02/23/2019. Please see the same data in attached csv files: The longest time each builder was red during the week; "Status change ratio" by active builder (percent of builds that changed the builder status from greed

Buildbot numbers for the week of 02/24/2019 - 03/02/2019

Hello everyone, Below are some buildbot numbers for the week of 02/24/2019 - 03/02/2019. Please see the same data in attached csv files: The longest time each builder was red during the week; "Status change ratio" by active builder (percent of builds that changed the builder status from greed

Buildbot numbers for the week of 03/03/2019 - 03/09/2019

Hello everyone, Below are some buildbot numbers for the last week of 03/03/2019 - 03/09/2019. Please see the same data in attached csv files: The longest time each builder was red during the week; "Status change ratio" by active builder (percent of builds that changed the builder status from

r355891 - [Driver] Support object files in addition to static and shared libraries in compiler-rt

Author: phosek Date: Mon Mar 11 19:12:48 2019 New Revision: 355891 URL: http://llvm.org/viewvc/llvm-project?rev=355891=rev Log: [Driver] Support object files in addition to static and shared libraries in compiler-rt This change introduces support for object files in addition to static and

r355890 - [DebugInfo] Add test cases for FlagNonTrivial

Author: asmith Date: Mon Mar 11 19:00:39 2019 New Revision: 355890 URL: http://llvm.org/viewvc/llvm-project?rev=355890=rev Log: [DebugInfo] Add test cases for FlagNonTrivial Summary: This is a test case to go with D44406 which added FlagNonTrivial to mark that a C++ record is non-trivial to

[PATCH] D56044: [Driver] Support object files in addition to static and shared libraries in compiler-rt

This revision was automatically updated to reflect the committed changes. Closed by commit rL355891: [Driver] Support object files in addition to static and shared libraries in… (authored by phosek, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed

[PATCH] D59176: Modules: Add LangOptions::CacheGeneratedPCH

dexonsmith updated this revision to Diff 190203. dexonsmith added a comment. Updated the constructor call to `PCHGenerator` in `GenerateModuleAction::CreateASTConsumer` to use `BuildingImplicitModule` on its own. Checking where it's set (only in `compileModuleImpl`), it's exactly the

[PATCH] D59176: Modules: Add LangOptions::CacheGeneratedPCH

dexonsmith marked 2 inline comments as done. dexonsmith added inline comments. Comment at: clang/lib/Frontend/FrontendActions.cpp:182 + CI.getFrontendOpts().BuildingImplicitModule && + CI.getLangOpts().isCompilingModule()));

[PATCH] D56990: Bugfix for Replacement of tied operand of inline asm

xiangzhangllvm added a comment. Hi, efriedma could you help he commit this patch? Thank you very much! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56990/new/ https://reviews.llvm.org/D56990 ___ cfe-commits mailing

[PATCH] D59087: [clang-format] [PR25010] AllowShortIfStatementsOnASingleLine not working if an "else" statement is present

MyDeveloperDay updated this revision to Diff 190049. MyDeveloperDay added a comment. Address review comments - collapse two options into one CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59087/new/ https://reviews.llvm.org/D59087 Files: clang/docs/ClangFormatStyleOptions.rst

[PATCH] D59087: [clang-format] [PR25010] AllowShortIfStatementsOnASingleLine not working if an "else" statement is present

reuk added a comment. This looks much better now, thanks for taking another look! I've flagged some formatting/spelling nits, and I think the tests/docs could be a little more explicit about the behaviour of `WithoutElse`. Other than that, looks great! Comment at:

[PATCH] D59087: [clang-format] [PR25010] AllowShortIfStatementsOnASingleLine not working if an "else" statement is present

MyDeveloperDay updated this revision to Diff 190053. MyDeveloperDay marked 8 inline comments as done. MyDeveloperDay added a comment. Address review comment - add document and comment spelling and punctuation - add additional unit tests to show non compound else clause case CHANGES SINCE LAST

r355819 - Remove an unnecessary -f when cp'ing to a file that was just deleted. NFC.

Author: d0k Date: Mon Mar 11 03:44:10 2019 New Revision: 355819 URL: http://llvm.org/viewvc/llvm-project?rev=355819=rev Log: Remove an unnecessary -f when cp'ing to a file that was just deleted. NFC. Modified: cfe/trunk/test/Modules/relative-import-path.c Modified:

[PATCH] D59205: [clangd] Respect Origin option in createStaticIndexingAction

kadircet created this revision. kadircet added a reviewer: ioeric. Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Currently createStaticIndexingAction always set Origin to Static, which makes it hard to change it later on by

[PATCH] D59205: [clangd] Respect Origin option in createStaticIndexingAction

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE355820: [clangd] Respect Origin option in createStaticIndexingAction (authored by kadircet, committed by ). Changed prior to commit: https://reviews.llvm.org/D59205?vs=190062=190066#toc Repository:

[PATCH] D59132: [clangd] Add TOC section to clangd doc.

This revision was automatically updated to reflect the committed changes. Closed by commit rL355811: [clangd] Add TOC section to clangd doc. (authored by hokein, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINCE LAST

[PATCH] D58977: [clang-tidy] Add the abseil-time-comparison check

ioeric accepted this revision. ioeric added inline comments. This revision is now accepted and ready to land. Comment at: clang-tidy/abseil/TimeComparisonCheck.cpp:23 + auto Matcher = + binaryOperator(anyOf(hasOperatorName(">"), hasOperatorName(">="), +

[clang-tools-extra] r355811 - [clangd] Add TOC section to clangd doc.

Author: hokein Date: Mon Mar 11 01:45:56 2019 New Revision: 355811 URL: http://llvm.org/viewvc/llvm-project?rev=355811=rev Log: [clangd] Add TOC section to clangd doc. Reviewers: gribozavr Subscribers: ilya-biryukov, ioeric, MaskRay, jkorous, arphaman, kadircet, cfe-commits Tags: #clang

[PATCH] D55358: [ASTImporter] Fix import of NestedNameSpecifierLoc.

balazske updated this revision to Diff 190056. balazske added a comment. Rebase. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55358/new/ https://reviews.llvm.org/D55358 Files: lib/AST/ASTImporter.cpp unittests/AST/ASTImporterTest.cpp Index:

[clang-tools-extra] r355820 - [clangd] Respect Origin option in createStaticIndexingAction

Author: kadircet Date: Mon Mar 11 04:01:14 2019 New Revision: 355820 URL: http://llvm.org/viewvc/llvm-project?rev=355820=rev Log: [clangd] Respect Origin option in createStaticIndexingAction Summary: Currently createStaticIndexingAction always set Origin to Static, which makes it hard to change

[PATCH] D58897: [ASTImporter] Make ODR error handling configurable

a_sidorin added a comment. Hi Gabor, This patch LGTM mostly, but there is a comment inline. Comment at: include/clang/AST/ASTStructuralEquivalence.h:81 EqKind(EqKind), StrictTypeSpelling(StrictTypeSpelling), -ErrorOnTagTypeMismatch(ErrorOnTagTypeMismatch),

r355816 - [Serialization] Add missing include

Author: d0k Date: Mon Mar 11 03:30:51 2019 New Revision: 355816 URL: http://llvm.org/viewvc/llvm-project?rev=355816=rev Log: [Serialization] Add missing include forward decl is not sufficient for destroying a unique_ptr. Modified: cfe/trunk/include/clang/Serialization/InMemoryModuleCache.h

[PATCH] D58977: [clang-tidy] Add the abseil-time-comparison check

hwright updated this revision to Diff 190075. hwright marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58977/new/ https://reviews.llvm.org/D58977 Files: clang-tidy/abseil/AbseilTidyModule.cpp clang-tidy/abseil/CMakeLists.txt

[PATCH] D59210: clang-format: distinguish ObjC call subexpressions after r355434

krasimir created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The revision r355434 had the unfortunate side-effect that it started to recognize certain ObjC expressions with a call subexpression followed by a `a->b` subexpression as C++ lambda expressions.

[PATCH] D58065: [analyzer] Document the frontend library

Szelethus added a reviewer: aaron.ballman. Szelethus added a comment. Oops. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58065/new/ https://reviews.llvm.org/D58065 ___ cfe-commits mailing list

[PATCH] D58841: [Diagnostics] Support -Wtype-limits for GCC compatibility

xbolva00 added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58841/new/ https://reviews.llvm.org/D58841 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D56160: [clang-tidy] modernize-use-trailing-return-type check

aaron.ballman added inline comments. Comment at: clang-tidy/modernize/UseTrailingReturnTypeCheck.cpp:180-184 + if (Info.hasMacroDefinition()) { +// The CV qualifiers of the return type are inside macros. +diag(F.getLocation(), Message); +return {}; +

[PATCH] D59083: [clangd] Store explicit template specializations in index for code navigation purposes

nridge added a comment. Is any representation of the template arguments stored in the index? Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59083/new/ https://reviews.llvm.org/D59083 ___ cfe-commits

[PATCH] D59054: [analyzer] C++17: PR40022: Support aggregate initialization with compound values in presence of base classes.

Szelethus accepted this revision. Szelethus added a comment. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59054/new/ https://reviews.llvm.org/D59054 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D59083: [clangd] Store explicit template specializations in index for code navigation purposes

kadircet added a comment. In D59083#1424509 , @nridge wrote: > Is any representation of the template arguments stored in the index? No we only have, class name if you want to do a "name based" search/lookup. But symbol IDs for template specializations

[PATCH] D59210: clang-format: distinguish ObjC call subexpressions after r355434

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59210/new/ https://reviews.llvm.org/D59210

[PATCH] D59083: [clangd] Store explicit template specializations in index for code navigation purposes

nridge added a comment. One of the use cases I imagined for this (unrelated to D58880 ) is that if the user searches for `vector` (using `workspace/symbols`), they get a separate search result for the `vector` primary template, and a separate one for `vector`.

[PATCH] D57855: [analyzer] Reimplement checker options

baloghadamsoftware requested changes to this revision. baloghadamsoftware added inline comments. This revision now requires changes to proceed. Comment at: include/clang/StaticAnalyzer/Checkers/CheckerBase.td:49 + string PackageName = name; + list PackageOptions;

[PATCH] D59105: [RFC] Create an Arbitrary Precision Integer Type.

ebevhan added inline comments. Comment at: lib/AST/ASTContext.cpp:1687-1693 + // toCharUnitsFromBits always rounds down, which isn't a problem when the size + // Width is a multiple of chars, however ArbPrecInt makes this not a valid + // assumption. + return

[PATCH] D59197: [NFC][clang][PCH][ObjC] Add some missing `VisitStmt(S); `

aprantl added a comment. How can this change be NFC? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59197/new/ https://reviews.llvm.org/D59197 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D59210: clang-format: distinguish ObjC call subexpressions after r355434

This revision was automatically updated to reflect the committed changes. Closed by commit rL355831: clang-format: distinguish ObjC call subexpressions after r355434 (authored by krasimir, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL

[PATCH] D59210: clang-format: distinguish ObjC call subexpressions after r355434

MyDeveloperDay added a comment. most of the cases that we were adding here were for a templated return types e.g. verifyFormat("[]() -> foo<5 + 2> { return {}; };"); verifyFormat("[]() -> foo<5 - 2> { return {}; };"); So we should probably have handle that "-> (return type)", where the

[PATCH] D59214: [private][clang][OpeMP] Model OpenMP structured-block in AST (PR40563)

lebedev.ri created this revision. lebedev.ri added reviewers: ABataev, rjmccall, hfinkel, rsmith, riccibruno, gribozavr. lebedev.ri added projects: clang, OpenMP. Herald added subscribers: jdoerfert, jfb, guansong. https://www.openmp.org/wp-content/uploads/OpenMP-API-Specification-5.0.pdf, page

[PATCH] D59197: [NFC][clang][PCH][ObjC] Add some missing `VisitStmt(S); `

lebedev.ri added a comment. In D59197#1424644 , @aprantl wrote: > How can this change be NFC? `VisitStmt()` is empty currently, there is currently no data serialized by the `Stmt` itself. D59214 changes that.

[PATCH] D58977: [clang-tidy] Add the abseil-time-comparison check

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE355835: [clang-tidy] Add the abseil-time-compare check (authored by hwright, committed by ). Changed prior to commit: https://reviews.llvm.org/D58977?vs=190075=190113#toc Repository: rCTE Clang

r355831 - clang-format: distinguish ObjC call subexpressions after r355434

Author: krasimir Date: Mon Mar 11 09:02:52 2019 New Revision: 355831 URL: http://llvm.org/viewvc/llvm-project?rev=355831=rev Log: clang-format: distinguish ObjC call subexpressions after r355434 Summary: The revision r355434 had the unfortunate side-effect that it started to recognize certain

[PATCH] D59219: [PR41007][OpenCL] Allow printf and toolchain reserved variadic functions in C++

Anastasia created this revision. Anastasia added a reviewer: neil.hickey. Herald added subscribers: ebevhan, yaxunl. As for OpenCL C, we will allow `printf` and other variadic functions (prefixed by "__") in C++ mode. https://reviews.llvm.org/D59219 Files: lib/Sema/SemaType.cpp

[PATCH] D59214: [clang][OpeMP] Model OpenMP structured-block in AST (PR40563)

ABataev added inline comments. Comment at: include/clang/AST/StmtOpenMP.h:335 + llvm::Optional getStructuredBlockImpl() const { +return const_cast(getInnermostCapturedStmt()->getCapturedStmt()); No need to insert it into each class, just add: ``` Stmt *

[PATCH] D31739: Add markup for libc++ dylib availability

ldionne added inline comments. Comment at: libcxx/trunk/test/std/thread/thread.mutex/thread.lock/thread.lock.shared/lit.local.cfg:1 +if 'availability' in config.available_features: +config.unsupported = True mehdi_amini wrote: > thakis wrote: > > Did you

[clang-tools-extra] r355835 - [clang-tidy] Add the abseil-time-compare check

Author: hwright Date: Mon Mar 11 09:47:45 2019 New Revision: 355835 URL: http://llvm.org/viewvc/llvm-project?rev=355835=rev Log: [clang-tidy] Add the abseil-time-compare check This is an analog of the abseil-duration-comparison check, but for the absl::Time domain. It has a similar

[PATCH] D31739: Add markup for libc++ dylib availability

thakis added inline comments. Herald added subscribers: llvm-commits, jdoerfert, jfb, christof. Herald added a reviewer: serge-sans-paille. Herald added a project: LLVM. Comment at: libcxx/trunk/test/std/thread/thread.mutex/thread.lock/thread.lock.shared/lit.local.cfg:1 +if

[PATCH] D31739: Add markup for libc++ dylib availability

mehdi_amini marked an inline comment as done. mehdi_amini added subscribers: ldionne, Bigcheese. mehdi_amini added inline comments. Comment at: libcxx/trunk/test/std/thread/thread.mutex/thread.lock/thread.lock.shared/lit.local.cfg:1 +if 'availability' in

[PATCH] D59118: creduce script for clang crashes

akhuang updated this revision to Diff 190189. akhuang added a comment. add interestingness test sanity check; revive ctrl-c hack CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59118/new/ https://reviews.llvm.org/D59118 Files: clang/utils/creduce-clang-crash.py Index:

[PATCH] D59223: Objective-C++11: Support static_assert() in @interface/@implementation ivar lists and method declarations

thakis marked an inline comment as done. thakis added inline comments. Comment at: clang/test/Parser/objc-static-assert.mm:1 +// RUN: %clang_cc1 -fsyntax-only -verify -Wno-objc-root-class %s + aaron.ballman wrote: > erik.pilkington wrote: > > thakis wrote: > > >

[PATCH] D59118: creduce script for clang crashes

thakis added a comment. (A few python style comments; feel free to ignore, and feel free to land no matter what you do with the comments.) Comment at: clang/utils/creduce-clang-crash.py:1 +#!/usr/bin/env python +# A tool that calls C-Reduce to create a minimal reproducer for

[PATCH] D48866: [clang-tidy] Add incorrect-pointer-cast checker

alexfh requested changes to this revision. alexfh added a comment. This revision now requires changes to proceed. As per the very first comment, "bugprone" will be a more suitable category for this check. The rename_check.py script should be able to help here. Repository: rCTE Clang Tools

[PATCH] D59223: Objective-C++11: Support static_assert() in @interface/@implementation ivar lists and method declarations

thakis created this revision. thakis added a reviewer: erik.pilkington. This adds support for static_assert() (and _Static_assert()) in @interface/@implementation ivar lists and in @interface method declarations. It was already supported in @implementation blocks outside of the ivar lists. The

[PATCH] D58317: [clang] Add install targets for API headers

This revision was automatically updated to reflect the committed changes. Closed by commit rL355853: [clang] Add install targets for API headers (authored by smeenai, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D59168: [runtimes] Move libunwind, libc++abi and libc++ to lib/clang/ and include/

smeenai accepted this revision. smeenai added a comment. This revision is now accepted and ready to land. LGTM, though you may wanna wait for @jdenny too. In D59168#1423587 , @phosek wrote: > The layout currently looks as follows: > > compiler-rt: >

[PATCH] D59176: Modules: Add LangOptions::CacheGeneratedPCH

jordan_rose added a comment. This commit by itself doesn't change any behavior, right? Comment at: clang/lib/Frontend/FrontendActions.cpp:115 CI.getPreprocessorOpts().AllowPCHWithCompilerErrors, - FrontendOpts.IncludeTimestamps)); +

[PATCH] D45978: dllexport const variables must have external linkage.

zahiraam updated this revision to Diff 190124. zahiraam marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D45978/new/ https://reviews.llvm.org/D45978 Files: lib/Sema/SemaDecl.cpp test/CodeGen/dllexport-1.c test/Sema/dllexport-1.cpp

[PATCH] D59219: [PR41007][OpenCL] Allow printf and toolchain reserved variadic functions in C++

neil.hickey accepted this revision. neil.hickey added a comment. This revision is now accepted and ready to land. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59219/new/ https://reviews.llvm.org/D59219 ___ cfe-commits mailing list

[PATCH] D59197: [NFC][clang][PCH][ObjC] Add some missing `VisitStmt(S); `

jordan_rose accepted this revision. jordan_rose added a comment. This revision is now accepted and ready to land. I'm no Clang serialization expert but this makes sense to me. It's consistent with all the other statement visitor methods. Repository: rC Clang CHANGES SINCE LAST ACTION

[PATCH] D59197: [NFC][clang][PCH][ObjC] Add some missing `VisitStmt(S); `

lebedev.ri added a comment. In D59197#1424832 , @jordan_rose wrote: > I'm no Clang serialization expert but this makes sense to me. It's consistent > with all the other statement visitor methods. Thank you. Repository: rC Clang CHANGES SINCE LAST

[PATCH] D48866: [clang-tidy] Add incorrect-pointer-cast checker

alexfh added a comment. And one more comment that hasn't yet been addressed: "Some patterns are covered by compiler diagnostics: https://godbolt.org/g/HvsjnP. Is there any benefit in re-implementing them?" And one more: please update file headers. The license has changed since. Repository:

[PATCH] D45978: dllexport const variables must have external linkage.

zahiraam marked 6 inline comments as done. zahiraam added inline comments. Comment at: test/SemaCXX/dllexport.cpp:72-74 +#ifndef MS namespace{ __declspec(dllexport) int InternalGlobal; } // expected-error{{'(anonymous namespace)::InternalGlobal' must have external linkage

[PATCH] D59118: creduce script for clang crashes

akhuang updated this revision to Diff 190126. akhuang marked 15 inline comments as done. akhuang added a comment. Addressed readability comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59118/new/ https://reviews.llvm.org/D59118 Files: clang/utils/creduce-clang-crash.py

[PATCH] D59118: creduce script for clang crashes

lebedev.ri added a comment. The new diffs should not be relative to the previously uploaded diff, but to the git master/svn trunk. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59118/new/ https://reviews.llvm.org/D59118 ___ cfe-commits

[PATCH] D59118: creduce script for clang crashes

akhuang added inline comments. Comment at: clang/utils/creduce-clang-crash.py:43 + # Get crash output + p = subprocess.Popen(build_script, + stdout=subprocess.PIPE, george.burgess.iv wrote: > nit: can replace with

[PATCH] D59221: [asan] Add gcc 8's driver option -fsanitize=pointer-compare and -fsanitize=pointer-substract.

pgousseau created this revision. pgousseau added reviewers: rsmith, filcab, wristow, gbedwell, kcc, riccibruno, probinson. Herald added subscribers: cfe-commits, jdoerfert, emaste. Herald added a project: clang. Disabled by default as this is still an experimental feature. This is the clang side

r355853 - [clang] Add install targets for API headers

Author: smeenai Date: Mon Mar 11 11:53:57 2019 New Revision: 355853 URL: http://llvm.org/viewvc/llvm-project?rev=355853=rev Log: [clang] Add install targets for API headers Add an install target for clang's API headers, which allows them to be included in distributions. The install rules already

[PATCH] D59223: Objective-C++11: Support static_assert() in @interface/@implementation ivar lists and method declarations

thakis added a comment. (Since jfb added a few people who might not have seen it: This was discussed in "Objective-C++11: concerns about adding static_assert support to @interface / @implementation?" on cfe-dev) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59223/new/

Re: r355182 - [clang-format] [NFC] clang-format the Format library

Am Sa., 9. März 2019 um 13:54 Uhr schrieb MyDeveloper Day : > > Yes ideally I'd agree, It also says: > > > Avoid committing formatting- or whitespace-only changes outside of code you > > plan to make subsequent changes to. > > This was getting to be a problem, every time we edited the file (with

[PATCH] D59223: Objective-C++11: Support static_assert() in @interface/@implementation ivar lists and method declarations

aaron.ballman added inline comments. Comment at: clang/test/Parser/objc-static-assert.mm:1 +// RUN: %clang_cc1 -fsyntax-only -verify -Wno-objc-root-class %s + thakis wrote: > aaron.ballman wrote: > > Can you try explicitly specifying C++98 as the underlying

[PATCH] D59087: [clang-format] [PR25010] AllowShortIfStatementsOnASingleLine not working if an "else" statement is present

reuk added a comment. The code looks good now. There's just a few places left where the formatting looks a bit suspect (sorry for missing those last time). I think once that's fixed this will be good to go. Comment at: clang/unittests/Format/FormatTest.cpp:553 -

[PATCH] D59176: Modules: Add LangOptions::CacheGeneratedPCH

dexonsmith marked 2 inline comments as done. dexonsmith added a comment. In D59176#1424864 , @jordan_rose wrote: > This commit by itself doesn't change any behavior, right? Correct, it just exposes an option. Comment at:

r355858 - [OPENMP]Fix codegen for declare target link in target regions.

Author: abataev Date: Mon Mar 11 12:51:42 2019 New Revision: 355858 URL: http://llvm.org/viewvc/llvm-project?rev=355858=rev Log: [OPENMP]Fix codegen for declare target link in target regions. If the declare target link global is used in the target region indirectly (used in the inner parallel,

[PATCH] D58659: [Sema] Fix assertion when `auto` parameter in lambda has an attribute.

vsapsai added inline comments. Comment at: clang/lib/Sema/SemaType.cpp:261 +/// necessary. +QualType ReplaceAutoType(QualType TypeWithAuto, QualType Replacement) { + QualType T = sema.ReplaceAutoType(TypeWithAuto, Replacement); aaron.ballman wrote:

[PATCH] D59048: Add AIX Target Info

andusy updated this revision to Diff 190133. andusy added a comment. - Fixed comment. - Checked that `_LP64`, `__LP64__`, and `__64BIT__` aren't defined in 32 bit mode. - Checked that `_ILP32` and `__ILP32__` aren't defined in 64 bit mode. CHANGES SINCE LAST ACTION

[PATCH] D59223: Objective-C++11: Support static_assert() in @interface/@implementation ivar lists and method declarations

thakis marked 2 inline comments as done. thakis added inline comments. Comment at: clang/lib/Parse/ParseDecl.cpp:3892-3893 /// +/// Note that a struct declaration refers to a declaration in a struct, +/// not to the declaration of a struct. +/// aaron.ballman

[PATCH] D59223: Objective-C++11: Support static_assert() in @interface/@implementation ivar lists and method declarations

aaron.ballman added inline comments. Comment at: clang/lib/Parse/ParseDecl.cpp:3892-3893 /// +/// Note that a struct declaration refers to a declaration in a struct, +/// not to the declaration of a struct. +/// Seems to be unrelated to this patch? Feel free to

r355862 - Remove esan.

Author: nico Date: Mon Mar 11 13:23:40 2019 New Revision: 355862 URL: http://llvm.org/viewvc/llvm-project?rev=355862=rev Log: Remove esan. It hasn't seen active development in years, and it hasn't reached a state where it was useful. Remove the code until someone is interested in working on it

[PATCH] D59133: Remove esan.

This revision was automatically updated to reflect the committed changes. Closed by commit rC355862: Remove esan. (authored by nico, committed by ). Herald added a project: clang. Herald added a subscriber: cfe-commits. Changed prior to commit:

[PATCH] D59118: creduce script for clang crashes

joerg added a comment. For it to be really useful for the majority of bugs, it would be nice to figure out automatically how to get the preprocessing step done and filter out the # lines afterwards. That part alone significantly cuts down the creduce time. CHANGES SINCE LAST ACTION

[PATCH] D57978: [CodeGen] Generate follow-up metadata for loops with more than one transformation.

Meinersbur added a comment. ping The Polly-powered additional transformations now also generate this kind of metadata. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57978/new/ https://reviews.llvm.org/D57978

[PATCH] D59118: creduce script for clang crashes

rnk added a subscriber: gbiv. rnk added a comment. @gbiv already got all my shell quoting comments. I think we should do one more round of fixes, we can commit that for you, and then move on to the next steps. Comment at: clang/utils/creduce-clang-crash.py:109 +

[PATCH] D59233: libclang/CIndexer.cpp: Use loadquery() on AIX for path to library

hubert.reinterpretcast added a comment. I believe that the conditions being checked for with `llvm_unreachable` in this patch are of the debug-only variety; however, some input would be appreciated regarding the choice of using `llvm_unreachable` instead of `report_fatal_error` or `assert`.

[PATCH] D59223: Objective-C++11: Support static_assert() in @interface/@implementation ivar lists and method declarations

erik.pilkington added inline comments. Comment at: clang/test/Parser/objc-static-assert.mm:1 +// RUN: %clang_cc1 -fsyntax-only -verify -Wno-objc-root-class %s + thakis wrote: > aaron.ballman wrote: > > thakis wrote: > > > aaron.ballman wrote: > > > > Can you try

[PATCH] D59223: Objective-C++11: Support static_assert() in @interface/@implementation ivar lists and method declarations

aaron.ballman added reviewers: rsmith, aaron.ballman. aaron.ballman added inline comments. Comment at: clang/test/Parser/objc-static-assert.mm:1 +// RUN: %clang_cc1 -fsyntax-only -verify -Wno-objc-root-class %s + erik.pilkington wrote: > thakis wrote: > >

[PATCH] D59118: creduce script for clang crashes

george.burgess.iv added a comment. > I think we should do one more round of fixes, we can commit that for you, and > then move on to the next steps +1. This looks good to me with outstanding nits fixed > and filter out the # lines afterwards. AIUI, the very-recently-merged

[PATCH] D59118: creduce script for clang crashes

rnk added inline comments. Comment at: clang/utils/creduce-clang-crash.py:1 +#!/usr/bin/env python +# A tool that calls C-Reduce to create a minimal reproducer for clang crashes george.burgess.iv wrote: > nit: please specify a python version here, since the

Re: r355858 - [OPENMP]Fix codegen for declare target link in target regions.

I don't think my fix did this, this test has nothing to do with OpenMP. Best regards, Alexey Bataev 11 марта 2019 г., в 17:56, Azhar Mohammed mailto:az...@apple.com>> написал(а): Hi Alexey Looks like this is failing on Darwin, can you please take a look? Refer to

Re: r355858 - [OPENMP]Fix codegen for declare target link in target regions.

I see that the next builds passed. Seems to me it wqs some kind of flacky fails. Best regards, Alexey Bataev 11 марта 2019 г., в 17:56, Azhar Mohammed mailto:az...@apple.com>> написал(а): Hi Alexey Looks like this is failing on Darwin, can you please take a look? Refer to

[PATCH] D59233: libclang/CIndexer.cpp: Use loadquery() on AIX for path to library

hubert.reinterpretcast created this revision. hubert.reinterpretcast added reviewers: sfertile, xingxue, jasonliu. Herald added a subscriber: arphaman. Herald added a project: clang. `dladdr` is not available on AIX. Similar functionality is presented through `loadquery`. This patch replaces a

[PATCH] D59234: [CodeGen][ObjC] Remove the leading 'l' from symbols for protocol metadata and protocol list

ahatanak created this revision. ahatanak added a reviewer: rjmccall. ahatanak added a project: clang. Herald added subscribers: dexonsmith, jkorous. The leading 'l' tells ld64 to remove the symbol name, which can make debugging difficult. rdar://problem/47256637 Repository: rC Clang

[PATCH] D59223: Objective-C++11: Support static_assert() in @interface/@implementation ivar lists and method declarations

thakis updated this revision to Diff 190172. thakis marked an inline comment as done. thakis added a comment. test c++98 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59223/new/ https://reviews.llvm.org/D59223 Files: clang/include/clang/Basic/Features.def

[PATCH] D59223: Objective-C++11: Support static_assert() in @interface/@implementation ivar lists and method declarations

thakis added inline comments. Comment at: clang/test/Parser/objc-static-assert.mm:1 +// RUN: %clang_cc1 -fsyntax-only -verify -Wno-objc-root-class %s + aaron.ballman wrote: > thakis wrote: > > aaron.ballman wrote: > > > Can you try explicitly specifying C++98 as

Re: r355858 - [OPENMP]Fix codegen for declare target link in target regions.

Hi Alexey Looks like this is failing on Darwin, can you please take a look? Refer to http://green.lab.llvm.org/green/job/clang-stage1-cmake-RA-incremental/58951/consoleFull . TEST

[PATCH] D59118: creduce script for clang crashes

akhuang updated this revision to Diff 190164. akhuang added a comment. fixed diff with style edits CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59118/new/ https://reviews.llvm.org/D59118 Files: .arcconfig clang/utils/creduce-clang-crash.py Index:

[PATCH] D59048: Add AIX Target Info

hubert.reinterpretcast accepted this revision. hubert.reinterpretcast added a subscriber: WuZhao. hubert.reinterpretcast added a comment. This revision is now accepted and ready to land. I think all comments have been addressed or otherwise responded to. @jasonliu: Since this patch is dependent

[PATCH] D59234: [CodeGen][ObjC] Remove the leading 'l' from symbols for protocol metadata and protocol list

ahatanak added a comment. There are other symbols that starts with 'l' and have private linkage. I haven't made any changes to those symbols in this patch, but I think it's possible to remove the leading 'l' from those symbols and change the linkage to internal if we want to keep the symbol