r358353 - [c++20] Parsing support for module-declarations, import-declarations,

Author: rsmith Date: Sun Apr 14 01:06:59 2019 New Revision: 358353 URL: http://llvm.org/viewvc/llvm-project?rev=358353&view=rev Log: [c++20] Parsing support for module-declarations, import-declarations, and the global and private module fragment. For now, the private module fragment introducer is

[PATCH] D43763: libclang: Visit class template instantiations

milianw added a comment. Herald added a subscriber: arphaman. Herald added a project: clang. looks good, but this needs a test, could you add one please? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D43763/new/ https://reviews.llvm.org/D43763 _

r358355 - [c++20] Enable driver and frontend support for building and using

Author: rsmith Date: Sun Apr 14 04:11:37 2019 New Revision: 358355 URL: http://llvm.org/viewvc/llvm-project?rev=358355&view=rev Log: [c++20] Enable driver and frontend support for building and using modules when -std=c++2a is specified. Added: cfe/trunk/test/CXX/module/module.unit/p8.cpp

[PATCH] D60663: Time profiler: small fixes and optimizations

anton-afanasyev created this revision. anton-afanasyev added a reviewer: lebedev.ri. Herald added subscribers: llvm-commits, cfe-commits, mgrang, hiraditya. Herald added projects: clang, LLVM. Fixes from Roman's review here: https://reviews.llvm.org/D58675#1465336 Repository: rG LLVM Github Mo

[PATCH] D58675: [clang] Adds `-ftime-trace` option to clang that produces Chrome `chrome://tracing` compatible JSON profiling output dumps

anton-afanasyev marked 23 inline comments as done. anton-afanasyev added a comment. In D58675#1465336 , @lebedev.ri wrote: > Some post-commit review (please submit a new review, don't replace this diff) > As usual, the incorrect license headers keep slipp

[PATCH] D60663: Time profiler: small fixes and optimizations

lebedev.ri added a comment. Looks good ignoring the json bits. Re license: > https://reviews.llvm.org/D58675 > This is the first part of time tracing system, I have splitted them cause > this part is mostly written by Aras Pranckevicius except of several minor > fixes concerning formatting.

[PATCH] D58675: [clang] Adds `-ftime-trace` option to clang that produces Chrome `chrome://tracing` compatible JSON profiling output dumps

lebedev.ri added a comment. In D58675#1465706 , @anton-afanasyev wrote: > In D58675#1465336 , @lebedev.ri > wrote: > > > Some post-commit review (please submit a new review, don't replace this > > diff) > > As u

[PATCH] D60561: [clang] fixing diagnostics of constexpr callstack

Tyker updated this revision to Diff 195055. Tyker added a comment. i changed the way arguments are stored. to make it more controllable. added an argument call stack where it is needed. this version slows down compilation by around 0.5% in average over 200 run for SemaDecl -fsyntax-only CHANGES

[PATCH] D60561: [clang] fixing diagnostics of constexpr callstack

Tyker updated this revision to Diff 195056. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60561/new/ https://reviews.llvm.org/D60561 Files: clang/lib/AST/ExprConstant.cpp clang/test/SemaCXX/constant-expression-cxx1y.cpp Index: clang/test/SemaCXX/constant-expression-cxx1y.cpp ===

[PATCH] D60363: [clang-format] [PR41170] Break after return type ignored with certain comments positions

MyDeveloperDay updated this revision to Diff 195057. MyDeveloperDay added a comment. use endsWith() as it ignored comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60363/new/ https://reviews.llvm.org/D60363 Files: clang/lib/Format/TokenAnnotator.h clang/unittests/Format/Format

[clang-tools-extra] r358356 - [clang-tidy] Add MagnitudeBitsUpperLimit option to bugprone-too-small-loop-variable

Author: ztamas Date: Sun Apr 14 05:47:48 2019 New Revision: 358356 URL: http://llvm.org/viewvc/llvm-project?rev=358356&view=rev Log: [clang-tidy] Add MagnitudeBitsUpperLimit option to bugprone-too-small-loop-variable Summary: The bugprone-too-small-loop-variable check often catches loop variabl

[PATCH] D59870: [clang-tidy] Add MagnitudeBitsUpperLimit option to bugprone-too-small-loop-variable

This revision was automatically updated to reflect the committed changes. Closed by commit rL358356: [clang-tidy] Add MagnitudeBitsUpperLimit option to bugprone-too-small-loop… (authored by ztamas, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed pri

[PATCH] D60570: [Sema] Add more tests for the behavior of argument-dependent name lookup

riccibruno marked 11 inline comments as done. riccibruno added a comment. In D60570#1465478 , @Quuxplusone wrote: > As you're making tests for ADL corner cases, you might also consider testing > the interactions between ADL and defaulted function paramete

[PATCH] D60570: [Sema] Add more tests for the behavior of argument-dependent name lookup

riccibruno updated this revision to Diff 195060. riccibruno marked 3 inline comments as done. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60570/new/ https://reviews.llvm.org/D60570 Files: test/CXX/basic/basic.lookup/basic.lookup.argdep/p2-associated-namespace

[PATCH] D60507: [clang-tidy] new check: bugprone-unhandled-self-assignment

ztamas updated this revision to Diff 195061. ztamas added a comment. Missed to syncronize ReleasNotes with the corresponding doc. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60507/new/ https://reviews.llvm.org/D60507 Files: clang-tools-extra/c

[PATCH] D60665: [Sema] ADL: Template arguments in a template-id naming a set of overloaded functions (part of CWG 997)

riccibruno created this revision. riccibruno added reviewers: Quuxplusone, rsmith, rjmccall. riccibruno added a project: clang. Herald added a subscriber: cfe-commits. riccibruno added a parent revision: D60573: [Sema] ADL: Associated namespaces for class types and enumeration types (CWG 1691). C

[PATCH] D60507: [clang-tidy] new check: bugprone-unhandled-self-assignment

xazax.hun added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/UnhandledSelfAssignmentCheck.cpp:51 + // Matcher for standard smart pointers. + const auto SmartPointerType = qualType(hasUnqualifiedDesugaredType( + recordType(hasDeclaration(classTemplate

[PATCH] D60573: [Sema] ADL: Associated namespaces for class types and enumeration types (CWG 1691)

riccibruno added a comment. In D60573#1463777 , @rjmccall wrote: > In D60573#1463641 , @riccibruno > wrote: > > > In D60573#1463569 , @rjmccall > > wrote: > > > > > Hmm. D

[PATCH] D60507: [clang-tidy] new check: bugprone-unhandled-self-assignment

ztamas marked an inline comment as done. ztamas added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/UnhandledSelfAssignmentCheck.cpp:51 + // Matcher for standard smart pointers. + const auto SmartPointerType = qualType(hasUnqualifiedDesugaredType( + r

[PATCH] D60507: [clang-tidy] new check: bugprone-unhandled-self-assignment

xazax.hun added inline comments. Comment at: clang-tools-extra/test/clang-tidy/bugprone-unhandled-self-assignment.cpp:326 + +// We should not catch move assignment operators. +class MoveAssignOperator { While I do agree move assignment operators should not be ch

[PATCH] D60663: Time profiler: small fixes and optimizations

anton-afanasyev updated this revision to Diff 195068. anton-afanasyev marked 2 inline comments as done. anton-afanasyev added a comment. Updated Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60663/new/ https://reviews.llvm.org/D60663 Files: clan

[PATCH] D60663: Time profiler: small fixes and optimizations

anton-afanasyev marked 7 inline comments as done. anton-afanasyev added a subscriber: aras-p. anton-afanasyev added a comment. In D60663#1465721 , @lebedev.ri wrote: > Looks good ignoring the json bits. > > Re license: > > > https://reviews.llvm.org/D58675

[PATCH] D60663: Time profiler: small fixes and optimizations

anton-afanasyev updated this revision to Diff 195069. anton-afanasyev added a comment. Updated Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60663/new/ https://reviews.llvm.org/D60663 Files: clang/tools/driver/cc1_main.cpp llvm/include/llvm/Su

[PATCH] D53076: [analyzer] ConditionBRVisitor: Enhance to write out more information

Charusso added a comment. Thanks you @NoQ for the great idea! Without the duplicated `BugReport.cpp` reports it could be an on-by-default patch, see: Before: F8685549: before.html After: F8685550: after.html It is not per

[PATCH] D60570: [Sema] Add more tests for the behavior of argument-dependent name lookup

riccibruno updated this revision to Diff 195076. riccibruno added a comment. Also test that typedef-names and using-declarations are not considered. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60570/new/ https://reviews.llvm.org/D60570 Files: test/CXX/basic

[PATCH] D60363: [clang-format] [PR41170] Break after return type ignored with certain comments positions

owenpan accepted this revision. owenpan added a comment. This revision is now accepted and ready to land. Looks good! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60363/new/ https://reviews.llvm.org/D60363 ___ cfe-commits mailing list cfe-

[PATCH] D60672: [libclang] visit c++14 lambda capture init expressions

milianw created this revision. milianw added reviewers: clang-c, cfe-commits, hokein, nik, yvvan, marcobubke. Herald added a subscriber: arphaman. Herald added a project: clang. Previously, libclang users could visit the non-init C++11 lambda captures, e.g. `[foo]`. But C++14 init-captures such as

[PATCH] D59639: [clangd] Print template arguments helper

thakis added inline comments. Comment at: clang-tools-extra/trunk/unittests/clangd/CMakeLists.txt:16 Annotations.cpp + PrintASTTests.cpp BackgroundIndexTests.cpp Keep alphabetized? Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D60570: [Sema] Add more tests for the behavior of argument-dependent name lookup

Quuxplusone added inline comments. Comment at: test/CXX/basic/basic.lookup/basic.lookup.argdep/p2-associated-namespaces-classes.cpp:304 +static_assert(f(g3) == 4, "");// FIXME: Also well-formed from the union rule. + // expec

[PATCH] D59673: [Driver] Allow setting the DWO name DWARF attribute separately

aaronpuchert planned changes to this revision. aaronpuchert added a comment. In D59673#1461983 , @dblaikie wrote: > Sure, I think the naming's a bit weird (but hard to come up with good names > for any of this) Agreed, `-split-dwarf-output` is pretty cl

[PATCH] D60674: [X86] Restore the pavg intrinsics.

craig.topper updated this revision to Diff 195090. craig.topper added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Add the clang changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60674/new/ https://reviews.l

[PATCH] D59744: Fix i386 ABI "__m64" type bug

wxiao3 updated this revision to Diff 195096. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59744/new/ https://reviews.llvm.org/D59744 Files: lib/CodeGen/TargetInfo.cpp test/CodeGen/vector.c test/CodeGen/x86_32-arguments-darwin.c test/CodeGen/x86_32-arguments-linux.c test/CodeGe