[PATCH] D60943: Delay diagnosing "n" constraint until after inlining

void added a comment. In D60943#1474091 , @joerg wrote: > I'm in the process of testing this, but feedback will take a bit. > > On the more meaty parts of this change, I think further iterations will be > necessary in-tree to extend this to the other

[PATCH] D60974: Clang IFSO driver action.

plotfi added a comment. In D60974#1474591 , @jakehehrlich wrote: > Can you elaborate on the use case for this? Like can you explain end to end > how this would be used? There are a few that I have in mind. 1. -emit-ifso could be added to a build to

[PATCH] D60349: [COFF, ARM64] Fix ABI implementation of struct returns

mgrang updated this revision to Diff 196144. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60349/new/ https://reviews.llvm.org/D60349 Files: include/clang/CodeGen/CGFunctionInfo.h lib/CodeGen/CGCall.cpp lib/CodeGen/MicrosoftCXXABI.cpp lib/Sema/SemaDeclCXX.cpp

[PATCH] D59673: [Driver] Allow setting the DWO name DWARF attribute separately

aaronpuchert updated this revision to Diff 196149. aaronpuchert added a comment. Introduce -split-dwarf-output instead to mirror the behavior of llc, which already allows to set the attribute separately from the output file name. Repository: rC Clang CHANGES SINCE LAST ACTION

[PATCH] D60899: [analyzer] Unbreak body farms in presence of multiple declarations.

NoQ added a comment. In D60899#1473412 , @a_sidorin wrote: > the correct solution is to synthesize a shining new function and include it > into the redeclaration chain. Mmm, what are the pros and cons? Repository: rC Clang CHANGES SINCE LAST

[PATCH] D60925: [analyzer] Don't display implementation checkers under -analyzer-checker-help, but do under the new flag -analyzer-checker-help-hidden

NoQ added a comment. Yup, that sounds useful! > I intentionally chose not to hide alpha checkers, because they have a scary > enough name, in my opinion, to cause no surprise when they emit false > positives or cause crashes. I've seen people yelling really loudly, like "look, your clang is

[PATCH] D60974: Clang IFSO driver action.

jakehehrlich added a comment. In D60974#1474751 , @plotfi wrote: > There are a few that I have in mind. > > 1. -emit-ifso could be added to a build to produce .so files as part of a > device SDK (where we don't want to ship the runnable bits in the SDK,

[PATCH] D59963: [clang-tidy] Add a module for the Linux kernel.

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:148 + + FIXME: add release notes. + Please add short description. Should be same as first statements in documentation. Repository: rG LLVM Github Monorepo CHANGES

r358935 - [CMake] Replace the sanitizer support in runtimes build with multilib

Author: phosek Date: Mon Apr 22 16:31:39 2019 New Revision: 358935 URL: http://llvm.org/viewvc/llvm-project?rev=358935=rev Log: [CMake] Replace the sanitizer support in runtimes build with multilib This is a more generic solution; while the sanitizer support can be used only for sanitizer

[PATCH] D60926: [CMake] Replace the sanitizer support in runtimes build with multilib

This revision was automatically updated to reflect the committed changes. Closed by commit rL358935: [CMake] Replace the sanitizer support in runtimes build with multilib (authored by phosek, committed by ). Changed prior to commit: https://reviews.llvm.org/D60926?vs=195934=196159#toc

[PATCH] D58537: lib/Header: Simplify CMakeLists.txt

tstellar marked an inline comment as done. tstellar added inline comments. Comment at: cfe/trunk/lib/Headers/CMakeLists.txt:168 install( - FILES ${cuda_wrapper_files} - COMPONENT clang-headers - PERMISSIONS OWNER_READ OWNER_WRITE GROUP_READ WORLD_READ - DESTINATION

[PATCH] D60985: Fix compatability for cuda sm_75

tra added a comment. FYI, I have almost-ready set of patches to implement missing bits of sm_75 support, including this change: https://reviews.llvm.org/D60279 I expect to land them some time this week. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60985/new/

[PATCH] D60899: [analyzer] Unbreak body farms in presence of multiple declarations.

a_sidorin added a comment. > Mmm, what are the pros and cons? This is how we do it in the ASTImporter. It allows us to correctly handle redeclarations with and without bodies - the declarations in the current AST remain unchanged but a new declaration appears. But it can be a kind of a

[PATCH] D60943: Delay diagnosing "n" constraint until after inlining

rsmith added a comment. In D60943#1474899 , @void wrote: > Here's the motivating bug report: https://bugs.llvm.org/show_bug.cgi?id=41027 Thanks, that's illuminating. OK, if we want to support that code, then there's really not much validation we can do

[PATCH] D56571: [RFC prototype] Implementation of asm-goto support in clang

craig.topper added a comment. @void, @jyknight given that looks like a LLVM issue rather than a clang issue, can we file a bugzilla to track separately from this clang frontend patch? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56571/new/ https://reviews.llvm.org/D56571

[PATCH] D60985: Fix compatability for cuda sm_75

eagleonhill created this revision. Herald added subscribers: cfe-commits, jholewinski. Herald added a project: clang. This allows compute capability 7.5 to use 7.X intrinsics. Repository: rC Clang https://reviews.llvm.org/D60985 Files: clang/include/clang/Basic/BuiltinsNVPTX.def Index:

[PATCH] D59963: [clang-tidy] Add a module for the Linux kernel.

tmroeder updated this revision to Diff 196150. tmroeder added a comment. Actually add the documentation in the release notes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59963/new/ https://reviews.llvm.org/D59963 Files:

[PATCH] D59977: [Lexer] Fix an off-by-one bug in Lexer::getAsCharRange() - NFC.

NoQ updated this revision to Diff 196145. NoQ added a comment. Herald added subscribers: kadircet, arphaman, jkorous. In D59977#1458051 , @alexfh wrote: > It looks like there's a number of users of this function beyond what you've > mentioned: >

[PATCH] D58537: lib/Header: Simplify CMakeLists.txt

tstellar added a comment. In D58537#1474824 , @smeenai wrote: > @tstellar ping. Someone appears to be running into this on the CMake mailing > list too: https://cmake.org/pipermail/cmake/2019-April/069359.html Sorry, I missed this. I will take a look.

[PATCH] D60349: [COFF, ARM64] Fix ABI implementation of struct returns

efriedma added inline comments. Comment at: lib/Sema/SemaDeclCXX.cpp:5904 if (CCK == TargetInfo::CCK_MicrosoftWin64) { +bool isAArch64 = S.Context.getTargetInfo().getTriple().isAArch64(); I'm not entirely sure it makes sense to do all of these

[PATCH] D60943: Delay diagnosing "n" constraint until after inlining

rsmith added a comment. I don't like making the validity of an input depend on optimizations, but I presume this is necessary to build Linux or similar? I'd be more comfortable with this if we still did the eager check if the enclosing function doesn't have the `always_inline` attribute. Is

[PATCH] D60943: Delay diagnosing "n" constraint until after inlining

void added a comment. Here's the motivating bug report: https://bugs.llvm.org/show_bug.cgi?id=41027 In general, I agree with you that diagnostics shouldn't depend on optimization levels, but inline assembly subverts this paradigm because it was originally a gcc extension. :-( That said, I

[PATCH] D59673: [Clang] Harmonize Split DWARF options with llc

aaronpuchert updated this revision to Diff 196156. aaronpuchert added a comment. Adapt one more test case. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59673/new/ https://reviews.llvm.org/D59673 Files: include/clang/Basic/CodeGenOptions.def

[PATCH] D59673: [Clang] Harmonize Split DWARF options with llc

aaronpuchert added a subscriber: pcc. aaronpuchert added inline comments. Comment at: lib/CodeGen/BackendUtil.cpp:1345 Conf.RemarksPasses = CGOpts.OptRecordPasses; - Conf.DwoPath = CGOpts.SplitDwarfFile; + Conf.DwoPath = CGOpts.SplitDwarfOutput; switch (Action) {

[PATCH] D60418: inline asm: Don't copy llvm::MemoryBuffers when showing diagnostics

rnk added a comment. > This is blocked on fixing PR41431. I reviewed the code, but timed out while trying to understand PR41431. Maybe ping @rsmith about it again? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60418/new/ https://reviews.llvm.org/D60418

[PATCH] D55500: [Builtins] Implement __builtin_is_constant_evaluated for use in C++2a

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. Herald added a subscriber: dexonsmith. LGTM, thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55500/new/ https://reviews.llvm.org/D55500

[PATCH] D59744: Fix i386 ABI "__m64" type bug

rnk added subscribers: dexonsmith, rjmccall. rnk added inline comments. Comment at: lib/CodeGen/TargetInfo.cpp:919 /// IsX86_MMXType - Return true if this is an MMX type. bool IsX86_MMXType(llvm::Type *IRType) { - // Return true if the type is an MMX type <2 x i32>, <4 x

[PATCH] D59168: [runtimes] Move libunwind, libc++abi and libc++ to lib/clang/ and include/

jdenny added a comment. Does the following match what you have in mind? $prefix/ include/ c++/ v1/ limits.h ... openmp/ v1/ <-- I don't think openmp has anything like this now omp.h ompt.h ... lib/

r358932 - [c++2a] Implement semantic restrictions for 'export' declarations.

Author: rsmith Date: Mon Apr 22 15:50:11 2019 New Revision: 358932 URL: http://llvm.org/viewvc/llvm-project?rev=358932=rev Log: [c++2a] Implement semantic restrictions for 'export' declarations. Added: cfe/trunk/test/CXX/module/module.interface/Inputs/

[PATCH] D59963: [clang-tidy] Add a module for the Linux kernel.

tmroeder updated this revision to Diff 196148. tmroeder marked an inline comment as done. tmroeder added a comment. Updated with an initial check. Verified that add_new_check.py works (that's how I added the check). Also added some basic docs and a test. Repository: rG LLVM Github Monorepo

[PATCH] D59963: [clang-tidy] Add a module for the Linux kernel.

tmroeder marked an inline comment as done. tmroeder added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:148 + + FIXME: add release notes. + Eugene.Zelenko wrote: > Please add short description. Should be same as first statements in >

[PATCH] D59963: [clang-tidy] Add a module for the Linux kernel.

tmroeder updated this revision to Diff 196151. tmroeder added a comment. Fix a line-length issue in the check code and rewrite the doc text. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59963/new/ https://reviews.llvm.org/D59963 Files:

[PATCH] D58537: lib/Header: Simplify CMakeLists.txt

smeenai added a comment. @tstellar ping. Someone appears to be running into this on the CMake mailing list too: https://cmake.org/pipermail/cmake/2019-April/069359.html Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58537/new/ https://reviews.llvm.org/D58537

[PATCH] D60988: [analyzer] Fix crash when returning C++ objects from ObjC messages-to-nil.

NoQ created this revision. NoQ added a reviewer: dcoughlin. Herald added subscribers: cfe-commits, Charusso, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a project: clang. This is an Objective-C++ specific fix to a problem that's

r358877 - [analyzer][www] Moving MoveChecker out of alpha is no longer an open project.

Author: szelethus Date: Mon Apr 22 02:20:23 2019 New Revision: 358877 URL: http://llvm.org/viewvc/llvm-project?rev=358877=rev Log: [analyzer][www] Moving MoveChecker out of alpha is no longer an open project. Modified: cfe/trunk/www/analyzer/open_projects.html Modified:

[PATCH] D60974: Clang IFSO driver action.

compnerd added a comment. @jakehehrlich I think you are misunderstanding this. The intent here is to provide a means to emit just the interfaces from a library into a stub that can be used for building. However, rather than have the interfaces be defined elsewhere, having clang run through

r358944 - [analyzer] PR41269: Add a bit of C++ smart pointer modeling.

Author: dergachev Date: Mon Apr 22 19:45:42 2019 New Revision: 358944 URL: http://llvm.org/viewvc/llvm-project?rev=358944=rev Log: [analyzer] PR41269: Add a bit of C++ smart pointer modeling. Implement cplusplus.SmartPtrModeling, a new checker that doesn't emit any warnings but models methods of

[PATCH] D60808: [analyzer] pr41335: NoStoreFuncVisitor: Fix crash when no-store event is in a body-farmed function.

This revision was automatically updated to reflect the committed changes. Closed by commit rC358945: [analyzer] PR41335: Fix crash when no-store event is in a body-farmed function. (authored by dergachev, committed by ). Changed prior to commit:

[PATCH] D59924: [PowerPC] [Clang] Port MMX intrinsics and basic test cases to Power

This revision was automatically updated to reflect the committed changes. Closed by commit rC358949: [PowerPC] [Clang] Port MMX intrinsics and basic test cases to Power (authored by chaofan, committed by ). Changed prior to commit: https://reviews.llvm.org/D59924?vs=194446=196182#toc

[PATCH] D60991: [analyzer] RetainCount: Allow offsets in return values.

NoQ created this revision. NoQ added a reviewer: dcoughlin. Herald added subscribers: cfe-commits, Charusso, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a project: clang. Because RetainCountChecker has custom "local" reasoning

[PATCH] D60943: Delay diagnosing "n" constraint until after inlining

void added a comment. In D60943#1474926 , @rsmith wrote: > In D60943#1474899 , @void wrote: > > > Here's the motivating bug report: > > https://bugs.llvm.org/show_bug.cgi?id=41027 > > > Thanks, that's

[PATCH] D60408: [LibTooling] Extend Transformer to support multiple simultaneous changes.

liutianle added a comment. In D60408#1474100 , @ymandel wrote: > In D60408#1473370 , @liutianle wrote: > > > hi ymandel, > > When I run "check-all", there are some warning/error in > > TransformerTest.cpp as

[PATCH] D60974: Clang IFSO driver action.

jakehehrlich added a comment. I'm not misunderstanding, please seem my post on llvm-dev where I layout the different issues involved. You're underestimating the complexities involved here I think. Trivializing what the linker does to "the linker just merges these" is a gross oversimplification

[PATCH] D60990: [Driver] Support priority for multilibs

phosek created this revision. phosek added reviewers: jroelofs, bkramer. Herald added subscribers: cfe-commits, mgrang. Herald added a project: clang. When more than one multilib flag matches, try to select the best possible match based on priority. When two different multilibs with the same same

[PATCH] D60974: Clang IFSO driver action.

compnerd added a comment. I'm well versed in the complexities of a linker - I've worked extensively on the GNU linkers as well as with lld. The visibility of the symbols is actually computed by the compiler - the STV_* flags associated with the symtab entry give you that information which is

r358945 - [analyzer] PR41335: Fix crash when no-store event is in a body-farmed function.

Author: dergachev Date: Mon Apr 22 19:50:38 2019 New Revision: 358945 URL: http://llvm.org/viewvc/llvm-project?rev=358945=rev Log: [analyzer] PR41335: Fix crash when no-store event is in a body-farmed function. Stuffing invalid source locations (such as those in functions produced by body farms)

[PATCH] D60899: [analyzer] Unbreak body farms in presence of multiple declarations.

This revision was automatically updated to reflect the committed changes. Closed by commit rL358946: [analyzer] Unbreak body farms in presence of multiple declarations. (authored by dergachev, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to

[PATCH] D60899: [analyzer] Unbreak body farms in presence of multiple declarations.

NoQ added a comment. With body farms, i think, the current declaration also remains unchanged, we're just getting a shining new `CompoundStmt` as a body in the middle of nowhere, i.e., `ADC->getDecl()->getBody()` isn't the same as `ADC->getBody()`. Which is, yeah, still weird :) Repository:

r358946 - [analyzer] Unbreak body farms in presence of multiple declarations.

Author: dergachev Date: Mon Apr 22 19:56:00 2019 New Revision: 358946 URL: http://llvm.org/viewvc/llvm-project?rev=358946=rev Log: [analyzer] Unbreak body farms in presence of multiple declarations. When growing a body on a body farm, it's essential to use the same redeclaration of the function

[PATCH] D58321: [WIP] Support for relative vtables

leonardchan updated this revision to Diff 196180. leonardchan added a subscriber: mcgrathr. leonardchan added a comment. Herald added a subscriber: hiraditya. Uploading my latest version of this patch and reporting some results. Will proceed with formatting and cleanup and ask for official

[PATCH] D60930: [codeview] Fix symbol names for dynamic initializers and atexit stubs

jyu2 added a comment. Looks good to me. We are basically de-mangled name for those __E initialize global’s function and __F destroy global's function. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60930/new/ https://reviews.llvm.org/D60930

[PATCH] D60974: Clang IFSO driver action.

plotfi created this revision. Herald added subscribers: cfe-commits, eraman, mgorny. Herald added a project: clang. This enables -emit-ifso to generate an interface library for each .o file. Currently it just writes a text file with the mangled names in it. Repository: rC Clang

[PATCH] D60974: Clang IFSO driver action.

plotfi marked an inline comment as done. plotfi added inline comments. Comment at: clang/lib/Frontend/FrontendActions.cpp:185 +OS << (IsRDOLate ? "late-parsed-decl: " : "") + << (IsRDOLate ? ND->getNameAsString() : MangledName) << "\n"; +// For now, lets just dump

[PATCH] D41910: [Concepts] Constrained partial specializations and function overloads.

saar.raz updated this revision to Diff 196106. saar.raz added a comment. - Fixed importing of ACs when importing partial specs. - Adjust to getAssociatedConstraints interface change Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D41910/new/

[PATCH] D41910: [Concepts] Constrained partial specializations and function overloads.

saar.raz updated this revision to Diff 196107. saar.raz added a comment. Renamed PartSpec to PartSpec2 (CR) Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D41910/new/ https://reviews.llvm.org/D41910 Files: include/clang/AST/DeclTemplate.h

[PATCH] D60349: [COFF, ARM64] Fix ABI implementation of struct returns

mgrang updated this revision to Diff 196109. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60349/new/ https://reviews.llvm.org/D60349 Files: include/clang/CodeGen/CGFunctionInfo.h lib/CodeGen/CGCall.cpp lib/CodeGen/MicrosoftCXXABI.cpp lib/Sema/SemaDeclCXX.cpp

[PATCH] D60926: [CMake] Replace the sanitizer support in runtimes build with multilib

phosek added a comment. Ping? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60926/new/ https://reviews.llvm.org/D60926 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D60570: [Sema] Add more tests for the behavior of argument-dependent name lookup

This revision was automatically updated to reflect the committed changes. Closed by commit rL358881: [Sema][NFC] Add more tests for the behavior of argument-dependent name lookup (authored by brunoricci, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits.

[PATCH] D60956: [Sema] Fix the lookup for a declaration conflicting with an enumerator (bogus use of LookupResult::getAsSingle)

riccibruno marked an inline comment as done. riccibruno added inline comments. Comment at: lib/Sema/SemaDecl.cpp:16607 + // Check for other kinds of shadowing not already handled. + if (PrevDecl && isa(PrevDecl->getUnderlyingDecl()) && + !TheEnumDecl->isScoped())

r358882 - [Sema] ADL: Associated namespaces for class types and enumeration types (CWG 1691)

Author: brunoricci Date: Mon Apr 22 05:19:00 2019 New Revision: 358882 URL: http://llvm.org/viewvc/llvm-project?rev=358882=rev Log: [Sema] ADL: Associated namespaces for class types and enumeration types (CWG 1691) CWG 1691 changed the definition of the namespaces associated with a class type

[PATCH] D60573: [Sema] ADL: Associated namespaces for class types and enumeration types (CWG 1691)

This revision was automatically updated to reflect the committed changes. Closed by commit rC358882: [Sema] ADL: Associated namespaces for class types and enumeration types (CWG… (authored by brunoricci, committed by ). Changed prior to commit:

[PATCH] D60507: [clang-tidy] new check: bugprone-unhandled-self-assignment

ztamas updated this revision to Diff 196066. ztamas added a comment. Add false positive test cases. Added a note about template related limitation to the docs. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60507/new/

r358881 - [Sema][NFC] Add more tests for the behavior of argument-dependent name lookup

Author: brunoricci Date: Mon Apr 22 04:40:31 2019 New Revision: 358881 URL: http://llvm.org/viewvc/llvm-project?rev=358881=rev Log: [Sema][NFC] Add more tests for the behavior of argument-dependent name lookup The goal here is to exercise each rule in [basic.lookup.argdep] at least once. These

[PATCH] D60956: [Sema] Fix the lookup for a declaration conflicting with an enumerator (bogus use of LookupResult::getAsSingle)

aaron.ballman added inline comments. Comment at: lib/Sema/SemaDecl.cpp:16607 + // Check for other kinds of shadowing not already handled. + if (PrevDecl && isa(PrevDecl->getUnderlyingDecl()) && + !TheEnumDecl->isScoped()) Is the change to

[PATCH] D60408: [LibTooling] Extend Transformer to support multiple simultaneous changes.

ymandel added a comment. In D60408#1473370 , @liutianle wrote: > hi ymandel, > When I run "check-all", there are some warning/error in TransformerTest.cpp > as follow. My version is llvm:0ee120077 and clang:d87ee8e678. Could you > please have a fix or

[PATCH] D60943: Delay diagnosing "n" constraint until after inlining

joerg added a comment. I'm in the process of testing this, but feedback will take a bit. On the more meaty parts of this change, I think further iterations will be necessary in-tree to extend this to the other constraints. Repository: rC Clang CHANGES SINCE LAST ACTION

[PATCH] D58033: Add option for emitting dbg info for call site parameters

djtodoro updated this revision to Diff 196053. djtodoro added a comment. -Add only cc1 option -Set up back end CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58033/new/ https://reviews.llvm.org/D58033 Files: include/clang/Basic/CodeGenOptions.def include/clang/Driver/CC1Options.td

[PATCH] D55793: [clang-tidy] Add duplicated access specifier readability check (PR25403)

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/RedundantAccessSpecifiersCheck.cpp:35-36 + for (DeclContext::specific_decl_iterator + AS(MatchedDecl->decls_begin()), + ASEnd(MatchedDecl->decls_end()); + AS !=

[PATCH] D60956: [Sema] Fix the lookup for a declaration conflicting with an enumerator (bogus use of LookupResult::getAsSingle)

aaron.ballman added inline comments. Comment at: lib/Sema/SemaDecl.cpp:16607 + // Check for other kinds of shadowing not already handled. + if (PrevDecl && isa(PrevDecl->getUnderlyingDecl()) && + !TheEnumDecl->isScoped()) riccibruno wrote: > aaron.ballman

[PATCH] D55411: [clang-tidy] check for flagging using declarations not in the inner most namespace

aaron.ballman added inline comments. Comment at: clang-tidy/abseil/SafelyScopedCheck.cpp:22 + // The target using declaration is either: + // 1. not in any namespace declaration, or + // 2. in some namespace declaration but not in the innermost layer

[PATCH] D59754: [Sema] Add c++2a designated initializer warnings

hintonda marked an inline comment as done. hintonda added inline comments. Comment at: clang/lib/Sema/SemaInit.cpp:2069-2072 +if (!VerifyOnly && HasDesignatedInit && SemaRef.getLangOpts().CPlusPlus2a) { + SemaRef.Diag(Init->getBeginLoc(), diag::ext_c20_designated_init)

[PATCH] D60920: [ASTMatchers] Introduce Objective-C matchers `isClassMessage`, `isClassMethod`, and `isInstanceMethod`

mwyman accepted this revision. mwyman added a comment. Thanks. I don't believe I have commit access, so I'll need someone to commit this to trunk. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60920/new/ https://reviews.llvm.org/D60920

[PATCH] D41569: [Concepts] Constraint enforcement and diagnostics

saar.raz updated this revision to Diff 196091. saar.raz added a comment. Adjusted to changes in getAssociatedConstraints interface Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D41569/new/ https://reviews.llvm.org/D41569 Files: include/clang/AST/ExprCXX.h

[PATCH] D38061: Set AnonymousTagLocations false for ASTContext if column info is expected not to be used

twoh added a subscriber: wenlei. twoh added a comment. Herald added a subscriber: dexonsmith. Herald added a project: clang. Hello @rsmith, @wenlei and I took another look at this, and we couldn't find any use of `AnonymousTagLocations` outside of debug info. If that's actually the case,

r358904 - [ASTMatchers] Introduce Objective-C matchers `isClassMessage`, `isClassMethod`, and `isInstanceMethod`

Author: benhamilton Date: Mon Apr 22 10:54:11 2019 New Revision: 358904 URL: http://llvm.org/viewvc/llvm-project?rev=358904=rev Log: [ASTMatchers] Introduce Objective-C matchers `isClassMessage`, `isClassMethod`, and `isInstanceMethod` Summary: isClassMessage is an equivalent to

[PATCH] D60920: [ASTMatchers] Introduce Objective-C matchers `isClassMessage`, `isClassMethod`, and `isInstanceMethod`

This revision was automatically updated to reflect the committed changes. Closed by commit rC358904: [ASTMatchers] Introduce Objective-C matchers `isClassMessage`, `isClassMethod`… (authored by benhamilton, committed by ). Changed prior to commit:

[PATCH] D60967: Move setTargetAttributes after setGVProperties in SetFunctionAttributes

scott.linder created this revision. scott.linder added reviewers: atanasyan, rjmccall, yaxunl. Herald added subscribers: cfe-commits, arichardson, tpr, sdardis. Herald added a project: clang. AMDGPU relies on global properties being set before setTargetProperties is called. Existing targets like

[PATCH] D46421: [analyzer][CrossTU] Extend CTU to VarDecls with initializer

xazax.hun added a comment. Looks good, thanks. Can you commit this or do you need someone to commit it on your behalf? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D46421/new/ https://reviews.llvm.org/D46421 ___

[PATCH] D59465: [analyzer] Add example plugin for checker option handling

Szelethus updated this revision to Diff 196079. Szelethus added a comment. - Move the existing plugin to `test/` - Implement the new plugin in there also CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59465/new/ https://reviews.llvm.org/D59465 Files: examples/CMakeLists.txt

[PATCH] D59464: [analyzer] Add an example plugin for checker dependency handling

Szelethus updated this revision to Diff 196083. Szelethus added a comment. - Move the existing plugin to `test/` - Implement the new plugin in there also CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59464/new/ https://reviews.llvm.org/D59464 Files: examples/CMakeLists.txt

[PATCH] D59465: [analyzer] Add example plugin for checker option handling

Szelethus updated this revision to Diff 196080. Szelethus added a comment. Accidentally uploaded the wrong diff. Rebase on top of D59464 . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59465/new/ https://reviews.llvm.org/D59465 Files:

[PATCH] D58033: Add option for emitting dbg info for call site parameters

aprantl added a comment. Is there some kind of testcase? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58033/new/ https://reviews.llvm.org/D58033 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D59802: [clang-tidy] Add new checker: llvm-prefer-isa-or-dyn-cast-in-conditionals

hintonda added a comment. @aaron.ballman, I just ran it over llvm/lib, including all in-tree headers, and it seems to work fine. However, it did miss this one: - if (V && isa(V) && (EntInst = cast(V)) && +if (isa_and_nonnull(V) && (EntInst = cast(V)) && It got the first, but not the

[PATCH] D59509: Make static constructors + destructors minsize + cold (except for in -O0)

paquette updated this revision to Diff 196085. paquette added a comment. Made the test less fragile by splitting the WITHOUT-NOT into three lines. (Thanks for the suggestion!) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59509/new/ https://reviews.llvm.org/D59509 Files:

[PATCH] D41284: [Concepts] Associated constraints infrastructure.

saar.raz updated this revision to Diff 196074. saar.raz added a comment. - Address CR comments by rsmith - Remove obsolete TODOs - Fix redeclaration checking - Change getAssociatedConstraints interface - Add requires clause to ASTNodeTraverser Repository: rC Clang CHANGES SINCE LAST

[PATCH] D46421: [analyzer][CrossTU] Extend CTU to VarDecls with initializer

r.stahl updated this revision to Diff 196075. r.stahl added a comment. @xazax.hun good point and that actually fixes a bug since that branch should also do the deep check. Added that to the tests. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D46421/new/

[PATCH] D60850: [sema][objc] Minor refactor to OverrideSearch. NFCI.

This revision was automatically updated to reflect the committed changes. Closed by commit rC358898: [sema][objc] Minor refactor to OverrideSearch. NFCI. (authored by mattd, committed by ). Herald added a project: clang. Herald added a subscriber: cfe-commits. Changed prior to commit:

[libunwind] r358896 - [NFC] Fix typo in debug log

Author: ldionne Date: Mon Apr 22 08:40:50 2019 New Revision: 358896 URL: http://llvm.org/viewvc/llvm-project?rev=358896=rev Log: [NFC] Fix typo in debug log Modified: libunwind/trunk/src/UnwindCursor.hpp Modified: libunwind/trunk/src/UnwindCursor.hpp URL:

r358898 - [sema][objc] Minor refactor to OverrideSearch. NFCI.

Author: mattd Date: Mon Apr 22 09:04:44 2019 New Revision: 358898 URL: http://llvm.org/viewvc/llvm-project?rev=358898=rev Log: [sema][objc] Minor refactor to OverrideSearch. NFCI. Summary: * Removed a member that was only used during construction. * Use range-based for iteration when accessing

[PATCH] D60974: Clang IFSO driver action.

jakehehrlich added a comment. Can you elaborate on the use case for this? Like can you explain end to end how this would be used? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60974/new/ https://reviews.llvm.org/D60974

[PATCH] D60349: [COFF, ARM64] Fix ABI implementation of struct returns

efriedma added inline comments. Comment at: lib/Sema/SemaDeclCXX.cpp:5906 +bool isAArch64 = S.Context.getTargetInfo().getTriple().isAArch64(); +if (isAArch64 && !D->isAggregate()) + return false; The isAggregate predicate is not appropriate to check

[PATCH] D59418: [OpenMP][Offloading] Extract common functionality

jdoerfert added a comment. ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59418/new/ https://reviews.llvm.org/D59418 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D59420: [NFC][OpenMP] Move runtime function generation to the target codegen

jdoerfert added a comment. ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59420/new/ https://reviews.llvm.org/D59420 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D59424: [OpenMP][NVPTX] Replace void** buffer by byte-wise buffer

jdoerfert added a comment. ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59424/new/ https://reviews.llvm.org/D59424 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D59712: [APSInt][OpenMP] Fix isNegative, etc. for unsigned types

jdenny added a comment. Thanks for the reviews! Will push soon. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59712/new/ https://reviews.llvm.org/D59712 ___ cfe-commits mailing list

[PATCH] D60926: [CMake] Replace the sanitizer support in runtimes build with multilib

beanz accepted this revision. beanz added a comment. This revision is now accepted and ready to land. I really like this. Using `+` to add variants seems much widely useful. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60926/new/ https://reviews.llvm.org/D60926

[PATCH] D60845: [VerifyDiagnosticConsumer] Document -verify= in doxygen

This revision was automatically updated to reflect the committed changes. Closed by commit rC358917: [VerifyDiagnosticConsumer] Document -verify=prefixes in doxygen (authored by jdenny, committed by ). Changed prior to commit: https://reviews.llvm.org/D60845?vs=195742=196127#toc Repository:

r358917 - [VerifyDiagnosticConsumer] Document -verify= in doxygen

Author: jdenny Date: Mon Apr 22 13:25:06 2019 New Revision: 358917 URL: http://llvm.org/viewvc/llvm-project?rev=358917=rev Log: [VerifyDiagnosticConsumer] Document -verify= in doxygen Previously, it was only documented by `-cc1 -help`, so people weren't aware of it, as discussed in D60732.