[PATCH] D62115: fix a issue that clang is incompatible with gcc with -H option.

xbolva00 added inline comments. Comment at: lib/Frontend/HeaderIncludeGen.cpp:56 + if (Filename.startswith("./")); +Filename=Filename.substr(2); + Formatting Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62115/new/ https://

[PATCH] D62115: fix a issue that clang is incompatible with gcc with -H option.

xiangzhangllvm added inline comments. Comment at: lib/Frontend/HeaderIncludeGen.cpp:55 + // Simplify Filename that starts with "./" + if (Filename.startswith("./")); +Filename=Filename.substr(2); Need remove ";" ? Repository: rC Clang CHANGES SINCE LA

[PATCH] D61722: [AST] Add RecoveryExpr; produce it on overload resolution failure and missing member.

rsmith added a comment. In D61722#1504376 , @sammccall wrote: > In D61722#1503863 , @rsmith wrote: > > > I expect we'll want a `ContainsErrors` bit on `Stmt`, propagated similarly > > to the existing `Instantiation

[PATCH] D62115: fix a issue that clang is incompatible with gcc with -H option.

skan updated this revision to Diff 200212. skan added a comment. remove ";" and format the code CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62115/new/ https://reviews.llvm.org/D62115 Files: lib/Frontend/HeaderIncludeGen.cpp test/Driver/clang_H_opt.c test/Driver/clang_H_opt.h

[PATCH] D59887: [Syntax] Introduce TokenBuffer, start clangToolingSyntax library

ilya-biryukov updated this revision to Diff 200213. ilya-biryukov marked 3 inline comments as done. ilya-biryukov added a comment. - Fix a comment, reformat - Use assertions instead of returning optionals Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D59887: [Syntax] Introduce TokenBuffer, start clangToolingSyntax library

ilya-biryukov added inline comments. Comment at: clang/include/clang/Tooling/Syntax/Tokens.h:115 + /// expansion. + llvm::Optional range(const SourceManager &SM) const; + sammccall wrote: > ilya-biryukov wrote: > > sammccall wrote: > > > I think this might need

[PATCH] D61974: [ObjC] Fix encoding of ObjC pointer types that are pointers to typedefs

ahatanak updated this revision to Diff 200216. ahatanak marked an inline comment as done. ahatanak added a comment. Delete the entire code path that tries to work around a bug in gcc. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61974/new/ https://reviews.llvm.o

[PATCH] D62125: Run ClangTidy tests in all C++ language modes

gribozavr created this revision. gribozavr added a reviewer: alexfh. Herald added subscribers: cfe-commits, lebedev.ri, jdoerfert, arphaman, kbarton, nemanjai. Herald added a reviewer: lebedev.ri. Herald added a project: clang. I inspected every test and did one of the following: - changed the t

[PATCH] D62125: Run ClangTidy tests in all C++ language modes

JonasToth added a comment. Wow, a lot of work! I did not check all test files, but I saw that you explicitly enabled c++11,14,17 but not 98. Is there a reason for that? I think we should test that standard too. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews

[PATCH] D62127: [Hexagon] driver uses out-of-date option name and binary name

t.yomitch created this revision. t.yomitch added reviewers: kparzysz, sidneym, sgundapa. Herald added a project: clang. Repository: rC Clang https://reviews.llvm.org/D62127 Files: lib/Driver/ToolChains/Hexagon.cpp Index: lib/Driver/ToolChains/Hexagon.cpp ===

[PATCH] D62125: Run ClangTidy tests in all C++ language modes

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. That's a quite impressive amount of work. Thanks! Looks good. In D62125#1508113 , @JonasToth wrote: > Wow, a lot of work! > > I did not check all test

[PATCH] D62125: Run ClangTidy tests in all C++ language modes

gribozavr added a comment. > c++98 coverage is a rather niche thing there days. I believe, someone with > genuine need for C++98 support can work on that. +1, that's exactly the reason why I skipped 98. C++98 is 21 years old now (or 16 if you count from C++03). Most projects that build with a

[PATCH] D61722: [AST] Add RecoveryExpr; produce it on overload resolution failure and missing member.

sammccall added subscribers: gribozavr, klimek. sammccall added a comment. In D61722#1508050 , @rsmith wrote: > The simplest thing to do might be to ensure that `vector` is itself > `ErrorTy`. You're probably right, I'll try this. > For example, the co

[PATCH] D62115: fix a issue that clang is incompatible with gcc with -H option.

lebedev.ri added inline comments. Comment at: lib/Frontend/HeaderIncludeGen.cpp:55 + // Simplify Filename that starts with "./" + if (Filename.startswith("./")); +Filename=Filename.substr(2); xiangzhangllvm wrote: > Need remove ";" ? This was fixed but no

[PATCH] D62131: [ASTImporter] Remove NonEquivalentDecls from ASTImporter

martong created this revision. martong added a reviewer: a_sidorin. Herald added subscribers: cfe-commits, gamesh411, Szelethus, dkrupp, rnkovacs. Herald added a reviewer: a.sidorin. Herald added a reviewer: shafik. Herald added a project: clang. Currently ASTImporter::NonEquivalentDecls member ke

[PATCH] D62009: [clang] perform semantic checking in constant context

Tyker updated this revision to Diff 200231. Tyker edited the summary of this revision. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62009/new/ https://reviews.llvm.org/D62009 Files: clang/include/clang/AST/Expr.h clang/include/clang/Sema/Sema.h clang/lib/AST/ExprConstant.cpp cla

[clang-tools-extra] r361138 - [clang-tidy] Sort this list alphabetically

Author: ztamas Date: Mon May 20 03:37:42 2019 New Revision: 361138 URL: http://llvm.org/viewvc/llvm-project?rev=361138&view=rev Log: [clang-tidy] Sort this list alphabetically Modified: clang-tools-extra/trunk/clang-tidy/bugprone/BugproneTidyModule.cpp Modified: clang-tools-extra/trunk/clang

[PATCH] D62066: [ASTImporter] Enable disabled but passing tests

This revision was automatically updated to reflect the committed changes. Closed by commit rL361139: [ASTImporter] Enable disabled but passing tests (authored by martong, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://revi

[PATCH] D62133: test/CodeGen/builtin-stackaddress.c duplicates test/CodeGen/2004-02-13-BuiltinFrameReturnAddress.c

t.yomitch created this revision. t.yomitch added reviewers: efriedma, echristo, ddunbar. Herald added a subscriber: kristina. Herald added a project: clang. Repository: rC Clang https://reviews.llvm.org/D62133 Files: test/CodeGen/builtin-stackaddress.c Index: test/CodeGen/builtin-stackaddr

[PATCH] D61136: [Analyzer] Refactor begin and end symbol creation

This revision was automatically updated to reflect the committed changes. Closed by commit rL361141: [Analyzer] Refactor begin and end symbol creation (authored by baloghadamsoftware, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

r361141 - [Analyzer] Refactor begin and end symbol creation

Author: baloghadamsoftware Date: Mon May 20 04:04:27 2019 New Revision: 361141 URL: http://llvm.org/viewvc/llvm-project?rev=361141&view=rev Log: [Analyzer] Refactor begin and end symbol creation This patch refactors begin and end symbol creation by moving symbol conjuration into the `create...` f

[PATCH] D62135: [clangd] Turn no-parse-completion on by when preamble isn't ready. Add flag to force it.

sammccall created this revision. sammccall added a reviewer: kadircet. Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D62135 Files: clangd/ClangdServer.cpp clangd/

[PATCH] D62135: [clangd] Turn no-parse-completion on by when preamble isn't ready. Add flag to force it.

sammccall updated this revision to Diff 200249. sammccall added a comment. code-completion-parse -> completion-parse Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62135/new/ https://reviews.llvm.org/D62135 Files: clangd/ClangdServer.cpp clangd/

[PATCH] D62137: [Frontend] Return an error on bad inputs to PrecompiledPreabmle

ilya-biryukov created this revision. ilya-biryukov added a reviewer: sammccall. Herald added a project: clang. Instead of failing with assertions. Fixed a crash found by oss-fuzz: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=12865 Repository: rG LLVM Github Monorepo https://reviews.l

[PATCH] D59415: Do not resolve directory junctions for `-fdiagnostics-absolute-paths` on Windows.

ikudrin updated this revision to Diff 200252. ikudrin added a comment. - Made the patch affect only `-fdiagnostics-absolute-paths` option. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59415/new/ https://reviews.llvm.org/D59415 Files: lib/Frontend/TextDiagnostic.cpp test/Frontend/a

r361145 - Fix compilation warning about unused variable [NFC]

Author: uabelho Date: Mon May 20 04:38:33 2019 New Revision: 361145 URL: http://llvm.org/viewvc/llvm-project?rev=361145&view=rev Log: Fix compilation warning about unused variable [NFC] Without the fix at least clang 3.6 complains with ../tools/clang/lib/AST/ExprConstant.cpp:90:24: error: unused

[clang-tools-extra] r361147 - [clangd] Fix naming warning from clang-tidy. NFC

Author: ibiryukov Date: Mon May 20 05:17:36 2019 New Revision: 361147 URL: http://llvm.org/viewvc/llvm-project?rev=361147&view=rev Log: [clangd] Fix naming warning from clang-tidy. NFC Also remove newlines and braces. Modified: clang-tools-extra/trunk/clangd/unittests/ClangdTests.cpp Modifi

[PATCH] D62135: [clangd] Turn no-parse-completion on by when preamble isn't ready. Add flag to force it.

kadircet accepted this revision. kadircet added inline comments. This revision is now accepted and ready to land. Comment at: clangd/CodeComplete.h:128 +/// Always use text-based completion. +NeverParse, + } RunParser = ParseIfReady; Do we really have an

r361139 - [ASTImporter] Enable disabled but passing tests

Author: martong Date: Mon May 20 03:38:14 2019 New Revision: 361139 URL: http://llvm.org/viewvc/llvm-project?rev=361139&view=rev Log: [ASTImporter] Enable disabled but passing tests Reviewers: a_sidorin, a.sidorin, shafik Subscribers: rnkovacs, dkrupp, Szelethus, gamesh411, cfe-commits Tags: #c

[PATCH] D61774: [LibTooling] Add RangeSelector library for defining source ranges based on bound AST nodes.

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. Thanks! LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61774/new/ https://reviews.llvm.org/D61774

[PATCH] D43576: Solution to fix PR27066 - Redefinition with same mangled name as another definition (dllexport and uuid)

zahiraam marked 12 inline comments as done. zahiraam added a comment. @rsmith I think I have made all the changes you have pointed out to. But please note that this new patch only impements an explicit AST representation of uuid in template arguments. It **does not** fix the bug for which this

[PATCH] D43576: Solution to fix PR27066 - Redefinition with same mangled name as another definition (dllexport and uuid)

zahiraam updated this revision to Diff 200258. zahiraam marked 2 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D43576/new/ https://reviews.llvm.org/D43576 Files: include/clang/AST/Decl.h include/clang/AST/RecursiveASTVisitor.h include/clang/Basic/Attr.td i

r361148 - [Syntax] Introduce TokenBuffer, start clangToolingSyntax library

Author: ibiryukov Date: Mon May 20 06:00:42 2019 New Revision: 361148 URL: http://llvm.org/viewvc/llvm-project?rev=361148&view=rev Log: [Syntax] Introduce TokenBuffer, start clangToolingSyntax library Summary: TokenBuffer stores the list of tokens for a file obtained after preprocessing. This is

[PATCH] D62138: [Docs] Increase Doxygen cache size

jryans created this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. When building Doxygen docs for llvm and clang, it helpfully prints a warning at the end noting that the `LOOKUP_CACHE_SIZE` value was too small to keep all symbols in memory. By

[PATCH] D59887: [Syntax] Introduce TokenBuffer, start clangToolingSyntax library

This revision was automatically updated to reflect the committed changes. Closed by commit rC361148: [Syntax] Introduce TokenBuffer, start clangToolingSyntax library (authored by ibiryukov, committed by ). Changed prior to commit: https://reviews.llvm.org/D59887?vs=200213&id=200260#toc Reposit

[PATCH] D61774: [LibTooling] Add RangeSelector library for defining source ranges based on bound AST nodes.

ymandel updated this revision to Diff 200262. ymandel added a comment. updated some comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61774/new/ https://reviews.llvm.org/D61774 Files: clang/include/clang/Tooling/Refactoring/RangeSelector.h

r361152 - [LibTooling] Add RangeSelector library for defining source ranges based on bound AST nodes.

Author: ymandel Date: Mon May 20 06:15:14 2019 New Revision: 361152 URL: http://llvm.org/viewvc/llvm-project?rev=361152&view=rev Log: [LibTooling] Add RangeSelector library for defining source ranges based on bound AST nodes. Summary: The RangeSelector library defines a combinator language for

[PATCH] D61774: [LibTooling] Add RangeSelector library for defining source ranges based on bound AST nodes.

This revision was automatically updated to reflect the committed changes. Closed by commit rL361152: [LibTooling] Add RangeSelector library for defining source ranges based on… (authored by ymandel, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed pri

[PATCH] D60283: [DebugInfo] Don't emit checksums when compiling a preprocessed CPP

aganea added a comment. Ping! Any further comments? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60283/new/ https://reviews.llvm.org/D60283 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.

[PATCH] D61851: [clang-tidy] New option for misc-throw-by-value-catch-by-reference

baloghadamsoftware updated this revision to Diff 200266. baloghadamsoftware added a comment. Updated according to the comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61851/new/ https://reviews.llvm.org/D61851 Files: clang-tidy/misc/ThrowByValueCatchByReferenceCheck.cpp clan

[PATCH] D61851: [clang-tidy] New option for misc-throw-by-value-catch-by-reference

lebedev.ri added a comment. Looks good Comment at: clang-tidy/misc/ThrowByValueCatchByReferenceCheck.h:45 + const bool WarnOnLargeObject; + uint64_t MaxSize; // No `const` bacause we have to set it in two steps. }; because CHANGES SINCE LAST ACTION https

[PATCH] D62138: [Docs] Increase Doxygen cache size

jryans added a comment. I don't currently have commit access, so I would need someone to land this for me assuming it's approved. If it would be easier for me to submit separate patches for the llvm and clang changes, please let me know! 😄 Repository: rG LLVM Github Monorepo CHANGES SINCE L

[PATCH] D61743: New clang option -MD-filter=prefix to filter files from make dependencies

mibintc added a comment. @rjmccall Can you take a look at this patch or recommend someone who can review it? Many thanks. --Melanie CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61743/new/ https://reviews.llvm.org/D61743 ___ cfe-commits ma

[PATCH] D60283: [DebugInfo] Don't emit checksums when compiling a preprocessed CPP

probinson accepted this revision. probinson added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60283/new/ https://reviews.llvm.org/D60283 ___ cfe-comm

[PATCH] D61851: [clang-tidy] New option for misc-throw-by-value-catch-by-reference

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM (with the typo fix). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61851/new/ https://reviews.llvm.org/D61851 ___ cfe

[PATCH] D62121: [PowerPC] [Clang] Port SSE intrinsics to PowerPC

jsji added subscribers: MaskRay, rjmccall, aaron.ballman, rnk, jyknight. jsji added a comment. Add more subscribers, reviews and comments are welcome and appreciated. Thanks. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62121/new/ https://reviews.llvm.org/D62121

[PATCH] D61774: [LibTooling] Add RangeSelector library for defining source ranges based on bound AST nodes.

ymandel added a comment. Test file broke gcc builds. Fix in progress... Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61774/new/ https://reviews.llvm.org/D61774 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D62138: [Docs] Increase Doxygen cache size

hintonda accepted this revision. hintonda added a comment. This revision is now accepted and ready to land. Thanks, LGTM! I'll give it a day for further comments, and barring any, commit it for you tomorrow. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

r361160 - [LibTooling] Fix build break in test after r361152.

Author: ymandel Date: Mon May 20 07:44:40 2019 New Revision: 361160 URL: http://llvm.org/viewvc/llvm-project?rev=361160&view=rev Log: [LibTooling] Fix build break in test after r361152. r361152 broke gcc builds. Modified: cfe/trunk/unittests/Tooling/RangeSelectorTest.cpp Modified: cfe/trunk

[PATCH] D61774: [LibTooling] Add RangeSelector library for defining source ranges based on bound AST nodes.

ymandel added a comment. Fixed with r361160. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61774/new/ https://reviews.llvm.org/D61774 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-

[PATCH] D37813: clang-format: better handle namespace macros

klimek added a comment. In D37813#1254891 , @Typz wrote: > In D37813#1254865 , @klimek wrote: > > > In D37813#1253813 , @Typz wrote: > > > > > In D37813#1184051

[PATCH] D58418: [clang][DirectoryWatcher] Upstream DirectoryWatcher

gribozavr added inline comments. Comment at: clang/include/clang/DirectoryWatcher/DirectoryWatcher.h:78 + /// The DirectoryWatcher that originated this event is no longer valid and + /// it's behavior is undefined. + /// The prime case is kernel signalling to OS-s

r361161 - Fix test not to use UNSUPPORTED as a FileCheck prefix.

Author: probinson Date: Mon May 20 07:57:18 2019 New Revision: 361161 URL: http://llvm.org/viewvc/llvm-project?rev=361161&view=rev Log: Fix test not to use UNSUPPORTED as a FileCheck prefix. It was not causing a problem but it's not good practice. Modified: cfe/trunk/test/Driver/cl-cc-flags.c

[PATCH] D62143: [clangd] Make it possible to use VFS from parsing for getting tidy options

ilya-biryukov created this revision. ilya-biryukov added a reviewer: sammccall. Herald added subscribers: kadircet, arphaman, jkorous, MaskRay. Herald added a project: clang. To give an option for clangd embedders with snapshotted filesystem to read config files from exact snapshots, possibly loos

[clang-tools-extra] r361163 - Disable the modernize-use-trailing-return-type.cpp test in C++2a mode

Author: gribozavr Date: Mon May 20 08:12:12 2019 New Revision: 361163 URL: http://llvm.org/viewvc/llvm-project?rev=361163&view=rev Log: Disable the modernize-use-trailing-return-type.cpp test in C++2a mode It is performing a use-of-uninitialized-value, as detected by MSan. Modified: clang-t

[PATCH] D62019: [clang] Handle lrint/llrint builtins

zatrazz updated this revision to Diff 200291. zatrazz added a comment. Updated patch based on D62026 . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62019/new/ https://reviews.llvm.org/D62019 Files: clang/lib/CodeGen/CGBuiltin.cpp clang/test/CodeGen

[PATCH] D62149: [LibTooling] Update Transformer to use RangeSelector instead of NodePart enum.

ymandel created this revision. ymandel added a reviewer: ilya-biryukov. Herald added a project: clang. ymandel updated this revision to Diff 200310. ymandel added a comment. reordered some declarations. Transformer provides an enum to indicate the range of source text to be edited. That support

[PATCH] D62149: [LibTooling] Update Transformer to use RangeSelector instead of NodePart enum.

ymandel updated this revision to Diff 200310. ymandel added a comment. reordered some declarations. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62149/new/ https://reviews.llvm.org/D62149 Files: clang/include/clang/Tooling/Refactoring/Transform

[PATCH] D61963: [clang][Darwin] Refactor header search path logic into the driver

ldionne updated this revision to Diff 200311. ldionne added a comment. Fix test that fails on systems that don't have /usr/include/c++. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61963/new/ https://reviews.llvm.org/D61963 Files: clang/include

[PATCH] D62149: [LibTooling] Update Transformer to use RangeSelector instead of NodePart enum.

ilya-biryukov added a comment. Looks neat! The only concern I have is about the growing number of overloads in `Transformer.h`, see the relevant comment. Comment at: clang/include/clang/Tooling/Refactoring/Transformer.h:186 +/// where a \c TextGenerator, \c RangeSelector are o

r361169 - [Intrinsics] Merge lround.i32 and lround.i64 into a single intrinsic with overloaded result type. Make result type for llvm.llround overloaded instead of fixing to i64

Author: ctopper Date: Mon May 20 09:27:09 2019 New Revision: 361169 URL: http://llvm.org/viewvc/llvm-project?rev=361169&view=rev Log: [Intrinsics] Merge lround.i32 and lround.i64 into a single intrinsic with overloaded result type. Make result type for llvm.llround overloaded instead of fixing t

[PATCH] D62150: Renamed `apply` to `select` to avoid ADL conflict with `std::apply`

gribozavr created this revision. gribozavr added a reviewer: ilya-biryukov. Herald added a project: clang. Herald added a subscriber: cfe-commits. `std::apply` in C++14 and above is defined with two unrestricted arguments, and it wins overload resolution in this case. Repository: rG LLVM Githu

[PATCH] D62151: [clangd] Add tweak to convert normal to raw string literal, when it contains escapes.

sammccall created this revision. sammccall added a reviewer: ilya-biryukov. Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay, mgorny. Herald added a project: clang. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D62151 Files: clangd/refactor/tweaks/CM

[PATCH] D62150: Renamed `apply` to `select` to avoid ADL conflict with `std::apply`

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. Quick LGTM to unbreak our integrate! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62150/new/ https://reviews.llvm.org/D62150 _

r361170 - Renamed `apply` to `select` to avoid ADL conflict with `std::apply`

Author: gribozavr Date: Mon May 20 09:30:49 2019 New Revision: 361170 URL: http://llvm.org/viewvc/llvm-project?rev=361170&view=rev Log: Renamed `apply` to `select` to avoid ADL conflict with `std::apply` Summary: `std::apply` in C++14 and above is defined with two unrestricted arguments, and it w

[PATCH] D62150: Renamed `apply` to `select` to avoid ADL conflict with `std::apply`

This revision was automatically updated to reflect the committed changes. Closed by commit rC361170: Renamed `apply` to `select` to avoid ADL conflict with `std::apply` (authored by gribozavr, committed by ). Changed prior to commit: https://reviews.llvm.org/D62150?vs=200313&id=200316#toc Repo

[PATCH] D62019: [clang] Handle lrint/llrint builtins

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62019/new/ https://reviews.llvm.org/D62019 ___ cfe-commits mailing list c

[PATCH] D62150: Renamed `apply` to `select` to avoid ADL conflict with `std::apply`

ilya-biryukov added a comment. @ymandel, feel free to change the name to your liking if you don't like `select`. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62150/new/ https://reviews.llvm.org/D62150 ___ cfe-commi

[PATCH] D62143: [clangd] Make it possible to use VFS from parsing for getting tidy options

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. This seems fine: - please give this `function<>` type a name - maybe `ClangTidyOptionsBuilder` or so? - while we're defining this, we should make it threadsafe because that's what we re

[PATCH] D62050: [Analysis] Only run plugins tests if plugins are actually enabled

hintonda added inline comments. Comment at: llvm/trunk/cmake/modules/HandleLLVMOptions.cmake:930 -else() +if(BUILD_SHARED_LIBS OR LLVM_BUILD_LLVM_DYLIB) set(LLVM_ENABLE_PLUGINS ON) endif() This is a breaking patch. What's the rational for unilaterally disabl

[PATCH] D62152: [ARM][AArch64] Fix incorrect handling of alignment in va_arg code generation

john.brawn created this revision. john.brawn added reviewers: chill, efriedma, t.p.northover, rjmccall. Herald added subscribers: kristof.beyls, javed.absar. Herald added a project: clang. Overaligned and underaligned types (i.e. types where the alignment has been increased or decreased using the

r361172 - Dump macro expansion information as needed when outputting the AST to JSON.

Author: aaronballman Date: Mon May 20 09:46:44 2019 New Revision: 361172 URL: http://llvm.org/viewvc/llvm-project?rev=361172&view=rev Log: Dump macro expansion information as needed when outputting the AST to JSON. Added: cfe/trunk/test/AST/ast-dump-macro-json.c Modified: cfe/trunk/includ

[PATCH] D62050: [Analysis] Only run plugins tests if plugins are actually enabled

hintonda added inline comments. Comment at: llvm/trunk/cmake/modules/HandleLLVMOptions.cmake:930 -else() +if(BUILD_SHARED_LIBS OR LLVM_BUILD_LLVM_DYLIB) set(LLVM_ENABLE_PLUGINS ON) endif() hintonda wrote: > This is a breaking patch. What's the rational for u

[PATCH] D61838: [Sema] Suppress additional warnings for C's zero initializer

Lekensteyn accepted this revision. Lekensteyn added a comment. Verified again! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61838/new/ https://reviews.llvm.org/D61838 ___ cfe-commits mailing list cfe-commits@lists.l

[PATCH] D62149: [LibTooling] Update Transformer to use RangeSelector instead of NodePart enum.

ymandel updated this revision to Diff 200325. ymandel added a comment. Removed most `change` overloads. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62149/new/ https://reviews.llvm.org/D62149 Files: clang/include/clang/Tooling/Refactoring/Trans

[PATCH] D62149: [LibTooling] Update Transformer to use RangeSelector instead of NodePart enum.

ymandel marked 2 inline comments as done. ymandel added inline comments. Comment at: clang/include/clang/Tooling/Refactoring/Transformer.h:186 +/// where a \c TextGenerator, \c RangeSelector are otherwise expected. +inline ASTEdit change(RangeSelector Target, std::string Replacem

[PATCH] D62143: [clangd] Make it possible to use VFS from parsing for getting tidy options

ilya-biryukov updated this revision to Diff 200328. ilya-biryukov added a comment. - Add a typedef for function - Make the provider thread-safe Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62143/new/ https://reviews.llvm.org/D62143 Files: clang

[PATCH] D60568: [OpenMP] Add support for registering requires directives with the runtime

gtbercea added a comment. ping Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60568/new/ https://reviews.llvm.org/D60568 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/l

[PATCH] D62143: [clangd] Make it possible to use VFS from parsing for getting tidy options

ilya-biryukov updated this revision to Diff 200329. ilya-biryukov added a comment. - Fix a typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62143/new/ https://reviews.llvm.org/D62143 Files: clang-tools-extra/clangd/ClangdServer.cpp clang-too

[PATCH] D62143: [clangd] Make it possible to use VFS from parsing for getting tidy options

ilya-biryukov updated this revision to Diff 200330. ilya-biryukov added a comment. - Fix another typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62143/new/ https://reviews.llvm.org/D62143 Files: clang-tools-extra/clangd/ClangdServer.cpp cla

[clang-tools-extra] r361178 - [clangd] Make it possible to use VFS from parsing for getting tidy options

Author: ibiryukov Date: Mon May 20 10:30:46 2019 New Revision: 361178 URL: http://llvm.org/viewvc/llvm-project?rev=361178&view=rev Log: [clangd] Make it possible to use VFS from parsing for getting tidy options Summary: To give an option for clangd embedders with snapshotted filesystem to read co

[PATCH] D62143: [clangd] Make it possible to use VFS from parsing for getting tidy options

This revision was automatically updated to reflect the committed changes. Closed by commit rL361178: [clangd] Make it possible to use VFS from parsing for getting tidy options (authored by ibiryukov, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed pr

[PATCH] D60568: [OpenMP] Add support for registering requires directives with the runtime

ABataev added a comment. Looks good, in general. Just one more question: will __tgt_register_requires be emitted if only -fopenmp is used? If -fopenmp-targets is not provided, this function should not be called, I think, because we're not going to use offloading at all in this case and __tgt_re

r361182 - Rearrange and clean up how we disambiguate lambda-introducers from ObjC

Author: rsmith Date: Mon May 20 11:01:54 2019 New Revision: 361182 URL: http://llvm.org/viewvc/llvm-project?rev=361182&view=rev Log: Rearrange and clean up how we disambiguate lambda-introducers from ObjC message sends, designators, and attributes. Instead of having the tentative parsing phase so

r361184 - [CMake] Update DistributionExample for mono repo

Author: cbieneman Date: Mon May 20 11:10:20 2019 New Revision: 361184 URL: http://llvm.org/viewvc/llvm-project?rev=361184&view=rev Log: [CMake] Update DistributionExample for mono repo This just updates the DistributionExamples from my 2016 Dev Meeting talk to work more seamlessly with the monor

[PATCH] D61974: [ObjC] Fix encoding of ObjC pointer types that are pointers to typedefs

smeenai added a comment. In D61974#1508097 , @ahatanak wrote: > Delete the entire code path that tries to work around a bug in gcc. Should something be added to the release notes for this? Repository: rC Clang CHANGES SINCE LAST ACTION https://rev

[PATCH] D62156: [Sema] Diagnose addr space mismatch while constructing objects

Anastasia marked 3 inline comments as done. Anastasia added inline comments. Comment at: lib/Sema/SemaInit.cpp:3771 else { - // C++ [over.match.copy]p1: - // - When initializing a temporary to be bound to the first parameter - // of a constructor [for ty

[PATCH] D62156: [Sema] Diagnose addr space mismatch while constructing objects

Anastasia created this revision. Anastasia added a reviewer: rjmccall. Herald added a subscriber: ebevhan. Anastasia edited the summary of this revision. Anastasia marked 3 inline comments as done. Anastasia added inline comments. Comment at: lib/Sema/SemaInit.cpp:3771 else

[PATCH] D59988: [PR41276] Generate address space cast of 'this' for objects attributed by an address space in C++

Anastasia marked an inline comment as done. Anastasia added inline comments. Comment at: test/CodeGenCXX/address-space-of-this.cpp:9 +//CHECK: call void @_ZN6MyTypeC1Ei(%struct.MyType* addrspacecast (%struct.MyType addrspace(10)* @m to %struct.MyType*), i32 123) +MyType __attrib

Re: r360109 - Recommit r359859 "[Attribute/Diagnostics] Print macro if definition is an attribute declaration"

Hello, it seems this broke building some iOS programs. $ cat test.m # define UI_APPEARANCE_SELECTOR __attribute__((annotate("ui_appearance_selector"))) @class UIColor; @interface Test @property(null_resettable, nonatomic, strong) UIColor *onTintColor UI_APPEARANCE_SELECTOR; @end @implementatio

r361187 - [X86] Check the alignment argument for the masked.load/store for the _mm_mask_store_ss/sd and _mm_mask(z)_load_ss/sd intrinsics.

Author: ctopper Date: Mon May 20 11:48:31 2019 New Revision: 361187 URL: http://llvm.org/viewvc/llvm-project?rev=361187&view=rev Log: [X86] Check the alignment argument for the masked.load/store for the _mm_mask_store_ss/sd and _mm_mask(z)_load_ss/sd intrinsics. Modified: cfe/trunk/test/Code

[PATCH] D62152: [ARM][AArch64] Fix incorrect handling of alignment in va_arg code generation

efriedma added a comment. Please verify my understanding of the following is correct: 1. getTypeUnadjustedAlign() is currently only used to compute calling convention alignment for ARM and AArch64. 2. Without this patch, we use the unadjusted alignment to pass arguments, but the adjusted alignm

[PATCH] D59887: [Syntax] Introduce TokenBuffer, start clangToolingSyntax library

thakis added a comment. Out of interest: The RecursiveASTVisitorTests are part of the ToolingTests binary while this adds a new binary TokensTest. Can you say why? (No change needed, just curious.) Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59887/new/ https:

[PATCH] D59887: [Syntax] Introduce TokenBuffer, start clangToolingSyntax library

thakis added a comment. Another comment: The new binary is called TokensTest but is in a directory "Syntax". For consistency with all other unit test binaries, please either rename the binary to SyntaxTests, or rename the directory to "Tokens". (From the patch description, the former seems more

[PATCH] D62157: Remove explicit header-filter in run_clang_tidy.py

juliehockett created this revision. juliehockett added reviewers: alexfh, hokein. juliehockett added a project: clang-tools-extra. This removes the else clause that adds a default `-header-filter` flag to clang-tidy invocations from the run_clang_tidy.py script. If this clause is present, any He

[PATCH] D58418: [clang][DirectoryWatcher] Upstream DirectoryWatcher

jkorous marked 2 inline comments as done. jkorous added a comment. Thanks for taking a look @gribozavr! I briefly scanned the rest of your comments and I agree with you (or don't really have a strong opinion) in all cases. I'll work on that today. Comment at: clang/lib/Direct

[PATCH] D62156: [Sema] Diagnose addr space mismatch while constructing objects

rjmccall added inline comments. Comment at: lib/Sema/SemaDeclCXX.cpp:8229 + if (FTI.hasMethodTypeCVRUQualifiers()) { +FTI.MethodQualifiers->forEachCVRUQualifier( [&](DeclSpec::TQ TypeQual, StringRef QualName, SourceLocation SL) { We want to catch `_

[PATCH] D62009: [clang] perform semantic checking in constant context

rsmith added a comment. In D62009#1506415 , @Tyker wrote: > there are issues with using ConstantExpr to mark expressions as constant for > semantic checking: > > - #1 multpile Expr::Ignore* operation remove ConstantExpr from the expression. `Ignore*` is

[PATCH] D61865: [clangd] improve help message for limit-results

umanwizard added a comment. Ping. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61865/new/ https://reviews.llvm.org/D61865 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/

[PATCH] D62065: Move dump method implementations to their respective class files

aaron.ballman added inline comments. Comment at: lib/AST/Comment.cpp:378-380 +LLVM_DUMP_METHOD void Comment::dump() const { + dump(llvm::errs(), nullptr, nullptr); +} If we're moving things around, is there a reason we should keep this in a source file as oppos

  1   2   >