[PATCH] D62005: [libunwind] [test] Fix inferring source paths

mgorny marked 2 inline comments as done. mgorny added inline comments. Comment at: libunwind/test/libunwind/test/config.py:27 +self.libcxx_src_root = (self.get_lit_conf('libcxx_src_root') +or os.path.join(self.libunwind_src_root, '../libcxx'))

[PATCH] D62005: [libunwind] [test] Fix inferring source paths

This revision was automatically updated to reflect the committed changes. mgorny marked an inline comment as done. Closed by commit rL361931: [libunwind] [test] Fix inferring source paths (authored by mgorny, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits.

[libunwind] r361931 - [libunwind] [test] Fix inferring source paths

Author: mgorny Date: Wed May 29 00:20:30 2019 New Revision: 361931 URL: http://llvm.org/viewvc/llvm-project?rev=361931=rev Log: [libunwind] [test] Fix inferring source paths Fix two issues that caused libcxx source path not to be inferred correctly when not specified explicitly: 1.

[PATCH] D62571: Implement codegen for MSVC unions with reference members

domdom created this revision. domdom added a reviewer: asl. Herald added a project: clang. Herald added a subscriber: cfe-commits. Currently, clang accepts a union with a reference member when given the -fms-extensions flag. This change fixes the codegen for this case. Repository: rC Clang

[PATCH] D60499: [ASTImporter] Various source location and range import fixes.

balazske added a comment. There is a test for the SourceLocation import in https://reviews.llvm.org/D60463 (after this patch is applied that test should not fail and the "return" statement is to be removed). Repository: rC Clang CHANGES SINCE LAST ACTION

[PATCH] D62009: [clang] perform semantic checking in constant context

Tyker added a comment. @rsmith friendly ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62009/new/ https://reviews.llvm.org/D62009 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D61923: [GWP-ASan] Mutex implementation [2].

morehouse added inline comments. Comment at: compiler-rt/lib/gwp_asan/tests/driver.cpp:14 + return RUN_ALL_TESTS(); +} hctim wrote: > morehouse wrote: > > Can we just link with gtest_main instead of having this? > Unfortunately not easily.

[PATCH] D62638: [analyzer] A Python script to prettify the ExplodedGraph dumps.

NoQ updated this revision to Diff 202092. NoQ added a comment. Remove outdated comment. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62638/new/ https://reviews.llvm.org/D62638 Files: clang/test/Analysis/exploded-graph-rewriter/edge.dot

[PATCH] D62638: [analyzer][WIP] A Python script to prettify the ExplodedGraph dumps.

NoQ updated this revision to Diff 202091. NoQ added a comment. Abstract away raw prints. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62638/new/ https://reviews.llvm.org/D62638 Files: clang/test/Analysis/exploded-graph-rewriter/edge.dot

[libunwind] r362057 - [runtimes] Use -Wunknown-pragmas for the pragma check

Author: phosek Date: Wed May 29 22:38:06 2019 New Revision: 362057 URL: http://llvm.org/viewvc/llvm-project?rev=362057=rev Log: [runtimes] Use -Wunknown-pragmas for the pragma check This is a follow up to r362055, we need -Wunknown-pragmas otherwise the check is going to succeed it the pragma

r362045 - clang support gnu asm goto.

Author: jyu2 Date: Wed May 29 18:05:46 2019 New Revision: 362045 URL: http://llvm.org/viewvc/llvm-project?rev=362045=rev Log: clang support gnu asm goto. Syntax: asm [volatile] goto ( AssemblerTemplate : : InputOperands :

[PATCH] D62638: [analyzer] A Python script to prettify the ExplodedGraph dumps.

NoQ added a comment. > I wrote some tests but i'm not really sure they're worth it. Mmm, on second thought, they probably won't work out of the box, because they might require installing python modules in order to work. I'm actually not sure if all machines have python3. I'll try but it'll

[PATCH] D62509: [Driver] Render target options (e.g. -fuse-init-array) for -fembed-bitcode

This revision was automatically updated to reflect the committed changes. Closed by commit rC362052: [Driver] Render target options (e.g. -fuse-init-array) for -fembed-bitcode (authored by MaskRay, committed by ). Changed prior to commit: https://reviews.llvm.org/D62509?vs=202103=202105#toc

[PATCH] D62045: Revise the google-objc-global-variable-declaration check to match the style guide.

stephanemoore accepted this revision. stephanemoore marked an inline comment as done. stephanemoore added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/test/clang-tidy/google-objc-global-variable-declaration.m:46 +//

r362054 - Add the `objc_class_stub` attribute.

Author: rjmccall Date: Wed May 29 21:09:01 2019 New Revision: 362054 URL: http://llvm.org/viewvc/llvm-project?rev=362054=rev Log: Add the `objc_class_stub` attribute. Swift requires certain classes to be not just initialized lazily on first use, but actually allocated lazily using information

[PATCH] D62638: [analyzer][WIP] A Python script to prettify the ExplodedGraph dumps.

NoQ created this revision. NoQ added reviewers: dcoughlin, xazax.hun, a_sidorin, rnkovacs, Szelethus, baloghadamsoftware, Charusso, george.karpenkov. Herald added subscribers: cfe-commits, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, szepet. Herald added a project: clang. That's my attempt

[PATCH] D62619: [analyzer][Dominators] Add a control dependency tree builder + a new debug checker

Szelethus added a comment. I seem to have made good progress on this, although it did require a lot of code changes on LLVM side (basically turning `BasicBlock *` to template arguments). Here's a sample: // <-- //

r362051 - [PowerPC] Set the default PLT mode on musl to Secure PLT

Author: maskray Date: Wed May 29 19:13:15 2019 New Revision: 362051 URL: http://llvm.org/viewvc/llvm-project?rev=362051=rev Log: [PowerPC] Set the default PLT mode on musl to Secure PLT The musl libc only supports Secure PLT. Patch by A. Wilcox! Reviewed By: jhibbits Differential Revision:

[PATCH] D62584: [OpenCL][PR42033] Deducing addr space of pointer/reference with template parameter types

rjmccall added a comment. I think the right approach here is probably to make sure you're applying deduction during instantiation as well. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62584/new/ https://reviews.llvm.org/D62584 ___

[PATCH] D62645: [Sema] Resolve placeholder types before type deduction to silence spurious `-Warc-repeated-use-of-weak` warnings

ahatanak created this revision. ahatanak added reviewers: rsmith, rjmccall. ahatanak added a project: clang. Herald added subscribers: dexonsmith, jkorous. The spurious `-Warc-repeated-use-of-weak` warnings are issued when an initializer expression uses a weak ObjC pointer. My first attempt to

[libunwind] r362048 - [runtimes] Support ELF dependent libraries feature

Author: phosek Date: Wed May 29 18:34:41 2019 New Revision: 362048 URL: http://llvm.org/viewvc/llvm-project?rev=362048=rev Log: [runtimes] Support ELF dependent libraries feature As of r360984, LLD supports dependent libraries feature for ELF. libunwind, libc++abi and libc++ have library

[PATCH] D62299: [PR41567][Sema] Fixed cast kind in addr space conversions

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Seems reasonable. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62299/new/ https://reviews.llvm.org/D62299 ___ cfe-commits mailing

[libunwind] r362055 - [runtimes] Check if pragma comment(lib, ...) is supported first

Author: phosek Date: Wed May 29 21:40:21 2019 New Revision: 362055 URL: http://llvm.org/viewvc/llvm-project?rev=362055=rev Log: [runtimes] Check if pragma comment(lib, ...) is supported first This fixes the issue introduced by r362048 where we always use pragma comment(lib, ...) for dependent

[PATCH] D59628: Add support for __attribute__((objc_class_stub))

slavapestov updated this revision to Diff 202084. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59628/new/ https://reviews.llvm.org/D59628 Files: clang/include/clang/Basic/Attr.td clang/include/clang/Basic/AttrDocs.td clang/include/clang/Basic/DiagnosticSemaKinds.td

[PATCH] D59628: Add support for __attribute__((objc_class_stub))

slavapestov marked 2 inline comments as done. slavapestov added inline comments. Comment at: clang/include/clang/Basic/Attr.td:297 def CUDA : LangOpt<"CUDA">; -def COnly : LangOpt<"CPlusPlus", 1>; +def COnly : LangOpt<"COnly", "!LangOpts.CPlusPlus">; def CPlusPlus :

[PATCH] D58321: Support for relative vtables

rjmccall added inline comments. Comment at: clang/include/clang/Basic/LangOptions.def:329 +"Whether to use clang's relative C++ ABI " +"for classes with vtables") + leonardchan wrote: > rjmccall wrote: > > Yeah, see, this plays into the question

[PATCH] D62643: [CodeGen][ObjC] Convert '[self alloc]' in a class method to 'objc_alloc(self)'

ahatanak created this revision. ahatanak added reviewers: rjmccall, pete, erik.pilkington. ahatanak added a project: clang. Herald added subscribers: dexonsmith, jkorous. In a class method, 'self' points to the class object, so it should be safe to pass it to `objc_alloc`. Also, convert '[[self

[PATCH] D62643: [CodeGen][ObjC] Convert '[self alloc]' in a class method to 'objc_alloc(self)'

rjmccall added inline comments. Comment at: lib/CodeGen/CGObjC.cpp:376 + bool isClassMessage, + bool isSelfReceiverInClassMethod) { auto = CGF.CGM; I think it's fine to just call this a class

[PATCH] D62645: [Sema] Resolve placeholder types before type deduction to silence spurious `-Warc-repeated-use-of-weak` warnings

rjmccall added inline comments. Comment at: lib/Sema/SemaDecl.cpp:11101 + if (auto *placeholderType = Init->getType()->getAsPlaceholderType()) +if (placeholderType->getKind() == BuiltinType::PseudoObject) { + Res = CheckPlaceholderExpr(Init).get();

[PATCH] D62623: Reduce memory consumption of coverage dumps

kwk added a comment. In D62623#1521999 , @kwk wrote: > @serge-sans-paille testing it now. Unfortunately, the error for me is similar (or the same) to before; [692/2860] Building CXX object

[PATCH] D62622: [CMake] Provide an option to use relative paths in debug info

phosek added a comment. In D62622#1522247 , @aprantl wrote: > -DLLVM_USE_RELATIVE_PATHS is very generic sounding and might give a false > impression. Is there a name that emphasizes that this affects the debug info > of the built compiler? How about

[PATCH] D62638: [analyzer] A Python script to prettify the ExplodedGraph dumps.

NoQ updated this revision to Diff 202094. NoQ added a comment. Use `os.path.join` for discovering the utility in tests. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62638/new/ https://reviews.llvm.org/D62638 Files: clang/test/Analysis/exploded-graph-rewriter/edge.dot

[PATCH] D62606: [Driver] -static-pie: add -z text

This revision was automatically updated to reflect the committed changes. Closed by commit rL362050: [Driver] -static-pie: add -z text (authored by MaskRay, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINCE LAST ACTION

r362050 - [Driver] -static-pie: add -z text

Author: maskray Date: Wed May 29 18:55:43 2019 New Revision: 362050 URL: http://llvm.org/viewvc/llvm-project?rev=362050=rev Log: [Driver] -static-pie: add -z text This matches gcc -static-pie. The intention is to prevent dynamic relocations in read-only segments. In ld.bfd and gold, -z notext

[PATCH] D62619: [analyzer][Dominators] Add a control dependency tree builder + a new debug checker

Szelethus added a comment. Also, I read some of the article you showed as well as the one I found on the dominance frontier file documentation[1], and I feel a lot more enlightened about the subject, thanks! I'll spend more time on them before wrapping this up. [1] Sreedhar and Gao. A linear

[PATCH] D59185: [PowerPC] Set the default PLT mode on musl to Secure PLT

This revision was automatically updated to reflect the committed changes. Closed by commit rL362051: [PowerPC] Set the default PLT mode on musl to Secure PLT (authored by MaskRay, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

r362052 - [Driver] Render target options (e.g. -fuse-init-array) for -fembed-bitcode

Author: maskray Date: Wed May 29 19:30:04 2019 New Revision: 362052 URL: http://llvm.org/viewvc/llvm-project?rev=362052=rev Log: [Driver] Render target options (e.g. -fuse-init-array) for -fembed-bitcode Modern ELF platforms use -fuse-init-array to emit .init_array instead of .ctors . ld.bfd

[PATCH] D62509: [Driver] Render target options (e.g. -fuse-init-array) for -fembed-bitcode

MaskRay updated this revision to Diff 202103. MaskRay retitled this revision from "[Driver] Render -fuse-init-array for -fembed-bitcode" to "[Driver] Render target options (e.g. -fuse-init-array) for -fembed-bitcode". MaskRay edited the summary of this revision. MaskRay added a comment. Add

Re: r350917 - [Sema] If CheckPlaceholderExpr rewrites the initializer of an auto

Hi Richard, Thank you for the feedback. Please review my new patch: https://reviews.llvm.org/D62645 . > On Apr 23, 2019, at 7:21 PM, Richard Smith wrote: > > Hi Akira, > > I've reverted this in r359066. This subtly breaks the semantics of C++ > initializers

[PATCH] D60499: [ASTImporter] Various source location and range import fixes.

balazske marked 3 inline comments as done. balazske added inline comments. Comment at: lib/AST/ASTImporter.cpp:6129 if (Error Err = -ImportTemplateArgumentListInfo(E->template_arguments(), ToTAInfo)) +ImportTemplateArgumentListInfo(E->getLAngleLoc(),

[PATCH] D61601: [clangd] Represent Hover result using FormattedString

ilya-biryukov added a comment. This is ready for review now Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61601/new/ https://reviews.llvm.org/D61601 ___ cfe-commits mailing list

[PATCH] D61601: [clangd] Represent Hover result using FormattedString

ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/XRefs.cpp:1170 else if (NamespaceScope->empty()) - Out << "global namespace"; + Output.appendText(" global namespace"); else kadircet wrote: > Should this also be

[PATCH] D37035: Implement __builtin_LINE() et. al. to support source location capture.

uweigand added a comment. As of r361920, the SystemZ build bots are green again. Thanks, Eric! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D37035/new/ https://reviews.llvm.org/D37035 ___ cfe-commits mailing list

[PATCH] D62573: [Index] Correctly set symbol kind of IndirectFieldDecl

ilya-biryukov created this revision. ilya-biryukov added a reviewer: kadircet. Herald added subscribers: arphaman, jkorous. Herald added a project: clang. The kind has been 'unknown' before, now it is 'field'. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D62573 Files:

r361937 - Fix test added in r361903 to work on Windows.

Author: dyung Date: Wed May 29 02:20:01 2019 New Revision: 361937 URL: http://llvm.org/viewvc/llvm-project?rev=361937=rev Log: Fix test added in r361903 to work on Windows. Modified: cfe/trunk/test/Driver/print-file-name.c Modified: cfe/trunk/test/Driver/print-file-name.c URL:

[PATCH] D61601: [clangd] Represent Hover result using FormattedString

ilya-biryukov updated this revision to Diff 201844. ilya-biryukov added a comment. - Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61601/new/ https://reviews.llvm.org/D61601 Files: clang-tools-extra/clangd/ClangdLSPServer.cpp

[PATCH] D61601: [clangd] Represent Hover result using FormattedString

kadircet added a comment. Ping, D61497 has landed Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61601/new/ https://reviews.llvm.org/D61601 ___ cfe-commits mailing

[PATCH] D62573: [Index] Correctly set symbol kind of IndirectFieldDecl

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. LGTM thanks! Do you think it would be beneficial to add some logging for the default case of that switch statement ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D61601: [clangd] Represent Hover result using FormattedString

This revision was automatically updated to reflect the committed changes. Closed by commit rL361940: [clangd] Represent Hover result using FormattedString (authored by ibiryukov, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[clang-tools-extra] r361941 - [Index] Correctly set symbol kind of IndirectFieldDecl

Author: ibiryukov Date: Wed May 29 03:11:14 2019 New Revision: 361941 URL: http://llvm.org/viewvc/llvm-project?rev=361941=rev Log: [Index] Correctly set symbol kind of IndirectFieldDecl Summary: The kind has been 'unknown' before, now it is 'field'. Reviewers: kadircet Reviewed By: kadircet

r361941 - [Index] Correctly set symbol kind of IndirectFieldDecl

Author: ibiryukov Date: Wed May 29 03:11:14 2019 New Revision: 361941 URL: http://llvm.org/viewvc/llvm-project?rev=361941=rev Log: [Index] Correctly set symbol kind of IndirectFieldDecl Summary: The kind has been 'unknown' before, now it is 'field'. Reviewers: kadircet Reviewed By: kadircet

[PATCH] D62573: [Index] Correctly set symbol kind of IndirectFieldDecl

ilya-biryukov added a comment. In D62573#1520641 , @kadircet wrote: > Do you think it would be beneficial to add some logging for the default case > of that switch statement ? We should replace `default` with all cases it covers to make sure we get a

[PATCH] D62573: [Index] Correctly set symbol kind of IndirectFieldDecl

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE361941: [Index] Correctly set symbol kind of IndirectFieldDecl (authored by ibiryukov, committed by ). Changed prior to commit: https://reviews.llvm.org/D62573?vs=201837=201851#toc Repository:

RE: [PATCH] D62483: [CUDA][HIP] Emit dependent libs for host only

Fixed by 361905. Sam -Original Message- From: Petr Hosek via Phabricator Sent: Tuesday, May 28, 2019 9:54 PM To: Liu, Yaxun (Sam) ; t...@google.com Cc: pho...@google.com; cfe-commits@lists.llvm.org; mlek...@skidmore.edu; blitzrak...@gmail.com; shen...@google.com; jle...@google.com;

[PATCH] D60748: Fix i386 struct and union parameter alignment

This revision was automatically updated to reflect the committed changes. Closed by commit rC361934: [X86] Fix i386 struct and union parameter alignment (authored by pengfei, committed by ). Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60748/new/

[clang-tools-extra] r361940 - [clangd] Represent Hover result using FormattedString

Author: ibiryukov Date: Wed May 29 03:01:00 2019 New Revision: 361940 URL: http://llvm.org/viewvc/llvm-project?rev=361940=rev Log: [clangd] Represent Hover result using FormattedString Reviewers: sammccall, kadircet Reviewed By: kadircet Subscribers: MaskRay, jkorous, arphaman, kadircet,

[PATCH] D60748: Fix i386 struct and union parameter alignment

krytarowski added subscribers: mgorny, joerg. krytarowski added inline comments. Comment at: lib/CodeGen/TargetInfo.cpp:1501 +// +// Exclude other System V OS (e.g Darwin, PS4 and FreeBSD) since we don't +// want to spend any effort dealing with the ramifications of

[PATCH] D61601: [clangd] Represent Hover result using FormattedString

ilya-biryukov updated this revision to Diff 201847. ilya-biryukov marked 2 inline comments as done. ilya-biryukov added a comment. - Create an inline code block for 'global namespace' too Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61601/new/

[PATCH] D62574: Initial draft of target-configurable address spaces.

ebevhan created this revision. ebevhan added reviewers: Anastasia, rjmccall. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is an initial draft of the support for target-configurable address spaces. Original RFC:

[PATCH] D62575: [clangd] Another improvement for std include mapping.

hokein created this revision. hokein added a reviewer: sammccall. Herald added subscribers: kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Improve the way of checking a symbol name is in the first cell. The previous way is not very robost for cases where a

r361974 - [CodeComplete] Add semicolon when completing patterns for 'static_assert' and 'typedef

Author: ibiryukov Date: Wed May 29 08:32:17 2019 New Revision: 361974 URL: http://llvm.org/viewvc/llvm-project?rev=361974=rev Log: [CodeComplete] Add semicolon when completing patterns for 'static_assert' and 'typedef This is a trivial follow-up to r360042, which added semicolons to other

[PATCH] D37813: clang-format: better handle namespace macros

Typz updated this revision to Diff 201936. Typz marked an inline comment as done. Typz added a comment. - Rebase - Fix NamespaceEndCommentsFixerTest to match LLVM indent style Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D37813/new/

[PATCH] D62580: [OpenCL] Use long instead of long long in x86 builtins

erichkeane added a comment. 'O' is an interesting choice. Any real justification for it, or just "what was available"? It definitely needs to be documented in the top of Builtins.def however. Comment at: clang/lib/AST/ASTContext.cpp:9362 +case 'O': +

[PATCH] D62335: [OpenCL][PR41963] Add overloads of old atomics with generic pointer type in C++ mode

svenvh accepted this revision. svenvh added a comment. This revision is now accepted and ready to land. LGTM, please address style issue before committing. Comment at: test/Headers/opencl-c-header.cl:79 +{ +atomic_add(a, 1); +} Probably better to follow

[PATCH] D62580: [OpenCL] Use long instead of long long in x86 builtins

erichkeane added a comment. A different (perhaps silly) question is why 'W' isn't sufficient? It represents int64_t, which I wonder if is sufficient. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62580/new/ https://reviews.llvm.org/D62580

r361979 - [analyzer] print() JSONify: Type information implementation

Author: charusso Date: Wed May 29 08:53:12 2019 New Revision: 361979 URL: http://llvm.org/viewvc/llvm-project?rev=361979=rev Log: [analyzer] print() JSONify: Type information implementation Summary: - Reviewers: NoQ, xazax.hun, ravikandhadai, baloghadamsoftware, Szelethus Reviewed By: NoQ

[PATCH] D62582: [CodeComplete] Improve overload handling for C++ qualified and ref-qualified methods.

ilya-biryukov added inline comments. Comment at: lib/Sema/SemaCodeComplete.cpp:1300 +auto = +OverloadMap[std::make_pair(CurContext, Method->getName())]; +for (const DeclIndexPair& Entry : OverloadSet) { Won't this crash on

[PATCH] D62606: [Driver] -static-pie: add -z text

MaskRay created this revision. MaskRay added reviewers: saugustine, sivachandra. Herald added a project: clang. Herald added a subscriber: cfe-commits. gcc -static-pie adds -z text. In ld.bfd and gold, default/-z text/-z notext are tri-state. By default, text relocations (and DF_TEXTREL) are

[PATCH] D61974: [ObjC] Fix encoding of ObjC pointer types that are pointers to typedefs

theraven accepted this revision. theraven added a comment. This revision is now accepted and ready to land. LGTM. I wonder if we have any other ugly GCC bug compatibility parts in clang's Objective-C implementation... Repository: rC Clang CHANGES SINCE LAST ACTION

[PATCH] D61912: [analyzer] print() JSONify: Store implementation

Charusso added a comment. Hey @lebedev.ri, thanks for the review! In D61912#1521306 , @lebedev.ri wrote: > All these patches bypassed cfe-commits. Bypassed? It is only added when you push your stuff, which is happened as expected. > Why does this

[PATCH] D62087: [analyzer] print() JSONify: Program state implementation

This revision was automatically updated to reflect the committed changes. Closed by commit rC361983: [analyzer] print() JSONify: Program state implementation (authored by Charusso, committed by ). Herald added a subscriber: cfe-commits. Changed prior to commit:

[PATCH] D62509: [Driver] Render -fuse-init-array for -fembed-bitcode

compnerd accepted this revision. compnerd added a comment. This revision is now accepted and ready to land. Sounds safe enough to me. I think that it would be nice to add a test that checks the hexagon flags as well. Repository: rC Clang CHANGES SINCE LAST ACTION

[PATCH] D37813: clang-format: better handle namespace macros

Typz marked 2 inline comments as done. Typz added inline comments. Comment at: unittests/Format/NamespaceEndCommentsFixerTest.cpp:526 EXPECT_EQ("namespace A {\n" " int i;\n" "} // namespace A", klimek wrote: > Typz wrote: > > Should

[PATCH] D61912: [analyzer] print() JSONify: Store implementation

lebedev.ri added a comment. In D61912#1521352 , @Charusso wrote: > Hey @lebedev.ri, thanks for the review! > > In D61912#1521306 , @lebedev.ri > wrote: > > > All these patches bypassed cfe-commits. > > > Bypassed?

r361986 - [clang-format] Allow configuring list of function-like macros that resolve to a type

Author: typz Date: Wed May 29 09:30:47 2019 New Revision: 361986 URL: http://llvm.org/viewvc/llvm-project?rev=361986=rev Log: [clang-format] Allow configuring list of function-like macros that resolve to a type Summary: Adds a `TypenameMacros` configuration option that causes certain

[PATCH] D59673: [Clang] Harmonize Split DWARF options with llc

dblaikie added a comment. Might be easier as a few patches - renaming the existing option, adding the new one, then removing the single split dwarf flag handling in favor of implying that by the absence of an output file name. (if I'm reading what this patch does) Comment

[PATCH] D61912: [analyzer] print() JSONify: Store implementation

Charusso added a comment. >> In D61912#1521306 , @lebedev.ri >> wrote: >> >>> All these patches bypassed cfe-commits. >> >> >> Bypassed? It is only added when you push your stuff, which is happened as >> expected. > > That is pretty much the opposite

[PATCH] D61601: [clangd] Represent Hover result using FormattedString

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. LGTM, thanks! Comment at: clang-tools-extra/clangd/XRefs.cpp:1170 else if (NamespaceScope->empty()) - Out << "global namespace"; + Output.appendText("

[PATCH] D62579: [Index] Compute correct symbol kind for variable templates

ilya-biryukov added inline comments. Comment at: clang/lib/Index/IndexSymbol.cpp:99 + if (auto *VT = dyn_cast(D)) { +Info.Properties |= (SymbolPropertySet)SymbolProperty::Generic; kadircet wrote: > what about function and class templates? Are they handled

[PATCH] D61912: [analyzer] print() JSONify: Store implementation

This revision was automatically updated to reflect the committed changes. Closed by commit rC361972: [analyzer] print() JSONify: Store implementation (authored by Charusso, committed by ). Herald added a subscriber: cfe-commits. Changed prior to commit:

r361978 - [analyzer] print() JSONify: Constraints implementation

Author: charusso Date: Wed May 29 08:43:26 2019 New Revision: 361978 URL: http://llvm.org/viewvc/llvm-project?rev=361978=rev Log: [analyzer] print() JSONify: Constraints implementation Summary: - Reviewers: NoQ, xazax.hun, ravikandhadai, baloghadamsoftware, Szelethus Reviewed By: NoQ

r361980 - [analyzer] print() JSONify: Constructing objects implementation

Author: charusso Date: Wed May 29 08:58:26 2019 New Revision: 361980 URL: http://llvm.org/viewvc/llvm-project?rev=361980=rev Log: [analyzer] print() JSONify: Constructing objects implementation Summary: - Reviewers: NoQ, xazax.hun, ravikandhadai, baloghadamsoftware, Szelethus Reviewed By: NoQ

[PATCH] D57184: [clang-format] Allow configuring list of function-like macros that resolve to a type

This revision was automatically updated to reflect the committed changes. Closed by commit rC361986: [clang-format] Allow configuring list of function-like macros that resolve to a… (authored by Typz, committed by ). Changed prior to commit: https://reviews.llvm.org/D57184?vs=201395=201962#toc

[PATCH] D62045: Revise the google-objc-global-variable-declaration check to match the style guide.

yaqiji updated this revision to Diff 201968. yaqiji added a comment. Updated warning Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62045/new/ https://reviews.llvm.org/D62045 Files:

[PATCH] D62085: [analyzer] print() JSONify: Constructing objects implementation

This revision was automatically updated to reflect the committed changes. Closed by commit rC361980: [analyzer] print() JSONify: Constructing objects implementation (authored by Charusso, committed by ). Herald added a subscriber: cfe-commits. Changed prior to commit:

[PATCH] D61912: [analyzer] print() JSONify: Store implementation

lebedev.ri added a comment. All these patches bypassed cfe-commits. Why does this invent a yet another json formatter instead of using `"llvm/Support/JSON.h"`, in particular it's lightweight `json::OStream` ? Repository: rC Clang CHANGES SINCE LAST ACTION

[PATCH] D62603: [CUDA][HIP] Skip setting `externally_initialized` for static device variables.

yaxunl added a comment. LGTM. The externally initializable attribute causes some optimizations disabled. For static device variables it seems reasonable to remove the externaly initializable attribute. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

r361984 - [NFC] clang-format: Use LLVM style in NamespaceEndCommentsFixerTest

Author: typz Date: Wed May 29 09:22:43 2019 New Revision: 361984 URL: http://llvm.org/viewvc/llvm-project?rev=361984=rev Log: [NFC] clang-format: Use LLVM style in NamespaceEndCommentsFixerTest As pointed out in https://reviews.llvm.org/D37813#inline-555026, the code which is formatted does not

r361983 - [analyzer] print() JSONify: Program state implementation

Author: charusso Date: Wed May 29 09:22:21 2019 New Revision: 361983 URL: http://llvm.org/viewvc/llvm-project?rev=361983=rev Log: [analyzer] print() JSONify: Program state implementation Summary: - Reviewers: NoQ, xazax.hun, ravikandhadai, baloghadamsoftware, Szelethus Reviewed By: NoQ

r361967 - [mips] Check argument for __builtin_msa_ctcmsa / __builtin_msa_cfcmsa

Author: atanasyan Date: Wed May 29 07:59:32 2019 New Revision: 361967 URL: http://llvm.org/viewvc/llvm-project?rev=361967=rev Log: [mips] Check argument for __builtin_msa_ctcmsa / __builtin_msa_cfcmsa The `__builtin_msa_ctcmsa` and `__builtin_msa_cfcmsa` builtins are mapped to the `ctcmsa` and

[clang-tools-extra] r361969 - [clangd] Map typedefs to the same LSP completion kind as VSCode

Author: ibiryukov Date: Wed May 29 08:10:19 2019 New Revision: 361969 URL: http://llvm.org/viewvc/llvm-project?rev=361969=rev Log: [clangd] Map typedefs to the same LSP completion kind as VSCode For consistency and, more importantly, to get a nicer icon for those in VSCode. Modified:

r361972 - [analyzer] print() JSONify: Store implementation

Author: charusso Date: Wed May 29 08:25:19 2019 New Revision: 361972 URL: http://llvm.org/viewvc/llvm-project?rev=361972=rev Log: [analyzer] print() JSONify: Store implementation Summary: - Reviewers: NoQ, xazax.hun, ravikandhadai, baloghadamsoftware, Szelethus Reviewed By: NoQ Subscribers:

r361976 - [analyzer] print() JSONify: Environment implementation

Author: charusso Date: Wed May 29 08:36:58 2019 New Revision: 361976 URL: http://llvm.org/viewvc/llvm-project?rev=361976=rev Log: [analyzer] print() JSONify: Environment implementation Summary: - Reviewers: NoQ, xazax.hun, ravikandhadai, baloghadamsoftware, Szelethus Reviewed By: NoQ

[PATCH] D62603: [CUDA][HIP] Skip setting `externally_initialized` for static device variables.

hliao created this revision. hliao added a reviewer: yaxunl. Herald added a project: clang. Herald added a subscriber: cfe-commits. - By declaring device variables as `static`, we assume they won't be addressable from the host side. Thus, no `externally_initialized` is required. Repository:

[PATCH] D62082: [analyzer] print() JSONify: Constraints implementation

This revision was automatically updated to reflect the committed changes. Closed by commit rC361978: [analyzer] print() JSONify: Constraints implementation (authored by Charusso, committed by ). Herald added a subscriber: cfe-commits. Changed prior to commit:

[PATCH] D62459: [clangd] Serialization support for RelationSlab

nridge marked an inline comment as done. nridge added inline comments. Comment at: clang-tools-extra/clangd/index/Serialization.h:81 +// Used for serializing SymbolRole as used in Relation. +enum class RelationKind : uint8_t { ChildOf = 1, BaseOf }; +llvm::Expected

r361982 - [analyzer] print() JSONify: Checker messages implementation

Author: charusso Date: Wed May 29 09:02:33 2019 New Revision: 361982 URL: http://llvm.org/viewvc/llvm-project?rev=361982=rev Log: [analyzer] print() JSONify: Checker messages implementation Summary: - Reviewers: NoQ, xazax.hun, ravikandhadai, baloghadamsoftware, Szelethus Reviewed By: NoQ

[PATCH] D62527: [clangd] Remove the whitelist std symbols in CanonicalIncludes.

hokein updated this revision to Diff 201869. hokein added a comment. Remove more symbols. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62527/new/ https://reviews.llvm.org/D62527 Files: clang-tools-extra/clangd/index/CanonicalIncludes.cpp

[PATCH] D62419: [LibTooling] Add `before` and `after` selectors for selecting point-ranges relative to nodes.

This revision was automatically updated to reflect the committed changes. ymandel marked 2 inline comments as done. Closed by commit rL361955: [LibTooling] Add `before` and `after` selectors for selecting point-ranges… (authored by ymandel, committed by ). Herald added a project: LLVM. Herald

[PATCH] D62121: [PowerPC] [Clang] Port SSE intrinsics to PowerPC

jsji requested changes to this revision. jsji added a comment. This revision now requires changes to proceed. TEST 'Clang :: CodeGen/ppc-mm-malloc.c' FAILED Script: -- : 'RUN: at line 9';

  1   2   3   >