[PATCH] D62814: [clangd] Treat lambdas as functions when preparing hover response

kadircet updated this revision to Diff 202888. kadircet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62814/new/ https://reviews.llvm.org/D62814 Files: clang-tools-extra/clangd/XRefs.cpp

[PATCH] D48116: [libclang] Allow skipping warnings from all included files

nik added a comment. Ping. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D48116/new/ https://reviews.llvm.org/D48116 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D62814: [clangd] Treat lambdas as functions when preparing hover response

kadircet marked 4 inline comments as done. kadircet added inline comments. Comment at: clang-tools-extra/clangd/unittests/XRefsTests.cpp:819 )cpp", [](HoverInfo ) { HI.NamespaceScope = ""; sammccall wrote: > I'm slightly nervous about

[PATCH] D62591: [OpenCL][PR42031] Prevent deducing addr space in type alias.

mantognini accepted this revision. mantognini added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62591/new/ https://reviews.llvm.org/D62591 ___ cfe-commits mailing list

r362479 - [CodeComplete] Include more text into typed chunks of pattern completions

Author: ibiryukov Date: Tue Jun 4 02:26:08 2019 New Revision: 362479 URL: http://llvm.org/viewvc/llvm-project?rev=362479=rev Log: [CodeComplete] Include more text into typed chunks of pattern completions Summary: To allow filtering on any of the words in the editors. In particular, the

[PATCH] D61446: Generalize the pass registration mechanism used by Polly to any third-party tool

serge-sans-paille updated this revision to Diff 202908. serge-sans-paille added a comment. - reorder registration to make sure options are correctly taken into account - make LINK_POLLY_INTO_TOOLS obsolete in favor of just using LLVM_LINK_POLLY_INTO_TOOLS Repository: rG LLVM Github Monorepo

[PATCH] D62850: [X86] Fix builtins-x86.c test where it wasn't using immediates. NFC

probinson added a comment. Is the compiler missing a check that these parameters are immediates? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62850/new/ https://reviews.llvm.org/D62850 ___

[PATCH] D62476: [clangd] Support offsets for parameters in signatureHelp

This revision was automatically updated to reflect the committed changes. Closed by commit rL362481: [clangd] Support offsets for parameters in signatureHelp (authored by ibiryukov, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D61446: Generalize the pass registration mechanism used by Polly to any third-party tool

serge-sans-paille added a comment. @beanz turns out the depdendency problem was just a matter of moving the `register_llvm_extension` call at the top of the file. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61446/new/

[PATCH] D61446: Generalize the pass registration mechanism used by Polly to any third-party tool

serge-sans-paille added a comment. @philip.pfaffe : NewPM integeration actually works thanks to ``Register${Name}Passes(llvm::PassBuilder )``. It's already used by Polly for NewPM integration and we mimic that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D60763: Prototype OpenCL BIFs using Tablegen

Pierre added a comment. In D60763#1527870 , @thakis wrote: > From what I can tell, the only client of OpenCLBuiltins.td is currently > lib/Sema. Do you expect that to change? If not, does it make more sense to > move the .td file to there? > > Do you

[PATCH] D62615: [CodeComplete] Include more text into typed chunks of pattern completions

This revision was automatically updated to reflect the committed changes. Closed by commit rL362479: [CodeComplete] Include more text into typed chunks of pattern completions (authored by ibiryukov, committed by ). Herald added subscribers: llvm-commits, arphaman. Herald added a project: LLVM.

[PATCH] D62850: [X86] Fix builtins-x86.c test where it wasn't using immediates. NFC

russell.gallop created this revision. russell.gallop added reviewers: craig.topper, cfe-commits. russell.gallop added a project: clang. Some of these test cases were using a variable instead of a literal so were not generating the immediate form of the corresponding instruction. Repository:

[clang-tools-extra] r362489 - Fix Wshadow warning

Author: rksimon Date: Tue Jun 4 04:11:51 2019 New Revision: 362489 URL: http://llvm.org/viewvc/llvm-project?rev=362489=rev Log: Fix Wshadow warning Modified: clang-tools-extra/trunk/clangd/ClangdLSPServer.cpp Modified: clang-tools-extra/trunk/clangd/ClangdLSPServer.cpp URL:

[PATCH] D62855: Implementation of auto type expansion.

kuhnel created this revision. kuhnel added a reviewer: sammccall. Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, mgorny. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D62855 Files: clang-tools-extra/clangd/AST.cpp

[PATCH] D62850: [X86] Fix builtins-x86.c test where it wasn't using immediates. NFC

lebedev.ri added a comment. .. or? Is this fixing a current test failure? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62850/new/ https://reviews.llvm.org/D62850 ___ cfe-commits mailing list

[clang-tools-extra] r362491 - Fix -Wparentheses warning. NFCI.

Author: rksimon Date: Tue Jun 4 04:31:45 2019 New Revision: 362491 URL: http://llvm.org/viewvc/llvm-project?rev=362491=rev Log: Fix -Wparentheses warning. NFCI. Modified: clang-tools-extra/trunk/clangd/Protocol.cpp Modified: clang-tools-extra/trunk/clangd/Protocol.cpp URL:

Re: [clang-tools-extra] r362491 - Fix -Wparentheses warning. NFCI.

Thanks! And sorry about this in the first place, I did not have this warning enabled locally. On Tue, Jun 4, 2019 at 1:28 PM Simon Pilgrim via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: rksimon > Date: Tue Jun 4 04:31:45 2019 > New Revision: 362491 > > URL:

[PATCH] D62850: [X86] Fix builtins-x86.c test where it wasn't using immediates. NFC

russell.gallop added a comment. > .. or? I'm not sure what you mean. > Is this fixing a current test failure? No. The test is not failing, but it is not doing what was intended as these builtins are for generating the immediate form of the corresponding instruction and they were generating

[clang-tools-extra] r362481 - [clangd] Support offsets for parameters in signatureHelp

Author: ibiryukov Date: Tue Jun 4 02:36:59 2019 New Revision: 362481 URL: http://llvm.org/viewvc/llvm-project?rev=362481=rev Log: [clangd] Support offsets for parameters in signatureHelp Summary: Added to LSP in version 3.14 Reviewers: hokein Reviewed By: hokein Subscribers: MaskRay,

[PATCH] D60691: [ARM] Replace fp-only-sp and d16 with fp64 and d32.

simon_tatham marked an inline comment as done. simon_tatham added a comment. Hmm, yes, I see what you mean. It //looks// to me as if the problem is that `llvm::ARM::getFPUFeatures` is setting up a feature list including `+vfp4`, `-fp64` and `-d32` just as you'd expect, but when it's called from

[PATCH] D62814: [clangd] Treat lambdas as functions when preparing hover response

ilya-biryukov requested changes to this revision. ilya-biryukov added a comment. This revision now requires changes to proceed. Please add a check for the type of variable being not null before landing. The other comment is not very important Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D62814: [clangd] Treat lambdas as functions when preparing hover response

ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/XRefs.cpp:628 +auto QT = VD->getType(); +while (!QT->getPointeeType().isNull()) + QT = QT->getPointeeType(); We need a check for `!QT.isNull` here Comment

[PATCH] D62623: Reduce memory consumption of coverage dumps

serge-sans-paille updated this revision to Diff 202896. serge-sans-paille marked an inline comment as done. serge-sans-paille added a comment. Update comment + force reduced memory consumption. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D48866: [clang-tidy] Add incorrect-pointer-cast checker

steakhal updated this revision to Diff 202913. steakhal marked 4 inline comments as done. steakhal added a comment. - Removed different signess related parts. - Don't warn for the casts which are already covered by '-Wcast-align' check. - Improved the diagnostic messages: - Now adds notes for

[PATCH] D48866: [clang-tidy] Add incorrect-pointer-cast checker

steakhal added a comment. In D48866#1527540 , @lebedev.ri wrote: > In D48866#1527506 , @steakhal wrote: > > > The problem with the `-Wcast-align` is that it will only fire for C-style > > bitcast expressions, not

[PATCH] D54258: [Clang] Fix pretty printing of CUDA address spaces

richardmembarth added a comment. Merging in two weeks is fine for me. My assumption was that accepted patches are merged into upstream in a timely manner. Maybe this is not how it works? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54258/new/

[PATCH] D62845: [clang-tidy] Fix make-unique tests on C++2a.

hokein added a comment. In D62845#1528791 , @gribozavr wrote: > I'd suggest to add a separate file that covers the exact language modes > needed. > > The C++14 test that we have right now is about C++14-or-later, testing the > availability of

[PATCH] D62845: [clang-tidy] Fix make-unique tests on C++2a.

gribozavr added a comment. In D62845#1528887 , @hokein wrote: > In D62845#1528791 , @gribozavr wrote: > > > I'd suggest to add a separate file that covers the exact language modes > > needed. > > > > The C++14

[PATCH] D48866: [clang-tidy] Add incorrect-pointer-cast checker

steakhal marked 8 inline comments as done. steakhal added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/IncorrectPointerCastCheck.cpp:69-70 + "cast from %0 to %1 may lead to access memory based on invalid " + "memory layout; pointed to type

[PATCH] D62845: [clang-tidy] Fix make-unique tests on C++2a.

gribozavr added a comment. In D62845#1529149 , @hokein wrote: > > I think we should be looking at the intent of the test rather than its name. > > > > The intent looks like testing how the check works when `std::make_unique` > > is available from the

[PATCH] D62850: [X86] Fix builtins-x86.c test where it wasn't using immediates. NFC

russell.gallop added a comment. > Is the compiler missing a check that these parameters are immediates? I don't think that there can be a check, or this would have been noticed. I don't know whether this is possible and/or desirable. Do users use one version of the builtin and want the

[PATCH] D62845: [clang-tidy] Fix make-unique tests on C++2a.

hokein updated this revision to Diff 202940. hokein marked 2 inline comments as done. hokein added a comment. address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62845/new/ https://reviews.llvm.org/D62845 Files:

[PATCH] D62845: [clang-tidy] Fix make-unique tests on C++2a.

hokein added a comment. In D62845#1529190 , @gribozavr wrote: > In D62845#1529149 , @hokein wrote: > > > > I think we should be looking at the intent of the test rather than its > > > name. > > > > > > The intent

r362521 - [CodeGen][ObjC] Convert '[self alloc]' in a class method to a call to

Author: ahatanak Date: Tue Jun 4 09:29:58 2019 New Revision: 362521 URL: http://llvm.org/viewvc/llvm-project?rev=362521=rev Log: [CodeGen][ObjC] Convert '[self alloc]' in a class method to a call to 'objc_alloc(self)' Also convert '[[self alloc] init]' in a class method to a call to

[PATCH] D62814: [clangd] Treat lambdas as functions when preparing hover response

kadircet updated this revision to Diff 202933. kadircet marked an inline comment as done. kadircet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62814/new/ https://reviews.llvm.org/D62814 Files:

[PATCH] D62814: [clangd] Treat lambdas as functions when preparing hover response

kadircet added inline comments. Comment at: clang-tools-extra/clangd/unittests/XRefsTests.cpp:831 + }; return HI; }}, ilya-biryukov wrote: > kadircet wrote: > > ilya-biryukov wrote: > > > Could you add another test with even weirder

[PATCH] D59744: Fix i386 ABI "__m64" type bug

mgorny added a comment. In D59744#1529182 , @krytarowski wrote: > In D59744#1527412 , @wxiao3 wrote: > > > Consider other Systems (e.g Darwin, PS4 and FreeBSD) don't want to spend > > any effort dealing with the

[PATCH] D62648: [Sema][Typo] Fix assertion failure for expressions with multiple typos

dgoldman updated this revision to Diff 202938. dgoldman added a comment. - Remove unused State variable Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62648/new/ https://reviews.llvm.org/D62648 Files: lib/Sema/SemaExprCXX.cpp

[clang-tools-extra] r362352 - [clangd] Add RelationSlab

Author: nridge Date: Sun Jun 2 21:55:46 2019 New Revision: 362352 URL: http://llvm.org/viewvc/llvm-project?rev=362352=rev Log: [clangd] Add RelationSlab Summary: RelationSlab is a new index data structure that stores relations between symbols. Reviewers: kadircet Subscribers: ilya-biryukov,

[clang-tools-extra] r362353 - [clangd] Serialization support for RelationSlab

Author: nridge Date: Sun Jun 2 22:07:52 2019 New Revision: 362353 URL: http://llvm.org/viewvc/llvm-project?rev=362353=rev Log: [clangd] Serialization support for RelationSlab Summary: This builds on D59407 to provide YAML and RIFF serialization support. Reviewers: kadircet Subscribers:

[PATCH] D56571: [RFC prototype] Implementation of asm-goto support in clang

jyu2 closed this revision. jyu2 added a comment. jyu2 committed rGb8fee677bf8e : Re-check in clang support gun asm goto after fixing tests. (authored by jyu2). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56571/new/

[clang-tools-extra] r362467 - [clangd] SymbolCollector support for relations

Author: nridge Date: Mon Jun 3 21:25:44 2019 New Revision: 362467 URL: http://llvm.org/viewvc/llvm-project?rev=362467=rev Log: [clangd] SymbolCollector support for relations Summary: The only relation currently collected is RelationBaseOf, because this is all we need for type hierarchy

[PATCH] D61446: Generalize the pass registration mechanism used by Polly to any third-party tool

serge-sans-paille updated this revision to Diff 202950. serge-sans-paille added a comment. Take into account @philip.pfaffe remarks and improve support for new PM. - harmonize static/dynamic loading, although two functions are still needed, one for dynamic loading and one for static loading

[PATCH] D62643: [CodeGen][ObjC] Convert '[self alloc]' in a class method to 'objc_alloc(self)'

This revision was automatically updated to reflect the committed changes. ahatanak marked 2 inline comments as done. Closed by commit rL362521: [CodeGen][ObjC] Convert [self alloc] in a class method to a call to (authored by ahatanak, committed by ). Herald added a project: LLVM. Herald added a

[PATCH] D62845: [clang-tidy] Fix make-unique tests on C++2a.

hokein updated this revision to Diff 202922. hokein added a comment. Tests for C++2a. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62845/new/ https://reviews.llvm.org/D62845 Files:

[PATCH] D62856: [clangd] Also apply adjustArguments when returning fallback commands

kadircet created this revision. kadircet added a reviewer: ilya-biryukov. Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D62856 Files:

[PATCH] D62845: [clang-tidy] Fix make-unique tests on C++2a.

hokein added a comment. > I think we should be looking at the intent of the test rather than its name. > > The intent looks like testing how the check works when `std::make_unique` is > available from the standard library (as opposed to some kind of replacement > like `absl::make_unique`).

[PATCH] D62814: [clangd] Treat lambdas as functions when preparing hover response

ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/unittests/XRefsTests.cpp:831 + }; return HI; }}, kadircet wrote: > ilya-biryukov wrote: > > kadircet wrote: > > > ilya-biryukov wrote: > > > > Could you add

[PATCH] D48116: [libclang] Allow skipping warnings from all included files

ilya-biryukov added a comment. @jkorous, could you take a look or suggest someone who can review the libclang changes? As mentioned before, I've reviewed the clang bits (which are now gone), but don't have much experience in `libclang` parts. Repository: rC Clang CHANGES SINCE LAST ACTION

[clang-tools-extra] r362517 - [clangd] Minor cleanup. NFC

Author: ibiryukov Date: Tue Jun 4 09:19:11 2019 New Revision: 362517 URL: http://llvm.org/viewvc/llvm-project?rev=362517=rev Log: [clangd] Minor cleanup. NFC Removed unused using declaration from TweakTests.cpp Modified: clang-tools-extra/trunk/clangd/unittests/TweakTests.cpp Modified:

r362531 - PR42104: Support instantiations of lambdas that implicitly capture

Author: rsmith Date: Tue Jun 4 10:17:20 2019 New Revision: 362531 URL: http://llvm.org/viewvc/llvm-project?rev=362531=rev Log: PR42104: Support instantiations of lambdas that implicitly capture packs. Two changes: * Track odr-use via FunctionParmPackExprs to properly handle dependent

[PATCH] D62856: [clangd] Also apply adjustArguments when returning fallback commands

This revision was automatically updated to reflect the committed changes. Closed by commit rL362496: [clangd] Also apply adjustArguments when returning fallback commands (authored by kadircet, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to

[PATCH] D62638: [analyzer] A Python script to prettify the ExplodedGraph dumps.

krytarowski added a comment. This commit breaks the NetBSD buildbot node. http://lab.llvm.org:8011/builders/netbsd-amd64/builds/20359 The problem is that this patch hardcodes python specific binary name, while it has to be detected dynamically or ideally passed from CMake. Afair lit has a

[clang-tools-extra] r362496 - [clangd] Also apply adjustArguments when returning fallback commands

Author: kadircet Date: Tue Jun 4 06:38:36 2019 New Revision: 362496 URL: http://llvm.org/viewvc/llvm-project?rev=362496=rev Log: [clangd] Also apply adjustArguments when returning fallback commands Reviewers: ilya-biryukov Subscribers: MaskRay, jkorous, arphaman, cfe-commits Tags: #clang

Re: [PATCH] D54258: [Clang] Fix pretty printing of CUDA address spaces

On Tue, Jun 4, 2019 at 5:37 AM Richard Membarth via Phabricator wrote: > > richardmembarth added a comment. > > Merging in two weeks is fine for me. > > My assumption was that accepted patches are merged into upstream in a timely > manner. > Maybe this is not how it works? Your assumption is

[PATCH] D62850: [X86] Fix builtins-x86.c test where it wasn't using immediates. NFC

craig.topper added a comment. We support non immediate on these because gcc does. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62850/new/ https://reviews.llvm.org/D62850 ___ cfe-commits mailing list

r362530 - [Syntax] Do not depend on llvm targets for Syntax tests. NFC

Author: ibiryukov Date: Tue Jun 4 10:15:48 2019 New Revision: 362530 URL: http://llvm.org/viewvc/llvm-project?rev=362530=rev Log: [Syntax] Do not depend on llvm targets for Syntax tests. NFC They are not required and only slow down the build. Modified:

[PATCH] D59474: [OpenMP 5.0] Codegen support for user-defined mappers

lildmh updated this revision to Diff 202926. lildmh added a comment. Address Alexey's comment about mapping between function and user-defined mappers CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59474/new/ https://reviews.llvm.org/D59474 Files: include/clang/AST/GlobalDecl.h

[PATCH] D55463: Introduce a source minimizer that reduces source to directives that might affect the dependency list for a compilation

thakis added a comment. Any reason this isn't tested via lit instead? Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55463/new/ https://reviews.llvm.org/D55463 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D62782: Fix -Wdouble-promotion warnings.

brucem added a comment. I'd modified `CMakeLists.txt` to add `-Wdouble-promotion` and removed this line: `-Wno-double-promotion # FIXME: remove me` ... Repository: rCXX libc++ CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62782/new/ https://reviews.llvm.org/D62782

[PATCH] D62850: [X86] Fix builtins-x86.c test where it wasn't using immediates. NFC

russell.gallop added a comment. > Then the test should be failing? Or is the current form also legal? Hmm, __builtin_ia32_insertps128() errors if you pass a variable, but these don't (e.g.): mytest.c:122:13: error: argument to '__builtin_ia32_insertps128' must be a constant integer tmp_V4f

[PATCH] D59744: Fix i386 ABI "__m64" type bug

krytarowski added subscribers: mgorny, joerg. krytarowski added a comment. In D59744#1527412 , @wxiao3 wrote: > Consider other Systems (e.g Darwin, PS4 and FreeBSD) don't want to spend any > effort dealing with the ramifications of ABI breaks (as

[Diffusion] rL358949: [PowerPC] [Clang] Port MMX intrinsics and basic test cases to Power

jsji added inline comments. /cfe/trunk/lib/Driver/ToolChains/PPCLinux.cpp:26 yes, it is currently Linux only. I think we can extend it to include other OS like AIX later if needed. https://reviews.llvm.org/rL358949 ___ cfe-commits mailing list

[PATCH] D62845: [clang-tidy] Fix make-unique tests on C++2a.

gribozavr accepted this revision. gribozavr added a comment. This revision is now accepted and ready to land. Looks great, thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62845/new/ https://reviews.llvm.org/D62845

Re: [PATCH] D62814: [clangd] Treat lambdas as functions when preparing hover response

AST dump doesn't traverse into typelocs, which is where x is. That said, this particular case is not worth any complexity at all. Even pointer-to-lambda is vanishingly rare. Regarding dropping ref/pointer info: one option here is keeping the old "class (lambda)&", and simply making sure we now

[PATCH] D62856: [clangd] Also apply adjustArguments when returning fallback commands

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62856/new/ https://reviews.llvm.org/D62856

[PATCH] D62850: [X86] Fix builtins-x86.c test where it wasn't using immediates. NFC

lebedev.ri added a comment. In D62850#1529081 , @russell.gallop wrote: > > .. or? > > I'm not sure what you mean. > > > Is this fixing a current test failure? > > No. The test is not failing, but it is not doing what was intended as these > builtins are

[PATCH] D60697: [ARM] Allow "-march=foo+fp" to vary with foo.

SjoerdMeijer updated this revision to Diff 202934. SjoerdMeijer added a comment. Hi Oliver, thanks for your comments! This was the easy one, they have been added: > I also don't see any tests for the negated forms of either feature. The trouble begun with this: > +fp.dp, but the FPU is

[PATCH] D60763: Prototype OpenCL BIFs using Tablegen

Nicola added a comment. A bit late to the review, but I've noticed a couple of issues with some of the implemented builtins: - The fmin/fmax builtins are defined twice for scalar types, does this create problems in overload resolution when using them? - The convert_ builtins don't have support

[PATCH] D62363: [X86] Enable intrinsics that convert float and bf16 data to each other

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62363/new/ https://reviews.llvm.org/D62363 ___ cfe-commits mailing list

[PATCH] D62363: [X86] Enable intrinsics that convert float and bf16 data to each other

RKSimon accepted this revision. RKSimon added a comment. Yup, doxygen LGTM - cheers Comment at: lib/Headers/avx512bf16intrin.h:33 + +/// Convert One BF16 Data to One Single Data. +/// Single Float Data CHANGES SINCE LAST ACTION

[PATCH] D62830: [WebAssembly] Support Leak Sanitizer on Emscripten

quantum added a comment. LSan is supposed to be linked in to replace some C library functions, and does not change the generated LLVM IR code, so there is nothing to actually test in LLVM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62830/new/

r362537 - Factor out repeated code to build a DeclRefExpr and mark it referenced.

Author: rsmith Date: Tue Jun 4 11:30:46 2019 New Revision: 362537 URL: http://llvm.org/viewvc/llvm-project?rev=362537=rev Log: Factor out repeated code to build a DeclRefExpr and mark it referenced. Modified: cfe/trunk/include/clang/Sema/Sema.h cfe/trunk/lib/Sema/SemaDeclCXX.cpp

[PATCH] D62621: [LibTooling] Add insert/remove convenience functions for creating `ASTEdit`s.

ymandel marked an inline comment as done. ymandel added a comment. Thanks for the review. In D62621#1528714 , @ilya-biryukov wrote: > Are there any corner cases with handling whitespace that we might want to > handle or document them if we don't handle

[PATCH] D60583: [AArch64] Implement Vector Funtion ABI name mangling.

jdoerfert reopened this revision. jdoerfert added a comment. This revision is now accepted and ready to land. Why/Where did we decide to clobber the attribute list with "non-existent function names"? This seems to me like an ad-hoc implementation of the RFC that is currently discussed but

[PATCH] D60583: [AArch64] Implement Vector Funtion ABI name mangling.

ABataev added a comment. In D60583#1529885 , @jdoerfert wrote: > In D60583#1529882 , @ABataev wrote: > > > In D60583#1529878 , @jdoerfert > > wrote: > > > > > Why/Where did

[PATCH] D62638: [analyzer] A Python script to prettify the ExplodedGraph dumps.

NoQ added a comment. Thanks!! Will fix as soon as i get to my desktop. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62638/new/ https://reviews.llvm.org/D62638 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D62445: [test] Fix plugin tests

hintonda marked an inline comment as done. hintonda added inline comments. Comment at: cfe/trunk/lib/Analysis/plugins/CMakeLists.txt:1 +if(LLVM_ENABLE_PLUGINS) + add_subdirectory(SampleAnalyzer) nathanchance wrote: > I think this should have a dependency on

[PATCH] D62648: [Sema][Typo] Fix assertion failure for expressions with multiple typos

dgoldman updated this revision to Diff 203011. dgoldman added a comment. - Move if empty check back Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62648/new/ https://reviews.llvm.org/D62648 Files: lib/Sema/SemaExprCXX.cpp

[PATCH] D61967: [clang-tidy] Add a close-on-exec check on pipe() in Android module.

jcai19 updated this revision to Diff 202984. jcai19 added a comment. Update test function names. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61967/new/ https://reviews.llvm.org/D61967 Files:

[PATCH] D53157: Teach the IRBuilder about constrained fadd and friends

kpn updated this revision to Diff 202987. kpn added a comment. Address the rest of the review comments, hopefully. I've lifted from mibintc's D62730 the enums for the exception behavior and rounding modes. The rest of that set of changes is better left to a

[PATCH] D62445: [test] Fix plugin tests

nathanchance added inline comments. Comment at: cfe/trunk/lib/Analysis/plugins/CMakeLists.txt:1 +if(LLVM_ENABLE_PLUGINS) + add_subdirectory(SampleAnalyzer) I think this should have a dependency on `CLANG_ENABLE_STATIC_ANALYZER` like in

[PATCH] D62830: [WebAssembly] Support Leak Sanitizer on Emscripten

quantum added a comment. It's not urgent, so I am willing to wait a day or two for commit access. If I still can't get access by then, I'll ask someone else to commit this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62830/new/

[PATCH] D60583: [AArch64] Implement Vector Funtion ABI name mangling.

ABataev added a comment. In D60583#1529878 , @jdoerfert wrote: > Why/Where did we decide to clobber the attribute list with "non-existent > function names"? > > This seems to me like an ad-hoc implementation of the RFC that is currently > discussed but

[PATCH] D60583: [AArch64] Implement Vector Funtion ABI name mangling.

jdoerfert added a comment. In D60583#1529882 , @ABataev wrote: > In D60583#1529878 , @jdoerfert wrote: > > > Why/Where did we decide to clobber the attribute list with "non-existent > > function names"? > > > >

[PATCH] D62638: [analyzer] A Python script to prettify the ExplodedGraph dumps.

Charusso added inline comments. Comment at: cfe/trunk/utils/analyzer/exploded-graph-rewriter.py:1 +#!/usr/bin/env python + ``` # something else then # #==- exploded-graph-rewriter.py - Simplifies the ExplodedGraph -*- python -*-==# # # Part of the LLVM Project,

[PATCH] D62850: [X86] Fix builtins-x86.c test where it wasn't using immediates. NFC

russell.gallop added a comment. > We support non immediate on these because gcc does. Thanks. Your comment crossed in mid-air. Okay, so is this test worth changing, or should it have both versions (immediate and non-immediate)? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D62850: [X86] Fix builtins-x86.c test where it wasn't using immediates. NFC

russell.gallop added a comment. > I'll have a look and see if there is a reason why these don't fail in the > same way (which would make the test fail in it's current form). These do not have the "I" prefix (// I -> Required to constant fold to an integer constant expression.) in

[PATCH] D62850: [X86] Fix builtins-x86.c test where it wasn't using immediates. NFC

lebedev.ri added a comment. In D62850#1529588 , @russell.gallop wrote: > > We support non immediate on these because gcc does. > > Thanks. Your comment crossed in mid-air. Okay, so is this test worth > changing, or should it have both versions

r362545 - Introduce Value::stripPointerCastsSameRepresentation

Author: jdoerfert Date: Tue Jun 4 13:21:46 2019 New Revision: 362545 URL: http://llvm.org/viewvc/llvm-project?rev=362545=rev Log: Introduce Value::stripPointerCastsSameRepresentation This patch allows current users of Value::stripPointerCasts() to force the result of the function to have the

[PATCH] D60974: Clang IFSO driver action.

plotfi updated this revision to Diff 202976. plotfi added a comment. Adding a test for inheritance and constructors/destroctors. Also addressing feedback from @alexshap Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60974/new/

[PATCH] D62049: [clang-tidy] Add a close-on-exec check on pipe2() in Android module.

jcai19 marked an inline comment as done. jcai19 added inline comments. Comment at: clang-tools-extra/test/clang-tidy/android-cloexec-pipe2.cpp:20 + pipe2(pipefd, O_NONBLOCK); + // CHECK-MESSAGES: :[[@LINE-1]]:27: warning: 'pipe2' should use O_CLOEXEC where possible

[PATCH] D62873: Avoid building analyzer plugins if CLANG_ENABLE_STATIC_ANALYZER is OFF

dim created this revision. dim added reviewers: hintonda, dcoughlin, NoQ. Herald added subscribers: dkrupp, donat.nagy, Szelethus, a.sidorin, baloghadamsoftware, mgorny. Herald added a project: clang. Attempting to build clang with CLANG_ENABLE_STATIC_ANALYZER=OFF fails after rC362328

[PATCH] D48680: Add missing visibility annotation for __base

pcc added a comment. Here's a standalone reproducer for the problem: $ cat exe.cpp #include std::function f(); int main() { f()(); } $ cat dso.cpp #include __attribute__((visibility("default"))) std::function f() { return [](){}; } $

[PATCH] D62873: Avoid building analyzer plugins if CLANG_ENABLE_STATIC_ANALYZER is OFF

kristina added a comment. Experienced the same, updated my test build configuration to always force `CLANG_ENABLE_STATIC_ANALYZER` to On when building with tests. Maybe it's worth adding a warning about when Clang tests are being built? Repository: rC Clang CHANGES SINCE LAST ACTION

[PATCH] D62873: Avoid building analyzer plugins if CLANG_ENABLE_STATIC_ANALYZER is OFF

nathanchance added a comment. Thanks for the quick fix, looks good to me! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62873/new/ https://reviews.llvm.org/D62873 ___ cfe-commits mailing list

[PATCH] D60233: [clang-scan-deps] initial outline of the tool that runs preprocessor to find dependencies over a JSON compilation database

arphaman updated this revision to Diff 203012. arphaman marked 7 inline comments as done. arphaman added a comment. Address review comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60233/new/ https://reviews.llvm.org/D60233 Files:

[PATCH] D62830: [WebAssembly] Support Leak Sanitizer on Emscripten

aheejin added a comment. I see. Do you want me to commit this, or you are gonna get a commit access? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62830/new/ https://reviews.llvm.org/D62830 ___

[PATCH] D61446: Generalize the pass registration mechanism used by Polly to any third-party tool

serge-sans-paille updated this revision to Diff 203029. serge-sans-paille added a comment. - make it possible for client code to speicify the registration function for new PM, thanks @philip.pfaffe for the hint. @Meinersbur this should be ok now. CHANGES SINCE LAST ACTION

  1   2   >