[PATCH] D65997: Add options rounding and exceptions to pragma fp

sepavloff marked an inline comment as done. sepavloff added inline comments. Comment at: clang/lib/Parse/ParsePragma.cpp:2678 + auto *AnnotValue = new (PP.getPreprocessorAllocator()) TokFPAnnotValue; while (Tok.is(tok::identifier)) { aaron.ballman wrote: >

r368976 - [clang] Loop pragma parsing. NFC.

Author: sjoerdmeijer Date: Thu Aug 15 00:39:05 2019 New Revision: 368976 URL: http://llvm.org/viewvc/llvm-project?rev=368976&view=rev Log: [clang] Loop pragma parsing. NFC. Just a refactoring and a tidy up. Differential Revision: https://reviews.llvm.org/D64564 Modified: cfe/trunk/lib/Parse

[PATCH] D64564: Loop pragma parsing. NFC.

This revision was automatically updated to reflect the committed changes. Closed by commit rL368976: [clang] Loop pragma parsing. NFC. (authored by SjoerdMeijer, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.

[PATCH] D66092: [CodeGen] Generate constrained fp intrinsics depending on FPOptions

sepavloff added a comment. In D66092#1629460 , @andrew.w.kaylor wrote: > In D66092#1627339 , @sepavloff wrote: > > > In D66092#1625380 , @kpn wrote: > > > > > Also, if any c

r368979 - [analyzer] Add docs for cplusplus.InnerPointer

Author: szelethus Date: Thu Aug 15 01:52:10 2019 New Revision: 368979 URL: http://llvm.org/viewvc/llvm-project?rev=368979&view=rev Log: [analyzer] Add docs for cplusplus.InnerPointer Differential Revision: https://reviews.llvm.org/D60281 Modified: cfe/trunk/docs/analyzer/checkers.rst Modifi

r368980 - [analyzer] Warn about -analyzer-configs being meant for development purposes only

Author: szelethus Date: Thu Aug 15 01:53:16 2019 New Revision: 368980 URL: http://llvm.org/viewvc/llvm-project?rev=368980&view=rev Log: [analyzer] Warn about -analyzer-configs being meant for development purposes only This is more of a temporary fix, long term, we should convert AnalyzerOptions

[PATCH] D60281: [analyzer] Add docs for cplusplus.InnerPointer

This revision was automatically updated to reflect the committed changes. Closed by commit rL368979: [analyzer] Add docs for cplusplus.InnerPointer (authored by Szelethus, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://rev

[PATCH] D66261: [analyzer] Warn about -analyzer-configs being meant for development purposes only

This revision was automatically updated to reflect the committed changes. Closed by commit rL368980: [analyzer] Warn about -analyzer-configs being meant for development purposes… (authored by Szelethus, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed

[PATCH] D55562: Atomics: support min/max orthogonally

t.p.northover added a comment. Ping. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55562/new/ https://reviews.llvm.org/D55562 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mai

[PATCH] D66266: [WIP][RISCV] Set MaxAtomicPromoteWidth and MaxAtomicInlineWidth

lenary added a comment. Hi Pengxuan, Thanks for the patch! We have a similar patch from @asb under review at the moment, D57450 . There's one question about ABI compatibility that still needs to be answered, which we will discuss in the RISC-V sync-up later tod

r368985 - Revert rL368939 "Remove LVALUE / RVALUE workarounds"

Author: russell_gallop Date: Thu Aug 15 03:12:11 2019 New Revision: 368985 URL: http://llvm.org/viewvc/llvm-project?rev=368985&view=rev Log: Revert rL368939 "Remove LVALUE / RVALUE workarounds" This reverts commit cad8356d699b36c73abb267f65db575ddacbd652. To unbreak Windows bots Modified: c

r368990 - Replace llvm::integer_sequence and friends with the C++14 standard version

Author: d0k Date: Thu Aug 15 03:56:05 2019 New Revision: 368990 URL: http://llvm.org/viewvc/llvm-project?rev=368990&view=rev Log: Replace llvm::integer_sequence and friends with the C++14 standard version The implementation in libc++ takes O(1) compile time, ours was O(n). Modified: cfe/trun

[clang-tools-extra] r368990 - Replace llvm::integer_sequence and friends with the C++14 standard version

Author: d0k Date: Thu Aug 15 03:56:05 2019 New Revision: 368990 URL: http://llvm.org/viewvc/llvm-project?rev=368990&view=rev Log: Replace llvm::integer_sequence and friends with the C++14 standard version The implementation in libc++ takes O(1) compile time, ours was O(n). Modified: clang-to

[clang-tools-extra] r368991 - [clangd] llvm::integer_sequence -> std::integer_sequence.

Author: d0k Date: Thu Aug 15 04:09:22 2019 New Revision: 368991 URL: http://llvm.org/viewvc/llvm-project?rev=368991&view=rev Log: [clangd] llvm::integer_sequence -> std::integer_sequence. Modified: clang-tools-extra/trunk/clangd/Function.h Modified: clang-tools-extra/trunk/clangd/Function.h

[PATCH] D64418: [Docs][OpenCL] Documentation of C++ for OpenCL mode

svenvh added inline comments. Comment at: docs/LanguageExtensions.rst:1561 +s3.1.3). For OpenCL it means that implicit conversions are allowed from +named address space except for ``__constant`` to ``__generic`` address space +that is a superset of all others except for ``__const

[PATCH] D66002: [RISCV] Move architecture parsing code into its own function

luismarques added a comment. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66002/new/ https://reviews.llvm.org/D66002 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.or

[PATCH] D66290: [clang] Pragma vectorize_width() implies vectorize(enable)

SjoerdMeijer created this revision. SjoerdMeijer added reviewers: Meinersbur, fhahn, hsaito, dorit. Specifying the vectorization width was supposed to implicitly enable vectorization, except that it wasn't really doing this. It was only setting the `vectorize.width` metadata, but not `vectorize.en

[PATCH] D66290: [clang] Pragma vectorize_width() implies vectorize(enable)

fhahn added a comment. > As also pointed out in the discussion on the cfe dev list, this is probably a > bit > of a silly combination: > > > vectorize(enable) vectorize_width(1) > > > but it could still mean that the vectorizer interleaves. So, with this > simplification, disabl

[PATCH] D66269: [clang-tidy] Migrate objc-forbidden-subclassing to use isDerivedFrom 🚛

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66269/new/ https://reviews.llvm.org/D66269

[PATCH] D66270: [clang-tidy] Migrate objc-super-self to use isDerivedFrom 🚛

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66270/new/ https://reviews.llvm.org/D66270

[PATCH] D65863: [ARM] Add support for the s,j,x,N,O inline asm constraints

dcandler added a comment. Ping. @compnerd any other changes before this could be accepted? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65863/new/ https://reviews.llvm.org/D65863 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http

[PATCH] D65997: Add options rounding and exceptions to pragma fp

aaron.ballman added inline comments. Comment at: clang/lib/Parse/ParsePragma.cpp:2678 + auto *AnnotValue = new (PP.getPreprocessorAllocator()) TokFPAnnotValue; while (Tok.is(tok::identifier)) { sepavloff wrote: > aaron.ballman wrote: > > Might as well move

[PATCH] D55892: [OpenMP] 'close' map-type-modifier code generation

Hahnfeld removed a reviewer: Hahnfeld. Hahnfeld added a comment. Herald added a reviewer: jdoerfert. Herald added a project: clang. Can we close this after D65341 landed? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55892/new/ h

[PATCH] D65819: [Driver][Bundler] Improve bundling of object files.

Hahnfeld requested changes to this revision. Hahnfeld added a comment. This revision now requires changes to proceed. The code changes look good to me, but the test doesn't pass on x86. We've faced the same problem when `clang-offload-bundler` was initially committed and the current testing is t

[PATCH] D66290: [clang] Pragma vectorize_width() implies vectorize(enable)

SjoerdMeijer updated this revision to Diff 215388. SjoerdMeijer edited the summary of this revision. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66290/new/ https://reviews.llvm.org/D66290 Files: clang/lib/CodeGen/CGLoopInfo.cpp clang/test/CodeGenCXX/pragma-loop-predicate.cpp clan

[PATCH] D66290: [clang] Pragma vectorize_width() implies vectorize(enable)

SjoerdMeijer added a comment. Thanks for looking again! Good catch, feedback addressed. (forgot to add this message when I uploaded the new diff) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66290/new/ https://reviews.llvm.org/D66290 ___

QualType

Hello, I want to create QualType instances for *const int*, *int* const*, and *const int* const.* How can I do that?? Regards, Mona ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] r369005 - [clangd] Don't use Bind() where C++14 move capture works

Author: d0k Date: Thu Aug 15 07:16:06 2019 New Revision: 369005 URL: http://llvm.org/viewvc/llvm-project?rev=369005&view=rev Log: [clangd] Don't use Bind() where C++14 move capture works Modified: clang-tools-extra/trunk/clangd/ClangdLSPServer.cpp clang-tools-extra/trunk/clangd/ClangdLSPS

[PATCH] D66018: [ARM] Take into account -mcpu and -mfpu options while handling 'crypto' feature

krisb updated this revision to Diff 215394. krisb added a comment. Applied the comment. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66018/new/ https://reviews.llvm.org/D66018 Files: lib/Driver/ToolChains/Arch/ARM.cpp test/Driver/arm-features.c Index: tes

[PATCH] D66018: [ARM] Take into account -mcpu and -mfpu options while handling 'crypto' feature

krisb added a comment. @dnsampaio, thanks, this looks better. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66018/new/ https://reviews.llvm.org/D66018 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://l

[PATCH] D66294: [Docs][OpenCL] Release 9.0 notes for OpenCL

Anastasia created this revision. Anastasia added reviewers: svenvh, mantognini, hans. Herald added subscribers: ebevhan, jfb, yaxunl. https://reviews.llvm.org/D66294 Files: docs/ReleaseNotes.rst Index: docs/ReleaseNotes.rst === --

[PATCH] D65819: [Driver][Bundler] Improve bundling of object files.

ABataev updated this revision to Diff 215399. ABataev added a comment. Fixed comments. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65819/new/ https://reviews.llvm.org/D65819 Files: test/Driver/clang-offload-bundler.c test/Driver/clang-offload-bundler.c.o

[PATCH] D65819: [Driver][Bundler] Improve bundling of object files.

ABataev added a comment. In D65819#1631410 , @Hahnfeld wrote: > The code changes look good to me, but the test doesn't pass on x86. We've > faced the same problem when `clang-offload-bundler` was initially committed > and the current testing is the best

[PATCH] D65819: [Driver][Bundler] Improve bundling of object files.

Hahnfeld added a comment. Please submit the test changes unrelated to the code changes in a separate patch! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65819/new/ https://reviews.llvm.org/D65819 ___ cfe-commits ma

[PATCH] D66296: [BUNDLER]Improve the test, NFC.

ABataev created this revision. ABataev added reviewers: Hahnfeld, hfinkel. Herald added a reviewer: jdoerfert. Herald added a project: clang. Make the test more portable and do not rely on the pre-bundled object file. Repository: rC Clang https://reviews.llvm.org/D66296 Files: test/Driver/

[PATCH] D66298: [clang-doc] Fix records in global namespace

DiegoAstiazaran created this revision. DiegoAstiazaran added reviewers: juliehockett, jakehehrlich. DiegoAstiazaran added a project: clang-tools-extra. When a Record is declared in the global namespace, clang-doc serializes it as a child of the global namespace, so the global namespace is now one

[PATCH] D66299: [clang-doc] Sort index elements case insensitive

DiegoAstiazaran created this revision. DiegoAstiazaran added reviewers: juliehockett, jakehehrlich. DiegoAstiazaran added a project: clang-tools-extra. Herald added a subscriber: arphaman. Implement logic to compare the references of the index case insensitive. https://reviews.llvm.org/D66299 F

[PATCH] D66296: [BUNDLER]Improve the test, NFC.

Hahnfeld accepted this revision. Hahnfeld added a comment. This revision is now accepted and ready to land. LG Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66296/new/ https://reviews.llvm.org/D66296 ___ cfe-commits

[PATCH] D66294: [Docs][OpenCL] Release 9.0 notes for OpenCL

mantognini requested changes to this revision. mantognini added a comment. This revision now requires changes to proceed. The overall structure seems alright. I'll let people more familiar with the code-base judge whether other important features should be added there as well.

[PATCH] D65634: [RISCV] Default to ilp32d/lp64d in RISC-V Linux

luismarques added inline comments. Comment at: clang/lib/Driver/ToolChains/Arch/RISCV.cpp:386 + else +return Triple.getArch() == llvm::Triple::riscv32 ? "ilp32" : "lp64"; } When I compile a bare metal GNU toolchain (using

[PATCH] D66294: [Docs][OpenCL] Release 9.0 notes for OpenCL

svenvh added inline comments. Comment at: docs/ReleaseNotes.rst:173 + +- Added initial support for implicitly including OpenCL BIFs using + efficient trie lookup generated by TableGen. A corresponding mantognini wrote: > If the BIF acronym wasn't introduced befo

[PATCH] D65634: [RISCV] Default to ilp32d/lp64d in RISC-V Linux

luismarques added inline comments. Comment at: clang/lib/Driver/ToolChains/Arch/RISCV.cpp:386 + else +return Triple.getArch() == llvm::Triple::riscv32 ? "ilp32" : "lp64"; } luismarques wrote: > When I compile a bare metal GNU toolchain (using >

[PATCH] D66298: [clang-doc] Fix records in global namespace

juliehockett added inline comments. Comment at: clang-tools-extra/unittests/clang-doc/SerializeTest.cpp:299 RecordInfo *G = InfoAsRecord(Infos[2].get()); - RecordInfo ExpectedG(EmptySID, /*Name=*/"G", /*Path=*/"E"); + RecordInfo ExpectedG(EmptySID, /*Name=*/"G", /*Path=*/"Gl

[PATCH] D66302: [SVE][Inline-Asm] Support for SVE asm operands

kmclaughlin created this revision. kmclaughlin added reviewers: t.p.northover, sdesmalen, rovka, momchil.velikov. Herald added subscribers: psnobl, rkruppe, tschuett, javed.absar. Herald added a reviewer: rengolin. Herald added a project: LLVM. Adds the following inline asm constraints for SVE: -

[PATCH] D52524: Add -Wno-poison-system-directories flag

thakis added a comment. Ok, makes sense, thanks for explaining. Please add a summary of that discussion to the patch description / commit message :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D52524/new/ https://reviews.llvm.org/D52524 _

[PATCH] D66040: [Sema] Implement DR2386 for C++17 structured binding

thakis added a comment. rnk, what's the status here? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66040/new/ https://reviews.llvm.org/D66040 ___ cfe-commits mailing list cfe-commits@lists.llvm.org htt

[PATCH] D66040: [Sema] Implement DR2386 for C++17 structured binding

rnk marked an inline comment as done. rnk added a comment. In D66040#1631658 , @thakis wrote: > rnk, what's the status here? I think I can get this in today, things just got busy here and I forgot about this. I have to add that test.

[PATCH] D66303: [LifetimeAnalysis] Add support for free functions

xazax.hun created this revision. xazax.hun added reviewers: mgehre, gribozavr. xazax.hun added a project: clang. Herald added subscribers: Szelethus, Charusso, gamesh411, dkrupp, rnkovacs. This patch adds support to the idiom when people using the free version of `begin`, `end` and the like inste

[PATCH] D66003: [RISCV] Make -march=rv{32, 64}gc the default in RISC-V Linux

luismarques accepted this revision. luismarques added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66003/new/ https://reviews.llvm.org/D66003

r369015 - [BUNDLER]Improve the test, NFC.

Author: abataev Date: Thu Aug 15 09:28:24 2019 New Revision: 369015 URL: http://llvm.org/viewvc/llvm-project?rev=369015&view=rev Log: [BUNDLER]Improve the test, NFC. Summary: Make the test more portable and do not rely on the pre-bundled object file. Reviewers: Hahnfeld, hfinkel, jdoerfert Subs

[PATCH] D66014: [analyzer] Avoid unnecessary enum range check on LValueToRValue casts

chrish_ericsson_atx marked 5 inline comments as done. chrish_ericsson_atx added a comment. In D66014#1627858 , @Szelethus wrote: > LGTM, thanks! Do you need someone to commit this on your behalf? Also, could > you please make the comments capitalized, ter

[PATCH] D66296: [BUNDLER]Improve the test, NFC.

This revision was automatically updated to reflect the committed changes. Closed by commit rL369015: [BUNDLER]Improve the test, NFC. (authored by ABataev, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINCE LAST ACTION http

[PATCH] D66014: [analyzer] Avoid unnecessary enum range check on LValueToRValue casts

Szelethus added a comment. Yup, you can upload it and the green checkmark will stay. If it doesn't, I'll accept again. I think there was one case when I added like 800 extra LOCs to a patch and phabricator automatically marked it as "needs reviews", but I never came across this after that, eve

[PATCH] D65819: [Driver][Bundler] Improve bundling of object files.

ABataev updated this revision to Diff 215421. ABataev added a comment. Rebase Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65819/new/ https://reviews.llvm.org/D65819 Files: test/Driver/clang-offload-bundler.c tools/clang-offload-bundler/ClangOffloadBundler.

[PATCH] D66014: [analyzer] Avoid unnecessary enum range check on LValueToRValue casts

Szelethus added a comment. Oh, there is no need for a new differential, you can update this one by clicking on 'update diff' in the right panel. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66014/new/ https://reviews.llvm.org/D66014 _

Re: r368874 - Document clang-cpp in the release notes for clang

It actually does not. Getting the MSVC export list is a much harder problem. I'll update the release note. -Chris > On Aug 14, 2019, at 10:32 PM, Kim Gräsman wrote: > > On Wed, Aug 14, 2019 at 6:48 PM Chris Bieneman via cfe-commits > wrote: >> >> Author: cbieneman >> Date: Wed Aug 14 09:49:5

[PATCH] D65819: [Driver][Bundler] Improve bundling of object files.

Hahnfeld accepted this revision. Hahnfeld added a comment. This revision is now accepted and ready to land. LG, thanks for the changes. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65819/new/ https://reviews.llvm.org/D65819 ___

r369019 - [Driver][Bundler] Improve bundling of object files.

Author: abataev Date: Thu Aug 15 10:15:35 2019 New Revision: 369019 URL: http://llvm.org/viewvc/llvm-project?rev=369019&view=rev Log: [Driver][Bundler] Improve bundling of object files. Summary: Previously, object files were bundled using partial linking. It resulted in the following structure of

r369020 - Test commit #2.

Author: george.karpenkov Date: Thu Aug 15 10:17:21 2019 New Revision: 369020 URL: http://llvm.org/viewvc/llvm-project?rev=369020&view=rev Log: Test commit #2. Modified: cfe/trunk/www/index.html Modified: cfe/trunk/www/index.html URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/www/index.h

[PATCH] D65819: [Driver][Bundler] Improve bundling of object files.

This revision was automatically updated to reflect the committed changes. Closed by commit rL369019: [Driver][Bundler] Improve bundling of object files. (authored by ABataev, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINC

[PATCH] D64811: Warn when NumParams overflows

Mordante updated this revision to Diff 215425. Mordante added a comment. Moved the testing from Parse to Sema. Added additional safeguards for template instantiation. Added more unit tests. The comments may be a bit noisy, but they explain why the templates need to be tested at two locations. C

[PATCH] D66014: [analyzer] Avoid unnecessary enum range check on LValueToRValue casts

chrish_ericsson_atx updated this revision to Diff 215433. chrish_ericsson_atx added a comment. Follow-up on reviewer feedback. Changed from blacklisting LValueToRValue to whitelisting IntegralCast. This was a good call -- additional testing with different cast kinds showed that the assertion t

[PATCH] D66040: [Sema] Implement DR2386 for C++17 structured binding

rnk updated this revision to Diff 215442. rnk added a comment. - add DR test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66040/new/ https://reviews.llvm.org/D66040 Files: clang/lib/Sema/SemaDeclCXX.cpp clang/test/CXX/dcl.decl/dcl.decomp

r369028 - Fix the test, NFC.

Author: abataev Date: Thu Aug 15 10:53:49 2019 New Revision: 369028 URL: http://llvm.org/viewvc/llvm-project?rev=369028&view=rev Log: Fix the test, NFC. Modified: cfe/trunk/test/Driver/clang-offload-bundler.c Modified: cfe/trunk/test/Driver/clang-offload-bundler.c URL: http://llvm.org/viewv

[PATCH] D66186: [Sema] Don't warn on printf('%hd', [char]) (PR41467)

Nathan-Huckleberry added a comment. In D66186#1630427 , @aaron.ballman wrote: > There was a request in the linked bug for some code archaeology to see why > this behavior exists in the first place. What were the results of that? I'm > not opposed to the

[PATCH] D63260: [Attr] Support _attribute__ ((fallthrough))

kees added a comment. For latest version see https://reviews.llvm.org/D64838 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63260/new/ https://reviews.llvm.org/D63260 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm

[PATCH] D66186: [Sema] Don't warn on printf('%hd', [char]) (PR41467)

lebedev.ri added a comment. In D66186#1631921 , @Nathan-Huckleberry wrote: > In D66186#1630427 , @aaron.ballman > wrote: > > > There was a request in the linked bug for some code archaeology to see why > > this b

[PATCH] D66186: [Sema] Don't warn on printf('%hd', [char]) (PR41467)

aaron.ballman added a comment. In D66186#1631921 , @Nathan-Huckleberry wrote: > In D66186#1630427 , @aaron.ballman > wrote: > > > There was a request in the linked bug for some code archaeology to see why > > thi

[PATCH] D61466: [Rewrite][NFC] Add FIXMEs and tests for RemoveLineIfEmpty bug

jkorous accepted this revision. jkorous added a comment. This revision is now accepted and ready to land. LGTM. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61466/new/ https://reviews.llvm.org/D61466 ___ cfe-commits mailing list cf

[PATCH] D65696: Implements CWG 2082 Referring to parameters in unevaluated operands of default arguments

Mordante updated this revision to Diff 215448. Mordante added a comment. Updated the unit tests as requested. This required the `Sema::ActOnParamDefaultArgument` to delay a part of the ODR validation until the default argument has been 'instantiated'. As discussed on IRC; the up to date `cwg_ind

r369033 - Allow standards-based attributes to have leading and trailing underscores.

Author: aaronballman Date: Thu Aug 15 11:35:44 2019 New Revision: 369033 URL: http://llvm.org/viewvc/llvm-project?rev=369033&view=rev Log: Allow standards-based attributes to have leading and trailing underscores. This gives library implementers a way to use standards-based attributes that do no

r369035 - Rename this file from cx2.c to c2x.c; NFC.

Author: aaronballman Date: Thu Aug 15 11:37:30 2019 New Revision: 369035 URL: http://llvm.org/viewvc/llvm-project?rev=369035&view=rev Log: Rename this file from cx2.c to c2x.c; NFC. Added: cfe/trunk/test/Sema/attr-c2x.c - copied unchanged from r369034, cfe/trunk/test/Sema/attr-cx2.c Rem

[PATCH] D62731: [RFC] Add support for options -fp-model= and -fp-speculation= : specify floating point behavior

kpn added inline comments. Comment at: clang/docs/UsersManual.rst:1307 + + ``precise `` Disables optimizations that are not value-safe on + floating-point data, although FP contraction (FMA) is enabled. Extra spaces? Comment at: clang/li

[PATCH] D66296: [BUNDLER]Improve the test, NFC.

azharudd added a comment. Looks like this is failing on Darwin: http://green.lab.llvm.org/green/job/clang-stage1-cmake-RA-incremental/1193/consoleFull#-2382751928254eaf0-7326-4999-85b0-388101f2d404 /Users/buildslave/jenkins/workspace/clang-stage1-cmake-RA-incremental/llvm-project/clang/t

RE: QualType

Usually the cfe-dev mailing list is better for questions like this. The type “int” is ASTContext::IntTy. You can use QualType::withConst to add a “const” qualifier, and ASTContext::getPointerType to construct a pointer type. Putting that together, you can construct a “const int*” with somethin

[PATCH] D66296: [BUNDLER]Improve the test, NFC.

ABataev added a comment. In D66296#1632003 , @azharudd wrote: > Looks like this is failing on Darwin: > > http://green.lab.llvm.org/green/job/clang-stage1-cmake-RA-incremental/1193/consoleFull#-2382751928254eaf0-7326-4999-85b0-388101f2d404 > > > /Users/

[PATCH] D66186: [Sema] Don't warn on printf('%hd', [char]) (PR41467)

lebedev.ri requested changes to this revision. lebedev.ri added a comment. This revision now requires changes to proceed. (just want to mark it as "unanswered questions") Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66186/new/ https://reviews.llvm

[PATCH] D66040: [Sema] Implement DR2386 for C++17 structured binding

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. LGTM with minor adjustments to the test. Comment at: clang/test/CXX/drs/dr23xx.cpp:43-57 +#if __cplusplus >= 201707L +// Otherwise, if the qualified-id std::tuple_size names

r369042 - [WebAssembly] Correctly handle va_arg of zero-sized structures

Author: quantum Date: Thu Aug 15 12:33:36 2019 New Revision: 369042 URL: http://llvm.org/viewvc/llvm-project?rev=369042&view=rev Log: [WebAssembly] Correctly handle va_arg of zero-sized structures Summary: D66168 passes size 0 structs indirectly, while the wasm backend expects it to be passed dir

[PATCH] D66255: [WebAssembly] Correctly handle va_arg of zero-sized structures

This revision was automatically updated to reflect the committed changes. Closed by commit rL369042: [WebAssembly] Correctly handle va_arg of zero-sized structures (authored by quantum, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D66266: [WIP][RISCV] Set MaxAtomicPromoteWidth and MaxAtomicInlineWidth

pzheng abandoned this revision. pzheng added a comment. Hi Sam, Thanks for pointing me to the patch. I can abandon this one now. Pengxuan Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66266/new/ https://reviews.llvm.org/D66266

[PATCH] D66040: [Sema] Implement DR2386 for C++17 structured binding

This revision was automatically updated to reflect the committed changes. Closed by commit rL369043: [Sema] Implement DR2386 for C++17 structured binding (authored by rnk, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://rev

r369043 - [Sema] Implement DR2386 for C++17 structured binding

Author: rnk Date: Thu Aug 15 12:45:28 2019 New Revision: 369043 URL: http://llvm.org/viewvc/llvm-project?rev=369043&view=rev Log: [Sema] Implement DR2386 for C++17 structured binding Allow implementations to provide complete definitions of std::tuple_size, but to omit the 'value' member to signal

[PATCH] D65695: Implements CWG 1601 in [over.ics.rank/4.2]

Mordante updated this revision to Diff 215457. Mordante added a comment. Add the proper markers in the unit test to update `cxx_dr_status.html`. As discussed on IRC; the up to date `cwg_index.html` is not public, so I only updated the unit test and removed the changes to `cxx_dr_status.html`.

[PATCH] D62731: [RFC] Add support for options -fp-model= and -fp-speculation= : specify floating point behavior

mibintc marked 3 inline comments as done. mibintc added inline comments. Comment at: clang/lib/CodeGen/CodeGenFunction.cpp:126 + case LangOptions::FPM_Precise: + case LangOptions::FPM_Fast: +break; kpn wrote: > Wait, so "fast" and "precise" are the same thi

[PATCH] D65935: [ASTImporter] Import ctor initializers after setting flags.

shafik accepted this revision. shafik added a comment. This revision is now accepted and ready to land. I was hoping to be able reproduce this in LLDB via an expression like this: expr testImportOfDelegateConstructor(10) == 10 but it does not. I am assuming the test ctu test case invokes the i

Re: [PATCH] D66296: [BUNDLER]Improve the test, NFC.

Seeing this now: fatal error: error in backend: Global variable '' has an invalid section specifier '__CLANG_OFFLOAD_BUNDLE__host-x86_64-apple-darwin17.6.0': mach-o section specifier requires a segment whose length is between 1 and 16 characters. <>clang-10: error: clang frontend command faile

Re: [PATCH] D66296: [BUNDLER]Improve the test, NFC.

Will fix this shortly. - Best regards, Alexey Bataev 15.08.2019 16:23, Azhar Mohammed пишет: > Seeing this now: > > fatal error: error in backend: Global variable '' has an invalid > section specifier > '__CLANG_OFFLOAD_BUNDLE__host-x86_64-apple-darwin17.6.0': mach-o > section specifi

[PATCH] D65453: Improve the accuracy of the Clang call graph analysis

jcranmer-intel updated this revision to Diff 215462. jcranmer-intel added a comment. I've rolled the relevant call graph analysis changes from the prior commit into this updated patch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65453/new/ https://reviews.llvm.org/D65453 Files: cl

r369044 - Mark the test as unsupported on darwin, NFC.

Author: abataev Date: Thu Aug 15 13:31:47 2019 New Revision: 369044 URL: http://llvm.org/viewvc/llvm-project?rev=369044&view=rev Log: Mark the test as unsupported on darwin, NFC. The bundler may fail on darwin, mark the test as not compatible. Modified: cfe/trunk/test/Driver/clang-offload-bu

[PATCH] D65997: Add options rounding and exceptions to pragma fp

andrew.w.kaylor added inline comments. Comment at: clang/docs/LanguageExtensions.rst:3127 The pragma can take three values: ``on``, ``fast`` and ``off``. The ``on`` option is identical to using ``#pragma STDC FP_CONTRACT(ON)`` and it allows This part of the

[PATCH] D65695: Implements CWG 1601 in [over.ics.rank/4.2]

rsmith added inline comments. Comment at: clang/lib/Sema/SemaOverload.cpp:3758 +static QualType +getFixedEnumUnderlayingType(const StandardConversionSequence &SCS) { + Underlaying -> Underlying (here and below) Comment at: clang/lib/Sema/SemaOv

[PATCH] D66303: [LifetimeAnalysis] Add support for free functions

mgehre added inline comments. Comment at: clang/lib/Sema/SemaInit.cpp:6622 +return false; + const auto *RD = FD->getParamDecl(0)->getType()->getPointeeCXXRecordDecl(); + if (!FD->isInStdNamespace() || !RD || !RD->isInStdNamespace()) Maybe move the `Callee->

[PATCH] D59692: [ASTImporter] Fix name conflict handling

shafik added a comment. Just wanted to see if you were planning on landing this soon, the fix `Name` -> `SearchName` is probably an important one since we have seen several issues w/ bugs like that but I really would like to see more tests. Are you having issues coming up w/ tests? Repository

r369049 - [Rewrite][NFC] Add FIXMEs and tests for RemoveLineIfEmpty bug

Author: jdenny Date: Thu Aug 15 14:17:48 2019 New Revision: 369049 URL: http://llvm.org/viewvc/llvm-project?rev=369049&view=rev Log: [Rewrite][NFC] Add FIXMEs and tests for RemoveLineIfEmpty bug I'd like to add these comments to warn others of problems I encountered when trying to use `RemoveLine

[PATCH] D61466: [Rewrite][NFC] Add FIXMEs and tests for RemoveLineIfEmpty bug

This revision was automatically updated to reflect the committed changes. Closed by commit rL369049: [Rewrite][NFC] Add FIXMEs and tests for RemoveLineIfEmpty bug (authored by jdenny, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D66267: [analyzer] TrackConstraintBRVisitor: Do not track unknown values

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. This code is super messy. It'd be great to actually test this change on something to see if it has any unwanted side effects. Could you see if it also fixes https://bugs.llvm.org/show_bug.cgi?id=429

[PATCH] D66267: [analyzer] TrackConstraintBRVisitor: Do not track unknown values

NoQ added a comment. In D66267#1630728 , @Szelethus wrote: > Shouldn't we just delete this entire visitor altogether and merge it into > ConditionBRVisitor (like, eventually, not right now)? It seems to be a relic > of the past. I'm actually curious ab

[PATCH] D66092: [CodeGen] Generate constrained fp intrinsics depending on FPOptions

andrew.w.kaylor added a comment. In D66092#1630997 , @sepavloff wrote: > Replacement of floating point operations with constrained intrinsics seems > more an optimization helper then a semantic requirement. IR where constrained > operations are mixed wit

[PATCH] D65453: Improve the accuracy of the Clang call graph analysis

NoQ added a comment. Thanks! This looks very useful. Comment at: clang/lib/Analysis/CallGraph.cpp:97-102 +const auto *ConstructedType = Ctor->getParent(); +if (ConstructedType->hasUserDeclaredDestructor()) { + CXXDestructorDecl *Dtor = ConstructedType->getDestructo

  1   2   >