[PATCH] D66290: [clang] Pragma vectorize_width() implies vectorize(enable)

2019-08-15 Thread Florian Hahn via Phabricator via cfe-commits
fhahn added a comment. > As also pointed out in the discussion on the cfe dev list, this is probably a > bit > of a silly combination: > > > vectorize(enable) vectorize_width(1) > > > but it could still mean that the vectorizer interleaves. So, with this > simplification,

[PATCH] D65997: Add options rounding and exceptions to pragma fp

2019-08-15 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added inline comments. Comment at: clang/lib/Parse/ParsePragma.cpp:2678 + auto *AnnotValue = new (PP.getPreprocessorAllocator()) TokFPAnnotValue; while (Tok.is(tok::identifier)) { sepavloff wrote: > aaron.ballman wrote: > > Might as well move

[PATCH] D55892: [OpenMP] 'close' map-type-modifier code generation

2019-08-15 Thread Jonas Hahnfeld via Phabricator via cfe-commits
Hahnfeld removed a reviewer: Hahnfeld. Hahnfeld added a comment. Herald added a reviewer: jdoerfert. Herald added a project: clang. Can we close this after D65341 landed? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55892/new/

[PATCH] D65997: Add options rounding and exceptions to pragma fp

2019-08-15 Thread Serge Pavlov via Phabricator via cfe-commits
sepavloff marked an inline comment as done. sepavloff added inline comments. Comment at: clang/lib/Parse/ParsePragma.cpp:2678 + auto *AnnotValue = new (PP.getPreprocessorAllocator()) TokFPAnnotValue; while (Tok.is(tok::identifier)) { aaron.ballman wrote: >

r368976 - [clang] Loop pragma parsing. NFC.

2019-08-15 Thread Sjoerd Meijer via cfe-commits
Author: sjoerdmeijer Date: Thu Aug 15 00:39:05 2019 New Revision: 368976 URL: http://llvm.org/viewvc/llvm-project?rev=368976=rev Log: [clang] Loop pragma parsing. NFC. Just a refactoring and a tidy up. Differential Revision: https://reviews.llvm.org/D64564 Modified:

[PATCH] D64564: Loop pragma parsing. NFC.

2019-08-15 Thread Sjoerd Meijer via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL368976: [clang] Loop pragma parsing. NFC. (authored by SjoerdMeijer, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D66092: [CodeGen] Generate constrained fp intrinsics depending on FPOptions

2019-08-15 Thread Serge Pavlov via Phabricator via cfe-commits
sepavloff added a comment. In D66092#1629460 , @andrew.w.kaylor wrote: > In D66092#1627339 , @sepavloff wrote: > > > In D66092#1625380 , @kpn wrote: > > > > > Also, if any

[PATCH] D64418: [Docs][OpenCL] Documentation of C++ for OpenCL mode

2019-08-15 Thread Sven van Haastregt via Phabricator via cfe-commits
svenvh added inline comments. Comment at: docs/LanguageExtensions.rst:1561 +s3.1.3). For OpenCL it means that implicit conversions are allowed from +named address space except for ``__constant`` to ``__generic`` address space +that is a superset of all others except for

[PATCH] D66290: [clang] Pragma vectorize_width() implies vectorize(enable)

2019-08-15 Thread Sjoerd Meijer via Phabricator via cfe-commits
SjoerdMeijer updated this revision to Diff 215388. SjoerdMeijer edited the summary of this revision. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66290/new/ https://reviews.llvm.org/D66290 Files: clang/lib/CodeGen/CGLoopInfo.cpp clang/test/CodeGenCXX/pragma-loop-predicate.cpp

[clang-tools-extra] r369005 - [clangd] Don't use Bind() where C++14 move capture works

2019-08-15 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Thu Aug 15 07:16:06 2019 New Revision: 369005 URL: http://llvm.org/viewvc/llvm-project?rev=369005=rev Log: [clangd] Don't use Bind() where C++14 move capture works Modified: clang-tools-extra/trunk/clangd/ClangdLSPServer.cpp

[PATCH] D66270: [clang-tidy] Migrate objc-super-self to use isDerivedFrom 

2019-08-15 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66270/new/ https://reviews.llvm.org/D66270

[PATCH] D65863: [ARM] Add support for the s,j,x,N,O inline asm constraints

2019-08-15 Thread David Candler via Phabricator via cfe-commits
dcandler added a comment. Ping. @compnerd any other changes before this could be accepted? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65863/new/ https://reviews.llvm.org/D65863 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D66002: [RISCV] Move architecture parsing code into its own function

2019-08-15 Thread Luís Marques via Phabricator via cfe-commits
luismarques added a comment. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66002/new/ https://reviews.llvm.org/D66002 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D66290: [clang] Pragma vectorize_width() implies vectorize(enable)

2019-08-15 Thread Sjoerd Meijer via Phabricator via cfe-commits
SjoerdMeijer created this revision. SjoerdMeijer added reviewers: Meinersbur, fhahn, hsaito, dorit. Specifying the vectorization width was supposed to implicitly enable vectorization, except that it wasn't really doing this. It was only setting the `vectorize.width` metadata, but not

[PATCH] D66269: [clang-tidy] Migrate objc-forbidden-subclassing to use isDerivedFrom 

2019-08-15 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66269/new/ https://reviews.llvm.org/D66269

QualType

2019-08-15 Thread Monalisa Rout via cfe-commits
Hello, I want to create QualType instances for *const int*, *int* const*, and *const int* const.* How can I do that?? Regards, Mona ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D65819: [Driver][Bundler] Improve bundling of object files.

2019-08-15 Thread Alexey Bataev via Phabricator via cfe-commits
ABataev updated this revision to Diff 215399. ABataev added a comment. Fixed comments. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65819/new/ https://reviews.llvm.org/D65819 Files: test/Driver/clang-offload-bundler.c test/Driver/clang-offload-bundler.c.o

[PATCH] D65819: [Driver][Bundler] Improve bundling of object files.

2019-08-15 Thread Alexey Bataev via Phabricator via cfe-commits
ABataev added a comment. In D65819#1631410 , @Hahnfeld wrote: > The code changes look good to me, but the test doesn't pass on x86. We've > faced the same problem when `clang-offload-bundler` was initially committed > and the current testing is the best

[PATCH] D65819: [Driver][Bundler] Improve bundling of object files.

2019-08-15 Thread Jonas Hahnfeld via Phabricator via cfe-commits
Hahnfeld requested changes to this revision. Hahnfeld added a comment. This revision now requires changes to proceed. The code changes look good to me, but the test doesn't pass on x86. We've faced the same problem when `clang-offload-bundler` was initially committed and the current testing is

[PATCH] D66018: [ARM] Take into account -mcpu and -mfpu options while handling 'crypto' feature

2019-08-15 Thread Kristina Bessonova via Phabricator via cfe-commits
krisb updated this revision to Diff 215394. krisb added a comment. Applied the comment. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66018/new/ https://reviews.llvm.org/D66018 Files: lib/Driver/ToolChains/Arch/ARM.cpp test/Driver/arm-features.c Index:

[PATCH] D66294: [Docs][OpenCL] Release 9.0 notes for OpenCL

2019-08-15 Thread Anastasia Stulova via Phabricator via cfe-commits
Anastasia created this revision. Anastasia added reviewers: svenvh, mantognini, hans. Herald added subscribers: ebevhan, jfb, yaxunl. https://reviews.llvm.org/D66294 Files: docs/ReleaseNotes.rst Index: docs/ReleaseNotes.rst ===

[PATCH] D65819: [Driver][Bundler] Improve bundling of object files.

2019-08-15 Thread Jonas Hahnfeld via Phabricator via cfe-commits
Hahnfeld added a comment. Please submit the test changes unrelated to the code changes in a separate patch! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65819/new/ https://reviews.llvm.org/D65819 ___ cfe-commits

[PATCH] D66290: [clang] Pragma vectorize_width() implies vectorize(enable)

2019-08-15 Thread Sjoerd Meijer via Phabricator via cfe-commits
SjoerdMeijer added a comment. Thanks for looking again! Good catch, feedback addressed. (forgot to add this message when I uploaded the new diff) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66290/new/ https://reviews.llvm.org/D66290 ___

[PATCH] D66018: [ARM] Take into account -mcpu and -mfpu options while handling 'crypto' feature

2019-08-15 Thread Kristina Bessonova via Phabricator via cfe-commits
krisb added a comment. @dnsampaio, thanks, this looks better. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66018/new/ https://reviews.llvm.org/D66018 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r368985 - Revert rL368939 "Remove LVALUE / RVALUE workarounds"

2019-08-15 Thread Russell Gallop via cfe-commits
Author: russell_gallop Date: Thu Aug 15 03:12:11 2019 New Revision: 368985 URL: http://llvm.org/viewvc/llvm-project?rev=368985=rev Log: Revert rL368939 "Remove LVALUE / RVALUE workarounds" This reverts commit cad8356d699b36c73abb267f65db575ddacbd652. To unbreak Windows bots Modified:

r368969 - [X86] Add test cases for _mm_movepi64_pi64 and _mm_movpi64_epi64.

2019-08-15 Thread Craig Topper via cfe-commits
Author: ctopper Date: Wed Aug 14 23:20:33 2019 New Revision: 368969 URL: http://llvm.org/viewvc/llvm-project?rev=368969=rev Log: [X86] Add test cases for _mm_movepi64_pi64 and _mm_movpi64_epi64. Modified: cfe/trunk/test/CodeGen/sse2-builtins.c Modified:

[PATCH] D64564: Loop pragma parsing. NFC.

2019-08-15 Thread Sjoerd Meijer via Phabricator via cfe-commits
SjoerdMeijer added a comment. Thanks, and will fix your suggestions before committing. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64564/new/ https://reviews.llvm.org/D64564 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D66261: [analyzer] Warn about -analyzer-configs being meant for development purposes only

2019-08-15 Thread Kristóf Umann via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL368980: [analyzer] Warn about -analyzer-configs being meant for development purposes… (authored by Szelethus, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits.

[PATCH] D60281: [analyzer] Add docs for cplusplus.InnerPointer

2019-08-15 Thread Kristóf Umann via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL368979: [analyzer] Add docs for cplusplus.InnerPointer (authored by Szelethus, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

r368970 - [Clang] Pragma vectorize_predicate implies vectorize

2019-08-15 Thread Sjoerd Meijer via cfe-commits
Author: sjoerdmeijer Date: Wed Aug 14 23:24:40 2019 New Revision: 368970 URL: http://llvm.org/viewvc/llvm-project?rev=368970=rev Log: [Clang] Pragma vectorize_predicate implies vectorize New pragma "vectorize_predicate(enable)" now implies "vectorize(enable)", and it is ignored when

[PATCH] D65776: [Clang] Pragma vectorize_predicate implies vectorize

2019-08-15 Thread Sjoerd Meijer via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL368970: [Clang] Pragma vectorize_predicate implies vectorize (authored by SjoerdMeijer, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D55562: Atomics: support min/max orthogonally

2019-08-15 Thread Tim Northover via Phabricator via cfe-commits
t.p.northover added a comment. Ping. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55562/new/ https://reviews.llvm.org/D55562 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r368979 - [analyzer] Add docs for cplusplus.InnerPointer

2019-08-15 Thread Kristof Umann via cfe-commits
Author: szelethus Date: Thu Aug 15 01:52:10 2019 New Revision: 368979 URL: http://llvm.org/viewvc/llvm-project?rev=368979=rev Log: [analyzer] Add docs for cplusplus.InnerPointer Differential Revision: https://reviews.llvm.org/D60281 Modified: cfe/trunk/docs/analyzer/checkers.rst Modified:

r368980 - [analyzer] Warn about -analyzer-configs being meant for development purposes only

2019-08-15 Thread Kristof Umann via cfe-commits
Author: szelethus Date: Thu Aug 15 01:53:16 2019 New Revision: 368980 URL: http://llvm.org/viewvc/llvm-project?rev=368980=rev Log: [analyzer] Warn about -analyzer-configs being meant for development purposes only This is more of a temporary fix, long term, we should convert AnalyzerOptions.def

[PATCH] D66266: [WIP][RISCV] Set MaxAtomicPromoteWidth and MaxAtomicInlineWidth

2019-08-15 Thread Sam Elliott via Phabricator via cfe-commits
lenary added a comment. Hi Pengxuan, Thanks for the patch! We have a similar patch from @asb under review at the moment, D57450 . There's one question about ABI compatibility that still needs to be answered, which we will discuss in the RISC-V sync-up later

r368990 - Replace llvm::integer_sequence and friends with the C++14 standard version

2019-08-15 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Thu Aug 15 03:56:05 2019 New Revision: 368990 URL: http://llvm.org/viewvc/llvm-project?rev=368990=rev Log: Replace llvm::integer_sequence and friends with the C++14 standard version The implementation in libc++ takes O(1) compile time, ours was O(n). Modified:

[clang-tools-extra] r368990 - Replace llvm::integer_sequence and friends with the C++14 standard version

2019-08-15 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Thu Aug 15 03:56:05 2019 New Revision: 368990 URL: http://llvm.org/viewvc/llvm-project?rev=368990=rev Log: Replace llvm::integer_sequence and friends with the C++14 standard version The implementation in libc++ takes O(1) compile time, ours was O(n). Modified:

[clang-tools-extra] r368991 - [clangd] llvm::integer_sequence -> std::integer_sequence.

2019-08-15 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Thu Aug 15 04:09:22 2019 New Revision: 368991 URL: http://llvm.org/viewvc/llvm-project?rev=368991=rev Log: [clangd] llvm::integer_sequence -> std::integer_sequence. Modified: clang-tools-extra/trunk/clangd/Function.h Modified: clang-tools-extra/trunk/clangd/Function.h URL:

[PATCH] D66294: [Docs][OpenCL] Release 9.0 notes for OpenCL

2019-08-15 Thread Sven van Haastregt via Phabricator via cfe-commits
svenvh added inline comments. Comment at: docs/ReleaseNotes.rst:173 + +- Added initial support for implicitly including OpenCL BIFs using + efficient trie lookup generated by TableGen. A corresponding mantognini wrote: > If the BIF acronym wasn't introduced

[PATCH] D65819: [Driver][Bundler] Improve bundling of object files.

2019-08-15 Thread Alexey Bataev via Phabricator via cfe-commits
ABataev updated this revision to Diff 215421. ABataev added a comment. Rebase Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65819/new/ https://reviews.llvm.org/D65819 Files: test/Driver/clang-offload-bundler.c

[PATCH] D66014: [analyzer] Avoid unnecessary enum range check on LValueToRValue casts

2019-08-15 Thread Kristóf Umann via Phabricator via cfe-commits
Szelethus added a comment. Oh, there is no need for a new differential, you can update this one by clicking on 'update diff' in the right panel. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66014/new/ https://reviews.llvm.org/D66014

[PATCH] D66014: [analyzer] Avoid unnecessary enum range check on LValueToRValue casts

2019-08-15 Thread Kristóf Umann via Phabricator via cfe-commits
Szelethus added a comment. Yup, you can upload it and the green checkmark will stay. If it doesn't, I'll accept again. I think there was one case when I added like 800 extra LOCs to a patch and phabricator automatically marked it as "needs reviews", but I never came across this after that,

[PATCH] D65819: [Driver][Bundler] Improve bundling of object files.

2019-08-15 Thread Jonas Hahnfeld via Phabricator via cfe-commits
Hahnfeld accepted this revision. Hahnfeld added a comment. This revision is now accepted and ready to land. LG, thanks for the changes. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65819/new/ https://reviews.llvm.org/D65819

r369019 - [Driver][Bundler] Improve bundling of object files.

2019-08-15 Thread Alexey Bataev via cfe-commits
Author: abataev Date: Thu Aug 15 10:15:35 2019 New Revision: 369019 URL: http://llvm.org/viewvc/llvm-project?rev=369019=rev Log: [Driver][Bundler] Improve bundling of object files. Summary: Previously, object files were bundled using partial linking. It resulted in the following structure of the

[PATCH] D66014: [analyzer] Avoid unnecessary enum range check on LValueToRValue casts

2019-08-15 Thread Chris Hamilton via Phabricator via cfe-commits
chrish_ericsson_atx updated this revision to Diff 215433. chrish_ericsson_atx added a comment. Follow-up on reviewer feedback. Changed from blacklisting LValueToRValue to whitelisting IntegralCast. This was a good call -- additional testing with different cast kinds showed that the assertion

[PATCH] D63260: [Attr] Support _attribute__ ((fallthrough))

2019-08-15 Thread Kees Cook via Phabricator via cfe-commits
kees added a comment. For latest version see https://reviews.llvm.org/D64838 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63260/new/ https://reviews.llvm.org/D63260 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D66296: [BUNDLER]Improve the test, NFC.

2019-08-15 Thread Alexey Bataev via Phabricator via cfe-commits
ABataev created this revision. ABataev added reviewers: Hahnfeld, hfinkel. Herald added a reviewer: jdoerfert. Herald added a project: clang. Make the test more portable and do not rely on the pre-bundled object file. Repository: rC Clang https://reviews.llvm.org/D66296 Files:

[PATCH] D66040: [Sema] Implement DR2386 for C++17 structured binding

2019-08-15 Thread Reid Kleckner via Phabricator via cfe-commits
rnk marked an inline comment as done. rnk added a comment. In D66040#1631658 , @thakis wrote: > rnk, what's the status here? I think I can get this in today, things just got busy here and I forgot about this. I have to add that test.

[PATCH] D66299: [clang-doc] Sort index elements case insensitive

2019-08-15 Thread Diego Astiazarán via Phabricator via cfe-commits
DiegoAstiazaran created this revision. DiegoAstiazaran added reviewers: juliehockett, jakehehrlich. DiegoAstiazaran added a project: clang-tools-extra. Herald added a subscriber: arphaman. Implement logic to compare the references of the index case insensitive. https://reviews.llvm.org/D66299

[PATCH] D66296: [BUNDLER]Improve the test, NFC.

2019-08-15 Thread Jonas Hahnfeld via Phabricator via cfe-commits
Hahnfeld accepted this revision. Hahnfeld added a comment. This revision is now accepted and ready to land. LG Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66296/new/ https://reviews.llvm.org/D66296 ___ cfe-commits

r369015 - [BUNDLER]Improve the test, NFC.

2019-08-15 Thread Alexey Bataev via cfe-commits
Author: abataev Date: Thu Aug 15 09:28:24 2019 New Revision: 369015 URL: http://llvm.org/viewvc/llvm-project?rev=369015=rev Log: [BUNDLER]Improve the test, NFC. Summary: Make the test more portable and do not rely on the pre-bundled object file. Reviewers: Hahnfeld, hfinkel, jdoerfert

Re: r368874 - Document clang-cpp in the release notes for clang

2019-08-15 Thread Chris Bieneman via cfe-commits
It actually does not. Getting the MSVC export list is a much harder problem. I'll update the release note. -Chris > On Aug 14, 2019, at 10:32 PM, Kim Gräsman wrote: > > On Wed, Aug 14, 2019 at 6:48 PM Chris Bieneman via cfe-commits > wrote: >> >> Author: cbieneman >> Date: Wed Aug 14

[PATCH] D65819: [Driver][Bundler] Improve bundling of object files.

2019-08-15 Thread Alexey Bataev via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL369019: [Driver][Bundler] Improve bundling of object files. (authored by ABataev, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES

[PATCH] D66294: [Docs][OpenCL] Release 9.0 notes for OpenCL

2019-08-15 Thread Marco Antognini via Phabricator via cfe-commits
mantognini requested changes to this revision. mantognini added a comment. This revision now requires changes to proceed. The overall structure seems alright. I'll let people more familiar with the code-base judge whether other important features should be added there as well.

[PATCH] D65634: [RISCV] Default to ilp32d/lp64d in RISC-V Linux

2019-08-15 Thread Luís Marques via Phabricator via cfe-commits
luismarques added inline comments. Comment at: clang/lib/Driver/ToolChains/Arch/RISCV.cpp:386 + else +return Triple.getArch() == llvm::Triple::riscv32 ? "ilp32" : "lp64"; } When I compile a bare metal GNU toolchain (using

[PATCH] D66298: [clang-doc] Fix records in global namespace

2019-08-15 Thread Julie Hockett via Phabricator via cfe-commits
juliehockett added inline comments. Comment at: clang-tools-extra/unittests/clang-doc/SerializeTest.cpp:299 RecordInfo *G = InfoAsRecord(Infos[2].get()); - RecordInfo ExpectedG(EmptySID, /*Name=*/"G", /*Path=*/"E"); + RecordInfo ExpectedG(EmptySID, /*Name=*/"G",

[PATCH] D66302: [SVE][Inline-Asm] Support for SVE asm operands

2019-08-15 Thread Kerry McLaughlin via Phabricator via cfe-commits
kmclaughlin created this revision. kmclaughlin added reviewers: t.p.northover, sdesmalen, rovka, momchil.velikov. Herald added subscribers: psnobl, rkruppe, tschuett, javed.absar. Herald added a reviewer: rengolin. Herald added a project: LLVM. Adds the following inline asm constraints for SVE:

[PATCH] D66003: [RISCV] Make -march=rv{32, 64}gc the default in RISC-V Linux

2019-08-15 Thread Luís Marques via Phabricator via cfe-commits
luismarques accepted this revision. luismarques added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66003/new/ https://reviews.llvm.org/D66003

[PATCH] D66014: [analyzer] Avoid unnecessary enum range check on LValueToRValue casts

2019-08-15 Thread Chris Hamilton via Phabricator via cfe-commits
chrish_ericsson_atx marked 5 inline comments as done. chrish_ericsson_atx added a comment. In D66014#1627858 , @Szelethus wrote: > LGTM, thanks! Do you need someone to commit this on your behalf? Also, could > you please make the comments capitalized,

[PATCH] D64811: Warn when NumParams overflows

2019-08-15 Thread Mark de Wever via Phabricator via cfe-commits
Mordante updated this revision to Diff 215425. Mordante added a comment. Moved the testing from Parse to Sema. Added additional safeguards for template instantiation. Added more unit tests. The comments may be a bit noisy, but they explain why the templates need to be tested at two locations.

[PATCH] D66298: [clang-doc] Fix records in global namespace

2019-08-15 Thread Diego Astiazarán via Phabricator via cfe-commits
DiegoAstiazaran created this revision. DiegoAstiazaran added reviewers: juliehockett, jakehehrlich. DiegoAstiazaran added a project: clang-tools-extra. When a Record is declared in the global namespace, clang-doc serializes it as a child of the global namespace, so the global namespace is now

[PATCH] D66296: [BUNDLER]Improve the test, NFC.

2019-08-15 Thread Alexey Bataev via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL369015: [BUNDLER]Improve the test, NFC. (authored by ABataev, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINCE LAST ACTION

r369020 - Test commit #2.

2019-08-15 Thread George Karpenkov via cfe-commits
Author: george.karpenkov Date: Thu Aug 15 10:17:21 2019 New Revision: 369020 URL: http://llvm.org/viewvc/llvm-project?rev=369020=rev Log: Test commit #2. Modified: cfe/trunk/www/index.html Modified: cfe/trunk/www/index.html URL:

[PATCH] D66186: [Sema] Don't warn on printf('%hd', [char]) (PR41467)

2019-08-15 Thread Nathan Huckleberry via Phabricator via cfe-commits
Nathan-Huckleberry added a comment. In D66186#1630427 , @aaron.ballman wrote: > There was a request in the linked bug for some code archaeology to see why > this behavior exists in the first place. What were the results of that? I'm > not opposed to

[PATCH] D66186: [Sema] Don't warn on printf('%hd', [char]) (PR41467)

2019-08-15 Thread Roman Lebedev via Phabricator via cfe-commits
lebedev.ri added a comment. In D66186#1631921 , @Nathan-Huckleberry wrote: > In D66186#1630427 , @aaron.ballman > wrote: > > > There was a request in the linked bug for some code archaeology to see why > > this

[PATCH] D65634: [RISCV] Default to ilp32d/lp64d in RISC-V Linux

2019-08-15 Thread Luís Marques via Phabricator via cfe-commits
luismarques added inline comments. Comment at: clang/lib/Driver/ToolChains/Arch/RISCV.cpp:386 + else +return Triple.getArch() == llvm::Triple::riscv32 ? "ilp32" : "lp64"; } luismarques wrote: > When I compile a bare metal GNU toolchain (using >

[PATCH] D52524: Add -Wno-poison-system-directories flag

2019-08-15 Thread Nico Weber via Phabricator via cfe-commits
thakis added a comment. Ok, makes sense, thanks for explaining. Please add a summary of that discussion to the patch description / commit message :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D52524/new/ https://reviews.llvm.org/D52524

[PATCH] D66040: [Sema] Implement DR2386 for C++17 structured binding

2019-08-15 Thread Nico Weber via Phabricator via cfe-commits
thakis added a comment. rnk, what's the status here? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66040/new/ https://reviews.llvm.org/D66040 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D66303: [LifetimeAnalysis] Add support for free functions

2019-08-15 Thread Gábor Horváth via Phabricator via cfe-commits
xazax.hun created this revision. xazax.hun added reviewers: mgehre, gribozavr. xazax.hun added a project: clang. Herald added subscribers: Szelethus, Charusso, gamesh411, dkrupp, rnkovacs. This patch adds support to the idiom when people using the free version of `begin`, `end` and the like

[PATCH] D66040: [Sema] Implement DR2386 for C++17 structured binding

2019-08-15 Thread Reid Kleckner via Phabricator via cfe-commits
rnk updated this revision to Diff 215442. rnk added a comment. - add DR test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66040/new/ https://reviews.llvm.org/D66040 Files: clang/lib/Sema/SemaDeclCXX.cpp

r369028 - Fix the test, NFC.

2019-08-15 Thread Alexey Bataev via cfe-commits
Author: abataev Date: Thu Aug 15 10:53:49 2019 New Revision: 369028 URL: http://llvm.org/viewvc/llvm-project?rev=369028=rev Log: Fix the test, NFC. Modified: cfe/trunk/test/Driver/clang-offload-bundler.c Modified: cfe/trunk/test/Driver/clang-offload-bundler.c URL:

[PATCH] D66186: [Sema] Don't warn on printf('%hd', [char]) (PR41467)

2019-08-15 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added a comment. In D66186#1631921 , @Nathan-Huckleberry wrote: > In D66186#1630427 , @aaron.ballman > wrote: > > > There was a request in the linked bug for some code archaeology to see why > >

[PATCH] D61466: [Rewrite][NFC] Add FIXMEs and tests for RemoveLineIfEmpty bug

2019-08-15 Thread Jan Korous via Phabricator via cfe-commits
jkorous accepted this revision. jkorous added a comment. This revision is now accepted and ready to land. LGTM. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61466/new/ https://reviews.llvm.org/D61466 ___ cfe-commits mailing list

[PATCH] D66040: [Sema] Implement DR2386 for C++17 structured binding

2019-08-15 Thread Richard Smith - zygoloid via Phabricator via cfe-commits
rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. LGTM with minor adjustments to the test. Comment at: clang/test/CXX/drs/dr23xx.cpp:43-57 +#if __cplusplus >= 201707L +// Otherwise, if the qualified-id std::tuple_size names

[PATCH] D66303: [LifetimeAnalysis] Add support for free functions

2019-08-15 Thread Matthias Gehre via Phabricator via cfe-commits
mgehre added inline comments. Comment at: clang/lib/Sema/SemaInit.cpp:6622 +return false; + const auto *RD = FD->getParamDecl(0)->getType()->getPointeeCXXRecordDecl(); + if (!FD->isInStdNamespace() || !RD || !RD->isInStdNamespace()) Maybe move the

[PATCH] D59692: [ASTImporter] Fix name conflict handling

2019-08-15 Thread Shafik Yaghmour via Phabricator via cfe-commits
shafik added a comment. Just wanted to see if you were planning on landing this soon, the fix `Name` -> `SearchName` is probably an important one since we have seen several issues w/ bugs like that but I really would like to see more tests. Are you having issues coming up w/ tests?

[PATCH] D66267: [analyzer] TrackConstraintBRVisitor: Do not track unknown values

2019-08-15 Thread Kristóf Umann via Phabricator via cfe-commits
Szelethus added a comment. In D66267#1632164 , @NoQ wrote: > In D66267#1630728 , @Szelethus wrote: > > > Shouldn't we just delete this entire visitor altogether and merge it into > > ConditionBRVisitor (like,

[PATCH] D66151: [clang-doc] Fix bitcode writer

2019-08-15 Thread Diego Astiazarán via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL369063: [clang-doc] Fix bitcode writer for access specifiers (authored by DiegoAstiazaran, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[clang-tools-extra] r369063 - [clang-doc] Fix bitcode writer for access specifiers

2019-08-15 Thread Diego Astiazaran via cfe-commits
Author: diegoastiazaran Date: Thu Aug 15 16:04:27 2019 New Revision: 369063 URL: http://llvm.org/viewvc/llvm-project?rev=369063=rev Log: [clang-doc] Fix bitcode writer for access specifiers Bitcode writer was not emitting the corresponding record for the Access attribute of a FunctionInfo. This

[PATCH] D66267: [analyzer] TrackConstraintBRVisitor: Do not track unknown values

2019-08-15 Thread Csaba Dabis via Phabricator via cfe-commits
Charusso marked an inline comment as done. Charusso added a comment. @Szelethus pointed out well. My patch is about nullability, and it is perfect. The bug report you made is about deduplication rather than nullability. The fact is we fail to call the deduplication function:

[clang-tools-extra] r369065 - [clang-doc] Fix use of source-root flag

2019-08-15 Thread Diego Astiazaran via cfe-commits
Author: diegoastiazaran Date: Thu Aug 15 16:20:42 2019 New Revision: 369065 URL: http://llvm.org/viewvc/llvm-project?rev=369065=rev Log: [clang-doc] Fix use of source-root flag The value, if any, of --source-root flag was not being used. This has been fixed and the logic was moved to the

[PATCH] D66268: [clang-doc] Fix use of source-root flag

2019-08-15 Thread Diego Astiazarán via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL369065: [clang-doc] Fix use of source-root flag (authored by DiegoAstiazaran, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D66299: [clang-doc] Sort index elements case insensitive

2019-08-15 Thread Diego Astiazarán via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL369068: [clang-doc] Sort index elements case insensitive (authored by DiegoAstiazaran, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D66238: [clang-doc] Serialize inherited attributes and methods

2019-08-15 Thread Diego Astiazarán via Phabricator via cfe-commits
DiegoAstiazaran updated this revision to Diff 215506. DiegoAstiazaran added a comment. Rebase to master CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66238/new/ https://reviews.llvm.org/D66238 Files: clang-tools-extra/clang-doc/BitcodeReader.cpp

[PATCH] D66267: [analyzer] TrackConstraintBRVisitor: Do not track unknown values

2019-08-15 Thread Kristóf Umann via Phabricator via cfe-commits
Szelethus added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/BugReporterVisitors.cpp:1898-1900 + // If the contents are symbolic and null, find out when they became null. + if (V.getAsLocSymbol(/*IncludeBaseRegions=*/true)) +if

[PATCH] D63889: Check possible warnings on global initializers for reachability

2019-08-15 Thread Richard Smith - zygoloid via Phabricator via cfe-commits
rsmith added inline comments. Comment at: clang/include/clang/Sema/Sema.h:1684-1686 + void pushDeclForInitializer(Decl *D) { DeclForInitializer.push_back(D); } + + void popDeclForInitializer() { DeclForInitializer.pop_back(); } I don't think a simple list of

[PATCH] D66238: [clang-doc] Serialize inherited attributes and methods

2019-08-15 Thread Diego Astiazarán via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL369075: [clang-doc] Serialize inherited attributes and methods (authored by DiegoAstiazaran, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to

[clang-tools-extra] r369075 - [clang-doc] Serialize inherited attributes and methods

2019-08-15 Thread Diego Astiazaran via cfe-commits
Author: diegoastiazaran Date: Thu Aug 15 17:10:49 2019 New Revision: 369075 URL: http://llvm.org/viewvc/llvm-project?rev=369075=rev Log: [clang-doc] Serialize inherited attributes and methods clang-doc now serializes the inherited attributes and methods, not only the name of the base class. All

[PATCH] D66014: [analyzer] Avoid unnecessary enum range check on LValueToRValue casts

2019-08-15 Thread Kristóf Umann via Phabricator via cfe-commits
Szelethus added a comment. You seem to have diffed against your latest local commit, rather than against trunk (or master, if you use the monorepo). Phabricator isn't smart enough to put two and two together, and only displays the uploaded diff (though one has to admit, its doing a damn good

[PATCH] D61466: [Rewrite][NFC] Add FIXMEs and tests for RemoveLineIfEmpty bug

2019-08-15 Thread Joel E. Denny via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL369049: [Rewrite][NFC] Add FIXMEs and tests for RemoveLineIfEmpty bug (authored by jdenny, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D66267: [analyzer] TrackConstraintBRVisitor: Do not track unknown values

2019-08-15 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. This code is super messy. It'd be great to actually test this change on something to see if it has any unwanted side effects. Could you see if it also fixes

[PATCH] D66267: [analyzer] TrackConstraintBRVisitor: Do not track unknown values

2019-08-15 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ added a comment. In D66267#1630728 , @Szelethus wrote: > Shouldn't we just delete this entire visitor altogether and merge it into > ConditionBRVisitor (like, eventually, not right now)? It seems to be a relic > of the past. I'm actually curious

[PATCH] D66092: [CodeGen] Generate constrained fp intrinsics depending on FPOptions

2019-08-15 Thread Andy Kaylor via Phabricator via cfe-commits
andrew.w.kaylor added a comment. In D66092#1630997 , @sepavloff wrote: > Replacement of floating point operations with constrained intrinsics seems > more an optimization helper then a semantic requirement. IR where constrained > operations are mixed

[PATCH] D65453: Improve the accuracy of the Clang call graph analysis

2019-08-15 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ added a comment. Thanks! This looks very useful. Comment at: clang/lib/Analysis/CallGraph.cpp:97-102 +const auto *ConstructedType = Ctor->getParent(); +if (ConstructedType->hasUserDeclaredDestructor()) { + CXXDestructorDecl *Dtor =

[PATCH] D65907: Introduce FileEntryRef and use it when handling includes to report correct dependencies when the FileManager is reused across invocations

2019-08-15 Thread Michael Spencer via Phabricator via cfe-commits
Bigcheese requested changes to this revision. Bigcheese added inline comments. This revision now requires changes to proceed. Comment at: clang/include/clang/Basic/SourceManager.h:1024 + Optional getFileEntryRefForID(FileID FID) const { +bool MyInvalid = false; +const

[clang-tools-extra] r369068 - [clang-doc] Sort index elements case insensitive

2019-08-15 Thread Diego Astiazaran via cfe-commits
Author: diegoastiazaran Date: Thu Aug 15 16:32:12 2019 New Revision: 369068 URL: http://llvm.org/viewvc/llvm-project?rev=369068=rev Log: [clang-doc] Sort index elements case insensitive Implement logic to compare the references of the index case insensitive. Differential revision:

[PATCH] D66186: [Sema] Don't warn on printf('%hd', [char]) (PR41467)

2019-08-15 Thread Nathan Huckleberry via Phabricator via cfe-commits
Nathan-Huckleberry added a comment. As far as I can tell this case was just overlooked. The original commit adding this change https://reviews.llvm.org/rG0208793e41018ac168412a3da8b2fba70aba9716 only allows chars to int and chars to chars. Another commit ignores typing of chars

[PATCH] D59922: [Attributor] Deduce "no-capture" argument attribute

2019-08-15 Thread Johannes Doerfert via Phabricator via cfe-commits
jdoerfert updated this revision to Diff 215498. jdoerfert added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59922/new/ https://reviews.llvm.org/D59922 Files: llvm/include/llvm/Transforms/IPO/Attributor.h

[PATCH] D59922: [Attributor] Deduce "no-capture" argument attribute

2019-08-15 Thread Johannes Doerfert via Phabricator via cfe-commits
jdoerfert updated this revision to Diff 215504. jdoerfert added a comment. Extracted CaptureTracking changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59922/new/ https://reviews.llvm.org/D59922 Files:

[PATCH] D66324: clang-misexpect: Profile Guided Validation of Performance Annotations in LLVM

2019-08-15 Thread Paul Kirth via Phabricator via cfe-commits
paulkirth created this revision. paulkirth added reviewers: phosek, leonardchan, jakehehrlich, mcgrathr. Herald added subscribers: llvm-commits, cfe-commits, hiraditya, mgorny. Herald added projects: clang, LLVM. paulkirth added a parent revision: D65300: [clang] [CodeGen] clang-misexpect

  1   2   >