[PATCH] D60465: [ASTImporter] Error handling fix in ImportDefinition_New.

2019-08-22 Thread Balázs Kéri via Phabricator via cfe-commits
balazske abandoned this revision. balazske added a comment. This change is obsolete in the current code. Casting related changes do not look important (and should be a new patch anyway). Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60465/new/

[PATCH] D66538: [AST] AST structural equivalence to work internally with pairs.

2019-08-22 Thread Balázs Kéri via Phabricator via cfe-commits
balazske marked an inline comment as done. balazske added inline comments. Comment at: clang/lib/AST/ASTStructuralEquivalence.cpp:1586 - if (EquivToD1) -return EquivToD1 == D2->getCanonicalDecl(); It looks like that the original code is correct in the

[PATCH] D66541: [clangd] Send highlighting diff beyond the end of the file.

2019-08-22 Thread Johan Vikström via Phabricator via cfe-commits
jvikstrom accepted this revision. jvikstrom added a comment. This revision is now accepted and ready to land. It feels a bit strange to be sending highlighting (even if they are empty) beyond eof. But I guess the proposal does not specify this and it would make life for the vscode extension

[PATCH] D66555: [driver] add a new option `-gen-cdb-fragment-path` to emit a fragment of a compilation database for each compilation

2019-08-22 Thread Thorsten via Phabricator via cfe-commits
tschuett added a comment. How does it relate to the -MJ option? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66555/new/ https://reviews.llvm.org/D66555 ___ cfe-commits mailing list

Re: r369591 - [LifetimeAnalysis] Support more STL idioms (template forward declaration and DependentNameType)

2019-08-22 Thread Diana Picus via cfe-commits
Hi Matthias, It seems this is breaking some of our AArch64 bots: http://lab.llvm.org:8011/builders/clang-cmake-aarch64-quick/builds/19691 http://lab.llvm.org:8011/builders/clang-cmake-aarch64-global-isel/builds/12022 You probably didn't notice it because something else also failed in that build

r369629 - Remove an unused function, suppress -Wunused-function warning.

2019-08-22 Thread Haojian Wu via cfe-commits
Author: hokein Date: Thu Aug 22 01:49:41 2019 New Revision: 369629 URL: http://llvm.org/viewvc/llvm-project?rev=369629=rev Log: Remove an unused function, suppress -Wunused-function warning. Modified: cfe/trunk/lib/StaticAnalyzer/Checkers/CastValueChecker.cpp Modified:

[PATCH] D66578: Remove \brief commands from doxygen comments.

2019-08-22 Thread Ilya Biryukov via Phabricator via cfe-commits
ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM. Kill it with fire Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66578/new/ https://reviews.llvm.org/D66578

[clang-tools-extra] r369631 - [clangd] The ClangdServer::EnableHiddenFeatures is not used any more.

2019-08-22 Thread Haojian Wu via cfe-commits
Author: hokein Date: Thu Aug 22 02:01:04 2019 New Revision: 369631 URL: http://llvm.org/viewvc/llvm-project?rev=369631=rev Log: [clangd] The ClangdServer::EnableHiddenFeatures is not used any more. Remove it. Modified: clang-tools-extra/trunk/clangd/ClangdServer.h Modified:

[PATCH] D66538: [AST] AST structural equivalence to work internally with pairs.

2019-08-22 Thread Gabor Marton via Phabricator via cfe-commits
martong added inline comments. Comment at: clang/lib/AST/ASTStructuralEquivalence.cpp:1586 - if (EquivToD1) -return EquivToD1 == D2->getCanonicalDecl(); balazske wrote: > It looks like that the original code is correct in the decision of structural >

[PATCH] D66302: [SVE][Inline-Asm] Support for SVE asm operands

2019-08-22 Thread Kerry McLaughlin via Phabricator via cfe-commits
kmclaughlin updated this revision to Diff 216574. kmclaughlin added a comment. - Changed printAsmRegInClass in AArch64AsmPrinter.cpp to accept //unsigned AltName// instead of //bool isVector// - Added a comment to explain the test in aarch64-sve-asm-negative.ll CHANGES SINCE LAST ACTION

[PATCH] D66336: [ASTImporter] Add development internals docs

2019-08-22 Thread Gabor Marton via Phabricator via cfe-commits
martong updated this revision to Diff 216579. martong marked an inline comment as done. martong added a comment. - Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66336/new/ https://reviews.llvm.org/D66336 Files:

[PATCH] D66336: [ASTImporter] Add development internals docs

2019-08-22 Thread Gabor Marton via Phabricator via cfe-commits
martong marked 6 inline comments as done. martong added a comment. Thanks for the review! Comment at: clang/docs/InternalsManual.rst:1470 +*templated* class (the ``CXXRecordDecl``) of a ``ClassTemplateDecl`` with +``ClassTemplateDecl::getTemplatedDec()``. And we can get back a

Re: r369458 - [DebugInfo] Add debug location to dynamic atexit destructor

2019-08-22 Thread Hans Wennborg via cfe-commits
This broke the Chromium build, see https://bugs.chromium.org/p/chromium/issues/detail?id=996618#c1 for a reproducer. I've reverted in r369633. On Wed, Aug 21, 2019 at 12:08 AM Alexandre Ganea via cfe-commits wrote: > > Author: aganea > Date: Tue Aug 20 15:09:49 2019 > New Revision: 369458 > >

r369633 - Revert r369458 "[DebugInfo] Add debug location to dynamic atexit destructor"

2019-08-22 Thread Hans Wennborg via cfe-commits
Author: hans Date: Thu Aug 22 02:07:25 2019 New Revision: 369633 URL: http://llvm.org/viewvc/llvm-project?rev=369633=rev Log: Revert r369458 "[DebugInfo] Add debug location to dynamic atexit destructor" It causes the build to fail with "inlinable function call in a function with debug info must

r369641 - [OpenCL] Fix declaration of enqueue_marker

2019-08-22 Thread Yaxun Liu via cfe-commits
Author: yaxunl Date: Thu Aug 22 04:18:59 2019 New Revision: 369641 URL: http://llvm.org/viewvc/llvm-project?rev=369641=rev Log: [OpenCL] Fix declaration of enqueue_marker Differential Revision: https://reviews.llvm.org/D66512 Modified: cfe/trunk/lib/Headers/opencl-c.h Modified:

[PATCH] D66512: [OpenCL] Fix declaration of enqueue_marker

2019-08-22 Thread Yaxun Liu via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL369641: [OpenCL] Fix declaration of enqueue_marker (authored by yaxunl, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D66397: [Diagnostics] Improve -Wxor-used-as-pow

2019-08-22 Thread Dávid Bolvanský via Phabricator via cfe-commits
xbolva00 added a comment. >> I think adding parens and casts are fairly well-understood to suppress >> warnings. It should work here as well. #define ALPHA_OFFSET (3). Did anobody from Chromium try it? >> They have varying levels of C++ proficiency I consider things like hex decimals or

[PATCH] D64695: [clang-format] Modified SortIncludes and IncludeCategories to priority for sorting #includes within the Group Category.

2019-08-22 Thread Manikishan Ghantasala via Phabricator via cfe-commits
Manikishan updated this revision to Diff 216576. Manikishan edited the summary of this revision. Manikishan added a comment. I have removed the introduction to the NetBSDStyle, as there are some styles that are needed to implemented before launching the NetBSD style. Repository: rC Clang

[PATCH] D66541: [clangd] Send highlighting diff beyond the end of the file.

2019-08-22 Thread Haojian Wu via Phabricator via cfe-commits
hokein marked an inline comment as done. hokein added inline comments. Comment at: clang-tools-extra/clangd/unittests/SemanticHighlightingTests.cpp:625 + testing::UnorderedElementsAre( + testing::AllOf(LineNumber(3), EmptyHighlightings()), +

[PATCH] D66538: [AST] AST structural equivalence to work internally with pairs.

2019-08-22 Thread Gabor Marton via Phabricator via cfe-commits
martong added inline comments. Comment at: clang/unittests/AST/StructuralEquivalenceTest.cpp:1323 +NonEquivalentDecls.end()); + EXPECT_EQ(NonEquivalentDecls.find(std::make_pair(y1, y2)), +NonEquivalentDecls.end()); This should be

[PATCH] D66538: [AST] AST structural equivalence to work internally with pairs.

2019-08-22 Thread Balázs Kéri via Phabricator via cfe-commits
balazske marked an inline comment as done. balazske added inline comments. Comment at: clang/unittests/AST/StructuralEquivalenceTest.cpp:1323 +NonEquivalentDecls.end()); + EXPECT_EQ(NonEquivalentDecls.find(std::make_pair(y1, y2)), +

[PATCH] D64695: [clang-format] Modified SortIncludes and IncludeCategories to priority for sorting #includes within the Group Category.

2019-08-22 Thread MyDeveloperDay via Phabricator via cfe-commits
MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. LGTM Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64695/new/ https://reviews.llvm.org/D64695 ___ cfe-commits mailing list

[PATCH] D66397: [Diagnostics] Improve -Wxor-used-as-pow

2019-08-22 Thread Dávid Bolvanský via Phabricator via cfe-commits
xbolva00 added a comment. >> other warning that behaves differently for ordinary and hex literals Such literals should indicate that the user knows what he/she is doing (bit tricks, ..). I agree that there should be a additional docs (as we mentioned it and kindly pinged @hans) and not force

[PATCH] D66592: [clangd] Send suppported codeActionKinds to the client.

2019-08-22 Thread Haojian Wu via Phabricator via cfe-commits
hokein updated this revision to Diff 216625. hokein marked 3 inline comments as done. hokein added a comment. Fix the comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66592/new/ https://reviews.llvm.org/D66592 Files:

[PATCH] D66219: [clangd] Added a colorizer to the vscode extension.

2019-08-22 Thread Johan Vikström via Phabricator via cfe-commits
jvikstrom updated this revision to Diff 216624. jvikstrom added a comment. Added missing protected and comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66219/new/ https://reviews.llvm.org/D66219 Files:

[clang-tools-extra] r369656 - [clangd] Send suppported codeActionKinds to the client.

2019-08-22 Thread Haojian Wu via cfe-commits
Author: hokein Date: Thu Aug 22 07:53:45 2019 New Revision: 369656 URL: http://llvm.org/viewvc/llvm-project?rev=369656=rev Log: [clangd] Send suppported codeActionKinds to the client. Summary: This would make client know which codeActionKinds that clangd may return. VSCode will add a new entry

[PATCH] D66122: [CodeGen] Emit dynamic initializers for static TLS vars in outlined scopes

2019-08-22 Thread Princeton Ferro via Phabricator via cfe-commits
Prince781 added a comment. The more I think about this, the more I have doubts about whether this should be supported. For example, what happens in cases like this?: #include #include struct Object { int i; Object() : i(3) {} Object(int v) : i(3 + v) {} };

[PATCH] D66219: [clangd] Added a colorizer to the vscode extension.

2019-08-22 Thread Johan Vikström via Phabricator via cfe-commits
jvikstrom updated this revision to Diff 216621. jvikstrom marked 6 inline comments as done. jvikstrom added a comment. Rewrote the Highlighter class as we can override the highlighting method for the tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D66219: [clangd] Added a colorizer to the vscode extension.

2019-08-22 Thread Johan Vikström via Phabricator via cfe-commits
jvikstrom added a comment. I had completely forgotten we could just override the applyHighlightings method in the tests, everything is much simpler now. Basically this entire CL was rewritten just now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D53476: [clang-cl] Allowed -fopenmp work and link openmp library from per-runtime library directory

2019-08-22 Thread Peiyuan Song via Phabricator via cfe-commits
SquallATF added a comment. In D53476#1641049 , @hans wrote: > It looks like it was never committed. > > Peiyuan, what's the status here? This patch need rebase, I see recent have a commit rG7994e1d

[PATCH] D66598: [Clang][Bundler] Fix for a hang when unbundling fat binary

2019-08-22 Thread Sergey Dmitriev via Phabricator via cfe-commits
sdmitriev created this revision. sdmitriev added a reviewer: ABataev. Herald added a reviewer: jdoerfert. Herald added a project: clang. Herald added a subscriber: cfe-commits. clang-offload-bundler tool may hang under certain conditions when it extracts a subset of all available device bundles

[PATCH] D57450: [RISCV] Set MaxAtomicInlineWidth and MaxAtomicPromoteWidth for RV32/RV64 targets with atomics

2019-08-22 Thread James Y Knight via Phabricator via cfe-commits
jyknight added a comment. In D57450#1641190 , @lenary wrote: > @jyknight I hear where you're coming from. I'll see what I can do about the > psABI document. > > In that ticket, it's mentioned that the Darwin ABI explicitly says that > non-power-of-two

[PATCH] D66018: [ARM] Take into account -mcpu and -mfpu options while handling 'crypto' feature

2019-08-22 Thread Diogo N. Sampaio via Phabricator via cfe-commits
dnsampaio added a comment. Hi @krisb, thanks for looking into this, and sorry for the delay, was out for a week. Comment at: lib/Driver/ToolChains/Arch/ARM.cpp:486-490 + if (ArchKind == llvm::ARM::ArchKind::ARMV8A || + ArchKind == llvm::ARM::ArchKind::ARMV8_1A || +

[PATCH] D66592: [clangd] Send suppported codeActionKinds to the client.

2019-08-22 Thread Ilya Biryukov via Phabricator via cfe-commits
ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang-tools-extra/clangd/ClangdLSPServer.cpp:467 + // Per LSP, codeActionProvide can be either boolean or CodeActionOptions. + //

[PATCH] D66592: [clangd] Send suppported codeActionKinds to the client.

2019-08-22 Thread Haojian Wu via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL369656: [clangd] Send suppported codeActionKinds to the client. (authored by hokein, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D57450: [RISCV] Set MaxAtomicInlineWidth and MaxAtomicPromoteWidth for RV32/RV64 targets with atomics

2019-08-22 Thread Sam Elliott via Phabricator via cfe-commits
lenary added a comment. @jyknight I hear where you're coming from. I'll see what I can do about the psABI document. In that ticket, it's mentioned that the Darwin ABI explicitly says that non-power-of-two atomic types should be padded and realigned, but I cannot find any documentation

Re: r369641 - [OpenCL] Fix declaration of enqueue_marker

2019-08-22 Thread Anastasia Stulova via cfe-commits
Hi Hans, Can this still be merged into the release branch please. Thanks in advance, Anastasia From: cfe-commits on behalf of Yaxun Liu via cfe-commits Sent: 22 August 2019 12:18 To: cfe-commits@lists.llvm.org Subject: r369641 - [OpenCL] Fix declaration

[PATCH] D66516: [clangd] Added highlighting to types dependant on templates.

2019-08-22 Thread Johan Vikström via Phabricator via cfe-commits
jvikstrom marked an inline comment as done. jvikstrom added inline comments. Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:177 return; +if (TP->isPointerType() || TP->isLValueReferenceType()) + // When highlighting dependant template types the

[PATCH] D66516: [clangd] Added highlighting to types dependant on templates.

2019-08-22 Thread Ilya Biryukov via Phabricator via cfe-commits
ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:177 return; +if (TP->isPointerType() || TP->isLValueReferenceType()) + // When highlighting dependant template types the type can be a pointer or

[PATCH] D66591: [RISCV] Correct Logic around ilp32e macros

2019-08-22 Thread Sam Elliott via Phabricator via cfe-commits
lenary created this revision. lenary added reviewers: luismarques, asb. Herald added subscribers: cfe-commits, pzheng, s.egerton, Jim, benna, psnobl, jocewei, PkmX, rkruppe, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, MaskRay, jrtc27, shiva0217, kito-cheng, niosHD,

r369647 - Revert r369402 "win: Enable /Zc:twoPhase by default if targeting MSVC 2017 update 3 or newer"

2019-08-22 Thread Hans Wennborg via cfe-commits
Author: hans Date: Thu Aug 22 06:15:36 2019 New Revision: 369647 URL: http://llvm.org/viewvc/llvm-project?rev=369647=rev Log: Revert r369402 "win: Enable /Zc:twoPhase by default if targeting MSVC 2017 update 3 or newer" This broke compiling some ASan tests with never versions of MSVC/the Win

[PATCH] D57450: [RISCV] Set MaxAtomicInlineWidth and MaxAtomicPromoteWidth for RV32/RV64 targets with atomics

2019-08-22 Thread Sam Elliott via Phabricator via cfe-commits
lenary updated this revision to Diff 216594. lenary added a comment. Herald added a subscriber: pzheng. Update MaxAtomicPromote width to treat it like an ABI feature, and set it to 128 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57450/new/

[PATCH] D57450: [RISCV] Set MaxAtomicInlineWidth and MaxAtomicPromoteWidth for RV32/RV64 targets with atomics

2019-08-22 Thread Sam Elliott via Phabricator via cfe-commits
lenary added a comment. Cross linking to the relevant psABI pull request (still pending): https://github.com/riscv/riscv-elf-psabi-doc/pull/112 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57450/new/ https://reviews.llvm.org/D57450

[PATCH] D66593: [analyzer] CastValueChecker: Fix some assertions

2019-08-22 Thread Csaba Dabis via Phabricator via cfe-commits
Charusso marked an inline comment as done. Charusso added a comment. I am not sure how would I fix them, so I just commented them out. Comment at: clang/lib/StaticAnalyzer/Checkers/CastValueChecker.cpp:102 + else if (Ty->isReferenceType()) Ty = Ty.getNonReferenceType();

[PATCH] D66397: [Diagnostics] Improve -Wxor-used-as-pow

2019-08-22 Thread Nico Weber via Phabricator via cfe-commits
thakis added a comment. In D66397#1640685 , @xbolva00 wrote: > >> I think adding parens and casts are fairly well-understood to suppress > >> warnings. > > It should work here as well. #define ALPHA_OFFSET (3). Did anobody from > Chromium try it? > > >>

[PATCH] D66584: [clang-format] Support .mjs module javascript extension in clang-format

2019-08-22 Thread Fergal Daly via Phabricator via cfe-commits
fergald created this revision. fergald added a reviewer: MaskRay. Herald added a project: clang. Herald added a subscriber: cfe-commits. PR43085. This causes .mjs files to be treated as javascript. .mjs is the extension for module-javascript. Module javascript is not compatible with non-module

Re: r369402 - win: Enable /Zc:twoPhase by default if targeting MSVC 2017 update 3 or newer

2019-08-22 Thread Hans Wennborg via cfe-commits
Reverted in r369647 due to https://bugs.chromium.org/p/chromium/issues/detail?id=996675 On Tue, Aug 20, 2019 at 6:26 PM Nico Weber via cfe-commits wrote: > > Author: nico > Date: Tue Aug 20 09:28:11 2019 > New Revision: 369402 > > URL: http://llvm.org/viewvc/llvm-project?rev=369402=rev > Log: >

Re: r369093 - [RISCV] Add inline asm constraint A for RISC-V

2019-08-22 Thread Hans Wennborg via cfe-commits
Merged to release_90 in r369649. On Fri, Aug 16, 2019 at 12:22 PM Lewis Revill via cfe-commits wrote: > > Author: lewis-revill > Date: Fri Aug 16 03:23:56 2019 > New Revision: 369093 > > URL: http://llvm.org/viewvc/llvm-project?rev=369093=rev > Log: > [RISCV] Add inline asm constraint A for

[PATCH] D66590: [clangd] Fix toHalfOpenFileRange where start/end endpoints are in different files due to #include

2019-08-22 Thread Sam McCall via Phabricator via cfe-commits
sammccall marked 4 inline comments as done. sammccall added inline comments. Comment at: clang-tools-extra/clangd/SourceCode.cpp:318 -// Check if two locations have the same file id. -static bool inSameFile(SourceLocation Loc1, SourceLocation Loc2, - const

[PATCH] D66592: [clangd] Send suppported codeActionKinds to the client.

2019-08-22 Thread Haojian Wu via Phabricator via cfe-commits
hokein created this revision. hokein added a reviewer: ilya-biryukov. Herald added subscribers: kadircet, arphaman, jkorous, MaskRay. Herald added a project: clang. This would make client know which codeActionKinds that clangd may return. VSCode will add a new entry "Refactor..." (which shows

[PATCH] D66559: [OPENMP] Update the diagnosis message for canonical loop form

2019-08-22 Thread Alexey Bataev via Phabricator via cfe-commits
ABataev added a comment. `!=` form is part of OpenMP 5.0. It would be good to allow this form for OpenMP 5.0 only and emit this new error message only for OpenMP 5.0 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66559/new/

[PATCH] D66588: [ARM NEON] Avoid duplicated decarations

2019-08-22 Thread Diogo N. Sampaio via Phabricator via cfe-commits
dnsampaio created this revision. dnsampaio added reviewers: t.p.northover, ostannard. Herald added subscribers: cfe-commits, kristof.beyls, javed.absar. Herald added a project: clang. The declaration of arm neon intrinsics that are "big endian safe" print the same code for big and small endian

[PATCH] D66397: [Diagnostics] Improve -Wxor-used-as-pow

2019-08-22 Thread Bruno Ricci via Phabricator via cfe-commits
riccibruno added a comment. > This should not warn. Please verify that patch was applied correctly and you > use newly built clang with this patch. (I use arc patch DX) You were right, I messed up on my side. Sorry about the noise ! I don't have much to add to the macro yes/no discussion

[PATCH] D53476: [clang-cl] Allowed -fopenmp work and link openmp library from per-runtime library directory

2019-08-22 Thread Hans Wennborg via Phabricator via cfe-commits
hans added a comment. It looks like it was never committed. Peiyuan, what's the status here? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53476/new/ https://reviews.llvm.org/D53476 ___ cfe-commits mailing list

[PATCH] D66590: [clangd] Fix toHalfOpenFileRange where start/end endpoints are in different files due to #include

2019-08-22 Thread Sam McCall via Phabricator via cfe-commits
sammccall created this revision. sammccall added a reviewer: SureYeaah. Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. https://github.com/clangd/clangd/issues/129 Repository: rG LLVM Github Monorepo

[PATCH] D66122: [CodeGen] Emit dynamic initializers for static TLS vars in outlined scopes

2019-08-22 Thread Princeton Ferro via Phabricator via cfe-commits
Prince781 marked an inline comment as done. Prince781 added a comment. In D66122#1639947 , @efriedma wrote: > But given that, I think we should submit a core issue, and hold off on > merging this until we hear back from the committee. I agree here.

[PATCH] D66590: [clangd] Fix toHalfOpenFileRange where start/end endpoints are in different files due to #include

2019-08-22 Thread Sam McCall via Phabricator via cfe-commits
sammccall updated this revision to Diff 216609. sammccall added a comment. kick phabricator to try to get it to mail Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66590/new/ https://reviews.llvm.org/D66590 Files:

[PATCH] D57450: [RISCV] Set MaxAtomicInlineWidth and MaxAtomicPromoteWidth for RV32/RV64 targets with atomics

2019-08-22 Thread James Y Knight via Phabricator via cfe-commits
jyknight added a comment. That GCC and Clang differ in handling of Atomics is a really unfortunate, longstanding issue. See https://bugs.llvm.org/show_bug.cgi?id=26462 For RISCV, perhaps it's not yet too late to have the RISCV psABI actually specify a single ABI for C11 _Atomic which all

[PATCH] D66593: [analyzer] CastValueChecker: Fix some assertions

2019-08-22 Thread Csaba Dabis via Phabricator via cfe-commits
Charusso created this revision. Charusso added a reviewer: NoQ. Charusso added a project: clang. Herald added subscribers: cfe-commits, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. - Repository: rC Clang https://reviews.llvm.org/D66593

[PATCH] D66538: [AST] AST structural equivalence to work internally with pairs.

2019-08-22 Thread Gabor Marton via Phabricator via cfe-commits
martong added a comment. > It looks like that the original code is correct in the decision of structural > equivalence of the original pair. If we have an (A,B) and (A,C) to compare, B > and C are in different decl chain, then (A,B) or (A,C) will be non-equivalent > (unless B and C are

[clang-tools-extra] r369666 - Fixed Missing Expected error handling

2019-08-22 Thread Shaurya Gupta via cfe-commits
Author: sureyeaah Date: Thu Aug 22 09:42:42 2019 New Revision: 369666 URL: http://llvm.org/viewvc/llvm-project?rev=369666=rev Log: Fixed Missing Expected error handling Modified: clang-tools-extra/trunk/clangd/unittests/TweakTesting.cpp Modified:

r369668 - [OPENMP]Generalization of handling of declare target attribute.

2019-08-22 Thread Alexey Bataev via cfe-commits
Author: abataev Date: Thu Aug 22 09:48:26 2019 New Revision: 369668 URL: http://llvm.org/viewvc/llvm-project?rev=369668=rev Log: [OPENMP]Generalization of handling of declare target attribute. Used OMPDeclareTargetDeclAttr::isDeclareTargetDeclaration instead of direct checking of the

[PATCH] D66555: [driver] add a new option `-gen-cdb-fragment-path` to emit a fragment of a compilation database for each compilation

2019-08-22 Thread Alex Lorenz via Phabricator via cfe-commits
arphaman added a comment. In D66555#1640603 , @tschuett wrote: > How does it relate to the -MJ option? Ah, I wasn't aware that such option existed. I should use it instead. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D66446: [clang][IFS] Adding new Interface Stubs format.

2019-08-22 Thread Saleem Abdulrasool via Phabricator via cfe-commits
compnerd accepted this revision. compnerd added a comment. This revision is now accepted and ready to land. Please add a test case for read/write, otherwise LGTM. Comment at: clang/lib/Frontend/InterfaceStubFunctionsConsumer.cpp:383 +auto VD =

[PATCH] D66601: [Clang][Bundler] Do not require host triple for extracting device bundles

2019-08-22 Thread Sergey Dmitriev via Phabricator via cfe-commits
sdmitriev created this revision. sdmitriev added a reviewer: ABataev. Herald added a reviewer: jdoerfert. Herald added a project: clang. Herald added a subscriber: cfe-commits. sdmitriev added a reviewer: hfinkel. Bundler currently requires host triple to be provided no matter if you are

[PATCH] D66573: [clang][ifs] Dropping older experimental interface stub formats.

2019-08-22 Thread Saleem Abdulrasool via Phabricator via cfe-commits
compnerd accepted this revision. compnerd added a comment. This revision is now accepted and ready to land. Please add a diagnostic to indicate that the provided value is invalid for the argument (or at at least extend the existing the tests to ensure that the old values are diagnosed in the

[clang-tools-extra] r369674 - Retire llvm::less/equal in favor of C++14 std::less<>/equal_to<>.

2019-08-22 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Thu Aug 22 10:31:59 2019 New Revision: 369674 URL: http://llvm.org/viewvc/llvm-project?rev=369674=rev Log: Retire llvm::less/equal in favor of C++14 std::less<>/equal_to<>. Modified: clang-tools-extra/trunk/clang-doc/Representation.h Modified:

r369675 - Retire llvm::less_ptr. llvm::deref is much more flexible.

2019-08-22 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Thu Aug 22 10:32:16 2019 New Revision: 369675 URL: http://llvm.org/viewvc/llvm-project?rev=369675=rev Log: Retire llvm::less_ptr. llvm::deref is much more flexible. Modified: cfe/trunk/lib/Serialization/ASTWriter.cpp cfe/trunk/utils/TableGen/NeonEmitter.cpp Modified:

Re: r369591 - [LifetimeAnalysis] Support more STL idioms (template forward declaration and DependentNameType)

2019-08-22 Thread Richard Smith via cfe-commits
Hi Matthias, This introduces false positives into -Wreturn-stack-address for an example such as: #include std::vector::iterator downcast_to(std::vector::iterator value) { return * } This breaks an internal build bot for us, so I'm going to revert this for now (though I expect this isn't the

[PATCH] D66437: Sema: Create a no-op implicit cast for lvalue function conversions.

2019-08-22 Thread Peter Collingbourne via Phabricator via cfe-commits
pcc added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66437/new/ https://reviews.llvm.org/D66437 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r369677 - Revert "[LifetimeAnalysis] Support more STL idioms (template forward declaration and DependentNameType)"

2019-08-22 Thread Richard Smith via cfe-commits
Author: rsmith Date: Thu Aug 22 10:48:11 2019 New Revision: 369677 URL: http://llvm.org/viewvc/llvm-project?rev=369677=rev Log: Revert "[LifetimeAnalysis] Support more STL idioms (template forward declaration and DependentNameType)" This reverts commit r369591, because it causes the

Re: r369591 - [LifetimeAnalysis] Support more STL idioms (template forward declaration and DependentNameType)

2019-08-22 Thread Richard Smith via cfe-commits
Reverted in r369677. On Thu, 22 Aug 2019 at 10:34, Richard Smith wrote: > Hi Matthias, > > This introduces false positives into -Wreturn-stack-address for an example > such as: > > #include > > std::vector::iterator downcast_to(std::vector::iterator value) { > return * > } > > This breaks an

[PATCH] D66492: [Clang][CodeGen] set alias linkage on QualType

2019-08-22 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. I am not an expert on the alias attribute, but from what I can tell (with much thanks to @erichkeane for also helping to verify), this matches the GCC behavior. LGTM, but can

Re: r261008 - Add a nullPointerConstant() AST matcher to handle variations of null pointer constants in one matcher.

2019-08-22 Thread Richard Smith via cfe-commits
(Sorry for the very late review!) On Tue, 16 Feb 2016 at 13:06, Aaron Ballman via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: aaronballman > Date: Tue Feb 16 15:02:23 2016 > New Revision: 261008 > > URL: http://llvm.org/viewvc/llvm-project?rev=261008=rev > Log: > Add a

[PATCH] D66302: [SVE][Inline-Asm] Support for SVE asm operands

2019-08-22 Thread Kerry McLaughlin via Phabricator via cfe-commits
kmclaughlin updated this revision to Diff 216655. kmclaughlin added a comment. - Removed a confusing comment from AArch64AsmPrinter.cpp CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66302/new/ https://reviews.llvm.org/D66302 Files: docs/LangRef.rst

[PATCH] D66446: [clang][IFS] Adding new Interface Stubs format.

2019-08-22 Thread Puyan Lotfi via Phabricator via cfe-commits
plotfi marked 4 inline comments as done. plotfi added inline comments. Comment at: clang/lib/Frontend/InterfaceStubFunctionsConsumer.cpp:383 +auto VD = cast(E.first)->getType(); +OS << "Object, Size: " + <<

[PATCH] D66606: IR. Change strip* family of functions to not look through aliases.

2019-08-22 Thread Peter Collingbourne via Phabricator via cfe-commits
pcc created this revision. pcc added a reviewer: rnk. Herald added subscribers: cfe-commits, aheejin, hiraditya, jgravelle-google, sbc100, dschuff, srhines. Herald added projects: clang, LLVM. I noticed another instance of the issue where references to aliases were being replaced with aliasees,

[clang-tools-extra] r369679 - [clangd] Fold string copy into lambda capture. NFC.

2019-08-22 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Thu Aug 22 11:09:46 2019 New Revision: 369679 URL: http://llvm.org/viewvc/llvm-project?rev=369679=rev Log: [clangd] Fold string copy into lambda capture. NFC. Modified: clang-tools-extra/trunk/clangd/ClangdServer.cpp Modified:

r369680 - Introduce FileEntryRef and use it when handling includes to report correct dependencies

2019-08-22 Thread Alex Lorenz via cfe-commits
Author: arphaman Date: Thu Aug 22 11:15:50 2019 New Revision: 369680 URL: http://llvm.org/viewvc/llvm-project?rev=369680=rev Log: Introduce FileEntryRef and use it when handling includes to report correct dependencies when the FileManager is reused across invocations This commit introduces a

[PATCH] D65907: Introduce FileEntryRef and use it when handling includes to report correct dependencies when the FileManager is reused across invocations

2019-08-22 Thread Alex Lorenz via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL369680: Introduce FileEntryRef and use it when handling includes to report correct… (authored by arphaman, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed

Re: r261008 - Add a nullPointerConstant() AST matcher to handle variations of null pointer constants in one matcher.

2019-08-22 Thread Aaron Ballman via cfe-commits
On Thu, Aug 22, 2019 at 12:58 PM Richard Smith wrote: > > (Sorry for the very late review!) > > On Tue, 16 Feb 2016 at 13:06, Aaron Ballman via cfe-commits > wrote: >> >> Author: aaronballman >> Date: Tue Feb 16 15:02:23 2016 >> New Revision: 261008 >> >> URL:

[clang-tools-extra] r369676 - [Clangd] Tweaktesting replace toString with consumeError

2019-08-22 Thread Shaurya Gupta via cfe-commits
Author: sureyeaah Date: Thu Aug 22 10:36:31 2019 New Revision: 369676 URL: http://llvm.org/viewvc/llvm-project?rev=369676=rev Log: [Clangd] Tweaktesting replace toString with consumeError Modified: clang-tools-extra/trunk/clangd/unittests/TweakTesting.cpp Modified:

[PATCH] D65526: [Clangd] Initial prototype version of ExtractFunction

2019-08-22 Thread Shaurya Gupta via Phabricator via cfe-commits
SureYeaah updated this revision to Diff 216669. SureYeaah marked 33 inline comments as done. SureYeaah added a comment. Herald added a subscriber: mgrang. Addressed Review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65526/new/

r369683 - Implement nullPointerConstant() using a better API.

2019-08-22 Thread Aaron Ballman via cfe-commits
Author: aaronballman Date: Thu Aug 22 11:26:44 2019 New Revision: 369683 URL: http://llvm.org/viewvc/llvm-project?rev=369683=rev Log: Implement nullPointerConstant() using a better API. Instead of manually attempting to identify whether something is a null pointer constant, use

Re: r261008 - Add a nullPointerConstant() AST matcher to handle variations of null pointer constants in one matcher.

2019-08-22 Thread Aaron Ballman via cfe-commits
On Thu, Aug 22, 2019 at 1:13 PM Aaron Ballman wrote: > > On Thu, Aug 22, 2019 at 12:58 PM Richard Smith wrote: > > > > (Sorry for the very late review!) > > > > On Tue, 16 Feb 2016 at 13:06, Aaron Ballman via cfe-commits > > wrote: > >> > >> Author: aaronballman > >> Date: Tue Feb 16 15:02:23

[PATCH] D66621: [clang] Devirtualization for classes with destructors marked as 'final'

2019-08-22 Thread Logan Smith via Phabricator via cfe-commits
logan-5 created this revision. logan-5 added a reviewer: rsmith. logan-5 added a project: clang. Herald added subscribers: cfe-commits, Prazek. A class with a destructor marked `final` cannot be derived from, so it should afford the same devirtualization opportunities as marking the entire class

[PATCH] D66559: [OPENMP] Update the diagnosis message for canonical loop form

2019-08-22 Thread Alexey Bataev via Phabricator via cfe-commits
ABataev added a comment. In D66559#1641827 , @cchen wrote: > Is there any way that I can find the OpenMP version in Clang? I couldn't find > any example in source code. Thanks. LangOpts.OpenMP has the version of OpenMP. For OpenMP 5.0 this value is set

r369714 - [libclang][NFC] Remove debug comment

2019-08-22 Thread Jan Korous via cfe-commits
Author: jkorous Date: Thu Aug 22 16:29:10 2019 New Revision: 369714 URL: http://llvm.org/viewvc/llvm-project?rev=369714=rev Log: [libclang][NFC] Remove debug comment Modified: cfe/trunk/tools/libclang/Indexing.cpp Modified: cfe/trunk/tools/libclang/Indexing.cpp URL:

r369719 - [clang][ifs] Dropping older experimental interface stub formats.

2019-08-22 Thread Puyan Lotfi via cfe-commits
Author: zer0 Date: Thu Aug 22 16:44:34 2019 New Revision: 369719 URL: http://llvm.org/viewvc/llvm-project?rev=369719=rev Log: [clang][ifs] Dropping older experimental interface stub formats. I've been working on a new tool, llvm-ifs, for merging interface stub files generated by clang and I've

r369687 - Improve the documentation for OpenCL vector types.

2019-08-22 Thread Aaron Ballman via cfe-commits
Author: aaronballman Date: Thu Aug 22 11:57:46 2019 New Revision: 369687 URL: http://llvm.org/viewvc/llvm-project?rev=369687=rev Log: Improve the documentation for OpenCL vector types. This fixes some minor grammatical issues I noticed when reading the docs, and changes the recommended feature

r369688 - Disable the ScanDepsReuseFilemanager test on Windows

2019-08-22 Thread Alex Lorenz via cfe-commits
Author: arphaman Date: Thu Aug 22 12:00:08 2019 New Revision: 369688 URL: http://llvm.org/viewvc/llvm-project?rev=369688=rev Log: Disable the ScanDepsReuseFilemanager test on Windows Right now it fails. I'm going to investigate it and fix it in follow-up commits. Modified:

[PATCH] D66122: [CodeGen] Emit dynamic initializers for static TLS vars in outlined scopes

2019-08-22 Thread Eli Friedman via Phabricator via cfe-commits
efriedma added a comment. Oh, I somehow forgot that was legal. :( That breaks this whole approach (well, maybe the lambda could capture "w", but that seems way too complicated). So we're left with a few possibilities: 1. an error 2. undefined behavior (probably we would want to warn in this

r369697 - IR. Change strip* family of functions to not look through aliases.

2019-08-22 Thread Peter Collingbourne via cfe-commits
Author: pcc Date: Thu Aug 22 12:56:14 2019 New Revision: 369697 URL: http://llvm.org/viewvc/llvm-project?rev=369697=rev Log: IR. Change strip* family of functions to not look through aliases. I noticed another instance of the issue where references to aliases were being replaced with aliasees,

[PATCH] D66606: IR. Change strip* family of functions to not look through aliases.

2019-08-22 Thread Peter Collingbourne via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL369697: IR. Change strip* family of functions to not look through aliases. (authored by pcc, committed by ). Changed prior to commit: https://reviews.llvm.org/D66606?vs=216671=216694#toc Repository:

[PATCH] D62731: [RFC] Add support for options -fp-model= and -fp-speculation= : specify floating point behavior

2019-08-22 Thread Melanie Blower via Phabricator via cfe-commits
mibintc added a comment. ping, looking for a code review, especially from front end folks. thank you! Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62731/new/ https://reviews.llvm.org/D62731 ___ cfe-commits mailing

[PATCH] D62739: AMDGPU: Always emit amdgpu-flat-work-group-size

2019-08-22 Thread Matt Arsenault via Phabricator via cfe-commits
arsenm added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62739/new/ https://reviews.llvm.org/D62739 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r369686 - Fix the nullPointerConstant() test to get bots back to green.

2019-08-22 Thread Aaron Ballman via cfe-commits
Author: aaronballman Date: Thu Aug 22 11:56:18 2019 New Revision: 369686 URL: http://llvm.org/viewvc/llvm-project?rev=369686=rev Log: Fix the nullPointerConstant() test to get bots back to green. Modified: cfe/trunk/unittests/ASTMatchers/ASTMatchersNarrowingTest.cpp Modified:

[PATCH] D62739: AMDGPU: Always emit amdgpu-flat-work-group-size

2019-08-22 Thread Stanislav Mekhanoshin via Phabricator via cfe-commits
rampitec added inline comments. Comment at: lib/CodeGen/TargetInfo.cpp:7885 +// By default, restrict the maximum size to 256. +F->addFnAttr("amdgpu-flat-work-group-size", "128,256"); } arsenm wrote: > yaxunl wrote: > > arsenm wrote: > > > b-sumner

[clang-tools-extra] r369695 - Fight a bit against global initializers. NFC.

2019-08-22 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Thu Aug 22 12:43:27 2019 New Revision: 369695 URL: http://llvm.org/viewvc/llvm-project?rev=369695=rev Log: Fight a bit against global initializers. NFC. Modified: clang-tools-extra/trunk/clangd/index/CanonicalIncludes.cpp clang-tools-extra/trunk/clangd/index/Ref.cpp

[PATCH] D66606: IR. Change strip* family of functions to not look through aliases.

2019-08-22 Thread Reid Kleckner via Phabricator via cfe-commits
rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm GlobalOpt already replaces replaceable aliases, and if it doesn't do it enough, we can adjust the pass pipeline to fix the phase ordering problem. Repository: rG LLVM Github Monorepo

  1   2   >