[clang-tools-extra] r370452 - [clangd] Collecting main file macro expansion locations in ParsedAST.

Author: jvikstrom Date: Fri Aug 30 02:33:27 2019 New Revision: 370452 URL: http://llvm.org/viewvc/llvm-project?rev=370452=rev Log: [clangd] Collecting main file macro expansion locations in ParsedAST. Summary: TokenBuffer does not collect macro expansions inside macro arguments which is needed

[PATCH] D66928: [clangd] Collecting main file macro expansion locations in ParsedAST.

This revision was automatically updated to reflect the committed changes. Closed by commit rL370452: [clangd] Collecting main file macro expansion locations in ParsedAST. (authored by jvikstrom, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior

[PATCH] D66738: [clangd] Added highlighting for structured bindings.

hokein added a comment. I don't have a strong preference on how to highlight `BindingDecl`, but I think highlighting them as `Variable` is better than no highlighting them at all, so LGTM from myside. @ilya-biryukov thoughts? again, please update the patch description in phabricator and your

[PATCH] D66738: [clangd] Added highlighting for structured bindings.

hokein accepted this revision. hokein added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/unittests/SemanticHighlightingTests.cpp:443 +$Primitive[[int]] $Variable[[A]][2] = {1,2}; +auto [$Variable[[B1]],

[PATCH] D65744: [PR42707][OpenCL] Fix addr space deduction for auto

Anastasia marked an inline comment as done. Anastasia added a comment. missing test case 1 auto* accumulator() 2 { 3 __global int * glptr; 4 return glptr; 5 } 6 int i; 7 auto* ai = 8 int* ii = In D65744#1646348 , @rjmccall wrote: >

r370444 - [CodeGen]: fix error message for "=r" asm constraint

Author: glider Date: Fri Aug 30 01:58:46 2019 New Revision: 370444 URL: http://llvm.org/viewvc/llvm-project?rev=370444=rev Log: [CodeGen]: fix error message for "=r" asm constraint Summary: Nico Weber reported that the following code: char buf[9]; asm("" : "=r" (buf)); yields the

[PATCH] D66948: [CodeGen]: fix error message for "=r" asm constraint

glider updated this revision to Diff 218037. glider added a comment. Minor comment fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66948/new/ https://reviews.llvm.org/D66948 Files: clang/lib/CodeGen/CGStmt.cpp

[PATCH] D66933: [ASTImporter] Propagate errors during import of overridden methods.

balazske updated this revision to Diff 218039. balazske added a comment. - Renamed ImportOverrides, additional check in test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66933/new/ https://reviews.llvm.org/D66933 Files:

[PATCH] D66960: [Tooling] Migrated APIs that take ownership of objects to unique_ptr

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM from my side. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66960/new/ https://reviews.llvm.org/D66960

[PATCH] D66995: [clangd] Add highlighting for macro expansions.

ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:35 +TraverseAST(AST.getASTContext()); +// Add highlightings for Macro Expansions as they are not traversed by the +// visitor. NIT: uncapitalize and

[PATCH] D66990: [clangd] Add distinct highlightings for declarations of functions and methods

jvikstrom added a comment. Should we have different highlightings for declarations vs usages? (Although I guess in the end it will be up to the editor if they highlight them differently as the scope is just more specific for declarations) I guess I personally don't really see the reason as it

[PATCH] D66738: [clangd] Added highlighting for structured bindings.

jvikstrom marked an inline comment as done. jvikstrom added inline comments. Comment at: clang-tools-extra/clangd/unittests/SemanticHighlightingTests.cpp:443 +$Primitive[[int]] $Variable[[A]][2] = {1,2}; +auto [$Variable[[B1]], $Variable[[B2]]] = $Variable[[A]];

[PATCH] D66995: [clangd] Add highlighting for macro expansions.

jvikstrom updated this revision to Diff 218061. jvikstrom added a comment. Removed SourceManager field from HighlightingTokenCollector. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66995/new/ https://reviews.llvm.org/D66995 Files:

[PATCH] D66732: [Clangd] ExtractFunction Added checks for broken control flow

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/refactor/tweaks/ExtractFunction.cpp:433 +// inside Extraction Zone. +void incrementLoopSwitchCounters(Stmt *S) { +

[PATCH] D66990: [clangd] Add distinct highlightings for declarations of functions and methods

ilya-biryukov added a comment. In D66990#1652172 , @jvikstrom wrote: > Should we have different highlightings for declarations vs usages? (Although > I guess in the end it will be up to the editor if they highlight them > differently as the scope is

[PATCH] D66960: [Tooling] Migrated APIs that take ownership of objects to unique_ptr

gribozavr updated this revision to Diff 218046. gribozavr added a comment. Updated documentation and added release notes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66960/new/ https://reviews.llvm.org/D66960 Files:

[PATCH] D66960: [Tooling] Migrated APIs that take ownership of objects to unique_ptr

gribozavr added a comment. In D66960#1651258 , @lebedev.ri wrote: > In D66960#1651243 , @gribozavr wrote: > > > In D66960#1651198 , @lebedev.ri > > wrote: > > > > > This is

[PATCH] D66516: [clangd] Added highlighting to types dependant on templates.

ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:177 return; +if (TP->isPointerType() || TP->isLValueReferenceType()) + // When highlighting dependant template types the type can be a pointer or

[PATCH] D66933: [ASTImporter] Propagate errors during import of overridden methods.

This revision was automatically updated to reflect the committed changes. Closed by commit rL370457: [ASTImporter] Propagate errors during import of overridden methods. (authored by balazske, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to

r370461 - [ASTImporter] Do not look up lambda classes

Author: martong Date: Fri Aug 30 03:55:41 2019 New Revision: 370461 URL: http://llvm.org/viewvc/llvm-project?rev=370461=rev Log: [ASTImporter] Do not look up lambda classes Summary: Consider this code: ``` void f() { auto L0 = [](){}; auto L1 = [](){}; } ``` First we

[PATCH] D66348: [ASTImporter] Do not look up lambda classes

This revision was automatically updated to reflect the committed changes. Closed by commit rL370461: [ASTImporter] Do not look up lambda classes (authored by martong, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D66538: [AST] AST structural equivalence to work internally with pairs.

martong added a comment. @a_sidorin Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66538/new/ https://reviews.llvm.org/D66538 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D62977: [clang-tidy]: Google: new check 'google-upgrade-googletest-case'

tsatsulin marked an inline comment as done. tsatsulin added inline comments. Comment at: clang-tools-extra/clang-tidy/google/UpgradeGoogletestCaseCheck.cpp:83 + + void Ifndef(SourceLocation Loc, const Token , + const MacroDefinition ) override {

[PATCH] D65919: [clang-tidy] Add llvm-prefer-register-over-unsigned check and apply it to LLVM

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from a nit with `auto`. Comment at: clang-tools-extra/clang-tidy/llvm/PreferRegisterOverUnsignedCheck.cpp:47 +for (const auto *UsingDirective :

[PATCH] D66505: Make add_new_check.py's insertion of registerCheck<> match the sort order

aaron.ballman added a comment. Generally LG to me as well Comment at: clang-tools-extra/clang-tidy/add_new_check.py:198 +# If we didn't find the check name on this line, look on the +# next one +last_line = line

[PATCH] D66948: [CodeGen]: fix error message for "=r" asm constraint

This revision was automatically updated to reflect the committed changes. Closed by commit rL370444: [CodeGen]: fix error message for =r asm constraint (authored by glider, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[clang-tools-extra] r370446 - [clangd] Add .vscode-test to .gitignore.

Author: hokein Date: Fri Aug 30 02:06:18 2019 New Revision: 370446 URL: http://llvm.org/viewvc/llvm-project?rev=370446=rev Log: [clangd] Add .vscode-test to .gitignore. Reviewers: jvikstrom Subscribers: ilya-biryukov, MaskRay, jkorous, arphaman, kadircet, cfe-commits Tags: #clang Differential

[PATCH] D66949: [clangd] Add .vscode-test to .gitignore.

This revision was automatically updated to reflect the committed changes. Closed by commit rL370446: [clangd] Add .vscode-test to .gitignore. (authored by hokein, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D66928: [clangd] Collecting main file macro expansion locations in ParsedAST.

ilya-biryukov accepted this revision. ilya-biryukov marked an inline comment as done. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM, thanks! Comment at: clang-tools-extra/clangd/unittests/ClangdUnitTests.cpp:260 +// Macros from token

r370451 - [Tooling] Migrated APIs that take ownership of objects to unique_ptr

Author: gribozavr Date: Fri Aug 30 02:29:34 2019 New Revision: 370451 URL: http://llvm.org/viewvc/llvm-project?rev=370451=rev Log: [Tooling] Migrated APIs that take ownership of objects to unique_ptr Subscribers: jkorous, arphaman, kadircet, cfe-commits Tags: #clang Differential Revision:

[clang-tools-extra] r370451 - [Tooling] Migrated APIs that take ownership of objects to unique_ptr

Author: gribozavr Date: Fri Aug 30 02:29:34 2019 New Revision: 370451 URL: http://llvm.org/viewvc/llvm-project?rev=370451=rev Log: [Tooling] Migrated APIs that take ownership of objects to unique_ptr Subscribers: jkorous, arphaman, kadircet, cfe-commits Tags: #clang Differential Revision:

r370457 - [ASTImporter] Propagate errors during import of overridden methods.

Author: balazske Date: Fri Aug 30 03:12:14 2019 New Revision: 370457 URL: http://llvm.org/viewvc/llvm-project?rev=370457=rev Log: [ASTImporter] Propagate errors during import of overridden methods. Summary: If importing overridden methods fails for a method it can be seen incorrectly as

[PATCH] D66995: [clangd] Add highlighting for macro expansions.

hokein added inline comments. Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:469 + case HighlightingKind::MacroExpansion: +return "entity.name.function.preprocessor.expansion.cpp"; case HighlightingKind::NumKinds: ilya-biryukov wrote: > Is

[PATCH] D66738: [clangd] Added highlighting for structured bindings.

ilya-biryukov added a comment. In D66738#1652285 , @hokein wrote: > I don't have a strong preference on how to highlight `BindingDecl`, but I > think highlighting them as `Variable` is better than no highlighting them at > all, so LGTM from myside.

[PATCH] D66505: Make add_new_check.py's insertion of registerCheck<> match the sort order

alexfh added a comment. Mostly LG, if you've verified that this works. A couple of comments below. Comment at: clang-tools-extra/clang-tidy/add_new_check.py:192 + else: +match = re.search('registerCheck<(.*)> *\( *(?:"([^"]*)")?', line) +

[PATCH] D66960: [Tooling] Migrated APIs that take ownership of objects to unique_ptr

This revision was automatically updated to reflect the committed changes. Closed by commit rL370451: [Tooling] Migrated APIs that take ownership of objects to unique_ptr (authored by gribozavr, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior

[PATCH] D66516: [clangd] Added highlighting to types dependant on templates.

jvikstrom added a comment. Pinging about this @ilya-biryukov Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66516/new/ https://reviews.llvm.org/D66516 ___ cfe-commits mailing list

[PATCH] D66995: [clangd] Add highlighting for macro expansions.

jvikstrom created this revision. jvikstrom added reviewers: hokein, ilya-biryukov. Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay. Herald added a project: clang. https://github.com/clangd/clangd/issues/134 Repository: rG LLVM Github Monorepo

[PATCH] D66732: [Clangd] ExtractFunction Added checks for broken control flow

SureYeaah updated this revision to Diff 218053. SureYeaah marked 4 inline comments as done. SureYeaah added a comment. Addressed review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66732/new/ https://reviews.llvm.org/D66732 Files:

[clang-tools-extra] r370455 - [Clangd] ExtractFunction Added checks for broken control flow

Author: sureyeaah Date: Fri Aug 30 02:57:56 2019 New Revision: 370455 URL: http://llvm.org/viewvc/llvm-project?rev=370455=rev Log: [Clangd] ExtractFunction Added checks for broken control flow Summary: - Added checks for broken control flow - Added unittests Reviewers: sammccall, kadircet

[PATCH] D66732: [Clangd] ExtractFunction Added checks for broken control flow

This revision was automatically updated to reflect the committed changes. Closed by commit rL370455: [Clangd] ExtractFunction Added checks for broken control flow (authored by SureYeaah, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to

[PATCH] D66324: clang-misexpect: Profile Guided Validation of Performance Annotations in LLVM

lebedev.ri added a comment. Trying to start reviewing this. The llvm side of the patch is self contained; clang patch should be split into a dependent review. Comment at: clang/lib/CodeGen/CodeGenAction.cpp:626 + unsigned Line, Column; + bool BadDebugInfo = false; +

[PATCH] D66333: [analyzer] NonNullParamChecker and CStringChecker parameter number in checker message

whisperity accepted this revision. whisperity added a comment. @Szelethus Nope. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66333/new/ https://reviews.llvm.org/D66333 ___ cfe-commits mailing list

[libunwind] r370469 - Creating release candidate rc3 from release_900 branch

Author: hans Date: Fri Aug 30 05:25:14 2019 New Revision: 370469 URL: http://llvm.org/viewvc/llvm-project?rev=370469=rev Log: Creating release candidate rc3 from release_900 branch Added: libunwind/tags/RELEASE_900/rc3/ - copied from r370468, libunwind/branches/release_90/

[libclc] r370469 - Creating release candidate rc3 from release_900 branch

Author: hans Date: Fri Aug 30 05:25:14 2019 New Revision: 370469 URL: http://llvm.org/viewvc/llvm-project?rev=370469=rev Log: Creating release candidate rc3 from release_900 branch Added: libclc/tags/RELEASE_900/rc3/ - copied from r370468, libclc/branches/release_90/

[PATCH] D66995: [clangd] Add highlighting for macro expansions.

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. LGTM from my side. Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:471 + case HighlightingKind::Macro: +return

[clang-tools-extra] r370482 - [clangd] Add highlighting for macro expansions.

Author: jvikstrom Date: Fri Aug 30 08:47:27 2019 New Revision: 370482 URL: http://llvm.org/viewvc/llvm-project?rev=370482=rev Log: [clangd] Add highlighting for macro expansions. Summary: https://github.com/clangd/clangd/issues/134 Reviewers: hokein, ilya-biryukov Subscribers: MaskRay,

[clang-tools-extra] r370473 - [clangd] Added highlighting for structured bindings.

Author: jvikstrom Date: Fri Aug 30 07:07:05 2019 New Revision: 370473 URL: http://llvm.org/viewvc/llvm-project?rev=370473=rev Log: [clangd] Added highlighting for structured bindings. Summary: Structured bindings are in a BindingDecl. The decl the declRefExpr points to are the BindingDecls. So

[PATCH] D66559: [OPENMP] Update the diagnosis message for canonical loop form

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG, thanks for the fix! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66559/new/ https://reviews.llvm.org/D66559

[PATCH] D66336: [ASTImporter] Add development internals docs

martong added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66336/new/ https://reviews.llvm.org/D66336 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D66018: [ARM] Take into account -mcpu and -mfpu options while handling 'crypto' feature

krisb marked an inline comment as done. krisb added a comment. @dnsampaio thanks for reviewing this! Could I ask you to commit the patch (since I don't have commit access yet)? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66018/new/

[PATCH] D66018: [ARM] Take into account -mcpu and -mfpu options while handling 'crypto' feature

dnsampaio requested changes to this revision. dnsampaio added a comment. This revision now requires changes to proceed. `clang -### -target arm-arm-none-eabit -march=armv8-m.main+crypto` did not show +sha2 or +aes. After the patch it does. I believe that is not expected, as in ARM.td `crypto` is

[PATCH] D66999: [ASTImporter][NFC] Add comments to code where we cannot use HandleNameConflict

martong created this revision. martong added reviewers: shafik, a_sidorin. Herald added subscribers: cfe-commits, gamesh411, Szelethus, dkrupp, rnkovacs. Herald added a reviewer: a.sidorin. Herald added a project: clang. This is the continuation of https://reviews.llvm.org/D59692 where we started

[PATCH] D66018: [ARM] Take into account -mcpu and -mfpu options while handling 'crypto' feature

krisb updated this revision to Diff 218076. krisb edited the summary of this revision. krisb added a comment. Added 'CPU.empty()' check back. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66018/new/ https://reviews.llvm.org/D66018 Files:

[PATCH] D66995: [clangd] Add highlighting for macro expansions.

jvikstrom added inline comments. Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:469 + case HighlightingKind::MacroExpansion: +return "entity.name.function.preprocessor.expansion.cpp"; case HighlightingKind::NumKinds: ilya-biryukov wrote: >

[PATCH] D66738: [clangd] Added highlighting for structured bindings.

This revision was automatically updated to reflect the committed changes. Closed by commit rL370473: [clangd] Added highlighting for structured bindings. (authored by jvikstrom, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

r370481 - Revert [Clang Interpreter] Initial patch for the constexpr interpreter

Author: nand Date: Fri Aug 30 08:41:45 2019 New Revision: 370481 URL: http://llvm.org/viewvc/llvm-project?rev=370481=rev Log: Revert [Clang Interpreter] Initial patch for the constexpr interpreter This reverts r370476 (git commit a5590950549719d0d9ea69ed164b0c8c0f4e02e6) Removed:

[PATCH] D66834: Driver tests: set `--sysroot=""` to support clang with `DEFAULT_SYSROOT`

compnerd added a comment. I think that this is pretty easy to forget. Fortunately, last argument wins. Why not sink this into the `%clang` substitution in lit? That ensures that we run with an empty sysroot and then when the test needs to adjust the sysroot, it can do so explicitly.

[PATCH] D66524: [SVE][Inline-Asm] Add constraints for SVE predicate registers

kmclaughlin updated this revision to Diff 218071. kmclaughlin added a comment. - Added isPredicateConstraint function to AArch64ISelLowering.cpp, which returns Upl, Upa or Invalid. This is used to replace some repeated checks of the predicate type - Minor changes to InlineAsm.cpp CHANGES

[PATCH] D66995: [clangd] Add highlighting for macro expansions.

jvikstrom updated this revision to Diff 218089. jvikstrom added a comment. Renamed MacroExpansion to Macro. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66995/new/ https://reviews.llvm.org/D66995 Files:

[PATCH] D59922: [Attributor] Deduce "no-capture" argument attribute

jdoerfert updated this revision to Diff 218109. jdoerfert added a comment. Update tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59922/new/ https://reviews.llvm.org/D59922 Files: llvm/include/llvm/Transforms/IPO/Attributor.h

[PATCH] D66989: FileManager: Remove ShouldCloseOpenFile argument from getBufferForFile, NFC

Bigcheese accepted this revision. Bigcheese added a comment. This revision is now accepted and ready to land. lgtm CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66989/new/ https://reviews.llvm.org/D66989 ___ cfe-commits mailing list

[PATCH] D66559: [OPENMP] Update the diagnosis message for canonical loop form

cchen marked an inline comment as done. cchen added a comment. I'm not able to `arc land` my patch since I updated the patch for a minor refactor and the state is "not approve" now. Do I wait for the approval for the new patch so that I can `arc land` or I don't need to do `arc land` myself?

[PATCH] D66710: ASTReader: Bypass overridden files when reading PCHs

bruno accepted this revision. bruno added a comment. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66710/new/ https://reviews.llvm.org/D66710 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r370493 - [clang-scan-deps] NFC, remove outdated implementation comment

Author: arphaman Date: Fri Aug 30 10:34:22 2019 New Revision: 370493 URL: http://llvm.org/viewvc/llvm-project?rev=370493=rev Log: [clang-scan-deps] NFC, remove outdated implementation comment There's no need to purge symlinked entries in the FileManager, as the new FileEntryRef API allows us to

[PATCH] D66505: Make add_new_check.py's insertion of registerCheck<> match the sort order

dsanders marked 4 inline comments as done. dsanders added a comment. In D66505#1652420 , @alexfh wrote: > Mostly LG, if you've verified that this works. A couple of comments below. I verified it using ./add_new_check.py llvm

[PATCH] D66706: [Wdocumentation] fixes an assertion failure with typedefed function and block pointer

gribozavr added inline comments. Comment at: clang/lib/AST/Comment.cpp:151 +static bool getFunctionTypeLoc(TypeLoc TL, FunctionTypeLoc , + bool testTypedefTypeLoc = false) { TypeLoc PrevTL; Mordante wrote: > gribozavr wrote: > >

[PATCH] D66397: [Diagnostics] Improve -Wxor-used-as-pow

aaron.ballman added inline comments. Comment at: lib/Sema/SemaExpr.cpp:54-55 +const SourceLocation Loc, +const Expr *SubLHS = nullptr, +const Expr *SubRHS = nullptr); +

[PATCH] D66397: [Diagnostics] Improve -Wxor-used-as-pow

aaron.ballman added a comment. In D66397#1652771 , @xbolva00 wrote: > >> tbh, I would appreciate if you would leave the definition of > >> diagnoseXorMisusedAsPow() where it is and add a forward declare of the > >> function earlier in the file. > > I

[PATCH] D65744: [PR42707][OpenCL] Fix addr space deduction for auto

rjmccall added a comment. In D65744#1652355 , @Anastasia wrote: > I don't think this is likely to change. Are you suggesting to move the > deduction logic for pointee of pointers, references and block pointers into > ASTContext helper that creates a

[PATCH] D66559: [OPENMP] Update the diagnosis message for canonical loop form

ABataev added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:5423 + SemaRef.Diag(DefaultLoc, diag::err_omp_loop_not_canonical_cond) + << IneqCondIsCanonical << LCDecl; return true; I would not suggest to rely

[PATCH] D66324: clang-misexpect: Profile Guided Validation of Performance Annotations in LLVM

paulkirth marked an inline comment as done. paulkirth added a comment. Thanks for the review. I'm working on splitting up the patch now. I should be able to address most of your comments, but I left some inline comments for clarification/discussion. Comment at:

[PATCH] D66505: Make add_new_check.py's insertion of registerCheck<> match the sort order

dsanders added a comment. Missed one of the commands from my history that I used to verify it: ./add_new_check.py llvm i Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66505/new/ https://reviews.llvm.org/D66505

[PATCH] D66505: Make add_new_check.py's insertion of registerCheck<> match the sort order

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thank you for working on this! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66505/new/ https://reviews.llvm.org/D66505

[PATCH] D66559: [OPENMP] Update the diagnosis message for canonical loop form

ABataev accepted this revision. ABataev added a comment. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66559/new/ https://reviews.llvm.org/D66559 ___ cfe-commits mailing list

[PATCH] D66919: Warn about zero-parameter K definitions in -Wstrict-prototypes

dexonsmith added a comment. > In D66919#1650174 , @dexonsmith > wrote: > >> We could carve out a `-W` flag (if it doesn't already exist) that warns if >> you incorrectly pass parameters to a function whose definition has no >> prototype > > > The

[PATCH] D65919: [clang-tidy] Add llvm-prefer-register-over-unsigned check and apply it to LLVM

This revision was automatically updated to reflect the committed changes. dsanders marked an inline comment as done. Closed by commit rL370512: [clang-tidy] Add llvm-prefer-register-over-unsigned to clang-tidy (authored by dsanders, committed by ). Herald added a project: LLVM. Changed prior to

[PATCH] D65919: [clang-tidy] Add llvm-prefer-register-over-unsigned check and apply it to LLVM

dsanders added a comment. r370512 Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65919/new/ https://reviews.llvm.org/D65919 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r370488 - FileManager: Remove ShouldCloseOpenFile argument from getBufferForFile, NFC

Author: dexonsmith Date: Fri Aug 30 09:56:26 2019 New Revision: 370488 URL: http://llvm.org/viewvc/llvm-project?rev=370488=rev Log: FileManager: Remove ShouldCloseOpenFile argument from getBufferForFile, NFC Remove this dead code. We always close it. Modified:

[PATCH] D66989: FileManager: Remove ShouldCloseOpenFile argument from getBufferForFile, NFC

dexonsmith closed this revision. dexonsmith added a comment. r370488 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66989/new/ https://reviews.llvm.org/D66989 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang-tools-extra] r370512 - [clang-tidy] Add llvm-prefer-register-over-unsigned to clang-tidy

Author: dsanders Date: Fri Aug 30 13:01:59 2019 New Revision: 370512 URL: http://llvm.org/viewvc/llvm-project?rev=370512=rev Log: [clang-tidy] Add llvm-prefer-register-over-unsigned to clang-tidy Summary: This clang-tidy check is looking for unsigned integer variables whose initializer starts

[PATCH] D67010: [Modules] Move search paths from control block to unhashed control block

bruno created this revision. bruno added reviewers: dexonsmith, arphaman, rsmith. Herald added subscribers: cfe-commits, ributzka, jkorous. Herald added a project: clang. Header search paths are currently ignored for the purpose of computing `getModuleHash()` during a module build. This means

[PATCH] D66808: [ConstExprPreter] Full patch of the interpreter.

nand updated this revision to Diff 218131. nand added a comment. Added more features Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66808/new/ https://reviews.llvm.org/D66808 Files: clang/docs/ConstantInterpreter.rst

[PATCH] D66018: [ARM] Take into account -mcpu and -mfpu options while handling 'crypto' feature

krisb added a comment. I see. But this doesn't seem like a valid case, does it? Shouldn't we somehow diagnose it to not to silently ignore user-specified options? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66018/new/ https://reviews.llvm.org/D66018

[PATCH] D66706: [Wdocumentation] fixes an assertion failure with typedefed function and block pointer

Mordante marked 3 inline comments as done. Mordante added inline comments. Comment at: clang/lib/AST/Comment.cpp:151 +static bool getFunctionTypeLoc(TypeLoc TL, FunctionTypeLoc , + bool testTypedefTypeLoc = false) { TypeLoc PrevTL;

[PATCH] D66505: Make add_new_check.py's insertion of registerCheck<> match the sort order

dsanders updated this revision to Diff 218137. dsanders marked an inline comment as done. dsanders added a comment. - Full stop at end of comment - last_line -> prev_line Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66505/new/

[PATCH] D66836: [libc++] Add `__truncating_cast` for safely casting float types to integers

EricWF updated this revision to Diff 218149. EricWF marked an inline comment as done. EricWF added a comment. Address review comments. - Document that NaN isn't a supported input. - Fix spelling mistake. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66836/new/

[PATCH] D64480: [ASTImporter] Added visibility context check for TypedefNameDecl.

shafik added inline comments. Comment at: lib/AST/ASTImporter.cpp:949 +return Importer.GetFromTU(Found) == From->getTranslationUnitDecl(); + return From->isInAnonymousNamespace() == Found->isInAnonymousNamespace(); +} I am not sure what case this covers?

[PATCH] D66995: [clangd] Add highlighting for macro expansions.

jvikstrom updated this revision to Diff 218087. jvikstrom marked 3 inline comments as done. jvikstrom added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66995/new/ https://reviews.llvm.org/D66995 Files:

[PATCH] D66995: [clangd] Add highlighting for macro expansions.

This revision was automatically updated to reflect the committed changes. Closed by commit rL370482: [clangd] Add highlighting for macro expansions. (authored by jvikstrom, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D66397: [Diagnostics] Improve -Wxor-used-as-pow

xbolva00 updated this revision to Diff 218115. xbolva00 added a comment. Fixed review comment. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66397/new/ https://reviews.llvm.org/D66397 Files: include/clang/Basic/DiagnosticSemaKinds.td lib/Sema/SemaExpr.cpp

[PATCH] D66397: [Diagnostics] Improve -Wxor-used-as-pow

xbolva00 added a comment. >> tbh, I would appreciate if you would leave the definition of >> diagnoseXorMisusedAsPow() where it is and add a forward declare of the >> function earlier in the file. I uploaded the patch almost 2 weeks ago and nobody complained so I thought it is okay. Uploaded,

[PATCH] D66505: Make add_new_check.py's insertion of registerCheck<> match the sort order

This revision was automatically updated to reflect the committed changes. Closed by commit rL370527: Make add_new_check.pys insertion of registerCheck match the sort order (authored by dsanders, committed by ). Herald added a project: LLVM. Changed prior to commit:

[clang-tools-extra] r370527 - Make add_new_check.py's insertion of registerCheck<> match the sort order

Author: dsanders Date: Fri Aug 30 13:47:02 2019 New Revision: 370527 URL: http://llvm.org/viewvc/llvm-project?rev=370527=rev Log: Make add_new_check.py's insertion of registerCheck<> match the sort order Summary: Following on from review comments in D65919 about the ordering of the

[PATCH] D67019: [analyzer] pr43179: CallDescription: Check number of parameters as well as number of arguments.

Charusso accepted this revision. Charusso added a comment. This revision is now accepted and ready to land. I like the isolation of this kind of stuff. Thanks you! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67019/new/ https://reviews.llvm.org/D67019

r370535 - Revert [Clang Interpreter] Initial patch for the constexpr interpreter

Author: nand Date: Fri Aug 30 14:32:00 2019 New Revision: 370535 URL: http://llvm.org/viewvc/llvm-project?rev=370535=rev Log: Revert [Clang Interpreter] Initial patch for the constexpr interpreter This reverts r370531 (git commit d4c1002e0ab50f6891cdd2f5bd3a8f3a3584) Removed:

r370544 - [c++20] Implement semantic restrictions for C++20 designated

Author: rsmith Date: Fri Aug 30 15:52:55 2019 New Revision: 370544 URL: http://llvm.org/viewvc/llvm-project?rev=370544=rev Log: [c++20] Implement semantic restrictions for C++20 designated initializers. This has some interesting interactions with our existing extensions to support C99 designated

[PATCH] D67026: Introduce a DirectoryEntryRef that stores both a reference and an accessed name to the directory entry

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. A few minor comments. Assuming the `FIXME` I point out was intentionally left for later, this LGTM. Comment at: clang/include/clang/Basic/FileManager.h:59 +public:

[PATCH] D66983: [WebAssembly] Add wasm-specific vector shuffle builtin and intrinsic

tlively added a comment. Link to DAGCombiner.cpp code: https://github.com/llvm/llvm-project/blob/802aab5/llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp#L19014 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66983/new/ https://reviews.llvm.org/D66983

r370555 - [c++20] Disallow template argument deduction from a braced-init-list

Author: rsmith Date: Fri Aug 30 17:05:50 2019 New Revision: 370555 URL: http://llvm.org/viewvc/llvm-project?rev=370555=rev Log: [c++20] Disallow template argument deduction from a braced-init-list containing designators. The C++20 wording doesn't actually say what happens in this case, but

  1   2   >