[PATCH] D64305: [clangd] Add path mappings functionality

2019-11-18 Thread Sam McCall via Phabricator via cfe-commits
sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. LG. A couple of optional comments to address as you see fit. It looks like you're not an LLVM committer yet, do you want me to commit this for you? (Usually it's reasonable to ask for

[PATCH] D70222: [clangd] Add support for .rsp files in compile_commands.json

2019-11-18 Thread liu hui via Phabricator via cfe-commits
lh123 updated this revision to Diff 229758. lh123 added a comment. update diff CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70222/new/ https://reviews.llvm.org/D70222 Files: clang-tools-extra/clangd/GlobalCompilationDatabase.cpp Index:

[PATCH] D70325: [clangd] Fix hover 'local scope' to include class template params

2019-11-18 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet added a comment. LGTM, with a question. What about default template params? I believe we would also like to print them, could you add a test case for that? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70325/new/

[PATCH] D70359: [clangd] Show values of more expressions on hover

2019-11-18 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet marked an inline comment as done. kadircet added inline comments. Comment at: clang-tools-extra/clangd/Hover.cpp:247 + // to the enclosing call. + if (E->getType()->isFunctionType() || E->getType()->isFunctionPointerType() || +

[PATCH] D54214: [RISCV] Set triple based on -march flag

2019-11-18 Thread Simon Cook via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGc00e5cf29d49: [RISCV] Set triple based on -march flag (authored by simoncook). Changed prior to commit: https://reviews.llvm.org/D54214?vs=228261=229784#toc Repository: rG LLVM Github Monorepo

[PATCH] D67545: [clang-tidy] Added DefaultOperatorNewCheck.

2019-11-18 Thread Roman Lebedev via Phabricator via cfe-commits
lebedev.ri resigned from this revision. lebedev.ri added a comment. This revision is now accepted and ready to land. In D67545#1749561 , @balazske wrote: > Ping. It should be accepted before I can land it. @aaron.ballman already accepted. Repository:

[PATCH] D70222: [clangd] Add support for .rsp files in compile_commands.json

2019-11-18 Thread liu hui via Phabricator via cfe-commits
lh123 updated this revision to Diff 229759. lh123 added a comment. format patch CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70222/new/ https://reviews.llvm.org/D70222 Files: clang-tools-extra/clangd/GlobalCompilationDatabase.cpp Index:

[clang] 2d739f9 - [ARM] Allocatable Global Register Variables for ARM

2019-11-18 Thread Anna Welker via cfe-commits
Author: Anna Welker Date: 2019-11-18T10:07:37Z New Revision: 2d739f98d8a53e38bf9faa88cdb6b0c2a363fb77 URL: https://github.com/llvm/llvm-project/commit/2d739f98d8a53e38bf9faa88cdb6b0c2a363fb77 DIFF: https://github.com/llvm/llvm-project/commit/2d739f98d8a53e38bf9faa88cdb6b0c2a363fb77.diff LOG:

[PATCH] D70317: [clangd] More sensible output for constructors/destructors in hover.

2019-11-18 Thread Haojian Wu via Phabricator via cfe-commits
hokein added inline comments. Comment at: clang-tools-extra/clangd/XRefs.cpp:598 +// Constructor's "return type" is the class type. +HI.ReturnType = declaredType(CCD->getParent()).getAsString(Policy); +// Don't provide any type for the constructor itself.

[clang] c00e5cf - [RISCV] Set triple based on -march flag

2019-11-18 Thread Simon Cook via cfe-commits
Author: Simon Cook Date: 2019-11-18T10:44:24Z New Revision: c00e5cf29d49e51701b00382a3f41a4dfe1c0c0f URL: https://github.com/llvm/llvm-project/commit/c00e5cf29d49e51701b00382a3f41a4dfe1c0c0f DIFF: https://github.com/llvm/llvm-project/commit/c00e5cf29d49e51701b00382a3f41a4dfe1c0c0f.diff LOG:

[PATCH] D70359: [clangd] Show values of more expressions on hover

2019-11-18 Thread Sam McCall via Phabricator via cfe-commits
sammccall added a comment. "mouseover" all_the_things "all the things" Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70359/new/

[PATCH] D70357: [clangd] Untangle Hover from XRefs, move into own file.

2019-11-18 Thread Christian Kühnel via Phabricator via cfe-commits
kuhnel added a comment. I had a look at the build problems: https://github.com/google/llvm-premerge-checks/issues/56 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70357/new/ https://reviews.llvm.org/D70357

[PATCH] D67545: [clang-tidy] Added DefaultOperatorNewCheck.

2019-11-18 Thread Balázs Kéri via Phabricator via cfe-commits
balazske added a comment. Ping. It should be accepted before I can land it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67545/new/ https://reviews.llvm.org/D67545 ___ cfe-commits mailing list

[PATCH] D69934: [clangd] Implement rename by using SelectionTree and findExplicitReferences.

2019-11-18 Thread Haojian Wu via Phabricator via cfe-commits
hokein updated this revision to Diff 229766. hokein added a comment. rebase: renaming the filed on cxx initializer list e.g. "Foo() : Fie^ld()" is fixed in SelectionTree. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69934/new/

[PATCH] D69543: [clangd] Add a tweak refactoring to wrap Objective-C string literals in `NSLocalizedString` macros

2019-11-18 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet added a comment. implementation lgtm with a few nits. main concern is about the new getlangopts helper Comment at: clang-tools-extra/clangd/ParsedAST.h:80 + const LangOptions () const { +return getASTContext().getLangOpts(); can we introduce

[PATCH] D70203: [AST] Attach comment in `/** doc */ typedef struct A {} B` to B as well as A.

2019-11-18 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet accepted this revision. kadircet marked an inline comment as done. kadircet added a comment. This revision is now accepted and ready to land. LGTM, thanks! Comment at: clang/test/Index/annotate-comments-typedef.m:20 } MyEnum; -// CHECK:

[PATCH] D70203: [AST] Attach comment in `/** doc */ typedef struct A {} B` to B as well as A.

2019-11-18 Thread Sam McCall via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGa433e7141fb3: [AST] Attach comment in `/** doc */ typedef struct A {} B` to B as well as A. (authored by sammccall). Changed prior to commit: https://reviews.llvm.org/D70203?vs=229157=229769#toc

[PATCH] D70380: [clangd] Expose the xref's incomplete flag to clangdServer API.

2019-11-18 Thread pre-merge checks [bot] via Phabricator via cfe-commits
merge_guards_bot added a comment. Build result: fail - 60148 tests passed, 1 failed and 729 were skipped. failed: LLVM.Bindings/Go/go.test Log files: console-log.txt , CMakeCache.txt

[PATCH] D70357: [clangd] Untangle Hover from XRefs, move into own file.

2019-11-18 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet added inline comments. Comment at: clang-tools-extra/clangd/Hover.cpp:374 + } else { +auto Offset = positionToOffset(SM.getBufferData(SM.getMainFileID()), Pos); +if (!Offset) { nit: `SM.getFileOffset(SourceLocationBeg)` ?

[PATCH] D62731: Add support for options -frounding-math, -ftrapping-math, -ffp-model=, and -ffp-exception-behavior=, : Specify floating point behavior

2019-11-18 Thread Jorge Gorbe Moya via Phabricator via cfe-commits
jgorbe added a comment. Hi, I found a clang crash that seems to be caused by this patch. Here's a reduced test case: template class a { public: ~a(); void b(); }; template a::~a() try { b(); } catch (...) { } class d { public: d(const char *, int);

[PATCH] D70359: [clangd] Show values of more expressions on hover

2019-11-18 Thread Sam McCall via Phabricator via cfe-commits
sammccall marked an inline comment as done. sammccall added inline comments. Comment at: clang-tools-extra/clangd/Hover.cpp:423 + // - certain expressions (sizeof etc) + // - built-in types } lh123 wrote: > I think we should also support hover

[PATCH] D70377: clang-format: [JS] tests for async wrapping.

2019-11-18 Thread Martin Probst via Phabricator via cfe-commits
mprobst created this revision. mprobst added a reviewer: krasimir. Herald added a project: clang. Herald added a subscriber: cfe-commits. Adds tests to ensure that `async method() ...` does not wrap between async and the method name, which would cause automatic semicolon insertion. Repository:

[PATCH] D70359: [clangd] Show values of more expressions on hover

2019-11-18 Thread liu hui via Phabricator via cfe-commits
lh123 added inline comments. Comment at: clang-tools-extra/clangd/Hover.cpp:423 + // - certain expressions (sizeof etc) + // - built-in types } sammccall wrote: > lh123 wrote: > > I think we should also support hover on literal. > sure - can you

[PATCH] D70359: [clangd] Show values of more expressions on hover

2019-11-18 Thread liu hui via Phabricator via cfe-commits
lh123 added inline comments. Comment at: clang-tools-extra/clangd/Hover.cpp:423 + // - certain expressions (sizeof etc) + // - built-in types } lh123 wrote: > sammccall wrote: > > lh123 wrote: > > > I think we should also support hover on

[PATCH] D69934: [clangd] Implement rename by using SelectionTree and findExplicitReferences.

2019-11-18 Thread pre-merge checks [bot] via Phabricator via cfe-commits
merge_guards_bot added a comment. Build result: fail - 60148 tests passed, 1 failed and 729 were skipped. failed: LLVM.Bindings/Go/go.test Log files: console-log.txt , CMakeCache.txt

[PATCH] D70297: [ARM,MVE] Add intrinsics for vector comparisons.

2019-11-18 Thread Dave Green via Phabricator via cfe-commits
dmgreen accepted this revision. dmgreen added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70297/new/ https://reviews.llvm.org/D70297

[clang] a433e71 - [AST] Attach comment in `/** doc */ typedef struct A {} B` to B as well as A.

2019-11-18 Thread Sam McCall via cfe-commits
Author: Sam McCall Date: 2019-11-18T11:09:23+01:00 New Revision: a433e7141fb3f697e6430437ee73b19076603c1b URL: https://github.com/llvm/llvm-project/commit/a433e7141fb3f697e6430437ee73b19076603c1b DIFF: https://github.com/llvm/llvm-project/commit/a433e7141fb3f697e6430437ee73b19076603c1b.diff

[PATCH] D70380: [clangd] Expose the xref's incomplete flag to clangdServer API.

2019-11-18 Thread Haojian Wu via Phabricator via cfe-commits
hokein created this revision. hokein added a reviewer: sammccall. Herald added subscribers: usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. so that clangd C++ API users (via ClangdServer) can access it. Repository: rG LLVM Github Monorepo

[PATCH] D70222: [clangd] Add support for .rsp files in compile_commands.json

2019-11-18 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet added a comment. Thanks for taking a look into this, the `rsp files` issue has came up before in the past but there wasn't enough investment to implement it. Haven't checked the implementation in detail yet, I believe the layering should be different; This is a common problem for all

[PATCH] D70008: [clangd] Store xref for Macros in ParsedAST.

2019-11-18 Thread Haojian Wu via Phabricator via cfe-commits
hokein added a comment. Thanks, looks mostly good, a few more nits. Comment at: clang-tools-extra/clangd/CollectMacros.h:91-92 Out.Names.insert(MacroNameTok.getIdentifierInfo()->getName()); - Out.Ranges.push_back(*Range); + if (auto SID = +

[PATCH] D70380: [clangd] Expose the xref's incomplete flag to clangdServer API.

2019-11-18 Thread Sam McCall via Phabricator via cfe-commits
sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Let's see how many times I can miss the button Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70380/new/ https://reviews.llvm.org/D70380

[PATCH] D70380: [clangd] Expose the xref's incomplete flag to clangdServer API.

2019-11-18 Thread Sam McCall via Phabricator via cfe-commits
sammccall added a comment. Oops, LG apart from naming nits Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70380/new/ https://reviews.llvm.org/D70380 ___ cfe-commits mailing list

[PATCH] D70380: [clangd] Expose the xref's incomplete flag to clangdServer API.

2019-11-18 Thread Sam McCall via Phabricator via cfe-commits
sammccall added inline comments. Comment at: clang-tools-extra/clangd/XRefs.h:128 +struct References { + std::vector Refs; // reference locations of the symbol. + bool InComplete = false;// true if the result is incomplete. References -> ReferenceList or

[PATCH] D70222: [clangd] Add support for .rsp files in compile_commands.json

2019-11-18 Thread liu hui via Phabricator via cfe-commits
lh123 added a comment. In D70222#1749533 , @kadircet wrote: > Thanks for taking a look into this, the `rsp files` issue has came up before > in the past but there wasn't enough investment to implement it. > > Haven't checked the implementation in detail

[clang-tools-extra] 5181ada - [clangd] Expose the xref's incomplete flag to clangdServer API.

2019-11-18 Thread Haojian Wu via cfe-commits
Author: Haojian Wu Date: 2019-11-18T13:27:19+01:00 New Revision: 5181adab6183d058509ca6da7c1306ced3a61e1c URL: https://github.com/llvm/llvm-project/commit/5181adab6183d058509ca6da7c1306ced3a61e1c DIFF: https://github.com/llvm/llvm-project/commit/5181adab6183d058509ca6da7c1306ced3a61e1c.diff

[PATCH] D69263: [clangd] Implement cross-file rename.

2019-11-18 Thread Haojian Wu via Phabricator via cfe-commits
hokein marked an inline comment as done. hokein added a comment. In D69263#1738289 , @ilya-biryukov wrote: > LGTM. > > It's probably worth collecting a list of things we need to fix before > enabling cross-file rename and putting it somewhere (a GitHub

[PATCH] D69825: [Clang][Driver] Bypass cc1 process and re-enter driver main

2019-11-18 Thread Hans Wennborg via Phabricator via cfe-commits
hans added a comment. In D69825#1747539 , @aganea wrote: > @hans : Simply because `ExecuteCC1Tool()` lives in the clang tool > (`clang/tools/driver/driver.cpp`) and we're calling it from the > clangDriver.lib (`clang/lib/Driver/Job.cpp`). The

[PATCH] D45444: [clang-tidy] implement new check for const-correctness

2019-11-18 Thread Jonas Toth via Phabricator via cfe-commits
JonasToth updated this revision to Diff 229818. JonasToth added a comment. - update license - rebase to master and patch for adding const Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D45444/new/ https://reviews.llvm.org/D45444 Files:

[PATCH] D69978: Separately track input and output denormal mode

2019-11-18 Thread Matt Arsenault via Phabricator via cfe-commits
arsenm marked an inline comment as done. arsenm added inline comments. Comment at: llvm/docs/LangRef.rst:1822 ``"denorm-fp-mode"`` + This indicates the subnormal handling that may be assumed for the andrew.w.kaylor wrote: > I don't like the definition of

[PATCH] D45444: [clang-tidy] implement new check for const-correctness

2019-11-18 Thread Jonas Toth via Phabricator via cfe-commits
JonasToth added a comment. Herald added a subscriber: mgehre. In D45444#1685995 , @tsdgeos wrote: > Would this warn with stuff like > > double borderWidth; > [... code that doesn't use borderWidth ...] > borderWidth = border->getWidth(); > [...

[PATCH] D70222: [clangd] Add support for .rsp files in compile_commands.json

2019-11-18 Thread liu hui via Phabricator via cfe-commits
lh123 updated this revision to Diff 229807. lh123 added a comment. Move the implementation to `JSONCompilationDatabase`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70222/new/ https://reviews.llvm.org/D70222 Files: clang/lib/Tooling/JSONCompilationDatabase.cpp Index:

[PATCH] D70380: [clangd] Expose the xref's incomplete flag to clangdServer API.

2019-11-18 Thread Haojian Wu via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG5181adab6183: [clangd] Expose the xrefs incomplete flag to clangdServer API. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70380/new/

[PATCH] D70390: [clang-tidy] new performance-no-automatic-move check.

2019-11-18 Thread Clement Courbet via Phabricator via cfe-commits
courbet created this revision. courbet added a reviewer: aaron.ballman. Herald added subscribers: xazax.hun, mgorny. Herald added a project: clang. The check flags constructs that prevent automatic move of local variables. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D70390

[PATCH] D70052: [clang-tidy] Add misc-mutating-copy check

2019-11-18 Thread Jonas Toth via Phabricator via cfe-commits
JonasToth added a comment. There is a `ExprMutAnalyzer` that is able to find mutation of expressions in general (even though it is kinda experimental still). Maybe that should be utilized somehow? I think the current implementation does not cover when the address is taken and mutation happens

[PATCH] D69263: [clangd] Implement cross-file rename.

2019-11-18 Thread Haojian Wu via Phabricator via cfe-commits
hokein updated this revision to Diff 229815. hokein marked an inline comment as done. hokein added a comment. rebase and call getMacroArgExpandedLocation in prepareRename. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69263/new/

[PATCH] D69934: [clangd] Implement rename by using SelectionTree and findExplicitReferences.

2019-11-18 Thread Ilya Biryukov via Phabricator via cfe-commits
ilya-biryukov added a comment. Thanks, LG. The only important is about testing the `foo.inc` case separately from the rest of rename tests. Comment at: clang-tools-extra/clangd/refactor/Rename.cpp:180 +const NamedDecl (const NamedDecl ) { + if (const auto *T =

[PATCH] D70222: [clangd] Add support for .rsp files in compile_commands.json

2019-11-18 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet added a comment. Thanks, layering seems better now. But as Sam mentioned in the issue it would be better to have something like `expandRSPFiles` similar to `inferMissingCompileCommands`. As the problem is not in the `JSONCompilationDatabase` itself, it can also occur in

[PATCH] D70380: [clangd] Expose the xref's incomplete flag to clangdServer API.

2019-11-18 Thread Haojian Wu via Phabricator via cfe-commits
hokein updated this revision to Diff 229808. hokein marked 3 inline comments as done. hokein added a comment. address naming comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70380/new/ https://reviews.llvm.org/D70380 Files:

[PATCH] D70222: [clangd] Add support for .rsp files in compile_commands.json

2019-11-18 Thread liu hui via Phabricator via cfe-commits
lh123 updated this revision to Diff 229812. lh123 added a comment. Respect `JSONCommandLineSyntax` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70222/new/ https://reviews.llvm.org/D70222 Files: clang/lib/Tooling/JSONCompilationDatabase.cpp Index:

[PATCH] D69934: [clangd] Implement rename by using SelectionTree and findExplicitReferences.

2019-11-18 Thread Haojian Wu via Phabricator via cfe-commits
hokein updated this revision to Diff 229822. hokein marked 4 inline comments as done. hokein added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69934/new/ https://reviews.llvm.org/D69934 Files:

[PATCH] D69934: [clangd] Implement rename by using SelectionTree and findExplicitReferences.

2019-11-18 Thread Haojian Wu via Phabricator via cfe-commits
hokein added inline comments. Comment at: clang-tools-extra/clangd/unittests/RenameTests.cpp:371 auto TU = TestTU::withCode(Code.code()); +TU.AdditionalFiles["foo.inc"] = R"cpp( + #define Macro(X) X ilya-biryukov wrote: > Maybe test this

[clang-tools-extra] f21b2d8 - [clangd] Fix diagnostic warnings in the RenameTests, NFC.

2019-11-18 Thread Haojian Wu via cfe-commits
Author: Haojian Wu Date: 2019-11-18T15:03:11+01:00 New Revision: f21b2d8e42f87ad6958599a385ed7bbc4df86de6 URL: https://github.com/llvm/llvm-project/commit/f21b2d8e42f87ad6958599a385ed7bbc4df86de6 DIFF: https://github.com/llvm/llvm-project/commit/f21b2d8e42f87ad6958599a385ed7bbc4df86de6.diff

[clang-tools-extra] b622ff3 - [clangd] Fix some clang-tidy warnings on SourceCodeTests.cpp, NFC.

2019-11-18 Thread Haojian Wu via cfe-commits
Author: Haojian Wu Date: 2019-11-18T15:20:42+01:00 New Revision: b622ff39c0c482494a7400ac0256b543025cd449 URL: https://github.com/llvm/llvm-project/commit/b622ff39c0c482494a7400ac0256b543025cd449 DIFF: https://github.com/llvm/llvm-project/commit/b622ff39c0c482494a7400ac0256b543025cd449.diff

[PATCH] D70390: [clang-tidy] new performance-no-automatic-move check.

2019-11-18 Thread Jonas Toth via Phabricator via cfe-commits
JonasToth added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/performance-no-automatic-move.rst:47 +std::vector&& obj = ...; +return std::move(obj); // calls StatusOr::StatusOr(std::vector&&) + } While checking this example it

[PATCH] D70008: [clangd] Store xref for Macros in ParsedAST.

2019-11-18 Thread UTKARSH SAXENA via Phabricator via cfe-commits
usaxena95 marked an inline comment as done. usaxena95 added inline comments. Comment at: clang-tools-extra/clangd/unittests/CollectMacrosTests.cpp:28 + )cpp", + // FIXME: Locating macro in duplicate definitions doesn't work. Enable + // this once LocateMacro is

[PATCH] D49466: Initial implementation of -fmacro-prefix-map and -ffile-prefix-map

2019-11-18 Thread Dan McGregor via Phabricator via cfe-commits
dankm added a comment. Whoops. There are extra changes here I didn't mean to submit :/ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D49466/new/ https://reviews.llvm.org/D49466 ___ cfe-commits mailing

[clang] 8c8c941 - Remove useless param tag to fix Wdocumentation warning. NFCI.

2019-11-18 Thread Simon Pilgrim via cfe-commits
Author: Simon Pilgrim Date: 2019-11-18T14:09:11Z New Revision: 8c8c941844080625fd2989bd4045cdd5db4bb908 URL: https://github.com/llvm/llvm-project/commit/8c8c941844080625fd2989bd4045cdd5db4bb908 DIFF: https://github.com/llvm/llvm-project/commit/8c8c941844080625fd2989bd4045cdd5db4bb908.diff

[PATCH] D70390: [clang-tidy] new performance-no-automatic-move check.

2019-11-18 Thread Eugene Zelenko via Phabricator via cfe-commits
Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:143 + + The check flags constructs that prevent automatic move of local variables. + Please omit //The check// and synchronize with first sentence of documentation.

[PATCH] D49466: Initial implementation of -fmacro-prefix-map and -ffile-prefix-map

2019-11-18 Thread Dan McGregor via Phabricator via cfe-commits
dankm updated this revision to Diff 229835. dankm added a comment. Herald added subscribers: lldb-commits, mgorny. Herald added a project: LLDB. - Address feedback from @Lekensteyn Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D49466/new/

[PATCH] D70111: [DWARF5]Addition of alignment field in the typedef for dwarf5

2019-11-18 Thread Sam McCall via Phabricator via cfe-commits
sammccall added a comment. I'm reverting because this breaks ABI for llvm-c (and the go bindings). Feel free to reapply with that change removed, though. (If this option is required for the C API, I'm not sure what the best approach is) Comment at:

[PATCH] D70008: [clangd] Store xref for Macros in ParsedAST.

2019-11-18 Thread UTKARSH SAXENA via Phabricator via cfe-commits
usaxena95 updated this revision to Diff 229836. usaxena95 marked 8 inline comments as done. usaxena95 added a comment. Addressed comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70008/new/ https://reviews.llvm.org/D70008 Files:

[PATCH] D62731: Add support for options -frounding-math, -ftrapping-math, -ffp-model=, and -ffp-exception-behavior=, : Specify floating point behavior

2019-11-18 Thread Melanie Blower via Phabricator via cfe-commits
mibintc added a comment. Thanks I see it, I'm working on a patch. Previously there was no support for frounding-math (unimplemented). This patch enables the option. In the IR builder, there's a call to a runtime function in the exception handler which is unexpectedly null. I start by adding a

[PATCH] D49466: Initial implementation of -fmacro-prefix-map and -ffile-prefix-map

2019-11-18 Thread Dan McGregor via Phabricator via cfe-commits
dankm marked an inline comment as done. dankm added inline comments. Comment at: clang/test/Driver/debug-prefix-map.c:8 +// RUN: %clang -### -ffile-prefix-map=old=new %s 2>&1 | FileCheck %s -check-prefix CHECK-DEBUG-SIMPLE +// RUN: %clang -### -ffile-prefix-map=old=new %s 2>&1

[PATCH] D69979: clang: Guess at some platform FTZ/DAZ default settings

2019-11-18 Thread Sanjay Patel via Phabricator via cfe-commits
spatel added a comment. In D69979#1749198 , @arsenm wrote: > I just posted the test I wrote here: https://github.com/arsenm/subnormal_test Thanks. I tried compiling with gcc (can't trust clang since it doesn't honor #pragma STDC FENV_ACCESS ON?). And

[clang-tools-extra] 4f80fc2 - [clangd] Implement rename by using SelectionTree and findExplicitReferences.

2019-11-18 Thread Haojian Wu via cfe-commits
Author: Haojian Wu Date: 2019-11-18T16:16:47+01:00 New Revision: 4f80fc2491cc35730a9a84b86975278b7daa8522 URL: https://github.com/llvm/llvm-project/commit/4f80fc2491cc35730a9a84b86975278b7daa8522 DIFF: https://github.com/llvm/llvm-project/commit/4f80fc2491cc35730a9a84b86975278b7daa8522.diff

[PATCH] D70245: [OPENMP50]Add device/kind context selector support.

2019-11-18 Thread Alexey Bataev via Phabricator via cfe-commits
ABataev updated this revision to Diff 229843. ABataev added a comment. Address comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70245/new/ https://reviews.llvm.org/D70245 Files: clang/include/clang/Basic/Attr.td

[PATCH] D70366: Add new 'flatten' LLVM attribute to fix clang's 'flatten' function attribute

2019-11-18 Thread LevitatingLion via Phabricator via cfe-commits
LevitatingLion added inline comments. Comment at: llvm/docs/LangRef.rst:1428 can prove that the call/invoke cannot call a convergent function. +``flatten`` +This attribute is similar to ``alwaysinline``, but applies recursively to arsenm wrote: > It's

[PATCH] D69934: [clangd] Implement rename by using SelectionTree and findExplicitReferences.

2019-11-18 Thread Ilya Biryukov via Phabricator via cfe-commits
ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69934/new/ https://reviews.llvm.org/D69934

[PATCH] D67536: [clangd] Inactive regions support as an extension to semantic highlighting

2019-11-18 Thread Haojian Wu via Phabricator via cfe-commits
hokein added a comment. thanks, mostly good, a few more nits. Comment at: clang-tools-extra/clangd/ParsedAST.h:134 + // Ranges skipped during preprocessing. + std::vector SkippedRanges; }; nit: it is not used anymore, remove it. Comment

[PATCH] D70390: [clang-tidy] new performance-no-automatic-move check.

2019-11-18 Thread Clement Courbet via Phabricator via cfe-commits
courbet marked 3 inline comments as done. courbet added a comment. Thanks for the comments Comment at: clang-tools-extra/docs/clang-tidy/checks/performance-no-automatic-move.rst:47 +std::vector&& obj = ...; +return std::move(obj); // calls

[PATCH] D70390: [clang-tidy] new performance-no-automatic-move check.

2019-11-18 Thread Clement Courbet via Phabricator via cfe-commits
courbet updated this revision to Diff 229833. courbet marked an inline comment as done. courbet added a comment. Fix markdown in doc. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70390/new/ https://reviews.llvm.org/D70390 Files:

[clang] d27a16e - Revert "[DWARF5]Addition of alignment atrribute in typedef DIE."

2019-11-18 Thread Sam McCall via cfe-commits
Author: Sam McCall Date: 2019-11-18T15:53:22+01:00 New Revision: d27a16eb392f39f9ee04ff5194b1eff3e189e6f8 URL: https://github.com/llvm/llvm-project/commit/d27a16eb392f39f9ee04ff5194b1eff3e189e6f8 DIFF: https://github.com/llvm/llvm-project/commit/d27a16eb392f39f9ee04ff5194b1eff3e189e6f8.diff

[PATCH] D49466: Initial implementation of -fmacro-prefix-map and -ffile-prefix-map

2019-11-18 Thread Dan McGregor via Phabricator via cfe-commits
dankm updated this revision to Diff 229837. dankm added a comment. - Address feedback from @Lekensteyn Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D49466/new/ https://reviews.llvm.org/D49466 Files:

[PATCH] D69620: Add AIX assembler support

2019-11-18 Thread David Tenty via Phabricator via cfe-commits
daltenty added inline comments. Comment at: clang/lib/Driver/ToolChains/AIX.h:26 + + bool hasIntegratedCPP() const override { return false; } + stevewan wrote: > Xiangling_L wrote: > > I saw a lot of other target also set `hasIntegratedCPP()` as false, but I >

[PATCH] D49466: Initial implementation of -fmacro-prefix-map and -ffile-prefix-map

2019-11-18 Thread Dan McGregor via Phabricator via cfe-commits
dankm added a comment. In D49466#1681534 , @phosek wrote: > @dankm is it OK if we take over this change to push it forward? At this point sure. Unless it's accepted as-is now, then I don't have a commit bit to finish it off. Repository: rG LLVM

[PATCH] D70008: [clangd] Store xref for Macros in ParsedAST.

2019-11-18 Thread Haojian Wu via Phabricator via cfe-commits
hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. lgtm, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70008/new/ https://reviews.llvm.org/D70008

[PATCH] D70390: [clang-tidy] new performance-no-automatic-move check.

2019-11-18 Thread Clement Courbet via Phabricator via cfe-commits
courbet updated this revision to Diff 229840. courbet added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70390/new/ https://reviews.llvm.org/D70390 Files: clang-tools-extra/clang-tidy/performance/CMakeLists.txt

[PATCH] D70390: [clang-tidy] new performance-no-automatic-move check.

2019-11-18 Thread Clement Courbet via Phabricator via cfe-commits
courbet marked 2 inline comments as done. courbet added a comment. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70390/new/ https://reviews.llvm.org/D70390 ___ cfe-commits mailing list

[PATCH] D70390: [clang-tidy] new performance-no-automatic-move check.

2019-11-18 Thread Roman Lebedev via Phabricator via cfe-commits
lebedev.ri added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/performance-no-automatic-move.rst:47 +std::vector&& obj = ...; +return std::move(obj); // calls StatusOr::StatusOr(std::vector&&) + } courbet wrote: > JonasToth

[PATCH] D69934: [clangd] Implement rename by using SelectionTree and findExplicitReferences.

2019-11-18 Thread Haojian Wu via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG4f80fc2491cc: [clangd] Implement rename by using SelectionTree and findExplicitReferences. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang-tools-extra] 2054ed0 - [clangd] Store xref for Macros in ParsedAST.

2019-11-18 Thread Utkarsh Saxena via cfe-commits
Author: Utkarsh Saxena Date: 2019-11-18T16:47:18+01:00 New Revision: 2054ed052f15b584e1bce57c8f765991eab2da7d URL: https://github.com/llvm/llvm-project/commit/2054ed052f15b584e1bce57c8f765991eab2da7d DIFF:

[clang] c85fa79 - [Attr] Fix `-ast-print` for `asm` attribute

2019-11-18 Thread Joel E. Denny via cfe-commits
Author: Joel E. Denny Date: 2019-11-18T11:55:25-05:00 New Revision: c85fa79d3663ecb3117e178b2a79ffa721d18e32 URL: https://github.com/llvm/llvm-project/commit/c85fa79d3663ecb3117e178b2a79ffa721d18e32 DIFF: https://github.com/llvm/llvm-project/commit/c85fa79d3663ecb3117e178b2a79ffa721d18e32.diff

[clang] c3eded0 - [OPENMP50]Fix PR44024: runtime assert in distribute construct.

2019-11-18 Thread Alexey Bataev via cfe-commits
Author: Alexey Bataev Date: 2019-11-18T11:14:27-05:00 New Revision: c3eded068c64bfe614d25359927a2917ff8e4a35 URL: https://github.com/llvm/llvm-project/commit/c3eded068c64bfe614d25359927a2917ff8e4a35 DIFF: https://github.com/llvm/llvm-project/commit/c3eded068c64bfe614d25359927a2917ff8e4a35.diff

[PATCH] D70349: [Attr] Fix `-ast-print` for `asm` attribute

2019-11-18 Thread Joel E. Denny via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGc85fa79d3663: [Attr] Fix `-ast-print` for `asm` attribute (authored by jdenny). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70349/new/

[PATCH] D68155: [clang][NFC] Make various uses of Regex const

2019-11-18 Thread Thomas Preud'homme via Phabricator via cfe-commits
thopre accepted this revision. thopre added a comment. This revision is now accepted and ready to land. LGTM. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68155/new/ https://reviews.llvm.org/D68155 ___ cfe-commits

[clang] b4e2b11 - [Remarks][Driver] Use different remark files when targeting multiple architectures

2019-11-18 Thread Francis Visoiu Mistrih via cfe-commits
Author: Francis Visoiu Mistrih Date: 2019-11-18T10:38:10-08:00 New Revision: b4e2b112b58154a89171df39dae80044865ff4ff URL: https://github.com/llvm/llvm-project/commit/b4e2b112b58154a89171df39dae80044865ff4ff DIFF:

[clang] 1ff5f0c - Revert "[Remarks][Driver] Use different remark files when targeting multiple architectures"

2019-11-18 Thread Reid Kleckner via cfe-commits
Author: Reid Kleckner Date: 2019-11-18T10:52:41-08:00 New Revision: 1ff5f0ced3163e457c799bd3bd838153806d6320 URL: https://github.com/llvm/llvm-project/commit/1ff5f0ced3163e457c799bd3bd838153806d6320 DIFF: https://github.com/llvm/llvm-project/commit/1ff5f0ced3163e457c799bd3bd838153806d6320.diff

Re: [clang] b4e2b11 - [Remarks][Driver] Use different remark files when targeting multiple architectures

2019-11-18 Thread Reid Kleckner via cfe-commits
I reverted this, the test fails for me locally. Does -arch work on non-Mac targets? On Mon, Nov 18, 2019 at 10:39 AM Francis Visoiu Mistrih via cfe-commits < cfe-commits@lists.llvm.org> wrote: > > Author: Francis Visoiu Mistrih > Date: 2019-11-18T10:38:10-08:00 > New Revision:

[clang] 8bfb353 - [Sema] Fix a -Wobjc-signed-char-bool false-positive

2019-11-18 Thread Erik Pilkington via cfe-commits
Author: Erik Pilkington Date: 2019-11-18T12:15:20-08:00 New Revision: 8bfb353bb33cd2bcd2ef28e36eb8b90123b153c4 URL: https://github.com/llvm/llvm-project/commit/8bfb353bb33cd2bcd2ef28e36eb8b90123b153c4 DIFF:

[clang] a77b66a - Allocate builtins table earlier to fix bug found by ubsan

2019-11-18 Thread Reid Kleckner via cfe-commits
Author: Reid Kleckner Date: 2019-11-18T10:41:30-08:00 New Revision: a77b66a05625ea4271c2d76f65428cce02e4699e URL: https://github.com/llvm/llvm-project/commit/a77b66a05625ea4271c2d76f65428cce02e4699e DIFF: https://github.com/llvm/llvm-project/commit/a77b66a05625ea4271c2d76f65428cce02e4699e.diff

[clang] e15b26f - Reland: [Remarks][Driver] Use different remark files when targeting multiple architectures

2019-11-18 Thread Francis Visoiu Mistrih via cfe-commits
Author: Francis Visoiu Mistrih Date: 2019-11-18T11:17:38-08:00 New Revision: e15b26fbbd901315a1402f97e83abf29bdce9a9f URL: https://github.com/llvm/llvm-project/commit/e15b26fbbd901315a1402f97e83abf29bdce9a9f DIFF:

[PATCH] D69876: Allow output constraints on "asm goto"

2019-11-18 Thread Nick Desaulniers via Phabricator via cfe-commits
nickdesaulniers added inline comments. Comment at: clang/lib/Analysis/UninitializedValues.cpp:830 + + for (unsigned i = 0, e = as->getNumOutputs(); i != e; ++i) { +FindVarResult Var = findVar(as->getOutputExpr(i)); `GCCAsmStmt` inherits from `AsmStmt` which

[clang] ee31adb - Populate CUDA flags on FreeBSD too, as many other toolchains do.

2019-11-18 Thread Dimitry Andric via cfe-commits
Author: Dimitry Andric Date: 2019-11-18T21:54:25+01:00 New Revision: ee31adb7fa42f5b601d9612f23755b4604f83cac URL: https://github.com/llvm/llvm-project/commit/ee31adb7fa42f5b601d9612f23755b4604f83cac DIFF:

[PATCH] D70317: [clangd] More sensible output for constructors/destructors in hover.

2019-11-18 Thread pre-merge checks [bot] via Phabricator via cfe-commits
merge_guards_bot added a comment. Build result: pass - 60168 tests passed, 0 failed and 731 were skipped. Log files: console-log.txt , CMakeCache.txt

[clang] 30e7ee3 - Temporarily Revert "Add support for options -frounding-math, ftrapping-math, -ffp-model=, and -ffp-exception-behavior="

2019-11-18 Thread Eric Christopher via cfe-commits
Author: Eric Christopher Date: 2019-11-18T10:46:48-08:00 New Revision: 30e7ee3c4bac4a12ea584a879aa320bd4e035cc2 URL: https://github.com/llvm/llvm-project/commit/30e7ee3c4bac4a12ea584a879aa320bd4e035cc2 DIFF:

Re: [PATCH] D62731: Add support for options -frounding-math, -ftrapping-math, -ffp-model=, and -ffp-exception-behavior=, : Specify floating point behavior

2019-11-18 Thread Eric Christopher via cfe-commits
Hi All, I've gone ahead and temporarily reverted here: echristo@jhereg ~/s/llvm-project> git push To github.com:llvm/llvm-project.git a77b66a0562..30e7ee3c4ba master -> master and we can just reapply when the issues are fixed. Thanks :) -eric On Mon, Nov 18, 2019 at 6:58 AM Melanie Blower

[PATCH] D69876: Allow output constraints on "asm goto"

2019-11-18 Thread Bill Wendling via Phabricator via cfe-commits
void updated this revision to Diff 229904. void marked 2 inline comments as done. void added a comment. Remove a "const_cast" and use iterators for output constraints. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69876/new/

[PATCH] D69990: Populate CUDA flags on FreeBSD too, as many other toolchains do.

2019-11-18 Thread Dimitry Andric via Phabricator via cfe-commits
dim added a comment. In D69990#1750348 , @tra wrote: > LGTM, though I'm curious if it's particularly useful. Last time I checked > NVIDIA didn't ship libcudart for FreeBSD and without it it's rather > cumbersome to use CUDA in practice. After

[clang] 2492b5a - [profile] Support online merging with continuous sync mode

2019-11-18 Thread Vedant Kumar via cfe-commits
Author: Vedant Kumar Date: 2019-11-18T12:56:58-08:00 New Revision: 2492b5a12550f7c4bb428c3761392f2ce47fa269 URL: https://github.com/llvm/llvm-project/commit/2492b5a12550f7c4bb428c3761392f2ce47fa269 DIFF: https://github.com/llvm/llvm-project/commit/2492b5a12550f7c4bb428c3761392f2ce47fa269.diff

[PATCH] D69145: Give readability-redundant-member-init an option IgnoreBaseInCopyConstructors to avoid breaking code with gcc -Werror=extra

2019-11-18 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added a comment. In D69145#1748733 , @lebedev.ri wrote: > In D69145#1748716 , @poelmanc wrote: > > > In D69145#1715611 , @mgehre wrote: > > > > > Exactly due

  1   2   >