[PATCH] D71124: [RISCV] support clang driver to select cpu

Jim added inline comments. Comment at: clang/lib/Basic/Targets/RISCV.h:46 + bool setCPU(const std::string ) override { +CPU = Name; I think this should test cpu name is valid first. And assign Name to CPU, if it is valid. Repository: rC Clang

[PATCH] D71179: [OpenMP][WIP] Initial support for `begin/end declare variant`

JonChesterfield added a comment. Great to see the fragile math.h stuff disappear. I'm not sure about the CPU/GPU/other granularity. An openmp program with x86 as the host and target offload regions for amdgcn and for nvptx seems like a reasonable aspiration. Or for a couple of different

[PATCH] D71189: [Parser] Don't crash on MS assembly if target desc/asm parser isn't linked in.

merge_guards_bot added a comment. Build result: pass - 60607 tests passed, 0 failed and 726 were skipped. Log files: console-log.txt , CMakeCache.txt

[PATCH] D71187: [clangd] Delete default arguments while moving functions out-of-line

merge_guards_bot added a comment. Build result: pass - 60555 tests passed, 0 failed and 726 were skipped. Log files: console-log.txt , CMakeCache.txt

[PATCH] D71179: [OpenMP][WIP] Initial support for `begin/end declare variant`

JonChesterfield added inline comments. Comment at: clang/lib/Headers/__clang_cuda_cmath.h:70 __DEVICE__ float fmod(float __x, float __y) { return ::fmodf(__x, __y); } -// TODO: remove when variant is supported -#ifndef _OPENMP jdoerfert wrote: > As far as I can

[PATCH] D71186: Reland "[AST] Traverse the class type loc inside the member type loc.""

merge_guards_bot added a comment. Build result: pass - 60555 tests passed, 0 failed and 726 were skipped. Log files: console-log.txt , CMakeCache.txt

[PATCH] D71187: [clangd] Delete default arguments while moving functions out-of-line

kadircet updated this revision to Diff 232790. kadircet added a comment. - Add `.` after comment and fix indentation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71187/new/ https://reviews.llvm.org/D71187 Files:

[clang] f3e6a61 - [OpenCL] Handle address space conversions for constexpr (PR44177)

Author: Sven van Haastregt Date: 2019-12-09T11:09:16Z New Revision: f3e6a61232640f2ec78b97d44cc0b5ba12676a0d URL: https://github.com/llvm/llvm-project/commit/f3e6a61232640f2ec78b97d44cc0b5ba12676a0d DIFF: https://github.com/llvm/llvm-project/commit/f3e6a61232640f2ec78b97d44cc0b5ba12676a0d.diff

[PATCH] D71189: [Parser] Don't crash on MS assembly if target desc/asm parser isn't linked in.

kadircet added inline comments. Comment at: clang-tools-extra/clangd/unittests/DiagnosticsTests.cpp:1018 + } // namespace nit: empty line Comment at: clang/lib/Parse/ParseStmtAsm.cpp:591 std::unique_ptr MAI(

[PATCH] D71189: [Parser] Don't crash on MS assembly if target desc/asm parser isn't linked in.

merge_guards_bot added a comment. Build result: pass - 60607 tests passed, 0 failed and 726 were skipped. Log files: console-log.txt , CMakeCache.txt

[PATCH] D71185: [DWARF5] Start emitting DW_AT_dwo_name when -gdwarf-5 is specified.

SouraVX created this revision. SouraVX added reviewers: aprantl, dblaikie. SouraVX added projects: debug-info, LLVM. Herald added subscribers: llvm-commits, cfe-commits, dexonsmith, steven_wu, hiraditya, mehdi_amini. Herald added a project: clang. Repository: rG LLVM Github Monorepo

[PATCH] D71172: [clang][Tooling] Fix potential UB in ExpandResponseFilesCompilationDatabase

merge_guards_bot added a comment. Build result: pass - 60606 tests passed, 0 failed and 726 were skipped. Log files: console-log.txt , CMakeCache.txt

[PATCH] D71187: [clangd] Delete default arguments while moving functions out-of-line

merge_guards_bot added a comment. Build result: pass - 60555 tests passed, 0 failed and 726 were skipped. Log files: console-log.txt , CMakeCache.txt

[PATCH] D71186: Reland "[AST] Traverse the class type loc inside the member type loc.""

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/unittests/Tooling/RecursiveASTVisitorTests/MemberPointerTypeLoc.cpp:50 + EXPECT_FALSE(Visitor.runOver(R"cpp( + class a(b(a::*))

[PATCH] D71179: [OpenMP][WIP] Initial support for `begin/end declare variant`

JonChesterfield added inline comments. Comment at: clang/test/OpenMP/begin_declare_variant_codegen.cpp:71 +} + +// Make sure all ompvariant functions return 1 and all others return 0. The name mangling should probably append the device kind, .e.g.

[PATCH] D71186: Reland "[AST] Traverse the class type loc inside the member type loc.""

hokein updated this revision to Diff 232782. hokein added a comment. address the review comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71186/new/ https://reviews.llvm.org/D71186 Files:

[PATCH] D70157: Align branches within 32-Byte boundary

fedor.sergeev added a comment. In D70157#1774561 , @skan wrote: > I could not reproduce the phenomenon that N-byte nop becomes (N+M) bytes with > your example. So according to my understanding, I slightly modified your > case. (If my understand is

[PATCH] D71186: Reland "[AST] Traverse the class type loc inside the member type loc.""

hokein marked 2 inline comments as done. hokein added inline comments. Comment at: clang/unittests/Tooling/RecursiveASTVisitorTests/MemberPointerTypeLoc.cpp:50 + EXPECT_FALSE(Visitor.runOver(R"cpp( + class a(b(a::*)) class + )cpp")); ilya-biryukov wrote:

[PATCH] D71189: [Parser] Don't crash on MS assembly if target desc/asm parser isn't linked in.

sammccall updated this revision to Diff 232791. sammccall added a comment. revert random meaningless changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71189/new/ https://reviews.llvm.org/D71189 Files:

[PATCH] D71189: [Parser] Don't crash on MS assembly if target desc/asm parser isn't linked in.

sammccall created this revision. sammccall added a reviewer: kadircet. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, ilya-biryukov, mgorny. Herald added a project: clang. sammccall updated this revision to Diff 232791. sammccall added a comment. revert random meaningless

[PATCH] D71188: [clangd] Delete ctor initializers while moving functions out-of-line

merge_guards_bot added a comment. Build result: FAILURE - Could not check out parent git hash "8d52e0ffa278d9047731523cc72ce605f8f336df". It was not found in the repository. Did you configure the "Parent Revision" in Phabricator properly? Trying to apply the patch to the master branch

[PATCH] D71186: Reland "[AST] Traverse the class type loc inside the member type loc.""

This revision was automatically updated to reflect the committed changes. hokein marked an inline comment as done. Closed by commit rG6d5c273500ad: Reland [AST] Traverse the class type loc inside the member type loc. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang-tools-extra] 6d5c273 - Reland "[AST] Traverse the class type loc inside the member type loc.""

Author: Haojian Wu Date: 2019-12-09T11:18:12+01:00 New Revision: 6d5c273500ad8352a061126999235aa71e0056ce URL: https://github.com/llvm/llvm-project/commit/6d5c273500ad8352a061126999235aa71e0056ce DIFF: https://github.com/llvm/llvm-project/commit/6d5c273500ad8352a061126999235aa71e0056ce.diff

[PATCH] D71186: Reland "[AST] Traverse the class type loc inside the member type loc.""

merge_guards_bot added a comment. Build result: pass - 60555 tests passed, 0 failed and 726 were skipped. Log files: console-log.txt , CMakeCache.txt

[PATCH] D71015: [OpenCL] Handle address space conversions for constexpr (PR44177)

This revision was automatically updated to reflect the committed changes. Closed by commit rGf3e6a6123264: [OpenCL] Handle address space conversions for constexpr (PR44177) (authored by svenvh). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D71049: Remove implicit conversion that promotes half to other larger precision types for fp classification builtins

Jim updated this revision to Diff 232765. Jim added a comment. Thank you for review. Update patch and add tests that test half value will not be promoted to double. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71049/new/

[PATCH] D71185: [DWARF5] Start emitting DW_AT_dwo_name when -gdwarf-5 is specified.

merge_guards_bot added a comment. Build result: pass - 60606 tests passed, 0 failed and 726 were skipped. Log files: console-log.txt , CMakeCache.txt

[PATCH] D71172: [clang][Tooling] Fix potential UB in ExpandResponseFilesCompilationDatabase

lh123 updated this revision to Diff 232771. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71172/new/ https://reviews.llvm.org/D71172 Files: clang/lib/Tooling/ExpandResponseFilesCompilationDatabase.cpp Index:

[PATCH] D71172: [clang][Tooling] Fix potential UB in ExpandResponseFilesCompilationDatabase

lh123 updated this revision to Diff 232770. lh123 added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71172/new/ https://reviews.llvm.org/D71172 Files: clang/lib/Tooling/ExpandResponseFilesCompilationDatabase.cpp

[PATCH] D71186: Reland "[AST] Traverse the class type loc inside the member type loc.""

hokein created this revision. hokein added a reviewer: ilya-biryukov. Herald added subscribers: usaxena95, kadircet, arphaman, jkorous, mgorny. Herald added a project: clang. added a unittest which causes "TL.getClassTInfo" is null. Repository: rG LLVM Github Monorepo

[PATCH] D71187: [clangd] Delete default arguments while moving functions out-of-line

kadircet created this revision. kadircet added a reviewer: hokein. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Only function declarations should have the default arguments. This patch makes sure we don't propogate

[PATCH] D71172: [clang][Tooling] Fix potential UB in ExpandResponseFilesCompilationDatabase

merge_guards_bot added a comment. Build result: pass - 60606 tests passed, 0 failed and 726 were skipped. Log files: console-log.txt , CMakeCache.txt

[PATCH] D71001: [clang-tidy] New check: bugprone-misplaced-pointer-arithmetic-in-alloc

whisperity added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/MisplacedPointerArithmeticInAllocCheck.cpp:81-82 + diag(PtrArith->getBeginLoc(), + "pointer arithmetic is applied to the result of %0() instead of its " + "argument") + <<

[PATCH] D71172: [clang][Tooling] Fix potential UB in ExpandResponseFilesCompilationDatabase

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Thanks! Might be worth a comment like "don't assign directly, Argv aliases CommandLine" or so Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D71172: [clang][Tooling] Fix potential UB in ExpandResponseFilesCompilationDatabase

lh123 added a comment. @sammccall Could you commit this, I don't have commit access. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71172/new/ https://reviews.llvm.org/D71172 ___ cfe-commits mailing

[PATCH] D71179: [OpenMP][WIP] Initial support for `begin/end declare variant`

ABataev added a comment. In D71179#1774487 , @jdoerfert wrote: > In D71179#1774471 , @ABataev wrote: > > > They do this because they have several function definitions with the same > > name. In our case, we have

[PATCH] D71187: [clangd] Delete default arguments while moving functions out-of-line

ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/unittests/TweakTests.cpp:1938 }, + // Default args + { NIT: missing full period at the end of the comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D71188: [clangd] Delete ctor initializers while moving functions out-of-line

kadircet created this revision. kadircet added reviewers: hokein, ilya-biryukov. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay. Herald added a project: clang. Currently we only delete function body from declaration, in addition to that we should also drop ctor

[PATCH] D71193: [clang] Turn -fno-builtin flag into an IR Attribute

gchatelet created this revision. gchatelet added reviewers: aaron.ballman, courbet. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is a follow up on https://reviews.llvm.org/D61634#1742154 to turn the clang driver -fno-builtin flag into an IR attribute. I also

[PATCH] D57747: [Sema] SequenceChecker: Fix handling of operator ||, && and ?:

xbolva00 added a comment. Does the whole stack of patch need to be commited at once or maybe you can land them individually? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57747/new/ https://reviews.llvm.org/D57747

[PATCH] D57660: [Sema] SequenceChecker: Handle references, members and structured bindings.

xbolva00 added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:12631 - void VisitSequencedExpressions(Expr *SequencedBefore, Expr *SequencedAfter) { + void VisitSequencedExpressions(const Expr *SequencedBefore, + const Expr

[PATCH] D49091: Warn about usage of __has_include/__has_include_next in macro expansions

torarnv added a comment. Qt fix in https://codereview.qt-project.org/c/qt/qtbase/+/284037 Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D49091/new/ https://reviews.llvm.org/D49091 ___ cfe-commits mailing list

[PATCH] D71190: [ARM][MVE] Add complex vector intrinsics

MarkMurrayARM accepted this revision. MarkMurrayARM added a comment. This revision is now accepted and ready to land. LGTM Comment at: llvm/include/llvm/IR/IntrinsicsARM.td:932 + def "": Intrinsic; + def _predicated: Intrinsic; I like this!!

[PATCH] D70696: [DebugInfo] Support to emit debugInfo for extern variables

Jac1494 added a comment. For some real life case like below we need debuginfo for declaration of global extern variable . $cat shlib.c int var; int test() { return var++; } $cat test extern int test(); extern int var; int main() { var++; printf("%d\n",test()); } If we debug above case with

[PATCH] D71189: [Parser] Don't crash on MS assembly if target desc/asm parser isn't linked in.

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71189/new/ https://reviews.llvm.org/D71189

[PATCH] D71062: [ARM][MVE] Add vector reduction intrinsics with two vector operands

MarkMurrayARM accepted this revision. MarkMurrayARM added a comment. This revision is now accepted and ready to land. This looks scary and fragile, but it seems to work, so OK. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71062/new/

[PATCH] D71199: [clang-tidy] New check readability-prefer-initialization-list

sylvestre.ledru added a comment. > affects positively its performance. Interesting! Do you have some numbers you could share? thanks Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71199/new/ https://reviews.llvm.org/D71199

[PATCH] D71197: llvm premerge: clang format test

merge_guards_bot added a comment. Build result: pass - 60624 tests passed, 0 failed and 726 were skipped. Log files: console-log.txt , CMakeCache.txt

[clang] 6626e5a - Fix compilation warning from GCC7. NFC.

Author: Michael Liao Date: 2019-12-09T10:11:27-05:00 New Revision: 6626e5a06a99b29b388f2dffde2c16f8eb5ded46 URL: https://github.com/llvm/llvm-project/commit/6626e5a06a99b29b388f2dffde2c16f8eb5ded46 DIFF: https://github.com/llvm/llvm-project/commit/6626e5a06a99b29b388f2dffde2c16f8eb5ded46.diff

[clang] f7e7a5f - [Attr] Add missing header for clang example.

Author: David Green Date: 2019-12-09T12:50:05Z New Revision: f7e7a5f1b6dd318d39627445c6a9ca7568d8cd61 URL: https://github.com/llvm/llvm-project/commit/f7e7a5f1b6dd318d39627445c6a9ca7568d8cd61 DIFF: https://github.com/llvm/llvm-project/commit/f7e7a5f1b6dd318d39627445c6a9ca7568d8cd61.diff LOG:

[PATCH] D71198: [ARM][MVE][Intrinsics] Add VQADDQ, VHADDQ, VRHADDQ, VQSUBQ, VHSUBQ, VQDMULHQ, VQRDMULHQ intrinsics.

MarkMurrayARM updated this revision to Diff 232820. MarkMurrayARM added a comment. Fix long lines. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71198/new/ https://reviews.llvm.org/D71198 Files: clang/include/clang/Basic/arm_mve.td

[PATCH] D71187: [clangd] Delete default arguments while moving functions out-of-line

kadircet updated this revision to Diff 232823. kadircet marked 4 inline comments as done. kadircet added a comment. - Make use of token buffer instead of trying to go-over identifier name. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71187/new/

[clang] 94603ec - [Parser] Don't crash on MS assembly if target desc/asm parser isn't linked in.

Author: Sam McCall Date: 2019-12-09T14:34:31+01:00 New Revision: 94603ec11b55ca22b5dbebcfca5e83f313b632e3 URL: https://github.com/llvm/llvm-project/commit/94603ec11b55ca22b5dbebcfca5e83f313b632e3 DIFF: https://github.com/llvm/llvm-project/commit/94603ec11b55ca22b5dbebcfca5e83f313b632e3.diff

[PATCH] D71188: [clangd] Delete ctor initializers while moving functions out-of-line

kadircet marked an inline comment as done. kadircet added inline comments. Comment at: clang-tools-extra/clangd/refactor/tweaks/DefineOutline.cpp:269 + } + DeletionRange.setBegin(InitStart); +} hokein wrote: > There is an alternative here, I think.

[PATCH] D71188: [clangd] Delete ctor initializers while moving functions out-of-line

kadircet updated this revision to Diff 232825. kadircet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71188/new/ https://reviews.llvm.org/D71188 Files:

[PATCH] D71198: [ARM][MVE][Intrinsics] Add VQADDQ, VHADDQ, VRHADDQ, VQSUBQ, VHSUBQ, VQDMULHQ, VQRDMULHQ intrinsics.

MarkMurrayARM updated this revision to Diff 232842. MarkMurrayARM added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71198/new/ https://reviews.llvm.org/D71198 Files: clang/include/clang/Basic/arm_mve.td

[PATCH] D71208: CodeGen: Allow annotations on globals in non-zero address space

merge_guards_bot added a comment. Build result: pass - 60628 tests passed, 0 failed and 726 were skipped. Log files: console-log.txt , CMakeCache.txt

[PATCH] D70594: [clangd] Implement range patching heuristics for cross-file rename.

hokein updated this revision to Diff 232844. hokein marked 12 inline comments as done. hokein added a comment. address comments: - don't emit the internal messages to users, llvm::Expected => llvm::Optional - use the index of lexed array to calculate the adjustment cost. Repository: rG LLVM

[PATCH] D71066: [ARM][MVE][Intrinsics] Add VMULL[BT]Q_(INT|POLY) intrinsics.

MarkMurrayARM marked 2 inline comments as done. MarkMurrayARM added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71066/new/ https://reviews.llvm.org/D71066 ___

[PATCH] D71172: [clang][Tooling] Fix potential UB in ExpandResponseFilesCompilationDatabase

This revision was automatically updated to reflect the committed changes. Closed by commit rG966fac1941ea: [clang][Tooling] Fix potential UB in ExpandResponseFilesCompilationDatabase (authored by sammccall). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 966fac1 - [clang][Tooling] Fix potential UB in ExpandResponseFilesCompilationDatabase

Author: Sam McCall Date: 2019-12-09T12:24:23+01:00 New Revision: 966fac1941ea99e076a7654d229b27e1e6e4ad17 URL: https://github.com/llvm/llvm-project/commit/966fac1941ea99e076a7654d229b27e1e6e4ad17 DIFF: https://github.com/llvm/llvm-project/commit/966fac1941ea99e076a7654d229b27e1e6e4ad17.diff

[PATCH] D71187: [clangd] Delete default arguments while moving functions out-of-line

hokein added inline comments. Comment at: clang-tools-extra/clangd/refactor/tweaks/DefineOutline.cpp:186 +if (PVD->hasDefaultArg()) { + auto DelRange = CharSourceRange::getTokenRange(PVD->getDefaultArgRange()); + auto StartLoc = PVD->getLocation();

[PATCH] D71174: [clang-tidy] new check: bugprone-signed-char-misuse

ztamas updated this revision to Diff 232814. ztamas added a comment. Fixes small things mentioned by reviewer commments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71174/new/ https://reviews.llvm.org/D71174 Files:

[PATCH] D71197: llvm premerge: clang format test

goncharov updated this revision to Diff 232813. goncharov added a comment. Trigger the build Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71197/new/ https://reviews.llvm.org/D71197 Files: clang/tools/clang-diff/ClangDiff.cpp Index:

[PATCH] D71199: [clang-tidy] New check readability-prefer-initialization-list

whisperity added a comment. Can you refresh my memory on whether a rule for "if init expr is constant, initialise in class body instead" exists for init list members? If so, this will be a funny "two pass needed to fix" kind of check. Comment at:

[PATCH] D71199: [clang-tidy] New check readability-prefer-initialization-list

whisperity added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/readability-prefer-initialization-list.cpp:221 +m = 1; +// NO-MESSAGES: initialization of m follows a conditional expression + } Comment diverged from what's

[PATCH] D71187: [clangd] Delete default arguments while moving functions out-of-line

merge_guards_bot added a comment. Build result: pass - 60555 tests passed, 0 failed and 726 were skipped. Log files: console-log.txt , CMakeCache.txt

[PATCH] D71140: [Wdocumentation] Properly place deprecated attribute

gribozavr2 accepted this revision. gribozavr2 added inline comments. This revision is now accepted and ready to land. Comment at: clang/test/Sema/warn-documentation-fixits.cpp:83 + +#if __cplusplus >= 201402L + // expected-warning@+2 {{declaration is marked with '\deprecated'

[clang] 32c802e - Fix build bot fails due to the patch here:

Author: Zahira Ammarguellat Date: 2019-12-09T09:24:47-05:00 New Revision: 32c802e0f539511f8535aaa1309cd06be86c2398 URL: https://github.com/llvm/llvm-project/commit/32c802e0f539511f8535aaa1309cd06be86c2398 DIFF:

[PATCH] D71189: [Parser] Don't crash on MS assembly if target desc/asm parser isn't linked in.

sammccall updated this revision to Diff 232798. sammccall marked an inline comment as done. sammccall added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71189/new/ https://reviews.llvm.org/D71189 Files:

[PATCH] D71189: [Parser] Don't crash on MS assembly if target desc/asm parser isn't linked in.

sammccall marked 4 inline comments as done. sammccall added inline comments. Comment at: clang/lib/Parse/ParseStmtAsm.cpp:591 std::unique_ptr MAI( TheTarget->createMCAsmInfo(*MRI, TT, MCOptions)); // Get the instruction descriptor. kadircet wrote: >

[PATCH] D70480: [clangd] Use expansion location when the ref is inside macros.

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70480/new/ https://reviews.llvm.org/D70480

[PATCH] D71179: [OpenMP][WIP] Initial support for `begin/end declare variant`

ABataev added a comment. In D71179#1775066 , @hfinkel wrote: > In D71179#1774678 , @ABataev wrote: > > > In D71179#1774487 , @jdoerfert > > wrote: > > > > > In

[PATCH] D71066: [ARM][MVE][Intrinsics] Add VMULL[BT]Q_(INT|POLY) intrinsics.

MarkMurrayARM updated this revision to Diff 232841. MarkMurrayARM added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71066/new/ https://reviews.llvm.org/D71066 Files: clang/include/clang/Basic/arm_mve.td

[PATCH] D70856: [Syntax] Build nodes for simple cases of top level declarations

ilya-biryukov updated this revision to Diff 232840. ilya-biryukov marked 5 inline comments as done. ilya-biryukov added a comment. - Remove the duplicate test - Add 'message' to the node for static_assert - Handle nested namespace definitions, add them to the tests Repository: rG LLVM Github

[PATCH] D70856: [Syntax] Build nodes for simple cases of top level declarations

ilya-biryukov added inline comments. Comment at: clang/include/clang/Tooling/Syntax/Nodes.h:346 +/// static_assert(, ) +/// static_assert() +class StaticAssertDeclaration final : public Declaration { gribozavr2 wrote: > Why no semicolon, here and in other

[PATCH] D70594: [clangd] Implement range patching heuristics for cross-file rename.

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/refactor/Rename.cpp:452 + for (int Pos : MatchedIndex) +Mapped.push_back(Lexed[Pos]); + return

[PATCH] D71197: llvm premerge: clang format test

goncharov created this revision. Herald added subscribers: cfe-commits, usaxena95, arphaman. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D71197 Files: clang/tools/clang-diff/ClangDiff.cpp Index: clang/tools/clang-diff/ClangDiff.cpp

[PATCH] D71201: [ObjC][DWARF] Emit DW_AT_APPLE_objc_direct for methods marked as __attribute__((objc_direct))

teemperor created this revision. teemperor added a reviewer: aprantl. Herald added subscribers: llvm-commits, cfe-commits, hiraditya. Herald added projects: clang, LLVM. With DWARF5 it is no longer possible to distinguish normal methods and methods with `__attribute__((objc_direct))` by just

[PATCH] D71198: [ARM][MVE][Intrinsics] Add VQADDQ, VHADDQ, VRHADDQ, VQSUBQ, VHSUBQ, VQDMULHQ, VQRDMULHQ intrinsics.

MarkMurrayARM updated this revision to Diff 232827. MarkMurrayARM added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71198/new/ https://reviews.llvm.org/D71198 Files: clang/include/clang/Basic/arm_mve.td

[PATCH] D71174: [clang-tidy] new check: bugprone-signed-char-misuse

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/SignedCharMisuseCheck.cpp:21 + +namespace { +static Matcher hasAnyListedName(const std::string ) { Anonymous namespace is not needed anymore. Repository: rG LLVM Github

[PATCH] D71066: [ARM][MVE][Intrinsics] Add VMULL[BT]Q_(INT|POLY) intrinsics.

simon_tatham added inline comments. Comment at: clang/include/clang/Basic/arm_mve_defs.td:281 +// Scalar. +def DblVector: VecOf>; + This could just be `VecOf>`, after you carefully defined `DoubleSize` above. Comment at:

[PATCH] D71190: [ARM][MVE] Add complex vector intrinsics

merge_guards_bot added a comment. Build result: pass - 60621 tests passed, 0 failed and 726 were skipped. Log files: console-log.txt , CMakeCache.txt

[PATCH] D71198: [ARM][MVE][Intrinsics] Add VQADDQ, VHADDQ, VRHADDQ, VQSUBQ, VHSUBQ, VQDMULHQ, VQRDMULHQ intrinsics.

dmgreen added a comment. Looks nice and clean. I just think we can come up with a better name than adding a _ on the end of it! Comment at: llvm/lib/Target/ARM/ARMInstrMVE.td:1591 -class MVE_VQxDMULH size, bit rounding, +class MVE_VQxDMULH_ size, bit rounding,

[PATCH] D70480: [clangd] Use expansion location when the ref is inside macros.

ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/index/SymbolCollector.cpp:280 (Roles & static_cast(index::SymbolRole::Reference)) && - SM.getFileID(SpellingLoc) == SM.getMainFileID()) + SM.getFileID(SM.getSpellingLoc(Loc)) ==

[PATCH] D70157: Align branches within 32-Byte boundary

annita.zhang added a comment. > The point is that we have explicit requirement at the start and we have a > lowering into 16-byte sequence that we need to be preserved exactly as it is. > Essentially what we need is a "protection" for this sequence from any > changes by machinery that

[PATCH] D71189: [Parser] Don't crash on MS assembly if target desc/asm parser isn't linked in.

This revision was automatically updated to reflect the committed changes. Closed by commit rG94603ec11b55: [Parser] Dont crash on MS assembly if target desc/asm parser isnt linked in. (authored by sammccall). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D71187: [clangd] Delete default arguments while moving functions out-of-line

kadircet added inline comments. Comment at: clang-tools-extra/clangd/refactor/tweaks/DefineOutline.cpp:186 +if (PVD->hasDefaultArg()) { + auto DelRange = CharSourceRange::getTokenRange(PVD->getDefaultArgRange()); + auto StartLoc = PVD->getLocation();

[PATCH] D71179: [OpenMP][WIP] Initial support for `begin/end declare variant`

hfinkel added a comment. In D71179#1774678 , @ABataev wrote: > In D71179#1774487 , @jdoerfert wrote: > > > In D71179#1774471 , @ABataev wrote: > > > > > They do this because

[PATCH] D71141: [Wdocumentation] Use C2x/C++14 deprecated attribute

gribozavr2 accepted this revision. gribozavr2 added a comment. LGTM with comments fixed. Comment at: clang/lib/AST/CommentSema.cpp:698 + // - In C2x/C++14 we prefer [[deprecated]] + // - If not found or an older C/C++ look for __attribute__((deprecated)) +

[clang-tools-extra] 771899e - [clangd] Allow extract-to-function on regions that always return.

Author: Sam McCall Date: 2019-12-09T14:57:49+01:00 New Revision: 771899e94452bbd5696abf8e2da7fee3514bb692 URL: https://github.com/llvm/llvm-project/commit/771899e94452bbd5696abf8e2da7fee3514bb692 DIFF: https://github.com/llvm/llvm-project/commit/771899e94452bbd5696abf8e2da7fee3514bb692.diff

[PATCH] D70569: [clangd] Allow extract-to-function on regions that always return.

This revision was automatically updated to reflect the committed changes. sammccall marked 3 inline comments as done. Closed by commit rG771899e94452: [clangd] Allow extract-to-function on regions that always return. (authored by sammccall). Changed prior to commit:

[PATCH] D71189: [Parser] Don't crash on MS assembly if target desc/asm parser isn't linked in.

merge_guards_bot added a comment. Build result: pass - 60607 tests passed, 0 failed and 726 were skipped. Log files: console-log.txt , CMakeCache.txt

[PATCH] D71198: [ARM][MVE][Intrinsics] Add VQADDQ, VHADDQ, VRHADDQ, VQSUBQ, VHSUBQ, VQDMULHQ, VQRDMULHQ intrinsics.

MarkMurrayARM created this revision. MarkMurrayARM added reviewers: simon_tatham, ostannard, dmgreen, miyuki. Herald added subscribers: llvm-commits, cfe-commits, hiraditya, kristof.beyls. Herald added projects: clang, LLVM. Add VQADDQ, VHADDQ, VRHADDQ, VQSUBQ, VHSUBQ, VQDMULHQ, VQRDMULHQ

[PATCH] D71199: [clang-tidy] New check readability-prefer-initialization-list

baloghadamsoftware created this revision. baloghadamsoftware added reviewers: alexfh, aaron.ballman. baloghadamsoftware added a project: clang-tools-extra. Herald added subscribers: mgehre, Szelethus, rnkovacs, xazax.hun, mgorny. Herald added a project: clang. Finds member initializations in the

[PATCH] D71190: [ARM][MVE] Add complex vector intrinsics

dmgreen added inline comments. Comment at: llvm/lib/Target/ARM/ARMISelDAGToDAG.cpp:2537 +/// Convert an SDValue to a boolean value. SDVal must be a compile-time constant +static bool SDValueToConstBool(SDValue SDVal) { + ConstantSDNode *SDValConstant = dyn_cast(SDVal);

[PATCH] D71188: [clangd] Delete ctor initializers while moving functions out-of-line

hokein added inline comments. Comment at: clang-tools-extra/clangd/refactor/tweaks/DefineOutline.cpp:269 + } + DeletionRange.setBegin(InitStart); +} There is an alternative here, I think. The end loc of `FunctionProtoTypeLoc` should point the

[PATCH] D62731: Add support for options -frounding-math, -ftrapping-math, -ffp-model=, and -ffp-exception-behavior=, : Specify floating point behavior

mibintc added a comment. In D62731#1773854 , @michele.scandale wrote: > I've noticed you removed the change for `CompilerInvocation.cpp` about the > initialization of the codegen option `NoTrappingMath`. Was that an accident? I checked the old and new

[PATCH] D71188: [clangd] Delete ctor initializers while moving functions out-of-line

merge_guards_bot added a comment. Build result: fail - 60625 tests passed, 1 failed and 726 were skipped. failed: LLVM.CodeGen/RISCV/mir-target-flags.ll Log files: console-log.txt , CMakeCache.txt

[PATCH] D71199: [clang-tidy] New check readability-prefer-initialization-list

Eugene.Zelenko added a comment. Clang-tidy also has //modernize-use-default-member-init//. Will be good idea to mention this check in documentation and otherwise as well as draw distinction (C++ version, coding guidelines, etc) in use cases. Comment at:

  1   2   3   >