[PATCH] D71422: [clangd] Introduce bulletlists

sammccall added inline comments. Comment at: clang-tools-extra/clangd/FormattedString.h:65 +/// Prints a list of documents while prepending "- " marker. Also indents the +/// documents. This is a class, not a function - comment should focus on what it *is*.

[PATCH] D71082: Allow system header to provide their own implementation of some builtin

serge-sans-paille updated this revision to Diff 233746. serge-sans-paille marked 6 inline comments as done. serge-sans-paille added a comment. Handle comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71082/new/

[PATCH] D71272: [OpenCL] Pretty print __private addr space

AlexeySotkin added inline comments. Comment at: clang/test/SemaOpenCL/access-qualifier.cl:28 kernel void k1(img1d_wo img) { - myRead(img); // expected-error {{passing 'img1d_wo' (aka '__write_only image1d_t') to parameter of incompatible type '__read_only image1d_t'}} +

[PATCH] D71345: [clangd] Fall back to selecting token-before-cursor if token-after-cursor fails.

sammccall added a comment. In D71345#1782647 , @nridge wrote: > Here, both navigations target the overloaded operator, but if you comment out > the overloaded operator, they target the respective local variable > declarations. I think this is pretty

[PATCH] D71455: [NFC] Fix typos in Clangd and Clang

kbobyrev created this revision. kbobyrev added a reviewer: sammccall. Herald added subscribers: usaxena95, kadircet, arphaman, jkorous, MaskRay, javed.absar, ilya-biryukov. https://reviews.llvm.org/D71455 Files: clang-tools-extra/clangd/AST.cpp clang-tools-extra/clangd/ClangdServer.cpp

[PATCH] D68261: [clangd] Add "inline" keyword to prevent ODR-violations in DefineInline

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 60834 tests passed, 0 failed and 726 were skipped. {icon times-circle color=red} clang-format: fail. Please format your changes with clang-format by running `git-clang-format HEAD^` or apply this patch

[PATCH] D71421: [ARM][MVE][Intrinsics] Add *_x() variants of my *_m() intrinsics.

simon_tatham accepted this revision. simon_tatham added a comment. This revision is now accepted and ready to land. LGTM. I must admit that I probably didn't manage to take in every single detail of the revised test collection, but the shape of it looks generally nice, and everything I

Re: [PATCH] D71439: Allow redeclaration of __declspec(uuid)

Same as my other pending patch. I'll need someone else to submit on my behalf since I don't have commit rights. @reid can that be you? Sent from my Palm III From: Reid Kleckner via Phabricator Sent: Thursday, December 12, 2019 6:29:57 PM To: Zachary Henkel ;

[PATCH] D71272: [OpenCL] Pretty print __private addr space

Anastasia marked an inline comment as done. Anastasia added inline comments. Comment at: clang/test/SemaOpenCL/access-qualifier.cl:28 kernel void k1(img1d_wo img) { - myRead(img); // expected-error {{passing 'img1d_wo' (aka '__write_only image1d_t') to parameter of

[PATCH] D71213: [Alignment][NFC] CreateMemSet use MaybeAlign

nhaehnle added a comment. In D71213#1781322 , @gchatelet wrote: > LLVM has this `LLVM_ATTRIBUTE_DEPRECATED` macro, it's convenient to get a > warning but it only works when building without `-Wall`. Did you mean to write _with_ -Wall? I fail to see

[PATCH] D71213: [Alignment][NFC] CreateMemSet use MaybeAlign

gchatelet added a comment. In D71213#1783467 , @nhaehnle wrote: > In D71213#1781322 , @gchatelet wrote: > > > LLVM has this `LLVM_ATTRIBUTE_DEPRECATED` macro, it's convenient to get a > > warning but it only works

[PATCH] D71345: [clangd] Fall back to selecting token-before-cursor if token-after-cursor fails.

kadircet added a comment. In D71345#1783579 , @nridge wrote: > (For completeness, there is a way to target `b` in `a+b+c`: by selecting `b` > (such that your selection range has length 1 rather than 0). Then, neither > `+` node will enclose the

[PATCH] D71345: [clangd] Fall back to selecting token-before-cursor if token-after-cursor fails.

sammccall added a comment. In D71345#1783579 , @nridge wrote: > In D71345#1783092 , @sammccall wrote: > > > (though personally I'd find it frustrating to have no way to target `b` in > > `a+b+c`). > > > (For

Re: [PATCH] D71466: [ARM][MVE][Intrinsics] remove extraneous intrinsics.

Hi I've committed a fix. M On 13/12/2019, 17:38, "Nico Weber via Phabricator" wrote: thakis added a comment. This breaks tests: http://45.33.8.238/mac/4132/step_7.txt Please take a look and revert if it takes a while to fix. Repository: rG LLVM

[PATCH] D71374: Improve support of GNU mempcpy

serge-sans-paille updated this revision to Diff 233797. serge-sans-paille added a comment. Added test cases Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71374/new/ https://reviews.llvm.org/D71374 Files: clang/include/clang/Basic/Builtins.def

[PATCH] D71345: [clangd] Fall back to selecting token-before-cursor if token-after-cursor fails.

sammccall marked an inline comment as done. sammccall added a comment. OK, I'm going to land this with some reservations. It's a mess, but the number of callsites isn't overwhelming. I'd been hoping to get away with bias-right, but we keep getting complaints about this. It's hard to find an

[PATCH] D71345: [clangd] Fall back to selecting token-before-cursor if token-after-cursor fails.

This revision was automatically updated to reflect the committed changes. Closed by commit rGb60896fad926: [clangd] Fall back to selecting token-before-cursor if token-after-cursor fails. (authored by sammccall). Changed prior to commit: https://reviews.llvm.org/D71345?vs=233804=233805#toc

[clang] 22f8125 - [Tooling/Syntax] Helpers to find spelled tokens touching a location.

Author: Sam McCall Date: 2019-12-13T16:57:03+01:00 New Revision: 22f81250889b2e366187ee1465ba0ec71a6e457d URL: https://github.com/llvm/llvm-project/commit/22f81250889b2e366187ee1465ba0ec71a6e457d DIFF: https://github.com/llvm/llvm-project/commit/22f81250889b2e366187ee1465ba0ec71a6e457d.diff

[PATCH] D71436: [X86][AsmParser] re-introduce 'offset' operator

epastor updated this revision to Diff 233806. epastor added a comment. - Fix Intel named operator parsing Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71436/new/ https://reviews.llvm.org/D71436 Files: clang/test/CodeGen/ms-inline-asm.c

[PATCH] D71436: [X86][AsmParser] re-introduce 'offset' operator

merge_guards_bot added a comment. {icon times-circle color=red} Unit tests: fail. 60824 tests passed, 4 failed and 726 were skipped. failed: Clang.CodeGen/ms-inline-asm-64.c failed: Clang.CodeGen/ms-inline-asm.c failed: Clang.SemaTemplate/instantiation-depth-default.cpp failed:

[PATCH] D71476: [OpenCL] Add builtin function extension handling

svenvh created this revision. svenvh added reviewers: Anastasia, Nicola. Herald added subscribers: jfb, yaxunl. Herald added a reviewer: rengolin. Provide a mechanism to attach OpenCL extension information to builtin functions, so that their use can be restricted according to the extension(s) the

[clang] 0eb0992 - [ARM][MVE][Intrinsics] remove extraneous intrinsics.

Author: Mark Murray Date: 2019-12-13T15:51:31Z New Revision: 0eb0992739189dba0d86af33722bc27260a9b555 URL: https://github.com/llvm/llvm-project/commit/0eb0992739189dba0d86af33722bc27260a9b555 DIFF: https://github.com/llvm/llvm-project/commit/0eb0992739189dba0d86af33722bc27260a9b555.diff LOG:

[PATCH] D71469: [AArch64] Add sq(r)dmulh_lane(q) LLVM IR intrinsics

sanwou01 created this revision. Herald added subscribers: llvm-commits, cfe-commits, jdoerfert, hiraditya, kristof.beyls. Herald added projects: clang, LLVM. sanwou01 added reviewers: SjoerdMeijer, dmgreen, t.p.northover. Currently, sqdmulh_lane and friends from the ACLE (implemented in

[PATCH] D67661: [RISCV] Headers: Add Bitmanip extension Clang header files and rvintrin.h

s.egerton planned changes to this revision. s.egerton added a comment. In D67661#1767141 , @lewis-revill wrote: > So I have a quick comment about this patch, perhaps it might help to get > things moving again. > > I'd like to see the actual frontend

[PATCH] D71463: Implement VectorType conditional operator GNU extension.

erichkeane created this revision. erichkeane added reviewers: eli.friedman, aaron.ballman, echristo, rjmccall. Herald added a subscriber: Anastasia. Herald added a project: clang. erichkeane added a comment. Sorry in advance for the reviewer choices... Blame got me you all for all touching these

[PATCH] D71241: [OpenMP][WIP] Use overload centric declare variants

hfinkel added a comment. In D71241#1783444 , @ABataev wrote: > In D71241#1782586 , @hfinkel wrote: > > > In D71241#1782460 , > > @JonChesterfield wrote: > > > > > >

[PATCH] D71016: [SYCL] Implement OpenCL kernel function generation

Fznamznon marked an inline comment as done. Fznamznon added inline comments. Comment at: clang/lib/Sema/SemaSYCL.cpp:417 + Util::DeclContextDesc{clang::Decl::Kind::ClassTemplateSpecialization, +"accessor"}}; + return matchQualifiedTypeName(Ty,

[PATCH] D71463: Implement VectorType conditional operator GNU extension.

erichkeane added a comment. Sorry in advance for the reviewer choices... Blame got me you all for all touching these things in the early 2010s. Since then, Richard and I seem to be the only one to have touched these types. Repository: rC Clang CHANGES SINCE LAST ACTION

Re: [PATCH] D71466: [ARM][MVE][Intrinsics] remove extraneous intrinsics.

Hi Sorry about the breakage; a commit crossed my build/check/push run, and I was testing a fix when your revert came. M On 13/12/2019, 16:24, "Dmitri Gribenko via Phabricator" wrote: gribozavr2 added a comment. I reverted this change in 34536db7bbe0b8c5f8ffa70df307312b451aca2e

[clang] 9757277 - Reland [DataLayout] Fix occurrences that size and range of pointers are assumed to be the same.

Author: Nicola Zaghen Date: 2019-12-13T14:30:21Z New Revision: 97572775d2fe088d8059b3a9423f6d8539fafe33 URL: https://github.com/llvm/llvm-project/commit/97572775d2fe088d8059b3a9423f6d8539fafe33 DIFF: https://github.com/llvm/llvm-project/commit/97572775d2fe088d8059b3a9423f6d8539fafe33.diff

[PATCH] D71241: [OpenMP][WIP] Use overload centric declare variants

ABataev added a comment. In D71241#1783499 , @hfinkel wrote: > In D71241#1783444 , @ABataev wrote: > > > In D71241#1782586 , @hfinkel wrote: > > > > > In D71241#1782460

[PATCH] D71345: [clangd] Fall back to selecting token-before-cursor if token-after-cursor fails.

nridge added a comment. In D71345#1783092 , @sammccall wrote: > (though personally I'd find it frustrating to have no way to target `b` in > `a+b+c`). (For completeness, there is a way to target `b` in `a+b+c`: by selecting `b` (such that your

[clang-tools-extra] b60896f - [clangd] Fall back to selecting token-before-cursor if token-after-cursor fails.

Author: Sam McCall Date: 2019-12-13T16:57:03+01:00 New Revision: b60896fad926754f715acc5d771555577e0f URL: https://github.com/llvm/llvm-project/commit/b60896fad926754f715acc5d771555577e0f DIFF: https://github.com/llvm/llvm-project/commit/b60896fad926754f715acc5d771555577e0f.diff

[PATCH] D71345: [clangd] Fall back to selecting token-before-cursor if token-after-cursor fails.

sammccall updated this revision to Diff 233804. sammccall added a comment. Bias selection-tree right for Hover. In VSCode (and presumably other GUI-based editors) the location sent is always the one on the left of the character under the cursor. Clang-format. Repository: rG LLVM Github

[PATCH] D71466: [ARM][MVE][Intrinsics] remove extraneous intrinsics.

This revision was automatically updated to reflect the committed changes. Closed by commit rG0eb099273918: [ARM][MVE][Intrinsics] remove extraneous intrinsics. (authored by MarkMurrayARM). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71466/new/

[PATCH] D71345: [clangd] Fall back to selecting token-before-cursor if token-after-cursor fails.

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 60850 tests passed, 0 failed and 726 were skipped. {icon check-circle color=green} clang-format: pass. Build artifacts : console-log.txt

[PATCH] D71345: [clangd] Fall back to selecting token-before-cursor if token-after-cursor fails.

nridge added a comment. In D71345#1783587 , @sammccall wrote: > Indeed, sorry - I meant that if we incorporated it into an LSP server, > there'd be no way to target it in methods that take a position rather than a > selection (go to defn, hover etc).

[PATCH] D71466: [ARM][MVE][Intrinsics] remove extraneous intrinsics.

gribozavr2 added a comment. I reverted this change in 34536db7bbe0b8c5f8ffa70df307312b451aca2e . This change didn't compile: http://lab.llvm.org:8011/builders/clang-x86_64-debian-fast/builds/20462. Please always run `ninja

[PATCH] D68362: [libunwind][RISCV] Add 64-bit RISC-V support

lenary accepted this revision. lenary added a comment. LGTM! Thanks for correcting the preprocessor issues! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68362/new/ https://reviews.llvm.org/D68362 ___ cfe-commits mailing list

[PATCH] D71475: [WIP][OPENMP] Try to fix linear clause crash by emitting alloca for step

cchen created this revision. cchen added a reviewer: ABataev. Herald added subscribers: cfe-commits, guansong. Herald added a reviewer: jdoerfert. Herald added a project: clang. For this example: int a[100]; int f2 (int i, int k) { for (int j = 16; j < 64; j++) {

[PATCH] D71466: [ARM][MVE][Intrinsics] remove extraneous intrinsics.

thakis added a comment. This breaks tests: http://45.33.8.238/mac/4132/step_7.txt Please take a look and revert if it takes a while to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71466/new/ https://reviews.llvm.org/D71466

[PATCH] D71466: [ARM][MVE][Intrinsics] remove extraneous intrinsics.

MarkMurrayARM created this revision. MarkMurrayARM added a reviewer: simon_tatham. Herald added subscribers: cfe-commits, dmgreen, kristof.beyls. Herald added a project: clang. I overstepped my reach and generated too many intrinsics; these never made it into the tests. Remove these extras. Some

[PATCH] D71467: [FPEnv] Generate constrained FP comparisons from clang

uweigand created this revision. uweigand added reviewers: kpn, andrew.w.kaylor, craig.topper, cameron.mcinally, RKSimon, spatel, rjmccall, rsmith. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Update the IRBuilder to generate constrained FP comparisons

[PATCH] D71241: [OpenMP][WIP] Use overload centric declare variants

JonChesterfield added a comment. Has anyone actually asked Richard to look at this? He isn't subscribed to the diff and may not be watching openmp-dev. I don't think it's reasonable to stall progress on optimising openmp indefinitely. Richard may find it difficult to find time to resolve this.

[clang] 34536db - Revert "[ARM][MVE][Intrinsics] remove extraneous intrinsics."

Author: Dmitri Gribenko Date: 2019-12-13T17:16:13+01:00 New Revision: 34536db7bbe0b8c5f8ffa70df307312b451aca2e URL: https://github.com/llvm/llvm-project/commit/34536db7bbe0b8c5f8ffa70df307312b451aca2e DIFF:

[PATCH] D64573: [Syntax] Allow to mutate syntax trees

gribozavr2 accepted this revision. gribozavr2 added a comment. This revision is now accepted and ready to land. Generally looks good, just nitpicks. Comment at: clang/include/clang/Tooling/Syntax/BuildTree.h:24 const

[PATCH] D71436: [X86][AsmParser] re-introduce 'offset' operator

epastor updated this revision to Diff 233813. epastor added a comment. - Respect correct usage of offset. - Don't assume implicit sizing on offset. - Check that offset works in compound expressions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D71436: [X86][AsmParser] re-introduce 'offset' operator

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 60854 tests passed, 0 failed and 726 were skipped. {icon times-circle color=red} clang-format: fail. Please format your changes with clang-format by running `git-clang-format HEAD^` or apply this patch

[PATCH] D71241: [OpenMP][WIP] Use overload centric declare variants

jdoerfert added a comment. In D71241#1783362 , @ABataev wrote: > >>> - Take https://godbolt.org/z/2evvtN which shows that the alias solution > >>> is incompatible with linking. > >> > >> Undefined behavior according to the standard. > > > > I don't

[clang] a2cd460 - [ARM][MVE][Intrinsics] All vqdmulhq/vqrdmulhq tests should be for signed numbers.

Author: Mark Murray Date: 2019-12-13T17:29:59Z New Revision: a2cd4600ec6710f3218f071128e2a81edd23a2b2 URL: https://github.com/llvm/llvm-project/commit/a2cd4600ec6710f3218f071128e2a81edd23a2b2 DIFF: https://github.com/llvm/llvm-project/commit/a2cd4600ec6710f3218f071128e2a81edd23a2b2.diff LOG:

[PATCH] D68261: [clangd] Add "inline" keyword to prevent ODR-violations in DefineInline

kadircet added inline comments. Comment at: clang-tools-extra/clangd/unittests/TweakTests.cpp:1913 + + // Specializations needs to be marked "inline". + ExtraFiles["a.h"] = R"cpp( hokein wrote: > could you add a test case for partial template specializations?

[PATCH] D68261: [clangd] Add "inline" keyword to prevent ODR-violations in DefineInline

This revision was automatically updated to reflect the committed changes. Closed by commit rG087528a33178: [clangd] Add inline keyword to prevent ODR-violations in DefineInline (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D68261: [clangd] Add "inline" keyword to prevent ODR-violations in DefineInline

kadircet updated this revision to Diff 233751. kadircet marked 3 inline comments as done. kadircet added a comment. - Address comments and rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68261/new/ https://reviews.llvm.org/D68261 Files:

[clang-tools-extra] 087528a - [clangd] Add "inline" keyword to prevent ODR-violations in DefineInline

Author: Kadir Cetinkaya Date: 2019-12-13T10:07:18+01:00 New Revision: 087528a331786228221d7a56a51ab97a3fcac8f1 URL: https://github.com/llvm/llvm-project/commit/087528a331786228221d7a56a51ab97a3fcac8f1 DIFF:

[PATCH] D71414: [clangd] Introduce codeblocks

This revision was automatically updated to reflect the committed changes. Closed by commit rG7c13fe8a6a64: [clangd] Introduce codeblocks (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71414/new/

[PATCH] D71201: [ObjC][DWARF] Emit DW_AT_APPLE_objc_direct for methods marked as __attribute__((objc_direct))

teemperor updated this revision to Diff 233756. teemperor added a comment. - Removed Objective-C metadata from LLVM test. - Removed quoted attributes. - Update DebugInfoFlags.def to be compatible with D68117 assuming probinson are applied there. CHANGES SINCE

[PATCH] D71374: Improve support of GNU mempcpy

serge-sans-paille added a comment. In D71374#1783032 , @Jim wrote: > I am curious what is difference of code generation after applying your > changes? Before, when compiling #define _GNU_SOURCE #include void* foo(void* to, void* from,

[PATCH] D71460: [OpenCL] Fix support for cl_khr_mipmap_image_writes

asavonic added a comment. What about `get_image_num_mip_levels` functions defined in the extension specification? Comment at: clang/lib/Headers/opencl-c.h:14780 void __ovld write_imagef(read_write image2d_depth_t image, int2 coord, int lod, float color); void __ovld

[PATCH] D71374: Improve support of GNU mempcpy

xbolva00 added a comment. > @xbolva00 should I remove the lowering part and leave it to llvm? Probably okay to leave it + inbounds, but please add a test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71374/new/ https://reviews.llvm.org/D71374

[PATCH] D71082: Allow system header to provide their own implementation of some builtin

serge-sans-paille updated this revision to Diff 233753. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71082/new/ https://reviews.llvm.org/D71082 Files: clang/include/clang/AST/Decl.h clang/lib/AST/Decl.cpp clang/lib/CodeGen/CGExpr.cpp

[PATCH] D71458: [ARM][MVE] Add intrinsics for more immediate shifts.

simon_tatham created this revision. simon_tatham added reviewers: dmgreen, MarkMurrayARM, miyuki, ostannard. Herald added subscribers: llvm-commits, cfe-commits, hiraditya, kristof.beyls. Herald added projects: clang, LLVM. This fills in the remaining shift operations that take a single vector

[PATCH] D71062: [ARM][MVE] Add vector reduction intrinsics with two vector operands

MarkMurrayARM accepted this revision. MarkMurrayARM added a comment. Tiny observation of types - fix only if you feel like it. Comment at: clang/include/clang/Basic/arm_mve.td:845 + +let params = [s16, s32] in { +defm vmlaldav : MVEBinaryVectorHoriz64; Types

[clang-tools-extra] 7c13fe8 - [clangd] Introduce codeblocks

Author: Kadir Cetinkaya Date: 2019-12-13T09:58:55+01:00 New Revision: 7c13fe8a6a643497d49036e6ea368e1adb06f57e URL: https://github.com/llvm/llvm-project/commit/7c13fe8a6a643497d49036e6ea368e1adb06f57e DIFF:

[clang-tools-extra] 597c6b6 - [clangd] Introduce paragraph, the first part of new rendering structs

Author: Kadir Cetinkaya Date: 2019-12-13T09:58:55+01:00 New Revision: 597c6b65552a777a40f2afed07c543f6789318b1 URL: https://github.com/llvm/llvm-project/commit/597c6b65552a777a40f2afed07c543f6789318b1 DIFF:

[clang-tools-extra] 6b8ff5e - [clangd] Fix windows builds

Author: Kadir Cetinkaya Date: 2019-12-13T10:30:44+01:00 New Revision: 6b8ff5e43b405d255259196b6a53a3b5671aa5c7 URL: https://github.com/llvm/llvm-project/commit/6b8ff5e43b405d255259196b6a53a3b5671aa5c7 DIFF:

[PATCH] D70048: [LLD] Add NetBSD support as a new flavor of LLD (nb.lld)

krytarowski added a comment. We attempted to patch internally LLD rebasing our code for the buildbot purposes but LLD without being used rots quickly, see: https://reviews.llvm.org/D58892 We use LD as `ld` and there are no plans neither intentions to break it. It was already decided

[PATCH] D71458: [ARM][MVE] Add intrinsics for more immediate shifts.

simon_tatham marked an inline comment as done. simon_tatham added inline comments. Comment at: llvm/lib/Target/ARM/ARMInstrMVE.td:2399 + foreach pred_int = [int_arm_mve_vshll_imm_predicated] in + foreach imm = [inst_imm.immediateType] in { + MarkMurrayARM

[PATCH] D71458: [ARM][MVE] Add intrinsics for more immediate shifts.

MarkMurrayARM accepted this revision. MarkMurrayARM added a comment. This revision is now accepted and ready to land. LGTM Comment at: llvm/lib/Target/ARM/ARMInstrMVE.td:2399 + foreach pred_int = [int_arm_mve_vshll_imm_predicated] in + foreach imm = [inst_imm.immediateType]

[PATCH] D71374: Improve support of GNU mempcpy

serge-sans-paille added a comment. [[edited the example to reflect actual state]] Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71374/new/ https://reviews.llvm.org/D71374 ___ cfe-commits mailing list

[PATCH] D70524: Support DebugInfo generation for auto return type for C++ functions.

probinson added a comment. > Hmm, maybe this feature/suggestion is broken or at least not exactly awesome > when it comes to auto-returning functions that are eventually void-returning > functions? Now the function definition has no DW_AT_type to override the > unspecified_type in the

[PATCH] D71241: [OpenMP][WIP] Use overload centric declare variants

ABataev added a comment. In D71241#1782963 , @jdoerfert wrote: > In D71241#1782668 , @ABataev wrote: > > > In D71241#1782650 , @jdoerfert > > wrote: > > > > > While we talk

[clang] 25305a9 - [ARM][MVE] Add intrinsics for more immediate shifts.

Author: Simon Tatham Date: 2019-12-13T13:07:39Z New Revision: 25305a9311d45bc602014b7ee7584e80675aaf59 URL: https://github.com/llvm/llvm-project/commit/25305a9311d45bc602014b7ee7584e80675aaf59 DIFF: https://github.com/llvm/llvm-project/commit/25305a9311d45bc602014b7ee7584e80675aaf59.diff LOG:

[PATCH] D71167: [Driver] Default to -momit-leaf-frame-pointer for AArch64

sdesmalen added a comment. The patch looks structurally fine, but I'm missing the argumentation for changing the default and related, the history of why the default is to //not// omit the frame pointer on leaf functions. Can you provide some insight here? Repository: rG LLVM Github Monorepo

[PATCH] D71458: [ARM][MVE] Add intrinsics for more immediate shifts.

simon_tatham marked an inline comment as done. simon_tatham added inline comments. Comment at: llvm/lib/Target/ARM/ARMInstrMVE.td:2399 + foreach pred_int = [int_arm_mve_vshll_imm_predicated] in + foreach imm = [inst_imm.immediateType] in { + simon_tatham

[PATCH] D70537: [clang] CGDebugInfo asserts `!DT.isNull()` when compiling with debug symbols

kamleshbhalui added a comment. In D70537#1769458 , @dblaikie wrote: > I feel like there's something missing about this bug/issue - is there a good > explanation/understanding for why does the bug only occur with the two levels > of static member inline

[PATCH] D71374: Improve support of GNU mempcpy

xbolva00 added a comment. LLVM already converts mempcpy to memcpy.. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71374/new/ https://reviews.llvm.org/D71374 ___ cfe-commits mailing list

[PATCH] D71062: [ARM][MVE] Add vector reduction intrinsics with two vector operands

miyuki marked an inline comment as done. miyuki added inline comments. Comment at: clang/include/clang/Basic/arm_mve.td:845 + +let params = [s16, s32] in { +defm vmlaldav : MVEBinaryVectorHoriz64; MarkMurrayARM wrote: > Types again? I don't it's worth adding a

[PATCH] D71436: [X86][AsmParser] re-introduce 'offset' operator

epastor updated this revision to Diff 233786. epastor added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. - Fix tests expecting use of 'r' constraints for offset operands Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D71241: [OpenMP][WIP] Use overload centric declare variants

ABataev added a comment. In D71241#1782586 , @hfinkel wrote: > In D71241#1782460 , @JonChesterfield > wrote: > > > > https://clang.llvm.org/docs/InternalsManual.html#the-ast-library > > > > > > Faithfulness¶ >

[PATCH] D71345: [clangd] Fall back to selecting token-before-cursor if token-after-cursor fails.

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. tl;dr; LGTM, from my side as long as you are also happy with the extra complexity introduced by this to all call sites. As told in the offline discussions, only problem I have with this

[PATCH] D71248: [clangd] Introduce paragraph, the first part of new rendering structs

This revision was automatically updated to reflect the committed changes. Closed by commit rG597c6b65552a: [clangd] Introduce paragraph, the first part of new rendering structs (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D71460: [OpenCL] Fix support for cl_khr_mipmap_image_writes

AlexeySotkin created this revision. AlexeySotkin added reviewers: Anastasia, svenvh, yaxunl, asavonic. Herald added a project: clang. Herald added a subscriber: cfe-commits. Patch by Ilya Mashkov Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D71460 Files:

[PATCH] D71374: Improve support of GNU mempcpy

serge-sans-paille added a comment. In D71374#1783245 , @xbolva00 wrote: > LLVM already converts mempcpy to memcpy.. Indeed, the clang version I was using as base reference was clang-9, and the mempcpy optimisation at IR level got introduced after that.

[PATCH] D71111: [Sema] Improve diagnostic about addr spaces for overload candidates

This revision was automatically updated to reflect the committed changes. Closed by commit rGed8dadb37c7e: [Sema] Improve diagnostic about addr spaces for overload candidates (authored by Anastasia). Herald added a project: clang. Changed prior to commit:

[clang] ed8dadb - [Sema] Improve diagnostic about addr spaces for overload candidates

Author: Anastasia Stulova Date: 2019-12-13T12:35:18Z New Revision: ed8dadb37c7e1a7f4889d868ac9b19bfe7762237 URL: https://github.com/llvm/llvm-project/commit/ed8dadb37c7e1a7f4889d868ac9b19bfe7762237 DIFF: https://github.com/llvm/llvm-project/commit/ed8dadb37c7e1a7f4889d868ac9b19bfe7762237.diff

[PATCH] D71433: [analyzer] CERT: POS34-C

Charusso added a reviewer: aaron.ballman. Charusso added a subscriber: aaron.ballman. Charusso added inline comments. Comment at: clang/docs/analyzer/checkers.rst:1881 + + #include + I would remove that line. Comment at:

[PATCH] D71458: [ARM][MVE] Add intrinsics for more immediate shifts.

This revision was automatically updated to reflect the committed changes. Closed by commit rG25305a9311d4: [ARM][MVE] Add intrinsics for more immediate shifts. (authored by simon_tatham). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71458/new/

[PATCH] D71039: Add support for the MS qualifiers __ptr32, __ptr64, __sptr, __uptr.

aaron.ballman added a comment. Can you also add documentation to the attribute in AttrDocs.td and hook it up to the attribute in Attr.td now that we're actually processing these attributes rather than ignoring them? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D71272: [OpenCL] Pretty print __private addr space

AlexeySotkin added inline comments. Comment at: clang/test/SemaOpenCL/access-qualifier.cl:28 kernel void k1(img1d_wo img) { - myRead(img); // expected-error {{passing 'img1d_wo' (aka '__write_only image1d_t') to parameter of incompatible type '__read_only image1d_t'}} +

[PATCH] D71485: [profile] Fix a crash when -fprofile-remapping-file= triggers an error

This revision was automatically updated to reflect the committed changes. Closed by commit rG193da743db63: [profile] Fix a crash when -fprofile-remapping-file= triggers an error (authored by MaskRay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D71485: [profile] Fix a crash when -fprofile-remapping-file= triggers an error

MaskRay updated this revision to Diff 233843. MaskRay added a comment. Delete unused declaration Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71485/new/ https://reviews.llvm.org/D71485 Files:

[PATCH] D71486: [clang-tools-extra] Fix switch coverage warning

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 60867 tests passed, 0 failed and 726 were skipped. {icon check-circle color=green} clang-format: pass. Build artifacts : console-log.txt

[PATCH] D71431: Call objc_retainBlock before passing a block as a variadic argument

ahatanak updated this revision to Diff 233851. ahatanak added a comment. Explain why this change is needed in ARC documentation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71431/new/ https://reviews.llvm.org/D71431 Files:

[PATCH] D71486: [clang-tools-extra] Fix switch coverage warning

sammccall added a comment. It should be possible to test this by adapting a test case from the original ed8dadb , but I'm not certain... Comment at:

[PATCH] D71486: [clang-tools-extra] Fix switch coverage warning

merge_guards_bot added a comment. {icon check-circle color=green} clang-format: pass. Build artifacts : console-log.txt , diff.json

[PATCH] D70919: [Hexagon] Avoid passing unsupported options to lld when -fuse-ld=lld is used

sidneym updated this revision to Diff 233864. sidneym added a comment. OK, Yes Fuchsia is a good example. Using that pattern Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70919/new/ https://reviews.llvm.org/D70919 Files:

[PATCH] D71082: Allow system header to provide their own implementation of some builtin

serge-sans-paille marked an inline comment as done. serge-sans-paille added inline comments. Comment at: clang/lib/AST/Decl.cpp:3019 +if (SL.isValid()) + return SM.isInSystemHeader(SL); + } efriedma wrote: > I'm a little concerned about this; we're

[PATCH] D71475: [WIP][OPENMP] Try to fix linear clause crash by emitting alloca for step

cchen updated this revision to Diff 233866. cchen added a comment. Add linear step var into Implicitfirstprivate Doing this still fail the assertion since we still don't have the variable inside CapturedStmt. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D71167: [Driver] Default to -momit-leaf-frame-pointer for AArch64

MaskRay added a comment. (I got confused over the last weekend.) @efriedma We still need this driver change, otherwise D71168 will cause a functional difference when neither -m(no-)omit-leaf-frame-pointer is specified. https://godbolt.org/z/653p3q

[PATCH] D70919: [Hexagon] Avoid passing unsupported options to lld when -fuse-ld=lld is used

bcain added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70919/new/ https://reviews.llvm.org/D70919 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

  1   2   >